Convert the Renesas R-Car DWC HDMI TX text binding to YAML.
Signed-off-by: Laurent Pinchart
---
Changes since v2:
- Update MAINTAINERS
Changes since v1:
- Drop the part numbers in comments, only keep the SoC names
- Use unevaluatedProperties instead of additionalProperties
- Only specify
Convert the i.MX6 HDMI TX text binding to YAML.
Signed-off-by: Laurent Pinchart
---
Changes since v1:
- Only specify maxItems for clocks
- Drop reg and interrupts as they're checked in the base schema
- Rebase on top of OF graph schema, dropped redundant properties
- Fix identation for
Replace the reference to the DWC HDMI text DT binding with a reference
to the YAML equivalent.
Signed-off-by: Laurent Pinchart
Acked-by: Rob Herring
Acked-by: Chen-Yu Tsai
---
.../bindings/display/allwinner,sun8i-a83t-dw-hdmi.yaml| 4 ++--
1 file changed, 2 insertions(+), 2 deletions
Convert the Rockchip HDMI TX text binding to YAML.
Signed-off-by: Laurent Pinchart
---
Changes since v2:
- Use Mark's @gmail.com e-mail address as the @rock-chips.com address
bounces
Changes since v1:
- Drop pinctrl-0 and pinctrl-1
- Use unevaluatedProperties instead of additionalPrope
dw_hdmi.txt has been replaced with synopsys,dw-hdmi.yaml, and all
references to the old file have been converted. Remove it.
Signed-off-by: Laurent Pinchart
Acked-by: Rob Herring
---
.../bindings/display/bridge/dw_hdmi.txt | 33 ---
1 file changed, 33 deletions(-)
delete
On Tue, Jan 05, 2021 at 08:08:13AM +0200, Laurent Pinchart wrote:
> Add a .yaml schema containing the common properties for the Synopsys
> DesignWare HDMI TX controller. This isn't a full device tree binding
> specification, but is meant to be referenced by platform-specific
> bi
Hi Philipp,
On Tue, Jan 05, 2021 at 10:32:01AM +0100, Philipp Zabel wrote:
> On Tue, 2021-01-05 at 07:49 +0200, Laurent Pinchart wrote:
> > On Mon, Jan 04, 2021 at 04:30:36PM +0100, Philipp Zabel wrote:
> > > On Sun, 2020-12-20 at 21:50 +0200, Laurent Pinchart wrote:
> &g
Hi Philipp,
On Wed, Jan 06, 2021 at 03:10:32PM +0100, Philipp Zabel wrote:
> On Tue, 2021-01-05 at 13:50 +0200, Laurent Pinchart wrote:
> > On Tue, Jan 05, 2021 at 10:32:01AM +0100, Philipp Zabel wrote:
> > > On Tue, 2021-01-05 at 07:49 +0200, Laurent Pinchart wrote:
> >
Hi Rob,
Given that the maintainers property is mandatory in the schema, what's
the procedure when no maintainer steps up for a converter YAML binding ?
On Tue, Jan 05, 2021 at 08:08:16AM +0200, Laurent Pinchart wrote:
> Convert the Rockchip HDMI TX text binding to YAML.
>
>
inal Message-
> > > > From: Laurent Pinchart
> > > > Sent: Tuesday, December 15, 2020 9:15 PM
> > > > To: Koenig, Christian
> > > > Cc: Daniel Vetter ; Laurent Pinchart
> > > > ; dri-
> > > > de...@lists.freedesktop.org; Dave A
Hi Rob,
On Mon, Jan 11, 2021 at 05:01:36PM -0600, Rob Herring wrote:
> On Wed, Jan 06, 2021 at 05:17:55PM +0200, Laurent Pinchart wrote:
> > Hi Rob,
> >
> > Given that the maintainers property is mandatory in the schema, what's
> > the procedure when no maintain
le class of bugs by turning
NSEC_PER_SEC into a ULL, but I suppose there are valid cases where a
32-bit integer is enough.
Reviewed-by: Laurent Pinchart
How did you come across this by the way ?
> }
>
> /*
--
Regards,
Laurent Pinchart
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Hi Rob,
On Mon, Jan 11, 2021 at 05:12:58PM -0600, Rob Herring wrote:
> On Tue, Jan 05, 2021 at 08:08:16AM +0200, Laurent Pinchart wrote:
> > Convert the Rockchip HDMI TX text binding to YAML.
> >
> > Signed-off-by: Laurent Pinchart
> > ---
> > Changes since v2:
ver provides display overlays
> to V4L. I guess on omapdrm V4L can use DRM planes instead and no
> driver is needed (i.e. this driver could just go away with omapfb)?
One feature that the omapfb2 and the omap-vout drivers provide is
rotation support with VRFB on OMAP3. I haven't moved to omapdrm on an
old project for this reason. It should be possible to implement rotation
support in omapdrm, but I'm not aware of any effort in that direction.
--
Regards,
Laurent Pinchart
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
"drm: rcar-du: Use DRM-managed allocation for encoders")
We could equally point to the patch that has added drmm_encoder_alloc(),
but I'm fine taking the blame :-)
Reviewed-by: Laurent Pinchart
> Reported-by: Geert Uytterhoeven
> Signed-off-by: Kieran Bingham
>
RCH_RENESAS
>
> drivers/gpu/drm/rcar-du/Kconfig | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
--
Regards,
Laurent Pinchart
mp;& OF && DRM_RCAR_DU
Shouldn't the same be done for DRM_RCAR_DW_HDMI ? Even better, we could
wrap all the entries for the subdrivers in a 'if DRM_RCAR_DU'.
> default DRM_RCAR_DU
> help
> Enable support for the R-Car Display Unit embedded LVDS encoders.
--
Regards,
Laurent Pinchart
Hi Geert,
On Wed, Dec 15, 2021 at 11:17:37AM +0100, Geert Uytterhoeven wrote:
> On Wed, Dec 15, 2021 at 11:12 AM Laurent Pinchart wrote:
> > On Wed, Dec 15, 2021 at 10:27:46AM +0100, Geert Uytterhoeven wrote:
> > > The Renesas R-Car LVDS encoder driver is a subdriver of the R
W_HDMI
> tristate "R-Car Gen3 and RZ/G2 DU HDMI Encoder Support"
> depends on DRM && OF
> + depends on ARCH_RENESAS || COMPILE_TEST
Let's move this entry first to keep alphabetical order.
Reviewed-by: Laurent Pinchart
> select DRM_DW_HDMI
&
state "R-Car DU MIPI DSI Encoder Support"
> depends on DRM && DRM_BRIDGE && OF
> + depends on ARCH_RENESAS || COMPILE_TEST
Same as for 1/3, let's move this entry first. I can handle this when
applying the patches, I'll take 1/3 and 3/3 in m
On Wed, Dec 15, 2021 at 12:25:26PM +0200, Laurent Pinchart wrote:
> Hi Geert,
>
> Thank you for the patch.
>
> On Wed, Dec 15, 2021 at 10:27:47AM +0100, Geert Uytterhoeven wrote:
> > The Renesas R-Car Display Unit embedded MIPI DSI encoder is only present
> > on Ren
Hi Geert,
On Wed, Dec 15, 2021 at 12:23:39PM +0200, Laurent Pinchart wrote:
> On Wed, Dec 15, 2021 at 11:17:37AM +0100, Geert Uytterhoeven wrote:
> > On Wed, Dec 15, 2021 at 11:12 AM Laurent Pinchart wrote:
> > > On Wed, Dec 15, 2021 at 10:27:46AM +0100, Geert Uytterhoeven
Hi Geert,
On Wed, Dec 15, 2021 at 11:47:27AM +0100, Geert Uytterhoeven wrote:
> On Wed, Dec 15, 2021 at 11:30 AM Laurent Pinchart wrote:
> > On Wed, Dec 15, 2021 at 12:23:39PM +0200, Laurent Pinchart wrote:
> > > On Wed, Dec 15, 2021 at 11:17:37AM +0100, Geert Uytterhoeven wro
| 3 +++
> drivers/gpu/drm/tiny/st7586.c | 3 +++
> drivers/gpu/drm/tiny/st7735r.c | 3 +++
> drivers/gpu/drm/tve200/tve200_drv.c | 3 +++
> drivers/gpu/drm/udl/udl_drv.c | 3 +++
> drivers/gpu/drm/via/via_drv.c | 3 +++
> drivers/gpu/drm/xen/xen_drm_front.c | 3 +++
> drivers/gpu/drm/xlnx/zynqmp_dpsub.c | 3 +++
> 60 files changed, 181 insertions(+)
--
Regards,
Laurent Pinchart
Hi Javier,
On Thu, Dec 16, 2021 at 01:13:56AM +0100, Javier Martinez Canillas wrote:
> Hello Laurent,
>
> On 12/16/21 00:35, Laurent Pinchart wrote:
>
> [snip]
>
> >>
> >> I've built tested with 'make allmodconfig && make M=drivers/gpu
a rule to disallow jeida-24 and vesa-24 when the compatible
string contains ti,ds90cf384a, but that may be overkill.
Reviewed-by: Laurent Pinchart
> Signed-off-by: Marek Vasut
> Cc: Laurent Pinchart
> Cc: Rob Herring
> Cc: Sam Ravnborg
> Cc: devicet...@vger.ke
@ -691,6 +693,8 @@ static int sn65dsi83_probe(struct i2c_client *client,
>
> err_remove_bridge:
> drm_bridge_remove(&ctx->bridge);
> +err_put_node:
> + of_node_put(ctx->host_node);
> return ret;
> }
>
--
Regards,
Laurent Pinchart
nly done in the remove function up to now.
>
> Fixes: ceb515ba29ba ("drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and
> SN65DSI84 driver")
> Signed-off-by: Christophe JAILLET
Reviewed-by: Laurent Pinchart
> ---
> v2: add error handling in sn65dsi83_parse_dt() [Laurent Pincha
compatible LVDS encoders
>- renesas,r8a7795-lvds # for R-Car H3 compatible LVDS encoders
> + - renesas,r8a77961-lvds # for R-Car M3-W+ compatible LVDS encoders
I'll move this line after the next to keep them sorted. No need to
resubmit.
Reviewed-by: Laurent Pinchart
&g
Reviewed-by: Laurent Pinchart
> ---
> drivers/gpu/drm/rcar-du/rcar_lvds.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/rcar-du/rcar_lvds.c
> b/drivers/gpu/drm/rcar-du/rcar_lvds.c
> index 72a272cfc11e..8dbfbbd3cad1 100644
> --- a/drivers/gpu/drm/rca
reg = <1>;
> + lvds0_out: endpoint {
> };
Endpoints must have a remote-endpoint property. Let's drop the endpoint
here and keep the port only, the endpoint can be declared in board
files.
If you're fine with this change I can make it when applying the patch.
Reviewed-by: Laurent Pinchart
> };
> };
--
Regards,
Laurent Pinchart
n this patch I just used the same approach as in files laying nearby.
>
> If this approach is not appropriate, then perhaps need to fix it in
> files for all SoCs, to make it possible for extension board dtsi to be
> compatible with all of them.
I'm writing a patch to drop those right now :-) I'll CC you.
--
Regards,
Laurent Pinchart
ate endpoints on both sides together in
overlays.
https://lore.kernel.org/linux-renesas-soc/20211229193135.28767-2-laurent.pinchart+rene...@ideasonboard.com/T/#t
--
Regards,
Laurent Pinchart
blem space. There's also a
proprietary implementation in the Rapsberry Pi boot loader of a
mechanism to support parametrized overlays ([2] and [3], or [4] for an
example of how a panel reset or backlight GPIO can be parametrized).
[1] https://lwn.net/Articles/689783/
[2] https://www.raspberrypi.com/documentation/computers/configuration.html#part3
[3]
https://github.com/raspberrypi/firmware/blob/master/boot/overlays/README#L122
[4]
https://github.com/raspberrypi/firmware/blob/master/boot/overlays/README#L312
--
Regards,
Laurent Pinchart
connector->bridge_hpd)
> + if (bridge_connector->bridge_hpd) {
> connector->polled = DRM_CONNECTOR_POLL_HPD;
> + drm_bridge_connector_enable_hpd(connector);
> + }
> else if (bridge_connector->bridge_detect)
> connector->polled = DRM_CONNECTOR_POLL_CONNECT
> | DRM_CONNECTOR_POLL_DISCONNECT;
--
Regards,
Laurent Pinchart
ed).
>
> So the problem is already recognized for years... what stops from
> wider adoption of this or similar solutions?
Someone to continue working on it I suppose :-)
> And - if/while that is not being done - can't we at least try to
> follow more portable DT coding pattern while staying within existing
> concepts?
We could use a label for the port node as shown above. It's not a
complete solution, but it may help. I'm not sure how to solve the
enabling of the lvds encoder DT node though.
--
Regards,
Laurent Pinchart
Hi Marek,
Thank you for the patch.
On Fri, Dec 31, 2021 at 05:00:56PM +0100, Marek Vasut wrote:
> When the device is unbound from the driver, the display may be active.
> Make sure it gets shut down.
>
> Signed-off-by: Marek Vasut
> Cc: Daniel Vetter
> Cc: Laurent Pinchart
rek Vasut
> Cc: Daniel Vetter
> Cc: Laurent Pinchart
> Cc: Lucas Stach
> Cc: Sam Ravnborg
> Cc: Stefan Agner
> Cc: Thomas Zimmermann
Reviewed-by: Laurent Pinchart
> ---
> drivers/gpu/drm/mxsfb/mxsfb_drv.c | 8
> 1 file changed, 8 insertions(+)
>
> dif
= drm_atomic_helper_bridge_duplicate_state,
> + .atomic_destroy_state = drm_atomic_helper_bridge_destroy_state,
> + .atomic_reset = drm_atomic_helper_bridge_reset,
I think this should go to 1/2.
Reviewed-by: Laurent Pinchart
> + .atomic_get_input_bus_fmts = tda998x_atomic_get_input_bus_fmts,
> };
>
> /* I2C driver functions */
--
Regards,
Laurent Pinchart
evam
With the comment from 2/2 taken into account,
Reviewed-by: Laurent Pinchart
> ---
> drivers/gpu/drm/i2c/tda998x_drv.c | 10 ++
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c
> b/drivers/gpu/drm/i2c/tda998x_drv.c
efore all mutable variables.
>
> hsw = mode->hsync_end - mode->hsync_start;
> hfp = mode->hsync_start - mode->hdisplay;
I wonder if
/* set pixel clock divider mode */
regmap_write(adv->regmap_cec, 0x16, (12 / dsi->lanes) << 3);
wo
Hi Geert,
On Mon, Jan 10, 2022 at 09:43:58AM +0100, Geert Uytterhoeven wrote:
> On Wed, Dec 29, 2021 at 5:56 PM Laurent Pinchart wrote:
> > On Fri, Dec 24, 2021 at 08:23:08AM +0300, Nikita Yushchenko wrote:
> > > Add the missing lvds0 node for the R-Car M3-W+ SoC.
> &g
ay/panel/lvds.yaml#
> +$id: http://devicetree.org/schemas/display/lvds.yaml#
> $schema: http://devicetree.org/meta-schemas/core.yaml#
>
> -title: LVDS Display Panel
> +title: LVDS Display Common Properties
>
> maintainers:
>- Laurent Pinchart
> @@ -26,18 +26,7 @@ d
> +...
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 368072da0a05..02001455949e 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -6080,6 +6080,7 @@ T: git git://anongit.freedesktop.org/drm/drm-misc
> S: Maintained
> F: drivers/gpu/drm/panel/panel-lvds.c
> F: Documentation/devicetree/bindings/display/lvds.yaml
> +F: Documentation/devicetree/bindings/display/panel/panel-lvds.yaml
>
> DRM DRIVER FOR MANTIX MLAF057WE51 PANELS
> M: Guido Günther
--
Regards,
Laurent Pinchart
2 ("drm/writeback: wire drm_writeback.h to kernel-doc")
> Cc: Sam Ravnborg
> Cc: Daniel Vetter
> Cc: Laurent Pinchart
> Cc: Brian Starkey
> Cc: Liviu Dudau
> Signed-off-by: Daniel Vetter
Reviewed-by: Laurent Pinchart
> ---
> Documentation/gpu/drm-kms.rst |
-du/rcar_du_drv.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> @@ -297,7 +297,6 @@ static int rcar_du_probe(struct platform_device *pdev)
> {
> struct device_node *np = pdev->dev.of_node;
> struct rcar_du_device *rcdu;
> - struct drm_connector *connector;
> struct drm_device *ddev;
> struct resource *mem;
> int ret;
--
Regards,
Laurent Pinchart
> >
> > -#define DEFR6_TCNE2(1 << 6)
> > +#define DEFR6_TCNE1(1 << 6)
> > +#define DEFR6_TCNE0(1 << 4)
> >
> > #define DEFR6_MLOS1(1 << 2)
> >
> > -#define DEFR6_DEFAULT (DEFR6_CODE | DEFR6_TCNE2)
> > +#define DEFR6_DEFAULT (DEFR6_CODE | DEFR6_TCNE1)
--
Regards,
Laurent Pinchart
hile at it, add the TCNE0 bit which controls whether DU0 is connected to
> TCON.
>
> Based on the large patch by Andrey Gusakov
> .
>
> Signed-off-by: Andrey Gusakov
> Signed-off-by: Sergei Shtylyov
Acked-by: Laurent Pinchart
and applied to my tree.
> ---
> The
unsigned int ?
>
> if (!src || !num_clips) {
> dst->x1 = 0;
> dst->x2 = width;
> dst->y1 = 0;
> dst->y2 = height;
> return;
> }
>
> dst->x1 = dst->y1 = ~0;
> dst->x2 = dst->y2 = 0;
>
> for (i = 0; i < num_clips; i++) {
> if (flags & DRM_MODE_FB_DIRTY_ANNOTATE_COPY)
> i++;
> dst->x1 = min(dst->x1, src[i].x1);
> dst->x2 = max(dst->x2, src[i].x2);
> dst->y1 = min(dst->y1, src[i].y1);
> dst->y2 = max(dst->y2, src[i].y2);
> }
>
> if (dst->x2 > width || dst->y2 > height ||
> dst->x1 >= dst->x2 || dst->y1 >= dst->y2) {
> DRM_DEBUG_KMS("Illegal clip: x1=%u, x2=%u, y1=%u, y2=%u\n",
>dst->x1, dst->x2, dst->y1, dst->y2);
> dst->x1 = dst->y1 = 0;
> dst->x2 = width;
> dst->y2 = height;
> }
> }
>
> static int mipi_dbi_dirtyfb(struct drm_framebuffer *fb, void *vmem,
> unsigned flags, unsigned color,
> struct drm_clip_rect *clips, unsigned num_clips)
> {
> struct drm_clip_rect clip;
>
> tinydrm_merge_clips(&clip, clips, num_clips, flags,
> fb->width, fb->height);
--
Regards,
Laurent Pinchart
rcar_fcp_enable() return a status
- Dropped the unneeded dependency on PM for the VSP driver
Cc: devicetree at vger.kernel.org
Cc: dri-devel at lists.freedesktop.org
Cc: Dave Airlie
Laurent Pinchart (13):
dt-bindings: Add Renesas R-Car FCP DT bindings
v4l: Add Renesas R-Car FCP driver
v4l:
Make the global alpha multiplier of VSP planes configurable through the
alpha property, exactly as for the native DU planes.
Signed-off-by: Laurent Pinchart
Acked-by: Dave Airlie
---
drivers/gpu/drm/rcar-du/rcar_du_vsp.c | 38 +--
1 file changed, 19 insertions
Make the Z-order of VSP planes configurable through the zpos property,
exactly as for the native DU planes.
Signed-off-by: Laurent Pinchart
Acked-by: Dave Airlie
---
drivers/gpu/drm/rcar-du/rcar_du_vsp.c | 11 ---
drivers/gpu/drm/rcar-du/rcar_du_vsp.h | 2 ++
2 files changed, 10
The only multi-planar format supported by the driver is NV12, there will
thus never be more than two planes per framebuffer.
Signed-off-by: Laurent Pinchart
---
drivers/gpu/drm/omapdrm/omap_fb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/omapdrm
ed to userspace.
The rest of the patches are mostly dead code removal and small
simplifications.
Tomi, do you have pending omapdrm patches for v4.7 ? If so (and if time
permits) would you like to get this series merged through your tree ?
Laurent Pinchart (23):
drm: omapdrm: fb: Limit number of plane
The number of bits per pixel is identical for all planes, don't store
multiple copies.
Signed-off-by: Laurent Pinchart
---
drivers/gpu/drm/omapdrm/omap_fb.c | 53 ++-
1 file changed, 25 insertions(+), 28 deletions(-)
diff --git a/drivers/gpu/drm/om
This replaces calls to drm_format_num_planes() by a simple field access
every time we need the number of planes for the frame buffer.
Signed-off-by: Laurent Pinchart
---
drivers/gpu/drm/omapdrm/omap_fb.c | 55 +--
1 file changed, 29 insertions(+), 26
Merge the single-user objects_lookup inline function into its caller,
allowing reuse of the error code path.
Signed-off-by: Laurent Pinchart
---
drivers/gpu/drm/omapdrm/omap_drv.h | 25 -
drivers/gpu/drm/omapdrm/omap_fb.c | 30 +++---
2 files
Checks can be simplified based on the requirement that pitches must be
identical for all planes.
Signed-off-by: Laurent Pinchart
---
drivers/gpu/drm/omapdrm/omap_fb.c | 51 ---
1 file changed, 26 insertions(+), 25 deletions(-)
diff --git a/drivers/gpu/drm
Don't print userspace parameters validation failures as error messages
to avoid giving userspace the ability to flood the kernel log.
Signed-off-by: Laurent Pinchart
---
drivers/gpu/drm/omapdrm/omap_fb.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/dr
Instead of going through a complicated registration mechanism, just
call the OCP error IRQ handler directly from the main IRQ handler.
Signed-off-by: Laurent Pinchart
---
drivers/gpu/drm/omapdrm/omap_drv.h | 1 -
drivers/gpu/drm/omapdrm/omap_irq.c | 29 +++--
2 files
.
Signed-off-by: Laurent Pinchart
---
drivers/gpu/drm/omapdrm/omap_crtc.c | 38 ++---
drivers/gpu/drm/omapdrm/omap_drv.h | 1 +
drivers/gpu/drm/omapdrm/omap_irq.c | 4 +++-
3 files changed, 18 insertions(+), 25 deletions(-)
diff --git a/drivers/gpu/drm/omapdrm
The IRQ wait functions are called from the DSS enable and disable
operations only, where the DISPC is guaranteed to be enabled. There's no
need for manual DISPC power management there.
Signed-off-by: Laurent Pinchart
---
drivers/gpu/drm/omapdrm/omap_irq.c | 4
1 file changed, 4 dele
The function is only used in omap_irq.c, move it there and make it
static.
Signed-off-by: Laurent Pinchart
---
drivers/gpu/drm/omapdrm/omap_crtc.c | 7 ---
drivers/gpu/drm/omapdrm/omap_drv.h | 1 -
drivers/gpu/drm/omapdrm/omap_irq.c | 7 ++-
3 files changed, 6 insertions(+), 9
As the FIFO underflow IRQ handler just prints an error message to the
kernel log, simplify the code by not registering one IRQ handler per
plane but print the messages directly from the main IRQ handler.
Signed-off-by: Laurent Pinchart
---
drivers/gpu/drm/omapdrm/omap_drv.h | 2 +-
drivers
The omapdrm DSS manager enable/disable operations check the DSS manager
state to avoid double enabling/disabling. Move that code to the DSS
manager to decrease the dependency of the DRM layer to the DSS layer.
Signed-off-by: Laurent Pinchart
---
drivers/gpu/drm/omapdrm/dss/dispc.c | 1
Instead of going through a complicated registration mechanism, just
expose the CRTC error IRQ function and call it directly from the main
IRQ handler.
Signed-off-by: Laurent Pinchart
---
drivers/gpu/drm/omapdrm/omap_crtc.c | 12 ++--
drivers/gpu/drm/omapdrm/omap_drv.h | 1 +
drivers
Instead of conditioning planes update based on the hardware device
state, use the CRTC state stored in the atomic state. This reduces the
dependency from the DRM layer to the DSS layer.
Signed-off-by: Laurent Pinchart
---
drivers/gpu/drm/omapdrm/omap_crtc.c | 23 ++-
1 file
preparation for vblank interrupt fixes, make sure that the atomic
update event will be processed once only when the vblank interrupt will
be kept enabled.
Signed-off-by: Laurent Pinchart
---
drivers/gpu/drm/omapdrm/omap_crtc.c | 22 +++---
1 file changed, 19 insertions(+), 3 deletions
The flag will need to be accessed atomically in the vblank interrupt
handler, memory barriers won't be enough.
Signed-off-by: Laurent Pinchart
---
drivers/gpu/drm/omapdrm/omap_crtc.c | 28 +---
1 file changed, 21 insertions(+), 7 deletions(-)
diff --git a/driver
The functions are not used outside of their compilation unit, make them
static.
Signed-off-by: Laurent Pinchart
---
drivers/gpu/drm/omapdrm/omap_drv.h | 6 +-
drivers/gpu/drm/omapdrm/omap_irq.c | 27 +++
2 files changed, 8 insertions(+), 25 deletions(-)
diff --git
Now that the IRQ list is used for IRQ wait only we can merge
omap_drm_irq and omap_irq_wait and simplify the implementation.
Signed-off-by: Laurent Pinchart
---
drivers/gpu/drm/omapdrm/omap_drv.h | 17 +--
drivers/gpu/drm/omapdrm/omap_irq.c | 94 ++
2
Move the list of pending IRQ wait instances to the omap_drm_private
structure and the wait queue head to the IRQ wait structure.
Signed-off-by: Laurent Pinchart
---
drivers/gpu/drm/omapdrm/omap_drv.h | 3 ++-
drivers/gpu/drm/omapdrm/omap_irq.c | 38 --
2
The backlight GPIO was supported with platform data only. Now that the
driver only supports DT, the backlight GPIO is never initialized. Remove
it.
Signed-off-by: Laurent Pinchart
---
.../drm/omapdrm/displays/panel-lgphilips-lb035q02.c | 19 ---
1 file changed, 19 deletions
The function is never used, remove it.
Signed-off-by: Laurent Pinchart
---
drivers/gpu/drm/omapdrm/omap_drv.h | 1 -
drivers/gpu/drm/omapdrm/omap_fb.c | 10 --
2 files changed, 11 deletions(-)
diff --git a/drivers/gpu/drm/omapdrm/omap_drv.h
b/drivers/gpu/drm/omapdrm/omap_drv.h
index
The function is never used, remove it.
Signed-off-by: Laurent Pinchart
---
drivers/gpu/drm/omapdrm/omap_drv.h | 1 -
drivers/gpu/drm/omapdrm/omap_gem.c | 12
2 files changed, 13 deletions(-)
diff --git a/drivers/gpu/drm/omapdrm/omap_drv.h
b/drivers/gpu/drm/omapdrm/omap_drv.h
dered as a stable mainline API.
Remove buffer synchronization support to prepare for its replacement by
an implementation based on standard fences and reservation objects.
Signed-off-by: Laurent Pinchart
---
drivers/gpu/drm/omapdrm/omap_drv.c | 49 -
drivers/gpu/drm/omapdrm/omap_drv.h
->crtc_w == 0 || state->crtc_h == 0)
> + return -EINVAL;
> +
> if (state->crtc_x < 0 || state->crtc_y < 0)
> return -EINVAL;
--
Regards,
Laurent Pinchart
Hi Maarten,
Thank you for the patch.
On Tuesday 26 Apr 2016 16:11:40 Maarten Lankhorst wrote:
> The async name is deprecated and should be changed to nonblocking.
>
> Cc: Laurent Pinchart
> Signed-off-by: Maarten Lankhorst
Acked-by: Laurent Pinchart
> ---
> drive
Hi Ville,
On Wednesday 27 Apr 2016 20:29:24 Ville Syrjälä wrote:
> On Wed, Apr 27, 2016 at 06:30:19PM +0300, Laurent Pinchart wrote:
> > Hi Tomi,
> >
> > (CC'ing Daniel)
> >
> > Thank you for the patch.
> >
> > On Tuesday 26 Apr 2016 13:
Hi Ville,
On Thursday 28 Apr 2016 21:30:18 Ville Syrjälä wrote:
> On Wed, Apr 27, 2016 at 11:02:17PM +0300, Laurent Pinchart wrote:
> > On Wednesday 27 Apr 2016 20:29:24 Ville Syrjälä wrote:
> >> On Wed, Apr 27, 2016 at 06:30:19PM +0300, Laurent Pinchart wrote:
> >>
%) create mode 100644 drivers/gpu/drm/bridge/adv7511/adv7533.c
> create mode 100644 drivers/gpu/drm/bridge/tc358767.c
> delete mode 100644 drivers/gpu/drm/rcar-du/rcar_du_hdmicon.c
> delete mode 100644 drivers/gpu/drm/rcar-du/rcar_du_hdmicon.h
--
Regards,
Laurent Pinchart
e for hdmi
encoder")
Signed-off-by: Laurent Pinchart
---
drivers/gpu/drm/rcar-du/rcar_du_hdmienc.c | 1 +
1 file changed, 1 insertion(+)
Dave, this is a candidate for v4.8 as the offending patch just made it
upstream during the merge window.
diff --git a/drivers/gpu/drm/rcar-du/rcar_du_hdmienc.c
The plane .prepare_fb() and .cleanup_fb() helpers are optional, there's
no need to implement empty stubs, and no need to explicitly set the
function pointers to NULL either.
Signed-off-by: Laurent Pinchart
---
drivers/gpu/drm/arc/arcpgu_crtc.c | 2 --
drivers/gpu/drm/fs
roduced by patches 4/6
and 5/6.
[1] https://www.mail-archive.com/linux-renesas-soc at
vger.kernel.org/msg06589.html
Laurent Pinchart (6):
drm: Don't implement empty prepare_fb()/cleanup_fb()
drm: Unconstify state argument to prepare_fb()/cleanup_fb()
v4l: rcar-fcp: Don't get/put modu
Direct callers of the FCP API hold a reference to the FCP module due to
module linkage, there's no need to take another one manually. Take a
reference to the device instead to ensure that it won't disappear being
the caller's back.
Signed-off-by: Laurent Pinchart
---
drivers/medi
The functions might need to modify the state to store memory-related
data.
Signed-off-by: Laurent Pinchart
---
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 4 ++--
drivers/gpu/drm/i915/intel_display.c| 4 ++--
drivers/gpu/drm/i915/intel_drv.h| 4 ++--
drivers
The new rcar_fcp_get_device() function retrieves the struct device
related to the FCP device. This is useful to handle DMA mapping through
the right device.
Signed-off-by: Laurent Pinchart
---
drivers/media/platform/rcar-fcp.c | 6 ++
include/media/rcar-fcp.h | 5 +
2 files
The display buffers must be mapped for DMA through the device that
performs memory access. Expose an API to map and unmap memory through
the VSP device to be used by the DU.
Signed-off-by: Laurent Pinchart
---
drivers/media/platform/vsp1/vsp1_drm.c | 24
include/media
For planes handled by a VSP instance, map the framebuffer memory through
the VSP to ensure proper IOMMU handling.
Signed-off-by: Laurent Pinchart
---
drivers/gpu/drm/rcar-du/rcar_du_vsp.c | 74 ---
drivers/gpu/drm/rcar-du/rcar_du_vsp.h | 2 +
2 files changed, 70
Hi Tomi,
On Fri, May 03, 2019 at 02:43:51PM +0300, Tomi Valkeinen wrote:
> On 23/04/2019 17:56, Laurent Pinchart wrote:
>
> >> During initial driver development I had one eDP display that reports 0 in
> >> Bit 0
> >> (ANSI 8B/10B) of DPCD reg 0x0006 (MAIN_LINK_C
Hi Tomi,
On Fri, May 03, 2019 at 12:20:49PM +0300, Tomi Valkeinen wrote:
> On 21/04/2019 00:29, Laurent Pinchart wrote:
> > On Tue, Mar 26, 2019 at 12:31:32PM +0200, Tomi Valkeinen wrote:
> >> It is nicer to have enable/disable functions instead of set(bool enable)
&
Hi Tomi,
On Fri, May 03, 2019 at 11:10:54AM +0300, Tomi Valkeinen wrote:
> On 21/04/2019 01:14, Laurent Pinchart wrote:
> > On Tue, Mar 26, 2019 at 12:31:40PM +0200, Tomi Valkeinen wrote:
> >> tc_main_link_enable() checks if videomode has been set, and fails if
> >&g
Hi Tomi,
On Fri, May 03, 2019 at 04:17:41PM +0300, Tomi Valkeinen wrote:
> On 03/05/2019 15:48, Laurent Pinchart wrote:
> > On Fri, May 03, 2019 at 02:43:51PM +0300, Tomi Valkeinen wrote:
> >> On 23/04/2019 17:56, Laurent Pinchart wrote:
> >>
> >>>> Durin
> state and whatever else you feel like from there?
>
> Adding Laurent.
Thank you. I'll experiment with this, but please don't wait for me to
post a v4.
> > In all cases I think only returning the object, not it's state is
> > simplest, since then you avoi
OCTLs will
> + * not return correct data to userspace.
>*/
> struct drm_encoder *best_encoder;
>
--
Regards,
Laurent Pinchart
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
sn't this slightly
more inefficient ?
> Changes in v3:
> - Added to the set
>
> Cc: Daniel Vetter
> Cc: Ville Syrjälä
> Cc: Jani Nikula
> Cc: Joonas Lahtinen
> Cc: Rodrigo Vivi
> Cc: Ben Skeggs
> Cc: Laurent Pinchart
> Cc: Kieran Bingham
> Cc: Eric Anho
Hi Paul,
On Tue, Apr 23, 2019 at 06:54:49PM +0200, Paul Kocialkowski wrote:
> Le dimanche 21 avril 2019 à 01:40 +0300, Laurent Pinchart a écrit :
> > On Thu, Apr 18, 2019 at 01:49:54PM +0200, Paul Kocialkowski wrote:
> >> On Thu, 2019-04-18 at 11:02 +0200, Maxime Ripard wrote:
Hi Daniel,
On Tue, Apr 23, 2019 at 09:18:52PM +0200, Daniel Vetter wrote:
> On Tue, Apr 23, 2019 at 5:45 PM Laurent Pinchart wrote:
> > On Tue, Apr 23, 2019 at 09:25:54AM +0200, Daniel Vetter wrote:
> >> On Sun, Apr 21, 2019 at 01:59:04AM +0300, Laurent Pinchart wrote:
> >
in a functional way anyway. Instead, use the helper
> function drm_mode_vrefresh().
>
> Fixes: 9c8af882bf12 ("drm: Add adv7511 encoder driver")
> Signed-off-by: Matt Redfearn
Wow, a 4.5 year old bug fix, nice :-)
Reviewed-by: Laurent Pinchart
> ---
>
> drivers
Hi Kieran,
On Wed, Apr 24, 2019 at 09:12:48AM +0100, Kieran Bingham wrote:
> On 06/03/2019 23:23, Laurent Pinchart wrote:
> > Extend the drm_bridge_timings structure with a new dual_link field to
> > indicate that the bridge's input bus carries data on two separate
> >
701 - 800 of 9324 matches
Mail list logo
