[PATCH] drm: rcar-du: dsi: Fix hsfreq range matching

2021-12-06 Thread Laurent Pinchart
frequency. Reported-by: kernel test robot Reported-by: Dan Carpenter Signed-off-by: Laurent Pinchart --- I will squash this with "drm: rcar-du: Add R-Car DSI driver", but I'm posting it separately to ease review. --- drivers/gpu/drm/rcar-du/rcar_mipi_dsi.c | 5 ++--- 1 file change

[GIT PULL FOR v5.17] R-Car DU updates

2021-12-06 Thread Laurent Pinchart
HOAI (1): drm: rcar-du: Add R-Car DSI driver Laurent Pinchart (2): drm: rcar-du: Fix CRTC timings when CMM is used dt-bindings: display: bridge: Add binding for R-Car MIPI DSI/CSI-2 TX .../display/bridge/renesas,dsi-csi2-tx.yaml|

Re: [PATCH 1/4] dt-bindings: display: bridge: tc358867: Document DPI output support

2021-12-07 Thread Laurent Pinchart
d both as input and output. > > Signed-off-by: Marek Vasut > Cc: Andrzej Hajda > Cc: Jernej Skrabec > Cc: Jonas Karlman > Cc: Laurent Pinchart > Cc: Neil Armstrong > Cc: Rob Herring > Cc: Sam Ravnborg > Cc: devicet...@vger.kernel.org > To: dri-devel@lis

Re: [PATCH 1/4] dt-bindings: display: bridge: tc358867: Document DPI output support

2021-12-07 Thread Laurent Pinchart
On Tue, Dec 07, 2021 at 05:47:29PM +0100, Marek Vasut wrote: > On 12/7/21 17:43, Laurent Pinchart wrote: > > [...] > > >> diff --git > >> a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358767.yaml > >> b/Documentation/devicetree/bindin

Re: [PATCH] drm: rcar-du: Use dev_err_probe() helper

2021-12-08 Thread Laurent Pinchart
e should (in rcar_du_encoder_init(), there are two main code paths where -EPROBE_DEFER is expected), so this patch would then get in the way I'm afraid. > I think it's probably fine, so > > Reviewed-by: Kieran Bingham > > > goto error; > > } > > -- Regards, Laurent Pinchart

Re: [PATCH] drm: rcar-du: Use dev_err_probe() helper

2021-12-08 Thread Laurent Pinchart
Hi Geert, On Wed, Dec 08, 2021 at 07:23:25PM +0100, Geert Uytterhoeven wrote: > On Wed, Dec 8, 2021 at 7:00 PM Laurent Pinchart wrote: > > On Wed, Dec 08, 2021 at 11:57:21AM +, Kieran Bingham wrote: > > > Quoting Geert Uytterhoeven (2021-12-08 10:30:53) > > > >

Re: [PATCH v4 4/4] drm/bridge: ti-sn65dsi83: Add vcc supply regulator support

2021-12-09 Thread Laurent Pinchart
; > + if (IS_ERR(ctx->vcc)) > + return dev_err_probe(dev, PTR_ERR(ctx->vcc), > + "Failed to get supply 'vcc': %pe\n", > + ERR_PTR(ret)); This doesn't seem right, ret doesn

Re: [PATCH v4 4/4] drm/bridge: ti-sn65dsi83: Add vcc supply regulator support

2021-12-09 Thread Laurent Pinchart
> > > + ret = regulator_enable(ctx->vcc); > > + if (ret) { > > + dev_err(ctx->dev, "Failed to enable vcc\n"); > > + return; > > + } > > Better check the vcc and enable it since it is an optional one. Won't the regulator core create a dummy regulator if none is specified in DT ? -- Regards, Laurent Pinchart

Re: [PATCH 1/2] drm/ bridge: tc358762: move bridge init to enable callback

2021-12-09 Thread Laurent Pinchart
idge_to_tc358762(bridge); > > > int ret; > > > @@ -157,7 +157,7 @@ static void tc358762_pre_enable(struct drm_bridge > > > *bridge) > > > if (ret < 0) > > > dev_err(ctx->dev, "error initializing bridge (%d)\n", &g

Re: [PATCH 3/9] drm: rcar-du: Drop unneeded encoder cleanup in error path

2020-12-14 Thread Laurent Pinchart
Hi Jacopo, On Mon, Dec 14, 2020 at 11:11:08AM +0100, Jacopo Mondi wrote: > On Sat, Dec 05, 2020 at 12:01:33AM +0200, Laurent Pinchart wrote: > > The encoder->name field can never be non-null in the error path, as that > > can only be possible after a successful call to > >

Re: [PATCH 5/9] drm: rcar-du: Use DRM-managed allocation for encoders

2020-12-14 Thread Laurent Pinchart
Hi Jacopo, On Mon, Dec 14, 2020 at 11:37:50AM +0100, Jacopo Mondi wrote: > On Sat, Dec 05, 2020 at 12:01:35AM +0200, Laurent Pinchart wrote: > > devm_kzalloc() is the wrong API to allocate encoders, as the lifetime of > > the encoders is tied to the DRM device, not the d

Re: [PATCH 8/9] drm: rcar-du: Skip encoder allocation for LVDS1 in dual-link mode

2020-12-14 Thread Laurent Pinchart
Hi Jacopo, On Mon, Dec 14, 2020 at 12:04:49PM +0100, Jacopo Mondi wrote: > On Sat, Dec 05, 2020 at 12:01:38AM +0200, Laurent Pinchart wrote: > > The rcar-du driver skips registration of the encoder for the LVDS1 > > output when LVDS is used in dual-link mode, as the LVDS0 and LVDS

Re: [PATCH 4/9] drm: rcar-du: Use DRM-managed allocation for VSP planes

2020-12-14 Thread Laurent Pinchart
Hi Kieran, On Mon, Dec 14, 2020 at 04:20:17PM +, Kieran Bingham wrote: > On 04/12/2020 22:01, Laurent Pinchart wrote: > > devm_kcalloc() is the wrong API to allocate planes, as the lifetime of > > the planes is tied to the DRM device, not the device to driver > > binding.

[PATCH v2 1/9] drm: rcar-du: Fix crash when using LVDS1 clock for CRTC

2020-12-14 Thread Laurent Pinchart
output on Gen3 when using dual-link LVDS mode") Signed-off-by: Laurent Pinchart Reviewed-by: Jacopo Mondi Reviewed-by: Kieran Bingham --- Changes since v1: - Drop rcar_du_device.encoders field - Add Fixes: tag --- drivers/gpu/drm/rcar-du/rcar_du_crtc.c| 10 ++ drivers/

[PATCH v2 0/9] drm: rcar-du: Fix LVDS-related crash

2020-12-14 Thread Laurent Pinchart
([1]), but those haven't landed yet. Not depending on them also helps backporting those fixes to stable kernels. I will switch to the new helpers when they will be available. [1] https://lore.kernel.org/dri-devel/20200911135724.25833-1-p.za...@pengutronix.de/ Laurent Pinchart (9): drm: rc

[PATCH v2 3/9] drm: rcar-du: Drop unneeded encoder cleanup in error path

2020-12-14 Thread Laurent Pinchart
The encoder->name field can never be non-null in the error path, as that can only be possible after a successful call to drm_simple_encoder_init(). Drop the cleanup. Signed-off-by: Laurent Pinchart Reviewed-by: Jacopo Mondi Reviewed-by: Kieran Bingham --- drivers/gpu/drm/rcar

[PATCH v2 2/9] drm: rcar-du: Release vsp device reference in all error paths

2020-12-14 Thread Laurent Pinchart
Use drmm_add_action_or_reset() instead of drmm_add_action() to ensure the vsp device reference is released in case the function call fails. Signed-off-by: Laurent Pinchart Reviewed-by: Jacopo Mondi Reviewed-by: Kieran Bingham --- drivers/gpu/drm/rcar-du/rcar_du_vsp.c | 2 +- 1 file changed, 1

[PATCH v2 8/9] drm: rcar-du: Skip encoder allocation for LVDS1 in dual-link mode

2020-12-14 Thread Laurent Pinchart
the encoder altogether in that case. Signed-off-by: Laurent Pinchart Reviewed-by: Jacopo Mondi Reviewed-by: Kieran Bingham --- Changes since v1: - Drop error label --- drivers/gpu/drm/rcar-du/rcar_du_encoder.c | 59 ++- 1 file changed, 25 insertions(+), 34 deletions(-) diff

[PATCH v2 5/9] drm: rcar-du: Use DRM-managed allocation for encoders

2020-12-14 Thread Laurent Pinchart
f the DRM objects. Use a plain kzalloc(), and register a drmm action to cleanup the encoder. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/rcar-du/rcar_du_encoder.c | 47 ++- 1 file changed, 29 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/rc

[PATCH v2 9/9] drm: rcar-du: Drop local encoder variable

2020-12-14 Thread Laurent Pinchart
The local encoder variable is an alias for &renc->base, and is only use twice. It doesn't help much, drop it, along with the rcar_encoder_to_drm_encoder() macro that is then unused. Signed-off-by: Laurent Pinchart Reviewed-by: Jacopo Mondi Reviewed-by: Kieran Bingham --- drivers/

[PATCH v2 6/9] drm: rcar-du: Embed drm_device in rcar_du_device

2020-12-14 Thread Laurent Pinchart
Embedding drm_device in rcar_du_device allows usage of the DRM managed API to allocate both structures in one go, simplifying error handling. Signed-off-by: Laurent Pinchart Reviewed-by: Jacopo Mondi Reviewed-by: Kieran Bingham --- drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 2 +- drivers

[PATCH v2 4/9] drm: rcar-du: Use DRM-managed allocation for VSP planes

2020-12-14 Thread Laurent Pinchart
e DRM objects. Use a plain kcalloc(), and cleanup the planes and free the memory in the existing rcar_du_vsp_cleanup() handler. Signed-off-by: Laurent Pinchart Reviewed-by: Kieran Bingham --- drivers/gpu/drm/rcar-du/rcar_du_vsp.c | 22 +- 1 file changed, 17 insertions(+), 5 dele

[PATCH v2 7/9] drm: rcar-du: Replace dev_private with container_of

2020-12-14 Thread Laurent Pinchart
Now that drm_device is embedded in rcar_du_device, we can use container_of to get the rcar_du_device pointer from the drm_device, instead of using the drm_device.dev_private field. Signed-off-by: Laurent Pinchart Reviewed-by: Jacopo Mondi Reviewed-by: Kieran Bingham --- drivers/gpu/drm/rcar

Re: [PATCH] drm: rcar-du: fix reference leak in rcar_cmm_enable

2020-12-15 Thread Laurent Pinchart
rcar-du: Add support for CMM") > Reported-by: Hulk Robot > Signed-off-by: Qinglang Miao Reviewed-by: Laurent Pinchart And queued for v5.11. > --- > drivers/gpu/drm/rcar-du/rcar_cmm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drive

[PATCH 1/4] drm: arc: Remove unnecessary drm_plane_cleanup() wrapper

2020-12-15 Thread Laurent Pinchart
Use the drm_plane_cleanup() function directly as the drm_plane_funcs .destroy() handler without creating an unnecessary wrapper around it. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/arc/arcpgu_crtc.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers

[PATCH 4/4] drm: zte: Remove unnecessary drm_plane_cleanup() wrapper

2020-12-15 Thread Laurent Pinchart
Use the drm_plane_cleanup() function directly as the drm_plane_funcs .destroy() handler without creating an unnecessary wrapper around it. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/zte/zx_plane.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/gpu/drm

[PATCH 2/4] drm: sti: Remove unnecessary drm_plane_cleanup() wrapper

2020-12-15 Thread Laurent Pinchart
Use the drm_plane_cleanup() function directly as the drm_plane_funcs .destroy() handler without creating an unnecessary wrapper around it. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/sti/sti_cursor.c | 9 + drivers/gpu/drm/sti/sti_gdp.c| 9 + drivers/gpu/drm/sti

[PATCH 3/4] drm: vc4: Remove unnecessary drm_plane_cleanup() wrapper

2020-12-15 Thread Laurent Pinchart
Use the drm_plane_cleanup() function directly as the drm_plane_funcs .destroy() handler without creating an unnecessary wrapper around it. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/vc4/vc4_plane.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/gpu

[PATCH] drm: Don't export the drm_gem_dumb_destroy() function

2020-12-15 Thread Laurent Pinchart
The drm_gem_dumb_destroy() isn't used in drivers, don't export it. Signed-off-by: Laurent Pinchart --- Changes since v1: - Move function prototype from drm_gem.h to drm_internal.h - Drop function documentation - Replace uint32_t with u32 --- drivers/gpu/drm/drm_dumb_buff

[PATCH v2 1/3] drm: Move legacy device list out of drm_driver

2020-12-15 Thread Laurent Pinchart
global where the local field didn't require serialization, but this only affects legacy drivers, and isn't in any hot path. While at it, compile-out the legacy_dev_list field when DRM_LEGACY isn't defined. Signed-off-by: Laurent Pinchart Reviewed-by: Daniel Vetter Reviewed-b

[PATCH v2 0/3] Finish constification of drm_driver in DRM core

2020-12-15 Thread Laurent Pinchart
, and in a few cases, change the driver features. This will require a bit more work to fix these cases. Laurent Pinchart (3): drm: Move legacy device list out of drm_driver drm: Use a const drm_driver for legacy PCI devices drm: Constify drm_driver in drivers that don't modify it driver

[PATCH v2 2/3] drm: Use a const drm_driver for legacy PCI devices

2020-12-15 Thread Laurent Pinchart
Now that the legacy PCI support code doesn't need to write to the drm_driver structure, it can be treated as const through the whole DRM core, unconditionally. This allows declaring the structure as const in all drivers, removing one possible attack vector. Signed-off-by: Laurent Pin

[PATCH v2 3/3] drm: Constify drm_driver in drivers that don't modify it

2020-12-15 Thread Laurent Pinchart
eed a more complex fix. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/arc/arcpgu_drv.c | 2 +- drivers/gpu/drm/kmb/kmb_drv.c| 2 +- drivers/gpu/drm/tdfx/tdfx_drv.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/arc/arcpgu_drv.c b/drivers/gpu/dr

Re: [PATCH] drm/bridge: thc63lvd1024: Fix regulator_get_optional() misuse

2020-12-15 Thread Laurent Pinchart
software. > > Signed-off-by: Mark Brown Reviewed-by: Laurent Pinchart and queued in my tree for v5.12. > --- > drivers/gpu/drm/bridge/thc63lvd1024.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/bridge/thc63lvd1024.c > b/

[PATCH] dt-bindings: display: bridge: renesas, lvds: RZ/G2E needs renesas, companion too

2020-12-15 Thread Laurent Pinchart
From: Fabrizio Castro Document RZ/G2E support for property renesas,companion. Signed-off-by: Fabrizio Castro Reviewed-by: Laurent Pinchart Signed-off-by: Laurent Pinchart --- Changes since v1: - Slight reword of SoC list in description --- .../devicetree/bindings/display/bridge/renesas

[PATCH] dt-bindings: display: renesas,du: Convert binding to YAML

2020-12-15 Thread Laurent Pinchart
Convert the Renesas R-Car DU text binding to YAML. Signed-off-by: Laurent Pinchart --- Changes since v1: - Use pattern instead of enum for dclkin - Update MAINTAINERS --- .../bindings/display/renesas,du.txt | 145 --- .../bindings/display/renesas,du.yaml | 854

[PATCH v2 0/4] Converter R-Car DU to the DRM bridge connector helper

2020-12-15 Thread Laurent Pinchart
GA, HDMI and LVDS outputs. [1] https://lore.kernel.org/dri-devel/20200526011505.31884-28-laurent.pinchart+rene...@ideasonboard.com/ Laurent Pinchart (4): drm: rcar-du: lvds: Convert to DRM panel bridge helper drm: bridge: dw-hdmi: Attach to next bridge if available drm: rcar-du: dw-hdmi: Set

[PATCH v2 2/4] drm: bridge: dw-hdmi: Attach to next bridge if available

2020-12-15 Thread Laurent Pinchart
bridge attach handler. Signed-off-by: Laurent Pinchart Reviewed-by: Neil Armstrong --- Changes since v1: - Make missing endpoint a fatal error --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 54 ++- include/drm/bridge/dw_hdmi.h | 2 + 2 files changed, 55

[PATCH v2 1/4] drm: rcar-du: lvds: Convert to DRM panel bridge helper

2020-12-15 Thread Laurent Pinchart
Replace the manual panel handling with usage of the DRM panel bridge helper. This simplifies the driver, and brings support for DRM_BRIDGE_ATTACH_NO_CONNECTOR as an added bonus. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/rcar-du/rcar_lvds.c | 120 +++- 1 file

[PATCH v2 4/4] drm: rcar-du: Use drm_bridge_connector_init() helper

2020-12-15 Thread Laurent Pinchart
Use the drm_bridge_connector_init() helper to create a drm_connector for each output, instead of relying on the bridge drivers doing so. Attach the bridges with the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag to instruct them not to create a connector. Signed-off-by: Laurent Pinchart --- drivers/gpu

[PATCH v2 3/4] drm: rcar-du: dw-hdmi: Set output port number

2020-12-15 Thread Laurent Pinchart
Report the DT output port number in dw_hdmi_plat_data to connect to the next bridge in the dw-hdmi driver. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/rcar-du/rcar_dw_hdmi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/rcar-du/rcar_dw_hdmi.c b/drivers/gpu/drm

Re: [PATCH] drm: rcar-du: Fix the return check of of_parse_phandle and of_find_device_by_node

2020-12-15 Thread Laurent Pinchart
Hi Wang, Thank you for the patch. On Wed, Nov 11, 2020 at 11:14:52AM +0800, Wang Xiaojun wrote: > of_parse_phandle and of_find_device_by_node may return NULL > which cannot be checked by IS_ERR. > > Signed-off-by: Wang Xiaojun > Reported-by: Hulk Robot Reviewed-by: Laurent

Re: [PATCH] drm: rcar-du: Fix the return check of of_parse_phandle and of_find_device_by_node

2020-12-15 Thread Laurent Pinchart
On Wed, Dec 16, 2020 at 03:00:43AM +0200, Laurent Pinchart wrote: > Hi Wang, > > Thank you for the patch. > > On Wed, Nov 11, 2020 at 11:14:52AM +0800, Wang Xiaojun wrote: > > of_parse_phandle and of_find_device_by_node may return NULL > > which cannot be checked by

[PATCH] drm: rcar-du: Fix leak of CMM platform device reference

2020-12-15 Thread Laurent Pinchart
The device references acquired by of_find_device_by_node() are not released by the driver. Fix this by registering a cleanup action. Fixes: 8de707aeb452 ("drm: rcar-du: kms: Initialize CMM instances") Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/rcar-du/rcar_du_

Re: [PATCH 14/65] drm/rcar-du: Annotate dma-fence critical section in commit path

2020-12-15 Thread Laurent Pinchart
Hi Daniel, Thank you for the patch. On Fri, Oct 23, 2020 at 02:21:25PM +0200, Daniel Vetter wrote: > Ends right after drm_atomic_helper_commit_hw_done(), absolutely > nothing fancy going on here. > > Signed-off-by: Daniel Vetter > Cc: Laurent Pinchart > Cc: Kieran Bingham &

Re: [PATCH 2/3] drm: uapi: Use SPDX in DRM drivers uAPI headers

2020-12-15 Thread Laurent Pinchart
Hi Christian, On Fri, Jul 17, 2020 at 04:05:42PM +0200, Christian König wrote: > Am 17.07.20 um 04:27 schrieb Laurent Pinchart: > > On Mon, Jun 22, 2020 at 11:29:33AM +0200, Daniel Vetter wrote: > >> On Mon, Jun 22, 2020 at 09:58:44AM +0200, Christian König wrote: > >

[PATCH v2 01/10] drm: uapi: Use SPDX in DRM core uAPI headers

2020-12-15 Thread Laurent Pinchart
implementations of software using the DRM uAPI are accepted, as allowed by the MIT license. Signed-off-by: Laurent Pinchart Reviewed-by: Greg Kroah-Hartman Reviewed-by: Thomas Gleixner Reviewed-by: Daniel Vetter --- Documentation/gpu/drm-uapi.rst | 4 include/uapi/drm/drm.h | 20

[PATCH v2 02/10] drm: uapi: amd: Use SPDX in DRM drivers uAPI headers

2020-12-15 Thread Laurent Pinchart
The AMD DRM drivers uAPI headers are licensed under the MIT license, and carry copies of the license with slight variations. Replace them with SPDX headers. Signed-off-by: Laurent Pinchart --- include/uapi/drm/amdgpu_drm.h | 19 +-- include/uapi/drm/r128_drm.h | 20

[PATCH v2 04/10] drm: uapi: intel: Use SPDX in DRM drivers uAPI headers

2020-12-15 Thread Laurent Pinchart
The Intel DRM drivers uAPI headers are licensed under the MIT license, and carry copies of the license with slight variations. Replace them with SPDX headers. Signed-off-by: Laurent Pinchart --- include/uapi/drm/i915_drm.h | 22 +- include/uapi/drm/vgem_drm.h | 22

[PATCH v2 07/10] drm: uapi: tegra: Use SPDX in DRM drivers uAPI headers

2020-12-15 Thread Laurent Pinchart
The Nvidia Tegra DRM driver uAPI header is licensed under the MIT license, and carries a copy of the license with slight variations. Replace it with an SPDX header. Signed-off-by: Laurent Pinchart --- include/uapi/drm/tegra_drm.h | 19 +-- 1 file changed, 1 insertion(+), 18

[PATCH v2 03/10] drm: uapi: broadcom: Use SPDX in DRM drivers uAPI headers

2020-12-15 Thread Laurent Pinchart
The Broadcom DRM drivers uAPI headers are licensed under the MIT license, and carry copies of the license with slight variations. Replace them with SPDX headers. Signed-off-by: Laurent Pinchart --- include/uapi/drm/v3d_drm.h | 20 +--- include/uapi/drm/vc4_drm.h | 20

[PATCH v2 08/10] drm: uapi: vmware: Use SPDX in DRM drivers uAPI headers

2020-12-15 Thread Laurent Pinchart
The VMware DRM driver uAPI header is licensed under the MIT license, and carries a copy of the license with slight variations. Replace it with an SPDX header. Signed-off-by: Laurent Pinchart Reviewed-by: Roland Scheidegger --- include/uapi/drm/vmwgfx_drm.h | 21 + 1 file

[PATCH v2 06/10] drm: uapi: redhat: Use SPDX in DRM drivers uAPI headers

2020-12-15 Thread Laurent Pinchart
The DRM drivers uAPI headers are licensed under the MIT license, and carry copies of the license with slight variations. Replace them with SPDX headers for headers copyrighted by Red Hat. Signed-off-by: Laurent Pinchart --- include/uapi/drm/msm_drm.h | 20 +--- include/uapi

[PATCH v2 10/10] drm: uapi: Remove copies of GPL license text from headers

2020-12-15 Thread Laurent Pinchart
Several DRM drivers uAPI headers that are licensed under the GPL carry both an SPDX header and a copy of the license text. Drop the latter. Signed-off-by: Laurent Pinchart Reviewed-by: Daniel Vetter --- include/uapi/drm/armada_drm.h | 4 include/uapi/drm/etnaviv_drm.h | 12

[PATCH v2 09/10] drm: uapi: legacy: Use SPDX in DRM drivers uAPI headers

2020-12-15 Thread Laurent Pinchart
The legacy DRM drivers uAPI headers are licensed under the MIT license, and carry copies of the license with slight variations. Replace them with SPDX headers. Signed-off-by: Laurent Pinchart --- include/uapi/drm/mga_drm.h| 20 +--- include/uapi/drm/savage_drm.h | 20

[PATCH v2 05/10] drm: uapi: nouveau: Use SPDX in DRM drivers uAPI headers

2020-12-15 Thread Laurent Pinchart
The Nouveau DRM driver uAPI header is licensed under the MIT license, and carries a copy of the license with slight variations. Replace it with an SPDX header. Signed-off-by: Laurent Pinchart --- include/uapi/drm/nouveau_drm.h | 20 +--- 1 file changed, 1 insertion(+), 19

Re: [PATCH v5 15/19] drm/msm: Remove prototypes for non-existing functions

2020-12-15 Thread Laurent Pinchart
On Wed, Mar 13, 2019 at 02:00:28AM +0200, Laurent Pinchart wrote: > On Thu, Feb 21, 2019 at 12:39:24PM +0200, Laurent Pinchart wrote: > > Forgot to CC Rob, sorry about that. > > Rob, could you take this in your tree ? Gentle ping. > > On Thu, Feb 21, 2019 at 12:32:08PM +0

Re: [PATCH v2 1/4] drm: rcar-du: lvds: Convert to DRM panel bridge helper

2020-12-16 Thread Laurent Pinchart
Hi Jacopo, On Wed, Dec 16, 2020 at 02:16:56PM +0100, Jacopo Mondi wrote: > On Wed, Dec 16, 2020 at 02:50:18AM +0200, Laurent Pinchart wrote: > > Replace the manual panel handling with usage of the DRM panel bridge > > helper. This simplifies the driver, and bri

Re: [PATCH v2 4/4] drm: rcar-du: Use drm_bridge_connector_init() helper

2020-12-16 Thread Laurent Pinchart
Hi Jacopo, On Wed, Dec 16, 2020 at 12:53:19PM +0100, Jacopo Mondi wrote: > On Wed, Dec 16, 2020 at 02:50:21AM +0200, Laurent Pinchart wrote: > > Use the drm_bridge_connector_init() helper to create a drm_connector for > > each output, instead of relying on the bridge drivers d

Re: [PATCH] drm: rcar-du: Fix leak of CMM platform device reference

2020-12-16 Thread Laurent Pinchart
own, doesn't it ? As the CMM shouldn't be hotplugged, yes. It's not really the device that is leaked here, but the reference. > On Wed, Dec 16, 2020 at 03:22:18AM +0200, Laurent Pinchart wrote: > > The device references acquired by of_find_device_by_node() are not >

[PATCH v2] drm: rcar-du: Fix leak of CMM platform device reference

2020-12-16 Thread Laurent Pinchart
The device references acquired by of_find_device_by_node() are not released by the driver. Fix this by registering a cleanup action. Fixes: 8de707aeb452 ("drm: rcar-du: kms: Initialize CMM instances") Signed-off-by: Laurent Pinchart --- Changes since v1: - Only set rcdu->cmms

Re: [PATCH] drm/bridge: use devm_add_action_or_reset() to handle failed condition

2020-12-16 Thread Laurent Pinchart
o Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c > b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c > index 70ab4fb

Re: [PATCH v2] drm: rcar-du: Fix leak of CMM platform device reference

2020-12-16 Thread Laurent Pinchart
Hi Jacopo, On Wed, Dec 16, 2020 at 03:16:28PM +0100, Jacopo Mondi wrote: > On Wed, Dec 16, 2020 at 04:08:36PM +0200, Laurent Pinchart wrote: > > The device references acquired by of_find_device_by_node() are not > > released by the driver. Fix this by registering a cleanup action

Re: [PATCH 4/4] drm: zte: Remove unnecessary drm_plane_cleanup() wrapper

2020-12-16 Thread Laurent Pinchart
Hi Daniel, On Wed, Dec 16, 2020 at 03:22:59PM +0100, Daniel Vetter wrote: > On Tue, Dec 15, 2020 at 09:37:55PM +0200, Laurent Pinchart wrote: > > Use the drm_plane_cleanup() function directly as the drm_plane_funcs > > .destroy() handler without creating an unnecessary wr

Re: [PATCH v2 2/3] drm: Use a const drm_driver for legacy PCI devices

2020-12-16 Thread Laurent Pinchart
On Wed, Dec 16, 2020 at 03:29:00PM +0100, Daniel Vetter wrote: > On Tue, Dec 15, 2020 at 10:31:25PM +0200, Laurent Pinchart wrote: > > Now that the legacy PCI support code doesn't need to write to the > > drm_driver structure, it can be treated as const through th

Re: [PATCH v2 01/10] drm: uapi: Use SPDX in DRM core uAPI headers

2020-12-16 Thread Laurent Pinchart
Hi Daniel, On Wed, Dec 16, 2020 at 03:34:35PM +0100, Daniel Vetter wrote: > On Wed, Dec 16, 2020 at 04:43:50AM +0200, Laurent Pinchart wrote: > > The DRM core uAPI headers are licensed under the MIT license, and carry > > copies of the license with slight variations. Replace

Re: [PATCH v2 01/10] drm: uapi: Use SPDX in DRM core uAPI headers

2020-12-16 Thread Laurent Pinchart
On Wed, Dec 16, 2020 at 04:12:14PM +0100, Daniel Vetter wrote: > On Wed, Dec 16, 2020 at 05:03:25PM +0200, Laurent Pinchart wrote: > > On Wed, Dec 16, 2020 at 03:34:35PM +0100, Daniel Vetter wrote: > > > On Wed, Dec 16, 2020 at 04:43:50AM +0200, Laurent Pinchart wrote: > &g

Re: [PATCH] dt-bindings: display: renesas, du: Convert binding to YAML

2020-12-20 Thread Laurent Pinchart
Hi Rob, On Thu, Dec 17, 2020 at 05:48:22PM -0600, Rob Herring wrote: > On Wed, Dec 16, 2020 at 01:06:03AM +0200, Laurent Pinchart wrote: > > Convert the Renesas R-Car DU text binding to YAML. > > I tend to think this should be split up, but up to you. I wouldn't mind, but I&

[PATCH v3] dt-bindings: display: renesas,du: Convert binding to YAML

2020-12-20 Thread Laurent Pinchart
Convert the Renesas R-Car DU text binding to YAML. Signed-off-by: Laurent Pinchart --- Changes since v2: - Drop boilerplate for ports node - Add description for interrupts peroperty - Use single quoted strings to avoid double backslashes Changes since v1: - Use pattern instead of enum for

Re: [PATCH] drm: bridge: dw-hdmi: Remove redundant null check before clk_disable_unprepare

2020-12-20 Thread Laurent Pinchart
Hi Xu Wang, Thank you for the patch. On Fri, Nov 27, 2020 at 09:23:32AM +, Xu Wang wrote: > Because clk_disable_unprepare() already checked NULL clock parameter, > so the additional check is unnecessary, just remove them. > > Signed-off-by: Xu Wang Reviewed-by: Laur

Re: [PATCH] drm: bridge: adv7511: Remove redundant null check before clk_disable_unprepare

2020-12-20 Thread Laurent Pinchart
Hi Xu Wang, Thank you for the patch. On Fri, Nov 27, 2020 at 09:18:29AM +, Xu Wang wrote: > Because clk_disable_unprepare() already checked NULL clock parameter, > so the additional check is unnecessary, just remove them. > > Signed-off-by: Xu Wang Reviewed-by: Laur

[PATCH v2 1/6] dt-bindings: display: bridge: Add YAML schema for Synopsys DW-HDMI

2020-12-20 Thread Laurent Pinchart
Add a .yaml schema containing the common properties for the Synopsys DesignWare HDMI TX controller. This isn't a full device tree binding specification, but is meant to be referenced by platform-specific bindings for the IP core. Signed-off-by: Laurent Pinchart --- Changes since v1:

[PATCH v2 0/6] dt-bindings: display: Convert DWC HDMI TX bindings to YAML

2020-12-20 Thread Laurent Pinchart
. I have volunteered Philipp Zabel and Mark Yao as maintainers for the i.MX6 and Rockchip bindings respectively. Please let me know if you would prefer a different maintainer, or ack the respective patch if this is fine with you. Laurent Pinchart (6): dt-bindings: display: bridge: Add YAML

[PATCH v2 2/6] dt-bindings: display: bridge: renesas, dw-hdmi: Convert binding to YAML

2020-12-20 Thread Laurent Pinchart
Convert the Renesas R-Car DWC HDMI TX text binding to YAML. Signed-off-by: Laurent Pinchart --- Changes since v1: - Drop the part numbers in comments, only keep the SoC names - Use unevaluatedProperties instead of additionalProperties - Only specify maxItems for clocks and clock-names - Drop

[PATCH v2 4/6] dt-bindings: display: rockchip: dw-hdmi: Convert binding to YAML

2020-12-20 Thread Laurent Pinchart
Convert the Rockchip HDMI TX text binding to YAML. Signed-off-by: Laurent Pinchart --- Changes since v1: - Drop pinctrl-0 and pinctrl-1 - Use unevaluatedProperties instead of additionalProperties - Drop reg and interrupts as they're checked in the base schema - Rebase on top of OF graph s

[PATCH v2 3/6] dt-bindings: display: imx: hdmi: Convert binding to YAML

2020-12-20 Thread Laurent Pinchart
Convert the i.MX6 HDMI TX text binding to YAML. Signed-off-by: Laurent Pinchart --- Changes since v1: - Only specify maxItems for clocks - Drop reg and interrupts as they're checked in the base schema - Rebase on top of OF graph schema, dropped redundant properties - Fix identation for

[PATCH v2 6/6] dt-bindings: display: bridge: Remove deprecated dw_hdmi.txt

2020-12-20 Thread Laurent Pinchart
dw_hdmi.txt has been replaced with synopsys,dw-hdmi.yaml, and all references to the old file have been converted. Remove it. Signed-off-by: Laurent Pinchart Acked-by: Rob Herring --- .../bindings/display/bridge/dw_hdmi.txt | 33 --- 1 file changed, 33 deletions(-) delete

[PATCH v2 5/6] dt-bindings: display: sun8i-a83t-dw-hdmi: Reference dw-hdmi YAML schema

2020-12-20 Thread Laurent Pinchart
Replace the reference to the DWC HDMI text DT binding with a reference to the YAML equivalent. Signed-off-by: Laurent Pinchart Acked-by: Rob Herring --- .../bindings/display/allwinner,sun8i-a83t-dw-hdmi.yaml| 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a

Re: [PATCH v2 0/6] dt-bindings: display: Convert DWC HDMI TX bindings to YAML

2020-12-20 Thread Laurent Pinchart
On Sun, Dec 20, 2020 at 09:49:59PM +0200, Laurent Pinchart wrote: > Hello, > > This patch series attempts a conversion of the DWC HDMI TX DT bindings > to YAML. > > The DWC HDMI TX is an HDMI transmitter IP core from Synopsys, integrated > in various SoCs with different

[PATCH 0/4] drm: rcar-du: Add cubic LUT support

2020-12-20 Thread Laurent Pinchart
ingham (3): drm: rcar-du: cmm: Provide 3D-CLU support drm: Extend color correction to support 3D-CLU drm: rcar-du: kms: Configure the CLU Laurent Pinchart (1): drm: rcar-du: cmm: Refactor LUT configuration drivers/gpu/drm/drm_atomic_helper.c | 1 + drivers/gpu/drm/drm_atomic_st

[PATCH 1/4] drm: rcar-du: cmm: Refactor LUT configuration

2020-12-20 Thread Laurent Pinchart
To prepare for CLU support, expend the CMM API exposed to the DU driver to separate the LUT table pointer from the LUT update decision. This will be required, as we will need to update the LUT and CLU independently. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/rcar-du/rcar_cmm.c | 60

[PATCH 4/4] drm: rcar-du: kms: Configure the CLU

2020-12-20 Thread Laurent Pinchart
From: Kieran Bingham Link the DRM 3D-CLU configuration to the CMM setup configuration. Signed-off-by: Kieran Bingham Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 23 ++- 1 file changed, 18 insertions(+), 5 deletions(-) diff --git a/drivers

[PATCH 2/4] drm: rcar-du: cmm: Provide 3D-CLU support

2020-12-20 Thread Laurent Pinchart
specific color adjustment. Signed-off-by: Kieran Bingham Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/rcar-du/rcar_cmm.c | 52 -- drivers/gpu/drm/rcar-du/rcar_cmm.h | 11 --- 2 files changed, 57 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/rcar

[PATCH 3/4] drm: Extend color correction to support 3D-CLU

2020-12-20 Thread Laurent Pinchart
From: Kieran Bingham Extend the existing color management properties to support provision of a 3D cubic look up table, allowing for color specific adjustments. Signed-off-by: Kieran Bingham Co-developed-by: Laurent Pinchart Signed-off-by: Laurent Pinchart --- drivers/gpu/drm

Re: [PATCH 3/4] drm: Extend color correction to support 3D-CLU

2020-12-21 Thread Laurent Pinchart
Hi Daniel, On Mon, Dec 21, 2020 at 07:36:22PM +0100, Daniel Vetter wrote: > On Mon, Dec 21, 2020 at 2:57 AM Laurent Pinchart wrote: > > > > From: Kieran Bingham > > > > Extend the existing color management properties to support provision > > of a 3D cubic

Re: [PATCH] dt-bindings: Drop redundant maxItems/items

2020-12-21 Thread Laurent Pinchart
ist. > > A meta-schema check for this is pending once these existing cases are > fixed. > > Cc: Laurent Pinchart > Cc: Vinod Koul > Cc: Mark Brown > Cc: Greg Kroah-Hartman > Cc: Jassi Brar > Cc: dri-devel@lists.freedesktop.org > Cc: dmaeng...@vger.kernel.org

Re: [PATCH] dt-bindings: Drop unnecessary *-supply schemas properties

2020-12-21 Thread Laurent Pinchart
cases are > fixed. > > Cc: Jonathan Cameron > Cc: Dmitry Torokhov > Cc: Laurent Pinchart > Cc: Mauro Carvalho Chehab > Cc: Sakari Ailus > Cc: Lee Jones > Cc: Mark Brown > Cc: Maxime Ripard > Cc: dri-devel@lists.freedesktop.org > Cc: linux-...@v

Re: [PATCH 06/14] dt-bindings: display: bridge: Add i.MX8qm/qxp display pixel link binding

2020-12-21 Thread Laurent Pinchart
#address-cells = <1>; > +#size-cells = <0>; > +reg = <1>; > + > +dc0_pixel_link0_mipi_lvds_0_pxl2dpi: endpoint@0 { > +reg = <0>; > +remote-endpoint = <&mipi_lvds_0_pxl2dpi_dc0

Re: [PATCH 11/14] dt-bindings: display: bridge: Add i.MX8qm/qxp LVDS display bridge binding

2020-12-21 Thread Laurent Pinchart
0 { > + reg = <0>; > + > +mipi_lvds_0_ldb_ch0_mipi_lvds_0_pxl2dpi: endpoint { > +remote-endpoint = > <&mipi_lvds_0_pxl2dpi_mipi_lvds_0_ldb_ch0>; > +}; > +}; > +}; > + > +channel@1 { > +#address-cells = <1>; > +#size-cells = <0>; > +reg = <1>; > +phys = <&mipi_lvds_0_phy>; > +phy-names = "lvds_phy"; > + > +port@0 { > +reg = <0>; > + > +mipi_lvds_0_ldb_ch1_mipi_lvds_0_pxl2dpi: endpoint { > +remote-endpoint = > <&mipi_lvds_0_pxl2dpi_mipi_lvds_0_ldb_ch1>; > +}; > +}; > +}; > +}; -- Regards, Laurent Pinchart ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 11/14] dt-bindings: display: bridge: Add i.MX8qm/qxp LVDS display bridge binding

2020-12-21 Thread Laurent Pinchart
Hi Liu, On Tue, Dec 22, 2020 at 09:36:37AM +0200, Laurent Pinchart wrote: > On Thu, Dec 17, 2020 at 05:59:30PM +0800, Liu Ying wrote: > > This patch adds bindings for i.MX8qm/qxp LVDS display bridge(LDB). > > > > Signed-off-by: Liu Ying > > --- > > .../bi

Re: [PATCH 3/4] drm: Extend color correction to support 3D-CLU

2020-12-22 Thread Laurent Pinchart
Hi Kieran, On Mon, Dec 21, 2020 at 02:09:09PM +, Kieran Bingham wrote: > On 21/12/2020 01:57, Laurent Pinchart wrote: > > From: Kieran Bingham > > > > Extend the existing color management properties to support provision > > of a 3D cubic look up table,

Re: [PATCH v6] drm/bridge: add it6505 driver

2020-12-22 Thread Laurent Pinchart
PM > Cc: Jau-Chih Tseng (曾昭智); Hermes Wu (吳佳宏); Kenneth Hung (洪家倫); Allen Chen > (陳柏宇); Pi-Hsun Shih; Jitao Shi; Yilun Lin; Hermes Wu (吳佳宏); Andrzej Hajda; > Neil Armstrong; Laurent Pinchart; Jonas Karlman; Jernej Skrabec; David > Airlie; Daniel Vetter; Matthias Brugger; open list; open lis

Re: [PATCH] dt-bindings: Drop redundant maxItems/items

2020-12-23 Thread Laurent Pinchart
list length is redundant. 'maxItems' is > > > preferred for a single entry while greater than 1 should have an 'items' > > > list. > > > > > > A meta-schema check for this is pending once these existing cases are > > > fixed. > &g

Re: [PATCH v1 1/2] dt-bindings: drm/bridge: anx7625: add DPI flag and swing setting

2020-12-28 Thread Laurent Pinchart
f>, <0x0c 0x20>, <0x0d 0x60>, > +<0x10 0x60>, <0x12 0x40>, <0x13 0x60>, > +<0x14 0x14>, <0x15 0x54>, <0x16 0x64>, > +<0x17 0x74>, <0x18 0x29>, <0x19 0x7b>, > + &

Re: [PATCH v1 1/2] dt-bindings: drm/bridge: anx7625: add DPI flag and swing setting

2020-12-29 Thread Laurent Pinchart
Hi Xin Ji, On Tue, Dec 29, 2020 at 02:50:48PM +0800, Xin Ji wrote: > On Mon, Dec 28, 2020 at 05:08:56PM +0200, Laurent Pinchart wrote: > > On Fri, Dec 25, 2020 at 07:01:09PM +0800, Xin Ji wrote: > > > Add DPI flag for distinguish MIPI input signal type, DSI or DPI. Add >

Re: [PATCH] dt-bindings: display: Use OF graph schema

2021-01-04 Thread Laurent Pinchart
use video-interfaces.yaml once that lands. > > Cc: Thierry Reding > Cc: Sam Ravnborg > Cc: Laurent Pinchart > Cc: Maxime Ripard > Cc: Maarten Lankhorst > Cc: Thomas Zimmermann > Signed-off-by: Rob Herring Reviewed-by: Laurent Pinchart > --- > v3: > - Rework b

[GIT PULL FOR v5.12] R-Car DU and misc other changes

2021-01-04 Thread Laurent Pinchart
CI devices Fabrizio Castro (1): dt-bindings: display: bridge: renesas,lvds: RZ/G2E needs renesas,companion too Laurent Pinchart (20): dt-bindings: display: bridge: thc63lvd1024: Document dual-output mode drm: Add default modes for connectors in unknown state drm: rcar-du: Fix

Re: [PATCH v2 3/6] dt-bindings: display: imx: hdmi: Convert binding to YAML

2021-01-04 Thread Laurent Pinchart
Hi Philipp, On Mon, Jan 04, 2021 at 04:30:36PM +0100, Philipp Zabel wrote: > On Sun, 2020-12-20 at 21:50 +0200, Laurent Pinchart wrote: > > Convert the i.MX6 HDMI TX text binding to YAML. > > > > Signed-off-by: Laurent Pinchart > > --- > > Changes since v1: >

[PATCH v3 0/6] dt-bindings: display: Convert DWC HDMI TX bindings to YAML

2021-01-04 Thread Laurent Pinchart
spectively. Please let me know if you would prefer a different maintainer, or ack the respective patch if this is fine with you. Laurent Pinchart (6): dt-bindings: display: bridge: Add YAML schema for Synopsys DW-HDMI dt-bindings: display: bridge: renesas,dw-hdmi: Convert binding to YAML d

[PATCH v3 1/6] dt-bindings: display: bridge: Add YAML schema for Synopsys DW-HDMI

2021-01-04 Thread Laurent Pinchart
Add a .yaml schema containing the common properties for the Synopsys DesignWare HDMI TX controller. This isn't a full device tree binding specification, but is meant to be referenced by platform-specific bindings for the IP core. Signed-off-by: Laurent Pinchart --- Changes since v1:

<    2   3   4   5   6   7   8   9   10   11   >