Re: [PATCH] drm/i915: Switch TGL-H DP-IN to dGFX when it's supported

2022-08-16 Thread Karol Herbst
On Tue, Aug 16, 2022 at 4:53 AM Kai-Heng Feng wrote: > > On mobile workstations like HP ZBook Fury G8, iGFX's DP-IN can switch to > dGFX so external monitors are routed to dGFX, and more monitors can be > supported as result. > > To switch the DP-IN to dGFX, the driver needs to invoke _DSM functio

Re: [PATCH] drm/i915: Switch TGL-H DP-IN to dGFX when it's supported

2022-08-16 Thread Karol Herbst
On Wed, Aug 17, 2022 at 3:18 AM Kai-Heng Feng wrote: > > On Wed, Aug 17, 2022 at 2:50 AM Karol Herbst wrote: > > > > On Tue, Aug 16, 2022 at 4:53 AM Kai-Heng Feng > > wrote: > > > > > > On mobile workstations like HP ZBook Fury G8, iGFX's DP-IN ca

Re: [PATCH] drm/i915: Switch TGL-H DP-IN to dGFX when it's supported

2022-08-19 Thread Karol Herbst
On Thu, Aug 18, 2022 at 2:09 PM Lukas Wunner wrote: > > On Tue, Aug 16, 2022 at 11:06:18AM +0300, Jani Nikula wrote: > > On Tue, 16 Aug 2022, Kai-Heng Feng wrote: > > > On mobile workstations like HP ZBook Fury G8, iGFX's DP-IN can switch to > > > dGFX so external monitors are routed to dGFX, and

[PATCH] nouveau: explicitly wait on the fence in nouveau_bo_move_m2mf

2022-08-19 Thread Karol Herbst
It is a bit unlcear to us why that's helping, but it does and unbreaks suspend/resume on a lot of GPUs without any known drawbacks. Cc: sta...@vger.kernel.org # v5.15+ Closes: https://gitlab.freedesktop.org/drm/nouveau/-/issues/156 Signed-off-by: Karol Herbst --- drivers/gpu/drm/no

Rust in our code base

2022-08-20 Thread Karol Herbst
Hey everybody, so I think it's time to have this discussion for real. I am working on Rusticl (https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15439) which I would like to merge quite soon. Others might also plan on starting kernel drivers written in Rust (and if people feel comfortabl

Re: [PATCH] subdev/clk: fix repeated words in comments

2022-08-21 Thread Karol Herbst
Reviewed-by: Karol Herbst thanks, and I'll push in a moment. On Sun, Aug 21, 2022 at 4:34 PM wangjianli wrote: > > Delete the redundant word 'at'. > > Signed-off-by: wangjianli > --- > drivers/gpu/drm/nouveau/nvkm/subdev/clk/gm20b.c | 2 +- > 1 file

Re: Rust in our code base

2022-08-21 Thread Karol Herbst
On Sun, Aug 21, 2022 at 5:46 PM Rob Clark wrote: > > On Sat, Aug 20, 2022 at 5:23 AM Karol Herbst wrote: > > > > Hey everybody, > > > > so I think it's time to have this discussion for real. > > > > I am working on Rusticl > > (https://gi

Re: Rust in our code base

2022-08-21 Thread Karol Herbst
On Sun, Aug 21, 2022 at 8:34 PM Rob Clark wrote: > > On Sun, Aug 21, 2022 at 10:45 AM Karol Herbst wrote: > > > > On Sun, Aug 21, 2022 at 7:43 PM Karol Herbst wrote: > > > > > > On Sun, Aug 21, 2022 at 5:46 PM Rob Clark wrote: > > > > > > &

Re: Rust in our code base

2022-08-24 Thread Karol Herbst
On Wed, Aug 24, 2022 at 5:18 PM Jason Ekstrand wrote: > > +mesa-dev and my jlekstrand.net e-mail > > On Sun, 2022-08-21 at 20:44 +0200, Karol Herbst wrote: > > On Sun, Aug 21, 2022 at 8:34 PM Rob Clark > > wrote: > > > > > > On Sun, Aug 21,

Re: Rust in our code base

2022-08-24 Thread Karol Herbst
On Sun, Aug 21, 2022 at 7:43 PM Karol Herbst wrote: > > On Sun, Aug 21, 2022 at 5:46 PM Rob Clark wrote: > > > > On Sat, Aug 20, 2022 at 5:23 AM Karol Herbst wrote: > > > > > > Hey everybody, > > > > > > so I think it's time to have th

Re: [PATCH] drm/i915: Switch TGL-H DP-IN to dGFX when it's supported

2022-08-25 Thread Karol Herbst
On Wed, Aug 24, 2022 at 7:50 PM Kai-Heng Feng wrote: > > On Tue, Aug 16, 2022 at 4:06 PM Jani Nikula > wrote: > > > > On Tue, 16 Aug 2022, Kai-Heng Feng wrote: > > > On mobile workstations like HP ZBook Fury G8, iGFX's DP-IN can switch to > > > dGFX so external monitors are routed to dGFX, and

Re: [PATCH 06/23] drm/nouveau: stop using dma_resv_excl_fence

2022-04-04 Thread Karol Herbst
tion. > > > > Signed-off-by: Christian König > > Reviewed-by: Daniel Vetter > > Cc: Ben Skeggs > > Cc: Karol Herbst > > Cc: Lyude Paul > > Cc: nouv...@lists.freedesktop.org > > --- > > drivers/gpu/drm/nouveau/nouveau_bo.c | 9 - >

[PATCH] dma-buf-map: remove renamed header file

2022-04-11 Thread Karol Herbst
-intel-next") Cc: Rodrigo Vivi Cc: Lucas De Marchi Cc: dri-devel@lists.freedesktop.org Signed-off-by: Karol Herbst --- include/linux/dma-buf-map.h | 266 1 file changed, 266 deletions(-) delete mode 100644 include/linux/dma-buf-map.h diff --git a/include

Re: Rust in our code base

2022-09-08 Thread Karol Herbst
will merge Rusticl tomorrow or so unless somebody complains. On Wed, Aug 24, 2022 at 5:34 PM Karol Herbst wrote: > > On Wed, Aug 24, 2022 at 5:18 PM Jason Ekstrand > wrote: > > > > +mesa-dev and my jlekstrand.net e-mail > > > > On Sun, 2022-08-21 at 20:44 +0200,

Re: [PATCH] nouveau: explicitly wait on the fence in nouveau_bo_move_m2mf

2022-09-20 Thread Karol Herbst
On Tue, Sep 20, 2022 at 12:42 PM Salvatore Bonaccorso wrote: > > Hi, > > On Fri, Aug 19, 2022 at 10:09:28PM +0200, Karol Herbst wrote: > > It is a bit unlcear to us why that's helping, but it does and unbreaks > > suspend/resume on a lot of GPUs without any kno

Re: [PATCH v4] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges

2019-11-14 Thread Karol Herbst
ping on the patch. I wasn't able to verify this issue on any other bridge controller, so it really might be only this one. On Thu, Oct 17, 2019 at 2:19 PM Karol Herbst wrote: > > Fixes state transitions of Nvidia Pascal GPUs from D3cold into higher device > states. > > v2

[PATCH v3] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges

2019-10-16 Thread Karol Herbst
Fixes state transitions of Nvidia Pascal GPUs from D3cold into higher device states. v2: convert to pci_dev quirk put a proper technical explanation of the issue as a in-code comment v3: disable it only for certain combinations of intel and nvidia hardware Signed-off-by: Karol Herbst Cc

Re: [PATCH v3] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges

2019-10-16 Thread Karol Herbst
04:44:49PM +0200, Karol Herbst wrote: > > Fixes state transitions of Nvidia Pascal GPUs from D3cold into higher device > > states. > > > > v2: convert to pci_dev quirk > > put a proper technical explanation of the issue as a in-code comment > > v3: disable it on

Re: [PATCH v3] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges

2019-10-16 Thread Karol Herbst
On Wed, Oct 16, 2019 at 11:37 PM Bjorn Helgaas wrote: > > [+cc linux-acpi] > > On Wed, Oct 16, 2019 at 09:18:32PM +0200, Karol Herbst wrote: > > but setting the PCI_DEV_FLAGS_NO_D3 flag does prevent using the > > platform means of putting the device into D3cold, right?

[PATCH v4] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges

2019-10-17 Thread Karol Herbst
on the GPU itself Signed-off-by: Karol Herbst Cc: Bjorn Helgaas Cc: Lyude Paul Cc: Rafael J. Wysocki Cc: Mika Westerberg Cc: linux-...@vger.kernel.org Cc: linux...@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Cc: nouv...@lists.freedesktop.org --- drivers/pci/pci.c| 7

Re: [Nouveau] [PATCH 1/7] Revert "ACPI / OSI: Add OEM _OSI string to enable dGPU direct output"

2019-10-21 Thread Karol Herbst
fyi: I decided to go for a different workaround to fix the runpm issues observed with nvidia gpus with nouveau in the "pci: prevent putting nvidia GPUs into lower device states on certain intel bridges" thread that's on the pci and pm mailing list. Maybe it makes sense to wait for that to land bef

Re: [PATCH v3] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges

2019-10-21 Thread Karol Herbst
On Mon, Oct 21, 2019 at 1:40 PM Mika Westerberg wrote: > > Hi Karol, > > Sorry for commenting late, I just came back from vacation. > > On Wed, Oct 16, 2019 at 04:44:49PM +0200, Karol Herbst wrote: > > Fixes state transitions of Nvidia Pascal GPUs from D3cold into

Re: [PATCH v3] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges

2019-10-21 Thread Karol Herbst
On Mon, Oct 21, 2019 at 2:06 PM Mika Westerberg wrote: > > On Mon, Oct 21, 2019 at 02:00:46PM +0200, Karol Herbst wrote: > > On Mon, Oct 21, 2019 at 1:40 PM Mika Westerberg > > wrote: > > > > > > Hi Karol, > > > > > > Sorry for commenting la

Re: [PATCH v3] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges

2019-10-21 Thread Karol Herbst
On Mon, Oct 21, 2019 at 3:33 PM Mika Westerberg wrote: > > On Wed, Oct 16, 2019 at 11:48:22PM +0200, Karol Herbst wrote: > > On Wed, Oct 16, 2019 at 11:37 PM Bjorn Helgaas wrote: > > > > > > [+cc linux-acpi] > > > > > > On Wed, Oct 16, 2019 at 0

Re: [PATCH v3] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges

2019-10-21 Thread Karol Herbst
On Mon, Oct 21, 2019 at 4:09 PM Mika Westerberg wrote: > > On Mon, Oct 21, 2019 at 03:54:09PM +0200, Karol Herbst wrote: > > > I really would like to provide you more information about such > > > workaround but I'm not aware of any ;-) I have not seen any issues l

Re: [PATCH v3] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges

2019-10-22 Thread Karol Herbst
opefully I'll find something I overlooked the last time. On Mon, Oct 21, 2019 at 6:40 PM Karol Herbst wrote: > > On Mon, Oct 21, 2019 at 5:46 PM Mika Westerberg > wrote: > > > > On Mon, Oct 21, 2019 at 04:49:09PM +0200, Karol Herbst wrote: > > > On Mon, Oct 21, 2019 at

Re: [PATCH v3] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges

2019-10-22 Thread Karol Herbst
On Tue, Oct 22, 2019 at 2:45 PM Mika Westerberg wrote: > > On Tue, Oct 22, 2019 at 11:16:14AM +0200, Karol Herbst wrote: > > I think there is something I totally forgot about: > > > > When there was never a driver bound to the GPU, and if runtime power > > manageme

[PATCH v6] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges

2020-03-03 Thread Karol Herbst
on the GPU itself v5: restructure quirk to make it easier to add new IDs fix whitespace issues fix potential NULL pointer access update the quirk documentation v6: move quirk into nouveau Signed-off-by: Karol Herbst Cc: Bjorn Helgaas Cc: Lyude Paul Cc: Rafael J. Wysocki Cc: Mika

Re: [PATCH v6] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges

2020-03-05 Thread Karol Herbst
On Wed, Mar 4, 2020 at 10:33 AM Mika Westerberg wrote: > > Hi, > > On Tue, Mar 03, 2020 at 11:10:52AM +0100, Karol Herbst wrote: > > Fixes state transitions of Nvidia Pascal GPUs from D3cold into higher device > > states. > > I think it is good to explain bit mo

[PATCH v7] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges

2020-03-10 Thread Karol Herbst
annoying issue for user having to choose between a crashing kernel or higher power consumption of their Laptops. Signed-off-by: Karol Herbst Cc: Bjorn Helgaas Cc: Lyude Paul Cc: Rafael J. Wysocki Cc: Mika Westerberg Cc: linux-...@vger.kernel.org Cc: linux...@vger.kernel.org Cc:

Re: [PATCH v7] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges

2020-03-20 Thread Karol Herbst
On Fri, Mar 20, 2020 at 11:19 PM Bjorn Helgaas wrote: > > On Tue, Mar 10, 2020 at 08:26:27PM +0100, Karol Herbst wrote: > > Fixes the infamous 'runtime PM' bug many users are facing on Laptops with > > Nvidia Pascal GPUs by skipping said PCI power state changes on t

Re: [PATCH v4] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges

2020-01-13 Thread Karol Herbst
ernal ACPI memory... so, anybody with any other ideas? I really wished the nvidia driver would enable runpm on pre turing GPUs, but that's sadly not the case and on Turing things seem to be totally different, so it wouldn't help to check there as well... *sigh* On Tue, Dec 10, 2019 at

[RFC PATCH] pci: prevent putting pcie devices into lower device states on certain intel bridges

2019-09-27 Thread Karol Herbst
ug_test.py Signed-off-by: Karol Herbst Cc: Bjorn Helgaas Cc: Lyude Paul Cc: linux-...@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Cc: nouv...@lists.freedesktop.org --- drivers/pci/pci.c | 39 +++ 1 file changed, 39 insertions(+) diff --git a/drivers/pci/

Re: [RFC PATCH] pci: prevent putting pcie devices into lower device states on certain intel bridges

2019-09-27 Thread Karol Herbst
On Fri, Sep 27, 2019 at 11:42 PM Bjorn Helgaas wrote: > > [+cc Rafael, Mika, linux-pm] > > On Fri, Sep 27, 2019 at 04:44:21PM +0200, Karol Herbst wrote: > > Fixes runpm breakage mainly on Nvidia GPUs as they are not able to resume. > > I don't know what runpm is. So

Re: [RFC PATCH] pci: prevent putting pcie devices into lower device states on certain intel bridges

2019-09-30 Thread Karol Herbst
On Mon, Sep 30, 2019 at 10:05 AM Mika Westerberg wrote: > > Hi Karol, > > On Fri, Sep 27, 2019 at 11:53:48PM +0200, Karol Herbst wrote: > > > What exactly is the serious issue? I guess it's that the rescan > > > doesn't detect the GPU, which means it&#

Re: [RFC PATCH] pci: prevent putting pcie devices into lower device states on certain intel bridges

2019-09-30 Thread Karol Herbst
updated patch shortly. On Mon, Sep 30, 2019 at 11:29 AM Mika Westerberg wrote: > > On Mon, Sep 30, 2019 at 11:15:48AM +0200, Karol Herbst wrote: > > On Mon, Sep 30, 2019 at 10:05 AM Mika Westerberg > > wrote: > > > > > > Hi Karol, > > > > > >

Re: [RFC PATCH] pci: prevent putting pcie devices into lower device states on certain intel bridges

2019-09-30 Thread Karol Herbst
On Mon, Sep 30, 2019 at 6:30 PM Mika Westerberg wrote: > > On Mon, Sep 30, 2019 at 06:05:14PM +0200, Karol Herbst wrote: > > still happens with your patch applied. The machine simply gets shut down. > > > > dmesg can be found here: > > https://gist.git

[RFC PATCH] pci: prevent putting pcie devices into lower device states on certain intel bridges

2019-09-30 Thread Karol Herbst
of loading nouveau: https://raw.githubusercontent.com/karolherbst/pci-stub-runpm/master/nv_runpm_bug_test.py Signed-off-by: Karol Herbst Cc: Bjorn Helgaas Cc: Lyude Paul Cc: Rafael J. Wysocki Cc: Mika Westerberg Cc: linux-...@vger.kernel.org Cc: linux...@vger.kernel.org Cc: dri-devel@lists

Re: [RFC PATCH] pci: prevent putting pcie devices into lower device states on certain intel bridges

2019-10-01 Thread Karol Herbst
On Tue, Oct 1, 2019 at 10:47 AM Mika Westerberg wrote: > > On Mon, Sep 30, 2019 at 06:36:12PM +0200, Karol Herbst wrote: > > On Mon, Sep 30, 2019 at 6:30 PM Mika Westerberg > > wrote: > > > > > > On Mon, Sep 30, 2019 at 06:05:14PM +0200, Karol Herbst wrote: &

Re: [RFC PATCH] pci: prevent putting pcie devices into lower device states on certain intel bridges

2019-10-01 Thread Karol Herbst
On Tue, Oct 1, 2019 at 11:11 AM Mika Westerberg wrote: > > On Tue, Oct 01, 2019 at 10:56:39AM +0200, Karol Herbst wrote: > > On Tue, Oct 1, 2019 at 10:47 AM Mika Westerberg > > wrote: > > > > > > On Mon, Sep 30, 2019 at 06:36:12PM +0200, Karol Herbst wrote:

Re: [RFC PATCH] pci: prevent putting pcie devices into lower device states on certain intel bridges

2019-10-01 Thread Karol Herbst
On Tue, Oct 1, 2019 at 3:27 PM Bjorn Helgaas wrote: > > On Mon, Sep 30, 2019 at 06:36:12PM +0200, Karol Herbst wrote: > > On Mon, Sep 30, 2019 at 6:30 PM Mika Westerberg > > wrote: > > > > > > On Mon, Sep 30, 2019 at 06:05:14PM +0200, Karol Herbst wrote: &

Re: [PATCH v4] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges

2019-11-19 Thread Karol Herbst
On Tue, Nov 19, 2019 at 10:50 PM Bjorn Helgaas wrote: > > [+cc Dave] > > On Thu, Oct 17, 2019 at 02:19:01PM +0200, Karol Herbst wrote: > > Fixes state transitions of Nvidia Pascal GPUs from D3cold into higher device > > states. > > > > v2: convert to pci_dev

Re: [PATCH v4] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges

2019-11-20 Thread Karol Herbst
; > wrote: > > > > > > > > Hi Karol, > > > > > > > > On Tue, Nov 19, 2019 at 11:26:45PM +0100, Karol Herbst wrote: > > > > > On Tue, Nov 19, 2019 at 10:50 PM Bjorn Helgaas > > > > > wrote: > > > > > >

Re: [PATCH v4] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges

2019-11-20 Thread Karol Herbst
for newer Windows the firmware uses bit 0x80 on 0x248 (Q0L2 being the field name) on the bridge controller to turn of the device, on other versions it uses the "older"? 0xb0 register and the P0LD field, which is documented, where the former is not. On Wed, Nov 20, 2019 at 12:51 PM Mika Westerberg

Re: [PATCH v4] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges

2019-11-20 Thread Karol Herbst
n Wed, Nov 20, 2019 at 12:54 PM Karol Herbst wrote: > > for newer Windows the firmware uses bit 0x80 on 0x248 (Q0L2 being the > field name) on the bridge controller to turn of the device, on other > versions it uses the "older"? 0xb0 register and the P0LD field, which > i

Re: [PATCH v4] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges

2019-11-20 Thread Karol Herbst
On Wed, Nov 20, 2019 at 1:06 PM Rafael J. Wysocki wrote: > > On Wed, Nov 20, 2019 at 12:51 PM Karol Herbst wrote: > > > > On Wed, Nov 20, 2019 at 12:48 PM Rafael J. Wysocki > > wrote: > > > > > > On Wed, Nov 20, 2019 at 12:22 PM Mika Westerberg &g

Re: [PATCH v4] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges

2019-11-20 Thread Karol Herbst
On Wed, Nov 20, 2019 at 1:09 PM Mika Westerberg wrote: > > On Wed, Nov 20, 2019 at 12:58:00PM +0100, Karol Herbst wrote: > > overall, what I really want to know is, _why_ does it work on windows? > > So do I ;-) > > > Or what are we doing differently on Linux

Re: [PATCH v4] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges

2019-11-20 Thread Karol Herbst
It depends on the kernel being built with ACPI_REV_OVERRIDE_POSSIBLE=y and acpi_rev_override=1 being set on the kernel command line On Wed, Nov 20, 2019 at 1:15 PM Rafael J. Wysocki wrote: > > On Wed, Nov 20, 2019 at 1:10 PM Karol Herbst wrote: > > > > On Wed, Nov 20, 2019 a

Re: [PATCH v4] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges

2019-11-20 Thread Karol Herbst
On Wed, Nov 20, 2019 at 4:15 PM Mika Westerberg wrote: > > On Wed, Nov 20, 2019 at 01:11:52PM +0100, Karol Herbst wrote: > > On Wed, Nov 20, 2019 at 1:09 PM Mika Westerberg > > wrote: > > > > > > On Wed, Nov 20, 2019 at 12:58:00PM +0100, Karol Herbst wrote: &g

Re: [PATCH v4] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges

2019-11-20 Thread Karol Herbst
wrote: > > On Wed, Nov 20, 2019 at 04:37:14PM +0100, Karol Herbst wrote: > > > On Wed, Nov 20, 2019 at 4:15 PM Mika Westerberg > > > wrote: > > > > > > > > On Wed, Nov 20, 2019 at 01:11:52PM +0100, Karol Herbst wrote: > > > >

Re: [PATCH v4] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges

2019-11-20 Thread Karol Herbst
On Wed, Nov 20, 2019 at 10:37 PM Rafael J. Wysocki wrote: > > On Wed, Nov 20, 2019 at 4:53 PM Mika Westerberg > wrote: > > > > On Wed, Nov 20, 2019 at 04:37:14PM +0100, Karol Herbst wrote: > > > On Wed, Nov 20, 2019 at 4:15 PM Mika Westerberg > > > wrote:

Re: [PATCH v4] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges

2019-11-21 Thread Karol Herbst
On Thu, Nov 21, 2019 at 12:46 PM Mika Westerberg wrote: > > On Thu, Nov 21, 2019 at 12:34:22PM +0100, Rafael J. Wysocki wrote: > > On Thu, Nov 21, 2019 at 12:28 PM Mika Westerberg > > wrote: > > > > > > On Wed, Nov 20, 2019 at 11:29:33PM +0100, Rafael J. Wysocki wrote: > > > > > last week or so I

Re: [PATCH v4] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges

2019-11-21 Thread Karol Herbst
On Thu, Nov 21, 2019 at 1:52 PM Mika Westerberg wrote: > > On Thu, Nov 21, 2019 at 01:46:14PM +0200, Mika Westerberg wrote: > > On Thu, Nov 21, 2019 at 12:34:22PM +0100, Rafael J. Wysocki wrote: > > > On Thu, Nov 21, 2019 at 12:28 PM Mika Westerberg > > > wrote: > > > > > > > > On Wed, Nov 20, 20

Re: [PATCH v4] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges

2019-11-21 Thread Karol Herbst
On Thu, Nov 21, 2019 at 4:47 PM Rafael J. Wysocki wrote: > > On Thu, Nov 21, 2019 at 1:53 PM Karol Herbst wrote: > > > > On Thu, Nov 21, 2019 at 12:46 PM Mika Westerberg > > wrote: > > > > > > On Thu, Nov 21, 2019 at 12:34:22PM +0100, Rafael J. Wysocki

Re: [PATCH v4] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges

2019-11-21 Thread Karol Herbst
On Thu, Nov 21, 2019 at 11:39 PM Rafael J. Wysocki wrote: > > On Thu, Nov 21, 2019 at 8:49 PM Mika Westerberg > wrote: > > > > On Thu, Nov 21, 2019 at 04:43:24PM +0100, Rafael J. Wysocki wrote: > > > On Thu, Nov 21, 2019 at 1:52 PM Mika Westerberg > > > wrote: > > > > > > > > On Thu, Nov 21, 201

Re: [PATCH v4] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges

2019-11-21 Thread Karol Herbst
so while trying to test with d3cold disabled, I noticed that I run into the exact same error. And I verified that the \_SB.PCI0.PEG0.PG00._STA returns 1, which indicates it should still be turned on. On Thu, Nov 21, 2019 at 11:50 PM Karol Herbst wrote: > > On Thu, Nov 21, 2019 at 11:39 PM

[PATCH v5] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges

2019-11-21 Thread Karol Herbst
on the GPU itself v5: restructure quirk to make it easier to add new IDs fix whitespace issues fix potential NULL pointer access update the quirk documentation Signed-off-by: Karol Herbst Cc: Bjorn Helgaas Cc: Lyude Paul Cc: Rafael J. Wysocki Cc: Mika Westerberg Cc: linux

Re: [PATCH v4] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges

2019-11-22 Thread Karol Herbst
On Fri, Nov 22, 2019 at 10:07 AM Rafael J. Wysocki wrote: > > On Fri, Nov 22, 2019 at 1:13 AM Karol Herbst wrote: > > > > so while trying to test with d3cold disabled, I noticed that I run > > into the exact same error. > > Does this mean that you disabled d3

Re: [PATCH v4] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges

2019-11-22 Thread Karol Herbst
On Fri, Nov 22, 2019 at 12:30 PM Rafael J. Wysocki wrote: > > On Fri, Nov 22, 2019 at 11:36 AM Mika Westerberg > wrote: > > > > On Thu, Nov 21, 2019 at 11:39:23PM +0100, Rafael J. Wysocki wrote: > > > On Thu, Nov 21, 2019 at 8:49 PM Mika Westerberg > > > wrote: > > > > > > > > On Thu, Nov 21, 20

Re: [PATCH v4] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges

2019-11-27 Thread Karol Herbst
On Wed, Nov 27, 2019 at 12:49 PM Mika Westerberg wrote: > > On Tue, Nov 26, 2019 at 06:10:36PM -0500, Lyude Paul wrote: > > Hey-this is almost certainly not the right place in this thread to respond, > > but this thread has gotten so deep evolution can't push the subject further > > to > > the ri

Re: [PATCH v4] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges

2019-12-09 Thread Karol Herbst
ers having similar issues to the one Lyude told us about... and I couldn't verify that the patches help there either in a reliable way. On Wed, Nov 27, 2019 at 8:55 PM Lyude Paul wrote: > > On Wed, 2019-11-27 at 12:51 +0100, Karol Herbst wrote: > > On Wed, Nov 27, 2019 at 12:49 PM

Re: [PATCH v4] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges

2019-12-09 Thread Karol Herbst
On Mon, Dec 9, 2019 at 12:39 PM Rafael J. Wysocki wrote: > > On Mon, Dec 9, 2019 at 12:17 PM Karol Herbst wrote: > > > > anybody any other ideas? > > Not yet, but I'm trying to collect some more information. > > > It seems that both patches don't reall

Re: [PATCH v4] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges

2019-12-10 Thread Karol Herbst
On Tue, Dec 10, 2019 at 8:58 PM Dave Airlie wrote: > > On Mon, 9 Dec 2019 at 21:39, Rafael J. Wysocki wrote: > > > > On Mon, Dec 9, 2019 at 12:17 PM Karol Herbst wrote: > > > > > > anybody any other ideas? > > > > Not yet, but I'm trying to c

Re: [PATCH] drm/nouveau: add missing single_release()

2019-09-05 Thread Karol Herbst
Reviewed-by: Karol Herbst On Thu, Sep 5, 2019 at 9:14 AM Wei Yongjun wrote: > > When using single_open() for opening, single_release() should be > used, otherwise there is a memory leak. > > This is detected by Coccinelle semantic patch. > > Fixes: 6e9fc177399f ("drm

Re: [Nouveau] [PATCH 1/7] Revert "ACPI / OSI: Add OEM _OSI string to enable dGPU direct output"

2019-09-05 Thread Karol Herbst
, August 15, 2019 12:47:35 AM CEST Dave Airlie wrote: > > On Thu, 15 Aug 2019 at 07:31, Karol Herbst wrote: > > > > > > This reverts commit 28586a51eea666d5531bcaef2f68e4abbd87242c. > > > > > > The original commit message didn't even make sense. AMD _does_

[PATCH 1/7] Revert "ACPI / OSI: Add OEM _OSI string to enable dGPU direct output"

2019-08-14 Thread Karol Herbst
;t the way we do things. And even if it means a muxed design, then the fix is to make it work inside the driver, not adding some hacky workaround through ACPI tricks. And what out of tree drivers do or do not support we don't care one bit anyway. Signed-off-by: Karol Herbst CC: Alex Hun

[PATCH 3/7] Revert "ACPI / OSI: Add OEM _OSI strings to disable NVidia RTD3"

2019-08-14 Thread Karol Herbst
ution feels like they have to please companies not wanting to be part of the linux community, please do so downstream and don't try to push something like this upstream. Signed-off-by: Karol Herbst CC: Alex Hung CC: Rafael J. Wysocki CC: Dave Airlie CC: Lyude Paul CC: Ben Skeggs --- dr

[PATCH 2/7] Revert "ACPI / OSI: Add OEM _OSI string to enable NVidia HDMI audio"

2019-08-14 Thread Karol Herbst
quired a proper fix first, but we have that now. Signed-off-by: Karol Herbst CC: Alex Hung CC: Rafael J. Wysocki CC: Dave Airlie CC: Lyude Paul CC: Ben Skeggs --- drivers/acpi/osi.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/acpi/osi.c b/drivers/acpi/osi.c ind

[PATCH 4/7] drm/nouveau/pci: enable pcie link changes for pascal

2019-08-14 Thread Karol Herbst
Signed-off-by: Karol Herbst Reviewed-by: Lyude Paul CC: Alex Hung CC: Rafael J. Wysocki CC: Dave Airlie CC: Lyude Paul CC: Ben Skeggs --- drivers/gpu/drm/nouveau/nvkm/subdev/pci/gk104.c | 8 drivers/gpu/drm/nouveau/nvkm/subdev/pci/gp100.c | 10 ++ drivers/gpu/drm/nouveau

[PATCH 7/7] drm/nouveau: abort runtime suspend if we hit an error

2019-08-14 Thread Karol Herbst
Signed-off-by: Karol Herbst CC: Alex Hung CC: Rafael J. Wysocki CC: Dave Airlie CC: Lyude Paul CC: Ben Skeggs --- drivers/gpu/drm/nouveau/nouveau_drm.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/nouveau/nouveau_drm.c b/drivers/gpu/drm/nouveau/nouveau_drm.c

[PATCH 0/7] Adding a proper workaround for fixing RTD3 issues with Nouveau

2019-08-14 Thread Karol Herbst
e the issues don't get fixed. Karol Herbst (7): Revert "ACPI / OSI: Add OEM _OSI string to enable dGPU direct output" Revert "ACPI / OSI: Add OEM _OSI string to enable NVidia HDMI audio" Revert "ACPI / OSI: Add OEM _OSI strings to disable NVidia RTD3" d

[PATCH 5/7] drm/nouveau/pci: add nvkm_pcie_get_speed

2019-08-14 Thread Karol Herbst
v2: fixed compilation error Signed-off-by: Karol Herbst Reviewed-by: Lyude Paul CC: Alex Hung CC: Rafael J. Wysocki CC: Dave Airlie CC: Lyude Paul CC: Ben Skeggs --- drivers/gpu/drm/nouveau/include/nvkm/subdev/pci.h | 1 + drivers/gpu/drm/nouveau/nvkm/subdev/pci/pcie.c| 8 2

[PATCH 6/7] drm/nouveau/pci: save the boot pcie link speed and restore it on fini

2019-08-14 Thread Karol Herbst
doing that outside of drivers? v2: squashed together patch 4 and 5 v3: only restore pcie speed on machines with runpm add NvRunpmWorkaround config option to disable the workaround Signed-off-by: Karol Herbst Reviewed-by: Lyude Paul (v2) CC: Alex Hung CC: Rafael J. Wysocki CC: Dave Airlie CC

Re: [PATCH 3/7] Revert "ACPI / OSI: Add OEM _OSI strings to disable NVidia RTD3"

2019-08-14 Thread Karol Herbst
On Thu, Aug 15, 2019 at 1:35 AM Alex Hung wrote: > > On Wed, Aug 14, 2019 at 3:31 PM Karol Herbst wrote: > > > > This reverts commit 9251a71db62ca9cc7e7cf364218610b0f018c291. > > > > This was never discussed with anybody Nouveau related and we would have > >

Re: [Nouveau] [PATCH 1/7] Revert "ACPI / OSI: Add OEM _OSI string to enable dGPU direct output"

2019-08-15 Thread Karol Herbst
On Thu, Aug 15, 2019 at 3:56 PM wrote: > > > -Original Message- > > From: linux-acpi-ow...@vger.kernel.org On > > Behalf Of Dave Airlie > > Sent: Wednesday, August 14, 2019 5:48 PM > > To: Karol Herbst > > Cc: LKML; Linux ACPI; dri-devel; nouv

Re: [Nouveau] [PATCH 1/7] Revert "ACPI / OSI: Add OEM _OSI string to enable dGPU direct output"

2019-08-15 Thread Karol Herbst
On Thu, Aug 15, 2019 at 4:13 PM Alex Deucher wrote: > > On Thu, Aug 15, 2019 at 10:04 AM Karol Herbst wrote: > > > > On Thu, Aug 15, 2019 at 3:56 PM wrote: > > > > > > > -Original Message- > > > > From: linux-acpi-ow...@vger.ke

Re: [Nouveau] [PATCH 1/7] Revert "ACPI / OSI: Add OEM _OSI string to enable dGPU direct output"

2019-08-15 Thread Karol Herbst
On Thu, Aug 15, 2019 at 4:20 PM wrote: > > > > There are definitely going to be regressions on machines in the field > > > with the > > > in tree drivers by reverting this. I think we should have an answer for > > > all of > > those > > > before this revert is accepted. > > > > > > Regarding sy

Re: [Nouveau] [PATCH 1/7] Revert "ACPI / OSI: Add OEM _OSI string to enable dGPU direct output"

2019-08-15 Thread Karol Herbst
On Thu, Aug 15, 2019 at 4:30 PM wrote: > > > On Thu, Aug 15, 2019 at 10:15 AM Karol Herbst wrote: > > > > > > On Thu, Aug 15, 2019 at 4:13 PM Alex Deucher > > wrote: > > > > > > > > On Thu, Aug 15, 2019 at 10:04 AM Karol Herbst > &

Re: [Nouveau] [PATCH 1/7] Revert "ACPI / OSI: Add OEM _OSI string to enable dGPU direct output"

2019-08-15 Thread Karol Herbst
On Thu, Aug 15, 2019 at 4:34 PM wrote: > > > -Original Message- > > From: Karol Herbst > > Sent: Thursday, August 15, 2019 9:25 AM > > To: Limonciello, Mario > > Cc: Dave Airlie; LKML; Linux ACPI Mailing List; dri-devel; nouveau; Rafael > > J . &g

Re: [Nouveau] [PATCH 11/34] drm/nouveau/nvkm/subdev/mc/tu102: Make functions called by reference static

2021-05-26 Thread Karol Herbst
t; spin_unlock_irqrestore(&mc->lock, flags); > } > > -void > +static void > tu102_mc_intr_mask(struct nvkm_mc *base, u32 mask, u32 intr) > { > struct tu102_mc *mc = tu102_mc(base); > -- > 2.31.1 > > ___ > Nouveau mailing list > nouv...@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/nouveau Reviewed-by: Karol Herbst

Re: [Nouveau] [PATCH RESEND][next] drm/nouveau: Fix fall-through warnings for Clang

2021-06-01 Thread Karol Herbst
all three nouveau patches are Reviewed-by: Karol Herbst and I don't think anybody would mind if those get into through other trees, but maybe drm-mist would be a good place for it if other patches involve other drm drivers? On Wed, Jun 2, 2021 at 1:16 AM Gustavo A. R. Silva wrote: &

Re: [PATCH v2 1/2] documentation: Update #nouveau IRC channel network

2021-06-09 Thread Karol Herbst
nquiries, please ping mupuf on IRC (#nouveau, freenode). > +inquiries, please ping mupuf on IRC (#nouveau, OFTC). > > Bug reports should be filled on Freedesktop's bug tracker. Please follow > https://nouveau.freedesktop.org/wiki/Bugs > -- > 2.30.2 > Reviewed-by: Karol Herbst

Re: [PATCH] remove unused varialble "struct device *dev"

2021-06-23 Thread Karol Herbst
On Tue, Jun 22, 2021 at 5:14 PM Cai Huoqing wrote: > > fix the warning- variable 'dev' set but not used > the patch title needs a prefix to indicate which subsystem it belongs to. Check git log for examples. With that fixed: Reviewed-by: Karol Herbst > Sign

Re: linux-6.2-rc4+ hangs on poweroff/reboot: Bisected

2023-01-27 Thread Karol Herbst
Where was the original email sent to anyway, because I don't have it at all. Anyhow, I suspect we want to fetch logs to see what's happening, but due to the nature of this bug it might get difficult. I'm checking out the laptops I have here if I can reproduce this issue, but I think all mine with

Re: linux-6.2-rc4+ hangs on poweroff/reboot: Bisected

2023-02-10 Thread Karol Herbst
On Fri, Feb 10, 2023 at 7:35 PM Linux regression tracking (Thorsten Leemhuis) wrote: > > On 08.02.23 09:48, Chris Clayton wrote: > > > > I'm assuming that we are not going to see a fix for this regression before > > 6.2 is released. > > Yeah, looks like it. That's unfortunate, but happens. But t

Re: linux-6.2-rc4+ hangs on poweroff/reboot: Bisected

2023-02-15 Thread Karol Herbst
t; >>> > >>> > >>> On 10/02/2023 19:33, Linux regression tracking (Thorsten Leemhuis) wrote: > >>>> On 10.02.23 20:01, Karol Herbst wrote: > >>>>> On Fri, Feb 10, 2023 at 7:35 PM Linux regression tracking (Thorsten > >>>&

Re: linux-6.2-rc4+ hangs on poweroff/reboot: Bisected

2023-02-18 Thread Karol Herbst
On Sat, Feb 18, 2023 at 1:22 PM Chris Clayton wrote: > > > > On 15/02/2023 11:09, Karol Herbst wrote: > > On Wed, Feb 15, 2023 at 11:36 AM Linux regression tracking #update > > (Thorsten Leemhuis) wrote: > >> > >> On 13.02.23 10:14, Chris Clayton wro

Re: linux-6.2-rc4+ hangs on poweroff/reboot: Bisected

2023-02-20 Thread Karol Herbst
On Mon, Feb 20, 2023 at 11:51 AM Chris Clayton wrote: > > > > On 20/02/2023 05:35, Ben Skeggs wrote: > > On Sun, 19 Feb 2023 at 04:55, Chris Clayton > > wrote: > >> > >> > >> > >> On 18/02/2023 15:19, Chris Clayton wrote: > >>

Re: [PATCH] drm/nouveau/fifo: set gf100_fifo_nonstall_block_dump storage-class-specifier to static

2023-03-03 Thread Karol Herbst
Reviewed-by: Karol Herbst will push in a moment On Fri, Mar 3, 2023 at 2:27 PM Tom Rix wrote: > > gcc with W=1 reports > drivers/gpu/drm/nouveau/nvkm/engine/fifo/gf100.c:451:1: error: > no previous prototype for ‘gf100_fifo_nonstall_block’ > [-Werror=missing-prot

Re: [PATCH] drm/nouveau/nvfw/acr: set wpr_generic_header_dump storage-class-specifier to static

2023-03-03 Thread Karol Herbst
Reviewed-by: Karol Herbst will push in a moment On Thu, Mar 2, 2023 at 1:48 PM Tom Rix wrote: > > gcc with W=1 reports > drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c:49:1: error: no previous > prototype for ‘wpr_generic_header_dump’ [-Werror=missing-prototypes] >49 | wpr_gene

Re: [PATCH] drm/nouveau/fifo: set nvkm_engn_cgrp_get storage-class-specifier to static

2023-03-03 Thread Karol Herbst
Reviewed-by: Karol Herbst will push in a moment On Tue, Feb 28, 2023 at 11:15 PM Tom Rix wrote: > > smatch reports > drivers/gpu/drm/nouveau/nvkm/engine/fifo/runl.c:33:18: > warning: symbol 'nvkm_engn_cgrp_get' was not declared. Should it be static? > > nvkm_e

Re: [PATCH RFC 01/18] rust: drm: ioctl: Add DRM ioctl abstraction

2023-03-07 Thread Karol Herbst
On Tue, Mar 7, 2023 at 3:27 PM Asahi Lina wrote: > > DRM drivers need to be able to declare which driver-specific ioctls they > support. This abstraction adds the required types and a helper macro to > generate the ioctl definition inside the DRM driver. > > Note that this macro is not usable unti

Re: [PATCH RFC 01/18] rust: drm: ioctl: Add DRM ioctl abstraction

2023-03-07 Thread Karol Herbst
On Tue, Mar 7, 2023 at 3:48 PM Karol Herbst wrote: > > On Tue, Mar 7, 2023 at 3:27 PM Asahi Lina wrote: > > > > DRM drivers need to be able to declare which driver-specific ioctls they > > support. This abstraction adds the required types and a helper macro to > >

Re: [PATCH RFC 15/18] drm/asahi: Add the Asahi driver UAPI [DO NOT MERGE]

2023-03-07 Thread Karol Herbst
On Tue, Mar 7, 2023 at 3:28 PM Asahi Lina wrote: > > Adds the Asahi GPU driver UAPI. Note: this API is not yet stable and > therefore not ready for merging! > > Signed-off-by: Asahi Lina > --- > include/uapi/drm/asahi_drm.h | 556 > +++ > 1 file changed,

Re: [PATCH RFC 10/18] drm/scheduler: Add can_run_job callback

2023-03-08 Thread Karol Herbst
On Wed, Mar 8, 2023 at 9:46 AM Christian König wrote: > > Am 07.03.23 um 15:25 schrieb Asahi Lina: > > Some hardware may require more complex resource utilization accounting > > than the simple job count supported by drm_sched internally. Add a > > can_run_job callback to allow drivers to implemen

Re: [PATCH RFC 10/18] drm/scheduler: Add can_run_job callback

2023-03-08 Thread Karol Herbst
On Wed, Mar 8, 2023 at 2:47 PM Christian König wrote: > > Am 08.03.23 um 13:39 schrieb Karol Herbst: > > On Wed, Mar 8, 2023 at 9:46 AM Christian König > > wrote: > >> Am 07.03.23 um 15:25 schrieb Asahi Lina: > >>> Some hardware may require more

Re: [PATCH RFC 10/18] drm/scheduler: Add can_run_job callback

2023-03-08 Thread Karol Herbst
On Wed, Mar 8, 2023 at 4:09 PM Christian König wrote: > > Am 08.03.23 um 15:43 schrieb Karol Herbst: > > [SNIP] > > "further"? There was no discussion at all, > > Yeah, well that is exactly what I wanted to archive. > > > you just started off like

Re: [PATCH] drm/nouveau: Remove support for legacy contexts/buffers

2023-01-12 Thread Karol Herbst
ps://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=7c510133d93dd6f15ca040733ba7b2891ed61fd1 > # 1 > Link: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=c21eb21cb50d58e7cbdcb8b9e7ff68b85cfa5095 > # 2 Reviewed-by: Karol Herbst

Re: [REGRESSION] GM20B probe fails after commit 2541626cfb79

2023-01-13 Thread Karol Herbst
On Fri, Jan 13, 2023 at 2:19 PM Linux kernel regression tracking (Thorsten Leemhuis) wrote: > > [CCing Daniel] > > On 05.01.23 13:28, Thorsten Leemhuis wrote: > > [adding Karol and Lyude to the list of recipients] > > > > On 28.12.22 15:49, Diogo Ivo wrote: > >> Hello, > >> > >> Commit 2541626cfb7

Re: [REGRESSION] GM20B probe fails after commit 2541626cfb79

2023-01-14 Thread Karol Herbst
On Sat, Jan 14, 2023 at 5:07 PM Diogo Ivo wrote: > > On Sat, Jan 14, 2023 at 04:27:38AM +0100, Karol Herbst wrote: > > I tried to look into it, but my jetson nano, just constantly behaves > > in very strange ways. I tried to compile and install a 6.1 kernel onto > >

<    1   2   3   4   5   >