hey thanks for the report.
This is a known issue and the fix is pending in drm-mist-fixes and
should land in 5.14 soonish.
On Thu, Jul 22, 2021 at 9:29 PM Ondrej Zary wrote:
>
> Hello,
> nouveau is broken again:
>
> [ 58.795794] BUG: kernel NULL pointer dereference, address: 017c
> [ 58.
On Fri, Jul 23, 2021 at 11:24 AM Daniel Vetter wrote:
>
> On Fri, Jul 23, 2021 at 11:15 AM Arnd Bergmann wrote:
> >
> > From: Arnd Bergmann
> >
> > When the backlight support is disabled, the driver fails to build:
> >
> > drivers/gpu/drm/nouveau/dispnv50/disp.c: In function
> > 'nv50_sor_atomi
On Fri, Jul 23, 2021 at 12:10 PM Karol Herbst wrote:
>
> On Fri, Jul 23, 2021 at 11:24 AM Daniel Vetter wrote:
> >
> > On Fri, Jul 23, 2021 at 11:15 AM Arnd Bergmann wrote:
> > >
> > > From: Arnd Bergmann
> > >
> > > When the ba
On Fri, Jul 23, 2021 at 5:10 PM Randy Dunlap wrote:
>
> On 7/23/21 2:15 AM, Arnd Bergmann wrote:
> > From: Arnd Bergmann
> >
> > When the backlight support is disabled, the driver fails to build:
> >
> > drivers/gpu/drm/nouveau/dispnv50/disp.c: In function
> > 'nv50_sor_atomic_disable':
> > driv
On Fri, Jul 23, 2021 at 6:31 PM Randy Dunlap wrote:
>
> On 7/23/21 8:15 AM, Karol Herbst wrote:
> > On Fri, Jul 23, 2021 at 5:10 PM Randy Dunlap wrote:
> >>
> >> On 7/23/21 2:15 AM, Arnd Bergmann wrote:
> >>> From: Arnd Bergmann
> >>>
&g
On Fri, Jul 23, 2021 at 8:40 PM Arnd Bergmann wrote:
>
> On Fri, Jul 23, 2021 at 6:34 PM Karol Herbst wrote:
> > On Fri, Jul 23, 2021 at 6:31 PM Randy Dunlap wrote:
> > > On 7/23/21 8:15 AM, Karol Herbst wrote:
> > > > On Fri, Jul 23, 2021 at 5:1
devel@lists.freedesktop.org
Fixes: 6eca310e8924 ("drm/nouveau/kms/nv50-: Add basic DPCD backlight support
for nouveau")
Signed-off-by: Karol Herbst
---
drivers/gpu/drm/nouveau/Kbuild | 2 +-
drivers/gpu/drm/nouveau/Kconfig | 13 ++-
drivers/gpu/drm/nouveau/
On Sat, Jul 24, 2021 at 8:55 AM Arnd Bergmann wrote:
>
> On Sat, Jul 24, 2021 at 12:47 AM Karol Herbst wrote:
> >
> > In the past this only led to compilation issues. Also the small amount of
> > extra .text shouldn't really matter compared to the ent
On Sat, Jul 24, 2021 at 1:56 PM Arnd Bergmann wrote:
>
> On Sat, Jul 24, 2021 at 11:55 AM Karol Herbst wrote:
> >
> > On Sat, Jul 24, 2021 at 8:55 AM Arnd Bergmann wrote:
> > >
> > > On Sat, Jul 24, 2021 at 12:47 AM Karol Herbst wrote:
> > > >
On Sat, Jul 24, 2021 at 2:10 PM Karol Herbst wrote:
>
> On Sat, Jul 24, 2021 at 1:56 PM Arnd Bergmann wrote:
> >
> > On Sat, Jul 24, 2021 at 11:55 AM Karol Herbst wrote:
> > >
> > > On Sat, Jul 24, 2021 at 8:55 AM Arnd Bergmann wrote:
> > > >
On Sat, Jul 24, 2021 at 4:05 PM Arnd Bergmann wrote:
>
> On Sat, Jul 24, 2021 at 2:52 PM Karol Herbst wrote:
> >
> > On Sat, Jul 24, 2021 at 2:10 PM Karol Herbst wrote:
> > >
> > > On Sat, Jul 24, 2021 at 1:56 PM Arnd Bergmann wrote:
> > > >
Reviewed-by: Karol Herbst
On Fri, Apr 16, 2021 at 4:37 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c:584: warning: Function
> parameter or member 'init' not described in 'init_reserv
On Fri, Apr 16, 2021 at 4:37 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/nouveau/dispnv50/disp.c:1381:6: warning: variable ‘ret’ set
> but not used [-Wunused-but-set-variable]
>
not a big fan of just ignoring return codes, I'd rather see it handl
Reviewed-by: Karol Herbst
On Fri, Apr 16, 2021 at 4:37 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c:992: warning: Function
> parameter or member 'gr' not described in 'gf100_gr_wait_
Reviewed-by: Karol Herbst
On Fri, Apr 16, 2021 at 4:37 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c:53: warning: Function
> parameter or member 'speedo' not described in 'gk20a_vo
Reviewed-by: Karol Herbst
On Fri, Apr 16, 2021 at 4:37 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/nouveau/nouveau_bo.c: In function ‘nouveau_ttm_tt_populate’:
> drivers/gpu/drm/nouveau/nouveau_bo.c:1228:17: warning: variable ‘
Reviewed-by: Karol Herbst
On Fri, Apr 16, 2021 at 4:38 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/nouveau/dispnv04/crtc.c:462: warning: Function parameter or
> member 'crtc' not described in 'nv_crtc_mode_set_re
On Fri, Apr 16, 2021 at 4:38 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/nouveau/dispnv50/disp.c: In function ‘nv50_mstm_cleanup’:
> drivers/gpu/drm/nouveau/dispnv50/disp.c:1357:6: warning: variable ‘ret’ set
> but not used [-Wunused-but-set-vari
Reviewed-by: Karol Herbst
On Fri, Apr 16, 2021 at 4:38 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/nouveau/dispnv50/headc57d.c:173:1: warning: no previous
> prototype for ‘headc57d_olut’ [-Wmissing-prototypes]
>
> Cc: Be
Reviewed-by: Karol Herbst
On Fri, Apr 16, 2021 at 4:38 PM Lee Jones wrote:
>
> Fixes the following build error:
>
> drivers/gpu/drm/nouveau/dispnv50/disp.c:2530:1: error: conflicting types for
> ‘nv50_display_fini’
> In file included from drivers/gpu/drm/nouveau/
On Fri, Apr 16, 2021 at 4:38 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/nouveau/nouveau_svm.c: In function ‘nouveau_pfns_map’:
> drivers/gpu/drm/nouveau/nouveau_svm.c:810:6: warning: variable ‘ret’ set but
> not used [-Wunused-but-set-variable]
Reviewed-by: Karol Herbst
On Fri, Apr 16, 2021 at 4:38 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/nouveau/nouveau_ioc32.c:52: warning: Function parameter or
> member 'filp' not described in 'nouveau_compat_ioc
Reviewed-by: Karol Herbst
On Fri, Apr 16, 2021 at 4:38 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/nouveau/nouveau_ioc32.c:2: warning: Cannot understand *
> file mga_ioc32.c
>
> Cc: Ben Skeggs
> Cc: David Airlie
&
Reviewed-by: Karol Herbst
On Fri, Apr 16, 2021 at 4:38 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/nouveau/dispnv50/disp.c:2599:1: warning: no previous
> prototype for ‘nv50_display_create’ [-Wmissing-prototypes]
>
> Cc: Be
playing around a little bit with this, I think the original "select
BACKLIGHT_CLASS_DEVICE" is fine. Atm we kind of have this weird mix of
drivers selecting and others depending on it. We could of course convert
everything over to depend, and break those cycling dependency issues with
this.
Anyway
On Wed, Aug 4, 2021 at 4:19 PM Arnd Bergmann wrote:
>
> On Wed, Aug 4, 2021 at 4:10 PM Karol Herbst wrote:
> >
> > playing around a little bit with this, I think the original "select
> > BACKLIGHT_CLASS_DEVICE" is fine. Atm we kind of have this weird mix o
On Wed, Aug 4, 2021 at 4:43 PM Karol Herbst wrote:
>
> On Wed, Aug 4, 2021 at 4:19 PM Arnd Bergmann wrote:
> >
> > On Wed, Aug 4, 2021 at 4:10 PM Karol Herbst wrote:
> > >
> > > playing around a little bit with this, I think the original "select
>
On Wed, Aug 4, 2021 at 11:10 PM Arnd Bergmann wrote:
>
> On Wed, Aug 4, 2021 at 8:59 PM Karol Herbst wrote:
> > On Wed, Aug 4, 2021 at 4:43 PM Karol Herbst wrote:
> > > On Wed, Aug 4, 2021 at 4:19 PM Arnd Bergmann wrote:
> > > > On Wed, Aug 4, 20
Hey everybody,
so, here is a proposal of what we could change in order to allow
patches to land faster, more reliably and to increase the overall bus
factor in terms of nouveau kernel maintenance.
But let's start with the current situation:
At the moment contributors have to send patches to the
On Tue, Aug 10, 2021 at 12:11 PM Daniel Vetter wrote:
>
> On Fri, Aug 06, 2021 at 06:53:06PM +0200, Karol Herbst wrote:
> > Hey everybody,
> >
> > so, here is a proposal of what we could change in order to allow
> > patches to land faster, more reliably and to incre
On Wed, Aug 18, 2021 at 8:52 PM Jarkko Nikula wrote:
>
> Hi
>
> My old Thinkpad T410i won't resume properly anymore after suspend or
> hibernation after v5.12 including today's head 614cb2751d31 ("Merge tag
> 'trace-v5.14-rc6' of
> git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace"
Reviewed-by: Karol Herbst
On Fri, Mar 19, 2021 at 9:24 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c:584: warning: Function
> parameter or member 'init' not described in 'init_reserv
c0)
> */
> static inline int
> @@ -58,7 +58,7 @@ gk20a_volt_get_cvb_voltage(int speedo, int s_scale, const
> struct cvb_coef *coef)
> return mv;
> }
>
> -/**
> +/*
> * cvb_t_mv =
> * ((c2 * speedo / s_sc
t;
> ___
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
Reviewed-by: Karol Herbst
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
gt; _______
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
Reviewed-by: Karol Herbst
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
; TTM_PAGE_FLAG_SG);
>
> if (slave)
> return;
>
> drm = nouveau_bdev(bdev);
> - dev = drm->dev->dev;
>
> return ttm_pool_free(&drm->ttm.bdev.pool, ttm);
> }
> --
> 2.27.0
>
> ___
e "nouveau_ioctl.h"
>
> -/**
> +/*
> * Called whenever a 32-bit process running under a 64-bit kernel
> * performs an ioctl on /dev/dri/card.
> *
> --
> 2.27.0
>
> _______
> dri-devel mailing list
> dri-devel@li
; *
> * 32-bit ioctl compatibility routines for the MGA DRM.
> --
> 2.27.0
>
> ___
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
Reviewed-by: Karol Herbst
ramebuffer *old_fb)
> return ret;
> }
>
> -/**
> +/*
> * Sets up registers for the given mode/adjusted_mode pair.
> *
> * The clocks, CRTCs and outputs attached to this CRTC must be off.
> --
> 2.27.0
>
> ___
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
Reviewed-by: Karol Herbst
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
; size != 1024)
> --
> 2.27.0
>
> ___
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
Reviewed-by: Karol Herbst
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Reviewed-by: Karol Herbst
On Thu, Nov 26, 2020 at 2:11 PM Christian König
wrote:
>
> This wasn't initialized for pre NV50 hardware.
>
> Signed-off-by: Christian König
> Reported-and-Tested-by: Mark Hounschell
> ---
> drivers/gpu/drm/nouveau/nouveau_bo.c | 2 +-
>
On Thu, Nov 26, 2020 at 4:28 PM Geert Uytterhoeven wrote:
>
> Hi Miguel,
>
> On Thu, Nov 26, 2020 at 3:54 PM Miguel Ojeda
> wrote:
> > On Wed, Nov 25, 2020 at 11:44 PM Edward Cree wrote:
> > > To make the intent clear, you have to first be certain that you
> > > understand the intent; otherwise
documentation.
Cc: sta...@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: Ben Skeggs
Reported-by: Mark Pearson
Tested-by: Mark Pearson
Signed-off-by: Karol Herbst
---
drivers/gpu/drm/nouveau/include/nvkm/subdev/bios/conn.h | 1 +
drivers/gpu/drm/nouveau/nouveau_connector.c | 1 +
2
hen.
>
As long as it doesn't touch code I don't see why not. Just in case:
Reviewed-by: Karol Herbst
On Fri, Nov 6, 2020 at 3:17 AM Jeremy Cline wrote:
>
> Make use of the devm_drm_dev_alloc() API to bind the lifetime of
> nouveau_drm structure to the drm_device. This is important because a
> reference to nouveau_drm is accessible from drm_device, which is
> provided to a number of DRM layer call
On Sun, Nov 15, 2020 at 6:43 PM Salvatore Bonaccorso wrote:
>
> Hi,
>
> On Fri, Aug 28, 2020 at 11:28:46AM +0200, Frantisek Hrbata wrote:
> > Unprivileged user can crash kernel by using DRM_IOCTL_NOUVEAU_CHANNEL_ALLOC
> > ioctl. This was reported by trinity[1] fuzzer.
> >
> > [ 71.073906] nouvea
Fixes a crash booting on those platforms with nouveau.
Fixes: 4cdd2450bf73 ("drm/nouveau/pmu/gm200-: use alternate falcon reset
sequence")
Cc: Ben Skeggs
Cc: Karol Herbst
Cc: dri-devel@lists.freedesktop.org
Cc: nouv...@lists.freedesktop.org
Cc: # v5.17+
Signed-off-by: Ka
gain in nv50_wndw_reset(). However, the helpers have been
> adjusted to set it properly at reset, so this is not needed anymore.
>
> Cc: nouv...@lists.freedesktop.org
> Cc: Ben Skeggs
> Cc: Karol Herbst
> Cc: Lyude Paul
> Signed-off-by: Maxime Ripard
> ---
> drivers/gpu/dr
On Tue, Feb 22, 2022 at 3:02 PM Maxime Ripard wrote:
>
> Hi,
>
> On Mon, Feb 21, 2022 at 05:42:36PM +0100, Karol Herbst wrote:
> > On Mon, Feb 21, 2022 at 11:00 AM Maxime Ripard wrote:
> > >
> > > The nouveau KMS driver will call drm_plane_create_zpos
pere GPUs is in
> the works, but the required changes are far too invasive that they
> would be unsuitable to backport to fix this issue on current kernels.
>
> Signed-off-by: Ben Skeggs
> Cc: Lyude Paul
> Cc: Karol Herbst
> Cc: # v5.12+
> ---
> drivers/gpu/drm/no
interactions with EFI.
>
Reviewed-by: Karol Herbst
> Fixes: e78b1b545c6c ("drm/nouveau/kms/nv50: workaround EFI GOP window channel
> format differences").
> Signed-off-by: Ben Skeggs
> Cc: Lyude Paul
> Cc: Karol Herbst
> Cc: # v5.12+
> ---
> drivers/gpu/drm/nou
On Tue, Sep 7, 2021 at 1:28 AM Ben Skeggs wrote:
>
> On Tue, 7 Sept 2021 at 09:17, Karol Herbst wrote:
> >
> > ."
> >
> >
> > On Mon, Sep 6, 2021 at 2:56 AM Ben Skeggs wrote:
> > >
> > > From: Ben Skeggs
> > >
> &
Reviewed-by: Karol Herbst
I haven't checked if other places need fixing up yet, and I still want
to test this patch, but I won't get to it until Monday. But if
everything is in place we can get this pushed next week so we can
finally fix this annoying issue :) I was also seeing
I am currently checking the ML for such old patches, just have to make
sure it's actually fine and not breaking stuff as well.
But I think we will pull this in soonish, I just also work on
improving our CI stuff at the same time by trying out some things.
On Mon, Oct 11, 2021 at 9:06 AM Salvatore
uhh, that's on me. I will send out a patch today. I just noticed that
the config file I used for testing had WERROR disabled.
On Tue, Oct 12, 2021 at 4:18 AM Stephen Rothwell wrote:
>
> Hi all,
>
> After merging the drm-misc tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
Fixes a compilation issue introduced because I forgot to test with WERROR
enabled.
Cc: Stephen Rothwell
Cc: DRI
Cc: nouv...@lists.freedesktop.org
Fixes: 404046cf4805 ("drm/nouveau/mmu/gp100-: drop unneeded assignment in the
if condition.")
Signed-off-by: Karol Herbst
---
drive
On Thu, Oct 14, 2021 at 5:02 AM wrote:
>
> Hi,
>
> I review the code.
>
> It seems I forget to delete the definition of the variable "inst",I'm sry for
> that.: (
>
> I'll submit another patch soon.
>
I already wrote the patch and pushed it:
https://git.kernel.org/pub/scm/linux/kernel/git/next/l
hat the programming style isn't the best and we should be
explicit about freeing memory though.
> Cc: Ben Skeggs
> Cc: David Airlie
> Cc: Daniel Vetter
> Cc: Karol Herbst
> Cc: dri-devel@lists.freedesktop.org
> Cc: nouv...@lists.freedesktop.org
> Cc: linux-ker...@
On Tue, Sep 21, 2021 at 11:07 AM Ben Skeggs wrote:
>
> From: Ben Skeggs
>
> Turns out caller isn't zero-initialised after-all.
>
> Fixes: 6b457230bfa1 ("drm/nouveau/ga102-: support ttm buffer moves via copy
> engine")
> Reported-by: Karol Herbst
> S
On Tue, Sep 21, 2021 at 3:22 PM Tim Gardner wrote:
>
>
>
> On 9/20/21 8:07 PM, Karol Herbst wrote:
> > On Mon, Sep 20, 2021 at 8:17 PM Tim Gardner
> > wrote:
> >>
> >> Coverity complains of a resource leak in ga102_chan_new():
> >>
>
Reviewed-by: Karol Herbst
and queued
On Fri, Mar 26, 2021 at 10:41 PM Lyude Paul wrote:
>
> Reviewed-by: Lyude Paul
>
> On Wed, 2020-12-02 at 19:02 -0500, Jeremy Cline wrote:
> > nouveau_bo_init() is backed by ttm_bo_init() and ferries its return code
> > back to
Reviewed-by: Karol Herbst
On Sat, Aug 21, 2021 at 10:46 AM CGEL wrote:
>
> From: Luo penghao
>
> In order to keep the code style consistency of the whole file,
> the 'ret' assignments should be deleted.
>
> The clang_analyzer complains as follows:
>
> dr
Reviewed-by: Karol Herbst
but I will remove the unnecessary brackets as well
On Sat, Aug 21, 2021 at 10:46 AM CGEL wrote:
>
> From: Luo penghao
>
> In order to keep the code style consistency of the whole file,
> the 'inst' assignments should be deleted.
>
>
Reviewed-by: Karol Herbst
On Sat, Sep 11, 2021 at 9:45 AM Yang Yingliang wrote:
>
> When using single_open() for opening, single_release() should be
> called, otherwise the 'op' allocated in single_open() will be leaked.
>
> Fixes: 12885ecbfe62 ("drm/nouv
Reviewed-by: Karol Herbst
On Sat, Sep 11, 2021 at 9:45 AM Yang Yingliang wrote:
>
> When using single_open() for opening, single_release() should be
> called, otherwise the 'op' allocated in single_open() will be leaked.
>
> Fixes: 6e9fc177399f ("drm/nouveau/deb
Lack of documentation inside Linux here is a bit annoying, but do I
understand it correctly, that the main (and probably only) difference
is that kvcalloc checks whether the multiplication overflows and
returns NULL in this case?
On Wed, Sep 29, 2021 at 12:21 AM Gustavo A. R. Silva
wrote:
>
> Use
I think it makes sense to add a Fixes tag to this:
Fixes: 822cab6150d3 ("drm/nouveau/svm: check for SVM initialized
before migrating")
Reviewed-by: Karol Herbst
On Tue, Sep 7, 2021 at 3:20 PM Chenyuan Mi wrote:
>
> The reference counting issue happens in one exception
On Wed, Oct 6, 2021 at 4:41 AM Lyude Paul wrote:
>
> Since we don't support hybrid AUX/PWM backlights in nouveau right now,
> let's add some explicit checks so that we don't break nouveau once we
> enable support for these backlights in other drivers.
>
> Signed-off-by: Lyude Paul
> ---
> driver
l typo nitpicks: provided and accessed
Also, I think it makes sense to add
Fixes: 4d4e9907ff572 "drm/nouveau/bios: guard against out-of-bounds
accesses to image"
Cc: # v4.10+
so it gets automatically backported to applicable stable kernels
Anyway, whoever picks the patch can mak
On Fri, Jan 28, 2022 at 8:54 PM Alex Deucher wrote:
>
> On Fri, Jan 28, 2022 at 2:20 PM Lyude Paul wrote:
> >
> > Sigh-thank you for catching this - I had totally forgot about the umn.edu
> > ban.
> > I pushed this already but I will go ahead and send a revert for this patch.
> > Will cc you on
(edp_dpcd[2] & DP_EDP_BACKLIGHT_BRIGHTNESS_AUX_SET_CAP)) {
> NV_DEBUG(drm, "DPCD backlight controls supported on
> %s\n",
> nv_conn->base.name);
>
> --
> 2.31.1
>
Reviewed-by: Karol Herbst
ff-by: Karol Herbst
---
MAINTAINERS | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 8805df335326..270dc9c0a427 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -5961,10 +5961,17 @@ F: drivers/gpu/drm/panel/panel-novatek-nt36672a.c
DRM D
something seems to have messed with the patch so it doesn't apply correctly.
On Thu, Jun 17, 2021 at 9:39 AM Yizhuo Zhai wrote:
>
> In function nvkm_ioctl_map(), the variable "type" could be
> uninitialized if "nvkm_object_map()" returns error code,
> however, it does not check the return value a
ders were also a bit broken. I just suspect that when
sending it something went wrong or so.
> On Sat, Nov 13, 2021 at 12:22 PM Karol Herbst wrote:
> >
> > something seems to have messed with the patch so it doesn't apply correctly.
> >
> > On Thu, Jun 17, 2021 at
On Tue, Dec 7, 2021 at 10:52 AM Christian König
wrote:
>
> Am 06.12.21 um 19:37 schrieb Dan Moulding:
> > On 04.12.21 17:40, Stefan Fritsch wrote:
> >> Hi,
> >>
> >> when updating from 5.14 to 5.15 on a system with NVIDIA GP108 [GeForce
> >> GT 1030] (NV138) and Ryzen 9 3900XT using kde/plasma on
This reverts commit 62b53b37e4b1500d4eb4624a44ad861cf8d3cd18.
Signed-off-by: Karol Herbst
---
drivers/gpu/drm/ttm/ttm_bo.c| 31 ---
include/drm/ttm/ttm_bo_driver.h | 15 +++
2 files changed, 15 insertions(+), 31 deletions(-)
diff --git a/drivers/gpu
This reverts commit 30f33126feca0fe16df9e9302ffc28a953e2eb37.
Signed-off-by: Karol Herbst
---
drivers/gpu/drm/ttm/ttm_bo.c | 1 +
drivers/gpu/drm/ttm/ttm_memory.c | 9 +
2 files changed, 10 insertions(+)
diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c
index
This reverts commit 2bb42410b1bd324912389c6ac748df1c1befd69f.
Signed-off-by: Karol Herbst
---
drivers/gpu/drm/Makefile| 2 +-
drivers/gpu/drm/drm_drv.c | 2 +
drivers/gpu/drm/drm_global.c| 137
include/drm/drmP.h | 1
This reverts commit a64f784bb14a56bfdfad2dc397dd67e4564e3a29.
Signed-off-by: Karol Herbst
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 59 ++-
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.h | 1 +
drivers/gpu/drm/ast/ast_drv.h | 1 +
drivers/gpu/drm/ast
This reverts commit 27eb1fa9130a98edd2b321d4dbce5c8b244ee7af.
Signed-off-by: Karol Herbst
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 44 +++
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.h | 1 +
drivers/gpu/drm/ast/ast_drv.h | 1 +
drivers/gpu/drm/ast
This reverts commit 56b3d20413587fab6a790cfc8bc075ca94bc8ed9.
Signed-off-by: Karol Herbst
---
drivers/gpu/drm/ttm/ttm_bo.c| 14 +-
include/drm/ttm/ttm_bo_driver.h | 1 +
2 files changed, 6 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu
c1453880
[54758.418696] FS: 7fc0b379c280() GS:9ebeae38()
knlGS:
[54758.418698] CS: 0010 DS: ES: CR0: 80050033
[54758.418699] CR2: 0004ee194700 CR3: 00045069e005 CR4: 003606e0
Karol Herbst (6):
Revert "drm: Remove drm_global.{c,h}
On Tue, Apr 16, 2019 at 8:38 AM Christian König
wrote:
>
> Am 16.04.19 um 02:35 schrieb Karol Herbst:
> > Kobjects are supposed to be dynamically allocated, but with recent changes
> > this rule was violated. Reverting those commits fixes crashes when a drm
> > driver usi
On Tue, Apr 16, 2019 at 11:12 AM Koenig, Christian
wrote:
>
> Am 16.04.19 um 11:10 schrieb Karol Herbst:
> > On Tue, Apr 16, 2019 at 8:38 AM Christian König
> > wrote:
> >> Am 16.04.19 um 02:35 schrieb Karol Herbst:
> >>> Kobjects are supposed to be dynamic
On Tue, Apr 16, 2019 at 1:07 PM Koenig, Christian
wrote:
>
> Am 16.04.19 um 12:54 schrieb Karol Herbst:
> > On Tue, Apr 16, 2019 at 11:12 AM Koenig, Christian
> > wrote:
> >> Am 16.04.19 um 11:10 schrieb Karol Herbst:
> >>> On Tue, Apr 16, 2019 at 8:38 AM
k_swapping(struct ttm_mem_global *glob)
> diff --git a/include/drm/ttm/ttm_bo_driver.h b/include/drm/ttm/ttm_bo_driver.h
> index 3db265bf2d4e..c008346c2401 100644
> --- a/include/drm/ttm/ttm_bo_driver.h
> +++ b/include/drm/ttm/ttm_bo_driver.h
> @@ -420,7 +420,6 @@ extern struct ttm_bo_global {
>
On Wed, Apr 17, 2019 at 1:09 AM Eric Anholt wrote:
>
> Christian König writes:
>
> > Am 16.04.19 um 02:35 schrieb Karol Herbst:
> >> Kobjects are supposed to be dynamically allocated, but with recent changes
> >> this rule was violated. Reverting those
Acked-by: Karol Herbst
On Fri, Jun 21, 2019 at 8:12 PM Emil Velikov wrote:
>
> On 2019/06/19, Ilia Mirkin wrote:
> > The bulk SPDX addition made all these files into GPL-2.0 licensed files.
> > However the remainder of the project is MIT-licensed, these files
> > (prim
s/149
Signed-off-by: Karol Herbst
---
.../gpu/drm/nouveau/nvkm/subdev/pmu/base.c| 37 ---
1 file changed, 16 insertions(+), 21 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/pmu/base.c
b/drivers/gpu/drm/nouveau/nvkm/subdev/pmu/base.c
index 455e95a89259..2438287
I am not entirely sure if this fixes anything, but the code standed out
while investigated problematic calls to vunmap.
nvkm_umem.io is only ever set for the NVKM_OBJECT_MAP_IO case in
nvkm_umem_map, but never for the NVKM_OBJECT_MAP_VA one, which could lead
to taking the wrong patch inside nvkm_u
reaking muxed systems where we have two
GPUs, but.. the systems I know of have different ways of controlling
the backlight anyway. So unless there is something I missed this is
Reviewed-by: Karol Herbst
> Signed-off-by: Lyude Paul
> Fixes: 6eca310e8924 ("drm/nouveau/kms/nv50-: Add ba
Reviewed-by: Karol Herbst
On Fri, Feb 4, 2022 at 8:33 PM Lyude Paul wrote:
>
> Currently we can get a warning on systems with eDP backlights like so:
>
> nv_backlight: invalid backlight type
> WARNING: CPU: 4 PID: 454 at drivers/video/backlight/
://gitlab.freedesktop.org/drm/intel/-/issues/5732
Signed-off-by: Karol Herbst
---
drivers/gpu/drm/i915/i915_vma.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_vma.c b/drivers/gpu/drm/i915/i915_vma.c
index 162e8d83691b..bb3b6e4bee8b 100644
@lists.freedesktop.org
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/5732
Signed-off-by: Karol Herbst
---
drivers/gpu/drm/i915/i915_vma.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_vma.c b/drivers/gpu/drm/i915/i915_vma.c
index
On Fri, Apr 29, 2022 at 9:54 PM Lyude Paul wrote:
>
> There's plenty of ways to fudge the GPU when developing on nouveau by
> mistake, some of which can result in nouveau seriously spamming dmesg with
> fault errors. This can be somewhat annoying, as it can quickly overrun the
> message buffer (or
On Sat, Apr 30, 2022 at 1:04 AM Lyude Paul wrote:
>
> On Sat, 2022-04-30 at 00:56 +0200, Karol Herbst wrote:
> > On Fri, Apr 29, 2022 at 9:54 PM Lyude Paul wrote:
> > >
> > > There's plenty of ways to fudge the GPU when developing on nouveau by
> > >
__i915_vma_remove_closed on the same vma.
On Wed, Apr 20, 2022 at 11:57 AM Karol Herbst wrote:
>
> i915_vma_reopen checked if the vma is closed before without taking the
> lock. So multiple threads could attempt removing the vma.
>
> Instead the lock needs to be taken before actually c
not able to hit any error on my machine, but regardless:
Reviewed-by: Karol Herbst
I suspect there are more places where we could put it, but we can add
those later.
Anyway, I think it's valuable to push it through fixes, not sure how
far back we want to CC stable though.
On Fri, Apr 29,
Actually, there is another place we have to put this, we can spam
"SCHED_ERROR" things which are triggered within multiple
drivers/gpu/drm/nouveau/nvkm/engine/fifo/ files.
On Tue, May 3, 2022 at 9:23 PM Karol Herbst wrote:
>
> not able to hit any error on my machine, but regardle
connector->interlace_allowed =
> + drm->client.device.info.family <
> NV_DEVICE_INFO_V0_VOLTA;
> connector->doublescan_allowed = true;
> } else
> if (nv_encoder->dcb->type == DCB_OUTPUT_LVDS ||
> --
> 2.37.1
>
Reviewed-by: Karol Herbst
1 - 100 of 418 matches
Mail list logo
