RE: [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-03-08 Thread Kandpal, Suraj
Hi Abhinav, > > Hi, > >>> Hi, > > Hi Abhinav, > >> Hi Laurent > >> > >> Ok sure, I can take this up but I need to understand the proposal > >> a little bit more before proceeding on this. So we will discuss > >> this in another email where we specifically talk about the > >>

RE: [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-02-22 Thread Kandpal, Suraj
Hey, > The connector/encoder funcs you do have to pass to > drm_writeback_connector_init() can't use any of the shared driver > infrastructure that assume a certain inheritance. > > See also my reply to Laurent [1]. > > > It well might be that we all misunderstand your design. Do you have a > >

RE: [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-02-25 Thread Kandpal, Suraj
Hi Abhinav, > Based on the discussion in this thread [1] , it seems like having drm_encoder > as a pointer seems to have merits for both of us and also in agreement with > the folks on this thread and has a better chance of an ack. > > However drm_connector is not. > > I had a brief look at your

RE: [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-03-04 Thread Kandpal, Suraj
Hi Abhinav, > Hi Laurent > > Ok sure, I can take this up but I need to understand the proposal a little bit > more before proceeding on this. So we will discuss this in another email > where we specifically talk about the connector changes. > > Also, I am willing to take this up once the encoder

RE: [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-03-04 Thread Kandpal, Suraj
Hi, > > Hi Abhinav, > > > Hi Laurent > > > > > > Ok sure, I can take this up but I need to understand the proposal a > > > little bit more before proceeding on this. So we will discuss this > > > in another email where we specifically talk about the connector changes. > > > > > > Also, I am willing

RE: [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-03-04 Thread Kandpal, Suraj
Hi, > > Hi, > > > > Hi Abhinav, > > > > > Hi Laurent > > > > > > > > > > Ok sure, I can take this up but I need to understand the > > > > > proposal a little bit more before proceeding on this. So we will > > > > > discuss this in another email where we specifically talk about the > connector chan

RE: [PATCH 1/3] drm: add writeback pointers to drm_connector

2022-01-27 Thread Kandpal, Suraj
> > + laurent on this > > Hi Suraj > Jani pointed me to this thread as i had posted something similar here : > https://patchwork.freedesktop.org/patch/470296/ but since this thread was > posted earlier, we can discuss further here. > > Overall, its similar to what I had posted in the RFC and you

RE: [PATCH 3/3] drm/vkms: change vkms driver to use drm_writeback_connector.base pointer

2022-01-30 Thread Kandpal, Suraj
Hi All, Gentle Reminder! Any Review comments? > Changing vkms driver to accomadate the change of > drm_writeback_connector.base to a pointer the reason for which is > explained in the Patch(drm: add writeback pointers to drm_connector). > > Signed-off-by: Kandpal, Suraj > ---

RE: [PATCH 1/3] drm: add writeback pointers to drm_connector

2022-01-31 Thread Kandpal, Suraj
Hey, > I think there are more places affected with this change. I can get below > compilation issues while trying to compile my branch: > > drivers/gpu/drm/vc4/vc4_txp.c: In function ‘encoder_to_vc4_txp’: > ./include/linux/build_bug.h:78:41: error: static assertion failed: > "pointer type mismatch

[PATCH v2 1/6] drm: add writeback pointers to drm_connector

2022-02-02 Thread Kandpal Suraj
nding ripple effect due to the above changes namely in two drivers as I can see it komeda and vkms have been dealt with in the upcoming patches of this series. Signed-off-by: Kandpal Suraj --- drivers/gpu/drm/drm_writeback.c | 19 ++- include/drm/drm_connector.h | 3 +++ in

[PATCH v2 2/6] drm/arm/komeda : change driver to use drm_writeback_connector.base pointer

2022-02-02 Thread Kandpal Suraj
Making changes to komeda driver because we had to change drm_writeback_connector.base into a pointer the reason for which is expained in the Patch (drm: add writeback pointers to drm_connector). Signed-off-by: Kandpal Suraj --- drivers/gpu/drm/arm/display/komeda/komeda_crtc.c | 2

[PATCH v2 3/6] drm/vkms: change vkms driver to use drm_writeback_connector.base pointer

2022-02-02 Thread Kandpal Suraj
Changing vkms driver to accomadate the change of drm_writeback_connector.base to a pointer the reason for which is explained in the Patch(drm: add writeback pointers to drm_connector). Signed-off-by: Kandpal Suraj --- drivers/gpu/drm/vkms/vkms_writeback.c | 9 ++--- 1 file changed, 6

[PATCH v2 4/6] drm/vc4: vc4 driver changes to accommodate changes done in drm_writeback_connector structure

2022-02-02 Thread Kandpal Suraj
Changing vc4 driver to accomadate the change of drm_writeback_connector.base and drm_writeback_connector.encoder to a pointer the reason for which is explained in the Patch(drm: add writeback pointers to drm_connector). Signed-off-by: Kandpal Suraj --- drivers/gpu/drm/vc4/vc4_txp.c | 20

[PATCH v2 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-02-02 Thread Kandpal Suraj
Changing rcar_du driver to accomadate the change of drm_writeback_connector.base and drm_writeback_connector.encoder to a pointer the reason for which is explained in the Patch(drm: add writeback pointers to drm_connector). Signed-off-by: Kandpal Suraj --- drivers/gpu/drm/rcar-du/rcar_du_crtc.h

[PATCH v2 6/6] drm/arm: changes to malidp driver resulting from drm_writeback_connector structure changes

2022-02-02 Thread Kandpal Suraj
Changing malidp driver to accomadate the change of drm_writeback_connector.base and drm_writeback_connector.encoder to a pointer the reason for which is explained in the Patch(drm: add writeback pointers to drm_connector). Signed-off-by: Kandpal Suraj --- drivers/gpu/drm/arm/malidp_crtc.c | 2

[PATCH 0/6] drm writeback connector changes

2022-02-02 Thread Kandpal Suraj
by it. I had perviously floated a patch series but missed some of the drivers that were effected by the change hence refloating the patch series Kandpal Suraj (6): drm: add writeback pointers to drm_connector drm/arm/komeda : change driver to use drm_writeback_connector.base pointer drm

[PATCH 1/6] drm: add writeback pointers to drm_connector

2022-02-02 Thread Kandpal Suraj
nding ripple effect due to the above changes namely in two drivers as I can see it komeda and vkms have been dealt with in the upcoming patches of this series. Signed-off-by: Kandpal Suraj Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/drm_writeback.c | 19 ++- includ

[PATCH 2/6] drm/arm/komeda : change driver to use drm_writeback_connector.base pointer

2022-02-02 Thread Kandpal Suraj
Making changes to komeda driver because we had to change drm_writeback_connector.base into a pointer the reason for which is expained in the Patch (drm: add writeback pointers to drm_connector). Signed-off-by: Kandpal Suraj Reviewed-by: Carsten Haitzler --- drivers/gpu/drm/arm/display/komeda

[PATCH 3/6] drm/vkms: change vkms driver to use drm_writeback_connector.base pointer

2022-02-02 Thread Kandpal Suraj
Changing vkms driver to accomadate the change of drm_writeback_connector.base to a pointer the reason for which is explained in the Patch(drm: add writeback pointers to drm_connector). Signed-off-by: Kandpal Suraj --- drivers/gpu/drm/vkms/vkms_writeback.c | 9 ++--- 1 file changed, 6

[PATCH 4/6] drm/vc4: vc4 driver changes to accommodate changes done in drm_writeback_connector structure

2022-02-02 Thread Kandpal Suraj
Changing vc4 driver to accomadate the change of drm_writeback_connector.base and drm_writeback_connector.encoder to a pointer the reason for which is explained in the Patch(drm: add writeback pointers to drm_connector). Signed-off-by: Kandpal Suraj --- drivers/gpu/drm/vc4/vc4_txp.c | 20

[PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-02-02 Thread Kandpal Suraj
Changing rcar_du driver to accomadate the change of drm_writeback_connector.base and drm_writeback_connector.encoder to a pointer the reason for which is explained in the Patch(drm: add writeback pointers to drm_connector). Signed-off-by: Kandpal Suraj --- drivers/gpu/drm/rcar-du/rcar_du_crtc.h

[PATCH 6/6] drm/arm: changes to malidp driver resulting from drm_writeback_connector structure changes

2022-02-02 Thread Kandpal Suraj
Changing malidp driver to accomadate the change of drm_writeback_connector.base and drm_writeback_connector.encoder to a pointer the reason for which is explained in the Patch(drm: add writeback pointers to drm_connector). Signed-off-by: Kandpal Suraj --- drivers/gpu/drm/arm/malidp_crtc.c | 2

[PATCH 1/3] drm: add writeback pointers to drm_connector

2022-01-11 Thread Kandpal, Suraj
nding ripple effect due to the above changes namely in two drivers as I can see it komeda and vkms have been dealt with in the upcoming patches of this series. Signed-off-by: Kandpal, Suraj --- drivers/gpu/drm/drm_writeback.c | 19 ++- include/drm/drm_connector.h | 3 +++ in

[PATCH 3/3] drm/vkms: change vkms driver to use drm_writeback_connector.base pointer

2022-01-11 Thread Kandpal, Suraj
Changing vkms driver to accomadate the change of drm_writeback_connector.base to a pointer the reason for which is explained in the Patch(drm: add writeback pointers to drm_connector). Signed-off-by: Kandpal, Suraj --- drivers/gpu/drm/vkms/vkms_writeback.c | 6 +++--- 1 file changed, 3

[PATCH 2/3] drm/arm/komeda : change driver to use drm_writeback_connector.base pointer

2022-01-11 Thread Kandpal, Suraj
Making changes to komeda driver because we had to change drm_writeback_connector.base into a pointer the reason for which is expained in the Patch (drm: add writeback pointers to drm_connector). Signed-off-by: Kandpal, Suraj --- drivers/gpu/drm/arm/display/komeda/komeda_crtc.c | 2

RE: [PATCH 1/6] drm: add writeback pointers to drm_connector

2022-02-03 Thread Kandpal, Suraj
Hi Dmitry, Thanks for your comments > Could you please clarify, why do you want to use intel_connector for the > writeback connector? > I can see a usecase for sharing an encoder between the display and writback > pipelines (and if I'm not mistaken, this is the case for Abhinav's case). > Howev

RE: [RFC PATCH 0/3] i915 writeback private framework

2022-04-27 Thread Kandpal, Suraj
++Laurent ,Dmitry, and Abhinav Hi, Can you have a look at the private implementation i915 is currently going with till we can figure out how to work with drm core . Regards, Suraj Kandpal > A patch series was floated in the drm mailing list which aimed to change the > drm_connector and drm_enco

RE: [RFC PATCH 2/3] drm/i915: Define WD trancoder for i915

2022-04-27 Thread Kandpal, Suraj
++Laurent ,Dmitry, Abhinav and Rob > -Original Message- > From: Kandpal, Suraj > Sent: Thursday, April 21, 2022 10:38 AM > To: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org > Cc: Nikula, Jani ; ville.syrj...@linux.intel.com; > Murthy, Arun

RE: [RFC PATCH 3/3] drm/i915: Enabling WD Transcoder

2022-04-27 Thread Kandpal, Suraj
++Laurent ,Dmitry, Abhinav and Rob > Adding support for writeback transcoder to start capturing frames using > interrupt mechanism > > Signed-off-by: Suraj Kandpal > --- > drivers/gpu/drm/i915/Makefile | 1 + > drivers/gpu/drm/i915/display/intel_acpi.c | 1 + > drivers/gp

RE: [RFC PATCH 1/3] drm/i915: Creating writeback pipeline to bypass drm_writeback framework

2022-04-28 Thread Kandpal, Suraj
++Laurent ,Dmitry, and Abhinav > Changes to create a i915 private pipeline to enable the WD transcoder > without relying on the current drm_writeback framework. > > Signed-off-by: Suraj Kandpal > --- > drivers/gpu/drm/i915/Makefile | 1 + > .../drm/i915/display/intel_display_t

RE: [Intel-gfx] [PATCH 0/3] i915 private writeback framework

2022-05-04 Thread Kandpal, Suraj
Hi Daniel, > > A patch series was floated in the drm mailing list which aimed to > > change the drm_connector and drm_encoder fields to pointer in the > > drm_connector_writeback structure, this received a huge pushback from > > the community but since i915 expects each connector present in the >

RE: [PATCH v9 01/10] drm/hdcp: Add drm_hdcp_atomic_check()

2023-04-17 Thread Kandpal, Suraj
Yacoub > ; linux-ker...@vger.kernel.org > Subject: [PATCH v9 01/10] drm/hdcp: Add drm_hdcp_atomic_check() > > From: Sean Paul > > Move the hdcp atomic check from i915 to drm_hdcp so other drivers can use > it. No functional changes, just cleaned up some of the code when moving it > over. > > Ac

RE: [PATCH v9 02/10] drm/hdcp: Avoid changing crtc state in hdcp atomic check

2023-04-17 Thread Kandpal, Suraj
> > From: Sean Paul > > Instead of forcing a modeset in the hdcp atomic check, rename to > drm_hdcp_has_changed and return true if the content protection value is > changing and let the driver decide whether a modeset is required or not. > > Acked-by: Jani Nikula > Reviewed-by: Rodrigo Vivi >

RE: [PATCH v9 07/10] drm/i915/hdcp: Use HDCP helpers for i915

2023-04-17 Thread Kandpal, Suraj
> -Original Message- > From: Mark Yacoub > Sent: Wednesday, April 12, 2023 12:52 AM > To: Jani Nikula ; Joonas Lahtinen > ; Vivi, Rodrigo ; > Tvrtko Ursulin ; David Airlie > ; Daniel Vetter > Cc: seanp...@chromium.org; Kandpal, Suraj ; > diand...@

RE: [PATCH v8 04/10] drm/hdcp: Expand HDCP helper library for enable/disable/check

2023-04-02 Thread Kandpal, Suraj
> -Original Message- > From: Mark Yacoub > Sent: Saturday, April 1, 2023 3:42 AM > To: David Airlie ; Daniel Vetter > Cc: seanp...@chromium.org; Kandpal, Suraj ; > diand...@chromium.org; dri-devel@lists.freedesktop.org; > freedr...@lists.f

RE: [PATCH v8 06/10] drm/i915/hdcp: Retain hdcp_capable return codes

2023-04-02 Thread Kandpal, Suraj
> -Original Message- > From: Mark Yacoub > Sent: Saturday, April 1, 2023 3:42 AM > To: Jani Nikula ; Joonas Lahtinen > ; Vivi, Rodrigo ; > Tvrtko Ursulin ; David Airlie > ; Daniel Vetter > Cc: seanp...@chromium.org; Kandpal, Suraj ; > diand

RE: [PATCH v8 06/10] drm/i915/hdcp: Retain hdcp_capable return codes

2023-04-02 Thread Kandpal, Suraj
> -Original Message- > From: Kandpal, Suraj > Sent: Monday, April 3, 2023 12:12 PM > To: Mark Yacoub ; Jani Nikula > ; Joonas Lahtinen > ; Vivi, Rodrigo ; > Tvrtko Ursulin ; David Airlie > ; Daniel Vetter > Cc: seanp...@chromium.org; diand

RE: [PATCH v8 07/10] drm/i915/hdcp: Use HDCP helpers for i915

2023-04-03 Thread Kandpal, Suraj
> -Original Message- > From: Mark Yacoub > Sent: Saturday, April 1, 2023 3:42 AM > To: Jani Nikula ; Joonas Lahtinen > ; Vivi, Rodrigo ; > Tvrtko Ursulin ; David Airlie > ; Daniel Vetter > Cc: seanp...@chromium.org; Kandpal, Suraj ; > diand

RE: [PATCH 0/7] Enable YCbCr420 format for VDSC

2023-04-06 Thread Kandpal, Suraj
Hi Dmitry > -Original Message- > From: Dmitry Baryshkov > Sent: Friday, April 7, 2023 8:28 AM > To: Kandpal, Suraj ; Jani Nikula > ; dri-devel@lists.freedesktop.org; intel- > g...@lists.freedesktop.org > Cc: Nautiyal, Ankit K ; Shankar, Uma > ; Maarten Lankhorst

RE: [PATCH v4 08/12] drm/display/dsc: add YCbCr 4:2:2 and 4:2:0 RC parameters

2023-04-13 Thread Kandpal, Suraj
Hi, > Include RC parameters for YCbCr 4:2:2 and 4:2:0 configurations. > Looks Good to me Reviewed-by: Suraj Kandpal > Signed-off-by: Dmitry Baryshkov > --- > drivers/gpu/drm/display/drm_dsc_helper.c | 438 > +++ > include/drm/display/drm_dsc_helper.h | 2 + > 2 files

RE: [Intel-gfx] [PATCH v6 01/10] drm/hdcp: Add drm_hdcp_atomic_check()

2023-03-09 Thread Kandpal, Suraj
> > From: Sean Paul > > This patch moves the hdcp atomic check from i915 to drm_hdcp so other > drivers can use it. No functional changes, just cleaned up some of the code > when moving it over. > > Acked-by: Jani Nikula > Acked-by: Jani Nikula > Reviewed-by: Rodrigo Vivi > Reviewed-by: Abhi

RE: [Intel-gfx] [PATCH v6 02/10] drm/hdcp: Avoid changing crtc state in hdcp atomic check

2023-03-09 Thread Kandpal, Suraj
> -Original Message- > From: Intel-gfx On Behalf Of Mark > Yacoub > Sent: Thursday, January 19, 2023 1:00 AM > To: quic_khs...@quicinc.com; linux-arm-...@vger.kernel.org; dri- > de...@lists.freedesktop.org; freedr...@lists.freedesktop.org; > devicet...@vger.kernel.org; linux-ker...@vger

RE: [PATCH v6 06/10] drm/i915/hdcp: Retain hdcp_capable return codes

2023-03-10 Thread Kandpal, Suraj
> Subject: [PATCH v6 06/10] drm/i915/hdcp: Retain hdcp_capable return codes > > From: Sean Paul > > The shim functions return error codes, but they are discarded in > intel_hdcp.c. This patch plumbs the return codes through so they are > properly handled. > > Acked-by: Jani Nikula > Reviewed-b

RE: [Intel-gfx] [PATCH v6 07/10] drm/i915/hdcp: Use HDCP helpers for i915

2023-03-13 Thread Kandpal, Suraj
> > From: Sean Paul > > Now that all of the HDCP 1.x logic has been migrated to the central HDCP > helpers, use it in the i915 driver. > > The majority of the driver code for HDCP 1.x will live in intel_hdcp.c, > however there are a few helper hooks which are connector-specific and > need to be

RE: [PATCH v6 06/10] drm/i915/hdcp: Retain hdcp_capable return codes

2023-03-23 Thread Kandpal, Suraj
> -Original Message- > From: Kandpal, Suraj > Sent: Friday, March 10, 2023 1:55 PM > To: Mark Yacoub ; quic_khs...@quicinc.com; > linux-arm-...@vger.kernel.org; dri-devel@lists.freedesktop.org; > freedr...@lists.freedesktop.org; devicet...@vger.kernel

RE: [PATCH v6 06/10] drm/i915/hdcp: Retain hdcp_capable return codes

2023-03-27 Thread Kandpal, Suraj
> -Original Message- > From: Mark Yacoub > Sent: Saturday, March 25, 2023 12:57 AM > To: Kandpal, Suraj > Cc: quic_khs...@quicinc.com; linux-arm-...@vger.kernel.org; dri- > de...@lists.freedesktop.org; freedr...@lists.freedesktop.org; > devicet...@vger.

RE: [PATCH 0/7] Enable YCbCr420 format for VDSC

2023-03-28 Thread Kandpal, Suraj
> -Original Message- > From: dri-devel On Behalf Of Jani > Nikula > Sent: Wednesday, March 8, 2023 5:00 PM > To: Kandpal, Suraj ; dri- > de...@lists.freedesktop.org; intel-...@lists.freedesktop.org > Cc: Dmitry Baryshkov ; Nautiyal, Ankit K > ; Shankar

RE: [PATCH v5 6/8] drm/display/dsc: split DSC 1.2 and DSC 1.1 (pre-SCR) parameters

2023-05-16 Thread Kandpal, Suraj
> Subject: [PATCH v5 6/8] drm/display/dsc: split DSC 1.2 and DSC 1.1 (pre-SCR) > parameters > > The array of rc_parameters contains a mixture of parameters from DSC 1.1 > and DSC 1.2 standards. Split these tow configuration arrays in preparation to > adding more configuration data. > > Signed-off

RE: [PATCH v5 6/8] drm/display/dsc: split DSC 1.2 and DSC 1.1 (pre-SCR) parameters

2023-05-16 Thread Kandpal, Suraj
> > The array of rc_parameters contains a mixture of parameters from DSC 1.1 > and DSC 1.2 standards. Split these tow configuration arrays in preparation to > adding more configuration data. > Hi , Needed to add some more comments apart from the previous ones already given > Signed-off-by: Dmit

RE: [PATCH v6 6/8] drm/display/dsc: split DSC 1.2 and DSC 1.1 (pre-SCR) parameters

2023-05-16 Thread Kandpal, Suraj
> > The array of rc_parameters contains a mixture of parameters from DSC 1.1 > and DSC 1.2 standards. Split these tow configuration arrays in preparation to > adding more configuration data. > > Signed-off-by: Dmitry Baryshkov > --- > drivers/gpu/drm/display/drm_dsc_helper.c | 139

RE: [Freedreno] [PATCH v5 6/8] drm/display/dsc: split DSC 1.2 and DSC 1.1 (pre-SCR) parameters

2023-05-16 Thread Kandpal, Suraj
> -Original Message- > From: Dmitry Baryshkov > Sent: Wednesday, May 17, 2023 5:33 AM > To: Kandpal, Suraj ; David Airlie > ; Daniel Vetter ; Jani Nikula > ; Joonas Lahtinen > ; Vivi, Rodrigo ; > Tvrtko Ursulin ; Rob Clark > ; Abhinav Kumar ; > Sean Paul ;

RE: [PATCH v7 6/8] drm/display/dsc: split DSC 1.2 and DSC 1.1 (pre-SCR) parameters

2023-05-17 Thread Kandpal, Suraj
> > The array of rc_parameters contains a mixture of parameters from DSC 1.1 > and DSC 1.2 standards. Split these tow configuration arrays in preparation to > adding more configuration data. > > Signed-off-by: Dmitry Baryshkov LGTM. Reviewed-by: Suraj Kandpal > --- > drivers/gpu/drm/display/

RE: [PATCH v7 6/8] drm/display/dsc: split DSC 1.2 and DSC 1.1 (pre-SCR) parameters

2023-05-19 Thread Kandpal, Suraj
> -Original Message- > From: Dmitry Baryshkov > Sent: Wednesday, May 17, 2023 3:58 PM > To: David Airlie ; Daniel Vetter ; Jani > Nikula ; Kandpal, Suraj > ; Joonas Lahtinen > ; Vivi, Rodrigo ; > Tvrtko Ursulin ; Rob Clark > ; Abhinav Kumar ; > Sean Paul ;

RE: [PATCH 1/8] drm/display/dp: Add helper function to get DSC bpp prescision

2023-09-12 Thread Kandpal, Suraj
> Subject: [PATCH 1/8] drm/display/dp: Add helper function to get DSC bpp > prescision > > From: Ankit Nautiyal > > Add helper to get the DSC bits_per_pixel precision for the DP sink. > LGTM. Reviewed-by: Suraj Kandpal > Signed-off-by: Ankit Nautiyal > --- > drivers/gpu/drm/display/drm_dp

RE: [PATCH 2/8] drm/i915/display: Store compressed bpp in U6.4 format

2023-09-12 Thread Kandpal, Suraj
> Subject: [PATCH 2/8] drm/i915/display: Store compressed bpp in U6.4 format > > From: Ankit Nautiyal > > DSC parameter bits_per_pixel is stored in U6.4 format. > The 4 bits represent the fractional part of the bpp. > Currently we use compressed_bpp member of dsc structure to store only the > in

RE: [PATCH 1/8] drm/display/dp: Add helper function to get DSC bpp prescision

2023-09-12 Thread Kandpal, Suraj
> Subject: [PATCH 1/8] drm/display/dp: Add helper function to get DSC bpp > prescision > > From: Ankit Nautiyal > > Add helper to get the DSC bits_per_pixel precision for the DP sink. > I think you forgot to add my reviewed by that I gave in the last revision 😝 Anyways, LGTM. Reviewed-by: Su

RE: [PATCH 09/11] drm/i915/dp_mst: Use precision of 1/16 for computing bpp

2023-11-11 Thread Kandpal, Suraj
> -Original Message- > From: Nautiyal, Ankit K > Sent: Friday, November 10, 2023 3:40 PM > To: dri-devel@lists.freedesktop.org; intel-...@lists.freedesktop.org > Cc: Sharma, Swati2 ; Kulkarni, Vandita > ; Kandpal, Suraj ; > suijingf...@loongson.cn > Subject

RE: [PATCH 10/11] drm/i916/dp_mst: Iterate over the DSC bpps as per DSC precision support

2023-11-11 Thread Kandpal, Suraj
> Subject: [PATCH 10/11] drm/i916/dp_mst: Iterate over the DSC bpps as per > DSC precision support > > Currently we iterate over the bpp_x16 in step of 16. > Use DSC fractional bpp precision supported by the sink to compute the > appropriate steps to iterate over the bpps. > LGTM. Reviewed-by:

RE: [PATCH 11/11] drm/i915/dp_mst: Add support for forcing dsc fractional bpp via debugfs

2023-11-11 Thread Kandpal, Suraj
> -Original Message- > From: Nautiyal, Ankit K > Sent: Friday, November 10, 2023 3:40 PM > To: dri-devel@lists.freedesktop.org; intel-...@lists.freedesktop.org > Cc: Sharma, Swati2 ; Kulkarni, Vandita > ; Kandpal, Suraj ; > suijingf...@loongson.cn > Subject

RE: [PATCH 02/11] drm/i915/display: Store compressed bpp in U6.4 format

2023-11-14 Thread Kandpal, Suraj
> -Original Message- > From: Nautiyal, Ankit K > Sent: Friday, November 10, 2023 3:40 PM > To: dri-devel@lists.freedesktop.org; intel-...@lists.freedesktop.org > Cc: Sharma, Swati2 ; Kulkarni, Vandita > ; Kandpal, Suraj ; > suijingf...@loongson.cn > Subject

RE: [PATCH 03/11] drm/i915/display: Consider fractional vdsc bpp while computing m_n values

2023-11-14 Thread Kandpal, Suraj
> MTL+ supports fractional compressed bits_per_pixel, with precision of > 1/16. This compressed bpp is stored in U6.4 format. > Accommodate this precision while computing m_n values. > > v1: > Replace the computation of 'data_clock' with 'data_clock = > DIV_ROUND_UP(data_clock, 16).' (Sui Jingfe

RE: [PATCH 04/11] drm/i915/audio: Consider fractional vdsc bpp while computing tu_data

2023-11-14 Thread Kandpal, Suraj
> MTL+ supports fractional compressed bits_per_pixel, with precision of > 1/16. This compressed bpp is stored in U6.4 format. > Accommodate the precision during calculation of transfer unit data for > hblank_early calculation. > > v2: > -Fix tu_data calculation while dealing with U6.4 format. (Sta

RE: [PATCHv4 5/7] drm/i915/histogram: Add crtc properties for global histogram

2024-10-24 Thread Kandpal, Suraj
> -Original Message- > From: dri-devel On Behalf Of > Arun R Murthy > Sent: Wednesday, September 25, 2024 8:38 PM > To: intel...@lists.freedesktop.org; intel-...@lists.freedesktop.org; dri- > de...@lists.freedesktop.org > Cc: Murthy, Arun R > Subject: [PATCHv4 5/7] drm/i915/histogram:

RE: [PATCH] drm/xe/hdcp: Fix logic errors

2024-10-28 Thread Kandpal, Suraj
> -Original Message- > From: dri-devel On Behalf Of > 1064094...@qq.com > Sent: Monday, October 28, 2024 3:13 PM > To: Jani Nikula > Cc: Vivi, Rodrigo ; De Marchi, Lucas > ; Thomas ; > Maarten Lankhorst ; Maxime Ripard > ; Thomas Zimmermann ; > David Airlie ; Simona Vetter ; intel- > g

RE: [PATCHv2 2/7] drm/i915/histogram: Add support for histogram

2024-10-23 Thread Kandpal, Suraj
> -Original Message- > From: dri-devel On Behalf Of > Arun R Murthy > Sent: Wednesday, September 25, 2024 8:38 PM > To: intel...@lists.freedesktop.org; intel-...@lists.freedesktop.org; dri- > de...@lists.freedesktop.org > Cc: Murthy, Arun R > Subject: [PATCHv2 2/7] drm/i915/histogram: A

RE: [PATCHv2 2/7] drm/i915/histogram: Add support for histogram

2024-10-23 Thread Kandpal, Suraj
> -Original Message- > From: dri-devel On Behalf Of > Arun R Murthy > Sent: Wednesday, September 25, 2024 8:38 PM > To: intel...@lists.freedesktop.org; intel-...@lists.freedesktop.org; dri- > de...@lists.freedesktop.org > Cc: Murthy, Arun R > Subject: [PATCHv2 2/7] drm/i915/histogram: A

RE: [PATCHv4 4/7] drm/i915/histogram: histogram interrupt handling

2024-10-23 Thread Kandpal, Suraj
> -Original Message- > From: dri-devel On Behalf Of > Arun R Murthy > Sent: Wednesday, September 25, 2024 8:38 PM > To: intel...@lists.freedesktop.org; intel-...@lists.freedesktop.org; dri- > de...@lists.freedesktop.org > Cc: Murthy, Arun R > Subject: [PATCHv4 4/7] drm/i915/histogram:

RE: [PATCHv3 1/6] drm/i915/histogram: Add support for histogram

2024-09-24 Thread Kandpal, Suraj
> -Original Message- > From: Intel-gfx On Behalf Of Arun > R Murthy > Sent: Thursday, September 19, 2024 7:02 PM > To: intel...@lists.freedesktop.org; intel-...@lists.freedesktop.org; dri- > de...@lists.freedesktop.org > Cc: Murthy, Arun R > Subject: [PATCHv3 1/6] drm/i915/histogram: Ad

RE: [PATCHv3 2/6] drm/xe: Add histogram support to Xe builds

2024-09-24 Thread Kandpal, Suraj
> -Original Message- > From: Intel-gfx On Behalf Of Arun > R Murthy > Sent: Thursday, September 19, 2024 7:02 PM > To: intel...@lists.freedesktop.org; intel-...@lists.freedesktop.org; dri- > de...@lists.freedesktop.org > Cc: Murthy, Arun R > Subject: [PATCHv3 2/6] drm/xe: Add histogram

RE: [PATCHv3 1/6] drm/i915/histogram: Add support for histogram

2024-09-24 Thread Kandpal, Suraj
> -Original Message- > From: Intel-gfx On Behalf Of > Kandpal, Suraj > Sent: Wednesday, September 25, 2024 11:02 AM > To: Murthy, Arun R ; intel- > x...@lists.freedesktop.org; intel-...@lists.freedesktop.org; dri- > de...@lists.freedesktop.org > Cc: Murth

RE: [PATCHv3 5/6] drm/i915/histogram: histogram delay counter doesnt reset

2024-09-24 Thread Kandpal, Suraj
> -Original Message- > From: Intel-gfx On Behalf Of Arun > R Murthy > Sent: Thursday, September 19, 2024 7:02 PM > To: intel...@lists.freedesktop.org; intel-...@lists.freedesktop.org; dri- > de...@lists.freedesktop.org > Cc: Murthy, Arun R > Subject: [PATCHv3 5/6] drm/i915/histogram: h

RE: [PATCHv6 7/8] drm/i915/histogram: Histogram changes for Display 20+

2024-11-22 Thread Kandpal, Suraj
> -Original Message- > From: Murthy, Arun R > Sent: Thursday, November 21, 2024 8:10 PM > To: Kandpal, Suraj ; intel...@lists.freedesktop.org; > intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org > Subject: RE: [PATCHv6 7/8] drm/i915/histogram: His

RE: [PATCH 8/8] drm/i915/histogram: Enable pipe dithering

2024-11-20 Thread Kandpal, Suraj
> -Original Message- > From: Intel-gfx On Behalf Of Arun > R Murthy > Sent: Tuesday, November 19, 2024 4:15 PM > To: intel...@lists.freedesktop.org; intel-...@lists.freedesktop.org; dri- > de...@lists.freedesktop.org > Cc: Murthy, Arun R > Subject: [PATCH 8/8] drm/i915/histogram: Enabl

RE: [PATCHv5 5/8] drm/i915/histogram: Add crtc properties for global histogram

2024-11-20 Thread Kandpal, Suraj
> -Original Message- > From: dri-devel On Behalf Of > Arun R Murthy > Sent: Tuesday, November 19, 2024 4:15 PM > To: intel...@lists.freedesktop.org; intel-...@lists.freedesktop.org; dri- > de...@lists.freedesktop.org > Cc: Murthy, Arun R > Subject: [PATCHv5 5/8] drm/i915/histogram: Add

RE: [PATCH 6/8] drm/i915/histogram: histogram delay counter doesnt reset

2024-11-20 Thread Kandpal, Suraj
> -Original Message- > From: Intel-xe On Behalf Of Arun R > Murthy > Sent: Tuesday, November 19, 2024 4:15 PM > To: intel...@lists.freedesktop.org; intel-...@lists.freedesktop.org; dri- > de...@lists.freedesktop.org > Cc: Murthy, Arun R > Subject: [PATCH 6/8] drm/i915/histogram: histog

RE: [PATCHv4 7/8] drm/i915/histogram: Histogram changes for Display 20+

2024-11-20 Thread Kandpal, Suraj
> -Original Message- > From: Intel-xe On Behalf Of Arun R > Murthy > Sent: Tuesday, November 19, 2024 4:15 PM > To: intel...@lists.freedesktop.org; intel-...@lists.freedesktop.org; dri- > de...@lists.freedesktop.org > Cc: Murthy, Arun R > Subject: [PATCHv4 7/8] drm/i915/histogram: Hist

RE: [PATCHv2 1/8] drm/i915/histogram: Define registers for histogram

2024-11-19 Thread Kandpal, Suraj
> -Original Message- > From: Intel-xe On Behalf Of Arun R > Murthy > Sent: Tuesday, November 19, 2024 4:15 PM > To: intel...@lists.freedesktop.org; intel-...@lists.freedesktop.org; dri- > de...@lists.freedesktop.org > Cc: Murthy, Arun R > Subject: [PATCHv2 1/8] drm/i915/histogram: Defin

RE: [PATCHv4 2/8] drm/i915/histogram: Add support for histogram

2024-11-20 Thread Kandpal, Suraj
> -Original Message- > From: Intel-xe On Behalf Of Arun R > Murthy > Sent: Tuesday, November 19, 2024 4:15 PM > To: intel...@lists.freedesktop.org; intel-...@lists.freedesktop.org; dri- > de...@lists.freedesktop.org > Cc: Murthy, Arun R > Subject: [PATCHv4 2/8] drm/i915/histogram: Add s

RE: [PATCH 3/7] drm/i915/backlight: Check Nits based brightness control for VESA

2025-02-04 Thread Kandpal, Suraj
> -Original Message- > From: Jani Nikula > Sent: Tuesday, February 4, 2025 2:15 PM > To: Kandpal, Suraj ; intel...@lists.freedesktop.org; > intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org > Cc: Shankar, Uma ; Murthy, Arun R > ; Kao, Ben ; Kandpa

RE: [PATCH v5 3/4] drm/i915/dp: Use the generic helper to control LTTPR transparent mode

2025-02-05 Thread Kandpal, Suraj
> -Original Message- > From: dri-devel On Behalf Of Abel > Vesa > Sent: Monday, February 3, 2025 4:28 PM > To: Maarten Lankhorst ; Maxime Ripard > ; Thomas Zimmermann ; > David Airlie ; Simona Vetter ; Karol > Herbst ; Lyude Paul ; Danilo > Krummrich ; Jani Nikula ; > Vivi, Rodrigo ; Joo

RE: [PATCH 1/8] drm/dp: Add eDP 1.5 bit definition

2025-02-05 Thread Kandpal, Suraj
> -Original Message- > From: Kandpal, Suraj > Sent: Thursday, February 6, 2025 12:03 PM > To: intel...@lists.freedesktop.org; intel-...@lists.freedesktop.org; dri- > de...@lists.freedesktop.org > Cc: Shankar, Uma ; Murthy, Arun R > ; Kao, Ben ; Kandpal, Suraj >

RE: [PATCH 2/8] drm/dp: Increase eDP display control capability size

2025-02-05 Thread Kandpal, Suraj
> -Original Message- > From: Murthy, Arun R > Sent: Thursday, February 6, 2025 12:13 PM > To: Kandpal, Suraj ; intel...@lists.freedesktop.org; > intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org > Cc: Shankar, Uma ; Kao, Ben > Subject: RE: [PATCH

RE: [PATCH 3/7] drm/i915/backlight: Check Luminance based brightness control for VESA

2025-02-05 Thread Kandpal, Suraj
> -Original Message- > From: Murthy, Arun R > Sent: Wednesday, February 5, 2025 8:14 PM > To: Kandpal, Suraj ; intel...@lists.freedesktop.org; > intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org > Cc: Shankar, Uma ; Nikula, Jani > ; Kao, Ben >

RE: [PATCH 4/7] drm/i915/backlight: Modify function to get VESA brightness in Nits

2025-02-05 Thread Kandpal, Suraj
> -Original Message- > From: Murthy, Arun R > Sent: Wednesday, February 5, 2025 9:40 PM > To: Kandpal, Suraj ; intel...@lists.freedesktop.org; > intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org > Cc: Shankar, Uma ; Nikula, Jani > ; Kao, Ben >

RE: [PATCHv2 10/10] drm/i915/histogram: Enable pipe dithering

2024-12-10 Thread Kandpal, Suraj
> -Original Message- > From: Intel-xe On Behalf Of Arun R > Murthy > Sent: Monday, December 9, 2024 9:55 PM > To: intel...@lists.freedesktop.org; intel-...@lists.freedesktop.org; dri- > de...@lists.freedesktop.org > Cc: Murthy, Arun R > Subject: [PATCHv2 10/10] drm/i915/histogram: Enab

RE: [PATCHv3 07/10] drm/i915/display: Handle drm-crtc histogram property updates

2024-12-10 Thread Kandpal, Suraj
> -Original Message- > From: dri-devel On Behalf Of > Arun R Murthy > Sent: Monday, December 9, 2024 9:55 PM > To: intel...@lists.freedesktop.org; intel-...@lists.freedesktop.org; dri- > de...@lists.freedesktop.org > Cc: Murthy, Arun R > Subject: [PATCHv3 07/10] drm/i915/display: Handl

RE: [PATCHv6 7/8] drm/i915/histogram: Histogram changes for Display 20+

2024-11-21 Thread Kandpal, Suraj
> -Original Message- > From: dri-devel On Behalf Of > Arun R Murthy > Sent: Thursday, November 21, 2024 5:56 PM > To: intel...@lists.freedesktop.org; intel-...@lists.freedesktop.org; dri- > de...@lists.freedesktop.org > Cc: Murthy, Arun R > Subject: [PATCHv6 7/8] drm/i915/histogram: Hi

RE: [PATCHv5 2/8] drm/i915/histogram: Add support for histogram

2024-11-21 Thread Kandpal, Suraj
> -Original Message- > From: Intel-xe On Behalf Of Arun R > Murthy > Sent: Thursday, November 21, 2024 5:56 PM > To: intel...@lists.freedesktop.org; intel-...@lists.freedesktop.org; dri- > de...@lists.freedesktop.org > Cc: Murthy, Arun R > Subject: [PATCHv5 2/8] drm/i915/histogram: Add

RE: [PATCHv2 6/8] drm/i915/histogram: histogram delay counter doesnt reset

2024-11-21 Thread Kandpal, Suraj
> -Original Message- > From: Intel-gfx On Behalf Of Arun > R Murthy > Sent: Thursday, November 21, 2024 5:56 PM > To: intel...@lists.freedesktop.org; intel-...@lists.freedesktop.org; dri- > de...@lists.freedesktop.org > Cc: Murthy, Arun R > Subject: [PATCHv2 6/8] drm/i915/histogram: hi

RE: [PATCHv6 7/8] drm/i915/histogram: Histogram changes for Display 20+

2024-11-22 Thread Kandpal, Suraj
> -Original Message- > From: Murthy, Arun R > Sent: Friday, November 22, 2024 1:49 PM > To: Kandpal, Suraj ; intel...@lists.freedesktop.org; > intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org > Subject: RE: [PATCHv6 7/8] drm/i915/histogram: His

RE: [PATCHv5 06/10] drm/i915/histogram: histogram interrupt handling

2024-12-03 Thread Kandpal, Suraj
> -Original Message- > From: Intel-gfx On Behalf Of Arun > R Murthy > Sent: Tuesday, December 3, 2024 11:25 AM > To: intel...@lists.freedesktop.org; intel-...@lists.freedesktop.org; dri- > de...@lists.freedesktop.org > Cc: Murthy, Arun R > Subject: [PATCHv5 06/10] drm/i915/histogram: h

RE: [PATCH 07/10] drm/i915/display: handle drm-crtc histogram property updates

2024-12-03 Thread Kandpal, Suraj
> -Original Message- > From: dri-devel On Behalf Of > Arun R Murthy > Sent: Tuesday, December 3, 2024 11:25 AM > To: intel...@lists.freedesktop.org; intel-...@lists.freedesktop.org; dri- > de...@lists.freedesktop.org > Cc: Murthy, Arun R > Subject: [PATCH 07/10] drm/i915/display: handl

RE: [PATCHv3 08/10] drm/i915/histogram: histogram delay counter doesnt reset

2024-12-03 Thread Kandpal, Suraj
> -Original Message- > From: dri-devel On Behalf Of > Arun R Murthy > Sent: Tuesday, December 3, 2024 11:25 AM > To: intel...@lists.freedesktop.org; intel-...@lists.freedesktop.org; dri- > de...@lists.freedesktop.org > Cc: Murthy, Arun R > Subject: [PATCHv3 08/10] drm/i915/histogram: h

RE: [PATCH 01/10] drm/crtc: Add histogram properties

2024-12-03 Thread Kandpal, Suraj
> -Original Message- > From: Intel-xe On Behalf Of Arun R > Murthy > Sent: Tuesday, December 3, 2024 11:25 AM > To: intel...@lists.freedesktop.org; intel-...@lists.freedesktop.org; dri- > de...@lists.freedesktop.org > Cc: Murthy, Arun R > Subject: [PATCH 01/10] drm/crtc: Add histogram

RE: [PATCHv6 09/10] drm/i915/histogram: Histogram changes for Display 20+

2024-12-03 Thread Kandpal, Suraj
> -Original Message- > From: dri-devel On Behalf Of > Arun R Murthy > Sent: Tuesday, December 3, 2024 11:25 AM > To: intel...@lists.freedesktop.org; intel-...@lists.freedesktop.org; dri- > de...@lists.freedesktop.org > Cc: Murthy, Arun R > Subject: [PATCHv6 09/10] drm/i915/histogram: H

RE: [PATCH v7 14/14] drm/i915/histogram: Enable pipe dithering

2025-01-09 Thread Kandpal, Suraj
> -Original Message- > From: Murthy, Arun R > Sent: Friday, January 10, 2025 1:16 AM > To: dri-devel@lists.freedesktop.org; intel-...@lists.freedesktop.org; intel- > x...@lists.freedesktop.org > Cc: dmitry.barysh...@linaro.org; Kandpal, Suraj ; > Shankar, Uma ; &qu

RE: [PATCH 2/2] drm/i915/lttpr: Enable Extended Wake Timeout

2025-01-20 Thread Kandpal, Suraj
> -Original Message- > From: Dmitry Baryshkov > Sent: Friday, January 17, 2025 11:50 AM > To: Kandpal, Suraj > Cc: intel...@lists.freedesktop.org; intel-...@lists.freedesktop.org; dri- > de...@lists.freedesktop.org; Murthy, Arun R > Subject: Re: [PATCH 2/2] d

RE: [PATCH v8 01/14] drm: Define histogram structures exposed to user

2025-02-14 Thread Kandpal, Suraj
> -Original Message- > From: Kandpal, Suraj > Sent: Friday, February 14, 2025 12:09 PM > To: Murthy, Arun R ; intel...@lists.freedesktop.org; > intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org > Cc: dmitry.barysh...@linaro.org > Subject: RE: [PATCH

RE: [PATCH v8 01/14] drm: Define histogram structures exposed to user

2025-02-13 Thread Kandpal, Suraj
> -Original Message- > From: Murthy, Arun R > Sent: Tuesday, January 28, 2025 9:21 PM > To: intel...@lists.freedesktop.org; intel-...@lists.freedesktop.org; dri- > de...@lists.freedesktop.org > Cc: Kandpal, Suraj ; dmitry.barysh...@linaro.org; > Murthy, Arun R &g

RE: [PATCH v8 10/14] drm/i915/iet: Add support to writing the IET LUT data

2025-02-16 Thread Kandpal, Suraj
> -Original Message- > From: Murthy, Arun R > Sent: Tuesday, January 28, 2025 9:21 PM > To: intel...@lists.freedesktop.org; intel-...@lists.freedesktop.org; dri- > de...@lists.freedesktop.org > Cc: Kandpal, Suraj ; dmitry.barysh...@linaro.org; > Murthy, Arun R &g

  1   2   >