[PATCH] drm: bridge: adv7511: Add set_jack handler

2021-01-19 Thread Jun Nie
With commit 55c5cc63ab, the hdmi_codec_set_jack() will report unsupport failure if set_jack handler is missing. Add set_jack handler to resolve this failure. Signed-off-by: Jun Nie --- .../gpu/drm/bridge/adv7511/adv7511_audio.c| 27 ++- 1 file changed, 20 insertions(+), 7

Re: [PATCH] drm: bridge: adv7511: Add set_jack handler

2021-02-02 Thread Jun Nie
Jun Nie 于2021年1月19日周二 下午12:42写道: > > With commit 55c5cc63ab, the hdmi_codec_set_jack() will report unsupport > failure if set_jack handler is missing. Add set_jack handler to resolve > this failure. > > Signed-off-by: Jun Nie > --- > .../gpu/drm/bridge/adv7511

[PATCH 00/21] drm/msm: Support quad pipe with dual-DSI

2024-08-29 Thread Jun Nie
: Jun Nie --- Jonathan Marek (3): drm/msm/dsi: add support to DSI CTRL v2.8.0 drm/msm/dsi: fix DSC width for the bonded DSI case drm/msm/dsi: support DSC configurations with slice_per_pkt > 1 Jun Nie (18): drm/msm/dsi: pass the right width to dsc drm/msm/dpu: polish

[PATCH 01/21] drm/msm/dsi: add support to DSI CTRL v2.8.0

2024-08-29 Thread Jun Nie
From: Jonathan Marek Add support to DSI CTRL v2.8.0 with priority support Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/dsi/dsi_host.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c index 185d7de0bf376

[PATCH 02/21] drm/msm/dsi: fix DSC width for the bonded DSI case

2024-08-29 Thread Jun Nie
that behave like single panel for display controller. Signed-off-by: Jonathan Marek Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/dsi/dsi.h | 3 ++- drivers/gpu/drm/msm/dsi/dsi_host.c| 6 +- drivers/gpu/drm/msm/dsi/dsi_manager.c | 2 +- 3 files changed, 8 insertions(+), 3

[PATCH 03/21] drm/msm/dsi: pass the right width to dsc

2024-08-29 Thread Jun Nie
Data width for dsc engine is aligned with pipe, not with whole screen width. Because the width may be halved in DSI bonded case. The dsc width is not related to the timing with back front porch in later stage, so update dsc timing earlier. Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/dsi

[PATCH 04/21] drm/msm/dsi: support DSC configurations with slice_per_pkt > 1

2024-08-29 Thread Jun Nie
incorrect. Signed-off-by: Jonathan Marek Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/dsi/dsi_host.c | 25 ++--- include/drm/drm_mipi_dsi.h | 2 ++ 2 files changed, 12 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/d

[PATCH 05/21] drm/msm/dpu: polish log for resource allocation

2024-08-29 Thread Jun Nie
Add resource allocation type info. Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 23 +++ 1 file changed, 19 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c index 15b42a6683639

[PATCH 06/21] drm/msm/dpu: Add utility to get mixer number

2024-08-29 Thread Jun Nie
Add utility to get mixer number via CRTC handler Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 7 +++ drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h | 5 + 2 files changed, 12 insertions(+) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c b/drivers/gpu/drm/msm

[PATCH 07/21] drm/msm/dpu: Support dynamic DSC number

2024-08-29 Thread Jun Nie
Do not assume DSC number as 2. Because there are 4 DSC in quad pipe case. Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b/drivers/gpu/drm/msm/disp/dpu1

[PATCH 08/21] drm/msm/dpu: decide right side per last bit

2024-08-29 Thread Jun Nie
in case of multiple mixer pairs Signed-off-by: Jun Nie Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c index

[PATCH 09/21] drm/msm/dpu: request more mixer for 4K+ DSC case

2024-08-29 Thread Jun Nie
request more mixer for the case that hdisplay exceeding 4096 and DSC enabled. Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 24 1 file changed, 20 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b

[PATCH 10/21] drm/msm/dpu: fix lm number counter for quad-pipe

2024-08-29 Thread Jun Nie
Add the case to reserve multiple pair mixer for high resolution Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 6 +++--- drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 8 +++- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/msm/disp

[PATCH 11/21] drm/msm/dpu: Support 4 mixers at most

2024-08-29 Thread Jun Nie
Support 4 mixers case with increasing array size and checking the usage case. Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 2 +- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h | 6 +++--- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h | 3 ++- drivers/gpu

[PATCH 12/21] drm/msm/dpu: switch RM to use crtc_id rather than enc_id for allocation

2024-08-29 Thread Jun Nie
operation. While the sspp assignment is in drm_atomic_helper_check_planes() call tree. So CRTC is more central than encoder. Siwtching the id achieves above goal. Co-developed-by: Dmitry Baryshkov Signed-off-by: Dmitry Baryshkov Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1

[PATCH 13/21] drm/msm/dpu: Support quad pipe in header files

2024-08-29 Thread Jun Nie
Support 4 pipes and their configs at most. They are for 2 SSPP and their multi-rect mode. Because one SSPP can co-work with 2 mixer at most, 2 pair of mixer are needed for 2 SSPP in quad- pipe case. So 2 mixer configs are needed in quad-pipe case. Signed-off-by: Jun Nie --- drivers/gpu/drm/msm

[PATCH 14/21] drm/msm/dpu: Support quad-pipe in SSPP checking

2024-08-29 Thread Jun Nie
Support quad-pipe in SSPP checking with unified method Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 108 ++ 1 file changed, 51 insertions(+), 57 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c b/drivers/gpu/drm/msm/disp

[PATCH 15/21] drm/msm/dpu: support plane splitting in quad-pipe case

2024-08-29 Thread Jun Nie
Clip plane into SSPPs per left and right half screen per ROI if topology is quad pipe. Then split the split rectangle by half if the clip width still exceed limit. Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 97 ++- 1 file changed, 71

[PATCH 16/21] drm/msm/dpu: support SSPP assignment for quad-pipe case

2024-08-29 Thread Jun Nie
Support SSPP assignment for quad-pipe case with unified method Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 58 +-- 1 file changed, 25 insertions(+), 33 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c b/drivers/gpu/drm

[PATCH 17/21] drm/msm/dpu: setup pipes with 2 set of stage config

2024-08-29 Thread Jun Nie
The first 2 fields in multirect_index and stage array are for the first SSPP and its multi-rect. And the later 2 fields are for the 2nd SSPP and its multi-rect. Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 76 +++- 1 file changed, 55

[PATCH 18/21] drm/msm/dpu: blend pipes by left and right

2024-08-29 Thread Jun Nie
Blend pipes by left and right. The first 2 pipes are for left half screen and the later 2 pipes are for right in quad pipe case. Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c| 13 +++-- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 10 +++--- drivers/gpu

[PATCH 19/21] drm/msm/dpu: bind correct pingpong for quad pipe

2024-08-29 Thread Jun Nie
There are 2 interface and 4 PP in quad pipe. Map the 2nd interface to 3rd PP instead of the 2nd PP. Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c

[PATCH 20/21] drm/msm/dpu: support quad pipe in general operations

2024-08-29 Thread Jun Nie
Support quad pipe in general operations with unified method. Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 87 +-- 1 file changed, 47 insertions(+), 40 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c b/drivers/gpu/drm

[PATCH 21/21] drm/msm/dpu: revise debug info to support quad pipe

2024-08-29 Thread Jun Nie
Unify debug info to support dual pipe and quad pipe Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 16 +++--- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 35 +-- 2 files changed, 21 insertions(+), 30 deletions(-) diff --git a/drivers

Re: [PATCH 03/21] drm/msm/dsi: pass the right width to dsc

2024-09-03 Thread Jun Nie
Dmitry Baryshkov 于2024年8月29日周四 18:57写道: > > On Thu, 29 Aug 2024 at 13:19, Jun Nie wrote: > > > > Data width for dsc engine is aligned with pipe, not with whole screen > > width. Because the width may be halved in DSI bonded case. > > Can't really parse this. P

Re: [PATCH 06/21] drm/msm/dpu: Add utility to get mixer number

2024-09-03 Thread Jun Nie
Dmitry Baryshkov 于2024年8月29日周四 19:07写道: > > On Thu, 29 Aug 2024 at 13:19, Jun Nie wrote: > > > > Add utility to get mixer number via CRTC handler > > > > Signed-off-by: Jun Nie > > --- > > drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 7 +++ > &g

Re: [PATCH 07/21] drm/msm/dpu: Support dynamic DSC number

2024-09-03 Thread Jun Nie
Dmitry Baryshkov 于2024年8月29日周四 19:10写道: > > On Thu, 29 Aug 2024 at 13:20, Jun Nie wrote: > > > > Do not assume DSC number as 2. Because there are 4 DSC in > > quad pipe case. > > Please expand the commit message. You prefer brevity, but your > comments lack cla

Re: [PATCH 09/21] drm/msm/dpu: request more mixer for 4K+ DSC case

2024-09-03 Thread Jun Nie
Dmitry Baryshkov 于2024年8月29日周四 19:12写道: > > On Thu, 29 Aug 2024 at 13:20, Jun Nie wrote: > > > > request more mixer for the case that hdisplay exceeding 4096 > > and DSC enabled. > > This doesn't seem to match the code. And it misses the _reason_ to do it.

Re: [PATCH 10/21] drm/msm/dpu: fix lm number counter for quad-pipe

2024-09-03 Thread Jun Nie
Dmitry Baryshkov 于2024年8月29日周四 19:17写道: > > On Thu, 29 Aug 2024 at 13:20, Jun Nie wrote: > > > > Add the case to reserve multiple pair mixer for high resolution > > I think you already know what is missing here. Add the case to reserve multiple pair mixer for high resol

Re: [PATCH 13/21] drm/msm/dpu: Support quad pipe in header files

2024-09-03 Thread Jun Nie
Dmitry Baryshkov 于2024年8月29日周四 19:30写道: > > On Thu, 29 Aug 2024 at 13:20, Jun Nie wrote: > > > > Support 4 pipes and their configs at most. They are for 2 SSPP > > and their multi-rect mode. Because one SSPP can co-work with > > 2 mixer at most, 2 pair of mixer

Re: [PATCH 14/21] drm/msm/dpu: Support quad-pipe in SSPP checking

2024-09-03 Thread Jun Nie
Dmitry Baryshkov 于2024年8月29日周四 19:38写道: > > > @@ -1033,13 +1030,10 @@ static int dpu_plane_atomic_check(struct drm_plane > > *plane, > > return -E2BIG; > > } > > > > - /* > > -* Use multirect for wide plane. We do not support d

Re: [PATCH 18/21] drm/msm/dpu: blend pipes by left and right

2024-09-03 Thread Jun Nie
Dmitry Baryshkov 于2024年8月29日周四 19:51写道: > > On Thu, 29 Aug 2024 at 13:21, Jun Nie wrote: > > > > Blend pipes by left and right. The first 2 pipes are for > > left half screen and the later 2 pipes are for right in quad > > pipe case. > > > > Signed-off

Re: [PATCH 03/21] drm/msm/dsi: pass the right width to dsc

2024-09-03 Thread Jun Nie
Marijn Suijten 于2024年9月3日周二 18:12写道: > > On 2024-08-29 18:17:32, Jun Nie wrote: > > Data width for dsc engine is aligned with pipe, not with whole screen > > width. Because the width may be halved in DSI bonded case. > > > > The dsc width is not related to the t

[PATCH v4 0/5] Add DSC support to DSI video panel

2024-05-24 Thread Jun Nie
test it. - Address comments from version 2. Signed-off-by: Jun Nie --- Jonathan Marek (4): drm/msm/dpu: fix video mode DSC for DSI drm/msm/dsi: set video mode widebus enable bit when widebus is enabled drm/msm/dsi: set VIDEO_COMPRESSION_MODE_CTRL_WC drm/msm/dsi: add a comme

[PATCH v4 1/5] drm/msm/dpu: fix video mode DSC for DSI

2024-05-24 Thread Jun Nie
From: Jonathan Marek Add necessary DPU timing and control changes for DSC to work with DSI video mode. Signed-off-by: Jonathan Marek Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 2 +- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h | 8

[PATCH v4 2/5] drm: adjust data width for widen bus case

2024-05-24 Thread Jun Nie
data is valid for only half the active window if widebus is enabled Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c index

[PATCH v4 4/5] drm/msm/dsi: set VIDEO_COMPRESSION_MODE_CTRL_WC

2024-05-24 Thread Jun Nie
kov Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/dsi/dsi_host.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c index 47f5858334f6..7252d36687e6 100644 --- a/drivers/gpu/drm/msm/dsi/dsi_host.c +++ b/drivers/

[PATCH v4 3/5] drm/msm/dsi: set video mode widebus enable bit when widebus is enabled

2024-05-24 Thread Jun Nie
ewed-by: Dmitry Baryshkov Reviewed-by: Marijn Suijten Reviewed-by: Jessica Zhang Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/dsi/dsi_host.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c ind

[PATCH v4 5/5] drm/msm/dsi: add a comment to explain pkt_per_line encoding

2024-05-24 Thread Jun Nie
From: Jonathan Marek Make it clear why the pkt_per_line value is being "divided by 2". Signed-off-by: Jonathan Marek Reviewed-by: Dmitry Baryshkov Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/dsi/dsi_host.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/d

[PATCH v5 0/6] Add DSC support to DSI video panel

2024-05-27 Thread Jun Nie
p the INTF_CFG2_DATA_HCTL_EN change as it is handled in latest mainline code. - Drop the bonded DSI patch as I do not have device to test it. - Address comments from version 2. Signed-off-by: Jun Nie --- Changes in v5: - Link to v4: https://lore.kernel.org/r/20240524-msm-drm-dsc-dsi-video-upstream-4-v4-0-e61c

[PATCH v5 1/6] drm/msm/dpu: fix video mode DSC for DSI

2024-05-27 Thread Jun Nie
From: Jonathan Marek Add width change in DPU timing for DSC compression case to work with DSI video mode. Signed-off-by: Jonathan Marek Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 2 +- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h | 8

[PATCH v5 2/6] drm/msm/dpu: adjust data width for widen bus case

2024-05-27 Thread Jun Nie
data is valid for only half the active window if widebus is enabled Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c

[PATCH v5 3/6] drm/msm/dpu: enable compression bit in cfg2 for DSC

2024-05-27 Thread Jun Nie
Enable compression bit in cfg2 register for DSC in the DSI case Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c index

[PATCH v5 4/6] drm/msm/dsi: set video mode widebus enable bit when widebus is enabled

2024-05-27 Thread Jun Nie
ewed-by: Dmitry Baryshkov Reviewed-by: Marijn Suijten Reviewed-by: Jessica Zhang Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/dsi/dsi_host.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c ind

[PATCH v5 5/6] drm/msm/dsi: set VIDEO_COMPRESSION_MODE_CTRL_WC

2024-05-27 Thread Jun Nie
kov Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/dsi/dsi_host.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c index 47f5858334f6..7252d36687e6 100644 --- a/drivers/gpu/drm/msm/dsi/dsi_host.c +++ b/drivers/

[PATCH v5 6/6] drm/msm/dsi: add a comment to explain pkt_per_line encoding

2024-05-27 Thread Jun Nie
From: Jonathan Marek Make it clear why the pkt_per_line value is being "divided by 2". Signed-off-by: Jonathan Marek Reviewed-by: Dmitry Baryshkov Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/dsi/dsi_host.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/d

Re: [PATCH v5 2/6] drm/msm/dpu: adjust data width for widen bus case

2024-05-28 Thread Jun Nie
Dmitry Baryshkov 于2024年5月28日周二 08:48写道: > > On Mon, May 27, 2024 at 10:21:48PM +0800, Jun Nie wrote: > > data is valid for only half the active window if widebus > > is enabled > > > > Signed-off-by: Jun Nie > > --- > > drivers/gpu/drm/msm/disp/dp

[PATCH 1/3] drm/msm/dpu: fix DSC for DSI video mode

2024-03-28 Thread Jun Nie
Fix DSC timing and control configurations in DPU for DSI video mode. Only compression ratio 3:1 is handled and tested. This patch is modified from patchs of Jonathan Marek. Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 2 +- .../gpu/drm/msm/disp/dpu1

[PATCH 2/3] dt-bindings: display: panel: visionox, vtdr6130: Add mode property

2024-03-28 Thread Jun Nie
Add DSI mode property and compression mode property Signed-off-by: Jun Nie --- .../bindings/display/panel/visionox,vtdr6130.yaml | 8 1 file changed, 8 insertions(+) diff --git a/Documentation/devicetree/bindings/display/panel/visionox,vtdr6130.yaml b/Documentation

[PATCH 3/3] drm/panel: Enable DSC for Visionox VTDR6130 panel

2024-03-28 Thread Jun Nie
- cmd mode + DSC Signed-off-by: Jun Nie --- .../gpu/drm/panel/panel-visionox-vtdr6130.c | 58 ++- 1 file changed, 57 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-visionox-vtdr6130.c b/drivers/gpu/drm/panel/panel-visionox-vtdr6130.c index 540099253e1b

Re: [PATCH 1/3] drm/msm/dpu: fix DSC for DSI video mode

2024-03-28 Thread Jun Nie
Dmitry Baryshkov 于2024年3月28日周四 23:05写道: > > On Thu, 28 Mar 2024 at 13:12, Jun Nie wrote: > > > > Fix DSC timing and control configurations in DPU for DSI video mode. > > Only compression ratio 3:1 is handled and tested. > > > > This patch is modified from patc

[PATCH v3 0/6] Add DSC support to DSI video panel

2024-04-03 Thread Jun Nie
ff-by: Jun Nie --- Jonathan Marek (5): drm/msm/dpu: fix video mode DSC for DSI drm/msm/dsi: set video mode widebus enable bit when widebus is enabled drm/msm/dsi: set VIDEO_COMPRESSION_MODE_CTRL_WC (fix video mode DSC) drm/msm/dsi: add a comment to explain pkt_per_line enc

[PATCH v3 1/6] drm/msm/dpu: fix video mode DSC for DSI

2024-04-03 Thread Jun Nie
From: Jonathan Marek Add necessary DPU timing and control changes for DSC to work with DSI video mode. Signed-off-by: Jonathan Marek Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 9 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c | 8

[PATCH v3 2/6] drm/msm/dsi: set video mode widebus enable bit when widebus is enabled

2024-04-03 Thread Jun Nie
From: Jonathan Marek The value returned by msm_dsi_wide_bus_enabled() doesn't match what the driver is doing in video mode. Fix that by actually enabling widebus for video mode. Fixes: efcbd6f9cdeb ("drm/msm/dsi: Enable widebus for DSI") Signed-off-by: Jonathan Marek Signed-

[PATCH v3 3/6] drm/msm/dsi: set VIDEO_COMPRESSION_MODE_CTRL_WC (fix video mode DSC)

2024-04-03 Thread Jun Nie
From: Jonathan Marek Video mode DSC won't work if this field is not set correctly. Set it to fix video mode DSC (for slice_per_pkt==1 cases at least). Fixes: 08802f515c3c ("drm/msm/dsi: Add support for DSC configuration") Signed-off-by: Jonathan Marek Reviewed-by: Dmitry Baryshkov --- drivers

[PATCH v3 4/6] drm/msm/dsi: add a comment to explain pkt_per_line encoding

2024-04-03 Thread Jun Nie
From: Jonathan Marek Make it clear why the pkt_per_line value is being "divided by 2". Signed-off-by: Jonathan Marek Reviewed-by: Dmitry Baryshkov Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/dsi/dsi_host.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/d

[PATCH v3 5/6] drm/display: Add slice_per_pkt for dsc

2024-04-03 Thread Jun Nie
Add variable for slice number of a DSC compression bit stream packet. Its value shall be specified in panel driver, or default value can be set in display controller driver if panel driver does not set it. Signed-off-by: Jun Nie --- include/drm/display/drm_dsc.h | 4 1 file changed, 4

[PATCH v3 6/6] drm/msm/dsi: support DSC configurations with slice_per_pkt > 1

2024-04-03 Thread Jun Nie
From: Jonathan Marek Support slice_per_pkt in msm driver. Note that the removed "pkt_per_line = slice_per_intf * slice_per_pkt" comment is incorrect. Also trim the code to simplify the dsc reference. Signed-off-by: Jonathan Marek Signed-off-by: Jun Nie --- drivers/gpu/d

Re: [PATCH v3 0/6] Add DSC support to DSI video panel

2024-04-03 Thread Jun Nie
Dmitry Baryshkov 于2024年4月3日周三 17:49写道: > > On Wed, 3 Apr 2024 at 12:11, Jun Nie wrote: > > > > This is follow up update to Jonathan's patch set. > > > > Changes vs V2: > > - Rebase to latest mainline. > > - Drop the INTF_CFG2_DATA_HCTL_EN change a

Re: [PATCH v3 1/6] drm/msm/dpu: fix video mode DSC for DSI

2024-04-03 Thread Jun Nie
Dmitry Baryshkov 于2024年4月3日周三 17:57写道: > > On Wed, 3 Apr 2024 at 12:11, Jun Nie wrote: > > > > From: Jonathan Marek > > > > Add necessary DPU timing and control changes for DSC to work with DSI > > video mode. > > > > Signed-of

Re: [PATCH v3 2/6] drm/msm/dsi: set video mode widebus enable bit when widebus is enabled

2024-04-08 Thread Jun Nie
Dmitry Baryshkov 于2024年4月3日周三 18:10写道: > > On Wed, 3 Apr 2024 at 12:11, Jun Nie wrote: > > > > From: Jonathan Marek > > > > The value returned by msm_dsi_wide_bus_enabled() doesn't match what the > > driver is doing in video mode. Fix that by act

Re: [PATCH v3 5/6] drm/display: Add slice_per_pkt for dsc

2024-04-08 Thread Jun Nie
Dmitry Baryshkov 于2024年4月3日周三 17:41写道: > > On Wed, 3 Apr 2024 at 12:11, Jun Nie wrote: > > > > Add variable for slice number of a DSC compression bit stream packet. > > Its value shall be specified in panel driver, or default value can be set > > in display controll

Re: [PATCH v3 6/6] drm/msm/dsi: support DSC configurations with slice_per_pkt > 1

2024-04-08 Thread Jun Nie
Dmitry Baryshkov 于2024年4月3日周三 18:51写道: > > On Wed, 3 Apr 2024 at 12:11, Jun Nie wrote: > > > > From: Jonathan Marek > > > > Support slice_per_pkt in msm driver. > > > > Note that the removed "pkt_per_line = slice_per_intf * slice_per_pkt" >

Re: [PATCH v3 3/6] drm/msm/dsi: set VIDEO_COMPRESSION_MODE_CTRL_WC (fix video mode DSC)

2024-04-08 Thread Jun Nie
Marijn Suijten 于2024年4月9日周二 00:45写道: > > Can we drop (fix video mode DSC) from this patch title? It looks like more > patches are required to get this done, such a mention is more something for > the > cover letter. > > We could also clarify further to "set Word Count for video-mode DSC". > Acce

[PATCH v6 0/6] Add DSC support to DSI video panel

2024-05-29 Thread Jun Nie
olish warning usage - Add tags from reviewers Changes vs V2: - Drop the INTF_CFG2_DATA_HCTL_EN change as it is handled in latest mainline code. - Drop the bonded DSI patch as I do not have device to test it. - Address comments from version 2. Signed-off-by: Jun Nie --- Changes in v6: - Link

[PATCH v6 1/6] drm/msm/dpu: fix video mode DSC for DSI

2024-05-29 Thread Jun Nie
From: Jonathan Marek Add width change in DPU timing for DSC compression case to work with DSI video mode. Signed-off-by: Jonathan Marek Signed-off-by: Jun Nie Tested-by: Neil Armstrong # on SM8550-QRD Tested-by: Neil Armstrong # on SM8650-QRD Tested-by: Neil Armstrong # on SM8650-HDK

[PATCH v6 2/6] drm/msm/dpu: adjust data width for widen bus case

2024-05-29 Thread Jun Nie
data is valid for only half the active window if widebus is enabled Signed-off-by: Jun Nie Tested-by: Neil Armstrong # on SM8550-QRD Tested-by: Neil Armstrong # on SM8650-QRD Tested-by: Neil Armstrong # on SM8650-HDK Reviewed-by: Dmitry Baryshkov Reviewed-by: Jessica Zhang --- drivers/gpu

[PATCH v6 3/6] drm/msm/dpu: enable compression bit in cfg2 for DSC

2024-05-29 Thread Jun Nie
Enable compression bit in cfg2 register for DSC in the DSI case per hardware version. Signed-off-by: Jun Nie Tested-by: Neil Armstrong # on SM8550-QRD Tested-by: Neil Armstrong # on SM8650-QRD Tested-by: Neil Armstrong # on SM8650-HDK Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm

[PATCH v6 4/6] drm/msm/dsi: set video mode widebus enable bit when widebus is enabled

2024-05-29 Thread Jun Nie
ewed-by: Dmitry Baryshkov Reviewed-by: Marijn Suijten Reviewed-by: Jessica Zhang Signed-off-by: Jun Nie Tested-by: Neil Armstrong # on SM8550-QRD Tested-by: Neil Armstrong # on SM8650-QRD Tested-by: Neil Armstrong # on SM8650-HDK --- drivers/gpu/drm/msm/dsi/dsi_host.c | 3 ++- 1 file changed, 2 i

[PATCH v6 5/6] drm/msm/dsi: set VIDEO_COMPRESSION_MODE_CTRL_WC

2024-05-29 Thread Jun Nie
kov Signed-off-by: Jun Nie Tested-by: Neil Armstrong # on SM8550-QRD Tested-by: Neil Armstrong # on SM8650-QRD Tested-by: Neil Armstrong # on SM8650-HDK Reviewed-by: Jessica Zhang --- drivers/gpu/drm/msm/dsi/dsi_host.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/msm

[PATCH v6 6/6] drm/msm/dsi: add a comment to explain pkt_per_line encoding

2024-05-29 Thread Jun Nie
From: Jonathan Marek Make it clear why the pkt_per_line value is being "divided by 2". Signed-off-by: Jonathan Marek Reviewed-by: Dmitry Baryshkov Signed-off-by: Jun Nie Tested-by: Neil Armstrong # on SM8550-QRD Tested-by: Neil Armstrong # on SM8650-QRD Tested-by: Neil Armst

Re: [RFC 0/5] Generic panel framework

2012-08-23 Thread Jun Nie
Hi Laurent, Do you plan to add an API to get and parse EDID to mode list? video mode is tightly coupled with panel that is capable of hot-plug. Or you are busy on modifying EDID parsing code for sharing it amoung DRM/FB/etc? I see you mentioned this in Mar. It is great if you are considering ad

Re: Kernel Display and Video API Consolidation mini-summit at ELC 2012 - Notes

2012-05-17 Thread Jun Nie
Is there any discussion on HDCP on the summit? It is tightly coupled with HDMI and DVI and should be managed together with the transmitter. But there is not code to handle HDCP in DRM/FB/V4L in latest kernel. Any thoughts on HDCP? Or you guys think there is risk to support it in kernel? Thanks

[RFC 0/5] Generic panel framework

2012-08-23 Thread Jun Nie
Hi Laurent, Do you plan to add an API to get and parse EDID to mode list? video mode is tightly coupled with panel that is capable of hot-plug. Or you are busy on modifying EDID parsing code for sharing it amoung DRM/FB/etc? I see you mentioned this in Mar. It is great if you are considering ad

Kernel Display and Video API Consolidation mini-summit at ELC 2012 - Notes

2012-05-17 Thread Jun Nie
Is there any discussion on HDCP on the summit? It is tightly coupled with HDMI and DVI and should be managed together with the transmitter. But there is not code to handle HDCP in DRM/FB/V4L in latest kernel. Any thoughts on HDCP? Or you guys think there is risk to support it in kernel? Thanks

[PATCH 1/2] drm/msm/dpu: Do not fix number of DSC

2024-10-08 Thread Jun Nie
If DSC is enabled, the only case is with 2 DSC engines so far. More usage case will be added, such as 4 DSC in 4:4:2 topoplogy. So get real number of DSCs to decide whether DSC merge is needed. Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h| 2 ++ drivers/gpu/drm/msm

[PATCH 0/2] drm/msm/dpu: Support different number of DSC

2024-10-08 Thread Jun Nie
DSC is not aligned with maximum pipes. Thus we support DSC flexiblely with this patch set with storing the number and configuring DSC with it. Signed-off-by: Jun Nie --- Jun Nie (2): drm/msm/dpu: Do not fix number of DSC drm/msm/dpu: configure DSC per number in use drivers/gpu/drm

[PATCH 2/2] drm/msm/dpu: configure DSC per number in use

2024-10-08 Thread Jun Nie
Only 2 DSC engines are allowed, or no DSC is involved currently. We need 4 DSC in quad-pipe topology in future. So let's only configure DSC engines in use, instread of maximum number of DSC engines. Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 13 ---

Re: [PATCH v2 09/14] drm/msm/dpu: blend pipes per mixer pairs config

2024-10-15 Thread Jun Nie
Dmitry Baryshkov 于2024年10月11日周五 15:13写道: > > On Fri, 11 Oct 2024 at 10:11, Jun Nie wrote: > > > > Dmitry Baryshkov 于2024年10月11日周五 15:03写道: > > > > > > On Fri, 11 Oct 2024 at 09:40, Jun Nie wrote: > > > > > > > > Dmitry Baryshkov 于202

[PATCH v2 01/14] drm/msm/dpu: polish log for resource allocation

2024-10-09 Thread Jun Nie
Add resource allocation type info. Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 23 +++ 1 file changed, 19 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c index 15b42a6683639

[PATCH v2 02/14] drm/msm/dpu: decide right side per last bit

2024-10-09 Thread Jun Nie
decide right side of a pair per last bit, in case of multiple mixer pairs. Signed-off-by: Jun Nie Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c b

[PATCH v2 00/14] drm/msm/dpu: Support quad pipe with dual-DSI

2024-10-09 Thread Jun Nie
sequence with changing to 2 pipes topology first. Then prepare for quad-pipe setup, then enable quad-pipe at last. - Link to v1: https://lore.kernel.org/all/20240829-sm8650-v6-11-hmd-pocf-mdss-quad-upstream-8-v1-0-bdb05b4b5...@linaro.org/ Signed-off-by: Jun Nie --- Jun Nie (14): drm/msm

[PATCH v2 04/14] drm/msm/dpu: switch RM to use crtc_id rather than enc_id for allocation

2024-10-09 Thread Jun Nie
operation. While the sspp assignment is in drm_atomic_helper_check_planes() call tree. So CRTC is more central than encoder. Siwtching the id achieves above goal. Co-developed-by: Dmitry Baryshkov Signed-off-by: Dmitry Baryshkov Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1

[PATCH v2 03/14] drm/msm/dpu: fix mixer number counter on allocation

2024-10-09 Thread Jun Nie
pairs are needed, the failure on the test of 2nd pair results clearing to the 1st pair. This patch only clear the bit for the 2nd pair allocation before retry on another pair. Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 6 +- 1 file changed, 5 insertions(+), 1 del

[PATCH v2 05/14] drm/msm/dpu: handle pipes as array

2024-10-09 Thread Jun Nie
Store pipes in array with removing dedicated r_pipe. There are 2 pipes in a drm plane at most currently. While 4 pipes are needed for new usage case. This change generalize the handling to pipe pair and ease handling to another pipe pair later. Signed-off-by: Jun Nie --- drivers/gpu/drm/msm

[PATCH v2 06/14] drm/msm/dpu: split PIPES_PER_STAGE definition per plane and mixer

2024-10-09 Thread Jun Nie
Split PIPES_PER_STAGE definition per plane and mixer pair. Because there are more than 2 pipes in quad pipe case, while 2 pipes at most per mixer pair. Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c| 2 +- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c | 2 +- drivers

[PATCH v2 09/14] drm/msm/dpu: blend pipes per mixer pairs config

2024-10-09 Thread Jun Nie
Blend pipes by set of mixer pair config. The first 2 pipes are for left half screen with the first set of mixer pair config. And the later 2 pipes are for right in quad pipe case. Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c| 38 ++--- drivers

[PATCH v2 08/14] drm/msm/dpu: update mixer number info earlier

2024-10-09 Thread Jun Nie
Update mixer number info earlier so that the plane nopipe check can have the info to clip the plane. Otherwise, the first nonpipe check will have mixer number as 0 and plane is not checked. Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 11 ++- 1 file changed

[PATCH v2 07/14] drm/msm/dpu: bind correct pingpong for quad pipe

2024-10-09 Thread Jun Nie
There are 2 interfaces and 4 pingpong in quad pipe. Map the 2nd interface to 3rd PP instead of the 2nd PP. Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1

[PATCH v2 10/14] drm/msm/dpu: Support quad-pipe in SSPP checking

2024-10-09 Thread Jun Nie
Move requreiment check to routine of every pipe check. Because there is multiple SSPPs for quad-pipe case in future. Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h | 2 + drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 86 ++--- 2 files changed, 44

[PATCH v2 14/14] drm/msm/dpu: Enable quad-pipe for DSC and dual-DSI case

2024-10-09 Thread Jun Nie
Request 4 mixers and 4 DSC for the case that both dual-DSI and DSC are enabled. We prefer to use 4 pipes for dual DSI case for it is power optimal for DSC. Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 2 +- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h | 6

[PATCH v2 12/14] drm/msm/dpu: support plane splitting in quad-pipe case

2024-10-09 Thread Jun Nie
Clip plane into pipes per left and right half screen ROI if topology is quad pipe. Then split the clipped rectangle by half if the rectangle width still exceeds width limit. Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 7 +++ drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h

[PATCH v2 11/14] drm/msm/dpu: Share SSPP info for multi-rect case

2024-10-09 Thread Jun Nie
Share SSPP info for multi-rect case if virtual plane is not enabled. Otherwise, the 2nd half of DMA content is not displayed due to sspp pointer of r_pipe is null. Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 5 + 1 file changed, 5 insertions(+) diff --git a

[PATCH v2 13/14] drm/msm/dpu: support SSPP assignment for quad-pipe case

2024-10-09 Thread Jun Nie
Support SSPP assignment for quad-pipe case with unified method. The first 2 pipes can share a set of mixer config and enable multi-rect mode if condition is met. It is also the case for the later 2 pipes. Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 85

Re: [PATCH v2 09/14] drm/msm/dpu: blend pipes per mixer pairs config

2024-10-11 Thread Jun Nie
Dmitry Baryshkov 于2024年10月11日周五 15:03写道: > > On Fri, 11 Oct 2024 at 09:40, Jun Nie wrote: > > > > Dmitry Baryshkov 于2024年10月10日周四 21:15写道: > > > > > > On Wed, Oct 09, 2024 at 04:50:22PM GMT, Jun Nie wrote: > > > > Blend pipes by set of m

Re: [PATCH v2 05/14] drm/msm/dpu: handle pipes as array

2024-10-11 Thread Jun Nie
Dmitry Baryshkov 于2024年10月11日周五 15:10写道: > > On Fri, 11 Oct 2024 at 09:49, Jun Nie wrote: > > > > Dmitry Baryshkov 于2024年10月10日周四 21:08写道: > > > > > > On Wed, Oct 09, 2024 at 04:50:18PM GMT, Jun Nie wrote: > > > > Store pipes in array with removin

Re: [PATCH v2 09/14] drm/msm/dpu: blend pipes per mixer pairs config

2024-10-10 Thread Jun Nie
Dmitry Baryshkov 于2024年10月10日周四 21:15写道: > > On Wed, Oct 09, 2024 at 04:50:22PM GMT, Jun Nie wrote: > > Blend pipes by set of mixer pair config. The first 2 pipes are for left > > half screen with the first set of mixer pair config. And the later 2 pipes > > are for

Re: [PATCH v2 05/14] drm/msm/dpu: handle pipes as array

2024-10-10 Thread Jun Nie
Dmitry Baryshkov 于2024年10月10日周四 21:08写道: > > On Wed, Oct 09, 2024 at 04:50:18PM GMT, Jun Nie wrote: > > Store pipes in array with removing dedicated r_pipe. There are > > 2 pipes in a drm plane at most currently. While 4 pipes are > > needed for new usage case. This change

Re: [PATCH v2 11/14] drm/msm/dpu: Share SSPP info for multi-rect case

2024-10-10 Thread Jun Nie
Dmitry Baryshkov 于2024年10月10日周四 21:21写道: > > On Wed, Oct 09, 2024 at 04:50:24PM GMT, Jun Nie wrote: > > Share SSPP info for multi-rect case if virtual plane is not enabled. > > Otherwise, the 2nd half of DMA content is not displayed due to sspp > > pointer of r_pipe is nu

Re: [PATCH v2 14/14] drm/msm/dpu: Enable quad-pipe for DSC and dual-DSI case

2024-10-11 Thread Jun Nie
Dmitry Baryshkov 于2024年10月10日周四 22:00写道: > > On Wed, Oct 09, 2024 at 04:50:27PM GMT, Jun Nie wrote: > > Request 4 mixers and 4 DSC for the case that both dual-DSI and DSC are > > enabled. We prefer to use 4 pipes for dual DSI case for it is power optimal > > for DSC. &g

  1   2   3   4   >