An unlock may be missing before line 2568.
julia
-- Forwarded message --
Date: Fri, 30 Jun 2017 01:26:56 +0800
From: kbuild test robot
To: kbu...@01.org
Cc: Julia Lawall
Subject: Re: [Intel-gfx] [PATCH 10/13] drm/fb-helper: Support deferred setup
CC: kbuild-...@01.org
In-Reply
robot
To: kbu...@01.org
Cc: Julia Lawall
Subject: [radeon-alex:amd-staging-4.9 3/17]
drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dce_calcs.c:1328:3-5:
WARNING: possible condition with no effect (if == else)
tree: git://people.freedesktop.org/~agd5f/linux.git amd-staging-4.9
head
Remove unneeded semicolon.
Generated by: scripts/coccinelle/misc/semicolon.cocci
CC: Beomho Seo
Signed-off-by: Julia Lawall
Signed-off-by: Fengguang Wu
---
I also received the following warning from kbuild, without any other
information:
drivers/input/touchscreen/fts_ts.c:750:1-6: WARNING
Perhaps the mutex on line 410 needs to be considered on line 423.
julia
-- Forwarded message --
Hi Dave,
[auto build test WARNING on drm/drm-next]
[also build test WARNING on v4.11-rc2 next-20170310]
[if your patch is applied to the wrong git tree, please drop us a note to help
Lines 375 and 376 mention the same constant. Maybe something else was
intended, or mybe line 376 can just be dropped.
julia
-- Forwarded message --
Date: Thu, 11 May 2017 09:07:22 +0800
From: kbuild test robot
To: kbu...@01.org
Cc: Julia Lawall
Subject: [radeon-alex:raven
Hello,
It seems that (1 << LOG_DETECTION_EDID_PARSER) appears more than once in
the bit or (only one instance shown, on line 74).
julia
-- Forwarded message --
Date: Fri, 12 May 2017 09:54:09 +0800
From: kbuild test robot
To: kbu...@01.org
Cc: Julia Lawall
Subject: [
On line 466, the preceeding comment suggests that the second constant
should start with VS rather than HS again.
julia
-- Forwarded message --
Date: Fri, 19 May 2017 15:45:39 +0800
From: kbuild test robot
To: kbu...@01.org
Cc: Julia Lawall
Subject: Re: [PATCH] drm/stm: add
Hello,
Please check whether holding the lock taken on line 604 past a failure
return of the function is what was intended.
thanks,
julia
-- Forwarded message --
Date: Wed, 7 Jun 2017 15:06:38 +0800
From: kbuild test robot
To: kbu...@01.org
Cc: Julia Lawall
Subject: [radeon
Use drm_*_get() and drm_*_put() helpers instead of drm_*_reference() and
drm_*_unreference() helpers.
Generated by: scripts/coccinelle/api/drm-get-put.cocci
CC: Christian König
Signed-off-by: Julia Lawall
Signed-off-by: Fengguang Wu
---
Please take the patch only if it's a positive wa
Use drm_*_get() and drm_*_put() helpers instead of drm_*_reference() and
drm_*_unreference() helpers.
Generated by: scripts/coccinelle/api/drm-get-put.cocci
CC: annwang
Signed-off-by: Julia Lawall
Signed-off-by: Fengguang Wu
---
tree: git://people.freedesktop.org/~agd5f/linux.git
amd
Use BUG_ON instead of a if condition followed by BUG.
Generated by: scripts/coccinelle/misc/bugon.cocci
CC: Xiangliang Yu
Signed-off-by: Julia Lawall
Signed-off-by: Fengguang Wu
---
gfx_v8_0.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--- a/drivers/gpu/drm/amd/amdgpu
X != NULL, or even !X is more normmal in the kernel.
Generated by: scripts/coccinelle/misc/compare_const_fl.cocci
CC: Jammy Zhou
Signed-off-by: Fengguang Wu
Signed-off-by: Julia Lawall
---
smumgr.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
--- a/drivers/gpu/drm/amd
On Tue, 21 Apr 2020, Dan Carpenter wrote:
> On Tue, Apr 21, 2020 at 05:29:02PM +0200, Julia Lawall wrote:
> >
> >
> > On Tue, 21 Apr 2020, Dan Carpenter wrote:
> >
> > > Hi Kernel Janitors,
> > >
> > > Here is another idea that someone coul
On Tue, 21 Apr 2020, Dan Carpenter wrote:
> Hi Kernel Janitors,
>
> Here is another idea that someone could work on, fixing the
> IS_ERR_OR_NULL() checks in the xen driver.
>
> The patch c575b7eeb89f: "drm/xen-front: Add support for Xen PV
> display frontend" from Apr 3, 2018, leads to the foll
On Sat, 17 Oct 2020, Joe Perches wrote:
> On Sat, 2020-10-17 at 09:09 -0700, t...@redhat.com wrote:
> > From: Tom Rix
> >
> > This is a upcoming change to clean up a new warning treewide.
> > I am wondering if the change could be one mega patch (see below) or
> > normal patch per file about 10
On Sat, 31 Oct 2020, Joe Perches wrote:
> On Fri, 2020-10-30 at 09:03 +0100, Greg KH wrote:
> > On Fri, Oct 30, 2020 at 01:27:16PM +0530, Deepak R Varma wrote:
> > > On Fri, Oct 30, 2020 at 08:11:20AM +0100, Greg KH wrote:
> > > > On Fri, Oct 30, 2020 at 08:52:45AM +0530, Deepak R Varma wrote:
On Fri, 30 Oct 2020, Greg KH wrote:
> On Fri, Oct 30, 2020 at 01:47:05PM +0530, Sumera Priyadarsini wrote:
> > On Fri, 30 Oct, 2020, 1:32 PM Greg KH, wrote:
> >
> > > On Fri, Oct 30, 2020 at 01:27:16PM +0530, Deepak R Varma wrote:
> > > > On Fri, Oct 30, 2020 at 08:11:20AM +0100, Greg KH wrote
On Sat, 20 Jun 2020, Markus Elfring wrote:
> > The function kobject_init_and_add alloc memory like:
> > kobject_init_and_add->kobject_add_varg->kobject_set_name_vargs
> > ->kvasprintf_const->kstrdup_const->kstrdup->kmalloc_track_caller
> > ->kmalloc_slab, in err branch this memory not free. If u
On Sat, 20 Jun 2020, Bernard wrote:
>
>
> From: Julia Lawall
> Date: 2020-06-20 17:37:19
> To: Markus Elfring
> Cc: Bernard Zhao
> ,opensource.ker...@vivo.com,amd-...@lists.freedesktop.org,dri-devel@lists.freedesktop.org,kernel-janit...@vger.kernel.org,linux-ker...
On Sat, 20 Jun 2020, Markus Elfring wrote:
> > The function kobject_init_and_add alloc memory like:
> > kobject_init_and_add->kobject_add_varg->kobject_set_name_vargs
> > ->kvasprintf_const->kstrdup_const->kstrdup->kmalloc_track_caller
> > ->kmalloc_slab, in err branch this memory not free. If u
NULL check before kfree is not needed.
Generated by: scripts/coccinelle/free/ifnullfree.cocci
Fixes: c6603c740e0e ("drm: add managed resources tied to drm_device")
Signed-off-by: kbuild test robot
Signed-off-by: Julia Lawall
---
tree: git://anongit.freedesktop.org/drm/drm-misc drm
On Sun, 29 Mar 2020, John B. Wyatt IV wrote:
> Fix style issue with usleep_range being reported as preferred over
> udelay.
>
> Issue reported by checkpatch.
>
> Please review.
>
> As written in Documentation/timers/timers-howto.rst udelay is the
> generally preferred API. hrtimers, as noted in
On Sun, 29 Mar 2020, John Wyatt wrote:
> On Sun, 2020-03-29 at 11:28 +0200, Julia Lawall wrote:
> >
> > On Sun, 29 Mar 2020, John B. Wyatt IV wrote:
> >
> > > Fix style issue with usleep_range being reported as preferred over
> > > udelay.
&
n that it is easy to address the problem.
julia
>
> More clarification on this issue will be helpful.
>
> On Sun, 29 Mar 2020, 15:17 Julia Lawall, wrote:
>
>
> On Sun, 29 Mar 2020, John Wyatt wrote:
>
> > On Sun, 2020-03-29 at 11:28 +0200, Julia Law
On Tue, 31 Mar 2020, Daniel Vetter wrote:
> On Fri, Mar 27, 2020 at 09:11:44AM +0100, Julia Lawall wrote:
> > NULL check before kfree is not needed.
> >
> > Generated by: scripts/coccinelle/free/ifnullfree.cocci
> >
> > Fixes: c6603c740e0e ("drm: ad
On Wed, 1 Apr 2020, John B. Wyatt IV wrote:
> Fix 2 parenthesis alignment issues.
Please try to find a way to describe what you have done that doesn't
involve the word "Fix". What have you done and why?
julia
>
> Reported by checkpatch.
>
> Signed-off-by: John B. Wyatt IV
> ---
> drivers
From: kernel test robot
Use kobj_to_dev() instead of container_of()
Generated by: scripts/coccinelle/api/kobj_to_dev.cocci
Fixes: a2fc3718bc22 ("coccinelle: api: add kobj_to_dev.cocci script")
CC: Denis Efremov
Signed-off-by: kernel test robot
Signed-off-by: Julia Lawall
On Thu, 27 Aug 2020, Markus Elfring wrote:
> > Generated by: scripts/coccinelle/api/kobj_to_dev.cocci
> >
> > Fixes: a2fc3718bc22 ("coccinelle: api: add kobj_to_dev.cocci script")
>
> I wonder about such a combination of information.
>
> I find it reasonable that two function implementations sho
On Tue, 8 Sep 2020, Bartlomiej Zolnierkiewicz wrote:
>
> Hi,
>
> On 8/10/20 11:21 AM, kernel test robot wrote:
> > From: kernel test robot
> >
> > drivers/video/fbdev/core/fbcon.c:3509:8-16: WARNING: use scnprintf or
> > sprintf
> > drivers/video/fbdev/core/fbcon.c:3484:8-16: WARNING: use scn
Signed-off-by: Julia Lawall
---
drivers/gpu/drm/nouveau/nvkm/engine/gr/gk20a.c |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/gr/gk20a.c
b/drivers/gpu/drm/nouveau/nvkm/engine/gr/gk20a.c
index 4ca8ed1..de8b806 100644
--- a/drivers/gpu/drm/nouveau/nvkm
List_for_each entry binds its first argument to an offset from the list
pointer, so this should not be NULL.
Generated by: scripts/coccinelle/iterators/itnull.cocci
Signed-off-by: Fengguang Wu
---
Please take the patch only if it's a positive warning. Thanks!
intel_display.c |2 +-
1 file
On Mon, 18 Jan 2016, Daniel Vetter wrote:
> On Mon, Jan 18, 2016 at 04:49:06PM +0100, Julia Lawall wrote:
> > List_for_each entry binds its first argument to an offset from the list
> > pointer, so this should not be NULL.
> >
> > Generated by: scripts/coccin
devm_ioremap_resource often uses the result of a call to
platform_get_resource as its last argument. devm_ioremap_resource does
appropriate error handling on this argument, so error handling can be
removed from the call site. To make the connection between the call to
platform_get_resource and th
From: Julia Lawall
Remove unneeded error handling on the result of a call to
platform_get_resource when the value is passed to devm_ioremap_resource.
Move the call to platform_get_resource adjacent to the call to
devm_ioremap_resource to make the connection between them more clear.
A
The complate semantic patch that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
//
@ok exists@
identifier f,ret,i;
expression e;
constant c;
@@
// identify a function that returns a negative return value at least once.
f(...) {
... when any
(
return -c at i;
|
ret = -c at i;
...
amp;ret
*if(...)
{
... when != ret = e2
when forall
return ret;
}
//
Signed-off-by: Julia Lawall
---
drivers/gpu/drm/gma500/psb_drv.c |8 ++--
drivers/gpu/drm/omapdrm/omap_dmm_tiler.c |1 +
2 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/
ret
*if(...)
{
... when != ret = e2
when forall
return ret;
}
//
Signed-off-by: Julia Lawall
---
drivers/gpu/drm/exynos/exynos_drm_mic.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_mic.c
b/drivers/gpu/drm/exynos/exynos_drm_mic.c
index 8994eab..
The intel_dvo_dev_ops structures are never modified, so declare them as
const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/gpu/drm/i915/dvo.h| 12 ++--
drivers/gpu/drm/i915/dvo_ch7017.c |2 +-
drivers/gpu/drm/i915/dvo_ch7xxx.c |2
Maybe line 294 should become an unlock and should be moved under 295?
julia
On Tue, 29 Sep 2015, kbuild test robot wrote:
> CC: kbuild-all at 01.org
> In-Reply-To: <1443513993-5228-2-git-send-email-daniel.vetter at ffwll.ch>
> TO: Daniel Vetter
> CC: DRI Development
> CC: Daniel Vetter , Intel
On Tue, 12 Apr 2016, Emil Velikov wrote:
> On 30 March 2016 at 10:51, Daniel Vetter wrote:
> > No need to confuse userspace like this.
> >
> > Cc: Gerd Hoffmann
> > Cc: Dave Airlie
> > Signed-off-by: Daniel Vetter
> > ---
> > drivers/gpu/drm/virtio/virtgpu_display.c | 9 -
> > 1 fil
Move constants to the right of binary operators.
Generated by: scripts/coccinelle/misc/compare_const_fl.cocci
Signed-off-by: Fengguang Wu
Signed-off-by: Julia Lawall
---
Could be nice to put the thing being tested first.
amdgpu_grph_object_id_helpers.c |4 ++--
1 file changed, 2
On Fri, 15 Apr 2016, Christian König wrote:
> Am 15.04.2016 um 09:15 schrieb Julia Lawall:
> > Move constants to the right of binary operators.
> >
> > Generated by: scripts/coccinelle/misc/compare_const_fl.cocci
> >
> > Signed-off-by: Fengguang Wu
> &
On Tue, 16 Oct 2018, Mamta Shukla wrote:
> Shift * to be adjacent to pointer name to follow Linux coding style.
> Issue found with checkpatch.pl
> ERROR: "foo * bar" should be "foo *bar"
The patch looks OK, but at this point, you know how to send a patch, so it
would be better to focus on chang
On Fri, 19 Oct 2018, Mamta Shukla wrote:
> Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR because its
> better to have inlined function rather than code-opened implementation.
Just for your information, people have mixed feelings about this. In your
case, it's probably fine, becaus
The containing function is called with a spin_lock held, so GFP_KERNEL
can't be used.
julia
-- Forwarded message --
Date: Tue, 23 Oct 2018 17:14:25 +0800
From: kbuild test robot
To: kbu...@01.org
Cc: Julia Lawall
Subject: [PATCH] drm: fix call_kern.cocci warnings
CC: k
Declare as const clk_ops structures that are only stored in const fields or
passed to functions with const parameters.
Identified and transformed using Coccinelle.
Signed-off-by: Julia Lawall
---
arch/arm/mach-vexpress/spc.c |2 +-
drivers/clk/clk-max77686.c
The clk_ops structure is only stored in the ops field of a
clk_init_data structure. This field is const, so the clk_ops
structure can be const as well.
Identified and transformed using Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/gpu/drm/imx/imx-tve.c |2 +-
1 file changed, 1
The clk_ops structure is only stored in the ops field of a
clk_init_data structure. This field is const, so the clk_ops
structure can be const as well.
Identified and transformed using Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/gpu/drm/msm/hdmi/hdmi_phy_8996.c |2 +-
1 file
On Wed, 31 Oct 2018, Shayenne da Luz Moura wrote:
> Rename 'drm_mode_config.crtc_idr' as 'drm_mode_config.object_idr',
> as proposed in the task description in TODO list for KMS cleanups.
Is object_idr a field that already exists? If so, "Rename" is not the
best choice of words. It should be
On Wed, 31 Oct 2018, Shayenne Moura wrote:
> On 10/31, Julia Lawall wrote:
> >
> >
> > On Wed, 31 Oct 2018, Shayenne da Luz Moura wrote:
> >
> > > Rename 'drm_mode_config.crtc_idr' as 'drm_mode_config.object_idr',
> > >
On Wed, 31 Oct 2018, Shayenne Moura wrote:
> On 10/31, Julia Lawall wrote:
> >
> >
> > On Wed, 31 Oct 2018, Shayenne Moura wrote:
> >
> > > On 10/31, Julia Lawall wrote:
> > > >
> > > >
> > > > On Wed, 31 Oct 2018, Shayenn
The device node iterators perform an of_node_get on each iteration, so a
jump out of the loop requires an of_node_put.
---
drivers/gpu/drm/rockchip/rockchip_lvds.c |4 +++-
drivers/pci/hotplug/pnv_php.c |8 ++--
drivers/phy/hisilicon/phy-hisi-inno-usb2.c |9 +++
;
@@
for_each_child_of_node(root, child) {
... when != of_node_put(child)
when != e = child
+ of_node_put(child);
? break;
...
}
... when != child
//
Signed-off-by: Julia Lawall
---
drivers/gpu/drm/rockchip/rockchip_lvds.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion
From: kbuild test robot
drivers/dma-buf/udmabuf.c:167:6-12: inconsistent IS_ERR and PTR_ERR on line 168.
PTR_ERR should access the value just tested by IS_ERR
Semantic patch information:
There can be false positives in the patch case, where it is the call to
IS_ERR that is wrong.
Generated
Return an error code on failure.
Problem found using Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/video/fbdev/omap2/omapfb/displays/encoder-tpd12s015.c | 12 +++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/drivers/video/fbdev/omap2/omapfb/displays/encoder
Lines 686 and 688 seem to contain the same constant.
julia
On Wed, 16 May 2018, kbuild test robot wrote:
> CC: kbuild-...@01.org
> CC: dri-devel@lists.freedesktop.org
> TO: Alex Deucher
>
> tree: git://people.freedesktop.org/~agd5f/linux.git amd-staging-drm-next
> head: dbf4f8b16fdef588f3d9
test robot
Signed-off-by: Julia Lawall
---
tree: https://github.com/skeggsb/linux linux-4.18
head: 6c46d01f25bcf74608d09645c27c35c3f3940ebe
commit: 30ed49b55b6e44e004c3095671e74fea93ee84cb [105/165]
drm/nouveau/kms/nv50-: move code underneath dispnv50/
disp.c |2 +-
1 file changed, 1
Lines 680 and 682 contain the same constant.
julia
-- Forwarded message --
Date: Sat, 19 May 2018 04:22:09 +0800
From: kbuild test robot
To: kbu...@01.org
Cc: Julia Lawall
Subject: [radeon-alex:drm-next-4.18-wip 44/78]
drivers/gpu/drm/amd/amdgpu/soc15.c:680:3-24: duplicated
On Thu, 15 Nov 2018, Fernando Ramos wrote:
> The coccinelle script was used to rename some (deprecated) functions
> which no longer exist now.
>
> Signed-off-by: Fernando Ramos
Acked-by: Julia Lawall
> ---
> scripts/coccinelle/api/drm-get-put.cocci | 78
It seems that line 352 should have one more tab at the beginning of the
line.
julia
-- Forwarded message --
Date: Fri, 10 Aug 2018 21:01:50 +0800
From: kbuild test robot
To: kbu...@01.org
Cc: Julia Lawall
Subject: [radeon-alex:drm-next-4.19 52/60]
drivers/gpu/drm/amd/amdgpu
ned-off-by: Julia Lawall
---
url:
https://github.com/0day-ci/linux/commits/Abhinav-Kumar/drm-panel-Add-support-for-Truly-NT35597-panel-driver/20180818-120729
:: branch date: 2 hours ago
:: commit date: 2 hours ago
panel-truly-nt35597.c |2 +-
1 file changed, 1 insertion(+), 1 deletion
ld test robot
Signed-off-by: Julia Lawall
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master
head: b36fdc6853a38a6f8749897a33435635019e0647
commit: eaeb9010bb4bcdc20e58254fa42f3fe730a7f908 drm/nouveau/debugfs: Wake up
GPU before doing any reclocking
:: br
De: kbuild test robot
À: kbu...@01.org
Cc: Julia Lawall
CC: kbuild-...@01.org
CC: dri-devel@lists.freedesktop.org
TO: Alex Deucher
CC: Chunming Zhou
CC: "Christian König"
tree: git://people.freedesktop.org/~agd5f/linux.git drm-next-4.19-wip
head: 6becad35ec8a249df9f8e8fe196316
+0800
From: kbuild test robot
To: kbu...@01.org
Cc: Julia Lawall
Subject: Re: [PATCH 1/6] drm/dp_mst: Introduce
drm_dp_mst_connector_atomic_check()
CC: kbuild-...@01.org
In-Reply-To: <20180918230637.20700-2-ly...@redhat.com>
References: <20180918230637.20700-2-ly...@redhat.com>
T
On Tue, 25 Sep 2018, Mikko Perttunen wrote:
> I'm not the maintainer, but in line with previous similar patches..
>
> NAK: this makes the code harder to read.
If people don't like it, I wonder if it is a good thing for the function
to even exist? Or at least the semantic patch that suggests th
Please check on whether the kfree is still needed.
julia
-- Forwarded message --
Date: Wed, 18 Jul 2018 22:03:48 +0800
From: kbuild test robot
To: kbu...@01.org
Cc: Julia Lawall
Subject: Re: [resend PATCH v4 2/5] clk: mediatek: mt2701-mmsys: switch to
platform device
Hello,
Please check on whether the kfree in the remove function is still needed.
Also the platform_driver structure has two probe fields.
julia
-- Forwarded message --
Date: Wed, 18 Jul 2018 22:31:13 +0800
From: kbuild test robot
To: kbu...@01.org
Cc: Julia Lawall
Subject: Re
ld test robot
Signed-off-by: Julia Lawall
---
Please take the patch only if it's a positive warning. Thanks!
nouveau_debugfs.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/gpu/drm/nouveau/nouveau_debugfs.c
+++ b/drivers/gpu/drm/nouveau/nouveau_debugfs.
From: Julia Lawall
Remove unneeded error handling on the result of a call to
platform_get_resource when the value is passed to devm_ioremap_resource.
Move the call to platform_get_resource adjacent to the call to
devm_ioremap_resource to make the connection between them more clear.
A
devm_ioremap_resource often uses the result of a call to
platform_get_resource as its last argument. devm_ioremap_resource does
appropriate error handling on this argument, so error handling can be
removed from the call site. To make the connection between the call to
platform_get_resource and th
Add of_node_put on a break out of an of_node loop.
---
arch/powerpc/kexec/file_load_64.c|8 ++--
arch/powerpc/platforms/powermac/low_i2c.c|4 +++-
arch/powerpc/platforms/powermac/smp.c|4 +++-
drivers/bus/arm-cci.c
for_each_child_of_node performs an of_node_get on each
iteration, so a break out of the loop requires an
of_node_put.
This was done using the Coccinelle semantic patch
iterators/for_each_child.cocci
Signed-off-by: Julia Lawall
---
drivers/gpu/drm/mediatek/mtk_disp_ovl_adaptor.c |4
On Mon, 30 Oct 2023, Bagas Sanjaya wrote:
> On Sun, Oct 29, 2023 at 04:11:01PM +0100, Julia Lawall wrote:
> >
> >
> > On Sun, 29 Oct 2023, Dorine Tipo wrote:
> >
> > > Signed-off-by: Dorine Tipo
> > >
> > > Fix the line lengths of lines
On Tue, 20 Feb 2024, Johan Hovold wrote:
> On Mon, Feb 19, 2024 at 06:48:30PM +0100, Markus Elfring wrote:
> > > The two device node references taken during allocation need to be
> > > dropped when the auxiliary device is freed.
> > …
> > > +++ b/drivers/gpu/drm/bridge/aux-hpd-bridge.c
> > …
> >
On Tue, 20 Feb 2024, Dmitry Baryshkov wrote:
> On Tue, 20 Feb 2024 at 13:52, Julia Lawall wrote:
> >
> >
> >
> > On Tue, 20 Feb 2024, Johan Hovold wrote:
> >
> > > On Mon, Feb 19, 2024 at 06:48:30PM +0100, Markus Elfring wrote:
> > > > &g
On Wed, 1 May 2024, Daniel Thompson wrote:
> On Wed, May 01, 2024 at 06:21:46PM +0530, R Sundar wrote:
> > Use the new cleanup magic to replace of_node_put() with
> > __free(device_node) marking to auto release when they get out of scope.
> >
> > Suggested-by: Juli
On Thu, 2 May 2024, Ashok Kumar wrote:
> Corrected coding style CHECK: Alignment should match open parenthesis
Ashok, I think the code is nicer as is, because it has all the constant
numbers lined up.
julia
>
> Signed-off-by: Ashok Kumar
> ---
> drivers/staging/fbtft/fb_tinylcd.c | 2 +-
>
On Tue, 3 Apr 2018, Jani Nikula wrote:
> On Fri, 30 Mar 2018, Colin King wrote:
> > From: Colin Ian King
> >
> > Trivial fix to spelling mistake in DRM_ERROR error message text
>
> Thanks for the patch.
>
> Please do consider limiting the distribution in the future,
> though. There's no need t
From: Fengguang Wu
PTR_ERR should normally access the value just tested by IS_ERR
Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci
Fixes: 742243a44a73 ("drm: xlnx: pl_disp: Use xlnx pipeline calls")
CC: Hyun Kwon
Signed-off-by: Fengguang Wu
Signed-off-by: Julia Lawall
From: Fengguang Wu
Use drm_*_get() and drm_*_put() helpers instead of drm_*_reference() and
drm_*_unreference() helpers.
Generated by: scripts/coccinelle/api/drm-get-put.cocci
Fixes: 6784ac15bc68 ("drm: Add ASPEED GFX driver")
Signed-off-by: Fengguang Wu
Signed-off-by: Ju
On Mon, 16 Apr 2018, Daniel Vetter wrote:
> On Thu, Apr 12, 2018 at 07:54:10AM +0200, Julia Lawall wrote:
> > From: Fengguang Wu
> >
> > Use drm_*_get() and drm_*_put() helpers instead of drm_*_reference() and
> > drm_*_unreference() helpers.
> >
> > G
On Fri, 13 Oct 2017, Harsha Sharma wrote:
> Prefer kcalloc over kzalloc to allocate an array.
> This patch fixes checkcpatch issue.
>
> Signed-off-by: Harsha Sharma
> ---
> drivers/gpu/drm/drm_crtc_helper.c | 4 ++--
> drivers/gpu/drm/drm_fb_helper.c| 2 +-
> drivers/gpu/drm/drm_plane_hel
Hello,
There are two checks for dm_444_16on line 2943.
julia
-- Forwarded message --
Date: Fri, 13 Oct 2017 08:24:34 +0800
From: kbuild test robot
To: kbu...@01.org
Cc: Julia Lawall
Subject: [radeon-alex:amd-staging-drm-next 120/173]
drivers/gpu/drm/amd/amdgpu/../display
On Fri, 13 Oct 2017, Harsha Sharma wrote:
> Done with following coccinelle patch
>
> @r@
> expression x;
> void* e;
> type T;
> identifier f;
> @@
> (
> *((T *)e)
> |
> ((T *)x)[...]
> |
> ((T*)x)->f
> |
>
> - (T*)
> e
> )
>
> Signed-off-by: Harsha Sharma
> ---
> drivers/gpu/drm/amd/po
> @@ -3400,7 +3400,7 @@ static int smu7_read_sensor(struct pp_hwmgr *hwmgr, int
> idx,
> static int smu7_find_dpm_states_clocks_in_dpm_table(struct pp_hwmgr *hwmgr,
> const void *input)
> {
> const struct phm_set_power_state_input *states =
> - (const struct phm_set_po
On Sat, 14 Oct 2017, Harsha Sharma wrote:
> Done with following coccinelle patch
>
> @r@
> expression x;
> void* e;
> type T;
> identifier f;
> @@
> (
> *((T *)e)
> |
> ((T *)x)[...]
> |
> ((T*)x)->f
> |
>
> - (T*)
> e
> )
>
> Signed-off-by: Harsha Sharma
> ---
> Changes in v3:
> -Remo
The same field name appears on two differnt lines, with different values.
julia
-- Forwarded message --
Date: Fri, 16 Mar 2018 22:35:29 +0800
From: kbuild test robot
To: kbu...@01.org
Cc: Julia Lawall
Subject: [radeon-alex:drm-next-4.17-wip 72/87]
drivers/gpu/drm/amd
On Mon, 19 Mar 2018, Arushi Singhal wrote:
> This patch replace list_entry with list_{next/prev}_entry as it makes
> the code more clear to read.
> Done using coccinelle:
>
> @@
> expression e1;
> identifier e3;
> type t;
> @@
> (
> - list_entry(e1->e3.next,t,e3)
> + list_next_entry(e1,e3)
> |
>
On Mon, 19 Mar 2018, Christian König wrote:
> Mhm, actually that patch isn't correct. What we grab get here is the next
> entry, not the first one.
>
> We don't have an alias list_next_entry for list_first_entry?
As compared to the semantic patch I proposed earlier today, it would seem
that lis
Level is unsigned, so not less than 0 (line 230).
julia
-- Forwarded message --
Date: Tue, 20 Mar 2018 16:39:16 +0800
From: kbuild test robot
To: kbu...@01.org
Cc: Julia Lawall
Subject: [drm-intel:drm-intel-next-queued 13/14]
drivers/gpu/drm/i915/intel_guc.c:230:12-17
On Sun, 25 Mar 2018, Arushi Singhal wrote:
>
>
> On Mon, Mar 19, 2018 at 12:44 PM, Julia Lawall wrote:
>
>
> On Mon, 19 Mar 2018, Arushi Singhal wrote:
>
> > This patch replace list_entry with list_{next/prev}_entry as
> it makes
>
On Sun, 25 Mar 2018, Arushi Singhal wrote:
>
>
> On Mon, Mar 19, 2018 at 12:44 PM, Julia Lawall wrote:
>
>
> On Mon, 19 Mar 2018, Arushi Singhal wrote:
>
> > This patch replace list_entry with list_{next/prev}_entry as
> it makes
>
patch drm-get-put-cocci.
>
> Signed-off-by: Haneen Mohammed
Acked-by: Julia Lawall
For the Coccinelle part.
> ---
> include/drm/drm_property.h | 26 --
> scripts/coccinelle/api/drm-get-put.cocci | 10 --
> 2 files changed, 36 delet
The NULL comment is referring to the path to line 3388 via line 3360. But
if the value is not NULL, there will be an update of previously freed
memory.
julia
-- Forwarded message --
Date: Tue, 15 Aug 2017 18:58:51 +0800
From: kbuild test robot
To: kbu...@01.org
Cc: Julia Lawall
+0800
From: kbuild test robot
To: kbu...@01.org
Cc: Julia Lawall
Subject: [radeon-alex:amd-staging-drm-next 772/843]
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:3387:1-6: ERROR:
reference preceded by free on line 3384
CC: kbuild-...@01.org
CC: dri-devel@lists.freedesktop.o
On Wed, 13 Sep 2017, Meghana Madhyastha wrote:
> EXPORT_SYMBOL(foo) should immediately follow its function/variable.
> This coding style is preferred.
> Found by checkpath.pl.
>
> Signed-off-by: Meghana Madhyastha
> ---
> drivers/gpu/drm/drm_agpsupport.c | 4
> 1 file changed, 4 deletions
On Wed, 13 Sep 2017, Meghana Madhyastha wrote:
> This replaces all instances of foo * bar with foo *bar
> in drm_agpsupport.c. This is so that it adheres to
> standard C syntax for pointers.
>
> Signed-off-by: Meghana Madhyastha
Acked-by: Julia Lawall
> ---
On Wed, 13 Sep 2017, Meghana Madhyastha wrote:
> Move the assignment so that it happens before the if
> condition. This results in syntax which is easier to read.
It would be nice to mention the merged conditionals in the log message.
julia
> Found by checkpath.pl
>
> Signed-off-by: Meghana M
On Thu, 14 Sep 2017, Meghana Madhyastha wrote:
> Remove extra blank line to adhere to standard coding style.
> Found by checkpath.pl..
>
> Signed-off-by: Meghana Madhyastha
> ---
> Changes in v3:
> -This was part of another commit in v2 and v1.
> Now made this a separate commit
>
> drivers/
@@
>
> (
> -dev_info
> +DRM_DEV_INFO
> |
> -dev_err
> +DRM_DEV_ERROR
> |
> -dev_dbg
> +DRM_DEV_DEBUG
> )
>
> Signed-off-by: Haneen Mohammed
Acked-by: Julia Lawall
> ---
> drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 26 +++
> drive
101 - 200 of 335 matches
Mail list logo
