On Thu, Jun 22, 2023 at 05:28:15PM +, Allen Ballway wrote:
> --- a/drivers/gpu/drm/i915/display/intel_backlight.c
> +++ b/drivers/gpu/drm/i915/display/intel_backlight.c
> @@ -1192,6 +1192,11 @@ static u32 get_backlight_min_vbt(struct
> intel_connector *connector)
>
> drm_WARN_ON(&i915->
When building kernels for a preliminary hardware target, having to add a
kernel command-line option can prove inconvenient. Add a Kconfig option
that changes the default of this option to 1.
Signed-off-by: Josh Triplett
---
I dropped the indication of the default in the module parameter
es to the MAINTAINERS
file (perhaps in the same entry as get_maintainer.pl), so that
get_maintainer.pl does not fall back to git history for them?
- Josh Triplett
On Sat, Nov 08, 2014 at 12:49:29PM -0800, Joe Perches wrote:
> On Sat, 2014-11-08 at 11:01 -0800, Josh Triplett wrote:
> > On Sat, Nov 08, 2014 at 08:37:27PM +0200, Oded Gabbay wrote:
> > > CREDITS | 7 +++
> > > MAINTAINERS | 10 ++
> >
When building kernels for a preliminary hardware target, having to add a
kernel command-line option can prove inconvenient. Add a Kconfig option
that changes the default of this option to 1.
Signed-off-by: Josh Triplett
---
I dropped the indication of the default in the module parameter
this should
just "return kmemdup(...);".
That suggests an obvious further cleanup that coccinelle could easily
handle:
if (!foo)
return NULL;
return foo;
should become just "return foo;". And you might then want to check for
variables used *only* to capture a return value and imm
0 or NULL,
> where some of the fields already use labels, and where there are nested
> structures.
I responded to patches 6 and 8 with comments; for the rest (1-5, 7, 9):
Reviewed-by: Josh Triplett
//
>
> Signed-off-by: Julia Lawall
For this patch, I think it would make sense to drop
initializations of preferred/quirks/modes to 0, since a designated
initializer may skip fields to leave them initialized to 0.
With that change:
Reviewed-by: Josh Triplett
&
_du_update_layout? [-Wmissing-prototypes]
> >
> > Signed-off-by: Rashika Kheria
> > Reviewed-by: Josh Triplett
> > ---
> > drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 12 ++--
> > 1 file changed, 6 insertions(+), 6 deletions(-)
>
>
> This and pat
evice.c:281:6: warning: no previous
> > prototype for ?radeon_doorbell_fini? [-Wmissing-prototypes]
> >
> > Signed-off-by: Rashika Kheria
> > Reviewed-by: Josh Triplett
>
> I've pulled in a subset of these patches:
> http://cgit.freedesktop.org/~agd5f/linux/log/?h=drm-
On Wed, Jun 10, 2015 at 06:20:52AM -0300, Mauro Carvalho Chehab wrote:
> From: Jan Kara
>
> get_vaddr_frames() is used by relatively rare drivers so hide it and the
> related functions behind a config option that is selected only by
> drivers that need the infrastructure.
>
> Suggested-by: Andre
this should
just "return kmemdup(...);".
That suggests an obvious further cleanup that coccinelle could easily
handle:
if (!foo)
return NULL;
return foo;
should become just "return foo;". And you might then want to check for
variables used *only* to capture a return value and immediately
returned, and eliminate them.
- Josh Triplett
12 matches
Mail list logo