On Wed, Jan 08, 2014 at 11:40:28AM -0500, Alex Deucher wrote: > On Mon, Jan 6, 2014 at 10:21 AM, Rashika Kheria > <rashika.kheria at gmail.com> wrote: > > Mark functions radeon_doorbell_init() and radeon_doorbell_fini() as > > static in drm/radeon/radeon_device.c because they are not used outside > > this file. > > > > This eliminates the following warning in drm/radeon/radeon_device.c: > > drivers/gpu/drm/radeon/radeon_device.c:252:5: warning: no previous > > prototype for ?radeon_doorbell_init? [-Wmissing-prototypes] > > drivers/gpu/drm/radeon/radeon_device.c:281:6: warning: no previous > > prototype for ?radeon_doorbell_fini? [-Wmissing-prototypes] > > > > Signed-off-by: Rashika Kheria <rashika.kheria at gmail.com> > > Reviewed-by: Josh Triplett <josh at joshtriplett.org> > > I've pulled in a subset of these patches: > http://cgit.freedesktop.org/~agd5f/linux/log/?h=drm-next-3.14-wip > I held off on some of the others as I'd rather fix up the headers > properly rather than just cramming everything in radeon.h or > radeon-asic.h for now.
Can you elaborate on which patches are putting functions in the wrong header, and what header you'd prefer to see them in? - Josh Triplett
