Hi,
On 02/04/2015 04:14 AM, Gustavo Padovan wrote:
> From: Gustavo Padovan
>
> The new atomic infrastructure needs the .mode_set_nofb() callback to
> update CRTC timings before setting any plane.
>
> Signed-off-by: Gustavo Padovan
>
> Conflicts:
> drivers/gpu/drm/exynos/exynos_drm_crtc.
Hi,
On 02/04/2015 04:14 AM, Gustavo Padovan wrote:
> From: Gustavo Padovan
>
> Use drm_atomic_set_fb_for_plane() in the legacy page_flip path to keep
> track of the framebuffer pointer and reference.
>
> Signed-off-by: Gustavo Padovan
> ---
> drivers/gpu/drm/exynos/exynos_drm_crtc.c | 3 +++
>
Hi Daniel,
On 02/04/2015 11:16 PM, Daniel Vetter wrote:
> On Wed, Feb 04, 2015 at 04:42:57PM +0900, Joonyoung Shim wrote:
>> Hi,
>>
>> On 02/04/2015 04:14 AM, Gustavo Padovan wrote:
>>> From: Gustavo Padovan
>>>
>>> exynos_plane_dpms(DRM_MODE_DPM
Hi Daniel,
On 02/04/2015 11:28 PM, Daniel Vetter wrote:
> On Wed, Feb 04, 2015 at 04:44:12PM +0900, Joonyoung Shim wrote:
>> Hi,
>>
>> On 02/04/2015 04:14 AM, Gustavo Padovan wrote:
>>> From: Gustavo Padovan
>>>
>>> struct {fimd,mixer,vidi}_win_d
Hi Daniel,
On 02/04/2015 11:30 PM, Daniel Vetter wrote:
> On Wed, Feb 04, 2015 at 04:49:25PM +0900, Joonyoung Shim wrote:
>> Hi,
>>
>> On 02/04/2015 04:14 AM, Gustavo Padovan wrote:
>>> From: Gustavo Padovan
>>>
>>> Add CRTC callbacks .atomic_begin
exynos_plane_dpms() call with no effect
Joonyoung Shim (3):
drm/exynos: remove mode property of exynos crtc
drm/exynos: remove exynos_plane_dpms
drm/exynos: fix NULL pointer reference
drivers/gpu/drm/exynos/exynos_drm_crtc.c| 62 -
drivers/gpu/drm/exynos
This was added by commit 3b8d1cf818c2 ("drm/exynos: add property for
crtc mode"). Currently we can control a plane used for crtc using
primary plane by universal plane feature. Stop to use non-standard
property to control primary plane.
Signed-off-by: Joonyoung Shim
---
drivers/gpu/
From: Gustavo Padovan
exynos_plane_dpms(DRM_MODE_DPMS_ON) calls the win_enable()'s callback
from the underlying layer. However neither one of these layers implement
win_enable() - FIMD, Mixer and VIDI. Thus the call to exynos_plane_dpms()
is pointless.
Signed-off-by: Gustavo Padovan
---
driver
flag.
Let's remove enabled flag, it just stop to recall internal callback
function but hw drivers can handle it properly. And call internal
callback function directly then we can remove unnecessary
exynos_plane_dpms function
Signed-off-by: Joonyoung Shim
---
drivers/gpu/drm/e
There is a case called disable_plane callback function even if
plane->crtc is NULL from exynos_drm_encoder_disable and it will cause
NULL pointer reference error.
Signed-off-by: Joonyoung Shim
---
drivers/gpu/drm/exynos/exynos_drm_encoder.c | 2 +-
1 file changed, 1 insertion(+), 1 delet
exynos_fbd->exynos_gem_obj;
> struct drm_framebuffer *fb;
>
> - if (is_drm_iommu_supported(dev) && exynos_gem_obj->buffer->kvaddr)
> + if (is_drm_iommu_supported(dev))
> vunmap(exynos_gem_obj->buffer->kvaddr);
>
> /* release drm framebuffer and real buffer */
>
Acked-by: Joonyoung Shim
Thanks.
Hi,
On 02/05/2015 10:06 PM, Daniel Vetter wrote:
> On Thu, Feb 05, 2015 at 12:48:07PM +, Daniel Stone wrote:
>> Hi,
>>
>> On 5 February 2015 at 12:26, Rob Clark wrote:
>>> On Thu, Feb 5, 2015 at 4:15 AM, Daniel Vetter wrote:
Yeah I noticed the zpos fun when hacking around too. Exynos sh
Hi,
On 02/05/2015 10:07 PM, Gustavo Padovan wrote:
> Hi,
>
>
> 2015-02-05 Joonyoung Shim :
>
>> There is a case called disable_plane callback function even if
>> plane->crtc is NULL from exynos_drm_encoder_disable and it will cause
>> NULL pointer
Hi,
On 02/05/2015 06:40 PM, Daniel Vetter wrote:
> On Thu, Feb 05, 2015 at 04:11:35PM +0900, Joonyoung Shim wrote:
>> From: Gustavo Padovan
>>
>> exynos_plane_dpms(DRM_MODE_DPMS_ON) calls the win_enable()'s callback
>> from the underlying layer. However neith
Hi Gustavo,
On 02/06/2015 02:59 AM, Gustavo Padovan wrote:
> From: Gustavo Padovan
>
> struct {fimd,mixer,vidi}_win_data was just keeping the same data
> as struct exynos_drm_plane thus get ride of it and use exynos_drm_plane
> directly.
>
> It changes how planes are created and remove .win_mod
Hi,
On 02/06/2015 02:59 AM, Gustavo Padovan wrote:
> From: Gustavo Padovan
>
> Usually userspace don't want to have two overlay planes on the same zpos
> so this change assign a different zpos for each plane. Before this change
> a zpos of value zero was created for all planes so the userspace h
Hi,
On 02/06/2015 02:59 AM, Gustavo Padovan wrote:
> From: Gustavo Padovan
>
> The primary plane default zpos is now 0, so remove checks for zpos ==
> -1. We don't need to set win to 0 anymore it is already zero.
>
Could you also remove DEFAULT_ZPOS define? And zpos and win should be
unsigned
Hi,
On 02/05/2015 11:45 PM, Javier Martinez Canillas wrote:
> Hello Andrzej,
>
> Thanks a lot for finally finding what was causing the HDMI issue.
>
> On 02/05/2015 01:35 PM, Andrzej Hajda wrote:
>> Hi,
>>
>> Exynos chipsets since 542x have asynchronous bridges connecting different
>> IPs.
>> T
ve.
>
Working well on odroid u3 board.
Tested-by: Joonyoung Shim
Hi,
On 02/03/2015 10:53 PM, Tobias Jakobi wrote:
> The blend test uses the userptr functionality of exynos-drm, which
> is currently not safe to use. If the kernel hasn't been build with
> exynos-iommu support, then the blend test is going to produce (kernel)
> memory corruption, eventually leadin
Hi,
On 02/11/2015 10:39 AM, Tobias Jakobi wrote:
> Hello Joonyoung!
>
> Joonyoung Shim wrote:
>> Hi,
>>
>> On 02/03/2015 10:53 PM, Tobias Jakobi wrote:
>>> The blend test uses the userptr functionality of exynos-drm, which
>>> is currently not safe
On 07/04/2013 07:11 AM, Laurent Pinchart wrote:
> Hi Joonyoung,
>
> Thank you for the patches.
>
> On Friday 28 June 2013 14:24:43 Joonyoung Shim wrote:
>> Hello,
>>
>> This is the second version patchset.
>>
>> GEM CMA supports dma_buf but it needs
The drm_gem_map_detach() can be called with sgt is NULL.
Change-Id: I3b2f5878dfac6e1e77aebeeb7be781113dec59a7
Signed-off-by: Joonyoung Shim
---
drivers/gpu/drm/drm_prime.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/drm_prime.c b/drivers/gpu
The drm_gem_map_detach() can be called with sgt is NULL.
Signed-off-by: Joonyoung Shim
---
drivers/gpu/drm/drm_prime.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/drm_prime.c b/drivers/gpu/drm/drm_prime.c
index 1e0de41..ff5fece 100644
--- a
On 07/05/2013 02:38 PM, Dave Airlie wrote:
> On Thu, Jul 4, 2013 at 5:14 PM, Joonyoung Shim
> wrote:
>> On 07/04/2013 07:11 AM, Laurent Pinchart wrote:
>>> Hi Joonyoung,
>>>
>>> Thank you for the patches.
>>>
>>> On Friday 28 June 2013 14:
>From drm gem CMA helper, it wasn't fixed dma_buf refcount problem fixed
by commit 011c228. This patch solves it.
Signed-off-by: Joonyoung Shim
---
drivers/gpu/drm/drm_gem_cma_helper.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_gem_cma_hel
On 07/05/2013 06:46 PM, Laurent Pinchart wrote:
> Hi Joonyoung,
>
> Thank you for the patch.
>
> On Friday 05 July 2013 15:32:35 Joonyoung Shim wrote:
>> From drm gem CMA helper, it wasn't fixed dma_buf refcount problem fixed
>> by commit 011c228. This patch solv
On 07/05/2013 10:03 PM, Laurent Pinchart wrote:
> Hi Joonyoung,
>
> On Friday 05 July 2013 15:30:25 Joonyoung Shim wrote:
>> On 07/05/2013 02:38 PM, Dave Airlie wrote:
>>> On Thu, Jul 4, 2013 at 5:14 PM, Joonyoung Shim wrote:
>>>> On 07/04/2013 07:11 AM, Lauren
u/drm/exynos/exynos_drm_fimd.c | 90
>>>
>>> 1 file changed, 68 insertions(+), 22
>>> deletions(-)
>> Any comments for this series?
>>
>> Best regards,
>> Tomasz
> Ping.
>
> Best regards,
> Tomasz
>
>
This series looks good to me.
Acked-by: Joonyoung Shim
On 05/19/2013 08:32 PM, Tomasz Figa wrote:
> Hi,
>
> On Wednesday 01 of May 2013 22:00:25 Daniel Vetter wrote:
>> On Wed, May 01, 2013 at 09:06:09PM +0200, Tomasz Figa wrote:
>>> This patch modifies the driver to perform two stage parsing of video
>>> timings from device tree, to get timing informa
On 06/06/2013 06:47 PM, Tomasz Figa wrote:
> Hi Joonyoung,
>
> On Thursday 06 of June 2013 13:30:49 Joonyoung Shim wrote:
>> On 05/19/2013 08:32 PM, Tomasz Figa wrote:
>>> Hi,
>>>
>>> On Wednesday 01 of May 2013 22:00:25 Daniel Vetter wrote:
>>>
me helpers.
Thanks.
Joonyoung Shim (3):
drm: add mmap function to prime helpers
drm/cma: add low-level hook functions to use prime helpers
drm/cma: remove GEM CMA specific dma_buf functionality
drivers/gpu/drm/drm_gem_cma_helper.c | 291
+--
d
This adds to call low-level mmap() from prime helpers.
Signed-off-by: Joonyoung Shim
---
drivers/gpu/drm/drm_prime.c | 5 -
include/drm/drmP.h | 2 ++
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_prime.c b/drivers/gpu/drm/drm_prime.c
index
Instead of using the dma_buf functionality for GEM CMA, we can use prime
helpers if we can provide low-level hook functions for GEM CMA.
Signed-off-by: Joonyoung Shim
---
drivers/gpu/drm/drm_gem_cma_helper.c | 76
include/drm/drm_gem_cma_helper.h | 9
We can use prime helpers instead.
Signed-off-by: Joonyoung Shim
---
drivers/gpu/drm/drm_gem_cma_helper.c | 283 ---
include/drm/drm_gem_cma_helper.h | 6 -
2 files changed, 289 deletions(-)
diff --git a/drivers/gpu/drm/drm_gem_cma_helper.c
b/drivers/gpu
Hi,
>>> diff --git a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
>>> b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
>>> index e71e331..e0b085b 100644
>>> --- a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
>>> +++ b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
>>> @@ -275,9 +275,6 @@ int exynos_drm_fbdev_ini
It's more reasonable to use src_x and src_y to represent source as
counterpart of destination(crtc). Already we are using src_width and
src_height for width and height of source.
Signed-off-by: Joonyoung Shim
---
drivers/gpu/drm/exynos/exynos7_drm_decon.c | 4 ++--
drivers/gpu/drm/e
Calculation ratio from exynos_drm plane codes, then each hw drivers can
use it without extra operation. Also this fixes width and height of
source used for actual crtc shown via screen.
Signed-off-by: Joonyoung Shim
---
drivers/gpu/drm/exynos/exynos_drm_drv.h | 4
drivers/gpu/drm/exynos
drm/exynos/regs-mixer.h
> +++ b/drivers/gpu/drm/exynos/regs-mixer.h
> @@ -101,7 +101,7 @@
> #define MXR_CFG_GRP0_ENABLE (1 << 4)
> #define MXR_CFG_VP_ENABLE(1 << 3)
> #define MXR_CFG_SCAN_INTERLACE (0 << 2)
> -#define MXR_CFG_
DRM_ERROR("cannot use this gem memory type for fb.\n");
> + if (ret < 0)
> goto err_unreference;
> - }
> }
>
> ret = drm_framebuffer_init(dev, &exynos_fb->fb, &exynos_drm_fb_funcs);
>
Acked-by: Joonyoung Shim
Thanks.
er_context *ctx,
> int win)
> mixer_reg_write(res, MXR_RESOLUTION, val);
> }
>
> - val = MXR_GRP_WH_WIDTH(plane->crtc_width);
> - val |= MXR_GRP_WH_HEIGHT(plane->crtc_height);
> + val = MXR_GRP_WH_WIDTH(plane->src_width);
> + val |= MXR_GRP_WH_HEIGHT(plane->src_height);
With this changes, i got errors when crtc gets out bound of actual
screen area. I sent patch to fix it and to calculate ratio from
exynos_drm plane codes.
Acked-by: Joonyoung Shim
Thanks.
if (funcs && funcs->disable)
>>> + (*funcs->disable)(crtc, mode);
>>
>> This patch makes funcs->disable callback to be called instead of
>> funcs->dpms callback. However, funcs->disable callback isn't re
Don't call directly disable callback of plane helper, we need to
disconnect the plane from the fb and crtc after disable callback.
Signed-off-by: Joonyoung Shim
---
drivers/gpu/drm/exynos/exynos_drm_crtc.c| 5 +
drivers/gpu/drm/exynos/exynos_drm_encoder.c | 2 +-
2 files chang
Hi,
On 04/09/2015 12:14 AM, Inki Dae wrote:
> On 2015ë
04ì 08ì¼ 03:39, Gustavo Padovan wrote:
>> Hi Inki,
>>
>> 2015-04-07 Inki Dae :
>>
>>> On 2015ë
04ì 07ì¼ 00:44, Inki Dae wrote:
2015-04-06 19:46 GMT+09:00 Inki Dae :
> On 2015ë
04ì 04ì¼ 03:09, Gustavo Padovan wrote:
Hi,
On 04/11/2015 03:57 AM, Gustavo Padovan wrote:
> From: Gustavo Padovan
>
> The planes are already disabled by the drm_atomic_helper_commit() code
> so we don't need to disable the in these two places.
>
> Signed-off-by: Gustavo Padovan
> ---
> drivers/gpu/drm/exynos/exynos_drm_crtc.c|
Hi all,
This patchset is to fix properly about buffer and framebuffer resources
when terminates modetest of libdrm.
Thanks.
Joonyoung Shim (5):
modetest: fix Segmentation fault
modetest: add to use drmModeRmFB
modetest: fix to proper error path handling
modetest: clear
It's proper to remove added framebuffer before destroy buffer.
Signed-off-by: Joonyoung Shim
---
tests/modetest/modetest.c | 4
1 file changed, 4 insertions(+)
diff --git a/tests/modetest/modetest.c b/tests/modetest/modetest.c
index b59f6b5..6377459 100644
--- a/tests/modetest/modet
This patch needs to destroy and to remove buffer and framebuffer
properly from error path of set_mode and test_page_flip.
Signed-off-by: Joonyoung Shim
---
tests/modetest/modetest.c | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/tests/modetest/modetest.c b
Currently, we are missing to destroy buffer and to remove framebuffer of
planes when terminates modetest.
Signed-off-by: Joonyoung Shim
---
tests/modetest/modetest.c | 19 +++
1 file changed, 19 insertions(+)
diff --git a/tests/modetest/modetest.c b/tests/modetest/modetest.c
Currently, we are missing to destroy buffer of cursor when terminates
modetest.
Signed-off-by: Joonyoung Shim
---
tests/modetest/modetest.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/tests/modetest/modetest.c b/tests/modetest/modetest.c
index 56d49b0..758d86c 100644
--- a/tests
If use -P option without -s option, we meet Segmentation fault error
when modetest is terminated. Check whether dev.mode.bo is NULL.
Signed-off-by: Joonyoung Shim
---
tests/modetest/modetest.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/tests/modetest/modetest.c
The exynos_update_plane function needs 16.16 fixed point source data.
Signed-off-by: Joonyoung Shim
---
drivers/gpu/drm/exynos/exynos_drm_crtc.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_crtc.c
b/drivers/gpu/drm/exynos
Arrange arguments of MAKE_RGB_INFO define in order of rgb.
Signed-off-by: Joonyoung Shim
---
tests/modetest/buffers.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/modetest/buffers.c b/tests/modetest/buffers.c
index e4e8149..807819a 100644
--- a/tests/modetest
Hi Gustavo,
On 03/19/2015 11:27 PM, Gustavo Padovan wrote:
> From: Gustavo Padovan
>
> 'val' wasn't clean after its last usage, so we could get garbage value and
> send the wrong command to the hw.
>
> Signed-off-by: Gustavo Padovan
> ---
> drivers/gpu/drm/exynos/exynos_mixer.c | 2 +-
> 1 fi
Hi Gustavo,
On 03/19/2015 11:27 PM, Gustavo Padovan wrote:
> From: Gustavo Padovan
>
> Change the switch to use the pixel_format instead of bpp to figure out
> if we need to enable or disable the layer blending.
>
The default concept is ok about enable or disable of pixel blending
feature by p
Hi Tobias,
On 04/16/2015 04:54 AM, Tobias Jakobi wrote:
> No component of Exynos DRM uses this field. Perhaps it was
> once meant to provide more fine-grained information in
> addition to the status stored in the 'enabled' field.
>
> Reviewed-by: Gustavo Padovan
> Signed-off-by: Tobias Jakobi
>
Hi Tobias,
On 04/17/2015 05:04 PM, Tobias Jakobi wrote:
> Hello Joonyoung,
>
> On 2015-04-17 08:30, Joonyoung Shim wrote:
>> Hi Tobias,
>>
>> On 04/16/2015 04:54 AM, Tobias Jakobi wrote:
>>> No component of Exynos DRM uses this field. Perhaps it was
>>
Hi Emil,
On 04/22/2015 05:16 AM, Emil Velikov wrote:
> Hi Joonyoung,
>
> On 13/04/15 08:31, Joonyoung Shim wrote:
>> Hi all,
>>
>> This patchset is to fix properly about buffer and framebuffer resources
>> when terminates modetest of libdrm.
>>
> The s
Hi Tobias,
On 04/23/2015 09:12 PM, Tobias Jakobi wrote:
> Move the defines for the pixelformats that the mixer supports out
> of mixer_graph_buffer() to the top of the source.
> Then select the mixer pixelformat (pf) in mixer_graph_buffer() based on
> the plane's pf (and not bpp).
> Also add handl
remove also index_color?
>
> - bool default_win:1;
> - bool color_key:1;
> - bool local_path:1;
> - bool transparency:1;
> - bool activated:1;
> bool enabled:1;
> bool resume:1;
> };
>
Acked-by: Joonyoung Shim
Thanks.
Hi Tobias,
On 04/24/2015 05:10 PM, Tobias Jakobi wrote:
> On 2015-04-24 03:48, Joonyoung Shim wrote:
>> Hi Tobias,
>>
>> On 04/23/2015 09:12 PM, Tobias Jakobi wrote:
>>> Move the defines for the pixelformats that the mixer supports out
>>> of mixer_
Hi Gustavo,
On 04/25/2015 03:15 AM, Gustavo Padovan wrote:
> Hi Joonyoung,
>
> 2015-04-16 Joonyoung Shim :
>
>> The exynos_update_plane function needs 16.16 fixed point source data.
>>
>> Signed-off-by: Joonyoung Shim
>> ---
>> drivers/gpu/drm/exyno
lor;
>
> - bool default_win:1;
> - bool color_key:1;
> - bool local_path:1;
> - bool transparency:1;
> - bool activated:1;
> bool enabled:1;
> bool resume:1;
> };
>
Acked-by: Joonyoung Shim
Thanks.
Hi Tobias,
On 04/26/2015 05:31 AM, Tobias Jakobi wrote:
> The video processor (VP) supports four formats: NV12, NV21 and its
> tiled variants. All these formats are bi-planar, so the buffer
> count in vp_video_buffer() is always 2.
>
> While we're at it, also add support for NV21 and properly exi
kobi
> ---
> drivers/gpu/drm/exynos/exynos_drm_fb.c | 39
> +-
> 1 file changed, 1 insertion(+), 38 deletions(-)
>
Looks good to me about this series,
Acked-by: Joonyoung Shim
Thanks.
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_fb.c
> b
RMAT as prefix.
> v3: Re-add ARGB because of compatibility reasons
> (suggested by Joonyoung Shim).
>
> Reviewed-by: Gustavo Padovan
> Signed-off-by: Tobias Jakobi
> ---
> drivers/gpu/drm/exynos/exynos_mixer.c | 33 +++--
> 1 file changed, 23
On 08/06/2015 07:00 PM, Daniel Stone wrote:
> Hi Joonyoung,
>
> On 28 July 2015 at 09:53, Joonyoung Shim wrote:
>> static void update_vm_cache_attr(struct exynos_drm_gem_obj *obj,
>> struct vm_area_struct *vma)
>> {
>
Hi Tomasz,
On 10/02/2014 12:13 AM, Tomasz Figa wrote:
> Hi Inki,
>
> On 17.09.2014 15:48, Inki Dae wrote:
>> This interface and relevant codes aren't used anymore.
>>
>
> Hmm, I might be missing something, but after removing this IOCTL, how do
> we obtain an offset to pass to mmap()?
There is D
patch?
>From 6de01473746af225c688ee430123001d57d9af2a Mon Sep 17 00:00:00 2001
From: Joonyoung Shim
Date: Thu, 2 Oct 2014 17:48:27 +0900
Subject: [PATCH] drm/exynos: use drm_vblank_on()
We need to use drm_vblank_on() as a counterpart to drm_vblank_off()
after the commit 7ffd7a68511c ("drm: Always reject
On 06/15/2013 02:16 AM, Aaron Plattner wrote:
> On 06/12/2013 06:16 AM, Joonyoung Shim wrote:
>> This adds to call low-level mmap() from prime helpers.
>>
>> Signed-off-by: Joonyoung Shim
>> ---
>> drivers/gpu/drm/drm_prime.c | 5 -
>> include/
On 06/19/2013 08:02 AM, Laurent Pinchart wrote:
> Hi Joonyoung,
>
> On Wednesday 12 June 2013 22:16:14 Joonyoung Shim wrote:
>> Hi,
>>
>> GEM CMA supports dma_buf but it needs GEM CMA specific functionality for
>> dma_buf. We can use pr
The drm prime also can support it like GEM CMA supports to cache
mapping. It doesn't allow multiple mappings for one attachment.
Signed-off-by: Joonyoung Shim
---
drivers/gpu/drm/drm_prime.c | 54 +
1 file changed, 50 insertions(+), 4 dele
from "drm: add mmap function to prime helpers" commit
Joonyoung Shim (3):
drm: add mmap function to prime helpers
drm/cma: add low-level hook functions to use prime helpers
drm/cma: remove GEM CMA specific dma_buf functionality
drivers/gpu/drm/drm_ge
Instead of using the dma_buf functionality for GEM CMA, we can use prime
helpers if we can provide low-level hook functions for GEM CMA.
Signed-off-by: Joonyoung Shim
---
drivers/gpu/drm/drm_gem_cma_helper.c | 79
include/drm/drm_gem_cma_helper.h | 9
This adds to call low-level mmap() from prime helpers.
Signed-off-by: Joonyoung Shim
---
drivers/gpu/drm/drm_prime.c | 8 +++-
include/drm/drmP.h | 2 ++
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_prime.c b/drivers/gpu/drm/drm_prime.c
index
We can use prime helpers instead.
Signed-off-by: Joonyoung Shim
---
drivers/gpu/drm/drm_gem_cma_helper.c | 286 ---
include/drm/drm_gem_cma_helper.h | 6 -
2 files changed, 292 deletions(-)
diff --git a/drivers/gpu/drm/drm_gem_cma_helper.c
b/drivers/gpu
Hi Leela,
On 03/05/2013 08:25 PM, Leela Krishna Amudala wrote:
> Calculate the correct address offset values for alpha and color key
> control registers
>
> Signed-off-by: Leela Krishna Amudala
> ---
> drivers/gpu/drm/exynos/exynos_drm_fimd.c | 9 +
> 1 file changed, 5 insertions(+), 4
On 03/05/2013 09:04 PM, Leela Krishna Amudala wrote:
> Hi,
>
> On Tue, Mar 5, 2013 at 5:24 PM, Joonyoung Shim
> wrote:
>> Hi Leela,
>>
>>
>> On 03/05/2013 08:25 PM, Leela Krishna Amudala wrote:
>>> Calculate the correct address offset values
On 03/06/2013 02:20 PM, Leela Krishna Amudala wrote:
> Calculate the correct address offset values for alpha and color key
> control registers and clear size control register for window 0
>
> Signed-off-by: Leela Krishna Amudala
> ---
> drivers/gpu/drm/exynos/exynos_drm_fimd.c | 16 ++---
(struct device *dev, int zpos)
> if (win != 3 && win != 4) {
> u32 offset = VIDOSD_D(win);
> if (win == 0)
> - offset = VIDOSD_C_SIZE_W0;
> + offset = VIDOSD_C(win);
> val = win_data->ovl_width * win_data->ovl_height;
> writel(val, ctx->regs + offset);
>
Acked-by: Joonyoung Shim
Thanks.
On 03/13/2013 06:04 PM, Inki Dae wrote:
> From: YoungJun Cho
>
> This patch fixes G2D core mulfunctioning issue once g2d dma is started.
> Without 'DMA_HOLD_CMD_REG' register setting, there is only one interrupt
> after the execution to all command lists have been completed. And that
> induces wat
On 03/13/2013 06:04 PM, Inki Dae wrote:
> From: YoungJun Cho
>
> This patch just cleans up G2D codes for readability.
>
> For this, it changes the member of g2d_cmdlist_node, obj_type into
> buf_type and gathers relevant variables together.
Please make patch only about s/obj_type/buf_type.
>
> S
On 03/13/2013 07:14 PM, Inki Dae wrote:
>
>> -Original Message-
>> From: Joonyoung Shim [mailto:jy0922.shim at samsung.com]
>> Sent: Wednesday, March 13, 2013 6:53 PM
>> To: Inki Dae
>> Cc: airlied at linux.ie; dri-devel at lists.freedesktop.org;
>> k
On 03/13/2013 07:53 PM, Inki Dae wrote:
>> -Original Message-
>> From: Joonyoung Shim [mailto:jy0922.shim at samsung.com]
>> Sent: Wednesday, March 13, 2013 7:28 PM
>> To: Inki Dae
>> Cc:airlied at linux.ie;dri-devel at lists.freedesktop.org;
>> kyungm
501 - 584 of 584 matches
Mail list logo
