Re: [PATCH 1/3] drm: exynos: hdmi: add exynos5 support to mixer driver

2012-09-12 Thread Joonyoung Shim
Hi, Rahul. On 09/12/2012 09:08 PM, Rahul Sharma wrote: Added support for exynos5 to drm mixer driver. Exynos5 works with dt enabled while in exynos4 mixer device information can be passed either way (dt or plf data). This situation is taken cared. Signed-off-by: Rahul Sharma Signed-off-by: Shi

Re: [PATCH 3/3] drm: exynos: hdmi: clean dependency on plf data for mixer, hdmi context

2012-09-12 Thread Joonyoung Shim
Hi, Rahul. On 09/12/2012 09:08 PM, Rahul Sharma wrote: exynos-drm-hdmi need context pointers from hdmi and mixer. These pointers were expected from the plf data. Cleaned this dependency What does plf data mean? by exporting i/f which are called by hdmi, mixer driver probes for setting their

Re: [PATCH 1/3] drm: exynos: hdmi: add exynos5 support to mixer driver

2012-09-12 Thread Joonyoung Shim
On 09/13/2012 11:53 AM, Inki Dae wrote: -Original Message- From: Joonyoung Shim [mailto:jy0922.s...@samsung.com] Sent: Thursday, September 13, 2012 10:44 AM To: Rahul Sharma Cc: dri-devel@lists.freedesktop.org; sw0312@samsung.com; inki@samsung.com; kyungmin.p...@samsung.com

Re: [PATCH] drm: Destroy the planes prior to destroying the associated CRTC

2012-09-19 Thread Joonyoung Shim
On 09/17/2012 06:38 PM, Chris Wilson wrote: As during the plane cleanup, we wish to disable the hardware and so may modify state on the associated CRTC, that CRTC must continue to exist until we are finished. A similar issue can occur in the drm_framebuffer_cleanup(). If crtc and plane use same

Re: [PATCH] drm: Destroy the planes prior to destroying the associated CRTC

2012-09-19 Thread Joonyoung Shim
On 09/20/2012 02:38 PM, Rob Clark wrote: On Wed, Sep 19, 2012 at 9:52 PM, Joonyoung Shim wrote: On 09/17/2012 06:38 PM, Chris Wilson wrote: As during the plane cleanup, we wish to disable the hardware and so may modify state on the associated CRTC, that CRTC must continue to exist until we

Re: [PATCH] drm: Destroy the planes prior to destroying the associated CRTC

2012-09-20 Thread Joonyoung Shim
On 09/20/2012 04:49 PM, Chris Wilson wrote: On Thu, 20 Sep 2012 15:10:39 +0900, Joonyoung Shim wrote: On 09/20/2012 02:38 PM, Rob Clark wrote: On Wed, Sep 19, 2012 at 9:52 PM, Joonyoung Shim wrote: On 09/17/2012 06:38 PM, Chris Wilson wrote: As during the plane cleanup, we wish to disable

[PATCH] drm/exynos: fix to calculate CRTC shown via screen

2012-09-27 Thread Joonyoung Shim
This patch is to exactly calculate CRTC shown via screen for all cases. Refer exynos_plane_get_size() function for this. Also source position of fb is fixed when start position of CRTC is negative number. Signed-off-by: Joonyoung Shim Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos

[PATCH] drm/exynos: fix kcalloc size of g2d cmdlist node

2012-09-27 Thread Joonyoung Shim
The size argument means just one element size when we call kcalloc, so G2D_CMDLIST_NUM * sizeof(*node) is wrong. Signed-off-by: Joonyoung Shim Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_g2d.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a

Re: [PATCH 11/14] drm: exynos: hdmi: add support for exynos5 mixer

2012-10-02 Thread Joonyoung Shim
On 09/28/2012 11:25 PM, Rahul Sharma wrote: This patch adds support for exynos5 mixer with device tree enabled. Signed-off-by: Rahul Sharma Signed-off-by: Fahad Kunnathadi --- drivers/gpu/drm/exynos/exynos_mixer.c | 41 ++-- drivers/gpu/drm/exynos/regs-mixer.h

Re: [PATCH 09/14] drm: exynos: hdmi: add support for platform variants for mixer

2012-10-02 Thread Joonyoung Shim
On 09/28/2012 11:25 PM, Rahul Sharma wrote: This patch adds the support for multiple mixer versions avaialble in various platform variants. Version is passed as a driver data field instead of paltform data. Signed-off-by: Rahul Sharma --- drivers/gpu/drm/exynos/exynos_mixer.c | 28 +

Re: [PATCH 00/14] drm: exynos: hdmi: add dt based support for exynos5 hdmi

2012-10-02 Thread Joonyoung Shim
Hi, On 09/28/2012 11:25 PM, Rahul Sharma wrote: This patch set adds the DT based support for Samsung's Exynos5250 in DRM-HDMI. It includes disabling of hdmi internal interrupt, suppport for platform variants for hdmi and mixer, support to disable video processor based on platform type and remova

Re: [PATCH 01/11] drm: add plane support

2011-10-25 Thread Joonyoung Shim
10/25/2011 06:46 PM, Jesse Barnes 쓴 글: Planes are a bit like half-CRTCs. They have a location and fb, but don't drive outputs directly. Add support for handling them to the core KMS code. Signed-off-by: Jesse Barnes --- drivers/gpu/drm/drm_crtc.c | 236 ++

Re: DRM planes and new fb creation ioctl

2011-10-25 Thread Joonyoung Shim
Hi, Jesse. Thanks for posting. 10/25/2011 06:46 PM, Jesse Barnes 쓴 글: I've given up waiting for someone to implement support for these ioctls on another platform before they're merged, but I have received a lot of feedback on the interfaces, and it sounds like they're ok. I've also fixed all t

Re: [PATCH 01/11] drm: add plane support

2011-10-25 Thread Joonyoung Shim
10/25/2011 08:18 PM, Jesse Barnes 쓴 글: On Tue, 25 Oct 2011 19:53:02 +0900 Joonyoung Shim wrote: +/** + * drm_plane - central DRM plane control structure + * @dev: DRM device this plane belongs to + * @kdev: kernel device + * @attr: kdev attributes + * @head: for list management + * @base: base

Re: DRM planes and new fb creation ioctl

2011-10-25 Thread Joonyoung Shim
10/25/2011 08:13 PM, Jesse Barnes 쓴 글: On Tue, 25 Oct 2011 19:47:13 +0900 Joonyoung Shim wrote: 10/25/2011 06:46 PM, Jesse Barnes 쓴 글: I've given up waiting for someone to implement support for these ioctls on another platform before they're merged, but I have received a lot of f

Re: [PATCH 01/11] drm: add plane support

2011-10-25 Thread Joonyoung Shim
10/25/2011 06:46 PM, Jesse Barnes 쓴 글: [snip] diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h index 8020798..d7f03aa 100644 --- a/include/drm/drm_crtc.h +++ b/include/drm/drm_crtc.h @@ -44,6 +44,7 @@ struct drm_framebuffer; #define DRM_MODE_OBJECT_PROPERTY 0xb0b0b0b0 #define DRM

Re: [PATCH 1/5] drm: add plane support

2011-11-03 Thread Joonyoung Shim
11/03/2011 05:03 AM, Jesse Barnes 쓴 글: Planes are a bit like half-CRTCs. They have a location and fb, but don't drive outputs directly. Add support for handling them to the core KMS code. Signed-off-by: Jesse Barnes --- drivers/gpu/drm/drm_crtc.c | 236 ++

Re: [PATCH 2/5] drm: add an fb creation ioctl that takes a pixel format

2011-11-04 Thread Joonyoung Shim
11/03/2011 05:03 AM, Jesse Barnes 쓴 글: To properly support the various plane formats supported by different hardware, the kernel must know the pixel format of a framebuffer object. So add a new ioctl taking a format argument corresponding to a fourcc name from videodev2.h. Signed-off-by: Jesse B

Re: [PATCH 1/5] drm: add plane support

2011-11-09 Thread Joonyoung Shim
er > Signed-off-by: Jesse Barnes Reviewed-by: Joonyoung Shim Thanks. > --- > drivers/gpu/drm/drm_crtc.c | 257 +++- > drivers/gpu/drm/drm_drv.c |3 + > include/drm/drm.h |3 + > include/drm/drm_crtc.h |

[PATCH] drm: Fix missed parenthesis

2011-11-18 Thread Joonyoung Shim
This adds a missed parenthesis in drm_mode.h header file. Signed-off-by: Joonyoung Shim --- include/drm/drm_mode.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/include/drm/drm_mode.h b/include/drm/drm_mode.h index 094da8a..27d7faf 100644 --- a/include/drm/drm_mode.h

[PATCH] drm: Change order to turn off the crtc and plane with fb cleanup

2011-12-09 Thread Joonyoung Shim
Ths plane is enabled after the crtc is setted first, so first turn off the plane than the crtc. If not, it can occur some side effects because it may have to use any information of crtc when turns off the plane. Signed-off-by: Joonyoung Shim Signed-off-by: Kyungmin Park --- drivers/gpu/drm

Re: [PATCH 5/5] drm/exynos: Add plane support with fimd

2011-12-12 Thread Joonyoung Shim
On 12/13/2011 07:48 AM, Rob Clark wrote: On Fri, Dec 9, 2011 at 4:59 AM, Inki Dae wrote: +static int +exynos_update_plane(struct drm_plane *plane, struct drm_crtc *crtc, +struct drm_framebuffer *fb, int crtc_x, int crtc_y, +unsigned int crtc_w, unsigned i

Re: [PATCH 5/5] drm/exynos: Add plane support with fimd

2011-12-12 Thread Joonyoung Shim
On 12/13/2011 06:59 AM, Rob Clark wrote: On Fri, Dec 9, 2011 at 4:59 AM, Inki Dae wrote: From: Joonyoung Shim The exynos fimd supports 5 window overlays. Only one window overlay of fimd is used by the crtc, so we need plane feature to use the rest window overlays. This creates one ioctl

[PATCH] libdrm: fix sizes of memcpy to the drmModeAddFB2()

2011-12-13 Thread Joonyoung Shim
The variables(bo_handles, pitches and offsets) are the array having 4 elementary of uint32_t type. The their memcpy size is sizeof(uint32_t) * 4. Signed-off-by: Joonyoung Shim --- xf86drmMode.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/xf86drmMode.c b

[PATCH v2 5/5] drm/exynos: Add plane support with fimd

2011-12-14 Thread Joonyoung Shim
-off-by: Joonyoung Shim Signed-off-by: Inki Dae Signed-off-by: Kyungmin Park --- v2: consider fixed point about src_x/src_y drivers/gpu/drm/exynos/Makefile |3 +- drivers/gpu/drm/exynos/exynos_drm_crtc.c|1 + drivers/gpu/drm/exynos/exynos_drm_drv.c |9 ++ drivers

Re: [PATCH v2 5/5] drm/exynos: Add plane support with fimd

2011-12-14 Thread Joonyoung Shim
On 12/15/2011 02:26 AM, Jesse Barnes wrote: On Wed, 14 Dec 2011 19:00:15 +0900 Joonyoung Shim wrote: The exynos fimd supports 5 window overlays. Only one window overlay of fimd is used by the crtc, so we need plane feature to use the rest window overlays. This creates one ioctl exynos

[PATCH v3 5/5] drm/exynos: Add plane support with fimd

2011-12-14 Thread Joonyoung Shim
-off-by: Joonyoung Shim Signed-off-by: Inki Dae Signed-off-by: Kyungmin Park --- v2: consider fixed point about src_x/src_y v3: check to be validating the zpos ioctl parameter drivers/gpu/drm/exynos/Makefile |3 +- drivers/gpu/drm/exynos/exynos_drm_crtc.c|1 + drivers

Re: [PATCH] drm: exynos: Fix fb_videomode <-> drm_mode_modeinfo conversion

2012-03-08 Thread Joonyoung Shim
correct ? Good catch. You can refer Documentation/fb/framebuffer.txt to know in detail. Acked-by: Joonyoung Shim Thanks. diff --git a/drivers/gpu/drm/exynos/exynos_drm_connector.c b/drivers/gpu/drm/exynos/exynos_drm_connector.c index d620b07..7bb1dca 100644 --- a/drivers/gpu/drm/exy

[PATCH 2/2] drm/exynos: cleanup exynos_hdmi.h

2012-03-15 Thread Joonyoung Shim
The some contents of the exynos_hdmi.h are used only in exynos_hdmi.c, so move them to exynos_hdmi.c. Signed-off-by: Joonyoung Shim Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_hdmi.c | 36 drivers/gpu/drm/exynos/exynos_hdmi.h | 42

[PATCH 1/2] drm/exynos: remove exynos_mixer.h

2012-03-15 Thread Joonyoung Shim
The contents of exynos_mixer.h are used only in exynos_mixer.c, so separated header is unnecessary. Signed-off-by: Joonyoung Shim Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_mixer.c | 49 +- drivers/gpu/drm/exynos/exynos_mixer.h | 92

Re: [PATCH 1/2] drm/exynos: remove exynos_mixer.h

2012-03-15 Thread Joonyoung Shim
On 03/15/2012 05:19 PM, Joonyoung Shim wrote: The contents of exynos_mixer.h are used only in exynos_mixer.c, so separated header is unnecessary. Signed-off-by: Joonyoung Shim Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_mixer.c | 49 +- drivers/gpu/drm

Re: [RESEND][PATCH 01/10] drm/exynos: add HDMI version 1.4 support

2012-03-15 Thread Joonyoung Shim
On 03/15/2012 07:52 PM, Dave Airlie wrote: index 1ed3aae..aff2313 100644 --- a/include/drm/exynos_drm.h +++ b/include/drm/exynos_drm.h @@ -147,11 +147,13 @@ struct exynos_drm_common_hdmi_pd { * @timing: default video mode for initializing * @default_win: default window layer number to be used

Re: [PATCH 09/10] drm/exynos: add G2D driver

2012-03-15 Thread Joonyoung Shim
On 03/15/2012 07:50 PM, Dave Airlie wrote: G2D is a 2D graphic accelerator that supports Bit Block Transfer. This G2D driver is exynos drm specific and supports only exynos4x12 series. user application fills command set in cmdlist and once dma start request these cmdlists are parsed and performed

Re: [PATCH 09/10] drm/exynos: add G2D driver

2012-03-15 Thread Joonyoung Shim
esktop.org/mailman/listinfo/dri-devel >From 845c0a1bbf67b342099c5eae6f573063af8fc023 Mon Sep 17 00:00:00 2001 From: Joonyoung Shim Date: Fri, 16 Mar 2012 15:13:45 +0900 Subject: [PATCH] Add simple g2dtest This can test only solid color fill. Signed-off-by: Joonyoung Shim --- configure.ac

Re: [PATCH v2 09/14] drm/exynos: add G2D driver

2012-03-19 Thread Joonyoung Shim
On 03/19/2012 09:25 PM, Dave Airlie wrote: On Fri, Mar 16, 2012 at 9:47 AM, Inki Dae wrote: From: Joonyoung Shim The G2D is a 2D graphic accelerator that supports Bit Block Transfer. This G2D driver is exynos drm specific and supports only G2D(version 4.1) of later Exynos series from

[PATCH 0/4] code cleanup patchset of drm/exynos

2012-04-05 Thread Joonyoung Shim
branch. Thanks. Joonyoung Shim (4): drm/exynos: remove unnecessary type conversion of hdmi and mixer drm/exynos: remove unused codes in hdmi and mixer driver drm/exynos: fix struct for operation callback functions to driver name drm/exynos: fix to pointer manager member of

[PATCH 1/4] drm/exynos: remove unnecessary type conversion of hdmi and mixer

2012-04-05 Thread Joonyoung Shim
When the void pointer type variable is assigned to the specific pointer type variable, don't need to do type conversion. Signed-off-by: Joonyoung Shim Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_hdmi.c | 22 +++--- drivers/gpu/drm/exynos/exynos_mi

[PATCH 2/4] drm/exynos: remove unused codes in hdmi and mixer driver

2012-04-05 Thread Joonyoung Shim
Some defines and members in struct mixer_context aren't used, remove them. Signed-off-by: Joonyoung Shim Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_hdmi.c |1 - drivers/gpu/drm/exynos/exynos_mixer.c | 21 + 2 files changed, 9 insertions(+

[PATCH 3/4] drm/exynos: fix struct for operation callback functions to driver name

2012-04-05 Thread Joonyoung Shim
functions at the same time. Use their struct names to driver name. Signed-off-by: Joonyoung Shim Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_hdmi.c | 92 +- drivers/gpu/drm/exynos/exynos_drm_hdmi.h | 23 +++- drivers/gpu/drm/exynos/exynos_hdmi.c

[PATCH 4/4] drm/exynos: fix to pointer manager member of struct exynos_drm_subdrv

2012-04-05 Thread Joonyoung Shim
The struct exynos_drm_manager has to exist for exynos drm sub driver using encoder and connector. If it isn't NULL to member of struct exynos_drm_subdrv, will create encoder and connector else will not. And the is_local member also doesn't need. Signed-off-by: Joonyoung Shim Sig

Re: [PATCH 2/4] drm/exynos: remove unused codes in hdmi and mixer driver

2012-04-05 Thread Joonyoung Shim
On 04/05/2012 07:38 PM, Semwal, Sumit wrote: Hi Joonyoung, On Thu, Apr 5, 2012 at 3:53 PM, Joonyoung Shim wrote: Some defines and members in struct mixer_context aren't used, remove them. Signed-off-by: Joonyoung Shim Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_h

Re: [PATCH 2/4] drm/exynos: remove unused codes in hdmi and mixer driver

2012-04-05 Thread Joonyoung Shim
On 04/05/2012 08:00 PM, Daniel Vetter wrote: On Thu, Apr 05, 2012 at 07:53:43PM +0900, Joonyoung Shim wrote: On 04/05/2012 07:38 PM, Semwal, Sumit wrote: Hi Joonyoung, On Thu, Apr 5, 2012 at 3:53 PM, Joonyoung Shim wrote: Some defines and members in struct mixer_context aren't used, r

[PATCH v2 0/6] code cleanup patchset of drm/exynos

2012-04-05 Thread Joonyoung Shim
-fixes branch. Thanks. v2: Split "[PATCH 2/4] drm/exynos: remove unused codes in hdmi and mixer driver" patch of patchset v1. Joonyoung Shim (6): drm/exynos: remove unnecessary type conversion of hdmi and mixer drm/exynos: remove unused codes in hdmi and mixer drm/exyn

[PATCH 1/6] drm/exynos: remove unnecessary type conversion of hdmi and mixer

2012-04-05 Thread Joonyoung Shim
When the void pointer type variable is assigned to the specific pointer type variable, don't need to do type conversion. Signed-off-by: Joonyoung Shim Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_hdmi.c | 22 +++--- drivers/gpu/drm/exynos/exynos_mi

[PATCH 2/6] drm/exynos: remove unused codes in hdmi and mixer

2012-04-05 Thread Joonyoung Shim
Some members in struct mixer_context aren't used and the define HDMI_OVERLAY_NUMBER is unused in hdmi driver, remove them. Signed-off-by: Joonyoung Shim Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_hdmi.c |1 - drivers/gpu/drm/exynos/exynos_mixer.c |3 --- 2

[PATCH 3/6] drm/exynos: rename s/HDMI_OVERLAY_NUMBER/MIXER_WIN_NR

2012-04-05 Thread Joonyoung Shim
HDMI_OVERLAY_NUMBER is specific of mixer driver and be used "windows layer" term in exynos user manaual, so rename it. Signed-off-by: Joonyoung Shim --- drivers/gpu/drm/exynos/exynos_mixer.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/

[PATCH 4/6] drm/exynos: use define instead of default_win member in struct mixer_context

2012-04-05 Thread Joonyoung Shim
The default_win member in struct mixer_context isn't change its value after initialized to 0, so it's better using to define. Signed-off-by: Joonyoung Shim --- drivers/gpu/drm/exynos/exynos_mixer.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drive

[PATCH 5/6] drm/exynos: fix struct for operation callback functions to driver name

2012-04-05 Thread Joonyoung Shim
functions at the same time. Use their struct names to driver name. Signed-off-by: Joonyoung Shim Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_hdmi.c | 92 +- drivers/gpu/drm/exynos/exynos_drm_hdmi.h | 23 +++- drivers/gpu/drm/exynos/exynos_hdmi.c

[PATCH 6/6] drm/exynos: fix to pointer manager member of struct exynos_drm_subdrv

2012-04-05 Thread Joonyoung Shim
The struct exynos_drm_manager has to exist for exynos drm sub driver using encoder and connector. If it isn't NULL to member of struct exynos_drm_subdrv, will create encoder and connector else will not. And the is_local member also doesn't need. Signed-off-by: Joonyoung Shim Sig

[RFC PATCH] drm: Add plane event

2012-04-17 Thread Joonyoung Shim
g the framebuffer of plane via event. If DRM_MODE_PLANE_EVENT is added, we can also do pageflip of a plane. Signed-off-by: Joonyoung Shim Signed-off-by: Kyungmin Park --- drivers/gpu/drm/drm_crtc.c | 45 --- include/drm/drm.h |1 + include/drm/drm_c

[PATCH] drm: fix page_flip error handling

2012-04-17 Thread Joonyoung Shim
Free event and restore event_space only when page_flip->flags has DRM_MODE_PAGE_FLIP_EVENT if page_flip() is failed. Signed-off-by: Joonyoung Shim Signed-off-by: Kyungmin Park --- drivers/gpu/drm/drm_crtc.c | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --gi

Re: [RFC PATCH] drm: Add plane event

2012-04-18 Thread Joonyoung Shim
On 04/18/2012 05:46 PM, Daniel Vetter wrote: On Wed, Apr 18, 2012 at 01:31:59PM +0900, Joonyoung Shim wrote: DRM_MODE_PLANE_EVENT is similar to DRM_MODE_PAGE_FLIP_EVENT but it is for a plane. The setplane ioctl (DRM_IOCTL_MODE_SETPLANE) needs to provide the event such as

[PATCH 5/5] drm/exynos: add PM functions for hdmi and mixer

2012-04-23 Thread Joonyoung Shim
This patch supports the PM for hdmi and mixer. Turn off hdmi and mixer when suspended, and when resume, will turn on them by hdmi hotplug detection if hdmi is attached. Signed-off-by: Joonyoung Shim Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_hdmi.c | 32

[PATCH 0/5] Update dpms and PM for hdmi of exynos drm

2012-04-23 Thread Joonyoung Shim
This patchset is to support dpms and PM for hdmi of exynos drm. The exynos hdmi has internal and externel interrupt handler for hotplug detection. We can select whether use which interrupt handler by power state of hdmi. The base of this patchset is Linux 3.4-rc4. Joonyoung Shim (5): drm

[PATCH 1/5] drm/exynos: cleanup for hdmi platform data

2012-04-23 Thread Joonyoung Shim
The exynos_drm_hdmi_pdata struct have owned unnessary members. Remove them and add a function pointer to configure hdmi hotplug detection pin. Signed-off-by: Joonyoung Shim Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_hdmi.c | 13 ++--- include/drm/exynos_drm.h

[PATCH 2/5] drm/exynos: use platform_get_irq_byname for hdmi

2012-04-23 Thread Joonyoung Shim
The exynos hdmi supports two hdmi interrupts - external and internal, so use platform_get_irq_byname to distinguish their resources. Signed-off-by: Joonyoung Shim Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_hdmi.c | 11 +-- 1 files changed, 5 insertions(+), 6

[PATCH 3/5] drm/exynos: use threaded irq for hdmi hotplug

2012-04-23 Thread Joonyoung Shim
We can use irq thread instead of workqueue Signed-off-by: Joonyoung Shim Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_hdmi.c | 40 - 1 files changed, 5 insertions(+), 35 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b

[PATCH 4/5] drm/exynos: add dpms for hdmi

2012-04-23 Thread Joonyoung Shim
: Joonyoung Shim Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_hdmi.c | 77 + drivers/gpu/drm/exynos/exynos_drm_hdmi.h |6 +- drivers/gpu/drm/exynos/exynos_hdmi.c | 276 +++- drivers/gpu/drm/exynos/exynos_mixer.c| 288

[PATCH v2] drm/exynos: add G2D driver

2012-04-26 Thread Joonyoung Shim
DRM_EXYNOS_G2D_EVENT: event to give notification completion of the command list to user Signed-off-by: Joonyoung Shim Signed-off-by: Inki Dae Signed-off-by: Kyungmin Park --- The validation check codes are added to this patch v2 to prevent security problem from patch v1.

Re: [PATCH libdrm 8/8] proptest: support plane properties

2012-06-06 Thread Joonyoung Shim
Hi, Rob. On 06/06/2012 03:06 AM, Rob Clark wrote: From: Rob Clark Add support to display plane properties. Do you not support to set property for plane? Signed-off-by: Rob Clark --- tests/proptest/proptest.c | 32 1 file changed, 32 insertions(+) diff

Re: [PATCH libdrm 3/8] tests: add proptest

2012-06-06 Thread Joonyoung Shim
Hi, Rob and Paulo. On 06/06/2012 03:06 AM, Rob Clark wrote: From: Paulo Zanoni A small program that allows us to see and modify properties. Reviewed-by: Rob Clark Signed-off-by: Paulo Zanoni --- configure.ac |1 + tests/Makefile.am |2 +- tests/proptest/Makef

[PATCH 0/11] drm/exynos: update crtc and plane

2012-06-26 Thread Joonyoung Shim
This patchset is about update of crtc and plane. The interface of crtc and plane to control overlay is integrated internally. For this some code fixings are added. Also this supports the exynos specific property for crtc and plane. Joonyoung Shim (11): drm/exynos: fix point to call

[PATCH 05/11] drm/exynos: update overlay via plane from crtc

2012-06-27 Thread Joonyoung Shim
There is no any reason to update overlay at crtc directly because the crtc uses plane. Move its code to plane and call proper functions of plane from crtc. Signed-off-by: Joonyoung Shim Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_crtc.c| 146

[PATCH 07/11] drm/exynos: fix dpms operation for mode set

2012-06-27 Thread Joonyoung Shim
When we do mode set, the dpms mode should be ON. Don't control dpms in crtc commit function. Signed-off-by: Joonyoung Shim Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_crtc.c| 26 +++--- drivers/gpu/drm/exynos/exynos_drm_encoder.c |

[PATCH 01/11] drm/exynos: fix point to call overlay_ops->mode_set

2012-06-27 Thread Joonyoung Shim
Call overlay->mode_set from crtc->mode_set instead of encoder->mode_set, it makes codes clearly. Signed-off-by: Joonyoung Shim Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_crtc.c| 12 +++- drivers/gpu/drm/exynos/exynos_drm_encoder.c |9 +

[PATCH 09/11] drm/exynos: add plane enable/disable

2012-06-27 Thread Joonyoung Shim
The plane enable/disable can control only a power of plane, so they will be helpful to handle planes with dpms. Signed-off-by: Joonyoung Shim Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_crtc.c| 20 ++ drivers/gpu/drm/exynos/exynos_drm_drv.h |2

[PATCH 02/11] drm/exynos: fix to set pipe of crtc

2012-06-27 Thread Joonyoung Shim
It is enough to set pipe of crtc to manager only when do mode_set of crtc. Signed-off-by: Joonyoung Shim Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_crtc.c|8 +++--- drivers/gpu/drm/exynos/exynos_drm_encoder.c | 33 +++--- drivers/gpu/drm

[PATCH 11/11] drm/exynos: add property for crtc mode

2012-06-27 Thread Joonyoung Shim
d-off-by: Joonyoung Shim Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_crtc.c | 72 ++ drivers/gpu/drm/exynos/exynos_drm_drv.h |1 + 2 files changed, 73 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_crtc.c b/dr

[PATCH 03/11] drm/exynos: define to_exynos_plane macro

2012-06-27 Thread Joonyoung Shim
Add macro to get struct exynos_plane from struct drm_plane pointer. Signed-off-by: Joonyoung Shim Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_plane.c | 13 ++--- 1 files changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/exynos

[PATCH 04/11] drm/exynos: use private plane for crtc

2012-06-27 Thread Joonyoung Shim
The crtc can use private plane instead it has overlay struct. It will be helpful use plane feature from crtc later. Signed-off-by: Joonyoung Shim Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_crtc.c | 31 - drivers/gpu/drm/exynos

[PATCH 06/11] drm/exynos: add property for plane zpos

2012-06-27 Thread Joonyoung Shim
The exynos drm driver used a specific ioctl - DRM_EXYNOS_PLANE_SET_ZPOS to set zpos of plane. It can be substitute to property of plane. This patch adds a property for plane zpos and removes DRM_EXYNOS_PLANE_SET_ZPOS ioctl. Signed-off-by: Joonyoung Shim Signed-off-by: Kyungmin Park --- drivers

[PATCH 08/11] drm/exynos: remove unnecessary connector dpms control

2012-06-27 Thread Joonyoung Shim
The connector dpms should be controlled only by DPMS property and mode set. Signed-off-by: Joonyoung Shim Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_encoder.c | 11 --- 1 files changed, 0 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/exynos

[PATCH 10/11] drm/exynos: add crtc disable function

2012-06-27 Thread Joonyoung Shim
The crtc disable is used to turn off private plane for crtc. Signed-off-by: Joonyoung Shim Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_crtc.c | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_crtc.c b

Re: [PATCH 2/2] drm/exynos: Modifying exynos drm fimd to support exynos5

2012-07-19 Thread Joonyoung Shim
Hi, Some minor commants. On 07/06/2012 09:28 PM, Leela Krishna Amudala wrote: From: Prathyush K The name of the exynos drm fimd device is renamed to exynos-drm-fimd and two ids are created for exynos4-fb and exynos5-fb. Please write the subject clearly this patch is to do what. How about "a

Re: [PATCH V2 0/2] video: drm: Add Device tree support to DRM-FIMD

2012-07-20 Thread Joonyoung Shim
Hi, On 07/11/2012 05:44 PM, Leela Krishna Amudala wrote: This patch set adds device tree support for DRM-FIMD for Samsung's Exynos5250. It includes parsing platform data from dts file. This patchset is based and tested on top of v3.5-rc6 Changes since V1: - Corrected typo errors and ch

Re: [PATCH 2/2] drm/exynos: Add device tree based discovery support for G2D

2013-02-05 Thread Joonyoung Shim
On 02/05/2013 12:03 PM, Inki Dae wrote: > 2013/2/4 Sachin Kamat : >> On 1 February 2013 18:28, Inki Dae wrote: >>> >>> >>> >>> 2013. 2. 1. 오후 8:52 Inki Dae 작성: >>> > -Original Message- > From: linux-media-ow...@vger.kernel.org [mailto:linux-media- > ow...@vger.kernel.org]

Re: [PATCH v3 1/3] drm/exynos: Get HDMI version from device tree

2013-02-05 Thread Joonyoung Shim
On 02/06/2013 09:56 AM, Sean Paul wrote: On Tue, Feb 5, 2013 at 4:42 PM, Stephen Warren wrote: On 02/05/2013 05:37 PM, Sean Paul wrote: On Tue, Feb 5, 2013 at 4:22 PM, Stephen Warren wrote: n 02/05/2013 04:42 PM, Sean Paul wrote: Use the compatible string in the device tree to determine whi

Re: [PATCH v6 1/1] video: drm: exynos: Add display-timing node parsing using video helper function

2013-02-20 Thread Joonyoung Shim
Hi, On 02/15/2013 03:43 PM, Vikas Sajjan wrote: Add support for parsing the display-timing node using video helper function. The DT node parsing and pinctrl selection is done only if 'dev.of_node' exists and the NON-DT logic is still maintained under the 'else' part. Signed-off-by: Leela Krish

Re: [PATCH v7 0/2] Add display-timing node parsing to exynos drm fimd

2013-02-20 Thread Joonyoung Shim
Hi, Please refer my comments about v6 patch. On 02/21/2013 02:11 PM, Vikas Sajjan wrote: Add display-timing node parsing to drm fimd and depends on the display helper patchset at http://lists.freedesktop.org/archives/dri-devel/2013-January/033998.html It also adds pinctrl support for drm fimd

Re: [PATCH v7 2/2] video: drm: exynos: Add pinctrl support to fimd

2013-02-20 Thread Joonyoung Shim
Hi, On 02/21/2013 02:11 PM, Vikas Sajjan wrote: Adds support for pinctrl to drm fimd. Signed-off-by: Leela Krishna Amudala Signed-off-by: Vikas Sajjan --- drivers/gpu/drm/exynos/exynos_drm_fimd.c |9 + 1 file changed, 9 insertions(+) diff --git a/drivers/gpu/drm/exynos/exynos_

Re: [PATCH v6 1/1] video: drm: exynos: Add display-timing node parsing using video helper function

2013-02-20 Thread Joonyoung Shim
On 02/21/2013 04:12 PM, Vikas Sajjan wrote: Hi, On 21 February 2013 12:25, Joonyoung Shim wrote: Hi, On 02/15/2013 03:43 PM, Vikas Sajjan wrote: Add support for parsing the display-timing node using video helper function. The DT node parsing and pinctrl selection is done only if

Re: [PATCH v6 1/1] video: drm: exynos: Add display-timing node parsing using video helper function

2013-02-27 Thread Joonyoung Shim
Hi, On 02/21/2013 04:18 PM, Joonyoung Shim wrote: On 02/21/2013 04:12 PM, Vikas Sajjan wrote: Hi, On 21 February 2013 12:25, Joonyoung Shim wrote: Hi, On 02/15/2013 03:43 PM, Vikas Sajjan wrote: Add support for parsing the display-timing node using video helper function. The DT node

Re: [PATCH v8 1/2] video: drm: exynos: Add display-timing node parsing using video helper function

2013-02-27 Thread Joonyoung Shim
OF_USE_NATIVE_MODE); + if (ret) { + DRM_ERROR("failed: of_get_fb_videomode()\n" + "with return value: %d\n", ret); Could you make this error log to one line? except this, Acked-by: Joonyoung Shim +

Re: [PATCH] drm/exynos: modify the compatible string for exynos fimd

2013-02-27 Thread Joonyoung Shim
quot;samsung,exynos4-fimd", + { .compatible = "samsung,exynos4210-fimd", .data = &exynos4_fimd_driver_data }, - { .compatible = "samsung,exynos5-fimd", + { .compatible = "samsung,exynos5250-fimd", .data = &exynos5_fimd

Re: [PATCH v8 1/2] video: drm: exynos: Add display-timing node parsing using video helper function

2013-02-27 Thread Joonyoung Shim
On 02/28/2013 11:45 AM, Vikas Sajjan wrote: Hi, On 28 February 2013 08:07, Joonyoung Shim wrote: On 02/27/2013 08:49 PM, Vikas Sajjan wrote: Add support for parsing the display-timing node using video helper function. The DT node parsing and pinctrl selection is done only if 'dev.of

Re: [PATCH] drm/exynos: fimd: calculate the correct address offset

2013-03-05 Thread Joonyoung Shim
Hi Leela, On 03/05/2013 08:25 PM, Leela Krishna Amudala wrote: Calculate the correct address offset values for alpha and color key control registers Signed-off-by: Leela Krishna Amudala --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(

Re: [PATCH] drm/exynos: fimd: calculate the correct address offset

2013-03-05 Thread Joonyoung Shim
On 03/05/2013 09:04 PM, Leela Krishna Amudala wrote: Hi, On Tue, Mar 5, 2013 at 5:24 PM, Joonyoung Shim wrote: Hi Leela, On 03/05/2013 08:25 PM, Leela Krishna Amudala wrote: Calculate the correct address offset values for alpha and color key control registers Signed-off-by: Leela Krishna

Re: [PATCH V2] drm/exynos: fimd: calculate the correct address offset

2013-03-06 Thread Joonyoung Shim
On 03/06/2013 02:20 PM, Leela Krishna Amudala wrote: Calculate the correct address offset values for alpha and color key control registers and clear size control register for window 0 Signed-off-by: Leela Krishna Amudala --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 16 ++-- 1 f

Re: [PATCH V3] drm/exynos: fimd: calculate the correct address offset

2013-03-07 Thread Joonyoung Shim
offset = VIDOSD_C(win); val = win_data->ovl_width * win_data->ovl_height; writel(val, ctx->regs + offset); Acked-by: Joonyoung Shim Thanks. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://list

Re: [PATCH 3/7] drm/exynos: Fix G2D core mulfunctioning issue

2013-03-13 Thread Joonyoung Shim
On 03/13/2013 06:04 PM, Inki Dae wrote: From: YoungJun Cho This patch fixes G2D core mulfunctioning issue once g2d dma is started. Without 'DMA_HOLD_CMD_REG' register setting, there is only one interrupt after the execution to all command lists have been completed. And that induces watchdog. So

Re: [PATCH 4/7] drm/exynos: Clean up some G2D codes for readability

2013-03-13 Thread Joonyoung Shim
On 03/13/2013 06:04 PM, Inki Dae wrote: From: YoungJun Cho This patch just cleans up G2D codes for readability. For this, it changes the member of g2d_cmdlist_node, obj_type into buf_type and gathers relevant variables together. Please make patch only about s/obj_type/buf_type. Signed-off

Re: [PATCH 3/7] drm/exynos: Fix G2D core mulfunctioning issue

2013-03-13 Thread Joonyoung Shim
On 03/13/2013 07:14 PM, Inki Dae wrote: -Original Message- From: Joonyoung Shim [mailto:jy0922.s...@samsung.com] Sent: Wednesday, March 13, 2013 6:53 PM To: Inki Dae Cc: airl...@linux.ie; dri-devel@lists.freedesktop.org; kyungmin.p...@samsung.com; sw0312@samsung.com; YoungJun Cho

Re: [PATCH 3/7] drm/exynos: Fix G2D core mulfunctioning issue

2013-03-13 Thread Joonyoung Shim
On 03/13/2013 07:53 PM, Inki Dae wrote: -Original Message- From: Joonyoung Shim [mailto:jy0922.s...@samsung.com] Sent: Wednesday, March 13, 2013 7:28 PM To: Inki Dae Cc:airl...@linux.ie;dri-devel@lists.freedesktop.org; kyungmin.p...@samsung.com;sw0312@samsung.com; 'YoungJu

Re: [PATCH] drm/exynos: use drm_send_vblank_event() helper

2013-05-21 Thread Joonyoung Shim
Hi, On 05/22/2013 01:04 PM, Inki Dae wrote: From: Rob Clark Rebased. Signed-off-by: Rob Clark Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos_drm_crtc.c | 10 ++ 1 files changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_crtc.c b

Re: [PATCH 0/4] drm/exynos: fimd: Add support for S3C6400/S3C6410

2013-06-05 Thread Joonyoung Shim
, 68 insertions(+), 22 deletions(-) Any comments for this series? Best regards, Tomasz Ping. Best regards, Tomasz This series looks good to me. Acked-by: Joonyoung Shim ___ dri-devel mailing list dri-devel@lists.freedesktop.org http

Re: [PATCH] drm/exynos: fimd: Get signal polarities from device tree

2013-06-05 Thread Joonyoung Shim
On 05/19/2013 08:32 PM, Tomasz Figa wrote: Hi, On Wednesday 01 of May 2013 22:00:25 Daniel Vetter wrote: On Wed, May 01, 2013 at 09:06:09PM +0200, Tomasz Figa wrote: This patch modifies the driver to perform two stage parsing of video timings from device tree, to get timing information as stru

Re: [PATCH] drm/exynos: fimd: Get signal polarities from device tree

2013-06-06 Thread Joonyoung Shim
On 06/06/2013 06:47 PM, Tomasz Figa wrote: Hi Joonyoung, On Thursday 06 of June 2013 13:30:49 Joonyoung Shim wrote: On 05/19/2013 08:32 PM, Tomasz Figa wrote: Hi, On Wednesday 01 of May 2013 22:00:25 Daniel Vetter wrote: On Wed, May 01, 2013 at 09:06:09PM +0200, Tomasz Figa wrote: This

[PATCH 0/3] drm/cma: use prim helpers instead GEM CMA specific dma_buf functionality

2013-06-12 Thread Joonyoung Shim
me helpers. Thanks. Joonyoung Shim (3): drm: add mmap function to prime helpers drm/cma: add low-level hook functions to use prime helpers drm/cma: remove GEM CMA specific dma_buf functionality drivers/gpu/drm/drm_gem_cma_helper.c | 291 +-- drive

[PATCH 1/3] drm: add mmap function to prime helpers

2013-06-12 Thread Joonyoung Shim
This adds to call low-level mmap() from prime helpers. Signed-off-by: Joonyoung Shim --- drivers/gpu/drm/drm_prime.c | 5 - include/drm/drmP.h | 2 ++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_prime.c b/drivers/gpu/drm/drm_prime.c index

[PATCH 2/3] drm/cma: add low-level hook functions to use prime helpers

2013-06-12 Thread Joonyoung Shim
Instead of using the dma_buf functionality for GEM CMA, we can use prime helpers if we can provide low-level hook functions for GEM CMA. Signed-off-by: Joonyoung Shim --- drivers/gpu/drm/drm_gem_cma_helper.c | 76 include/drm/drm_gem_cma_helper.h | 9

<    1   2   3   4   5   6   >