On Sat, Mar 05, 2022 at 11:15:38PM +0900, Byungchul Park wrote:
> On Fri, Mar 04, 2022 at 10:26:23PM -0500, Theodore Ts'o wrote:
> > On Fri, Mar 04, 2022 at 09:42:37AM +0900, Byungchul Park wrote:
> > >
> > > All contexts waiting for any of the events in the circular dependency
> > > chain will be
On Sun, Apr 07, 2019 at 04:41:36PM -0400, Mathieu Desnoyers wrote:
>
> - On Apr 7, 2019, at 3:32 PM, Joel Fernandes, Google
> j...@joelfernandes.org wrote:
>
> > On Sun, Apr 07, 2019 at 03:26:16PM -0400, Mathieu Desnoyers wrote:
> >> - On Apr 7, 201
On Sun, Apr 07, 2019 at 06:59:37AM -0700, Paul E. McKenney wrote:
> On Sun, Apr 07, 2019 at 06:39:41AM -0700, Paul E. McKenney wrote:
> > On Sat, Apr 06, 2019 at 07:06:13PM -0400, Joel Fernandes wrote:
>
> [ . . . ]
>
> > > > diff --git a/include/asm-generic/vmlinu
On Fri, Apr 05, 2019 at 04:28:35PM -0700, Paul E. McKenney wrote:
> On Wed, Apr 03, 2019 at 09:20:39AM -0700, Paul E. McKenney wrote:
> > On Wed, Apr 03, 2019 at 10:27:42AM -0400, Mathieu Desnoyers wrote:
> > > - On Apr 3, 2019, at 9:32 AM, paulmck paul...@linux.ibm.com wrote:
> > >
> > > > On
On Sun, Apr 07, 2019 at 03:26:16PM -0400, Mathieu Desnoyers wrote:
> - On Apr 7, 2019, at 9:59 AM, paulmck paul...@linux.ibm.com wrote:
>
> > On Sun, Apr 07, 2019 at 06:39:41AM -0700, Paul E. McKenney wrote:
> >> On Sat, Apr 06, 2019 at 07:06:13PM -0400,
On Sun, Apr 07, 2019 at 10:05:14AM -0700, Paul E. McKenney wrote:
> On Sun, Apr 07, 2019 at 03:46:13PM +0000, Joel Fernandes wrote:
> > On Sun, Apr 07, 2019 at 06:59:37AM -0700, Paul E. McKenney wrote:
> > > On Sun, Apr 07, 2019 at 06:39:41AM -0700, Paul E. McKenney wrote:
>
t function. However, this is more than a bit user unfriendly.
>
> This commit therefore creates an ___srcu_struct_ptrs linker section,
> and pointers to srcu_struct structures created by DEFINE_SRCU() and
> DEFINE_STATIC_SRCU() within a module are placed into that module'
.@linux.ibm.com wrote:
> >>
> >> > On Mon, Apr 08, 2019 at 09:05:34AM -0400, Mathieu Desnoyers wrote:
> >> >> - On Apr 7, 2019, at 10:27 PM, paulmck paul...@linux.ibm.com wrote:
> >> >>
> >> >> > On Sun, Apr 07, 2019 at 09:07:18PM
On Tue, Apr 09, 2019 at 11:56:03AM -0400, Mathieu Desnoyers wrote:
> - On Apr 9, 2019, at 11:40 AM, Joel Fernandes, Google
> j...@joelfernandes.org wrote:
>
> > On Mon, Apr 08, 2019 at 01:24:47PM -0400, Mathieu Desnoyers wrote:
> >> - On Apr 8, 2019, a
Hi Sandeep,
On Sun, Mar 24, 2019 at 10:56:33AM -0700, Sandeep Patil wrote:
> On Fri, Mar 22, 2019 at 11:02:55AM -0400, Joel Fernandes wrote:
> > On Thu, Mar 21, 2019 at 07:51:33PM -0700, Chenbo Feng wrote:
> > > From: Greg Hackmann
> > >
> > > By travers
On Thu, Mar 21, 2019 at 07:51:33PM -0700, Chenbo Feng wrote:
> From: Greg Hackmann
>
> By traversing /proc/*/fd and /proc/*/map_files, processes with CAP_ADMIN
> can get a lot of fine-grained data about how shmem buffers are shared
> among processes. stat(2) on each entry gives the caller a uniq
On Thu, Mar 21, 2019 at 07:51:32PM -0700, Chenbo Feng wrote:
> Currently, all dma-bufs share the same anonymous inode. While we can count
> how many dma-buf fds or mappings a process has, we can't get the size of
> the backing buffers or tell if two entries point to the same dma-buf. And
> in debug
On Mon, Mar 25, 2019 at 12:34:59PM -0700, Chenbo Feng wrote:
[snip]
> > > > Also what is the benefit of having st_blocks from stat? AFAIK, that is
> > > > the
> > > > same as the buffer's size which does not change for the lifetime of the
> > > > buffer. In your patch you're doing this when 'struc
On Tue, Apr 02, 2019 at 08:23:34AM -0700, Paul E. McKenney wrote:
> On Tue, Apr 02, 2019 at 11:14:40AM -0400, Mathieu Desnoyers wrote:
> > - On Apr 2, 2019, at 10:28 AM, paulmck paul...@linux.ibm.com wrote:
> >
> > > Hello!
> > >
> > > This series prohibits use of DEFINE_SRCU() and DEFINE_STA
On Wed, Apr 03, 2019 at 09:20:39AM -0700, Paul E. McKenney wrote:
> On Wed, Apr 03, 2019 at 10:27:42AM -0400, Mathieu Desnoyers wrote:
> > - On Apr 3, 2019, at 9:32 AM, paulmck paul...@linux.ibm.com wrote:
> >
> > > On Tue, Apr 02, 2019 at 11:34:07AM -0400, Mathieu Desnoyers wrote:
> > >>
On Wed, Jul 24, 2019 at 4:24 PM John Stultz wrote:
>
> On Wed, Jul 24, 2019 at 1:18 PM John Stultz wrote:
> >
> > On Wed, Jul 24, 2019 at 12:36 PM Laura Abbott wrote:
> > >
> > > On 7/17/19 12:31 PM, Alexander Popov wrote:
> > > > Hello!
> > > >
> > > > The syzkaller [1] has a trouble with fuzzi
> On Nov 11, 2022, at 2:50 PM, Joel Fernandes (Google)
> wrote:
>
> During kexec on ARM device, we notice that device_shutdown() only calls
> pm_runtime_force_suspend() while shutting down the GPU. This means the GPU
> kthread is still running and further, there ma
> On Nov 11, 2022, at 4:28 PM, Akhil P Oommen wrote:
>
> On 11/12/2022 1:19 AM, Joel Fernandes (Google) wrote:
>> Even though the GPU is shut down, during kexec reboot we can have userspace
>> still running. This is especially true if KEXEC_JUMP is not enabled, bec
On Fri, Nov 11, 2022 at 4:37 PM Joel Fernandes
wrote:
>
>
> > On Nov 11, 2022, at 4:28 PM, Akhil P Oommen
> wrote:
> >
> > On 11/12/2022 1:19 AM, Joel Fernandes (Google) wrote:
> >> Even though the GPU is shut down, during kexec reboot we can have
>
On Sat, Nov 12, 2022 at 6:35 PM Rob Clark wrote:
>
> On Fri, Nov 11, 2022 at 1:28 PM Akhil P Oommen
> wrote:
> >
> > On 11/12/2022 1:19 AM, Joel Fernandes (Google) wrote:
> > > Even though the GPU is shut down, during kexec reboot we can have
> > >
On Thu, Dec 1, 2022 at 7:33 PM Rob Clark wrote:
>
> On Thu, Dec 1, 2022 at 10:42 AM Joel Fernandes wrote:
> >
> > On Sat, Nov 12, 2022 at 6:35 PM Rob Clark wrote:
> > >
> > > On Fri, Nov 11, 2022 at 1:28 PM Akhil P Oommen
> > > wrote:
> >
On Sat, Nov 12, 2022 at 6:44 PM Rob Clark wrote:
>
> On Fri, Nov 11, 2022 at 1:08 PM Joel Fernandes wrote:
> >
> >
> >
> > > On Nov 11, 2022, at 2:50 PM, Joel Fernandes (Google)
> > > wrote:
> > >
> > > During kexe
On Thu, Dec 1, 2022 at 10:06 PM Rob Clark wrote:
>
> On Thu, Dec 1, 2022 at 12:08 PM Joel Fernandes wrote:
> >
> > On Sat, Nov 12, 2022 at 6:44 PM Rob Clark wrote:
> > >
> > > On Fri, Nov 11, 2022 at 1:08 PM Joel Fernandes
> > > wrote:
> >
On Mon, Aug 7, 2023 at 7:17 AM Qi Zheng wrote:
>
> Use new APIs to dynamically allocate the rcu-kfree shrinker.
>
> Signed-off-by: Qi Zheng
For RCU:
Reviewed-by: Joel Fernandes (Google)
thanks,
- Joel
> ---
> kernel/rcu/tree.c | 22 +-
> 1 file c
On Mon, Aug 7, 2023 at 7:36 AM Qi Zheng wrote:
>
> Use new APIs to dynamically allocate the rcu-lazy shrinker.
>
> Signed-off-by: Qi Zheng
For RCU:
Reviewed-by: Joel Fernandes (Google)
thanks,
- Joel
> ---
> kernel/rcu/tree_nocb.h | 20 +++-
> 1 file c
w a690_gmu.bin
> > >- Update commit subject and message accordingly
> > > ---
> > > drivers/gpu/drm/msm/adreno/adreno_device.c | 11 +++
> > > 1 file changed, 11 insertions(+)
> >
> > Reviewed-by: Dmitry Baryshkov
> >
>
Reviewed-by: Joel Fernandes (Google)
thanks,
- Joel
27;s not used, and is only causing problems
> > > > for everyone involved.
> > > >
> > > > Cc: "Arve Hjønnevåg"
> > > > Cc: "Christian König"
> > > > Cc: Christian Brauner
> > > > Cc: Chris
On Mon, Aug 3, 2020 at 10:47 AM 'Kalesh Singh' via kernel-team
wrote:
>
> Provides a per process hook for the acquisition of file descriptors,
> despite the method used to obtain the descriptor.
>
Hi,
So apart from all of the comments received, I think it is hard to
understand what the problem is
On Mon, Feb 3, 2025 at 4:00 PM John Hubbard wrote:
[..]
>
> >> +()
> >> +)]
> >> +);
> >> +
> >> +impl pci::Driver for NovaCore {
> >> +type IdInfo = ();
> >> +const ID_TABLE: pci::IdTable = &PCI_TABLE;
> >> +
> >> +fn probe(pdev: &mut pci::Device, _info: &Self::IdInfo) ->
Hi Danilo,
On Fri, Jan 31, 2025 at 11:04:24PM +0100, Danilo Krummrich wrote:
> Add the initial nova-core driver stub.
>
> nova-core is intended to serve as a common base for nova-drm (the
> corresponding DRM driver) and the vGPU manager VFIO driver, serving as a
> hard- and firmware abstraction l
On Tue, Feb 4, 2025 at 1:46 PM Danilo Krummrich wrote:
>
> On Mon, Feb 03, 2025 at 03:24:10PM -0500, Joel Fernandes wrote:
> > Hi Danilo,
> >
> > On Fri, Jan 31, 2025 at 11:04:24PM +0100, Danilo Krummrich wrote:
> > > +#[pin_data]
> > > +pub
On Wed, Dec 4, 2024 at 11:27 AM Jann Horn wrote:
>
> The current check_memfd_seals() is racy: Since we first do
> check_memfd_seals() and then udmabuf_pin_folios() without holding any
> relevant lock across both, F_SEAL_WRITE can be set in between.
> This is problematic because we can end up holdi
("mm/memfd: add an F_SEAL_FUTURE_WRITE seal to memfd")
> Cc: sta...@vger.kernel.org
> Acked-by: Vivek Kasireddy
Thanks!
Reviewed-by: Joel Fernandes (Google)
- Joel
> Signed-off-by: Jann Horn
> ---
> drivers/dma-buf/udmabuf.c | 2 +-
> 1 file changed, 1 insertion(
On Tue, Dec 10, 2024 at 6:12 PM Jann Horn wrote:
>
> On Tue, Dec 10, 2024 at 11:51 PM Joel Fernandes
> wrote:
> > On Wed, Dec 4, 2024 at 11:27 AM Jann Horn wrote:
> > > The current check_memfd_seals() is racy: Since we first do
> > > check_memfd_seals() and
On 4/20/2025 8:19 AM, Alexandre Courbot wrote:
> We will commonly need to compare chipset versions, so derive the
> ordering traits to make that possible. Also derive Copy and Clone since
> passing Chipset by value will be more efficient than by reference.
>
> Signed-off-by: Alexandre Courbot
On 4/22/2025 9:06 AM, Alexandre Courbot wrote:
> On Tue Apr 22, 2025 at 8:28 PM JST, Danilo Krummrich wrote:
>> On Mon, Apr 21, 2025 at 05:45:33PM -0400, Joel Fernandes wrote:
>>> On 4/20/2025 8:19 AM, Alexandre Courbot wrote:
>>>> diff --git a/drivers/gpu/nova-core/
On 4/20/2025 8:19 AM, Alexandre Courbot wrote:
> A page of system memory is reserved so sysmembar can perform a read on
> it if a system write occurred since the last flush. Do this early as it
> can be required to e.g. reset the GPU falcons.
>
> Signed-off-by: Alexandre Courbot
> ---
> drive
sysmembar is a critical operation that the GSP falcon needs to perform
in the reset sequence. Add some code comments to clarify.
Signed-off-by: Joel Fernandes
---
drivers/gpu/nova-core/gpu.rs | 11 ++-
drivers/gpu/nova-core/regs.rs | 2 ++
2 files changed, 12 insertions(+), 1 deletion
Yes, sounds good to me. Thanks!
- Joel
>
> On Thu Apr 24, 2025 at 7:54 AM JST, Joel Fernandes wrote:
> > Signed-off-by: Joel Fernandes
> > ---
> > drivers/gpu/nova-core/firmware/fwsec.rs | 17 ++---
> > 1 file changed, 10 insertions(+), 7 deletions(-
On 4/24/2025 3:45 AM, Alexandre Courbot wrote:
> On Thu Apr 24, 2025 at 12:06 PM JST, Joel Fernandes wrote:
>> On April 24, 2025, 1:18 a.m. UTC
>> Alexandre Courbot wrote:
>>> Since this just renames fields, would you be ok if I squashed this one
>>> int
On 4/23/2025 10:06 AM, Danilo Krummrich wrote:
[...]
>> +
>> +/// Probe for VBIOS extraction
>> +/// Once the VBIOS object is built, bar0 is not read for vbios purposes
>> anymore.
>> +pub(crate) fn probe(bar0: &Devres) -> Result {
>
> Let's not call it probe(), what about VBios::p
On Wed, Apr 23, 2025 at 05:02:58PM +0200, Danilo Krummrich wrote:
[..]
> > >> +data.extend_with(len, 0, GFP_KERNEL)?;
> > >> +with_bar!(?bar0, |bar0_ref| {
> > >> +let dst = &mut data[current_len..current_len + len];
> > >> +for (idx, chunk) in dst
> > >> +
PM +0900, Alexandre Courbot wrote:
>> From: Joel Fernandes
>>
>> Add support for navigating and setting up vBIOS ucode data required for
[...]
>> diff --git a/drivers/gpu/nova-core/vbios.rs b/drivers/gpu/nova-core/vbios.rs
>> new file mode 100644
>> index
On 4/30/2025 9:25 AM, Alexandre Courbot wrote:
> Hi Danilo,
>
> On Tue Apr 22, 2025 at 11:44 PM JST, Danilo Krummrich wrote:
>> This patch could probably split up a bit, to make it more pleasant to
>> review. :)
>
> Probably yes. I thought since it is mostly new files, splitting up
> wouldn't
> On Apr 22, 2025, at 10:45 AM, Danilo Krummrich wrote:
> […]
>> +
>> +fn get_signature_reg_fuse_version(
>> +&self,
>> +bar: &Devres,
>> +engine_id_mask: u16,
>> +ucode_id: u8,
>> +) -> Result;
>> +
>> +// Program the BROM registers prior to starting
Hi Alex,
On 4/30/2025 8:09 PM, Alexandre Courbot wrote:
>>> I am just not seeing the benefits of not using dyn for
>>> this use case and only drawbacks. IMHO, we should try to not be doing the
>>> compiler's job.
>>>
>>> Maybe the only benefit is you don't need an Arc or Kbox wrapper?
>> That's no
On 4/29/2025 8:48 AM, Alexandre Courbot wrote:
> On Tue Apr 22, 2025 at 8:36 PM JST, Danilo Krummrich wrote:
>> On Sun, Apr 20, 2025 at 09:19:40PM +0900, Alexandre Courbot wrote:
>>> Upon reset, the GPU executes the GFW_BOOT firmware in order to
>>> initialize its base parameters such as clocks.
On 4/30/2025 2:16 PM, Danilo Krummrich wrote:
[...]
>>> It is also the one that makes use of methods to abstract things (vs.
>>> fixed parameters), so it is a natural candidate for using virtual
>>> methods. I am not a fan of having ever-growing boilerplate match
>>> statements for each method that
Hello, Alex,
On 5/2/2025 12:57 AM, Alexandre Courbot wrote:
> On Thu May 1, 2025 at 9:58 PM JST, Alexandre Courbot wrote:
>> From: Joel Fernandes
>>
>> This will be used in the nova-core driver where we need to upward-align
>> the image size to get to the
On 5/1/2025 11:31 AM, Timur Tabi wrote:
> On Thu, 2025-05-01 at 11:22 -0400, Joel Fernandes wrote:
>> Also not mutating it like that matches the pattern in the rest of this file
>> so
>> I'd leave it as-is.
>
> Oh I see now. One version changes a variable, and
On 5/1/2025 11:19 AM, Timur Tabi wrote:
> On Thu, 2025-05-01 at 21:58 +0900, Alexandre Courbot wrote:
>
>
>> +impl UsizeAlign for usize {
>> + fn align_up(mut self, align: usize) -> usize {
>> + self = (self + align - 1) & !(align - 1);
>> + self
>> + }
>> +}
>> +
>> +/// A
On 5/1/2025 10:18 AM, Alexandre Courbot wrote:
[..]
>> On Thu, May 01, 2025 at 09:58:33PM +0900, Alexandre Courbot wrote:
>>> Add the common Falcon code and HAL for Ampere GPUs, and instantiate the
>>> GSP and SEC2 Falcons that will be required to boot the GSP.
>>>
>>> Signed-off-by: Alexandre Cour
Hello Alex,
On Thu, May 01, 2025 at 09:58:33PM +0900, Alexandre Courbot wrote:
> Add the common Falcon code and HAL for Ampere GPUs, and instantiate the
> GSP and SEC2 Falcons that will be required to boot the GSP.
>
> Signed-off-by: Alexandre Courbot
> ---
> drivers/gpu/nova-core/falcon.rs
Hello, Alexandre,
On 5/3/2025 10:37 AM, Alexandre Courbot wrote:
> On Sat May 3, 2025 at 12:02 PM JST, Joel Fernandes wrote:
>>
>>
>> On 5/2/2025 9:59 PM, Alexandre Courbot wrote:
>>>> pub trait AlignUp {
>>>> fn align_up(self, alignment
On 5/5/2025 12:14 AM, Bagas Sanjaya wrote:
> On Sat, May 03, 2025 at 12:07:58AM -0400, Joel Fernandes wrote:
>> +Conceptual diagram (not exact) of the Falcon and its memory subsystem is as
>> follows:
>> +
>> + External Memory (Framebuffer / System DRAM)
On 5/5/2025 12:04 AM, Bagas Sanjaya wrote:
> On Sat, May 03, 2025 at 12:07:57AM -0400, Joel Fernandes wrote:
>> +.. SPDX-License-Identifier: GPL-2.0
>> +==
>> +Device Initialization (devinit)
>> +==
&
Add several code comments to reduce acronym soup and explain how devinit magic
and bootflow works before driver loads. These are essential for debug and
development of the nova driver.
Signed-off-by: Joel Fernandes
---
drivers/gpu/nova-core/devinit.rs | 36
Add detailed explanation and block diagrams of the layout of the vBIOS
on Nvidia GPUs. This is important to understand how nova-core boots an
Nvidia GPU.
Signed-off-by: Joel Fernandes
---
Documentation/gpu/nova/core/vbios.rst | 154 ++
1 file changed, 154 insertions
devinit is mentioned in the code. This patch explains it so it is clear
what it does. devinit is not only essential at boot-time, but also at
runtime due to suspend-resume and things like re-clocking.
Signed-off-by: Joel Fernandes
---
Documentation/gpu/nova/core/devinit.rst | 54
Add explanation of fwsec with diagrams. This helps clarify how the
nova-core falcon boot works.
Signed-off-by: Joel Fernandes
---
Documentation/gpu/nova/core/fwsec.rst | 173 ++
Documentation/gpu/nova/core/vbios.rst | 3 +-
Documentation/gpu/nova/index.rst | 1
Signed-off-by: Joel Fernandes
---
drivers/gpu/nova-core/firmware/fwsec.rs | 17 ++---
1 file changed, 10 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/nova-core/firmware/fwsec.rs
b/drivers/gpu/nova-core/firmware/fwsec.rs
index 664319d1d31c..79c21db9d89d 100644
--- a
osting for GSP WPR2 [1]
[1] https://lore.kernel.org/all/20250420-nova-frts-v1-0-ecd1cca23...@nvidia.com/
Joel Fernandes (6):
nova-core: doc: Add code comments related to devinit
nova-core: doc: Clarify sysmembar operations
nova-core: docs: Document vbios layout
nova-core: docs: Docu
On 4/23/2025 7:12 PM, Timur Tabi wrote:
> On Wed, 2025-04-23 at 18:53 -0400, Joel Fernandes wrote:
>> +This document describes the layout of the VBIOS image which is a series of
>> concatenated
>> +images in the ROM of the GPU. The VBIOS is mirrored onto the BAR 0 space
Hello, Danilo,
On April 24, 2025, 8:08 p.m. UTC Danilo Krummrich wrote:
> On Thu, Apr 24, 2025 at 02:54:42PM -0400, Joel Fernandes wrote:
> >
> >
> > On 4/23/2025 10:06 AM, Danilo Krummrich wrote:
> > [...]
> > >> +
> > >> +/// Probe
Hello, Danilo,
On April 24, 2025, 8:17 p.m. UTC Danilo Krummrich wrote:
> On Thu, Apr 24, 2025 at 03:54:48PM -0400, Joel Fernandes wrote:
> > On Wed, Apr 23, 2025 at 05:02:58PM +0200, Danilo Krummrich wrote:
> > > On Wed, Apr 23, 2025 at 10:52:42AM -0400, Joel Fernandes wr
On Wed, Apr 23, 2025 at 05:02:58PM +0200, Danilo Krummrich wrote:
> On Wed, Apr 23, 2025 at 10:52:42AM -0400, Joel Fernandes wrote:
> > Hello, Danilo,
> > Thanks for all the feedback. Due to the volume of feedback, I will respond
> > incrementally in multiple emails so we
On 4/23/2025 10:06 AM, Danilo Krummrich wrote:
> On Sun, Apr 20, 2025 at 09:19:45PM +0900, Alexandre Courbot wrote:
>> From: Joel Fernandes
>>
>> Add support for navigating and setting up vBIOS ucode data required for
>> GSP to boot. The main data extracted from
On April 25, 2025, 2:32 a.m. UTC Joel Fernandes wrote:
> Hello, Danilo,
>
> On April 24, 2025, 8:17 p.m. UTC Danilo Krummrich wrote:
> > On Thu, Apr 24, 2025 at 03:54:48PM -0400, Joel Fernandes wrote:
> > > On Wed, Apr 23, 2025 at 05:02:58PM +0200, Danilo Krummrich wrote
Hello, Danilo,
On Wed, 23 Apr 2025 16:06:16 +0200, Danilo Krummrich wrote:
> On Sun, Apr 20, 2025 at 09:19:45PM +0900, Alexandre Courbot wrote:
[...]
> > +impl NpdeStruct {
> > +/// Check if this is the last image in the ROM
> > +fn is_last(&self) -> bool {
> > +self.last_image &
On 5/1/2025 5:02 PM, Alexandre Courbot wrote:
> On Fri May 2, 2025 at 12:19 AM JST, Timur Tabi wrote:
>> On Thu, 2025-05-01 at 21:58 +0900, Alexandre Courbot wrote:
>>
>>
>>> +impl UsizeAlign for usize {
>>> + fn align_up(mut self, align: usize) -> usize {
>>> + self = (self + align -
On 5/2/2025 9:59 PM, Alexandre Courbot wrote:
>> pub trait AlignUp {
>> fn align_up(self, alignment: Self) -> Self;
>> }
>>
>> macro_rules! align_up_impl {
>> ($($t:ty),+) => {
>> $(
>> impl AlignUp for $t {
>> fn align_up(self, alignment: Self) -> Sel
Add explanation of fwsec with diagrams. This helps clarify how the
nova-core falcon boot works.
Signed-off-by: Joel Fernandes
---
Documentation/gpu/nova/core/fwsec.rst | 180 ++
Documentation/gpu/nova/index.rst | 1 +
2 files changed, 181 insertions(+)
create
sysmembar is a critical operation that the GSP falcon needs to perform
in the reset sequence. Add some code comments to clarify.
Signed-off-by: Joel Fernandes
---
drivers/gpu/nova-core/gpu.rs | 12 +---
drivers/gpu/nova-core/regs.rs | 2 ++
2 files changed, 11 insertions(+), 3
devinit is mentioned in the code. This patch explains it so it is clear
what it does. devinit is not only essential at boot-time, but also at
runtime due to suspend-resume and things like re-clocking.
Signed-off-by: Joel Fernandes
---
Documentation/gpu/nova/core/devinit.rst | 59
-off-by: Joel Fernandes
---
Documentation/gpu/nova/core/falcon.rst | 156 +
Documentation/gpu/nova/index.rst | 1 +
2 files changed, 157 insertions(+)
create mode 100644 Documentation/gpu/nova/core/falcon.rst
diff --git a/Documentation/gpu/nova/core/falcon.rst
b
https://lore.kernel.org/all/20250501-nova-frts-v2-0-b4a137175...@nvidia.com/
Previous posting:
https://lore.kernel.org/all/20250423225405.139613-1-joelagn...@nvidia.com/
Joel Fernandes (7):
nova-core: doc: Add code comments related to devinit
nova-core: doc: Clarify sysmembar operations
nova-core:
Add documentation strings, comments and AES mode for completeness
to the Falcon signatures.
Signed-off-by: Joel Fernandes
---
drivers/gpu/nova-core/falcon.rs | 25 +++--
1 file changed, 19 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/nova-core/falcon.rs b/drivers
Add several code comments to reduce acronym soup and explain how devinit magic
and bootflow works before driver loads. These are essential for debug and
development of the nova driver.
Signed-off-by: Joel Fernandes
---
drivers/gpu/nova-core/devinit.rs | 34
Add detailed explanation and block diagrams of the layout of the vBIOS
on Nvidia GPUs. This is important to understand how nova-core boots an
Nvidia GPU.
[ Applied Timur Tabi's feedback on providing link to BIT documentation. ]
Signed-off-by: Joel Fernandes
---
Documentation/gpu/nova
Hi, Alex,
Just some documentation-type comments and one Rust-naming-convention comment:
On 4/20/2025 8:19 AM, Alexandre Courbot wrote:
> Upon reset, the GPU executes the GFW_BOOT firmware in order to
> initialize its base parameters such as clocks. The driver must ensure
> that this step is comple
Hi Danilo,
On Mon, Feb 24, 2025 at 01:11:17PM +0100, Danilo Krummrich wrote:
> On Mon, Feb 24, 2025 at 01:07:19PM +0100, Danilo Krummrich wrote:
> > CC: Gary
> >
> > On Mon, Feb 24, 2025 at 10:40:00AM +0900, Alexandre Courbot wrote:
> > > This inability to sleep while we are accessing registers s
On Tue, Feb 25, 2025 at 05:09:35PM +0100, Danilo Krummrich wrote:
> On Tue, Feb 25, 2025 at 10:52:41AM -0500, Joel Fernandes wrote:
> >
> >
> > On 2/24/2025 6:44 PM, Danilo Krummrich wrote:
> > > On Mon, Feb 24, 2025 at 01:45:02PM -0500, Joel Fernandes wrote:
>
On 2/24/2025 6:44 PM, Danilo Krummrich wrote:
> On Mon, Feb 24, 2025 at 01:45:02PM -0500, Joel Fernandes wrote:
>> Hi Danilo,
>>
>> On Mon, Feb 24, 2025 at 01:11:17PM +0100, Danilo Krummrich wrote:
>>> On Mon, Feb 24, 2025 at 01:07:19PM +0100, Danilo Krummrich wro
On 5/6/2025 12:26 PM, Zhi Wang wrote:
> On Sat, 3 May 2025 00:07:56 -0400
> Joel Fernandes wrote:
>
>> Add explanation of fwsec with diagrams. This helps clarify how the
>> nova-core falcon boot works.
>>
>> Signed-off-by: Joel Fernandes
>> ---
&g
On 5/6/2025 12:21 PM, Zhi Wang wrote:
>> -/// Target/source of a DMA transfer to/from falcon memory.
>> +/// FBIF (Framebuffer Interface) aperture type. Used to determine
>> +/// the memory type of the external memory access for a DMA memory
>> +/// transfer (by the Falcon's FramebufferDMA (FBDM
Hi Danilo,
On 5/14/2025 12:23 PM, Danilo Krummrich wrote:
> I feel like this patch utilizes the Option type way too much and
> often without actual need. Can you please also double check?
>
I found one other instance (vbios.fwsec_image). Other than that, all others are
required AFAICS.
>> +
>>
On 5/20/2025 11:01 AM, Danilo Krummrich wrote:
> On Tue, May 20, 2025 at 09:43:42AM -0400, Joel Fernandes wrote:
>> On 5/20/2025 5:30 AM, Danilo Krummrich wrote:
>>> On Tue, May 20, 2025 at 03:55:06AM -0400, Joel Fernandes wrote:
>>>> On 5/13/2025 1:19 PM, Danilo
On 5/20/2025 5:30 AM, Danilo Krummrich wrote:
> On Tue, May 20, 2025 at 03:55:06AM -0400, Joel Fernandes wrote:
>> On 5/13/2025 1:19 PM, Danilo Krummrich wrote:
>>> On Wed, May 07, 2025 at 10:52:43PM +0900, Alexandre Courbot wrote:
>>>> @@ -238
On 5/20/2025 11:36 AM, Danilo Krummrich wrote:
>>> If you want a helper type with Options while parsing that's totally fine,
>>> but
>>> the final result can clearly be without Options. For instance:
>>>
>>> struct Data {
>>>image: KVec,
>>> }
>>>
>>> impl Data {
>>>
Hi Danilo,
On 5/13/2025 1:19 PM, Danilo Krummrich wrote:
> On Wed, May 07, 2025 at 10:52:43PM +0900, Alexandre Courbot wrote:
>> From: Joel Fernandes
>>
>> Add support for navigating and setting up vBIOS ucode data required for
>> GSP to boot. The main data extracted
On 5/16/2025 4:38 PM, Timur Tabi wrote:
> n Wed, 2025-05-07 at 22:52 +0900, Alexandre Courbot wrote:
>> +impl FwSecBiosImage {
>> + fn setup_falcon_data(
>> + &mut self,
>> + pdev: &pci::Device,
>> + pci_at_image: &PciAtBiosImage,
>> + first_fwsec_image: &FwSecBios
> On May 20, 2025, at 11:37 AM, Danilo Krummrich wrote:
>
> On Tue, May 20, 2025 at 11:11:12AM -0400, Joel Fernandes wrote:
>> On 5/20/2025 11:01 AM, Danilo Krummrich wrote:
>>
>> I made this change and it LGTM. Thanks! I did not do the '.0' though si
On 5/20/2025 5:32 PM, Dave Airlie wrote:
> On Wed, 21 May 2025 at 04:13, Joel Fernandes wrote:
>>
>>
>>
>> On 5/20/2025 11:36 AM, Danilo Krummrich wrote:
>>>>> If you want a helper type with Options while parsing that's totally fine,
>>
Hi Danilo,
On 5/14/2025 12:23 PM, Danilo Krummrich wrote:
> On Wed, May 07, 2025 at 10:52:43PM +0900, Alexandre Courbot wrote:
>> +/// PCI Data Structure as defined in PCI Firmware Specification
>> +#[derive(Debug, Clone)]
>> +#[repr(C)]
>> +struct PcirStruct {
>> +/// PCI Data Structure signa
can you pull these 3 for next posting or
applying?
git://git.kernel.org/pub/scm/linux/kernel/git/jfern/linux.git
tag: vbios-for-alex
thanks,
- Joel
On 5/21/2025 2:45 AM, Alexandre Courbot wrote:
> From: Joel Fernandes
>
> Add support for navigating and setting up vBIOS ucode data
On 5/21/2025 11:57 AM, Joel Fernandes wrote:
>
>
> On 5/21/2025 8:43 AM, Boqun Feng wrote:
>> On Wed, May 21, 2025 at 03:44:56PM +0900, Alexandre Courbot wrote:
>>> These properties are very useful to have and should be accessible.
>>>
>>> Signed-of
On 5/21/2025 8:43 AM, Boqun Feng wrote:
> On Wed, May 21, 2025 at 03:44:56PM +0900, Alexandre Courbot wrote:
>> These properties are very useful to have and should be accessible.
>>
>> Signed-off-by: Alexandre Courbot
>> ---
>> rust/kernel/dma.rs | 18 ++
>> 1 file changed, 18
On Mon, Jun 02, 2025 at 03:33:56PM +0200, Danilo Krummrich wrote:
> On Wed, May 21, 2025 at 03:45:11PM +0900, Alexandre Courbot wrote:
> > +impl Vbios {
>
>
>
> > +pub(crate) fn fwsec_header(&self, pdev: &device::Device) ->
> > Result<&FalconUCodeDescV3> {
> > +self.fwsec_image.fwse
Hi Lyude,
>> +bios_image! {
>> +PciAt PciAtBiosImage, // PCI-AT compatible BIOS image
>> +Efi EfiBiosImage, // EFI (Extensible Firmware Interface)
>> +Nbsi NbsiBiosImage, // NBSI (Nvidia Bios System Interface)
>> +FwSecPartial FwSecBiosPartial, // FWSEC (Firmware Securi
On 6/3/2025 5:15 PM, Lyude Paul wrote:
> On Tue, 2025-05-27 at 16:38 -0400, Joel Fernandes wrote:
>> Hello,
>> I split this particular patch into 3 patches:
>>
>> gpu: nova-core: vbios: Add support for FWSEC ucode extraction
>> gpu: nova-core: vbios: Add supp
1 - 100 of 114 matches
Mail list logo
