supported_colorspaces parameter.
The drm_colorspace enum member DRM_MODE_COLORIMETRY_COUNT has been
properly documented by moving the description out of the enum to the
member description list to get rid of an additional warning and improve
documentation clarity.
Signed-off-by: Javier Carrasco
---
The
The drm_colorspace enum member DRM_MODE_COLORIMETRY_COUNT has been
properly documented by moving the description out of the enum to the
member description list to get rid of an additional warning and improve
documentation clarity.
Signed-off-by: Javier Carrasco
Reviewed-by: Randy Dunlap
On 05.03.24 14:34, Greg Kroah-Hartman wrote:
> On Tue, Mar 05, 2024 at 06:55:02AM +0100, Javier Carrasco wrote:
>> The current implementation uses generic names for the power supplies,
>> which conflicts with proper name definitions in the device bindings.
>>
>> A
Deacon
To: Russell King
Cc: linux-so...@vger.kernel.org
Cc: devicet...@vger.kernel.org
Cc: linux-ker...@vger.kernel.org
Cc: linux-...@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: linux-arm-ker...@lists.infradead.org
Signed-off-by: Javier Carrasco
Changes in v8:
- General: rebase to
Kaehlcke
Signed-off-by: Javier Carrasco
---
drivers/usb/misc/onboard_usb_hub.c | 49 --
drivers/usb/misc/onboard_usb_hub.h | 13 ++
2 files changed, 39 insertions(+), 23 deletions(-)
diff --git a/drivers/usb/misc/onboard_usb_hub.c
b/drivers/usb/misc
least 100ns.
Once in normal operation, the XVF3500 registers itself as a USB device,
and it does not require any device-specific operations in the driver.
[1] https://www.xmos.com/xvf3500/
Acked-by: Matthias Kaehlcke
Signed-off-by: Javier Carrasco
---
drivers/usb/misc/onboard_usb_dev.c | 2
The onboard_usb_hub driver has been updated to support non-hub devices,
which has led to some renaming.
Update to the new name (ONBOARD_USB_DEV) accordingly.
Acked-by: Helen Koike
Reviewed-by: Matthias Kaehlcke
Signed-off-by: Javier Carrasco
---
drivers/gpu/drm/ci/arm64.config | 4 ++--
1
The onboard_usb_hub driver has been updated to support non-hub devices,
which has led to some renaming. Update to the new name accordingly.
Update to the new name (ONBOARD_USB_DEV) accordingly.
Reviewed-by: Matthias Kaehlcke
Signed-off-by: Javier Carrasco
---
arch/arm/configs
The XMOS XVF3500 VocalFusion Voice Processor[1] is a low-latency, 32-bit
multicore controller for voice processing.
Add new bindings to define the device properties.
[1] https://www.xmos.com/xvf3500/
Reviewed-by: Krzysztof Kozlowski
Acked-by: Mark Brown
Signed-off-by: Javier Carrasco
).
The "hub" variables in functions where "dev" (and similar names) variables
already exist have been renamed to onboard_dev for clarity, which adds a
few lines in cases where more than 80 characters are used.
No new functionality has been added.
Acked-by: Matthias Kaehlcke
S
eeping the driver's default behavior for non-hub devices (keep
on in suspend).
Acked-by: Matthias Kaehlcke
Signed-off-by: Javier Carrasco
---
drivers/usb/misc/onboard_usb_dev.c | 25 -
drivers/usb/misc/onboard_usb_dev.h | 11 +++
2 files changed, 35 insertions
The onboard_usb_hub driver has been updated to support non-hub devices,
which has led to some renaming.
Update to the new name (ONBOARD_USB_DEV) accordingly.
Reviewed-by: Matthias Kaehlcke
Signed-off-by: Javier Carrasco
---
arch/arm64/configs/defconfig | 2 +-
1 file changed, 1 insertion
you are aiming for a code refactoring, do not apply the __free()
macro to a single device_node, leaving the rest untouched.
Best regards,
Javier Carrasco
e.g. to remove the need for explicit of_node_put() when the
variable goes out of scope). The need for of_node_put() does no vanish,
it is only automated and no longer visible at first glance by means of
the cleanup attribute.
Best regards,
Javier Carrasco
).
The "hub" variables in functions where "dev" (and similar names) variables
already exist have been renamed to onboard_dev for clarity, which adds a
few lines in cases where more than 80 characters are used.
No new functionality has been added.
Signed-off-by: Javier Carras
The current mechanism uses generic names for the power supplies, which
conflicts with proper name definitions in the device bindings.
Add a per-device property to include real supply names and keep generic
names as a fallback mechanism for backward compatibility.
Signed-off-by: Javier Carrasco
The XMOS XVF3500 VocalFusion Voice Processor[1] is a low-latency, 32-bit
multicore controller for voice processing.
Add new bindings to define the device properties.
[1] https://www.xmos.com/xvf3500/
Signed-off-by: Javier Carrasco
---
.../devicetree/bindings/sound/xmos,xvf3500.yaml| 63
Most of the functionality this driver provides can be used by non-hub
devices as well.
To account for the hub-specific code, add a flag to the device data
structure and check its value for hub-specific code.
Signed-off-by: Javier Carrasco
---
drivers/usb/misc/onboard_usb_dev.c | 3
://www.xmos.com/xvf3500/
Signed-off-by: Javier Carrasco
---
drivers/usb/misc/onboard_usb_dev.c | 2 ++
drivers/usb/misc/onboard_usb_dev.h | 8
2 files changed, 10 insertions(+)
diff --git a/drivers/usb/misc/onboard_usb_dev.c
b/drivers/usb/misc/onboard_usb_dev.c
index e66fcac93006..e717d1ca8d79
The onboard_usb_hub driver has been updated to support non-hub devices,
which has led to some renaming.
Update to the new name (ONBOARD_USB_DEV) accordingly.
Signed-off-by: Javier Carrasco
---
drivers/gpu/drm/ci/arm64.config | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
The onboard_usb_hub driver has been updated to support non-hub devices,
which has led to some renaming.
Update to the new name (ONBOARD_USB_DEV) accordingly.
Signed-off-by: Javier Carrasco
---
arch/arm64/configs/defconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch
The onboard_usb_hub driver has been updated to support non-hub devices,
which has led to some renaming. Update to the new name accordingly.
Update to the new name (ONBOARD_USB_DEV) accordingly.
Signed-off-by: Javier Carrasco
---
arch/arm/configs/multi_v7_defconfig | 2 +-
1 file changed, 1
: linux-...@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: linux-arm-ker...@lists.infradead.org
Signed-off-by: Javier Carrasco
Changes in v4:
- General: use device supply names and generics as fallback.
- onbord_usb_dev.c: fix suspend callback for non-hub devices.
- onboard_usb_dev.c: fix
On 21.02.24 21:25, Matthias Kaehlcke wrote:
> On Tue, Feb 20, 2024 at 03:05:50PM +0100, Javier Carrasco wrote:
>> The current mechanism uses generic names for the power supplies, which
>> conflicts with proper name definitions in the device bindings.
>>
>> Add a per-devi
et me know if you still think the extra names are needed.
Not really, the only case I could come up is if an existing device that
uses generic names might end up requiring a third supply, which would
also be generic. But even such an unlikely event would be cover without
ARRAY_SIZE.
Actually one could argue that every existing device could have "vdd" and
"vdd2" as their supply names and remove checks and the generic array.
Best regards,
Javier Carrasco
On 21.02.24 20:24, Matthias Kaehlcke wrote:
> On Tue, Feb 20, 2024 at 03:05:46PM +0100, Javier Carrasco wrote:
>> Most of the functionality this driver provides can be used by non-hub
>> devices as well.
>>
>> To account for the hub-specific code, add a flag to the d
: linux-so...@vger.kernel.org
Cc: devicet...@vger.kernel.org
Cc: linux-ker...@vger.kernel.org
Cc: linux-...@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: linux-arm-ker...@lists.infradead.org
Signed-off-by: Javier Carrasco
Changes in v5:
- onboard_usb_dev: move device suppy names handling to [1
The current implementation uses generic names for the power supplies,
which conflicts with proper name definitions in the device bindings.
Add a per-device property to include real supply names and keep generic
names for existing devices to keep backward compatibility.
Signed-off-by: Javier
The onboard_usb_hub driver has been updated to support non-hub devices,
which has led to some renaming. Update to the new name accordingly.
Update to the new name (ONBOARD_USB_DEV) accordingly.
Signed-off-by: Javier Carrasco
---
arch/arm/configs/multi_v7_defconfig | 2 +-
1 file changed, 1
The onboard_usb_hub driver has been updated to support non-hub devices,
which has led to some renaming.
Update to the new name (ONBOARD_USB_DEV) accordingly.
Signed-off-by: Javier Carrasco
---
arch/arm64/configs/defconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch
The onboard_usb_hub driver has been updated to support non-hub devices,
which has led to some renaming.
Update to the new name (ONBOARD_USB_DEV) accordingly.
Acked-by: Helen Koike
Signed-off-by: Javier Carrasco
---
drivers/gpu/drm/ci/arm64.config | 4 ++--
1 file changed, 2 insertions(+), 2
The XMOS XVF3500 VocalFusion Voice Processor[1] is a low-latency, 32-bit
multicore controller for voice processing.
Add new bindings to define the device properties.
[1] https://www.xmos.com/xvf3500/
Reviewed-by: Krzysztof Kozlowski
Signed-off-by: Javier Carrasco
---
.../devicetree/bindings
://www.xmos.com/xvf3500/
Signed-off-by: Javier Carrasco
---
drivers/usb/misc/onboard_usb_dev.c | 2 ++
drivers/usb/misc/onboard_usb_dev.h | 8
2 files changed, 10 insertions(+)
diff --git a/drivers/usb/misc/onboard_usb_dev.c
b/drivers/usb/misc/onboard_usb_dev.c
index df0ed172c7ec..50f84c5278a2
).
The "hub" variables in functions where "dev" (and similar names) variables
already exist have been renamed to onboard_dev for clarity, which adds a
few lines in cases where more than 80 characters are used.
No new functionality has been added.
Signed-off-by: Javier Carras
eeping the driver's default behavior for non-hub devices (keep
on in suspend).
Signed-off-by: Javier Carrasco
---
drivers/usb/misc/onboard_usb_dev.c | 25 +++--
drivers/usb/misc/onboard_usb_dev.h | 10 ++
2 files changed, 33 insertions(+), 2 deletions(-)
diff --gi
On 28.02.24 16:37, Matthias Kaehlcke wrote:
> Hi Javier,
>
> Thanks for moving this patch to the front of the series!
>
> A few more comments inline.
>
> On Wed, Feb 28, 2024 at 02:51:28PM +0100, Javier Carrasco wrote:
>> The current implementation uses generic n
On 28.02.24 19:18, Matthias Kaehlcke wrote:
> On Wed, Feb 28, 2024 at 02:51:29PM +0100, Javier Carrasco wrote:
>> This patch prepares onboad_hub to support non-hub devices by renaming
>> the driver files and their content, the headers and their references.
>>
>> The com
On 28.02.24 19:10, Matthias Kaehlcke wrote:
> On Wed, Feb 28, 2024 at 02:51:33PM +0100, Javier Carrasco wrote:
>> Most of the functionality this driver provides can be used by non-hub
>> devices as well.
>>
>> To account for the hub-specific code, add a flag to the d
On 28.02.24 21:41, Matthias Kaehlcke wrote:
> On Wed, Feb 28, 2024 at 09:21:00PM +0100, Javier Carrasco wrote:
>> On 28.02.24 19:10, Matthias Kaehlcke wrote:
>>> On Wed, Feb 28, 2024 at 02:51:33PM +0100, Javier Carrasco wrote:
>>>> Most of the functionality this driv
On 28.02.24 22:34, Matthias Kaehlcke wrote:
> On Wed, Feb 28, 2024 at 09:50:22PM +0100, Javier Carrasco wrote:
>> On 28.02.24 21:41, Matthias Kaehlcke wrote:
>>> On Wed, Feb 28, 2024 at 09:21:00PM +0100, Javier Carrasco wrote:
>>>> On 28.02.24 19:10, Matthias Kaehlc
Commit 14485de431b0 ("usb: Use device_get_match_data()") overlooked the
already existing pointer to pdev->dev 'dev'.
Use the existing pointer 'dev' in device_get_match_data() to keep code
consistency.
Signed-off-by: Javier Carrasco
---
drivers/usb/misc/onboard
The current implementation uses generic names for the power supplies,
which conflicts with proper name definitions in the device bindings.
Add a per-device property to include real supply names and keep generic
names for existing devices to keep backward compatibility.
Signed-off-by: Javier
: linux-so...@vger.kernel.org
Cc: devicet...@vger.kernel.org
Cc: linux-ker...@vger.kernel.org
Cc: linux-...@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: linux-arm-ker...@lists.infradead.org
Signed-off-by: Javier Carrasco
Changes in v6:
- onboard_usb_hub.c: use dev pointer in probe
).
The "hub" variables in functions where "dev" (and similar names) variables
already exist have been renamed to onboard_dev for clarity, which adds a
few lines in cases where more than 80 characters are used.
No new functionality has been added.
Signed-off-by: Javier Carras
The onboard_usb_hub driver has been updated to support non-hub devices,
which has led to some renaming. Update to the new name accordingly.
Update to the new name (ONBOARD_USB_DEV) accordingly.
Signed-off-by: Javier Carrasco
---
arch/arm/configs/multi_v7_defconfig | 2 +-
1 file changed, 1
The XMOS XVF3500 VocalFusion Voice Processor[1] is a low-latency, 32-bit
multicore controller for voice processing.
Add new bindings to define the device properties.
[1] https://www.xmos.com/xvf3500/
Reviewed-by: Krzysztof Kozlowski
Acked-by: Mark Brown
Signed-off-by: Javier Carrasco
least 100ns.
Once in normal operation, the XVF3500 registers itself as a USB device,
and it does not require any device-specific operations in the driver.
[1] https://www.xmos.com/xvf3500/
Signed-off-by: Javier Carrasco
---
drivers/usb/misc/onboard_usb_dev.c | 2 ++
drivers/usb/misc
eeping the driver's default behavior for non-hub devices (keep
on in suspend).
Signed-off-by: Javier Carrasco
---
drivers/usb/misc/onboard_usb_dev.c | 25 -
drivers/usb/misc/onboard_usb_dev.h | 10 ++
2 files changed, 34 insertions(+), 1 deletion(-)
diff --gi
The onboard_usb_hub driver has been updated to support non-hub devices,
which has led to some renaming.
Update to the new name (ONBOARD_USB_DEV) accordingly.
Acked-by: Helen Koike
Signed-off-by: Javier Carrasco
---
drivers/gpu/drm/ci/arm64.config | 4 ++--
1 file changed, 2 insertions(+), 2
The onboard_usb_hub driver has been updated to support non-hub devices,
which has led to some renaming.
Update to the new name (ONBOARD_USB_DEV) accordingly.
Signed-off-by: Javier Carrasco
---
arch/arm64/configs/defconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch
On 29.02.24 20:52, Matthias Kaehlcke wrote:
> On Thu, Feb 29, 2024 at 09:34:50AM +0100, Javier Carrasco wrote:
>> Most of the functionality this driver provides can be used by non-hub
>> devices as well.
>>
>> To account for the hub-specific code, add a flag to the d
Kaehlcke
Signed-off-by: Javier Carrasco
---
drivers/usb/misc/onboard_usb_hub.c | 49 --
drivers/usb/misc/onboard_usb_hub.h | 12 ++
2 files changed, 38 insertions(+), 23 deletions(-)
diff --git a/drivers/usb/misc/onboard_usb_hub.c
b/drivers/usb/misc
: linux-so...@vger.kernel.org
Cc: devicet...@vger.kernel.org
Cc: linux-ker...@vger.kernel.org
Cc: linux-...@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: linux-arm-ker...@lists.infradead.org
Signed-off-by: Javier Carrasco
Changes in v7:
- onboard_usb_dev.c: drop comment for is_hub field
Commit 14485de431b0 ("usb: Use device_get_match_data()") overlooked the
already existing pointer to pdev->dev 'dev'.
Use the existing pointer 'dev' in device_get_match_data() to keep code
consistency.
Acked-by: Matthias Kaehlcke
Signed-off-by: Javie
eeping the driver's default behavior for non-hub devices (keep
on in suspend).
Acked-by: Matthias Kaehlcke
Signed-off-by: Javier Carrasco
---
drivers/usb/misc/onboard_usb_dev.c | 25 -
drivers/usb/misc/onboard_usb_dev.h | 10 ++
2 files changed, 34 insertions
The onboard_usb_hub driver has been updated to support non-hub devices,
which has led to some renaming.
Update to the new name (ONBOARD_USB_DEV) accordingly.
Acked-by: Helen Koike
Reviewed-by: Matthias Kaehlcke
Signed-off-by: Javier Carrasco
---
drivers/gpu/drm/ci/arm64.config | 4 ++--
1
The XMOS XVF3500 VocalFusion Voice Processor[1] is a low-latency, 32-bit
multicore controller for voice processing.
Add new bindings to define the device properties.
[1] https://www.xmos.com/xvf3500/
Reviewed-by: Krzysztof Kozlowski
Acked-by: Mark Brown
Signed-off-by: Javier Carrasco
).
The "hub" variables in functions where "dev" (and similar names) variables
already exist have been renamed to onboard_dev for clarity, which adds a
few lines in cases where more than 80 characters are used.
No new functionality has been added.
Acked-by: Matthias Kaehlcke
S
The onboard_usb_hub driver has been updated to support non-hub devices,
which has led to some renaming.
Update to the new name (ONBOARD_USB_DEV) accordingly.
Reviewed-by: Matthias Kaehlcke
Signed-off-by: Javier Carrasco
---
arch/arm64/configs/defconfig | 2 +-
1 file changed, 1 insertion
The onboard_usb_hub driver has been updated to support non-hub devices,
which has led to some renaming. Update to the new name accordingly.
Update to the new name (ONBOARD_USB_DEV) accordingly.
Reviewed-by: Matthias Kaehlcke
Signed-off-by: Javier Carrasco
---
arch/arm/configs
least 100ns.
Once in normal operation, the XVF3500 registers itself as a USB device,
and it does not require any device-specific operations in the driver.
[1] https://www.xmos.com/xvf3500/
Acked-by: Matthias Kaehlcke
Signed-off-by: Javier Carrasco
---
drivers/usb/misc/onboard_usb_dev.c | 2
Make use of the __free() cleanup handler to automatically free nodes
when they get out of scope.
Suggested-by: Julia Lawall
Signed-off-by: Javier Carrasco
---
The patch is based on the latest linux-next tag (next-20240410).
---
drivers/gpu/drm/kmb/kmb_drv.c | 13 -
drivers/gpu/drm
exits without the need for explicit calls to of_node_put().
Reported-by: kernel test robot
Reported-by: Julia Lawall
Closes: https://lore.kernel.org/r/202406172314.2vvgelas-...@intel.com/
Fixes: b72755f5b577 ("backlight: Add new lm3509 backlight driver")
Signed-off-by: Javier Carrasco
--
mistakes if new break/return instructions
are added, but the macro might not be available in older kernels.
When at it, an unused header has been dropped.
Signed-off-by: Javier Carrasco
---
Javier Carrasco (3):
drm/mediatek: ovl_adaptor: drop unused mtk_crtc.h header
drm/mediatek
calls to of_node_put().
Signed-off-by: Javier Carrasco
---
drivers/gpu/drm/mediatek/mtk_disp_ovl_adaptor.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl_adaptor.c
b/drivers/gpu/drm/mediatek/mtk_disp_ovl_adaptor.c
index 3faf26a55e77
None of the elements from that header is used in this file.
Signed-off-by: Javier Carrasco
---
drivers/gpu/drm/mediatek/mtk_disp_ovl_adaptor.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl_adaptor.c
b/drivers/gpu/drm/mediatek/mtk_disp_ovl_adaptor.c
Error paths that exit for_each_child_of_node() need to call
of_node_put() to decerement the child refcount and avoid memory leaks.
Add the missing of_node_put().
Cc: sta...@vger.kernel.org
Fixes: 453c3364632a ("drm/mediatek: Add ovl_adaptor support for MT8195")
Signed-off-by: Javie
On 4/10/24 22:45, Javier Carrasco wrote:
> Make use of the __free() cleanup handler to automatically free nodes
> when they get out of scope.
>
> Suggested-by: Julia Lawall
> Signed-off-by: Javier Carrasco
> ---
> The patch is based on the latest linux-next tag (next-202404
hasis")
Signed-off-by: Javier Carrasco
---
drivers/gpu/drm/bridge/tc358767.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/bridge/tc358767.c
b/drivers/gpu/drm/bridge/tc358767.c
index 159c95b26d33..942fbaa1413a 100644
--- a/drivers/gpu/drm/bridge/tc358767.c
+++ b/drive
paths, this series provides a first patch
with the classical approach of adding the missing of_node_put(), and two
more patches to use the cleanup attribute and avoid issues with
device nodes again.
Signed-off-by: Javier Carrasco
---
Javier Carrasco (3):
drm: logicvc: fix missing of_node_put
quot;)
Signed-off-by: Javier Carrasco
---
drivers/gpu/drm/logicvc/logicvc_layer.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/logicvc/logicvc_layer.c
b/drivers/gpu/drm/logicvc/logicvc_layer.c
index 464000aea765..52dabacd42ee 100644
--- a/drivers/gpu/drm/logicvc/logicvc_layer
Use the scoped variant of the macro to avoid leaking memory upon early
exits without the required call to of_node_put().
Signed-off-by: Javier Carrasco
---
drivers/gpu/drm/logicvc/logicvc_layer.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/logicvc
Use the more robust approach provided by the __free() macro to
automatically call of_node_put() when the device node goes out of scope.
Signed-off-by: Javier Carrasco
---
drivers/gpu/drm/logicvc/logicvc_layer.c | 10 +++---
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a
ff-by: Javier Carrasco
---
Javier Carrasco (2):
drm/mediatek: Fix child node refcount handling in early exit
drm/mediatek: Switch to for_each_child_of_node_scoped()
drivers/gpu/drm/mediatek/mtk_drm_drv.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
---
base-c
cking for coverity issue")
Signed-off-by: Javier Carrasco
---
drivers/gpu/drm/mediatek/mtk_drm_drv.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
index a4594f8873d5..0878df832859 10
Introduce the scoped variant of the loop to automatically release the
child node when it goes out of scope, which is more robust than the
non-scoped variant, and accounts for new early exits that could be added
in the future.
Signed-off-by: Javier Carrasco
---
drivers/gpu/drm/mediatek
sh them because the first one
would apply to stable patches (note the Cc: tag) that are older than the
scoped macro, which was introduced this year.
Best regards,
Javier Carrasco
`meson_regmap_config` is not modified and can be declared as const to
move its data to a read-only section.
Signed-off-by: Javier Carrasco
---
drivers/gpu/drm/meson/meson_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/meson/meson_drv.c
b/drivers/gpu
`ili9322_regmap_bus` is not modified and can be declared as const to
move its data to a read-only section.
Signed-off-by: Javier Carrasco
---
drivers/gpu/drm/panel/panel-ilitek-ili9322.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/panel/panel-ilitek
`regmap_txt_io` is not modified and can be declared as const to
move its data to a read-only section.
Signed-off-by: Javier Carrasco
---
drivers/gpu/drm/sprd/sprd_dsi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/sprd/sprd_dsi.c b/drivers/gpu/drm/sprd
`fsl_tcon_regmap_config` is not modified and can be declared as const to
move its data to a read-only section.
Signed-off-by: Javier Carrasco
---
drivers/gpu/drm/fsl-dcu/fsl_tcon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/fsl-dcu/fsl_tcon.c
b/drivers
`mtk_dp_regmap_config` is not modified and can be declared as const to
move its data to a read-only section.
Signed-off-by: Javier Carrasco
---
drivers/gpu/drm/mediatek/mtk_dp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_dp.c
b/drivers/gpu
This series adds the const modifier to the remaining regmap_bus and
regmap_config structs under drm/ that are effectively used as const
(i.e., only read after their declaration), but kept ad writtable data.
Signed-off-by: Javier Carrasco
---
Javier Carrasco (6):
drm/bridge: dpc3433
`dlpc_regmap_config` is not modified and can be declared as const to
move its data to a read-only section.
Signed-off-by: Javier Carrasco
---
drivers/gpu/drm/bridge/ti-dlpc3433.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/ti-dlpc3433.c
b/drivers
uct platform_device *pdev;
of_id = of_match_node(mtk_drm_of_ids, node);
---
This chunk can be found in mtk_drm_get_all_drm_priv(), which is not
listed in the trace, but it is called from mtk_drm_bind().
The loop did not release the child_node if cnt == MAX_CRTC (by means of
a break), which goes against how for_each_child_of_node() should be
handled. If the child_node is indeed required afterwards (it is not
referenced anywhere after the loop), it should be acquired via
of_node_get() and stored somewhere to be able to put it later.
Then another issue would lie underneath as the reference to the
child_node is not stored in any way. But if this patch fixes the issue,
then I suppose it should be applied immediately, and the rest should be
discussed later on.
By the way, are there any logs with debug/error messages to analyze
further is the issue is something different?
Thanks and best regards,
Javier Carrasco
On 09/12/2024 09:56, AngeloGioacchino Del Regno wrote:
> Il 06/12/24 09:54, CK Hu (胡俊光) ha scritto:
>> Hi, Sasha:
>>
>> On Mon, 2024-11-25 at 01:35 +0100, Javier Carrasco wrote:
>>> External email : Please do not click links or open attachments until
>>> you
86 matches
Mail list logo
