for_each_endpoint_of_node() requires a call to of_node_put() for every
early exit. A new error path was added to the loop without observing
this requirement.

Add the missing call to of_node_put() in the error path.

Fixes: 1fb4dceeedc5 ("drm/bridge: tc358767: Add configurable default 
preemphasis")
Signed-off-by: Javier Carrasco <javier.carrasco.c...@gmail.com>
---
 drivers/gpu/drm/bridge/tc358767.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/bridge/tc358767.c 
b/drivers/gpu/drm/bridge/tc358767.c
index 159c95b26d33..942fbaa1413a 100644
--- a/drivers/gpu/drm/bridge/tc358767.c
+++ b/drivers/gpu/drm/bridge/tc358767.c
@@ -2405,6 +2405,7 @@ static int tc_probe_bridge_endpoint(struct tc_data *tc)
                        if (tc->pre_emphasis[0] < 0 || tc->pre_emphasis[0] > 2 
||
                            tc->pre_emphasis[1] < 0 || tc->pre_emphasis[1] > 2) 
{
                                dev_err(dev, "Incorrect Pre-Emphasis setting, 
use either 0=0dB 1=3.5dB 2=6dB\n");
+                               of_node_put(node);
                                return -EINVAL;
                        }
                }

---
base-commit: d61a00525464bfc5fe92c6ad713350988e492b88
change-id: 20241013-tc358767-of_node_put-14a3004e9f45

Best regards,
-- 
Javier Carrasco <javier.carrasco.c...@gmail.com>

Reply via email to