Re: Is LLVM 13 (git) really ready for testing/development? libclc didn't compile

Not Marek, but hope this answer will help. libclc uses clang CLC preprocessor on .ll files, llvm/clang-13 started including clc declarations by default (clang cf3ef15a6ec5e5b45c6c54e8fbe3769255e815ce), thus corrupting any .ll assembly files that are used by libclc. Inclusion of the default declarat

Re: Is LLVM 13 (git) really ready for testing/development? libclc didn't compile

; Tried several places... > ...where to put it? > > Dieter > > Am 06.03.2021 17:56, schrieb Jan Vesely: > > Not Marek, but hope this answer will help. > > libclc uses clang CLC preprocessor on .ll files, llvm/clang-13 started > > including clc declarations by default (clang

Re: Is LLVM 13 (git) really ready for testing/development? libclc didn't compile

One more update. without changing any cmake files the following cmdline should work: cmake ../llvm-project/libclc/ -DLLVM_CONFIG=/usr/local/llvm-git/bin/llvm-config -DCMAKE_LLAsm_FLAGS=-cl-no-stdinc -DCMAKE_CLC_FLAGS=-cl-no-stdinc Jan On Wed, Mar 10, 2021 at 1:20 AM Jan Vesely wrote: >

[PATCH libdrm 1/1] drmsltest: Check expected neighbours

This test cements behaviour set in 3b2ee2b5bfc0d68525fee936e51297a9b6c629f1 drmSL: Fix neighbor lookup (2015-02-27) Signed-off-by: Jan Vesely --- tests/drmsl.c | 28 1 file changed, 20 insertions(+), 8 deletions(-) diff --git a/tests/drmsl.c b/tests/drmsl.c index

[PATCH 2/2] Fix one warning

familiar with the design than just reading the code (like I did) regards, jan > > Since the drmSetServerInfo is seldom used, maybe we can just do the 'int' > cast at this moment. I will send v2 for this. > > Regards, > Jammy > > -----Original Messa

[PATCH] configure.ac: disable annoying warning -Wmissing-field-initializers

> > > > That's up to you, but please note that I don't plan to stop > > > > > using "= {}", > > > > > because it's the most convenient way to clear memory in a lot > > > > > of > > > > > cases

[PATCH libdrm v2 1/8] tests/hash: extract test out of xf86drmHash.c

sh.h > new file mode 100644 > index 000..38fd84b > --- /dev/null > +++ b/xf86drmHash.h > @@ -0,0 +1,47 @@ > +/* > + * Copyright 1999 Precision Insight, Inc., Cedar Park, Texas. > + * All Rights Reserved. > + * > + * Permission is hereby granted, free of charge,

Re: [PATCH libdrm 3/3] amdgpu: Destroy fd_hash table when the last device is removed.

On Fri, 2018-05-18 at 13:00 -0400, Jan Vesely wrote: > Fixes memory leak on module unload. > Analogous to mesa commit of the same name. > Signed-off-by: Jan Vesely > --- > amdgpu/amdgpu_device.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/amdgpu/

[PATCH libdrm 1/1] amdgpu: Take lock before removing devices from fd_tab hash table.

Close the file descriptors under lock as well. Signed-off-by: Jan Vesely --- amdgpu/amdgpu_device.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/amdgpu/amdgpu_device.c b/amdgpu/amdgpu_device.c index 983b19ab..f71fc050 100644 --- a/amdgpu/amdgpu_device.c +++ b

Re: [PATCH libdrm 1/1] amdgpu: Take lock before removing devices from fd_tab hash table.

On Thu, 2018-05-10 at 19:33 -0400, Jan Vesely wrote: > Close the file descriptors under lock as well. > > Signed-off-by: Jan Vesely > --- > amdgpu/amdgpu_device.c | 11 +++ > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/amdgpu/

[PATCH libdrm v2 1/3] amdgpu: Take lock before removing devices from fd_tab hash table.

Close the file descriptors under lock as well. v2: close fds after removing from hash table Signed-off-by: Jan Vesely --- amdgpu/amdgpu_device.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/amdgpu/amdgpu_device.c b/amdgpu/amdgpu_device.c index 983b19ab

[PATCH libdrm 2/3] amdgpu/util_hash_table: Add helper function to count the number of entries in hash table

Analogous to the mesa commit of the same name. Signed-off-by: Jan Vesely --- amdgpu/util_hash_table.c | 12 amdgpu/util_hash_table.h | 2 ++ 2 files changed, 14 insertions(+) diff --git a/amdgpu/util_hash_table.c b/amdgpu/util_hash_table.c index 89a8bf9b..e06d4415 100644 --- a

[PATCH libdrm 3/3] amdgpu: Destroy fd_hash table when the last device is removed.

Fixes memory leak on module unload. Analogous to mesa commit of the same name. Signed-off-by: Jan Vesely --- amdgpu/amdgpu_device.c | 4 1 file changed, 4 insertions(+) diff --git a/amdgpu/amdgpu_device.c b/amdgpu/amdgpu_device.c index e23dd3b3..34ac95b8 100644 --- a/amdgpu/amdgpu_device.c

Re: [PATCH libdrm] xf86drmHash: remove unused loop variable

On Wed, 2018-11-07 at 14:44 +, Eric Engestrom wrote: > Reported-by: Jan Vesely > Signed-off-by: Eric Engestrom LGTM. Reviewed-by: Jan Vesely Jan > --- > xf86drmHash.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/xf86drmHash.c b/xf86drmHash.c > in

[PATCH libdrm 1/1] amdgpu: Do not write beyond allocated memory when parsing ids

Fixes crash when/usr/share/libdrm/amdgpu.ids contains ASIC_ID_TABLE_NUM_ENTRIES + 1 entries. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102432 Signed-off-by: Jan Vesely --- Compile tested only. amdgpu/amdgpu_asic_id.c | 15 --- 1 file changed, 8 insertions(+), 7

[PATCH libdrm 1/1] drmsltest: Check expected neighbours

Fixes: 7d8c9464081634f053e16e5eac9655a12fae1dc4 Signed-off-by: Jan Vesely --- I thought I sent this out, but couldn't find it in sent mail. This tests the behaviour set in 3b2ee2b5bfc0d68525fee936e51297a9b6c629f1 more than 2 years ago Jan tests/drmsl.c | 28 --

[PATCH libdrm 1/1] amdgpu: Add FX-9800P Bristol Ridge iGPU id

Signed-off-by: Jan Vesely --- data/amdgpu.ids | 1 + 1 file changed, 1 insertion(+) diff --git a/data/amdgpu.ids b/data/amdgpu.ids index 0b98c3c3..f6c65dd9 100644 --- a/data/amdgpu.ids +++ b/data/amdgpu.ids @@ -153,6 +153,7 @@ 9874, C5, AMD Radeon R6 Graphics 9874, C6, AMD Radeon R6

Re: [PATCH libdrm] exynos: change the license to X11/MIT

ed to get your agree - all committers. > So please give me Acked-by if you agree with me. Don't really know or care why this is necessary, but few cleanup commits shouldn't block this. Acked-by: Jan Vesely Jan > > Signed-off-by: Inki Dae > Acked-by: Hyungwon Hwang

[PATCH 1/1] drm/amdkfd: Do not ignore requested queue size during allocation

Signed-off-by: Jan Vesely --- drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue_vi.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue_vi.c b/drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue_vi.c index f1d48281e322..b3bee39661ab 100644

Re: [PATCH 1/1] drm/amdkfd: Do not ignore requested queue size during allocation

at reason? (I'm running ROCK-1.6.x based kernel) thanks, Jan > > Regards, > Felix > > > On 2017-11-19 03:19 AM, Oded Gabbay wrote: > > On Thu, Nov 16, 2017 at 11:36 PM, Jan Vesely wrote: > > > Signed-off-by: Jan Vesely > > > --- > > > d

Re: [PATCH 1/1] drm/amdkfd: Do not ignore requested queue size during allocation

20 resume commads fit (otherwise I get spurious ENOMEM when the queue is full but still advancing). thanks, Jan > > Regards, > Felix > > > On 2017-11-29 04:43 PM, Jan Vesely wrote: > > On Mon, 2017-11-20 at 14:22 -0500, Felix Kuehling wrote: > > > I think this

[PATCH libdrm 1/1] xf86drm.c: Fix mix of tabs and spaces

Remove whitespace at the end of line. diff -b shows only two removed lines Signed-off-by: Jan Vesely --- xf86drm.c | 1444 ++--- 1 file changed, 721 insertions(+), 723 deletions(-) diff --git a/xf86drm.c b/xf86drm.c index 804a413..e99f2e2

Re: [PATCH libdrm] xf86drm: fix valgrind warning in drmParsePciBusInfo

TAG); > - if (str == NULL) > -return -EINVAL; > +fclose(uevent); > > -if (sscanf(str, TAG "%04x:%02x:%02x.%1u", > - &domain, &bus, &dev, &func) != 4) > +if (!found) > return -EINVAL; > -#undef TAG > > info->domain = domain; > info->bus = bus; -- Jan Vesely signature.asc Description: This is a digitally signed message part ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[libdrm][PATCH 3/2] Fix always true comparison.

On Wed, 2015-02-25 at 18:41 +, Emil Velikov wrote: > On 25/02/15 17:11, Jan Vesely wrote: > > gentle ping > > > Afaics it's very had to get in this code nowadays - drm_server_info is > set only via the legacy (?) function drmSetServerInfo. With the latter > onl

[PATCH 1/1] drm/radeon: Fix cleanup error path.

Conversion to the reservation api is next on the list, after that the functionality can be restored with rcu. Signed-off-by: Maarten Lankhorst CC: stable at vger.kernel.org Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=94081 Signed-off-by: Jan Vesely --- drivers/gpu/drm/radeon

[PATCH 1/1] drm/radeon: Fix cleanup error path.

please ignore this patch, see bugzilla for details. sorry for the noise. On Wed, 2015-03-04 at 16:10 -0500, Jan Vesely wrote: > cleanup: target is called before fence_get > Fixes hangs on GPU reset on Turks GPU. > > regression introduced by: > commit dd7cfd641228abb2669d8d047

[PATCH libdrm 7/8] Fix unused, and unused-but-set variables warnings

On Fri, 2015-03-13 at 22:56 +, Emil Velikov wrote: > On 27 February 2015 at 18:07, Jan Vesely wrote: > > Signed-off-by: Jan Vesely > > --- > > tests/exynos/exynos_fimg2d_test.c | 4 +--- > > xf86drm.c | 9 ++--- > > 2 files chan

[PATCH libdrm 1/8] Add static qualifier to local functions

On Fri, 2015-03-13 at 23:07 +, Emil Velikov wrote: > On 27 February 2015 at 18:07, Jan Vesely wrote: > > Signed-off-by: Jan Vesely > > --- > > tests/drmstat.c | 8 > > tests/kmstest/main.c| 2 +- > >

[PATCH libdrm 0/8] Warnings fixes

On Fri, 2015-03-13 at 23:20 +, Emil Velikov wrote: > Hi Jan, > > On 27 February 2015 at 22:27, Emil Velikov > wrote: > > On 27/02/15 18:07, Jan Vesely wrote: > >> His series fixes most of the warnings my compiler spits out running > >> make distcheck. &g

[PATCH libdrm v2 1/8] Add static qualifier to local functions

v2: Don't bother marking dead functions static (handler, xf86VDrvMsgVerb, drmSetDebugMsgFunction) Signed-off-by: Jan Vesely --- tests/drmstat.c | 2 +- tests/kmstest/main.c| 2 +- tests/modeprint/modeprint.c | 18 +- tests/proptest/proptest.c

[PATCH libdrm 4/8] xf86drmSL: Fix neighbour printing

Hi Kristian, this patch partially reverts e4a519635: Tidy up compile warnings by cleaning up types. it looks to me that the xf86drmSL.c bits slipped in by accident. thanks, Jan On Fri, 2015-02-27 at 13:07 -0500, Jan Vesely wrote: > Signed-off-by: Jan Vesely > --- > xf86dr

[PATCH libdrm 1/1] tests/exynos: Fix warnings

Signed-off-by: Jan Vesely --- tests/exynos/exynos_fimg2d_test.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/exynos/exynos_fimg2d_test.c b/tests/exynos/exynos_fimg2d_test.c index e7d9b72..dfb34ac 100644 --- a/tests/exynos/exynos_fimg2d_test.c +++ b/tests/exynos

[PATCH libdrm v2 8/8] Fix unused function warnings

v2: Remove the handler function instead of commenting out split debugmsg function removal to a separate patch Signed-off-by: Jan Vesely --- tests/drmstat.c | 13 - xf86drm.c | 2 ++ 2 files changed, 2 insertions(+), 13 deletions(-) diff --git a/tests/drmstat.c b/tests

[PATCH libdrm 9/8] Remove drmSetDebugMsgFunction and related infrastructure

Not used anywhere Signed-off-by: Jan Vesely --- xf86drm.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/xf86drm.c b/xf86drm.c index a309d57..ab472ea 100644 --- a/xf86drm.c +++ b/xf86drm.c @@ -114,11 +114,6 @@ drmDebugPrint(const char *format, va_list ap

[PATCH libdrm 1/1] tests/exynos: Fix warnings

On Wed, 2015-03-18 at 20:23 +0100, Tobias Jakobi wrote: > Hello Jan, > > Jan Vesely wrote: > > Signed-off-by: Jan Vesely > > --- > > tests/exynos/exynos_fimg2d_test.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/t

[PATCH libdrm 4/8] xf86drmSL: Fix neighbour printing

On Fri, 2015-03-20 at 17:38 +, Emil Velikov wrote: > On 27/02/15 18:07, Jan Vesely wrote: > > Signed-off-by: Jan Vesely > > --- > > xf86drmSL.c | 7 +-- > > 1 file changed, 5 insertions(+), 2 deletions(-) > > > > diff --git a/xf86drmSL.c b/xf86dr

[PATCH libdrm 9/8] Remove drmSetDebugMsgFunction and related infrastructure

On Fri, 2015-03-20 at 21:06 +, Emil Velikov wrote: > On 18 March 2015 at 18:37, Jan Vesely wrote: > > Not used anywhere > > > Some information from my digging around: > > Function was added with commit 79038751ffe(libdrm: add support for > server side functiona

[PATCH libdrm 4/8] xf86drmSL: Fix neighbour printing

On Fri, 2015-03-20 at 14:01 -0400, Jan Vesely wrote: > On Fri, 2015-03-20 at 17:38 +, Emil Velikov wrote: > > On 27/02/15 18:07, Jan Vesely wrote: > > > Signed-off-by: Jan Vesely > > > --- > > > xf86drmSL.c | 7 +-- > > > 1 file changed, 5 in

[PATCH libdrm 1/4] drmSL: Fix neighbor printing

v2: zero the update array instead of checking the return value. SLLocate returns NULL both on failure and if the element is greater than everything in the list Signed-off-by: Jan Vesely --- xf86drmSL.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/xf86drmSL.c

[PATCH libdrm 3/4] drmsltest: Check expected neighbours

Signed-off-by: Jan Vesely --- tests/drmsltest.c | 28 1 file changed, 20 insertions(+), 8 deletions(-) diff --git a/tests/drmsltest.c b/tests/drmsltest.c index d193008..d871fbf 100644 --- a/tests/drmsltest.c +++ b/tests/drmsltest.c @@ -106,7 +106,9 @@ static double

[PATCH libdrm 2/4] drmSL: Split tests to a separate file

Signed-off-by: Jan Vesely --- .gitignore| 1 + tests/Makefile.am | 3 +- tests/drmsltest.c | 172 ++ 3 files changed, 175 insertions(+), 1 deletion(-) create mode 100644 tests/drmsltest.c diff --git a/.gitignore b/.gitignore index

[PATCH libdrm 4/4] drmSL: Remove test parts

Signed-off-by: Jan Vesely --- xf86drmSL.c | 172 +++- 1 file changed, 6 insertions(+), 166 deletions(-) diff --git a/xf86drmSL.c b/xf86drmSL.c index cf588ac..bb9ca7f 100644 --- a/xf86drmSL.c +++ b/xf86drmSL.c @@ -41,13 +41,7 @@ #include

[PATCH libdrm 1/1] tests/exynos: Fix warnings

On Wed, 2015-03-18 at 20:23 +0100, Tobias Jakobi wrote: > Hello Jan, > > Jan Vesely wrote: > > Signed-off-by: Jan Vesely > > --- > > tests/exynos/exynos_fimg2d_test.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/t

[PATCH libdrm 1/9] tests/dristat: don't include C files

t? The original code creates the node if it does not exist (on non-UDEV systems), or waits some time for udev to create it. Not sure how this is relevant for the test. > if (fd >= 0) { > printf("%s\n", buf); > if (mask & DRM_BUSID) getbusid(fd

[PATCH libdrm 2/9] tests/hash: extract test out of xf86drmHash.c

blePtr table; > -int i; > - > -printf("\n* 256 consecutive integers \n"); > -table = drmHashCreate(); > -for (i = 0; i < 256; i++) drmHashInsert(table, i, i); > -for (i = 0; i < 256; i++) check_table(table, i, i); > -for (i =

[PATCH libdrm 3/9] tests/hash: misc compilation fixes

+for (i = 0; i < 1024; i++) drmHashInsert(table, random(), (void *)&i); > srandom(0xbeefbeef); > for (i = 0; i < 1024; i++) check_table(table, random(), i); > srandom(0xbeefbeef); > @@ -207,7 +204,7 @@ int main(void) > printf("\n* 5000 rando

[PATCH libdrm 4/9] tests/hash: style fixes

0; > } > > static int count_entries(HashBucketPtr bucket) > { > -int count = 0; > +int count; > > -for (; bucket; bucket = bucket->next) ++count; > +for (count = 0; bucket; bucket = bucket->next) > +++count; I personally prefer to initi

[PATCH libdrm 5/9] tests/hash: return non-zero on failure

t; srandom(0xbeefbeef); > for (i = 0; i < 1024; i++) > -check_table(table, random(), i); > +ret = check_table(table, random(), i) && ret; > compute_dist(table); > drmHashDestroy(table); > > @@ -223,10 +227,10 @@ int main(vo

[PATCH libdrm 8/9] drm: replace HASH_DEBUG with DEBUG

{ > unsigned long magic; > diff --git a/xf86drmSL.c b/xf86drmSL.c > index acddb54..9bbf8fb 100644 > --- a/xf86drmSL.c > +++ b/xf86drmSL.c > @@ -53,7 +53,6 @@ > #define SL_ENTRY_MAGIC 0x00fab1edLU > #define SL_FREED_MAGIC 0xdecea5edLU > #define SL_MAX_LEVEL 16 &g

[PATCH libdrm 9/9] drm: use correct printf modifiers

ts[hash] = bucket; > -#if DEBUG > printf("Inserted %d at %d/%p\n", key, hash, bucket); > +#if DEBUG > +printf("Inserted %lu at %lu/%p\n", key, hash, bucket); > #endif ^^ This change looks funny in the patch. I assume you just replace the printf call? If that'

[PATCH libdrm 6/9] tests/random: extract test out of xf86drmRandom.c

> - > -state = drmRandomCreate(seed); > -initial = drmRandom(state); > -++count; > -while (initial != drmRandom(state)) { > - if (!++count) break; > -} > -printf("With seed of %10lu, period = %10lu (0x%08lx)\n", > -s

[PATCH libdrm 7/9] tests/random: return non-zero on test failure

"*INCORRECT*" : "CORRECT"); > +ret ? "*INCORRECT*" : "CORRECT"); > drmRandomDestroy(state); > > printf("Checking periods...\n"); > @@ -123,5 +125,5 @@ int main(void) > check_period(2); > check

[PATCH libdrm 2/3] tests/drmsl: Extract tests out of xf86drmSL.c

v2: merge tests creation and xf86drmSL cleanup rename tests/drmsltest -> tests/drmsl move the test out of libudev test block Signed-off-by: Jan Vesely --- Hi Emil, I know you send your R-b on the earlier version, but I thought the changes were big enough to send v2. I modeled it af

[PATCH libdrm v3 1/3] drmSL: Fix neighbor lookup

. v2: zero the update array instead of checking the return value. SLLocate returns NULL both on failure and if the element is greater than everything in the list v3: Improve commit message Signed-off-by: Jan Vesely Acked-by: Emil Velikov --- sorry for spamming, just realized it might be a

[PATCH libdrm 0/9] Rework remaining tests

gards, jan > > > -Emil > > ___ > dri-devel mailing list > dri-devel at lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel -- Jan Vesely -- next part -- A non-text attachment was scru

[libdrm][PATCH 1/2] random: Use unsigned long for seed

This is more consistent with the rest, and avoids potential undefined behavior (signed overflow) in drmRandom() Signed-off-by: Jan Vesely --- xf86drmRandom.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/xf86drmRandom.c b/xf86drmRandom.c index ecab9e2

[libdrm][PATCH 2/2] Fix gcc -Wextra warnings

Signed-off-by: Jan Vesely --- tests/vbltest/vbltest.c | 3 ++- xf86drm.c | 4 ++-- xf86drmMode.c | 2 +- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/tests/vbltest/vbltest.c b/tests/vbltest/vbltest.c index cdc1ef6..6e13c57 100644 --- a/tests/vbltest

[libdrm][PATCH 1/2] random: Use unsigned long for seed

On Mon, 2015-02-09 at 15:11 -0800, Ian Romanick wrote: > On 02/09/2015 01:39 PM, Jan Vesely wrote: > > This is more consistent with the rest, and avoids potential undefined > > behavior (signed overflow) in drmRandom() > > > > Signed-off-by: Jan Vesely > &

[libdrm][PATCH v2 1/2] random: Use unsigned long for seed

v2: Remove unrelated change in main() This is more consistent with the rest, and avoids potential undefined behavior (signed overflow) ind drmRandom() Signed-off-by: Jan Vesely --- xf86drmRandom.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/xf86drmRandom.c

[libdrm][PATCH 2/2] Fix gcc -Wextra warnings

On Mon, 2015-02-09 at 23:32 +, Emil Velikov wrote: > On 9 February 2015 at 21:39, Jan Vesely wrote: > > Signed-off-by: Jan Vesely > Nice one Jan. I've sent similar fixes for drmOpenDevice and > drmGetStats a few days ago. > > Considering you drop the last hunk tha

[libdrm][PATCH 3/2] Fix always true comparison.

The only user I found is xserver, it can return -1 under certain conditions. So check for -1 explicitly. Signed-off-by: Jan Vesely --- I could not find whether it's actually legal to return encoded negative values in get_perm. This is a quick fix to detect the one case that I found. xf86

[libdrm][PATCH 2/2] Fix gcc -Wextra warnings

On Tue, 2015-02-10 at 00:27 +, Emil Velikov wrote: > On 10 February 2015 at 00:02, Jan Vesely wrote: > > On Mon, 2015-02-09 at 23:32 +, Emil Velikov wrote: > >> On 9 February 2015 at 21:39, Jan Vesely wrote: > >> > Signed-off-by: Jan Vesely > >> Ni

[PATCH 4/4] xf86drm: Unconditionally clear ioctl structs

CTX, &map)) > @@ -2182,6 +2221,7 @@ int drmGetMap(int fd, int idx, drm_handle_t *offset, > drmSize *size, > { > drm_map_t map; > > +memclear(map); > map.offset = idx; > if (drmIoctl(fd, DRM_IOCTL_GET_MAP, &map)) > return -errno; > @@ -2

VM on GPUs

through the code and comments. thank you, Jan [0]http://developer.amd.com/resources/documentation-articles/developer-guides-manuals/ [1]http://lists.freedesktop.org/archives/dri-devel/2014-May/058858.html -- Jan Vesely -- next part -- A non-text attachment was scrubbed

VM on GPUs

idea how much worse it gets (relatively to non-snoop access)? thanks again, jan On Fri, 2015-02-20 at 17:19 -0500, Alex Deucher wrote: > On Fri, Feb 20, 2015 at 12:35 PM, Jan Vesely > wrote: > > Hello radeon devs, > > > > I have been trying to find out more about VM impl

VM on GPUs

Hi, thank you. I found a presentation on AMD APUs that mentions throughtput differences between different types of memory. This information helps me a lot. thanks again, Jan On Sat, 2015-02-21 at 10:24 -0500, Alex Deucher wrote: > On Fri, Feb 20, 2015 at 7:21 PM, Jan Vesely wrote: >

[PATCH 00/04 libdrm] The rocky road to building with -Wextra

ribed to the list, but I somehow missed the series. The changes are pretty straightforward. You can add Reviewed-by: Jan Vesely I'll try to find some time to take a look at the other series too. jan > > Thank > Emil > > [1] http://lists.freedesktop.org/archives/dri-devel/20

[PATCH libdrm 00/04] Silence compiler warnings

Hi, you can add Reviewed-by: Jan Vesely to 1,2, and 4. I think 3 needs someone from exynos to say whether the function should not be used somewhere (just to be on the safe side). jan On Mon, 2015-02-23 at 14:56 +, Emil Velikov wrote: > Short follow up to my earlier series "The ro

[libdrm][PATCH 3/2] Fix always true comparison.

gentle ping On Mon, 2015-02-09 at 19:10 -0500, Jan Vesely wrote: > The only user I found is xserver, it can return -1 under certain conditions. > So check for -1 explicitly. > > Signed-off-by: Jan Vesely > --- > > I could not find whether it's actually legal to retu

[PATCH libdrm 0/8] Warnings fixes

His series fixes most of the warnings my compiler spits out running make distcheck. Most of the changes do not change behaviour and those the do are in separate patches. After this series I'm left with: 1 -Wempty-body 1 -Wformat 1 -Wpointer-to-int-cast 1 -Wsign-compare

[PATCH libdrm 3/8] Fix type-limits, pointer-arith and sign-compare warnings

Signed-off-by: Jan Vesely --- tests/dristat.c | 4 ++-- tests/getstats.c | 2 -- xf86drmMode.c| 2 +- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/tests/dristat.c b/tests/dristat.c index 449aa24..992ceb4 100644 --- a/tests/dristat.c +++ b/tests/dristat.c @@ -189,9 +189,9

[PATCH libdrm 1/8] Add static qualifier to local functions

Signed-off-by: Jan Vesely --- tests/drmstat.c | 8 tests/kmstest/main.c| 2 +- tests/modeprint/modeprint.c | 18 +- tests/proptest/proptest.c | 2 +- tests/radeon/radeon_ttm.c | 4 ++-- xf86drm.c | 2 +- xf86drmMode.c

[PATCH libdrm 2/8] tests: String literals are const char *

Signed-off-by: Jan Vesely --- tests/kmstest/main.c | 2 +- tests/proptest/proptest.c | 2 +- tests/vbltest/vbltest.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/kmstest/main.c b/tests/kmstest/main.c index d8c6c1f..1d4c63e 100644 --- a/tests/kmstest/main.c

[PATCH libdrm 4/8] xf86drmSL: Fix neighbour printing

Signed-off-by: Jan Vesely --- xf86drmSL.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/xf86drmSL.c b/xf86drmSL.c index acddb54..2160bb8 100644 --- a/xf86drmSL.c +++ b/xf86drmSL.c @@ -266,11 +266,14 @@ int drmSLLookupNeighbors(void *l, unsigned long key

[PATCH libdrm 5/8] Fix aliasing and switch-enum warnings

Signed-off-by: Jan Vesely --- tests/exynos/exynos_fimg2d_test.c | 3 +++ tests/modeprint/modeprint.c | 1 + xf86drmMode.c | 2 +- 3 files changed, 5 insertions(+), 1 deletion(-) diff --git a/tests/exynos/exynos_fimg2d_test.c b/tests/exynos/exynos_fimg2d_test.c index

[PATCH libdrm 8/8] Fix unused function warnings

Signed-off-by: Jan Vesely --- tests/drmstat.c | 9 ++--- xf86drm.c | 8 ++-- 2 files changed, 4 insertions(+), 13 deletions(-) diff --git a/tests/drmstat.c b/tests/drmstat.c index 36cc70d..6502d78 100644 --- a/tests/drmstat.c +++ b/tests/drmstat.c @@ -82,10 +82,12 @@ static void

[PATCH libdrm 7/8] Fix unused, and unused-but-set variables warnings

Signed-off-by: Jan Vesely --- tests/exynos/exynos_fimg2d_test.c | 4 +--- xf86drm.c | 9 ++--- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/tests/exynos/exynos_fimg2d_test.c b/tests/exynos/exynos_fimg2d_test.c index ba8d12c..38ea974 100644 --- a

[PATCH libdrm 6/8] dristat: Handle DRM_CONSISTENT

Signed-off-by: Jan Vesely --- tests/dristat.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/dristat.c b/tests/dristat.c index 992ceb4..cca4b03 100644 --- a/tests/dristat.c +++ b/tests/dristat.c @@ -100,6 +100,7 @@ static void getvm(int fd) case DRM_SHM:typename

[PATCH] drm/nouveau/bios: 0 means success for nvbios_extend

Bugzilla:https://bugs.freedesktop.org/show_bug.cgi?id=89047 CC: David Airlie CC: Ben Skeggs CC: dri-devel at lists.freedesktop.org CC: linux-kernel at vger.kernel.org Signed-off-by: Jan Vesely --- It's needed for 3.19 too drivers/gpu/drm/nouveau/nvkm/subdev/bios/shadow.c | 2 +- dr

[PATCH 1/1] drm/radeon: Fix cleanup error path.

be tricky. regards, Jan On Thu, 2015-03-05 at 11:22 +0100, Maarten Lankhorst wrote: > Hey, > > On 05-03-15 02:13, Jan Vesely wrote: > > please ignore this patch, see bugzilla for details. > Just in case, can you try the patches from > https://bugzilla.kernel.org/show_b

[PATCH 2/2] Fix one warning

ktop.org/archives/dri-devel/2015-February/078171.html > chown_check_return(buf, user, group); > chmod(buf, devmode); > } -- Jan Vesely -- next part -- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature S

[PATCH 2/2] Fix one warning

rInfo is seldom used, maybe we can just do the > 'int' cast at this moment. I will send v2 for this. > > Regards, > Jammy > > -Original Message- > From: Jan Vesely [mailto:jv356 at scarletmail.rutgers.edu] On Behalf Of Jan > Vesely > Sent: Friday, Apr

[PATCH 2/2] Fix one warning (v2)

; > Signed-off-by: Jammy Zhou FWIW Reviewed-by: Jan Vesely Emil, are you OK with this approach? > --- > xf86drm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/xf86drm.c b/xf86drm.c > index 4d67861..4ecb24f 100644 > --- a/xf86drm.c > +++