Re: [PATCH v2 0/9] drm/exynos: misc fixes and more

2017-08-24 Thread Inki Dae
Hi Tobias, Regarding below two patches, I'd like to have more review so I will consider to merge them in next turn. Sorry for this. drm/exynos: introduce BYTE_PITCH capability drm/exynos: add BYTE_PITCH cap for all supported planes Thanks, Inki Dae 2017년 08월 22일 23:19에 Tobias Jakobi 이

[GIT PULL] exynos-drm-fixes

2017-09-20 Thread Inki Dae
Hi Dave, Just several regression fixups. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit 134dd2e616b9cd8300c08cd1b38987ded74f662f: Merge tag 'drm-amdkfd-next-2017-09-02' of git://people.freedesktop.org/~gabbayo/linu

Re: [PATCH] drm: exynos: Use proper macro definition for HDMI_I2S_PIN_SEL_1

2018-02-13 Thread Inki Dae
dmi_reg_writeb(hdata, HDMI_I2S_PIN_SEL_1, HDMI_I2S_SEL_SDATA1(3) Seems you fixed pin_sel_3 field value of I2S_PIN_SEL_1 register. According to datasheet, 0x3 should be set to this field to select SDATA_1 not 0x1. So could you update the description of this patch? Thanks, Inki Dae > +

[GIT PULL] exynos-drm-fixes

2018-02-19 Thread Inki Dae
Hi Dave, Just several fixups - timestamp issue, register definition and setting value, and cleanups - removing unnecessary messages and file. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit

Re: [PATCH] [v2] drm/exynos: g2d: use monotonic timestamps

2018-02-05 Thread Inki Dae
format. Even if > there is something looking at them, it will work just fine with > monotonic times as long as the application only looks at the > relative values between two events. > > Link: https://patchwork.kernel.org/patch/10038593/ > Cc: Tobias Jakobi > Signed-off-by: A

Re: [PATCH 2/4] drm/exynos: fix comparison to bitshift when dealing with a mask

2018-02-05 Thread Inki Dae
CIIMGEFF_PAT_CBCR_MASK((0xff < 13) | (0xff < > 0)) > +#define EXYNOS_CIIMGEFF_PAT_CBCR_MASK((0xff << 13) | (0xff > << 0)) > Oops. Picked it up. Thanks, Inki Dae > /* Real input DMA size register */ > #define EXYNOS_CIREAL_ISIZE_AUTOLOAD_ENABLE (1 <

[GIT PULL] exynos-drm-fixes

2017-07-26 Thread Inki Dae
Hi Dave, Just several regression fixups and trivial cleanups. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit 517069ff6ec0971e0794ab97d4fcfa8b143746e4: Merge branch 'drm-fixes-4.13' of git://people.freedesktop.org/~a

Re: [PATCH 0/7] drm/exynos: panel mode info propagation

2017-07-31 Thread Inki Dae
mand mode). >> The propagation is performed for whole pipeline as every its elements uses >> it. > > Gently ping. Sorry for late. Will review them soon. Thanks, Inki Dae > > Regards > Andrzej > >> >> Regards >> Andrzej >> >> >>

Re: [PATCH 3/7] drm/exynos/dsi: refactor panel detection logic

2017-08-01 Thread Inki Dae
de one, dsi should register > + * TE interrupt handler. > + */ > + if (!(device->mode_flags & MIPI_DSI_MODE_VIDEO)) { > + int ret = exynos_dsi_register_te_irq(dsi, &device->dev); > + > + if (ret) > + return

Re: [PATCH 4/7] drm/exynos: propagate info about command mode from panel

2017-08-01 Thread Inki Dae
tach(dsi->panel, &dsi->connector); > dsi->connector.status = connector_status_connected; > } > + exynos_drm_crtc_get_by_type(drm, EXYNOS_DISPLAY_TYPE_LCD)->i80_mode = > + !(dsi->mode_flags & MIPI_DSI_MODE_VIDEO); No place to use

Re: [PATCH 6/7] drm/exynos/decon5433: use mode info stored in CRTC to detect i80 mode

2017-08-01 Thread Inki Dae
regardless of panel mode. And the subject of this patch doesn't say everything to above changes. Thanks, Inki Dae 2017년 04월 18일 21:40에 Andrzej Hajda 이(가) 쓴 글: > Since panel's mode of work is propagated properly from panel to DECON, > there is no need to use redundant private property

Re: [PATCH 00/14] clean up drm_bridge_add

2017-08-07 Thread Inki Dae
Daniel, please ping~ 2017년 07월 03일 17:42에 Inki Dae 이(가) 쓴 글: > This patch series changes return type of drm_bridge_add > function to void one and also removes unnecessary checking > of the return type from relevant drivers. > > Ps. I had just build test so each maintainer may nee

Re: [PATCH] drm/exynos: forbid creating framebuffers from too small GEM buffers

2017-08-08 Thread Inki Dae
ble to create a framebuffer object from a small buffer and set it to >> the hardware, what results in displaying system memory outside the >> allocated GEM buffer. >> >> Signed-off-by: Marek Szyprowski >> CC: sta...@vger.kernel.org # v4.7+ > > Gentle ping. Applied

[GIT PULL] exynos-drm-fixes

2017-08-09 Thread Inki Dae
Hi Dave, Just one regression patch which fixes displaying issue. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit 5669b9989eaa664cacbad6a85631550bccdad963: Merge branch 'drm-fixes-4.13' of git://people.freedesktop.org/~a

[GIT PULL] exynos-drm-fixes

2017-08-09 Thread Inki Dae
Hi Dave, Just one regression patch which fixes displaying issue. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit 5669b9989eaa664cacbad6a85631550bccdad963: Merge branch 'drm-fixes-4.13' of git://people.freedesktop.org/~a

[PATCH libdrm] exynos: change the license to X11/MIT

2017-08-09 Thread Inki Dae
th me. Signed-off-by: Inki Dae Acked-by: Hyungwon Hwang Acked-by: SooChan Lim Acked-by: Sangjin LEE Acked-by: Boram Park Acked-by: Seung-Woo Kim Acked-by: Joonyoung Shim Acked-by: Emil Velikov --- exynos/exynos_fimg2d.c | 21 + exynos/exynos_fimg2d.h

Re: [PATCH 3/8] drm/exynos: mixer: simplify {vp_video,mixer_graph}_buffer()

2017-08-11 Thread Inki Dae
case DRM_FORMAT_XRGB: > case DRM_FORMAT_ARGB: > + default: > fmt = MXR_FORMAT_ARGB; > break; > - > - default: > - DRM_DEBUG_KMS("pixelformat unsupported by mixer\n"); > - return; This change

Re: [PATCH 4/8] drm/exynos: mixer: remove src offset from mixer_graph_buffer()

2017-08-11 Thread Inki Dae
2017년 08월 09일 20:48에 Tobias Jakobi 이(가) 쓴 글: > We always translate the dma address such that the offsets of > the source image are zero. Hence we can remove manipulation of > the MXR_GRAPHIC_SXY(win) register. > > We leave the register defines (in regs_mixer.h) in place, since > they document th

Re: [PATCH 5/8] drm/exynos: introduce BYTE_PITCH capability

2017-08-11 Thread Inki Dae
2017년 08월 09일 20:48에 Tobias Jakobi 이(가) 쓴 글: > In some of drivers we compute something like 'pitch / cpp' at some > point, silently assuming that the pitch (which is in bytes) is > divisible by the buffer's cpp. This is not always true, in particular > DRM core does not check for pitch alignment

Re: [PATCH v5 0/8] Exynos DRM: rewrite IPP subsystem and userspace API

2017-11-08 Thread Inki Dae
Hi Marek, I checked style warning of this patch series using checkpatch.pl before merging them but the script says many warnings. I will comment this. Thanks, Inki Dae 2017년 11월 08일 18:41에 Marek Szyprowski 이(가) 쓴 글: > Dear all, > > This patchset performs complete rewrite of Exyno

Re: [PATCH v5 2/8] drm/exynos: ipp: Add IPP v2 framework

2017-11-08 Thread Inki Dae
m/exynos_drm.h:387: + DRM_EXYNOS_IPP_GET_RESOURCES, struct drm_exynos_ioctl_ipp_get_res) WARNING: line over 80 characters #1516: FILE: include/uapi/drm/exynos_drm.h:391: + DRM_EXYNOS_IPP_GET_LIMITS, struct drm_exynos_ioctl_ipp_get_limits) total: 0 errors, 22 warn

Re: [PATCH v5 4/8] drm/exynos: gsc: Convert driver to IPP v2 core API

2017-11-08 Thread Inki Dae
:1158: + DRM_EXYNOS_IPP_CAP_SCALE | DRM_EXYNOS_IPP_CAP_CONVERT, WARNING: Missing a blank line after declarations #3248: FILE: drivers/gpu/drm/exynos/exynos_drm_gsc.c:1308: + int ret = clk_prepare_enable(ctx->clocks[i]); + if (ret) { Thanks, I

Re: [PATCH v5 RESEND 5/8] drm/exynos: fimc: Convert driver to IPP v2 core API

2017-11-08 Thread Inki Dae
0 characters #3098: FILE: drivers/gpu/drm/exynos/exynos_drm_fimc.c:1126: + DRM_EXYNOS_IPP_CAP_SCALE | DRM_EXYNOS_IPP_CAP_CONVERT, Thanks, Inki Dae 2017년 11월 08일 21:00에 Marek Szyprowski 이(가) 쓴 글: > This patch adapts Exynos DRM FIMC driver to new IPP v2 core API

Re: [PATCH v5 6/8] drm/exynos: Add driver for Exynos Scaler module

2017-11-08 Thread Inki Dae
rmats; WARNING: line over 80 characters #698: FILE: drivers/gpu/drm/exynos/exynos_drm_scaler.c:496: + scaler->clock[i] = devm_clk_get(dev, scaler->scaler_data->clk_name[i]); Thanks, Inki Dae 2017년 11월 08일 18:41에 Marek Szyprowski 이(가) 쓴 글: > From: Andrzej Pietrasie

Re: [PATCH v2 06/15] drm/exynos: Use drm_fb_helper_lastclose() and _poll_changed()

2017-11-09 Thread Inki Dae
ed callback. >> >> Cc: Inki Dae >> Cc: Joonyoung Shim >> Cc: Seung-Woo Kim >> Cc: Kyungmin Park >> Signed-off-by: Noralf Trønnes >> --- >> drivers/gpu/drm/exynos/exynos_drm_drv.c | 8 ++-- >> drivers/gpu/drm/exynos/ex

[GIT PULL] exynos-drm-next-v2

2017-11-09 Thread Inki Dae
. [1] https://www.tizen.org/ Thanks, Inki Dae The following changes since commit d65d31388a23b14df9494135ad6c6549a59a3caa: Merge tag 'drm-misc-next-fixes-2017-11-07' of git://anongit.freedesktop.org/drm/drm-misc into drm-next (2017-11-08 05:22:49 +1000) are available in the git reposit

Re: [PATCH] drm/exynos: gem: Drop NONCONTIG flag for buffers allocated without IOMMU

2017-11-09 Thread Inki Dae
* anyway, so drop EXYNOS_BO_NONCONTIG flag > + */ > + if (!is_drm_iommu_supported(dev)) > + flags &= ~EXYNOS_BO_NONCONTIG; So this could be a tempararily solution until the new flag is added, and you may need to modify above

Re: [PATCH] drm/exynos: gem: Drop NONCONTIG flag for buffers allocated without IOMMU

2017-11-12 Thread Inki Dae
Hi Marek, 2017년 11월 10일 16:35에 Marek Szyprowski 이(가) 쓴 글: > Dear Inki, > > On 2017-11-10 04:04, Inki Dae wrote: >> 2017년 11월 01일 01:28에 Marek Szyprowski 이(가) 쓴 글: >>> When no IOMMU is available, all GEM buffers allocated by Exynos DRM driver >>> are cont

Re: [PATCH] drm/exynos: gem: Drop NONCONTIG flag for buffers allocated without IOMMU

2017-11-13 Thread Inki Dae
2017년 11월 13일 23:28에 Marek Szyprowski 이(가) 쓴 글: > Hi Inki, > > On 2017-11-13 02:24, Inki Dae wrote: >> Hi Marek, >> >> 2017년 11월 10일 16:35에 Marek Szyprowski 이(가) 쓴 글: >>> Dear Inki, >>> >>> On 2017-11-10 04:04, Inki Dae wrote: >>>

Re: [GIT PULL] exynos-drm-next

2017-11-14 Thread Inki Dae
Hi Dave, 2017년 11월 14일 13:22에 Dave Airlie 이(가) 쓴 글: > On 26 October 2017 at 11:37, Inki Dae wrote: >> Hi Dave, >> >>Improving Exynos DRM HDMI and Mixer drivers and also adding >>HDMI audio support. >> >>Please kindly let me know if there is any

Re: [GIT PULL] exynos-drm-next

2017-11-15 Thread Inki Dae
Hi Daniel, 2017년 11월 15일 19:27에 Daniel Stone 이(가) 쓴 글: > Hi Inki, > > On 15 November 2017 at 01:26, Inki Dae wrote: >> 2017년 11월 14일 13:22에 Dave Airlie 이(가) 쓴 글: >>> On 26 October 2017 at 11:37, Inki Dae wrote: >>>>Ps. we are reviewing IPP v2 dri

Re: [PATCH v2] drm/exynos: gem: Drop NONCONTIG flag for buffers allocated without IOMMU

2017-11-22 Thread Inki Dae
t; + flags &= ~EXYNOS_BO_NONCONTIG; > + DRM_WARN("Non-contiguous allocation is not supported without > IOMMU, falling back to contiguous buffer\n"); WARNING: line over 80 characters I wil change above a warning like below if you are ok,

[PATCH] drm/exynos: remove unnecessary function declaration

2017-11-27 Thread Inki Dae
Removed exynos_drm_get_dma_device funtion declaration on top of exynos_drm_drv.c file. We can remove this declaration by moving the implementation of this function upwards. Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos_drm_drv.c | 44 - 1 file

[PATCH] drm/exynos: remove unnecessary descrptions

2017-11-27 Thread Inki Dae
Removed two descriptions to 'da_start' and 'da_space_size' from exynos_drm_private structure. These members don't exist anymore. Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos_drm_drv.h | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/gpu/dr

Re: [GIT PULL] exynos-drm-next

2017-11-28 Thread Inki Dae
Hi Daniel, 2017년 11월 20일 16:33에 Daniel Vetter 이(가) 쓴 글: > On Wed, Nov 15, 2017 at 10:26:45AM +0900, Inki Dae wrote: >> Hi Dave, >> >> 2017년 11월 14일 13:22에 Dave Airlie 이(가) 쓴 글: >>> On 26 October 2017 at 11:37, Inki Dae wrote: >>>> Hi Dave, >>>&g

Re: [PATCH v2] drm/exynos: mixer: avoid Oops in vp_video_buffer()

2017-11-30 Thread Inki Dae
the only way to identify buffer type would be to check how many buffers are set to exynos_drm_fb object. [1] https://lists.freedesktop.org/archives/dri-devel/2012-April/021812.html Thanks, Inki Dae > } > } else { > luma_addr[1] = 0; > @@ -507,2

Re: [PATCH v3 04/11] drm/exynos: Use drm_fb_helper_lastclose() and _poll_changed()

2017-12-06 Thread Inki Dae
2017년 12월 06일 03:24에 Noralf Trønnes 이(가) 쓴 글: > This driver can use drm_fb_helper_lastclose() as its .lastclose callback. > It can also use drm_fb_helper_output_poll_changed() as its > .output_poll_changed callback. > > Cc: Inki Dae > Cc: Joonyoung Shim > Cc: Seung-Wo

[GIT PULL] exynos-drm-fixes

2017-12-06 Thread Inki Dae
Hi Dave, Just a regression fixup and several cleanups. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit bd3a3a2e92624942a143e485c83e641b2492d828: Merge tag 'drm-misc-fixes-2017-12-06' of git://anongit.freedesktop.o

Re: [PATCH 2/7] drm/exynos: decon5433: Remove unnecessary platform_get_resource() error check

2017-12-18 Thread Inki Dae
2017년 12월 18일 22:02에 Fabio Estevam 이(가) 쓴 글: > From: Fabio Estevam > > devm_ioremap_resource() already checks if the resource is NULL, so > remove the unnecessary platform_get_resource() error check. > > Cc: Inki Dae > Signed-off-by: Fabio Estevam > --- &

[GIT PULL] exynos-drm-next

2018-01-01 Thread Inki Dae
if there is any problem. Happy new year~ Thanks, Inki Dae The following changes since commit 350877626faba5d60cbb8cef2bdeb524212c780b: Merge tag 'drm-intel-next-2017-12-22' of git://anongit.freedesktop.org/drm/drm-intel into drm-next (2017-12-28 05:20:31 +1000) are available

Re: [PATCH 03/19] drm/exynos: Use the alpha format helper

2018-01-11 Thread Inki Dae
2018년 01월 09일 19:56에 Maxime Ripard 이(가) 쓴 글: > Now that the core has a drm format helper to tell if a format embeds an > alpha component in it, let's use it. > > Cc: Inki Dae > Cc: Joonyoung Shim > Cc: Kyungmin Park > Cc: Seung-Woo Kim > Signed-off-by: Maxim

[PATCH] drm/exynos/dsi: use core helper to create DSI packet

2016-03-02 Thread Inki Dae
acket.payload_length || xfer->rx_len) > return; > > xfer->result = 0; > @@ -1189,10 +1186,11 @@ static bool exynos_dsi_transfer_finish(struct > exynos_dsi *dsi) > spin_unlock_irqrestore(&dsi->transfer_lock, flags); > > dev_dbg(dsi->dev, > - "> xfer %p, tx_len %u, tx_done %u, rx_len %u, rx_done %u\n", > - xfer, xfer->tx_len, xfer->tx_done, xfer->rx_len, > xfer->rx_done); > + "> xfer %p, tx_len %lu, tx_done %u, rx_len %u, rx_done %u\n", > + xfer, xfer->packet.payload_length, xfer->tx_done, > xfer->rx_len, %zu would be required for xfer->packet.payload_length which has size_t type. Thanks, Inki Dae

[GIT PULL] exynos-drm-next for 4.6

2016-03-02 Thread Inki Dae
removing #ifdef ~ #endif things. - Configure DMA-mapping address space common to Exynos DRM devices in more generic without any hacks. - some fixups and cleanups. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit

[GIT PULL] exynos-drm-next for 4.6

2016-03-13 Thread Inki Dae
for Tizen platform. All applications - who want to use dma buffer - use this module to allocate dma buffer through DRM GEM. Kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit 550e3b23a53c88adfa46e64f9d442743e65d47da: Merge branch 

[PATCH v8 01/17] drm: exynos: dp: convert to drm bridge mode

2016-03-23 Thread Inki Dae
t; > Tested-by: Javier Martinez Canillas > Signed-off-by: Yakir Yang Acked-by: Inki Dae Thanks, Inki Dae > --- > Changes in v8: None > Changes in v7: None > Changes in v6: > - Fix the wrong code in previous series, and test on Samsung snow Chromebook > su

Who is going to merge it [Was: Re: [PATCH v14 0/17] Add Analogix Core Display Port Driver]

2016-03-23 Thread Inki Dae
late. Dave had already pull-request. To Ajay, How about adding you as a drm bridge maintainer? DRM SoC driver maintainers would need a person who can manage the drm bridge relevant pathes. Thanks, Inki Dae > > Thanks > Heiko > >

Who is going to merge it [Was: Re: [PATCH v14 0/17] Add Analogix Core Display Port Driver]

2016-03-23 Thread Inki Dae
2016년 03월 23일 07:52에 Heiko Stübner 이(가) 쓴 글: > Am Mittwoch, 23. März 2016, 07:44:59 schrieb Inki Dae: >> + Ajay kumar with Samsung email >> >> Hi, >> >> 2016년 03월 23일 07:12에 Heiko Stübner 이(가) 쓴 글: >>> Hi, >>>

Who is going to merge it [Was: Re: [PATCH v14 0/17] Add Analogix Core Display Port Driver]

2016-03-23 Thread Inki Dae
2016년 03월 23일 08:39에 Russell King - ARM Linux 이(가) 쓴 글: > On Wed, Mar 23, 2016 at 08:09:33AM +0900, Inki Dae wrote: >> In this case, someone else may send an email again like you "who is going to >> merge?" >> That would be why we need a maintai

[PATCH 0/7] drm/exynos: HDMI and DECON fixes and enhancements

2016-03-24 Thread Inki Dae
by the way, they were posted about 5 months ago :) Oops, really sorry. Will have a review ASAP. Thanks, Inki Dae > - IOMMU patches by Marek (for some mysterious reason HDMI path on 5433 > works only with IOMMU enabled), > - latest exynos-drm-next patches. >

[PATCH 0/7] drm/exynos: HDMI and DECON fixes and enhancements

2016-03-24 Thread Inki Dae
2016년 03월 24일 10:07에 Inki Dae 이(가) 쓴 글: > Hi Andrzej, > > 2016년 03월 23일 22:15에 Andrzej Hajda 이(가) 쓴 글: >> Hi Inki, >> >> This set of patches provides set of different fixes and enhancements >> for DECON -> HDMI path. It is base

[RFC 1/6] drm/fence: add FENCE_FD property to planes

2016-03-24 Thread Inki Dae
sync interface used for DMA device as a Linux standard? I don't see why Android specific things are spreaded into Linux DRM. Thanks, Inki Dae > > Signed-off-by: Gustavo Padovan > --- > drivers/gpu/drm/drm_atomic.c| 4 > drivers/gpu/drm/drm_atomic_help

[RFC 0/6] drm/fences: add in-fences to DRM

2016-03-24 Thread Inki Dae
ere anyone who can explan why Android specific thing is tried to spread into Linux DRM? Was there any consensus to use Android sync driver - which uses explicit sync interfaces - as Linux standard? Thanks, Inki Dae > > /** > * struct fence_collection - aggregate fences together &g

[RFC 0/6] drm/fences: add in-fences to DRM

2016-03-25 Thread Inki Dae
Hi Guestavo, 2016년 03월 24일 23:39에 Gustavo Padovan 이(가) 쓴 글: > Hi Inki, > > 2016-03-24 Inki Dae : > >> Hi, >> >> 2016년 03월 24일 03:47에 Gustavo Padovan 이(가) 쓴 글: >>> From: Gustavo Padovan >>> >>> Hi, >&

[RFC 0/6] drm/fences: add in-fences to DRM

2016-03-25 Thread Inki Dae
2016년 03월 25일 00:40에 Rob Clark 이(가) 쓴 글: > On Thu, Mar 24, 2016 at 4:18 AM, Inki Dae wrote: >> Hi, >> >> 2016년 03월 24일 03:47에 Gustavo Padovan 이(가) 쓴 글: >>> From: Gustavo Padovan >>> >>> Hi, >>> >>

[patch 2/2] drm/exynos: mic: remove some dead code

2016-03-25 Thread Inki Dae
val &= ~(MIC0_RGB_MUX | MIC0_I80_MUX | MIC0_ON_MUX); > > regmap_write(mic->sysreg, DSD_CFG_MUX, val); > - if (ret) > - DRM_ERROR("mic: Failed to read system register\n"); I think we missed to keep return value from regmap_write function, ret =

[RFC 0/6] drm/fences: add in-fences to DRM

2016-03-28 Thread Inki Dae
Hi Rob and Daniel, 2016년 03월 25일 21:10에 Daniel Stone 이(가) 쓴 글: > Hi all, > > On 25 March 2016 at 11:58, Rob Clark wrote: >> On Thu, Mar 24, 2016 at 7:49 PM, Inki Dae wrote: >>> It's definitely different case. This tries to add new user-space interf

[PATCH 0/3] drm/exynos: Kconfig dependency fixes

2016-03-29 Thread Inki Dae
Hi Javier, Thanks for your patch set. Will merge them if there is no issue. Thanks, Inki Dae 2016년 03월 29일 10:28에 Javier Martinez Canillas 이(가) 쓴 글: > Hello Inki, > > This patch series contains some fixes for the Kconfig symbol dependencies > of the Exynos DRM

[RFC 0/6] drm/fences: add in-fences to DRM

2016-03-29 Thread Inki Dae
Hi Daniel, 2016년 03월 28일 22:26에 Daniel Stone 이(가) 쓴 글: > Hi Inki, > > On 28 March 2016 at 02:26, Inki Dae wrote: >> 2016년 03월 25일 21:10에 Daniel Stone 이(가) 쓴 글: >>> Second, really. Vulkan avoids implicit sync entirely, and exposes &

Re: [PATCH] drm: bridge: samsung-dsim: Don't use FORCE_STOP_STATE

2024-01-18 Thread Inki Dae
Really sorry for late. Will pick it up. Thanks, Inki Dae 2024년 1월 9일 (화) 오후 9:50, Daniel Vetter 님이 작성: > On Tue, Jan 09, 2024 at 09:47:20AM +0100, Michael Walle wrote: > > Hi, > > > > > > Inki, are you picking this up? Or if not, who will? > > > > > &g

[GIT PULL] exynos-drm-fixes

2024-01-21 Thread Inki Dae
Hi Dave and Daniel, Just several fixups. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit 0dd3ee31125508cd67f7e7172247f05b7fd1753a: Linux 6.7 (2024-01-07 12:18:38 -0800) are available in the Git repository at: git

Inquiry regarding the use of the dim tool

2024-01-21 Thread Inki Dae
a problem where the command `dim push-branch drm-misc-fixes` doesn't seem to work after I merge a patch using the command `cat 1.mbox | dim apply-branch drm-misc-fixes`. [1] https://gitlab.freedesktop.org/freedesktop/freedesktop/-/issues/569 [2] https://drm.pages.freedesktop.org/maintainer-tools/getting-started.html I'm still not quite familiar with using the dim tool. I'm sure there must be some aspects I'm missing. Could I please get some help with this? Thanks, Inki Dae

[GIT PULL RESEND] exynos-drm-fixes

2023-12-06 Thread Inki Dae
Hi Dave and Daniel, Just resending you the previous pull request[1] after resolving the build warning. [1] https://lore.kernel.org/dri-devel/20231120225537.1270358-1-inki@samsung.com/ Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes

[GIT PULL] exynos-drm-next

2023-12-11 Thread Inki Dae
Hi Dave and Daniel, Just one fixup to shutdown relevant issue and two cleanups. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit a2f8994c1001cfa48483a3afa3550016a3ab0a3e: Merge tag 'exynos-drm-next-for-v6.7-rc5

Re: [PATCH v3 08/16] drm/exynos: Convert to platform remove callback returning void

2023-12-11 Thread Inki Dae
From: Uwe Kleine-König > > > Sent: Wednesday, November 29, 2023 1:55 AM > > > To: Inki Dae > > > Cc: linux-samsung-...@vger.kernel.org; Daniel Vetter ; > > > Jingoo Han ; Seung-Woo Kim ; > > > Kyungmin Park ; DRI mailing list > > de...@lists.freed

Re: [PATCH] dt-bindings: display: samsung, exynos-mixer: Fix 'regs' typo

2023-12-13 Thread Inki Dae
2023년 12월 14일 (목) 오전 7:43, Rob Herring 님이 작성: > The correct property name is 'reg' not 'regs'. > Thanks, Inki Dae > Fixes: 68e89bb36d58 ("dt-bindings: display: samsung,exynos-mixer: convert > to dtschema") > Signed-off-by: Rob Herring > --

[PATCH] drm/exynos: fix incorrect type issue

2023-12-14 Thread Inki Dae
Fix incorrect type issue in fimd_commit() of exynos_drm_fimd.c module. Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202312140930.me9ywf8f-...@intel.com/ Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 2 +- 1 file changed, 1 insertion

Re: [PATCH] drm/exynos: fix accidental on-stack copy of exynos_drm_plane

2023-12-14 Thread Inki Dae
se a pointer instead. > > > > Fixes: 6f8ee5c21722 ("drm/exynos: fimd: Make plane alpha configurable") > > Signed-off-by: Arnd Bergmann > > > Reviewed-by: Marek Szyprowski > Thanks, Inki Dae > > > > --- > > drivers/gpu/drm/exynos/exynos

Re: [PATCH] drm: bridge: samsung-dsim: Don't use FORCE_STOP_STATE

2023-12-20 Thread Inki Dae
-by: Michael Walle > >> --- > >> Let me know wether this should be two commits each reverting one, but > >> both > >> commits appeared first in kernel 6.5. > > > > Are there any news? > > Inki, are you picking this up? Or if not, who will? > I can pick it up but it would be better to go to the drm-misc tree. If nobody cares about it then I will pick it up. :) acked-by : Inki Dae Thanks, Inki Dae

Re: [PATCH] drm/exynos: gsc: minor fix for loop iteration in gsc_runtime_resume

2023-12-20 Thread Inki Dae
> > Fixes: 8b7d3ec83aba ("drm/exynos: gsc: Convert driver to IPP v2 core > API") > > Signed-off-by: Fedor Pchelkin > Reviewed-by: Marek Szyprowski > Applied. Thanks, Inki Dae > --- > > drivers/gpu/drm/exynos/exynos_drm_gsc.c | 2 +- > > 1 file

Re: [PATCH 1/4] drm/exynos/vidi: fix memory leak in .get_modes()

2024-06-09 Thread Inki Dae
Hi Jani Nikula, The patch(1/4) has been applied to the -fixes branch, and the other three patches(2/4 ~ 4/4) have been applied to the -next branch. Thanks, Inki Dae 2024년 5월 30일 (목) 오후 7:02, Jani Nikula 님이 작성: > > The duplicated EDID is never freed. Fix it. > > Cc: sta...@vge

[GIT PULL] exynos-drm-fixes

2024-06-10 Thread Inki Dae
Hi Dave and Daniel, Two fixups - one for an regeression issue and other for memory leak - and one cleanup. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit eb55943aab89be99a26e34fc2175ebb3583a2778: Merge tag 'drm-misc-next-

Re: [PATCH 04/11] drm/exynos: hdmi: convert to struct drm_edid

2024-06-10 Thread Inki Dae
hysical address gets invalidated > when the EDID could not be read. > > Signed-off-by: Jani Nikula > > --- > > Cc: Inki Dae > Cc: Seung-Woo Kim > Cc: Kyungmin Park > Cc: Krzysztof Kozlowski > Cc: Alim Akhtar > Cc: linux-arm-ker...@lists.infradead.org >

drm/exynos: Unreference fb in exynos_disable_plane()

2012-11-21 Thread Inki Dae
Signed-off-by: YoungJun Cho Signed-off-by: Inki Dae Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_plane.c | 12 +++- 1 files changed, 11 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_plane.c b/drivers/gpu/drm/exynos/exynos_drm_plane

[PATCH] drm/exynos: fix memory leak: free EDID block

2012-11-21 Thread Inki Dae
Ok, I modifed the subject of your patch like below and applied. drm/exynos: fix memory lean to EDID block Thanks, Inki Dae 2012/11/20 Egbert Eich > drm_get_edid() returns a pointer to an EDID block. The caller > is responsible to free this pointer itself. > Here the pointer gets as

[PATCH v1] drm: exynos: fix for loosing display mode header during mode adjustment

2012-11-21 Thread Inki Dae
Applied. Thanks, Inki Dae 2012/11/20 Rahul Sharma > This patch is to preserve the display mode header during the mode > adjustment. > Display mode header is overwritten with the adjusted mode header which is > throwing the stack dump. > > Signed-off-by: Rahul Sharma > -

[PATCH v2] drm/exynos: remove 'pages' and 'page_size' elements in exynos gem buffer

2012-11-21 Thread Inki Dae
Applied. Thanks, Inki Dae 2012/11/20 Prathyush K > Changelog v2: > > Removed redundant check for invalid sgl. > Added check for valid page_offset in the beginning of > exynos_drm_gem_map_buf. > > Changelog v1: > > The 'pages' structure is not required

[GIT PULL] exynos-drm-next

2012-11-21 Thread Inki Dae
exynos: add ipp subsystem drm/exynos: add fimc ipp driver drm/exynos: add rotator ipp driver drm/exynos: add gsc ipp driver but they didn't reviewed enough yet so may not be merged to -next this time. Thanks, Inki Dae 2012/11/20 Inki Dae > Hi Dave, > > Thi

[PATCH] drm/exynos: use sgt instead of pages for framebuffer address

2012-11-22 Thread Inki Dae
Right, I missed. Thanks, Inki Dae > -Original Message- > From: Prathyush K [mailto:prathyush.k at samsung.com] > Sent: Thursday, November 22, 2012 3:49 PM > To: dri-devel at lists.freedesktop.org > Cc: inki.dae at samsung.com > Subject: [PATCH] drm/exynos: use sgt in

[PATCH 1/1] drm/exynos: Fix potential NULL pointer dereference in exynos_drm_encoder.c

2012-11-22 Thread Inki Dae
> -Original Message- > From: Sachin Kamat [mailto:sachin.kamat at linaro.org] > Sent: Thursday, November 22, 2012 3:13 PM > To: Inki Dae > Cc: dri-devel at lists.freedesktop.org; jy0922.shim at samsung.com; > patches at linaro.org > Subject: Re: [PATCH 1/1] drm/exyno

[PATCH 1/1] drm/exynos: Fix potential NULL pointer dereference in exynos_drm_encoder.c

2012-11-22 Thread Inki Dae
> -Original Message- > From: Sachin Kamat [mailto:sachin.kamat at linaro.org] > Sent: Thursday, November 22, 2012 5:19 PM > To: Inki Dae > Cc: dri-devel at lists.freedesktop.org; jy0922.shim at samsung.com; > patches at linaro.org > Subject: Re: [PATCH 1/1] drm/exyno

[PATCH 0/2] drm: exynos: hdmi: sending AVI and AUI info frames

2012-11-23 Thread Inki Dae
s-drm-fixes branch of > git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git > > Please rebase these patches to be based on exynos-drm-next. These should go to -next. Thanks, Inki Dae > Rahul Sharma (1): > drm: exynos: compose and send avi and aui info frames

[PATCH 1/5] drm/exynos: Use devm_clk_get in exynos_drm_fimd.c

2012-11-23 Thread Inki Dae
platform_device *pdev) > > err_clk: > clk_disable(ctx->lcd_clk); > - clk_put(ctx->lcd_clk); clk_disable shouldn't be called here so let's cleanup this also to reduce unnecessary cleanup commits. > > err_bus_clk: > clk_disable(ctx->bus_clk);

[PATCH 2/5] drm/exynos: Use devm_gpio_request in exynos_hdmi.c

2012-11-23 Thread Inki Dae
lease re-send updated patches? You've been submitting patches into too small pieces. Because they are trivial enough and in the same context, please merge this kind of patches as long as they are related with the same class or topics. I think you can combine them. :) Thanks, Inki Dae > e

[PATCH 3/5] drm/exynos: Use devm_clk_get in exynos_mixer.c

2012-11-23 Thread Inki Dae
> -Original Message- > From: Sachin Kamat [mailto:sachin.kamat at linaro.org] > Sent: Friday, November 23, 2012 12:42 PM > To: dri-devel at lists.freedesktop.org > Cc: inki.dae at samsung.com; jy0922.shim at samsung.com; airlied at linux.ie; > sachin.kamat at linaro.org; patches at linaro

[PATCH 4/5] drm/exynos: Use devm_clk_get in exynos_drm_g2d.c

2012-11-23 Thread Inki Dae
Applied. Thanks, Inki Dae > -Original Message- > From: Sachin Kamat [mailto:sachin.kamat at linaro.org] > Sent: Friday, November 23, 2012 12:42 PM > To: dri-devel at lists.freedesktop.org > Cc: inki.dae at samsung.com; jy0922.shim at samsung.com; airlied at linux.ie; &g

[PATCH 5/5] drm/exynos: Fix potential NULL pointer dereference

2012-11-23 Thread Inki Dae
This was my missing point. Applied. Thanks, Inki Dae > -Original Message- > From: Sachin Kamat [mailto:sachin.kamat at linaro.org] > Sent: Friday, November 23, 2012 12:42 PM > To: dri-devel at lists.freedesktop.org > Cc: inki.dae at samsung.com; jy0922.shim at samsung.

[PATCH Resend] drm/exynos: Use devm_clk_get in exynos_mixer.c

2012-11-23 Thread Inki Dae
Applied. Thanks, Inki Dae > -Original Message- > From: Sachin Kamat [mailto:sachin.kamat at linaro.org] > Sent: Friday, November 23, 2012 5:43 PM > To: dri-devel at lists.freedesktop.org > Cc: inki.dae at samsung.com; sachin.kamat at linaro.org; patches at linaro.org &g

[PATCH Resend] drm/exynos: Use devm_* APIs in exynos_hdmi.c

2012-11-23 Thread Inki Dae
Applied. Thanks, Inki Dae > -Original Message- > From: Sachin Kamat [mailto:sachin.kamat at linaro.org] > Sent: Friday, November 23, 2012 5:43 PM > To: dri-devel at lists.freedesktop.org > Cc: inki.dae at samsung.com; sachin.kamat at linaro.org; patches at linaro.org &g

[PATCH Resend] drm/exynos: Use devm_clk_get in exynos_drm_fimd.c

2012-11-23 Thread Inki Dae
The subject mentions just only 'use devm_clk_get in exynos_dev_fimd.c' but this patch removes unnecessary clk_disable calls also. Just separate this patch into two as you mentioned. For this, already applied old one. So could you send another one? Sorry for inconvenient. :) Thanks

[PATCH] drm: exynos: hdmi: sending AVI and AUI info frames

2012-11-23 Thread Inki Dae
Sorry but could you re-send this one more time? below is my comment. Thanks, Inki Dae > -Original Message- > From: Rahul Sharma [mailto:rahul.sharma at samsung.com] > Sent: Friday, November 23, 2012 6:17 PM > To: dri-devel at lists.freedesktop.org > Cc: airlied at redhat.c

[PATCH 1/1] drm/exynos: remove unnecessary clk_disable calls in exynos_drm_fimd.c

2012-11-24 Thread Inki Dae
0, "drm_fimd", ctx); > if (ret) { > dev_err(dev, "irq request failed.\n"); > - goto err_clk; > + return ret; > } > > ctx->vidcon0 = pdata->vidcon0; > @@ -9

[PATCH v2] drm: exynos: hdmi: sending AVI and AUI info frames

2012-11-24 Thread Inki Dae
Let's update one more time. Below is my comments. > -Original Message- > From: Rahul Sharma [mailto:rahul.sharma at samsung.com] > Sent: Friday, November 23, 2012 9:04 PM > To: dri-devel at lists.freedesktop.org > Cc: inki.dae at samsung.com; kgene.kim at samsung.com; r.sh.open at gmail.co

[RFC 1/4] drm/exynos: add ipp subsystem

2012-11-24 Thread Inki Dae
lease, describe your codes as much as possible. Thanks, Inki Dae > -Original Message- > From: Eunchul Kim [mailto:chulspro.kim at samsung.com] > Sent: Monday, October 29, 2012 10:11 PM > To: dri-devel at lists.freedesktop.org; inki.dae at samsung.com > Cc: jy0.jeon at samsun

[PATCH v3] drm: exynos: hdmi: sending AVI and AUI info frames

2012-11-26 Thread Inki Dae
Please, comply with patch format next time. Applied. Thank, Inki Dae > -Original Message- > From: Rahul Sharma [mailto:rahul.sharma at samsung.com] > Sent: Monday, November 26, 2012 2:23 PM > To: dri-devel at lists.freedesktop.org > Cc: inki.dae at samsung.com; kgene.kim

[PATCH Resend] drm/exynos: Use devm_clk_get in exynos_drm_fimd.c

2012-11-26 Thread Inki Dae
Applied. Thanks, Inki Dae > -Original Message- > From: Sachin Kamat [mailto:sachin.kamat at linaro.org] > Sent: Monday, November 26, 2012 1:17 PM > To: dri-devel at lists.freedesktop.org > Cc: inki.dae at samsung.com; sachin.kamat at linaro.org; patches at > linaro

[GIT PULL v2] exynos-drm-next

2012-11-29 Thread Inki Dae
know. Thanks, Inki Dae The following changes since commit 660c51e92f5357f351b483fa9d82451344ed25a4: drm/exynos: add exynos drm specific fb_mmap function (2012-11-29 03:30:38 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git exyno

[GIT PULL v2] exynos-drm-next

2012-11-30 Thread Inki Dae
2012/11/29 Daniel Vetter > On Thu, Nov 29, 2012 at 1:11 PM, Inki Dae wrote: > > - add sending AVI and AVI info frames. > > . this adds some codes for composing AVI and AUI info frames > > and send them every VSYNC for HDMI Certification. > > Imo we have a

[RFC v1] drm: add reference count of gem object name

2012-11-30 Thread Inki Dae
count = 0(released) b. obj_refcount = 0(released) once name_ref_count = 0 There may be my missing point so please give me any advice. Thanks, Inki Dae Signed-off-by: Inki Dae --- drivers/gpu/drm/drm_gem.c | 41 ++--- include/drm/drmP.h| 12

[RFC v1] drm: add reference count of gem object name

2012-11-30 Thread Inki Dae
2012/11/30 Inki Dae > Hello, all. > > This patch introduces reference count of gem object name and resolves > the below issue. > > In case that proces A shares its own gem object with process B, > process B opens a gem object name from process A to get its own > gem

[RFC v1] drm: add reference count of gem object name

2012-12-01 Thread Inki Dae
sn't released instead of handle. And this is the reason that we need this patch. Thanks, Inki Dae > > Cheers, Daniel > > On Fri, Nov 30, 2012 at 10:10 AM, Inki Dae wrote: > > Hello, all. > > > > This patch introduces reference count of gem object name and reso

<    5   6   7   8   9   10   11   12   13   14   >