2017년 01월 16일 18:37에 Andrzej Hajda 이(가) 쓴 글:
> On 16.01.2017 10:13, Inki Dae wrote:
>> This patch removes exynos_drm_crtc_cancel_page_flip call
>> when drm is closed because at that time, events will be released
>> by drm_events_release func
2017년 01월 16일 20:22에 Tobias Jakobi 이(가) 쓴 글:
> Inki Dae wrote:
>> This patch relpaces specific atomic commit function
>> with atomic helper commit one, which also includes
>> atomic_commit_tail callback for Exynos SoC becasue
>> crtc devices on Exynos SoC use
2017년 01월 17일 05:34에 Laurent Pinchart 이(가) 쓴 글:
> Hi Inki,
>
> Thank you for the patch.
>
> On Monday 16 Jan 2017 18:13:22 Inki Dae wrote:
>> This patch relpaces specific atomic commit function
>> with atomic helper commit one, which also includes
>> atomic_co
2017년 01월 17일 04:08에 Gustavo Padovan 이(가) 쓴 글:
> Hi Inki,
>
> 2017-01-16 Inki Dae :
>
>> This patch relpaces specific atomic commit function
>> with atomic helper commit one, which also includes
>> atomic_commit_tail callback for Exynos SoC becasue
>> c
Hi Andrzej,
2017년 01월 17일 23:15에 Andrzej Hajda 이(가) 쓴 글:
> Hi Inki,
>
> This is my final fight with DECON_UPDATE issues (I hope). My two previous
> patches
> fixed problems on panel path, this patchset fixes also TV path.
> The root cause of all evil was in incorrect DECON_CMU programming.
>
>
Hi Laurent,
2017년 01월 17일 18:17에 Laurent Pinchart 이(가) 쓴 글:
> Hi Inki,
>
> Thank you for the patch.
>
> On Monday 16 Jan 2017 18:13:22 Inki Dae wrote:
>> This patch relpaces specific atomic commit function
>> with atomic helper commit one, which also includes
>>
ivial things
- revive existing comment which explains why plane commit should be
called after crtc and encoder device are enabled.
Signed-off-by: Inki Dae
Reviewed-by: Gustavo Padovan
---
drivers/gpu/drm/exynos/exynos_drm_crtc.c | 10 ++-
drivers/gpu/drm/exynos/exynos_drm_drv.c
2017년 01월 19일 20:53에 Gustavo Padovan 이(가) 쓴 글:
> Hi Inki,
>
> 2017-01-19 Inki Dae :
>
>> This patch replaces specific atomic commit function
>> with atomic helper commit one.
>>
>> For this, it removes existing atomic commit function
>> and rele
just for review not merge. So if
there is any critical problem with this patch, I will stop to merge it. This
would be my role, maintainer.
Thanks.
>
> The commit message looks much better now. Still some spelling issues remain:
> implemention -> implementation
>
>
> With b
Applied including other two patches.
Thanks.
2017년 01월 17일 23:15에 Andrzej Hajda 이(가) 쓴 글:
> decon_commit is called just after reset so video is disabled anyway.
>
> Signed-off-by: Andrzej Hajda
> ---
> drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 2 --
> 1 file changed, 2 deletions(-)
>
>
2017년 01월 20일 22:05에 Tobias Jakobi 이(가) 쓴 글:
> Inki Dae wrote:
>> Hi Tobias,
>>
>> 2017년 01월 19일 21:49에 Tobias Jakobi 이(가) 쓴 글:
>>> What about Laurent's comment stating that drm_atomic_helper_commit() is
>>> broken at the moment? Shouldn't there
2017년 01월 23일 17:22에 Joonyoung Shim 이(가) 쓴 글:
> Hi Tobias,
>
> On 01/21/2017 01:05 AM, Tobias Jakobi wrote:
>> Hello Joonyoung,
>>
>>
>> Joonyoung Shim wrote:
>>> Hi Tobias,
>>>
>>> On 01/19/2017 10:16 PM, Tobias Jakobi wrote:
Hello Joonyoung,
Joonyoung Shim wrote:
> Hi Tobias
2017년 01월 21일 01:54에 Tobias Jakobi 이(가) 쓴 글:
> From: Dan Carpenter
>
> We were trying to print an error message if we timed out here, but the
> loop actually ends with "tries" set to UINT_MAX and not zero. Fix this
> by changing from tries-- to --tries.
Sorry but I already know this patch fro
2017년 01월 23일 23:55에 Sean Paul 이(가) 쓴 글:
>
>
> As of now, I don't see any case. even without Maarten's patch set, it
> works well - actually, I had a test with atomic test app more than 10
> hours..
Can you provide this test application? In particular I'm asking this
beca
2017년 01월 23일 18:41에 Chris Wilson 이(가) 쓴 글:
> On Mon, Jan 23, 2017 at 06:32:16PM +0900, Inki Dae wrote:
>>
>>
>> 2017년 01월 21일 01:54에 Tobias Jakobi 이(가) 쓴 글:
>>> From: Dan Carpenter
>>>
>>> We were trying to print an error message if we timed out
2016ë
03ì 29ì¼ 22:23ì Rob Clark ì´(ê°) ì´ ê¸:
> On Mon, Mar 28, 2016 at 10:18 PM, Inki Dae wrote:
>>
>> In addition, I wonder how explicit and implicit fences could coexist
>> together.
>> Rob said,
>> "Implicit sync ofc remains the
Hi Daniel,
2016ë
03ì 31ì¼ 18:35ì Daniel Stone ì´(ê°) ì´ ê¸:
> Hi Inki,
>
> On 31 March 2016 at 08:45, Inki Dae wrote:
>> 2016ë
03ì 29ì¼ 22:23ì Rob Clark ì´(ê°) ì´ ê¸:
>>> On Mon, Mar 28, 2016 at 10:18 PM, Inki Dae wrote:
>>>> In
Hi Daniel,
2016-03-31 19:56 GMT+09:00 Daniel Stone :
> Hi Inki,
>
> On 31 March 2016 at 11:05, Inki Dae wrote:
>> 2016ë
03ì 31ì¼ 18:35ì Daniel Stone ì´(ê°) ì´ ê¸:
>>> On 31 March 2016 at 08:45, Inki Dae wrote:
>>>> As of now, it seems that this w
is should only be used for shared buffers, e.g.
> explicit syncing in an android client running on top of implicitly synced
> ozone/kms.
Good idea. I hope fence things of mainline would be more discussed so
could be considered for many cases.
Thanks,
Inki Dae
> -Daniel
> --
>
ld you queue it to next pull request?
>
Got it.
Thanks,
Inki Dae
> Regards
> Andrzej
>
> On 03/23/2016 02:25 PM, Andrzej Hajda wrote:
>> HDMI-PHY clock should be accessible from other components in the pipeline.
>>
>> Signed-off-by: Andrze
uess there is a way to
>> write directly without using the shadow registers.
>
> My knowledge about fimd is also limited, but it seems it is not possible
Right, not possible to update registers directly in Exynos SoC.
> to update registers directly - it looks for me reasonable - update on
> vsyn
x);
Shouldn't it be configured in case of using SW trigger mode also?
Thanks,
Inki Dae
> +
> /* lcd on and use command if */
> val = VIDOUT_LCD_ON;
> if (ctx->out_type & IFTYPE_I80) {
> val |= VIDOUT_COMMAND_IF;
> - decon_setup
Hi Andrzej,
2016ë
05ì 10ì¼ 15:08ì Andrzej Hajda ì´(ê°) ì´ ê¸:
> Hi Inki,
>
>
> On 05/10/2016 07:31 AM, Inki Dae wrote:
>> Hi Andrzej,
>>
>> 2016ë
04ì 29ì¼ 22:42ì Andrzej Hajda ì´(ê°) ì´ ê¸:
>>> It seems trigger cannot be configure
support but not now yet. Picked it up.
Thanks,
Inki Dae
>
> Cc: Inki Dae
> Signed-off-by: Daniel Vetter
> ---
> drivers/gpu/drm/exynos/exynos_drm_fb.c | 11 ---
> 1 file changed, 11 deletions(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_fb.c
> b/
2016ë
04ì 27ì¼ 02:29ì Daniel Vetter ì´(ê°) ì´ ê¸:
> No dev->struct_mutex anywhere to be seen.
Acked-by: Inki Dae
Thanks,
Inki Dae
>
> Cc: Inki Dae
> Signed-off-by: Daniel Vetter
> ---
> drivers/gpu/drm/exynos/exynos_drm_drv.c | 2 +-
> 1 file ch
This patch changes GPL license to X11/MIT.
Signed-off-by: Inki Dae
---
exynos/exynos_fimg2d.c | 21 +
exynos/exynos_fimg2d.h | 21 +
exynos/fimg2d_reg.h| 21 +
tests/exynos/exynos_fimg2d_event.c
2016ë
05ì 10ì¼ 16:08ì Andrzej Hajda ì´(ê°) ì´ ê¸:
> On 05/10/2016 08:24 AM, Inki Dae wrote:
>> Hi Andrzej,
>>
>> 2016ë
05ì 10ì¼ 15:08ì Andrzej Hajda ì´(ê°) ì´ ê¸:
>>> Hi Inki,
>>>
>>>
>>> On 05/10/2016 07:31 AM, Ink
is any problem.
Thanks,
Inki Dae
The following changes since commit 2e726dc4b4e2dd3ae3fe675f9d3af88a2d593ee1:
Merge tag 'mediatek-drm-2016-05-09' of git://git.pengutronix.de/git/pza/linux
into drm-next (2016-05-10 15:01:47 +1000)
are available in the git repository a
Picked it up.
Thanks,
Inki Dae
2016ë
02ì 12ì¼ 22:31ì Chanho Park ì´(ê°) ì´ ê¸:
> This patch adds a exynos5420 driver data to support mic_bypass
> option to bypass the mic from display out path.
> The mic(Mobile image compressor) compresses RGB data from fimd
> and send th
2016ë
01ì 27ì¼ 23:44ì Marek Szyprowski ì´(ê°) ì´ ê¸:
> This patch replaces zpos property handling custom code in Exynos DRM
> driver with calls to generic DRM code.
It'd be better to go to drm-misc.
Acked-by: Inki Dae
Thanks,
Inki Dae
>
> Signed-off-by:
2016ë
01ì 27ì¼ 23:44ì Marek Szyprowski ì´(ê°) ì´ ê¸:
> This patch adds support for blending related properties to Exynos DRM
> core and Exynos Mixer CRTC device.
To drm-misc.
Acked-by : Inki Dae
Thanks,
Inki Dae
>
> Signed-off-by: Marek Szyprowski
> ---
>
For 1 and 2, picked it up.
Thanks,
Inki Dae
2016ë
02ì 18ì¼ 22:34ì Marek Szyprowski ì´(ê°) ì´ ê¸:
> This patch refactors driver and device registration by moving all drivers
> to the common array. This way additional flags can be added later for
> new features. #ifdef-based
Picked it up.
Thanks,
Inki Dae
2016ë
02ì 17ì¼ 22:33ì Andrzej Hajda ì´(ê°) ì´ ê¸:
> Core provides generic helper to create DSI packet, use it instead of
> custom code.
>
> Signed-off-by: Andrzej Hajda
> ---
> drivers/gpu/drm/exynos/exy
Hi Daniel,
2015ë
12ì 24ì¼ 22:32ì Daniel Stone ì´(ê°) ì´ ê¸:
> Hi Inki,
>
> On 24 December 2015 at 09:10, Inki Dae wrote:
>> +void exynos_drm_crtc_cancel_page_flip(struct drm_crtc *crtc)
>> +{
>> + struct exynos_drm_crtc *exynos_crtc = to_exynos_crtc
Hi Marek,
2015ë
12ì 28ì¼ 21:34ì Marek Szyprowski ì´(ê°) ì´ ê¸:
> Hello,
>
> On 2015-12-24 09:15, Inki Dae wrote:
>> Seems this patch could be more cleaned up.
>>
>> Each ctx object of each crtc driver has its own plane config object which
>> includes
event objects belonging to the request process,
increment event space and decrease pending_update when cancelling
the event
Signed-off-by: Inki Dae
Reviewed-by: Daniel Stone
---
drivers/gpu/drm/exynos/exynos_drm_crtc.c | 18 ++
drivers/gpu/drm/exynos/exynos_drm_crtc.h | 4
Hi Daniel,
2016ë
01ì 05ì¼ 05:24ì Daniel Stone ì´(ê°) ì´ ê¸:
> Hi Inki,
>
> On 4 January 2016 at 12:57, Inki Dae wrote:
>> 2015ë
12ì 24ì¼ 22:32ì Daniel Stone ì´(ê°) ì´ ê¸:
>>> On 24 December 2015 at 09:10, Inki Dae wrote:
>>>> +void exy
+ Rob Clark,
Hi Daniel and Rob,
2016ë
01ì 05ì¼ 20:08ì Daniel Vetter ì´(ê°) ì´ ê¸:
> On Tue, Jan 05, 2016 at 07:55:52PM +0900, Inki Dae wrote:
>> Hi Daniel,
>>
>> 2016ë
01ì 05ì¼ 05:24ì Daniel Stone ì´(ê°) ì´ ê¸:
>>> Hi Inki,
>>>
&
event space.
Signed-off-by: Inki Dae
Reviewed-by: Daniel Stone
---
drivers/gpu/drm/exynos/exynos_drm_crtc.c | 15 +++
drivers/gpu/drm/exynos/exynos_drm_crtc.h | 3 +++
drivers/gpu/drm/exynos/exynos_drm_drv.c | 5 +
3 files changed, 23 insertions(+)
diff --git a/drivers/gpu/drm
These events will be freed by drm_events_release of DRM core so
it doesn't need to free these events in SoC specific driver.
This patch removes relevant codes from Exynos DRM driver.
Signed-off-by: Inki Dae
---
drivers/gpu/drm/exynos/exynos_drm_drv.c | 11 ---
1 file change
n set of planes,
> - well defined semantics: planes are sorted by zpos values and then plane
> id value if zpos equals.
>
> Patches 2/4 and 3/4 are fixes for Exynos DRM driver, which are required
Picked them up. Especially, 2/4 is a good patch.
Thanks,
Inki Dae
> to properly impl
Hi Daniel,
It seems your patch is exactly same as below my one I posted before,
http://www.spinics.net/lists/dri-devel/msg97922.html
Anyway, it's ok if this patch can go to mainline.
Acked-by: Inki Dae
2016ë
01ì 12ì¼ 06:41ì Daniel Vetter ì´(ê°) ì´ ê¸:
> The core takes care
Hi Daniel,
2016ë
01ì 12ì¼ 04:00ì Daniel Stone ì´(ê°) ì´ ê¸:
> Hi Inki,
>
> On 8 January 2016 at 08:46, Inki Dae wrote:
>> Changelog v3:
>> - initialize only device specific things. Each page flip event object
>> is created by DRM core so DRM core should r
Hi Andrzej,
Really sorry for missing this.
I will merge them soon.
Thanks,
Inki Dae
2016ë
01ì 13ì¼ 23:01ì Andrzej Hajda ì´(ê°) ì´ ê¸:
> Hi Inki,
>
> Ping.
>
> Regards
> Andrzej
>
> On 11/02/2015 02:16 PM, Andrzej Hajda wrote:
>> Hi Inki, Krzysztof,
&g
uot;);
> - if (IS_ERR(hdata->sclk_hdmi)) {
> - DRM_ERROR("failed to get clock 'sclk_hdmi'\n");
> - ret = PTR_ERR(hdata->sclk_hdmi);
> - goto fail;
> - }
> - hdata->sclk_pixel = devm_clk_get(dev, "sclk_pi
Dae
2016ë
01ì 14ì¼ 13:54ì Inki Dae ì´(ê°) ì´ ê¸:
> Hi Andrzej,
>
> Really sorry for missing this.
> I will merge them soon.
>
> Thanks,
> Inki Dae
>
> 2016ë
01ì 13ì¼ 23:01ì Andrzej Hajda ì´(ê°) ì´ ê¸:
>> Hi Inki,
>>
>> Ping.
&g
2016ë
01ì 14ì¼ 16:01ì Andrzej Hajda ì´(ê°) ì´ ê¸:
> On 01/14/2016 07:25 AM, Inki Dae wrote:
>> Hi Andrzej,
>>
>> This patch series incurred merge conflicts at severial patches so I had to
>> merge them manually.
>> It looks good to me but it seems to
me acked-by?
Thanks,
Inki Dae
>
> Regards
> Andrzej
>
> On 10/26/2015 12:59 PM, Andrzej Hajda wrote:
>> DECON-TV(Display and Enhancement Controller for TV) is a variation
>> of DECON IP. Its main purpose is to produce video stream for HDMI IP.
>>
>> S
ways, hides references to the
> nents and orig_nents entries, making the code robust, easier to follow
> and copy/paste safe.
>
> Signed-off-by: Marek Szyprowski
Acked-by : Inki Dae
Thanks,
Inki Dae
> ---
> drivers/gpu/drm/exynos/exynos_drm_g2d.c | 10 +-
> 1 file
20. 6. 19. 오후 7:36에 Marek Szyprowski 이(가) 쓴 글:
> Use common helper for checking the contiguity of the imported dma-buf.
>
> Signed-off-by: Marek Szyprowski
Acked-by : Inki Dae
Thanks,
Inki Dae
> ---
> drivers/gpu/drm/exynos/exynos_drm_gem.c | 23 +++
&g
one of the exynos maintianers (Inki?) to pick it up.
Picked it up.
Thanks,
Inki Dae
>
> Sam
>
>> ---
>> drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 2 +-
>> drivers/gpu/drm/exynos/exynos_drm_gem.h | 2 +-
>> 2 files changed, 2 insertions(+), 2 deletions
20. 4. 7. 오후 10:42에 Marek Szyprowski 이(가) 쓴 글:
> The ExynosDRM page fault handler is never used, drm_gem_mmap()
> always calls exynos_drm_gem_mmap() function, which perform
> complete mapping for the given virtual address-space area.
Right, never used. Picked it up.
Thanks,
is 0? I think length of s is 0 then it
would be invalid because all entries of sgt should be mapped before
sg_dma_len() is called.
Thanks,
Inki Dae
> + if (sg_dma_address(s) != next_addr) {
> +
Hi Marek,
20. 4. 21. 오후 5:09에 Marek Szyprowski 이(가) 쓴 글:
> Hi Inki,
>
> On 21.04.2020 09:38, Inki Dae wrote:
>> 20. 4. 7. 오후 10:42에 Marek Szyprowski 이(가) 쓴 글:
>>> Explicitly check if the imported buffer has been mapped as contiguous in
>>> the DMA address spac
gt;
> This issue was detected by using the Coccinelle software.
Picked it up.
Thanks,
Inki Dae.
>
> Signed-off-by: Markus Elfring
> ---
> drivers/gpu/drm/exynos/exynos_drm_dsi.c | 4 +---
> drivers/gpu/drm/exynos/exynos_drm_rotator.c | 4 +---
> drivers/gpu/drm/exyno
20. 4. 22. 오후 12:37에 Inki Dae 이(가) 쓴 글:
> Hi Marek,
>
> 20. 4. 21. 오후 5:09에 Marek Szyprowski 이(가) 쓴 글:
>> Hi Inki,
>>
>> On 21.04.2020 09:38, Inki Dae wrote:
>>> 20. 4. 7. 오후 10:42에 Marek Szyprowski 이(가) 쓴 글:
>>>> Explicitly check if the imported
don't really need that array at all.
Picked it up.
Thanks,
Inki Dae
>
> Suggested-by: Christian König
> Signed-off-by: Marek Szyprowski
> ---
> drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 28 +
> drivers/gpu/drm/exynos/exynos_drm_gem.c | 124 +++--
Picked it up.
Thanks,
Inki Dae
>
> Signed-off-by: Marek Szyprowski
> ---
> v2:
> - reworked a check for sgt->nents
> - added a comment about a scatter-list contiguity check
> - removed additional 'return ERR_PTR(-EINVAL)' accidentaly left after
> debugging
call to the end of the probe function to
handle the error simply.
dsi->in_bridge_node is accessed in bind function and the probe function is
called before the bind call.
Could you rework and post it again?
Thanks,
Inki Dae
> ---
> drivers/gpu/drm/exynos/exynos_drm_dsi.c | 28 +++
20. 10. 9. 오후 10:05에 Marek Szyprowski 이(가) 쓴 글:
> Add clock configuration for 154MHz pixelclock to Exynos542x HDMIPHY,
> which is required for 1920x1200@60Hz mode. The PLL configuration data
> has been taken from the vendor's kernel tree for the Odroid XU4 board.
Merged.
Th
oto turn_off;
How about just calling pm_runtime_put_noidle()?
if (ret < 0) {
pm_runtime_put_noidle(mic->dev);
goto unlock;
}
Thanks,
Inki Dae
>
> mic_set_path(mic, 1);
>
>
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Navid Emamdoost
> ---
> Changes in v2:
> - reuse the unlock label and call pm_runtime_put_noidle
Picked it up.
Thanks,
Inki Dae
> ---
> ---
> drivers/gpu/drm/exynos/exynos_drm_mic.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/dr
Hi Dave,
Just one cleanup and two fixups.
Please kindly let me know if there is any problem.
Thanks,
Inki Dae
The following changes since commit 687a0ed337367be5267652af5f6dbcfc954b8732:
Merge tag 'drm-misc-fixes-2020-06-25' of
git://anongit.freedesktop.org/drm/drm-mis
kernel.org/dri-devel/20200707110827.3760-1-m.szyprow...@samsung.com/
>
> Inki, could You queue it for merge?
Oops, sorry. Reviewed already but forgot to merge.
Thanks,
Inki Dae
>
>> ---
>> drivers/gpu/drm/exynos/exynos_drm_dma.c | 26 +
>> 1
> ---
> This is a cheeky revert of 07dc3678bacc ("drm/exynos: Fix cleanup of
> IOMMU related objects"), plus removal of the remaining arm_iommu_*
> references on top.
Thanks for cleanup.
Acked-by: Inki Dae
Thanks,
Inki Dae
> ---
> drivers/gpu/drm/exynos/exynos5433
Hi Robin,
As Marek said, he posted same patch[1] before so I merged it instead of you.
I totally forgot to merge it. :( Sorry for confusing.
[1]
https://lore.kernel.org/dri-devel/20200707110827.3760-1-m.szyprow...@samsung.com/
Thanks,
Inki Dae
20. 9. 4. 오전 5:51에 Robin Murphy 이(가) 쓴 글:
> Si
Hi Dave,
Just two cleanups.
Please kindly let me know if there is any problem.
Thanks,
Inki Dae
The following changes since commit b40be05ed255d9a0257fb66ab2728ecca2c9d597:
Merge branch 'for-5.10-drm-sg-fix' of https://github.com/mszyprow/linux into
drm-next (2020-09-1
Hi Dave,
Just one fixup to fix sparse warning reported.
Please kindly let me know if there is any problem.
Thanks,
Inki Dae
The following changes since commit d012a7190fc1fd72ed48911e77ca97ba4521bccd:
Linux 5.9-rc2 (2020-08-23 14:08:43 -0700)
are available in the Git repository at
Hi Email,
20. 5. 18. 오전 4:36에 Emil Velikov 이(가) 쓴 글:
> Platform drivers now have the option to have the platform core create
> and remove any needed sysfs attribute files. So take advantage of that
> and do not register "by hand" a sysfs file.
>
> Cc: Inki Dae
> Cc:
20. 5. 16. 오후 7:57에 Christophe JAILLET 이(가) 쓴 글:
> 'exynos_dsi_parse_dt()' takes a reference to 'dsi->in_bridge_node'.
> This must be released in the error handling path.
Picked it up.
Thanks,
Inki Dae
>
> In order to do that, add an error handling path
be function.
static int mixer_remove(struct platform_device *pdev)
{
component_del(&pdev->dev, &mixer_component_ops);
pm_runtime_disable(&pdev->dev);
}
It's a trivial thing and it would be no problem as-is - we don't touch HW in
unbind - so picked
Hi Dave,
Just several fixups and cleanups.
Please kindly let me know if there is any problem.
Thanks,
Inki Dae
The following changes since commit 1493bddcca4d601ca6f3dd27f2226f37a0f39732:
Merge tag 'drm-misc-next-2020-05-14' of
git://anongit.freedesktop.org/drm/drm-misc int
Hi Tamseel,
Same patch[1] has been merged. So could you re-post this patch after rebasing
it on top of exynos-drm-next branch?
After rebase, only g2d part would be valid.
Thanks,
Inki Dae
[1]
https://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git/commit/?h=exynos-drm-next&am
20. 5. 21. 오후 11:22에 Tamseel Shams 이(가) 쓴 글:
> platform_get_irq() will call dev_err() itself on failure,
> so there is no need for the driver to also do this.
> This is detected by coccinelle.
Picked it up.
Thanks,
Inki Dae
>
> Signed-off-by: Tamseel Shams
> ---
&g
20. 5. 22. 오후 3:03에 Marek Szyprowski 이(가) 쓴 글:
> Propagate the proper error codes from the called functions instead of
> unconditionally returning 0.
>
Picked it up.
Thanks,
Inki Dae
> Reported-by: kbuild test robot
> Signed-off-by: Marek Szyprowski
> ---
> d
rm_crtc.h:24:
+ const struct exynos_drm_crtc_ops
*ops,
I modified and merged all patches.
Thanks,
Inki Dae
>
> Signed-off-by: Krzysztof Kozlowski
>
> ---
> Changes since v1:
> New patch.
> ---
> drivers/gpu/drm/exynos/exynos7_drm_decon.c | 2 +-
> drivers
On 2015ë
05ì 12ì¼ 03:04, Tobias Jakobi wrote:
> Hey Inki,
>
> Inki Dae wrote:
>> On 2015ë
05ì 06ì¼ 21:10, Tobias Jakobi wrote:
>>> The index for the hardware layer is always >=0. Previous
>>> code that also used -1 as special index is now gone.
&g
AGE_SHIFT;
> - g2d_userptr->npages = npages;
> -
> - pages = drm_calloc_large(npages, sizeof(struct page *));
The declaration to pages isn't needed anymore because you removed it.
> - if (!pages) {
> - DRM_ERROR("failed to allocate pages.\n");
> - ret = -ENOMEM;
> + vec = g2d_userptr->vec = frame_vector_create(npages);
I think you can use g2d_userptr->vec so it seems that vec isn't needed.
> + if (!vec)
> goto err_free;
> - }
>
> - down_read(¤t->mm->mmap_sem);
> - vma = find_vma(current->mm, userptr);
For vma, ditto.
Thanks,
Inki Dae
[--SNIP--]
> -static void exynos_drm_crtc_prepare(struct drm_crtc *crtc)
> -{
> - /* drm framework doesn't check NULL. */
> + if (exynos_crtc->ops->win_commit)
> + exynos_crtc->ops->win_commit(exynos_crtc, exynos_plane->zpos);
> +
> + if (exynos_crtc->ops->commit)
> + exynos_crtc->ops->commit(exynos_crtc);
crtc commit already was called by mode_set_nofb callback as soon as it
disables crtc and encoder devices so I think unnecessary. Please see the
drm_atomic_helper_commit_modeset_disable function.
<--snip-->
Thanks,
Inki Dae
atomic_flush callback to enable global dma
like commit callback did. Is there any reason that you don't use
atomic_begin and atomic_flush callbacks?
atomic relevant codes I looked into do as follows,
atomic_begin();
atomic_update(); /* this will call win_commit callback to set a overl
Hi Gustavo,
On 2015ë
05ì 28ì¼ 05:27, Gustavo Padovan wrote:
> Hi Inki,
>
> 2015-05-27 Inki Dae :
>
>> Hi Gustavo,
>>
>> On 2015ë
05ì 23ì¼ 00:40, Gustavo Padovan wrote:
>>> From: Gustavo Padovan
>>>
>>> Run dpms operations thr
oc_attrs function in case of Exynos DRM.
This dma mapping API calls internally iommu_map function of iommu framework
after allocating physical pages and iova space, and the iova space will be
mapped with physical pages.
Please, look into the dma mapping framework - arch/arm/mm/dma-mapping.c -
Hi Dave,
2015ë
11ì 03ì¼ 08:10ì Dave Airlie ì´(ê°) ì´ ê¸:
> On 28 October 2015 at 22:37, Inki Dae wrote:
>> Hi Daniel,
>>
>> 2015ë
10ì 28ì¼ 20:52ì Daniel Stone ì´(ê°) ì´ ê¸:
>>> Hi Inki,
>>>
>>> On 28 October 2015 at 11:16,
the Tizen consists of Wayland or Xorg, libtbm and its backend
specific to Hardware. The libtbm backend uses libdrm.
So we are wait for the libtbm backend uses DRM_EXYNOS_GEM_MAP interface.
Please kindly let me know if there is any problem.
Thanks,
Inki Dae
[1] http://www.spinics.net
Hi Daniel,
2015ë
10ì 28ì¼ 21:37ì Inki Dae ì´(ê°) ì´ ê¸:
> Hi Daniel,
>
> 2015ë
10ì 28ì¼ 20:52ì Daniel Stone ì´(ê°) ì´ ê¸:
>> Hi Inki,
>>
>> On 28 October 2015 at 11:16, Inki Dae wrote:
>>> 2015ë
10ì 28ì¼ 20:00ì Daniel Stone
From: Gustavo Padovan
Let pm_runtime handle the enabling/disabling of the device with
proper refcnt instead of rely on specific flags to track the enabled
state.
Changelog v2:
- no change
Signed-off-by: Gustavo Padovan
Signed-off-by: Inki Dae
---
drivers/gpu/drm/exynos/exynos_dp_core.c | 58
From: Gustavo Padovan
The DP device will be properly enabled at the enable() call just
after the bind call finishes.
Changelog v2:
- no change
Signed-off-by: Gustavo Padovan
Signed-off-by: Inki Dae
---
drivers/gpu/drm/exynos/exynos_dp_core.c | 107 +++-
drivers
From: Gustavo Padovan
Let pm_runtime handle the enabling/disabling of the device with proper
refcnt instead of rely on specific flags to track the enabled state.
Changelog v2:
- Mofidy CONFIG_PM_SLEEP -> CONFIG_PM
Signed-off-by: Gustavo Padovan
Signed-off-by: Inki Dae
---
drivers/gpu/
From: Gustavo Padovan
Let pm_runtime handle the enabling/disabling of the device with
proper refcnt instead of rely on specific flags to track the enabled
state.
Changelog v2:
- Modify CONFIG_PM_SLEEP -> CONFIG_PM
Signed-off-by: Gustavo Padovan
Signed-off-by: Inki Dae
---
drivers/gpu/
This patch series adds pm runtime support for Exynos drm.
Originally, this patch was posted by Gustavo but there was no any
answer about some comments. So I rebased this patch series on top of
exynos-drm-next, removed unnecessary patches and modified wrong macro.
Changelog v2:
- Remove patch 5 an
From: Gustavo Padovan
Let pm_runtime handle the enabling/disabling of the device with proper
refcnt instead of rely on specific flags to track the enabled state.
Signed-off-by: Gustavo Padovan
Signed-off-by: Inki Dae
---
drivers/gpu/drm/exynos/exynos_mixer.c | 125
_PM
Signed-off-by: Gustavo Padovan
Signed-off-by: Inki Dae
---
drivers/gpu/drm/exynos/exynos_drm_fimd.c | 91 +---
1 file changed, 37 insertions(+), 54 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c
b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
in
From: Gustavo Padovan
Let pm_runtime handle the enabling/disabling of the device with
proper refcnt instead of rely on specific flags to track the enabled
state.
Changelog v2:
- Change CONFIG_PM_SLEEP -> CONFIG_PM
Signed-off-by: Gustavo Padovan
Signed-off-by: Inki Dae
---
drivers/gpu/
2015-11-03 22:24 GMT+09:00 Andrzej Hajda :
> Hi Inki,
>
> On 11/03/2015 11:47 AM, Inki Dae wrote:
>> This patch series adds pm runtime support for Exynos drm.
>>
>> Originally, this patch was posted by Gustavo but there was no any
>> answer about some comments.
2015ë
11ì 04ì¼ 16:24ì Andrzej Hajda ì´(ê°) ì´ ê¸:
> On 11/03/2015 04:38 PM, Inki Dae wrote:
>>
>> 2015-11-03 22:24 GMT+09:00 Andrzej Hajda > <mailto:a.hajda at samsung.com>>:
>>> Hi Inki,
>>>
>>> On 11/03/2015 11:47 AM, Inki Dae
2015ë
11ì 04ì¼ 19:13ì Andrzej Hajda ì´(ê°) ì´ ê¸:
> On 11/04/2015 08:56 AM, Inki Dae wrote:
>>
>> 2015ë
11ì 04ì¼ 16:24ì Andrzej Hajda ì´(ê°) ì´ ê¸:
>>> On 11/03/2015 04:38 PM, Inki Dae wrote:
>>>>
>>>> 2015-11-03 22:2
pass_shift = 11,
> - .trg_type = I80_HW_TRG,
> .has_shadowcon = 1,
> .has_vidoutcon = 1,
> .has_vtsel = 1,
> .has_mic_bypass = 1,
> .has_dp_clk = 1,
> - .has_hw_trigger = 1,
> - .has_trigger_per_te = 1,
We don't need to re
Hi Javier,
2016ë
06ì 09ì¼ 09:17ì Javier Martinez Canillas ì´(ê°) ì´ ê¸:
> Hello Inki,
>
> Thanks for your feedback.
>
> On 06/08/2016 07:09 PM, Inki Dae wrote:
>> Hi Javier,
>>
>> 2016ë
06ì 02ì¼ 23:20ì Javier Martinez Canillas ì´(ê°) ì´ ê
anyone not to call this function
with mutex lock?
If there is such case then,
some_function()
{
mutex_lock();
...
mutex_unlock();
drm_fb_helper_add_one_connector();
...
}
So in this case, other users should consider to make sure to unlock before
calling this
2016ë
05ì 30ì¼ 03:35ì Daniel Vetter ì´(ê°) ì´ ê¸:
> We want to hide drm_atomic_state internals better.
Acked-by: Inki Dae
Thanks,
Inki Dae
>
> Cc: Inki Dae
> Signed-off-by: Daniel Vetter
> ---
> drivers/gpu/drm/exynos/exynos_drm_drv.c | 8
&g
301 - 400 of 3067 matches
Mail list logo
