Re: [Nouveau] [PATCH v4 02/17] drm/nouveau/kms/nv50-: Move AUX adapter reg to connector late register/early unregister

2021-04-23 Thread Ilia Mirkin
Some trivia, no comment on the real logic of the changes: On Fri, Apr 23, 2021 at 2:43 PM Lyude Paul wrote: > > Since AUX adapters on nouveau have their respective DRM connectors as > parents, we need to make sure that we register then after their connectors. then -> them > > Signed-off-by: Lyu

Re: [Nouveau] [PATCH] drm/nouveau/kms/nv50-: Check plane size for cursors, not fb size

2021-03-18 Thread Ilia Mirkin
On Thu, Mar 18, 2021 at 5:56 PM Lyude Paul wrote: > > Found this while trying to make some changes to the kms_cursor_crc test. > curs507a_acquire checks that the width and height of the cursor framebuffer > are equal (asyw->image.{w,h}). This is actually wrong though, as we only > want to be conce

Re: [Nouveau] [RFC v3 05/10] drm/i915/dpcd_bl: Cleanup intel_dp_aux_vesa_enable_backlight() a bit

2021-02-05 Thread Ilia Mirkin
On Fri, Feb 5, 2021 at 6:45 PM Lyude Paul wrote: > > Get rid of the extraneous switch case in here, and just open code > edp_backlight_mode as we only ever use it once. > > Signed-off-by: Lyude Paul > --- > .../gpu/drm/i915/display/intel_dp_aux_backlight.c | 15 ++- > 1 file changed,

Re: [PATCH 2/3] drm/nouveau/kms/nv50-: Report max cursor size to userspace

2021-02-23 Thread Ilia Mirkin
On Tue, Feb 23, 2021 at 9:26 AM Alex Riesen wrote: > > Lyude Paul, Tue, Jan 19, 2021 02:54:13 +0100: > > diff --git a/drivers/gpu/drm/nouveau/dispnv50/disp.c > > b/drivers/gpu/drm/nouveau/dispnv50/disp.c > > index c6367035970e..5f4f09a601d4 100644 > > --- a/drivers/gpu/drm/nouveau/dispnv50/disp.c

Re: [PATCH 2/3] drm/nouveau/kms/nv50-: Report max cursor size to userspace

2021-02-23 Thread Ilia Mirkin
On Tue, Feb 23, 2021 at 10:36 AM Alex Riesen wrote: > > Ilia Mirkin, Tue, Feb 23, 2021 15:56:21 +0100: > > On Tue, Feb 23, 2021 at 9:26 AM Alex Riesen > > wrote: > > > Lyude Paul, Tue, Jan 19, 2021 02:54:13 +0100: > > > > diff --git a/drivers/gpu/drm/nou

Re: [PATCH 2/3] drm/nouveau/kms/nv50-: Report max cursor size to userspace

2021-02-23 Thread Ilia Mirkin
On Tue, Feb 23, 2021 at 11:23 AM Alex Riesen wrote: > > Alex Riesen, Tue, Feb 23, 2021 16:51:26 +0100: > > Ilia Mirkin, Tue, Feb 23, 2021 16:46:52 +0100: > > > I'd recommend using xf86-video-nouveau in any case, but some distros > > > > I would like try this

Re: [PATCH 2/3] drm/nouveau/kms/nv50-: Report max cursor size to userspace

2021-02-24 Thread Ilia Mirkin
[+emersion, -various people and lists who definitely don't care] On Wed, Feb 24, 2021 at 4:09 AM Alex Riesen wrote: > > Ilia Mirkin, Tue, Feb 23, 2021 19:13:59 +0100: > > On Tue, Feb 23, 2021 at 11:23 AM Alex Riesen > > wrote: > > > > > > $ xr

Re: [PATCH 2/3] drm/nouveau/kms/nv50-: Report max cursor size to userspace

2021-02-24 Thread Ilia Mirkin
On Wed, Feb 24, 2021 at 11:35 AM Alex Riesen wrote: > Ilia Mirkin, Wed, Feb 24, 2021 16:10:57 +0100: > > The fact that you're getting lines with modetest means there's > > something wrong with 256x256. What if you do 128x128 -- does that work > > OK? > > Yes.

Re: [PATCH 2/3] drm/nouveau/kms/nv50-: Report max cursor size to userspace

2021-02-24 Thread Ilia Mirkin
On Wed, Feb 24, 2021 at 11:53 AM Alex Riesen wrote: > > Ilia Mirkin, Wed, Feb 24, 2021 17:48:39 +0100: > > On Wed, Feb 24, 2021 at 11:35 AM Alex Riesen > > wrote: > > > Ilia Mirkin, Wed, Feb 24, 2021 16:10:57 +0100: > > > > The fact that you'

Re: [PATCH 2/3] drm/nouveau/kms/nv50-: Report max cursor size to userspace

2021-02-24 Thread Ilia Mirkin
On Wed, Feb 24, 2021 at 12:03 PM Alex Riesen wrote: > > Ilia Mirkin, Wed, Feb 24, 2021 17:57:41 +0100: > > On Wed, Feb 24, 2021 at 11:53 AM Alex Riesen > > wrote: > > > Ilia Mirkin, Wed, Feb 24, 2021 17:48:39 +0100: > > > > Just to be crystal clear -- ar

Re: [Intel-gfx] [PATCH 18/18] drm/i915/display13: Enabling dithering after the CC1 pipe

2021-02-28 Thread Ilia Mirkin
Just wanted to mention ... nouveau supports two separate properties, one controlling the type of dithering, and the other the dithering depth: dithering depth: auto supported: auto, 6 bpc, 8 bpc dithering mode: auto supported: auto, off, static 2x2,

[PATCH] drm/nouveau/kms/nv04: use vzalloc for nv04_display

2021-03-07 Thread Ilia Mirkin
The struct is giant, and triggers an order-7 allocation (512K). There is no reason for this to be kmalloc-type memory, so switch to vmalloc. This should help loading nouveau on low-memory and/or long-running systems. Reported-by: Nathan E. Egge Signed-off-by: Ilia Mirkin Cc: sta

Re: [PATCH v7 3/3] drm: Add GUD USB Display driver

2021-03-11 Thread Ilia Mirkin
On Thu, Mar 11, 2021 at 3:02 PM Peter Stuge wrote: > > > Hence the question: What does DRM promise about the XRGB mode? > > > > That it's a 32-bit value. From include/uapi/drm/drm_fourcc.h: > > > > /* 32 bpp RGB */ > > #define DRM_FORMAT_XRGB fourcc_code('X', 'R', '2', '4') /* [31:0] > >

Re: [PATCH v7 3/3] drm: Add GUD USB Display driver

2021-03-11 Thread Ilia Mirkin
On Thu, Mar 11, 2021 at 5:58 PM Peter Stuge wrote: > > Ilia Mirkin wrote: > > > > #define DRM_FORMAT_XRGB fourcc_code('X', 'R', '2', '4') /* [31:0] > > > > x:R:G:B 8:8:8:8 little endian */ > > > > > > O

Re: [Nouveau] Nouveau video --- [ cut here ] ----- crash dump 5.10.0-rc6

2020-12-02 Thread Ilia Mirkin
Unfortunately this isn't a crash, but rather a warning that things are timing out. By the time you get this, the display is most likely hung. Was there anything before this, e.g. an error state dump perhaps? What GPU are you using, what displays, and how are they connected? What kind of userspace

Re: [PATCH] drm/edid: Fix uninitialized variable in drm_cvt_modes()

2020-11-03 Thread Ilia Mirkin
On Tue, Nov 3, 2020 at 2:47 PM Lyude Paul wrote: > > Sorry! Thought I had responded to this but apparently not, comments down below > > On Thu, 2020-10-22 at 14:04 -0400, Ilia Mirkin wrote: > > On Thu, Oct 22, 2020 at 12:55 PM Lyude Paul wrote: > > > > > >

Re: [PATCH v2] drm/edid: Fix uninitialized variable in drm_cvt_modes()

2020-11-03 Thread Ilia Mirkin
On Tue, Nov 3, 2020 at 5:15 PM Lyude Paul wrote: > > Noticed this when trying to compile with -Wall on a kernel fork. We > potentially > don't set width here, which causes the compiler to complain about width > potentially being uninitialized in drm_cvt_modes(). So, let's fix that. > > Changes si

Re: [PATCH v3] drm/edid: Fix uninitialized variable in drm_cvt_modes()

2020-11-05 Thread Ilia Mirkin
uninitialized_var() usage") > Signed-off-by: Lyude Paul For the very little it's worth, Reviewed-by: Ilia Mirkin > --- > drivers/gpu/drm/drm_edid.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c &g

Re: [PATCH libdrm 3/3] util: Add SMPTE pattern support for C4 format

2022-03-14 Thread Ilia Mirkin
On Mon, Mar 14, 2022 at 9:07 AM Geert Uytterhoeven wrote: > > Hi Ilia, > > On Tue, Mar 8, 2022 at 8:57 AM Geert Uytterhoeven > wrote: > > On Mon, Mar 7, 2022 at 10:23 PM Ilia Mirkin wrote: > > > On Mon, Mar 7, 2022 at 3:53 PM Geert Uytterhoeven > > >

Re: [PATCH libdrm 3/3] util: Add SMPTE pattern support for C4 format

2022-03-14 Thread Ilia Mirkin
On Mon, Mar 14, 2022 at 10:06 AM Geert Uytterhoeven wrote: > > Hi Ilia, > > On Mon, Mar 14, 2022 at 2:44 PM Ilia Mirkin wrote: > > On Mon, Mar 14, 2022 at 9:07 AM Geert Uytterhoeven > > wrote: > > > On Tue, Mar 8, 2022 at 8:57 AM Geert Uytterhoeven > >

Re: [PATCH libdrm 3/3] util: Add SMPTE pattern support for C4 format

2022-03-07 Thread Ilia Mirkin
On Mon, Mar 7, 2022 at 3:53 PM Geert Uytterhoeven wrote: > diff --git a/tests/util/pattern.c b/tests/util/pattern.c > index 953bf95492ee150c..42d75d700700dc3d 100644 > --- a/tests/util/pattern.c > +++ b/tests/util/pattern.c > @@ -608,6 +608,46 @@ static void fill_smpte_rgb16fp(const struct > util

Re: [PATCH] MAINTAINERS: Add Helge as fbdev maintainer

2022-01-17 Thread Ilia Mirkin
On Mon, Jan 17, 2022 at 2:47 PM Helge Deller wrote: > > On 1/17/22 17:21, Helge Deller wrote: > > On 1/17/22 16:58, Thomas Zimmermann wrote: > >> Hi > >> > >> Am 17.01.22 um 16:42 schrieb Helge Deller: > >>> [...] > > c) reintroduce the state where fbcon is fast on fbdev. This is > > impo

Re: [PATCH v5 2/3] drm: Add Gamma and Degamma LUT sizes props to drm_crtc to validate.

2021-11-04 Thread Ilia Mirkin
On Thu, Nov 4, 2021 at 4:03 PM Mark Yacoub wrote: > > From: Mark Yacoub > > [Why] > 1. drm_atomic_helper_check doesn't check for the LUT sizes of either Gamma > or Degamma props in the new CRTC state, allowing any invalid size to > be passed on. > 2. Each driver has its own LUT size, which could

Re: [PATCH v8 4/4] NOTFORMERGE: drm/logicvc: Add plane colorkey support

2020-12-23 Thread Ilia Mirkin
FWIW this is something I added, hoping it was going to get used at some point, but I never followed up with support in xf86-video-nouveau for Xv. At this point, I'm not sure I ever will. I encoded the "enabled" part into the value with a high bit (1<<24) -- not sure that was such a great idea. All

Re: [PATCH] drm/loongson: Add DRM Driver for Loongson 7A1000 bridge chip

2020-12-30 Thread Ilia Mirkin
On Wed, Dec 30, 2020 at 6:08 AM Chenyang Li wrote: > + switch (format->format) { > + case DRM_FORMAT_RGB565: > + lcrtc->cfg_reg |= 0x3; > + break; > + case DRM_FORMAT_RGB888: > + default: > + lcrtc->cfg_reg |= 0x4; > +

Re: [PATCH] drm/amd/display: Fix pageflipping for XOrg in Linux 5.11+

2021-01-02 Thread Ilia Mirkin
On Sat, Jan 2, 2021 at 1:35 PM Mario Kleiner wrote: > I'm less sure about nouveau. It uses modifiers, but has atomic support > only on nv50+ and that atomic support is off by default -- needs a > nouveau.nouveau_atomic=1 boot parameter to switch it on. It seems to > enable modifier support uncondi

Re: [PATCH 4/4] PCI: add a REBAR size quirk for Sapphire RX 5600 XT Pulse.

2021-01-05 Thread Ilia Mirkin
On Tue, Jan 5, 2021 at 8:44 AM Christian König wrote: > > Otherwise the CPU can't fully access the BAR. > > Signed-off-by: Christian König > --- > drivers/pci/pci.c | 9 - > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c > index 1621

[PATCH] Re: Mullins support in xf86-video-amdgpu

2016-08-23 Thread Ilia Mirkin
On Mon, Aug 22, 2016 at 10:57 PM, Reid Hekman wrote: > On 08/22/2016 08:27 PM, Michel Dänzer wrote: >> >> On 23/08/16 10:18 AM, Reid Hekman wrote: >>> >>> >>> I was encouraged by a commit I saw today to add Sea Islands PCI ids to >>> xf86-video-amdgpu. However I did not see MULLINS included. Are

Re: [Nouveau] [PATCH] drm/nouveau: fix duplication of nv50_head_atom struct

2019-05-15 Thread Ilia Mirkin
On Tue, May 14, 2019 at 3:57 PM Peteris Rudzusiks wrote: > > On Tue, May 14, 2019 at 04:55:05PM +1000, Ben Skeggs wrote: > > On Sun, 12 May 2019 at 04:23, Peteris Rudzusiks > > wrote: > > > > > > nv50_head_atomic_duplicate_state() makes a copy of nv50_head_atom > > > struct. This patch adds copyi

[PATCH 1/2] drm/nouveau/disp/nv50-: force scaler for any non-default LVDS/eDP modes

2019-05-25 Thread Ilia Mirkin
, and i915 already does it this way. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110660 Signed-off-by: Ilia Mirkin --- Untested for now, hoping that the bugzilla filer will test it out. Seems obvious though. drivers/gpu/drm/nouveau/dispnv50/disp.c | 9 +++-- 1 file changed, 7 inser

[PATCH 2/2] drm/nouveau/disp/nv50-: fix center/aspect-corrected scaling

2019-05-25 Thread Ilia Mirkin
/show_bug.cgi?id=110660 Signed-off-by: Ilia Mirkin --- Tested on a 1920x1200-native screen with a 640x480 mode (got letter boxes on the side) and 720x400 mode (got letter boxes on top/bottom). drivers/gpu/drm/nouveau/dispnv50/head.c | 28 + 1 file changed, 24 insertions(+), 4

Re: [Nouveau] [PATCH 1/2] drm/nouveau/disp/nv50-: force scaler for any non-default LVDS/eDP modes

2019-05-28 Thread Ilia Mirkin
e, which copies mode into adjusted_mode... Assuming it makes sense to use "mode", Ben, want to just do a fixup locally, or want me to send a revert + new patch? -ilia On Mon, May 27, 2019 at 2:24 AM Ben Skeggs wrote: > > On Sun, 26 May 2019 at 08:41, Ilia Mirkin wrote: > &g

Re: [Nouveau] [PATCH] drm/nouveau: Don't disable polling in fallback mode

2018-12-30 Thread Ilia Mirkin
Ben - ping? Just ran into this myself on a NV42. On Wed, Nov 14, 2018 at 11:01 AM Takashi Iwai wrote: > > On Fri, 14 Sep 2018 13:59:25 +0200, > Martin Peres wrote: > > > > On 14/09/2018 10:28, Ben Skeggs wrote: > > > On Wed, 12 Sep 2018 at 20:59, Takashi Iwai wrote: > > >> > > >> When a fan is c

Re: Nouveau module results in total lockups without any dmesg trace on a NP900X5N Kaby Lake machine

2019-01-01 Thread Ilia Mirkin
On Tue, Jan 1, 2019 at 4:06 PM Jan Vlietland wrote: > > Hi Ben, David and Daniel , > > First of all happy new year. Based on advice of Greg K-H herewith a mail > about a number of Nouveau issues with my laptop. > > I installed various Kali linux versions up to Linux 4.20.0-rc7 > (downloaded, compi

Re: Nouveau module X server not starting on a NP900X5N Kaby Lake machine

2019-01-01 Thread Ilia Mirkin
On Tue, Jan 1, 2019 at 5:30 PM Jan Vlietland wrote: > > Hi Ilia, many thanks for answering my mail. > > Tonight I tried to see what happens if I generate a xorg.conf file and place > it in /etc/X11/xorg.conf, as described here: > https://askubuntu.com/questions/4662/where-is-the-x-org-config-file

Re: [PATCH v2 0/6] drm: byteorder fixes

2019-01-10 Thread Ilia Mirkin
Hi Gerd, What happened with this series (and the next one)? Semi-relatedly, I wonder if it wouldn't be better to just dump the BIG_ENDIAN flag and just define the "host" format to be the right one for a consistent little-endian interpretation. Cheers, -ilia On Wed, Sep 5, 2018 at 2:04 AM Ge

Re: [PATCH v2 0/6] drm: byteorder fixes

2019-01-11 Thread Ilia Mirkin
On Fri, Jan 11, 2019, 05:26 Daniel Vetter On Fri, Jan 11, 2019 at 10:43:42AM +0100, Gerd Hoffmann wrote: > > On Fri, Jan 11, 2019 at 10:11:09AM +0100, Daniel Vetter wrote: > > > On Fri, Jan 11, 2019 at 10:08 AM Gerd Hoffmann > wrote: > > > > > > > > On F

Re: [PATCH 02/11] drm/modes: Add DRM_SIMPLE_MODE()

2019-01-20 Thread Ilia Mirkin
You don't appear to set the mm in the new macro. Not sure if it's on purpose. On Sun, Jan 20, 2019, 06:43 Noralf Trønnes This adds a helper macro to specify modes that only contain info about > resolution. > > Signed-off-by: Noralf Trønnes > --- > drivers/gpu/drm/tinydrm/hx8357d.c | 2 +- > d

Re: drm/nouveau/bios/ramcfg, setting of RON pull value

2019-02-16 Thread Ilia Mirkin
On Sat, Feb 16, 2019 at 10:02 AM Colin Ian King wrote: > > Hi, > > Static Analysis with CoverityScan as detected an issue with the setting > of the RON pull value in function nvkm_gddr3_calc in > drm/nouveau/bios/ramcfg.c > > This was introduced by commit: c25bf7b6155cb ("drm/nouveau/bios/ramcfg:

[PATCH libdrm 00/10] Add C8, 30bpp and FP16 support to modetest

2019-06-02 Thread Ilia Mirkin
for the C8 indexed format. This was tested on nouveau, and used for bring-up of the C8, XB30, and FP16 formats on the NVIDIA hardware that supports these. Ilia Mirkin (10): util: add C8 format, support it with SMPTE pattern util: fix MAKE_RGBA macro for 10bpp modes util: add gradient pattern

[PATCH libdrm 02/10] util: fix MAKE_RGBA macro for 10bpp modes

2019-06-02 Thread Ilia Mirkin
We need to shift the values up, otherwise we'd end up with a negative shift. This works for up-to 16-bit components, which is fine for now. Signed-off-by: Ilia Mirkin --- tests/util/pattern.c | 19 +++ 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/tests

[PATCH libdrm 08/10] modetest: add C8 support to generate SMPTE pattern

2019-06-02 Thread Ilia Mirkin
This includes logic to configure the LUT accordingly. Signed-off-by: Ilia Mirkin --- tests/modetest/buffers.c | 2 ++ tests/modetest/modetest.c | 47 ++- 2 files changed, 44 insertions(+), 5 deletions(-) diff --git a/tests/modetest/buffers.c b/tests

[PATCH libdrm 01/10] util: add C8 format, support it with SMPTE pattern

2019-06-02 Thread Ilia Mirkin
This also adds a helper to generate a color LUT, which has to be used in conjunction with the C8 indexed format. Signed-off-by: Ilia Mirkin --- tests/util/format.c | 2 ++ tests/util/pattern.c | 75 tests/util/pattern.h | 4 +++ 3 files changed

[PATCH libdrm 03/10] util: add gradient pattern

2019-06-02 Thread Ilia Mirkin
). This is really only useful on 10bpc formats, but we also add support for 8bpc formats to ease testing. In the future, this could be applied to 16bpc formats as well. Signed-off-by: Ilia Mirkin --- tests/util/pattern.c | 113 +-- tests/util/pattern.h | 1 + 2

[PATCH libdrm 09/10] modetest: add the ability to specify fill patterns on the commandline

2019-06-02 Thread Ilia Mirkin
Instead of hacking the binary every time, we can now specify directly. Signed-off-by: Ilia Mirkin --- tests/modetest/modetest.c | 29 - tests/util/pattern.c | 20 tests/util/pattern.h | 2 ++ 3 files changed, 46 insertions(+), 5

[PATCH libdrm 07/10] modetest: add an add_property_optional variant that does not print errors

2019-06-02 Thread Ilia Mirkin
As new features are added and others are declared to be legacy, it's nice to be able to implement fallbacks. As such, create a property-setting variant that does not generate errors which can very well be entirely expected. Will be used for gamma control in a future change. Signed-off-by:

[PATCH libdrm 06/10] modetest: don't pretend that atomic mode includes a format

2019-06-02 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- tests/modetest/modetest.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/modetest/modetest.c b/tests/modetest/modetest.c index 9c85c07b..a1c81f6c 100644 --- a/tests/modetest/modetest.c +++ b/tests/modetest/modetest.c @@ -1335,8

[PATCH libdrm 04/10] util: add fp16 format support

2019-06-02 Thread Ilia Mirkin
This change adds support for all current patterns. Signed-off-by: Ilia Mirkin --- tests/util/format.c | 5 ++ tests/util/pattern.c | 207 ++- 2 files changed, 209 insertions(+), 3 deletions(-) diff --git a/tests/util/format.c b/tests/util/format.c

[PATCH libdrm 05/10] util: add cairo drawing for 30bpp formats when available

2019-06-02 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- tests/util/pattern.c | 8 1 file changed, 8 insertions(+) diff --git a/tests/util/pattern.c b/tests/util/pattern.c index 37796dbf..d197c444 100644 --- a/tests/util/pattern.c +++ b/tests/util/pattern.c @@ -788,6 +788,14 @@ static void make_pwetty(void

[PATCH libdrm 10/10] modetest: add FP16 format support

2019-06-02 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- tests/modetest/buffers.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/tests/modetest/buffers.c b/tests/modetest/buffers.c index 5ec4ec8e..8a8d9e01 100644 --- a/tests/modetest/buffers.c +++ b/tests/modetest/buffers.c @@ -194,6 +194,13

Re: [PATCH libdrm 00/10] Add C8, 30bpp and FP16 support to modetest

2019-06-03 Thread Ilia Mirkin
On Mon, Jun 3, 2019 at 3:32 AM Daniel Vetter wrote: > > On Sun, Jun 02, 2019 at 08:40:08PM -0400, Ilia Mirkin wrote: > > This series improves the pattern generation logic to support additional > > formats, as well as a new "gradient" pattern (see patch comments

Re: [PATCH libdrm 00/10] Add C8, 30bpp and FP16 support to modetest

2019-06-03 Thread Ilia Mirkin
On Sun, Jun 2, 2019 at 8:40 PM Ilia Mirkin wrote: > > This series improves the pattern generation logic to support additional > formats, as well as a new "gradient" pattern (see patch comments on why > I found it useful). > > Furthermore, these formats are piped throug

Re: [PATCH libdrm 06/10] modetest: don't pretend that atomic mode includes a format

2019-06-06 Thread Ilia Mirkin
On Thu, Jun 6, 2019 at 11:51 AM Emil Velikov wrote: > > On Mon, 3 Jun 2019 at 01:40, Ilia Mirkin wrote: > > > > Signed-off-by: Ilia Mirkin > > --- > > tests/modetest/modetest.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > >

[PATCH 1/2] drm/nouveau/kms/gf119-: add ctm property support

2019-06-10 Thread Ilia Mirkin
This adds support on GF119:GV100 (exclusive) for CTM (aka CSC). Signed-off-by: Ilia Mirkin --- drivers/gpu/drm/nouveau/dispnv50/atom.h | 6 ++ drivers/gpu/drm/nouveau/dispnv50/base907c.c | 65 + drivers/gpu/drm/nouveau/dispnv50/wndw.c | 13 + drivers/gpu/drm

[PATCH 2/2] drm/nouveau/kms/nv50-: enable modern color management properties

2019-06-10 Thread Ilia Mirkin
For GF119:GV100, we can enable DEGAMMA/CTM/GAMMA. For earlier GPUs, as there is no CTM, having both degamma and gamma is a bit pointless. Later GPUs currently lack an implementation. Signed-off-by: Ilia Mirkin --- drivers/gpu/drm/nouveau/dispnv50/head.c | 5 + 1 file changed, 5 insertions

[PATCH v2] drm/nouveau/kms/gf119-: add ctm property support

2019-06-11 Thread Ilia Mirkin
This adds support on GF119:GV100 (exclusive) for CTM (aka CSC). Signed-off-by: Ilia Mirkin --- v1 -> v2: - ctm -> csc - mark csc.valid = false when there is no ctm property drivers/gpu/drm/nouveau/dispnv50/atom.h | 6 ++ drivers/gpu/drm/nouveau/dispnv50/base907c.

Re: [RFC/WIP] drm/rockchip: Support CRTC gamma LUT

2019-06-13 Thread Ilia Mirkin
Note that userspace may provide any size of gamma lut. Have a look at i915/intel_color.c:intel_color_check which filters out only the allowed sizes. Consider having a special allowance for 256-sized LUTs since that's what most legacy userspace will set, and it seems like a waste to create a 10-bit

Re: [RFC/WIP] drm/rockchip: Support CRTC gamma LUT

2019-06-18 Thread Ilia Mirkin
On Tue, Jun 18, 2019 at 9:36 AM Ezequiel Garcia wrote: > > On Thu, 2019-06-13 at 15:36 -0400, Ilia Mirkin wrote: > > Note that userspace may provide any size of gamma lut. Have a look at > > i915/intel_color.c:intel_color_check which filters out only the > > allowed

Re: [PATCH 2/3] drm/rockchip: Add optional support for CRTC gamma LUT

2019-06-18 Thread Ilia Mirkin
On Tue, Jun 18, 2019 at 5:43 PM Ezequiel Garcia wrote: > > Add an optional CRTC gamma LUT support, and enable it on RK3288. > This is currently enabled via a separate address resource, > which needs to be specified in the devicetree. > > The address resource is required because on some SoCs, such

Re: nouveau: DRM: GPU lockup - switching to software fbcon

2019-06-18 Thread Ilia Mirkin
On Wed, Jun 19, 2019 at 1:08 AM Sergey Senozhatsky wrote: > > On (06/14/19 11:50), Sergey Senozhatsky wrote: > > dmesg > > > > nouveau :01:00.0: DRM: GPU lockup - switching to software fbcon > > nouveau :01:00.0: fifo: SCHED_ERROR 0a [CTXSW_TIMEOUT] > > nouveau :01:00.0: fifo: runli

Re: nouveau: DRM: GPU lockup - switching to software fbcon

2019-06-18 Thread Ilia Mirkin
On Wed, Jun 19, 2019 at 1:48 AM Sergey Senozhatsky wrote: > > On (06/19/19 01:20), Ilia Mirkin wrote: > > On Wed, Jun 19, 2019 at 1:08 AM Sergey Senozhatsky > > wrote: > > > > > > On (06/14/19 11:50), Sergey Senozhatsky wrote: > > > > dmesg > &

[PATCH] drm/nouveau/kms/gf119-: allow both 256- and 1024-sized LUTs to be used

2019-06-19 Thread Ilia Mirkin
The hardware supports either size. Also add checks to ensure that only these two sizes may be used for supplying a LUT. Finally, experimental evidence suggests you can't mix sizes for degamma and gamma. Disallow this as well. Signed-off-by: Ilia Mirkin --- Note that all the gv100+ change

Re: [PATCH] drm: Dump mode picture aspect ratio

2019-06-20 Thread Ilia Mirkin
On Thu, Jun 20, 2019 at 11:46 AM Ville Syrjala wrote: > > From: Ville Syrjälä > > Currently the logs show nothing about the mode's aspect ratio. > Include that information in the normal mode dump. > > Cc: Ilia Mirkin > Signed-off-by: Ville Syrjälä > --

Re: [RFC][PATCH] libdrm: modetest: Allow selecting modes by index

2019-06-21 Thread Ilia Mirkin
to be set. > > Cc: Ilia Mirkin > Cc: Rob Clark > Cc: Bjorn Andersson > Cc: Sumit Semwal > Signed-off-by: John Stultz > --- > tests/modetest/modetest.c | 23 +-- > 1 file changed, 17 insertions(+), 6 deletions(-) > > diff --git a/tests/mode

[PATCH libdrm] util: fix include path for drm_mode.h

2019-06-22 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- tests/util/pattern.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/util/pattern.h b/tests/util/pattern.h index 424b0e19..ea38cafd 100644 --- a/tests/util/pattern.h +++ b/tests/util/pattern.h @@ -26,7 +26,7 @@ #ifndef UTIL_PATTERN_H

Re: [PATCH v2] libdrm: modetest: Allow selecting modes by index

2019-06-24 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin One minor comment below though: (Maybe let it sit on the list for a day in case anyone feels like objecting strenuously.) On Mon, Jun 24, 2019 at 4:27 PM John Stultz wrote: > > Often there are many similar modes, which cannot be selected > via modetest d

[PATCH libdrm] tests/util: fix incorrect memset argument order

2019-07-02 Thread Ilia Mirkin
Make it actually clear the LUT. Reported-by: Dave Airlie Signed-off-by: Ilia Mirkin --- tests/util/pattern.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/util/pattern.c b/tests/util/pattern.c index 42a0e5c7..bf1797d4 100644 --- a/tests/util/pattern.c +++ b/tests

Re: [Nouveau] [PATCH 20/22] mm: move hmm_vma_fault to nouveau

2019-07-03 Thread Ilia Mirkin
On Wed, Jul 3, 2019 at 1:49 PM Ralph Campbell wrote: > On 6/30/19 11:20 PM, Christoph Hellwig wrote: > > hmm_vma_fault is marked as a legacy API to get rid of, but quite suites > > the current nouvea flow. Move it to the only user in preparation for > > I didn't quite parse the phrase "quite suit

Re: [PATCH 02/60] video: hdmi: Change return type of hdmi_avi_infoframe_init() to void

2019-07-07 Thread Ilia Mirkin
On Sun, Jul 7, 2019 at 2:15 PM Laurent Pinchart wrote: > > Sorry, forgot to CC Bartlomiej on this patch. > > On Sun, Jul 07, 2019 at 09:07:54PM +0300, Laurent Pinchart wrote: > > The hdmi_avi_infoframe_init() never needs to return an error, change its > > return type to void. > > > > Signed-off-by

Re: [PATCH v2] gpu/drm_memory: fix a few warnings

2019-07-08 Thread Ilia Mirkin
On Mon, Jul 8, 2019 at 2:06 PM Qian Cai wrote: > > The opening comment mark "/**" is reserved for kernel-doc comments, so > it will generate a warning with "make W=1". > > drivers/gpu/drm/drm_memory.c:2: warning: Cannot understand * \file > drm_memory.c > > Also, silence a checkpatch warning by a

Re: [PATCH 2/2] drm/nouveau: Add HD-audio component notifier support

2019-07-22 Thread Ilia Mirkin
On Mon, Jul 22, 2019 at 10:38 AM Takashi Iwai wrote: > +static void > +nv50_audio_component_init(struct nouveau_drm *drm) > +{ > + if (!component_add(drm->dev->dev, &nv50_audio_component_bind_ops)) > + drm->audio.component_registered = true; > +} Pardon my ignorance on this to

Re: My penguin has blue feets (aka: RGB versus BGR troubles)

2019-07-26 Thread Ilia Mirkin
On Fri, Jul 26, 2019 at 4:36 PM Sam Ravnborg wrote: > > Hi all. > > The Atmel at91sam9263 has a nice LCDC IP core that supports several > formats: > DRM_FORMAT_XBGR, DRM_FORMAT_BGR888, DRM_FORMAT_BGR565 > > (It also supports a palletized C8 format, but thats for later). > > The formats are

Re: [PATCH v2 1/4] drm/format-helper: Add drm_fb_{xrgb8888, gray8}_to_mono_reversed()

2022-02-04 Thread Ilia Mirkin
On Fri, Feb 4, 2022 at 10:53 AM Thomas Zimmermann wrote: > > Hi > > Am 04.02.22 um 14:43 schrieb Javier Martinez Canillas: > > Add support to convert XR24 and 8-bit grayscale to reversed monochrome for > > drivers that control monochromatic panels, that only have 1 bit per pixel. > > > > The drm_f

Re: [PATCH v6 1/3] drm/lsdc: add drm driver for loongson display controller

2022-02-12 Thread Ilia Mirkin
On Wed, Feb 9, 2022 at 11:16 AM Maxime Ripard wrote: > > On Wed, Feb 09, 2022 at 10:38:41PM +0800, Sui Jingfeng wrote: > > On 2022/2/9 16:49, Maxime Ripard wrote: > > > On Fri, Feb 04, 2022 at 12:04:19AM +0800, Sui Jingfeng wrote: > > > > > > +/* Get the simple EDID data from the device tree > > >

Re: [PATCH] drm/nouveau/bios: Use HWSQ entry 1 for PowerBook6,1

2022-02-14 Thread Ilia Mirkin
I'm not saying this is wrong, but could you file a bug at gitlab.freedesktop.org/drm/nouveau/-/issues and include the VBIOS (/sys/kernel/debug/dri/0/vbios.rom)? That would make it easier to review the full situation. On Mon, Feb 14, 2022 at 11:03 AM Icenowy Zheng wrote: > > On PowerBook6,1 (Power

Re: [PATCH 1/2] drm: replace Compliance/Margin magic numbers with PCI_EXP_LNKCTL2 definitions

2019-11-07 Thread Ilia Mirkin
On Thu, Nov 7, 2019 at 5:21 PM Bjorn Helgaas wrote: > diff --git a/include/uapi/linux/pci_regs.h b/include/uapi/linux/pci_regs.h > index 29d6e93fd15e..03446be8a7be 100644 > --- a/include/uapi/linux/pci_regs.h > +++ b/include/uapi/linux/pci_regs.h > @@ -673,6 +673,8 @@ > #define PCI_EXP_LNKCTL2_T

Re: UDL device cannot get its own screen

2019-11-12 Thread Ilia Mirkin
On Tue, Nov 12, 2019 at 9:23 AM Böszörményi Zoltán wrote: > But no, all GPU devices (now only one, the UDL device) have screen 0 > (a.k.a. DISPLAY=:0.0) set when AutoBindGPU is true: > > [ 2444.576] xf86AutoConfigOutputDevices: xf86NumScreens 2 xf86NumGPUScreens 1 > [ 2444.576] xf86AutoConfigOut

Re: UDL device cannot get its own screen

2019-11-13 Thread Ilia Mirkin
On Wed, Nov 13, 2019 at 11:59 AM Böszörményi Zoltán wrote: > > 2019. 11. 12. 17:41 keltezéssel, Ilia Mirkin írta: > > On Tue, Nov 12, 2019 at 9:23 AM Böszörményi Zoltán wrote: > >> But no, all GPU devices (now only one, the UDL device) have screen 0 > >>

Re: [Nouveau] [PATCH 3/3] drm/nouveau: Support NVIDIA format modifiers

2019-12-11 Thread Ilia Mirkin
On Wed, Dec 11, 2019 at 4:04 PM James Jones wrote: > > Allow setting the block layout of a nouveau FB > object using DRM format modifiers. When > specified, the format modifier block layout and > kind overrides the GEM buffer's implicit layout > and kind. The specified format modifier is > valid

Re: [PATCH] drm/nouveau: declare constants as unsigned long.

2019-12-31 Thread Ilia Mirkin
Probably want ULL for 32-bit arches to be correct here too. On Tue, Dec 31, 2019 at 3:53 PM Wambui Karuga wrote: > > Explicitly declare constants are unsigned long to address the following > sparse warnings: > warning: constant is so big it is long > > Signed-off-by: Wambui Karuga > --- > drive

Re: [PATCH v4 2/3] drm/rockchip: Add optional support for CRTC gamma LUT

2019-10-10 Thread Ilia Mirkin
On Thu, Oct 10, 2019 at 12:01 PM Sean Paul wrote: > > > > +static int vop_crtc_atomic_check(struct drm_crtc *crtc, > > > > + struct drm_crtc_state *crtc_state) > > > > +{ > > > > + struct vop *vop = to_vop(crtc); > > > > + > > > > + if (vop->lut_regs && crtc_st

Re: [PATCH v2 1/4] drm/komeda: Add a new helper drm_color_ctm_s31_32_to_qm_n()

2019-10-14 Thread Ilia Mirkin
On Fri, Oct 11, 2019 at 1:43 AM james qian wang (Arm Technology China) wrote: > > Add a new helper function drm_color_ctm_s31_32_to_qm_n() for driver to > convert S31.32 sign-magnitude to Qm.n 2's complement that supported by > hardware. > > Signed-off-by: james qian wang (Arm Technology China) >

Re: [PATCH v2 1/4] drm/komeda: Add a new helper drm_color_ctm_s31_32_to_qm_n()

2019-10-14 Thread Ilia Mirkin
On Mon, Oct 14, 2019 at 9:16 PM james qian wang (Arm Technology China) wrote: > On Mon, Oct 14, 2019 at 11:58:48AM -0400, Ilia Mirkin wrote: > > On Fri, Oct 11, 2019 at 1:43 AM james qian wang (Arm Technology China) > > wrote: > > > + * > > > + * Convert and clam

Re: UDL device cannot get its own screen

2019-10-22 Thread Ilia Mirkin
On Tue, Oct 22, 2019 at 11:50 AM Böszörményi Zoltán wrote: > > Hi, > > I have the below configuration for an Intel based POS system that, > while advertises 3 outputs (DP1, VGA1 and HDMI1 with xf86-video-intel), > only two are usable. DP1 for the built-in touchscreen and VGA1 for > the external VG

Re: UDL device cannot get its own screen

2019-10-23 Thread Ilia Mirkin
On Wed, Oct 23, 2019 at 2:41 AM Böszörményi Zoltán wrote: > > 2019. 10. 22. 22:57 keltezéssel, Ilia Mirkin írta: > > On Tue, Oct 22, 2019 at 11:50 AM Böszörményi Zoltán wrote: > >> Section "Device" > >> Identifier "UD

Re: [Nouveau] [PATCH] nv50_disp_chan_mthd: ensure mthd is not NULL

2020-02-20 Thread Ilia Mirkin
Hi Frédéric, It appears Ben made his own version of this patch (probably based on the one you added to the kernel bz), and it's already upstream: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v5.6-rc2&id=0e6176c6d286316e9431b4f695940cfac4ffe6c2 Cheers, -ilia On

Re: [Nouveau] [PATCH 1/3] drm: Add separate state structure for legacy, non-KMS drivers

2020-02-25 Thread Ilia Mirkin
On Tue, Feb 25, 2020 at 10:59 AM Thomas Zimmermann wrote: > > Non-KMS drivers store state in struct drm_driver. This bloats the > structure for KMS drivers and prevents it from being declared with > 'static const' qualifiers. Moving the non-KMS state into a separate > data structure resolves this.

Re: [PATCH libdrm] modetest: call drmModeCrtcSetGamma() only if add_property_optional returns true

2020-03-03 Thread Ilia Mirkin
; > Subject: RE: [PATCH libdrm] modetest: call drmModeCrtcSetGamma() only if > > add_property_optional returns true > > > > Gentle reminder. > > > > + Ilia Mirkin, +Emil Velikov. > > > > Thanks & Regards, > > Rohit > > > > > -Or

[PATCH] drm/msm: avoid double-attaching hdmi/edp bridges

2020-03-11 Thread Ilia Mirkin
) Cc: Boris Brezillon Signed-off-by: Ilia Mirkin --- drivers/gpu/drm/msm/edp/edp.c | 4 drivers/gpu/drm/msm/hdmi/hdmi.c | 4 2 files changed, 8 deletions(-) diff --git a/drivers/gpu/drm/msm/edp/edp.c b/drivers/gpu/drm/msm/edp/edp.c index ad4e963ccd9b..106a67473af5 100644 --- a/drivers

Re: [PATCH libdrm] modetest: call drmModeCrtcSetGamma() only if add_property_optional returns true

2020-03-12 Thread Ilia Mirkin
Hm. I'm not sure offhand how to check if drmModeCrtcSetGamma is supported. I guess you could check if gamma size > 0 or something? On Thu, Mar 12, 2020, 02:39 Rohit Visavalia wrote: > Hi Ilia Mirkin, > > Thanks for the review. > > By old-fashioned way you mean to say us

Re: [PATCH libdrm] modetest: call drmModeCrtcSetGamma() only if add_property_optional returns true

2020-03-13 Thread Ilia Mirkin
uld be drivers that didn't support a LUT. On Fri, Mar 13, 2020 at 6:08 AM Rohit Visavalia wrote: > > Hi Ilia Mirkin, > > > > But it should not go for setting gamma(drmModeCrtcSetGamma) as user has not > asked to do so in just simple mode set command(modetest -M -s &

Re: [PATCH 4.19 092/190] drm/nouveau: Dont WARN_ON VCPI allocation failures

2019-09-13 Thread Ilia Mirkin
Hi Greg, This feels like it's missing a From: line. commit b513a18cf1d705bd04efd91c417e79e4938be093 Author: Lyude Paul Date: Mon Jan 28 16:03:50 2019 -0500 drm/nouveau: Don't WARN_ON VCPI allocation failures Is this an artifact of your notification-of-patches process and I never noticed

Re: [PATCH 4.19 092/190] drm/nouveau: Dont WARN_ON VCPI allocation failures

2019-09-13 Thread Ilia Mirkin
On Fri, Sep 13, 2019 at 10:46 AM Sasha Levin wrote: > > On Fri, Sep 13, 2019 at 09:33:36AM -0400, Ilia Mirkin wrote: > >Hi Greg, > > > >This feels like it's missing a From: line. > > > >commit b513a18cf1d705bd04efd91c417e79e4938be093 > >Author:

Re: [PATCH 4.19 092/190] drm/nouveau: Dont WARN_ON VCPI allocation failures

2019-09-13 Thread Ilia Mirkin
On Fri, Sep 13, 2019 at 11:01 AM Sasha Levin wrote: > > On Fri, Sep 13, 2019 at 03:54:56PM +0100, Greg Kroah-Hartman wrote: > >On Fri, Sep 13, 2019 at 10:46:27AM -0400, Sasha Levin wrote: > >> On Fri, Sep 13, 2019 at 09:33:36AM -0400, Ilia Mirkin wrote: > >> >

Re: [PATCH 2/4] drm/nouveau: dispnv50: Remove nv50_mstc_best_encoder()

2019-09-13 Thread Ilia Mirkin
On Fri, Sep 13, 2019 at 6:05 PM Lyude Paul wrote: > > When drm_connector_helper_funcs->atomic_best_encoder is defined, > ->best_encoder is ignored both by the atomic modesetting helpers. That By both the atomic modesetting helpers and ... (usually "both" implies 2 things) > being said, this hook

Re: [PATCH 13/36] drm/nouveau: use bpp instead of cpp for drm_format_info

2019-09-23 Thread Ilia Mirkin
On Mon, Sep 23, 2019 at 8:56 AM Sandy Huang wrote: > > cpp[BytePerPlane] can't describe the 10bit data format correctly, > So we use bpp[BitPerPlane] to instead cpp. > > Signed-off-by: Sandy Huang > --- > drivers/gpu/drm/nouveau/dispnv04/crtc.c | 7 --- > drivers/gpu/drm/nouveau/dispnv50

Re: [Nouveau] Is Nouveau really using the io_reserve_lru?

2019-09-27 Thread Ilia Mirkin
On Thu, Sep 26, 2019 at 5:44 PM Ben Skeggs wrote: > > On Tue, 24 Sep 2019 at 22:19, Christian König > wrote: > > > > Hi guys, > > > > while working through more old TTM functionality I stumbled over the > > io_reserve_lru. > > > > Basic idea is that when this flag is set the driver->io_mem_reserv

Re: [PATCH 2/3] drm/komeda: Add drm_ctm_to_coeffs()

2019-09-30 Thread Ilia Mirkin
On Mon, Sep 30, 2019 at 7:05 AM Brian Starkey wrote: > > Hi James, > > On Mon, Sep 30, 2019 at 04:54:41AM +, james qian wang (Arm Technology > China) wrote: > > This function is used to convert drm_color_ctm S31.32 sign-magnitude > > value to komeda required Q2.12 2's complement > > > > Signe

Re: Display-Port HPD handling, link status, and bandwidth checks

2019-08-25 Thread Ilia Mirkin
You'll probably get a more detailed reply during the week, but for now have a look at the "link-status" property, which was made for precisely this situation. I think basically the idea is to ignore link training as part of the modeset, and just return the link status depending on the success. (And

Re: [Nouveau] [PATCH v3 5/7] drm/nouveau: utilize subconnector property for DP

2019-08-26 Thread Ilia Mirkin
This should probably be fixed to account for the scenario where an HDMI connector is plugged directly into the DP++ port. I don't think the dp.subconnector property will be valid in that case. (Unfortunately I don't remember how one detects that particular situation.) On Mon, Aug 26, 2019 at 9:22

  1   2   3   4   5   6   >