Re: [PATCH v2] drm/mediatek: add dither 6 setting

2021-07-19 Thread Hsin-Yi Wang
On Mon, Jul 19, 2021 at 4:24 PM Yongqiang Niu wrote: > > in the first version dither patch > https://patchwork.kernel.org/project/linux-mediatek/patch/1553667561-25447-13-git-send-email-yongqiang@mediatek.com/ > dither 6 setting is included in that patch I think you don't need to link the firs

Re: [PATCH v3] Fixes: a6b7c98afdca(drm/mediatek: add mtk_dither_set_common() function)

2021-07-19 Thread Hsin-Yi Wang
On Tue, Jul 20, 2021 at 1:51 PM Yongqiang Niu wrote: > > dither 6 setting is missed in a6b7c98afdca > bit 1 is lfsr_en( "Enables LFSR-type dithering"), need enable > bit 2 is rdither_en(Enables running order dithering), need disable > Fixes tag should be here, and the title of this patch should b

[PATCH 1/2] drm/mediatek: set panel orientation before drm_dev_register().

2021-04-08 Thread Hsin-Yi Wang
/0x1c0 [4.893879] do_el0_svc_compat+0x28/0x3c [4.897791] el0_svc_compat+0x10/0x1c [4.901441] el0_sync_compat_handler+0xa8/0xcc [4.905873] el0_sync_compat+0x178/0x180 [4.909783] ---[ end trace b4f2db9d9c88610c ]--- Signed-off-by: Hsin-Yi Wang --- drivers/gpu/drm/mediatek/mtk_dsi

[PATCH 2/2] arm64: dts: mt8183: Add panel rotation

2021-04-08 Thread Hsin-Yi Wang
krane, kakadu, and kodama boards have a default panel rotation. Signed-off-by: Hsin-Yi Wang --- arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi

Re: [PATCH 1/2] drm/mediatek: set panel orientation before drm_dev_register().

2021-04-20 Thread Hsin-Yi Wang
On Fri, Apr 9, 2021 at 12:53 PM Hsin-Yi Wang wrote: > > drm_dev_register() sets connector->registration_state to > DRM_CONNECTOR_REGISTERED and dev->registered to true. If > drm_connector_set_panel_orientation() is first called after > drm_dev_register(), it will fail sever

Re: [PATCH 1/2] drm/mediatek: set panel orientation before drm_dev_register().

2021-04-20 Thread Hsin-Yi Wang
On Wed, Apr 21, 2021 at 7:47 AM Chun-Kuang Hu wrote: > > Hi, Hsin-Yi: > > Hsin-Yi Wang 於 2021年4月20日 週二 下午5:05寫道: > > > > On Fri, Apr 9, 2021 at 12:53 PM Hsin-Yi Wang wrote: > > > > > > drm_dev_register() sets connector->registration_state to > >

[PATCH] drm/mediatek: clear pending flag when cmdq packet is done.

2021-04-22 Thread Hsin-Yi Wang
From: CK Hu In cmdq mode, packet may be flushed before it is executed, so the pending flag should be cleared after cmdq packet is done. Signed-off-by: CK Hu Signed-off-by: Hsin-Yi Wang --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 56 +--- include/linux/mailbox/mtk-cmdq

[PATCH v2 1/2] gpu: drm: init set panel orientation property earlier

2021-04-25 Thread Hsin-Yi Wang
off-by: Hsin-Yi Wang --- v1: https://patchwork.kernel.org/project/linux-mediatek/patch/20210409045314.3420733-1-hsi...@chromium.org/ --- drivers/gpu/drm/drm_connector.c | 28 +++- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/drm_connect

[PATCH v2 2/2] arm64: dts: mt8183: Add panel rotation

2021-04-25 Thread Hsin-Yi Wang
krane, kakadu, and kodama boards have a default panel rotation. Signed-off-by: Hsin-Yi Wang --- arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi

Re: [PATCH 1/2] drm/mediatek: set panel orientation before drm_dev_register().

2021-04-25 Thread Hsin-Yi Wang
On Fri, Apr 23, 2021 at 9:53 PM Sean Paul wrote: > > On Fri, Apr 9, 2021 at 12:53 AM Hsin-Yi Wang wrote: > > > > drm_dev_register() sets connector->registration_state to > > DRM_CONNECTOR_REGISTERED and dev->registered to true. If > > drm_connector_set_panel

[PATCH v3 1/3] gpu: drm: separate panel orientation property creating and value setting

2021-04-26 Thread Hsin-Yi Wang
/0x180 [4.909783] ---[ end trace b4f2db9d9c88610c ]--- Signed-off-by: Hsin-Yi Wang --- v3: create property in dsi driver and set value in panel. v2: create property in connector init https://patchwork.kernel.org/project/linux-mediatek/patch/20210426051848.2600890-1-hsi...@chromium.org/ v1: set

[PATCH v3 2/3] drm/mediatek: init panel orientation property

2021-04-26 Thread Hsin-Yi Wang
Init panel orientation property after connector is initialized. Let the panel driver decides the orientation value later. Signed-off-by: Hsin-Yi Wang --- drivers/gpu/drm/mediatek/mtk_dsi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm

[PATCH v3 3/3] arm64: dts: mt8183: Add panel rotation

2021-04-26 Thread Hsin-Yi Wang
krane, kakadu, and kodama boards have a default panel rotation. Signed-off-by: Hsin-Yi Wang --- arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi

Re: [PATCH v2 1/2] gpu: drm: init set panel orientation property earlier

2021-04-26 Thread Hsin-Yi Wang
On Mon, Apr 26, 2021 at 11:33 PM Ville Syrjälä wrote: > > On Mon, Apr 26, 2021 at 01:18:47PM +0800, Hsin-Yi Wang wrote: > > drm_dev_register() sets connector->registration_state to > > DRM_CONNECTOR_REGISTERED and dev->registered to true. If > > drm_connector_se

[PATCH] drm/bridge: anx7625: Fix power on delay

2021-04-26 Thread Hsin-Yi Wang
>From anx7625 spec, the delay between powering on power supplies and gpio should be larger than 10ms. Fixes: 6c744983004e ("drm/bridge: anx7625: disable regulators when power off") Signed-off-by: Hsin-Yi Wang --- drivers/gpu/drm/bridge/analogix/anx7625.c | 2 +- 1 file changed

[PATCH v4 1/3] gpu: drm: separate panel orientation property creating and value setting

2021-04-27 Thread Hsin-Yi Wang
/0x180 [4.909783] ---[ end trace b4f2db9d9c88610c ]--- Signed-off-by: Hsin-Yi Wang --- v4, v3: create property in dsi driver and set value in panel. v2: create property in connector init https://patchwork.kernel.org/project/linux-mediatek/patch/20210426051848.2600890-1-hsi...@chromium.org/ v

[PATCH v4 2/3] drm/mediatek: init panel orientation property

2021-04-27 Thread Hsin-Yi Wang
Init panel orientation property after connector is initialized. Let the panel driver decides the orientation value later. Signed-off-by: Hsin-Yi Wang --- drivers/gpu/drm/mediatek/mtk_dsi.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers

[PATCH v4 3/3] arm64: dts: mt8183: Add panel rotation

2021-04-27 Thread Hsin-Yi Wang
krane, kakadu, and kodama boards have a default panel rotation. Signed-off-by: Hsin-Yi Wang --- arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi

[PATCH v2] drm/bridge: anx7625: Fix power on delay

2021-04-28 Thread Hsin-Yi Wang
>From anx7625 spec, the delay between powering on power supplies and gpio should be larger than 10ms. Fixes: 6c744983004e ("drm/bridge: anx7625: disable regulators when power off") Signed-off-by: Hsin-Yi Wang Reviewed-by: Neil Armstrong --- v1->v2: Extend sleep range a bit as

[PATCH v5 1/4] gpu: drm: separate panel orientation property creating and value setting

2021-04-28 Thread Hsin-Yi Wang
/0x180 [4.909783] ---[ end trace b4f2db9d9c88610c ]--- Signed-off-by: Hsin-Yi Wang --- v5: don't create property in set_panel_orientation. v4, v3: create property in dsi driver and set value in panel. v2: create property in connector init https://patchwork.kernel.org/project/linux-med

[PATCH v5 3/4] drm/i915: init panel orientation property

2021-04-28 Thread Hsin-Yi Wang
Creating the panel orientation property first since we separate the property creating and value setting. Signed-off-by: Hsin-Yi Wang --- drivers/gpu/drm/i915/display/icl_dsi.c | 1 + drivers/gpu/drm/i915/display/intel_dp.c | 1 + drivers/gpu/drm/i915/display/vlv_dsi.c | 1 + 3 files changed

[PATCH v5 4/4] arm64: dts: mt8183: Add panel rotation

2021-04-28 Thread Hsin-Yi Wang
krane, kakadu, and kodama boards have a default panel rotation. Signed-off-by: Hsin-Yi Wang --- arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi

[PATCH v5 2/4] drm/mediatek: init panel orientation property

2021-04-28 Thread Hsin-Yi Wang
Init panel orientation property after connector is initialized. Let the panel driver decides the orientation value later. Signed-off-by: Hsin-Yi Wang --- drivers/gpu/drm/mediatek/mtk_dsi.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers

[PATCH v6 2/3] drm/mediatek: init panel orientation property

2021-04-28 Thread Hsin-Yi Wang
Init panel orientation property after connector is initialized. Let the panel driver decides the orientation value later. Signed-off-by: Hsin-Yi Wang --- drivers/gpu/drm/mediatek/mtk_dsi.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers

[PATCH v6 3/3] arm64: dts: mt8183: Add panel rotation

2021-04-28 Thread Hsin-Yi Wang
krane, kakadu, and kodama boards have a default panel rotation. Signed-off-by: Hsin-Yi Wang --- arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi

[PATCH v6 1/3] gpu: drm: separate panel orientation property creating and value setting

2021-04-28 Thread Hsin-Yi Wang
/0x180 [4.909783] ---[ end trace b4f2db9d9c88610c ]--- Signed-off-by: Hsin-Yi Wang --- v6, v5: don't create property in set_panel_orientation. v4, v3: create property in dsi driver and set value in panel. v2: create property in connector init https://patchwork.kernel.org/project/linux-med

Re: [PATCH v8] drm/bridge: add it6505 driver

2021-08-10 Thread Hsin-Yi Wang
On Tue, Aug 10, 2021 at 7:31 PM allen wrote: > > This adds support for the iTE IT6505. > This device can convert DPI signal to DP output. > > From: Allen Chen > Tested-by: Hsin-yi Wang > Signed-off-by: Hermes Wu > Signed-off-by: Allen Chen > --- <-- Add this

Re: [PATCH v4 2/2] drm/bridge: anx7625: disable regulators when power off

2021-03-17 Thread Hsin-Yi Wang
On Wed, Feb 24, 2021 at 2:14 PM Hsin-Yi Wang wrote: > > When suspending the driver, anx7625_power_standby() will be called to > turn off reset-gpios and enable-gpios. However, power supplies are not > disabled. To save power, the driver can get the power supply regulators > and t

Re: [PATCH] drm/mediatek: Add missing MODULE_DEVICE_TABLE()

2021-03-30 Thread Hsin-Yi Wang
rates correct modalias for automatic loading > > when these drivers are compiled as an external module. > > > > Signed-off-by: Boris Brezillon > > Signed-off-by: Enric Balletbo i Serra Reviewed-by: Hsin-Yi Wang > > A gentle ping for someone to review this pat

[RESEND PATCH v4 1/2] dt-bindings: drm/bridge: anx7625: Add power supplies

2021-03-31 Thread Hsin-Yi Wang
anx7625 requires 3 power supply regulators. Signed-off-by: Hsin-Yi Wang Reviewed-by: Rob Herring Reviewed-by: Robert Foss --- v3->v4: rebase to drm-misc/for-linux-next --- .../bindings/display/bridge/analogix,anx7625.yaml | 15 +++ 1 file changed, 15 insertions(+) diff --git

[RESEND PATCH v4 2/2] drm/bridge: anx7625: disable regulators when power off

2021-03-31 Thread Hsin-Yi Wang
When suspending the driver, anx7625_power_standby() will be called to turn off reset-gpios and enable-gpios. However, power supplies are not disabled. To save power, the driver can get the power supply regulators and turn off them in anx7625_power_standby(). Signed-off-by: Hsin-Yi Wang Reviewed

[PATCH v3 2/2] drm/bridge: anx7625: disable regulators when power off

2021-01-15 Thread Hsin-Yi Wang
When suspending the driver, anx7625_power_standby() will be called to turn off reset-gpios and enable-gpios. However, power supplies are not disabled. To save power, the driver can get the power supply regulators and turn off them in anx7625_power_standby(). Signed-off-by: Hsin-Yi Wang

[PATCH v3 1/2] dt-bindings: drm/bridge: anx7625: Add power supplies

2021-01-15 Thread Hsin-Yi Wang
anx7625 requires 3 power supply regulators. Signed-off-by: Hsin-Yi Wang Reviewed-by: Rob Herring --- .../bindings/display/bridge/analogix,anx7625.yaml | 15 +++ 1 file changed, 15 insertions(+) diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b

Re: [PATCH v4, 00/10] soc: mediatek: mmsys: Use function call for setting the routing registers

2021-01-19 Thread Hsin-Yi Wang
ys: Use function call for setting the routing > registers > soc: mediatek: mmsys: add mt8183 function call for setting the routing > registers patch 01 ~ 05: I've tested on a mt8183 device, so Tested-by: Hsin-Yi Wang > soc: mediatek: mmsys: add component OVL_2L2 > soc:

Re: [PATCH v3, 05/15] drm/mediatek: add component POSTMASK

2021-01-26 Thread Hsin-Yi Wang
On Mon, Jan 11, 2021 at 3:44 PM Yongqiang Niu wrote: > > This patch add component POSTMASK, > > Signed-off-by: Yongqiang Niu > --- > drivers/gpu/drm/mediatek/Makefile| 1 + > drivers/gpu/drm/mediatek/mtk_disp_postmask.c | 160 > +++ > drivers/gpu/drm/mediat

[PATCH v10 8/9] drm/mediatek: add DDP support for MT8183

2021-01-27 Thread Hsin-Yi Wang
From: Yongqiang Niu Add DDP support for MT8183 SoC. Signed-off-by: Yongqiang Niu Signed-off-by: Hsin-Yi Wang --- drivers/soc/mediatek/mtk-mutex.c | 50 1 file changed, 50 insertions(+) diff --git a/drivers/soc/mediatek/mtk-mutex.c b/drivers/soc/mediatek/mtk

[PATCH v10 3/9] drm/mediatek: add RDMA fifo size error handle

2021-01-27 Thread Hsin-Yi Wang
From: Yongqiang Niu This patch add RDMA fifo size error handle rdma fifo size will not always bigger than the calculated threshold if that case happened, we need set fifo size as the threshold Signed-off-by: Yongqiang Niu Signed-off-by: Hsin-Yi Wang --- drivers/gpu/drm/mediatek

[PATCH v10 4/9] drm/mediatek: generalize mtk_dither_set() function

2021-01-27 Thread Hsin-Yi Wang
There may be data structure other than mtk_ddp_comp_dev that would call mtk_dither_set(), so use regs as parameter instead of device. Signed-off-by: Hsin-Yi Wang --- drivers/gpu/drm/mediatek/mtk_disp_drv.h | 4 drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 25 + 2

[PATCH v10 0/9] drm/mediatek: add support for mediatek SOC MT8183

2021-01-27 Thread Hsin-Yi Wang
in patch 22 - add vmap support for mediatek drm in patch 23 - fix page offset issue for mmap function in patch 24 - enable allow_fb_modifiers for mediatek drm in patch 25 Hsin-Yi Wang (1): drm/mediatek: generalize mtk_dither_set() function Yongqiang Niu (8): arm64: dts: mt8183: rename rdma

[PATCH v10 5/9] drm/mediatek: separate gamma module

2021-01-27 Thread Hsin-Yi Wang
From: Yongqiang Niu mt8183 gamma module will different with mt8173 separate gamma for add private data Signed-off-by: Yongqiang Niu Signed-off-by: Hsin-Yi Wang --- drivers/gpu/drm/mediatek/Makefile | 1 + drivers/gpu/drm/mediatek/mtk_disp_drv.h | 10 ++ drivers/gpu/drm

[PATCH v10 9/9] drm/mediatek: add support for mediatek SOC MT8183

2021-01-27 Thread Hsin-Yi Wang
From: Yongqiang Niu 1. add ovl private data 2. add rdma private data 3. add gamma privte data 4. add main and external path module for crtc create Signed-off-by: Yongqiang Niu Signed-off-by: Hsin-Yi Wang --- drivers/gpu/drm/mediatek/mtk_disp_gamma.c | 1 + drivers/gpu/drm/mediatek

[PATCH v10 2/9] arm64: dts: mt8183: refine gamma compatible name

2021-01-27 Thread Hsin-Yi Wang
From: Yongqiang Niu mt8183 gamma is different with mt8173 remove mt8173 compatible name for mt8183 gamma Signed-off-by: Yongqiang Niu Signed-off-by: Hsin-Yi Wang --- arch/arm64/boot/dts/mediatek/mt8183.dtsi | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/arm64/boot

[PATCH v10 6/9] drm/mediatek: add has_dither private data for gamma

2021-01-27 Thread Hsin-Yi Wang
From: Yongqiang Niu Not all SoC has dither function in gamma module. Add private data to control this function setting. Signed-off-by: Yongqiang Niu Signed-off-by: Hsin-Yi Wang --- drivers/gpu/drm/mediatek/mtk_disp_gamma.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions

[PATCH v10 1/9] arm64: dts: mt8183: rename rdma fifo size

2021-01-27 Thread Hsin-Yi Wang
From: Yongqiang Niu property name must include only lowercase and '-' Signed-off-by: Yongqiang Niu Signed-off-by: Hsin-Yi Wang Reviewed-by: Chun-Kuang Hu --- arch/arm64/boot/dts/mediatek/mt8183.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm6

[PATCH v10 7/9] drm/mediatek: enable dither function

2021-01-27 Thread Hsin-Yi Wang
From: Yongqiang Niu for 5 or 6 bpc panel, we need enable dither function to improve the display quality Signed-off-by: Yongqiang Niu Signed-off-by: Hsin-Yi Wang --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 37 - 1 file changed, 36 insertions(+), 1 deletion(-) diff

[PATCH v11 7/9] drm/mediatek: enable dither function

2021-01-28 Thread Hsin-Yi Wang
From: Yongqiang Niu for 5 or 6 bpc panel, we need enable dither function to improve the display quality Signed-off-by: Yongqiang Niu Signed-off-by: Hsin-Yi Wang --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 44 - 1 file changed, 43 insertions(+), 1 deletion(-) diff

[PATCH v11 6/9] drm/mediatek: add has_dither private data for gamma

2021-01-28 Thread Hsin-Yi Wang
From: Yongqiang Niu Not all SoC has dither function in gamma module. Add private data to control this function setting. Signed-off-by: Yongqiang Niu Signed-off-by: Hsin-Yi Wang Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_disp_gamma.c | 12 +--- 1 file changed, 9 insertions

[PATCH v11 8/9] soc: mediatek: add mtk mutex support for MT8183

2021-01-28 Thread Hsin-Yi Wang
From: Yongqiang Niu Add mtk mutex support for MT8183 SoC. Signed-off-by: Yongqiang Niu Signed-off-by: Hsin-Yi Wang --- drivers/soc/mediatek/mtk-mutex.c | 50 1 file changed, 50 insertions(+) diff --git a/drivers/soc/mediatek/mtk-mutex.c b/drivers/soc

[PATCH v11 4/9] drm/mediatek: add mtk_dither_set_common() function

2021-01-28 Thread Hsin-Yi Wang
Current implementation of mtk_dither_set() cast dev data to struct mtk_ddp_comp_dev. But other devices with different dev data would also call this function. Separate necessary parameters out so other device components (dither, gamma) can call this function. Signed-off-by: Hsin-Yi Wang

[PATCH v11 0/9] drm/mediatek: add support for mediatek SOC MT8183

2021-01-28 Thread Hsin-Yi Wang
display nodes - adjust display clock control flow in patch 22 - add vmap support for mediatek drm in patch 23 - fix page offset issue for mmap function in patch 24 - enable allow_fb_modifiers for mediatek drm in patch 25 Hsin-Yi Wang (1): drm/mediatek: add mtk_dither_set_common() function

[PATCH v11 2/9] arm64: dts: mt8183: refine gamma compatible name

2021-01-28 Thread Hsin-Yi Wang
From: Yongqiang Niu mt8183 gamma is different with mt8173 remove mt8173 compatible name for mt8183 gamma Signed-off-by: Yongqiang Niu Signed-off-by: Hsin-Yi Wang --- arch/arm64/boot/dts/mediatek/mt8183.dtsi | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/arm64/boot

[PATCH v11 1/9] arm64: dts: mt8183: rename rdma fifo size

2021-01-28 Thread Hsin-Yi Wang
From: Yongqiang Niu property name must include only lowercase and '-' Signed-off-by: Yongqiang Niu Signed-off-by: Hsin-Yi Wang Reviewed-by: Chun-Kuang Hu --- arch/arm64/boot/dts/mediatek/mt8183.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm6

[PATCH v11 3/9] drm/mediatek: add RDMA fifo size error handle

2021-01-28 Thread Hsin-Yi Wang
From: Yongqiang Niu This patch add RDMA fifo size error handle rdma fifo size will not always bigger than the calculated threshold if that case happened, we need set fifo size as the threshold Signed-off-by: Yongqiang Niu Signed-off-by: Hsin-Yi Wang --- drivers/gpu/drm/mediatek

Re: [PATCH v10 4/9] drm/mediatek: generalize mtk_dither_set() function

2021-01-28 Thread Hsin-Yi Wang
On Thu, Jan 28, 2021 at 12:39 PM CK Hu wrote: > > Hi, Hsin-Yi: > > On Wed, 2021-01-27 at 12:54 +0800, Hsin-Yi Wang wrote: > > There may be data structure other than mtk_ddp_comp_dev that would call > > mtk_dither_set(), so use regs as parameter instead of device. >

[PATCH v11 9/9] drm/mediatek: add support for mediatek SOC MT8183

2021-01-28 Thread Hsin-Yi Wang
From: Yongqiang Niu 1. add ovl private data 2. add rdma private data 3. add gamma privte data 4. add main and external path module for crtc create Signed-off-by: Yongqiang Niu Signed-off-by: Hsin-Yi Wang Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_disp_gamma.c | 1 + drivers/gpu

Re: [PATCH v10 8/9] drm/mediatek: add DDP support for MT8183

2021-01-28 Thread Hsin-Yi Wang
On Thu, Jan 28, 2021 at 2:13 PM CK Hu wrote: > > Hi, Hsin-Yi: > > Modify the title's prefix to 'soc: mediatek:' > > On Wed, 2021-01-27 at 12:54 +0800, Hsin-Yi Wang wrote: > > From: Yongqiang Niu > > > > Add DDP support for MT8183 SoC. > >

[PATCH v11 5/9] drm/mediatek: separate gamma module

2021-01-28 Thread Hsin-Yi Wang
From: Yongqiang Niu mt8183 gamma module will different with mt8173 separate gamma for add private data Signed-off-by: Yongqiang Niu Signed-off-by: Hsin-Yi Wang Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/Makefile | 1 + drivers/gpu/drm/mediatek/mtk_disp_drv.h | 10

[PATCH v12 8/8] drm/mediatek: add support for mediatek SOC MT8183

2021-01-28 Thread Hsin-Yi Wang
From: Yongqiang Niu 1. add ovl private data 2. add rdma private data 3. add gamma privte data 4. add main and external path module for crtc create Signed-off-by: Yongqiang Niu Signed-off-by: Hsin-Yi Wang Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_disp_gamma.c | 1 + drivers/gpu

[PATCH v12 4/8] drm/mediatek: separate gamma module

2021-01-28 Thread Hsin-Yi Wang
From: Yongqiang Niu mt8183 gamma module will different with mt8173 separate gamma for add private data Signed-off-by: Yongqiang Niu Signed-off-by: Hsin-Yi Wang Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/Makefile | 1 + drivers/gpu/drm/mediatek/mtk_disp_drv.h | 10

Re: [PATCH v11 3/9] drm/mediatek: add RDMA fifo size error handle

2021-01-28 Thread Hsin-Yi Wang
On Thu, Jan 28, 2021 at 3:52 PM CK Hu wrote: > > Hi, Hsin-Yi: > > On Thu, 2021-01-28 at 15:27 +0800, Hsin-Yi Wang wrote: > > From: Yongqiang Niu > > > > This patch add RDMA fifo size error handle > > rdma fifo size will not always bigger than the calculated

[PATCH v12 7/8] soc: mediatek: add mtk mutex support for MT8183

2021-01-28 Thread Hsin-Yi Wang
From: Yongqiang Niu Add mtk mutex support for MT8183 SoC. Signed-off-by: Yongqiang Niu Signed-off-by: Hsin-Yi Wang --- drivers/soc/mediatek/mtk-mutex.c | 50 1 file changed, 50 insertions(+) diff --git a/drivers/soc/mediatek/mtk-mutex.c b/drivers/soc

[PATCH v12 2/8] arm64: dts: mt8183: refine gamma compatible name

2021-01-28 Thread Hsin-Yi Wang
From: Yongqiang Niu mt8183 gamma is different with mt8173 remove mt8173 compatible name for mt8183 gamma Fixes: 91f9c963ce79 ("arm64: dts: mt8183: Add display nodes for MT8183") Signed-off-by: Yongqiang Niu Signed-off-by: Hsin-Yi Wang Reviewed-by: Enric Balletbo i Serra --- arch/

[PATCH v12 1/8] arm64: dts: mt8183: rename rdma fifo size

2021-01-28 Thread Hsin-Yi Wang
From: Yongqiang Niu property name must include only lowercase and '-' Fixes: 91f9c963ce79 ("arm64: dts: mt8183: Add display nodes for MT8183") Signed-off-by: Yongqiang Niu Signed-off-by: Hsin-Yi Wang Reviewed-by: Chun-Kuang Hu Reviewed-by: Enric Balletbo i Serra ---

[PATCH v12 6/8] drm/mediatek: enable dither function

2021-01-28 Thread Hsin-Yi Wang
From: Yongqiang Niu for 5 or 6 bpc panel, we need enable dither function to improve the display quality Signed-off-by: Yongqiang Niu Signed-off-by: Hsin-Yi Wang --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git

Re: [PATCH v11 7/9] drm/mediatek: enable dither function

2021-01-28 Thread Hsin-Yi Wang
t; > > > On Thu, 2021-01-28 at 15:28 +0800, Hsin-Yi Wang wrote: > > > > > From: Yongqiang Niu > > > > > > > > > > for 5 or 6 bpc panel, we need enable dither function > > > > > to improve the display quality > > > > &

[PATCH v12 0/8] drm/mediatek: add support for mediatek SOC MT8183

2021-01-28 Thread Hsin-Yi Wang
ifiers for mediatek drm in patch 25 Hsin-Yi Wang (1): drm/mediatek: add mtk_dither_set_common() function Yongqiang Niu (7): arm64: dts: mt8183: rename rdma fifo size arm64: dts: mt8183: refine gamma compatible name drm/mediatek: separate gamma module drm/mediatek: add has_dither privat

Re: [PATCH v11 7/9] drm/mediatek: enable dither function

2021-01-28 Thread Hsin-Yi Wang
On Thu, Jan 28, 2021 at 4:32 PM Yongqiang Niu wrote: > > On Thu, 2021-01-28 at 16:28 +0800, CK Hu wrote: > > On Thu, 2021-01-28 at 16:18 +0800, Hsin-Yi Wang wrote: > > > On Thu, Jan 28, 2021 at 4:10 PM Yongqiang Niu > > > wrote: > > > > > > &g

[PATCH v12 3/8] drm/mediatek: add mtk_dither_set_common() function

2021-01-28 Thread Hsin-Yi Wang
Current implementation of mtk_dither_set() cast dev data to struct mtk_ddp_comp_dev. But other devices with different dev data would also call this function. Separate necessary parameters out so other device components (dither, gamma) can call this function. Signed-off-by: Hsin-Yi Wang Reviewed

[PATCH v12 5/8] drm/mediatek: add has_dither private data for gamma

2021-01-28 Thread Hsin-Yi Wang
From: Yongqiang Niu Not all SoC has dither function in gamma module. Add private data to control this function setting. Signed-off-by: Yongqiang Niu Signed-off-by: Hsin-Yi Wang Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_disp_gamma.c | 14 ++ 1 file changed, 10

[PATCH v4 5/8] drm/mediatek: separate ccorr module

2021-01-29 Thread Hsin-Yi Wang
From: Yongqiang Niu ccorr ctm matrix bits will be different in mt8192 Signed-off-by: Yongqiang Niu Signed-off-by: Hsin-Yi Wang --- drivers/gpu/drm/mediatek/Makefile | 3 +- drivers/gpu/drm/mediatek/mtk_disp_ccorr.c | 222 drivers/gpu/drm/mediatek

[PATCH v4 4/8] drm/mediatek: enable OVL_LAYER_SMI_ID_EN for multi-layer usecase

2021-01-29 Thread Hsin-Yi Wang
From: Yongqiang Niu enable OVL_LAYER_SMI_ID_EN for multi-layer usecase, without this patch, ovl will hang up when more than 1 layer enabled. Signed-off-by: Yongqiang Niu Signed-off-by: Hsin-Yi Wang --- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 17 + 1 file changed, 17

[PATCH v4 8/8] drm/mediatek: add support for mediatek SOC MT8192

2021-01-29 Thread Hsin-Yi Wang
From: Yongqiang Niu add support for mediatek SOC MT8192 Signed-off-by: Yongqiang Niu Signed-off-by: Hsin-Yi Wang --- drivers/gpu/drm/mediatek/mtk_disp_ccorr.c| 6 +++ drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 20 ++ drivers/gpu/drm/mediatek/mtk_disp_postmask.c | 1

[PATCH v4 3/8] drm/mediatek: add component RDMA4

2021-01-29 Thread Hsin-Yi Wang
From: Yongqiang Niu This patch add component RDMA4 Signed-off-by: Yongqiang Niu Reviewed-by: Chun-Kuang Hu Signed-off-by: Hsin-Yi Wang --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers

[PATCH v4 0/8] drm/mediatek: add support for mediatek SOC MT8192

2021-01-29 Thread Hsin-Yi Wang
This series are based on kernel/git/chunkuang.hu/linux.git mediatek-drm-next This series also depends on component support in mmsys[1]: - [v4,06/10] soc: mediatek: mmsys: add component OVL_2L2 - [v4,07/10] soc: mediatek: mmsys: add component POSTMASK - [v4,08/10] soc: mediatek: mmsys: add component

Re: [PATCH v12 6/8] drm/mediatek: enable dither function

2021-01-29 Thread Hsin-Yi Wang
On Fri, Jan 29, 2021 at 2:30 PM Yongqiang Niu wrote: > > On Fri, 2021-01-29 at 14:24 +0800, Hsin-Yi Wang wrote: > > On Fri, Jan 29, 2021 at 9:33 AM CK Hu wrote: > > > > > > Hi, Hsin-Yi: > > > > > > On Thu, 2021-01-28 at 19:23 +0800,

[PATCH v4 6/8] drm/mediatek: add matrix bits private data for ccorr

2021-01-29 Thread Hsin-Yi Wang
From: Yongqiang Niu matrix bits of mt8183 is 12 matrix bits of mt8192 is 13 Signed-off-by: Yongqiang Niu Signed-off-by: Hsin-Yi Wang --- drivers/gpu/drm/mediatek/mtk_disp_ccorr.c | 22 +++--- 1 file changed, 19 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm

[PATCH v4 1/8] drm/mediatek: add component OVL_2L2

2021-01-29 Thread Hsin-Yi Wang
From: Yongqiang Niu This patch add component OVL_2L2 Signed-off-by: Yongqiang Niu Reviewed-by: Chun-Kuang Hu Signed-off-by: Hsin-Yi Wang --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers

Re: [PATCH v12 6/8] drm/mediatek: enable dither function

2021-01-29 Thread Hsin-Yi Wang
On Fri, Jan 29, 2021 at 9:33 AM CK Hu wrote: > > Hi, Hsin-Yi: > > On Thu, 2021-01-28 at 19:23 +0800, Hsin-Yi Wang wrote: > > From: Yongqiang Niu > > > > for 5 or 6 bpc panel, we need enable dither function > > to improve the display quality > > > >

Re: [PATCH v12 6/8] drm/mediatek: enable dither function

2021-01-29 Thread Hsin-Yi Wang
On Fri, Jan 29, 2021 at 3:42 PM Yongqiang Niu wrote: > > On Fri, 2021-01-29 at 14:46 +0800, Hsin-Yi Wang wrote: > > On Fri, Jan 29, 2021 at 2:30 PM Yongqiang Niu > > wrote: > > > > > > On Fri, 2021-01-29 at 14:24 +0800, Hsin-Yi Wang wrote: > > > &

[PATCH v4 2/8] drm/mediatek: add component POSTMASK

2021-01-29 Thread Hsin-Yi Wang
From: Yongqiang Niu This patch add component POSTMASK, Signed-off-by: Yongqiang Niu Signed-off-by: Hsin-Yi Wang --- drivers/gpu/drm/mediatek/Makefile| 1 + drivers/gpu/drm/mediatek/mtk_disp_drv.h | 8 + drivers/gpu/drm/mediatek/mtk_disp_postmask.c | 161

[PATCH v4 7/8] soc: mediatek: add mtk mutex support for MT8192

2021-01-29 Thread Hsin-Yi Wang
From: Yongqiang Niu Add mtk mutex support for MT8192 SoC. Signed-off-by: Yongqiang Niu Signed-off-by: Hsin-Yi Wang --- drivers/soc/mediatek/mtk-mutex.c | 35 1 file changed, 35 insertions(+) diff --git a/drivers/soc/mediatek/mtk-mutex.c b/drivers/soc

[PATCH v13 0/8] drm/mediatek: add support for mediatek SOC MT8183

2021-01-30 Thread Hsin-Yi Wang
: - fix reviewed issue in v1 - add dts for mt8183 display nodes - adjust display clock control flow in patch 22 - add vmap support for mediatek drm in patch 23 - fix page offset issue for mmap function in patch 24 - enable allow_fb_modifiers for mediatek drm in patch 25 Hsin-Yi Wang (1): drm/mediatek

[PATCH v13 2/8] arm64: dts: mt8183: refine gamma compatible name

2021-01-30 Thread Hsin-Yi Wang
From: Yongqiang Niu mt8183 gamma is different with mt8173 remove mt8173 compatible name for mt8183 gamma Fixes: 91f9c963ce79 ("arm64: dts: mt8183: Add display nodes for MT8183") Signed-off-by: Yongqiang Niu Signed-off-by: Hsin-Yi Wang Reviewed-by: Enric Balletbo i Serra --- arch/

[PATCH v13 1/8] arm64: dts: mt8183: rename rdma fifo size

2021-01-30 Thread Hsin-Yi Wang
From: Yongqiang Niu property name must include only lowercase and '-' Fixes: 91f9c963ce79 ("arm64: dts: mt8183: Add display nodes for MT8183") Signed-off-by: Yongqiang Niu Signed-off-by: Hsin-Yi Wang Reviewed-by: Chun-Kuang Hu Reviewed-by: Enric Balletbo i Serra ---

[PATCH v13 8/8] drm/mediatek: add support for mediatek SOC MT8183

2021-01-30 Thread Hsin-Yi Wang
From: Yongqiang Niu 1. add ovl private data 2. add rdma private data 3. add gamma privte data 4. add main and external path module for crtc create Signed-off-by: Yongqiang Niu Signed-off-by: Hsin-Yi Wang Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_disp_gamma.c | 1 + drivers/gpu

[PATCH v13 5/8] drm/mediatek: add has_dither private data for gamma

2021-01-30 Thread Hsin-Yi Wang
From: Yongqiang Niu Not all SoC has dither function in gamma module. Add private data to control this function setting. Signed-off-by: Yongqiang Niu Signed-off-by: Hsin-Yi Wang Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_disp_gamma.c | 14 ++ 1 file changed, 10

[PATCH v13 3/8] drm/mediatek: add mtk_dither_set_common() function

2021-01-30 Thread Hsin-Yi Wang
Current implementation of mtk_dither_set() cast dev data to struct mtk_ddp_comp_dev. But other devices with different dev data would also call this function. Separate necessary parameters out so other device components (dither, gamma) can call this function. Signed-off-by: Hsin-Yi Wang Reviewed

Re: [PATCH v4 2/8] drm/mediatek: add component POSTMASK

2021-01-30 Thread Hsin-Yi Wang
t; > > > On Fri, 2021-01-29 at 15:34 +0800, Hsin-Yi Wang wrote: > > > > > From: Yongqiang Niu > > > > > > > > > > This patch add component POSTMASK, > > > > > > > > > > Signed-off-by: Yongqiang Niu > > &

[PATCH v13 4/8] drm/mediatek: separate gamma module

2021-01-30 Thread Hsin-Yi Wang
From: Yongqiang Niu mt8183 gamma module will different with mt8173 separate gamma for add private data Signed-off-by: Yongqiang Niu Signed-off-by: Hsin-Yi Wang Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/Makefile | 1 + drivers/gpu/drm/mediatek/mtk_disp_drv.h | 10

[PATCH v13 7/8] soc: mediatek: add mtk mutex support for MT8183

2021-01-30 Thread Hsin-Yi Wang
From: Yongqiang Niu Add mtk mutex support for MT8183 SoC. Signed-off-by: Yongqiang Niu Signed-off-by: Hsin-Yi Wang Reviewed-by: CK Hu --- drivers/soc/mediatek/mtk-mutex.c | 50 1 file changed, 50 insertions(+) diff --git a/drivers/soc/mediatek/mtk-mutex.c b

[PATCH v13 6/8] drm/mediatek: enable dither function

2021-01-30 Thread Hsin-Yi Wang
From: Yongqiang Niu Enable dither function to improve the display quality for dither supported bpc 4, 6, 8. For not supported bpc, use relay mode. Signed-off-by: Yongqiang Niu Signed-off-by: Hsin-Yi Wang --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 15 --- 1 file changed, 12

[PATCH] drm/mediatek: enable dither function

2021-01-31 Thread Hsin-Yi Wang
From: Yongqiang Niu Enable dither function to improve the display quality. Signed-off-by: Yongqiang Niu Signed-off-by: Hsin-Yi Wang --- Previous version: https://patchwork.kernel.org/project/linux-mediatek/patch/20210129092209.2584718-7-hsi...@chromium.org/ --- drivers/gpu/drm/mediatek

Re: [PATCH v13 6/8] drm/mediatek: enable dither function

2021-01-31 Thread Hsin-Yi Wang
On Sun, Jan 31, 2021 at 11:40 AM Chun-Kuang Hu wrote: > > Hi, Hsin-Yi: > > Hsin-Yi Wang 於 2021年1月29日 週五 下午5:23寫道: > > > > From: Yongqiang Niu > > > > Enable dither function to improve the display quality for dither > > supported bpc 4, 6, 8. For not sup

[PATCH v5 3/8] drm/mediatek: add component RDMA4

2021-02-02 Thread Hsin-Yi Wang
From: Yongqiang Niu This patch add component RDMA4 Signed-off-by: Yongqiang Niu Reviewed-by: Chun-Kuang Hu Signed-off-by: Hsin-Yi Wang --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers

[PATCH v5 0/8] drm/mediatek: add support for mediatek SOC MT8192

2021-02-02 Thread Hsin-Yi Wang
This series are based on kernel/git/chunkuang.hu/linux.git mediatek-drm-next and following patch: ("soc: mediatek: add mtk mutex support for MT8183") https://patchwork.kernel.org/project/linux-mediatek/patch/20210129092209.2584718-8-hsi...@chromium.org/ This series also depends on component suppor

[PATCH v5 4/8] drm/mediatek: separate ccorr module

2021-02-02 Thread Hsin-Yi Wang
From: Yongqiang Niu ccorr ctm matrix bits will be different in mt8192 Signed-off-by: Yongqiang Niu Signed-off-by: Hsin-Yi Wang --- drivers/gpu/drm/mediatek/Makefile | 3 +- drivers/gpu/drm/mediatek/mtk_disp_ccorr.c | 216 drivers/gpu/drm/mediatek

[PATCH v5 1/8] drm/mediatek: add component OVL_2L2

2021-02-02 Thread Hsin-Yi Wang
From: Yongqiang Niu This patch add component OVL_2L2 Signed-off-by: Yongqiang Niu Reviewed-by: Chun-Kuang Hu Signed-off-by: Hsin-Yi Wang --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers

[PATCH v5 5/8] drm/mediatek: Fix ccorr size config

2021-02-02 Thread Hsin-Yi Wang
From: Yongqiang Niu Fix setting to follow hardware datasheet. The original error setting affects mt8192 display. Signed-off-by: Yongqiang Niu Signed-off-by: Hsin-Yi Wang --- drivers/gpu/drm/mediatek/mtk_disp_ccorr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH v6 6/8] drm/mediatek: add matrix_bits private data for ccorr

2021-02-02 Thread Hsin-Yi Wang
From: Yongqiang Niu Add matrix_bits and coeffs_precision to ccorr private data: - matrix bits of mt8183 is 10 - matrix bits of mt8192 is 11 Signed-off-by: Yongqiang Niu Signed-off-by: Hsin-Yi Wang --- drivers/gpu/drm/mediatek/mtk_disp_ccorr.c | 27 ++- 1 file changed, 17

[PATCH v5 6/8] drm/mediatek: add matrix_bits private data for ccorr

2021-02-02 Thread Hsin-Yi Wang
From: Yongqiang Niu Add matrix_bits and coeffs_precision to ccorr private data: - matrix bits of mt8183 is 10 - matrix bits of mt8192 is 11 Signed-off-by: Yongqiang Niu Signed-off-by: Hsin-Yi Wang --- drivers/gpu/drm/mediatek/mtk_disp_ccorr.c | 34 --- 1 file changed, 24

  1   2   3   4   5   6   >