Reviewed-by: Bjorn Andersson
Acked-by: Mike Rapoport
Acked-by: Corey Minyard
Acked-by: Christian Brauner
Acked-by: Arnd Bergmann
Acked-by: Kees Cook
Acked-by: Wei Liu
Acked-by: Rasmus Villemoes
Signed-off-by: Andrew Morton
Acked-by: Helge Deller # parisc
Helge
On 3/11/22 03:56, Haowen Bai wrote:
> Fix the following coccicheck warning:
> drivers/video/fbdev/offb.c:415:13-14: WARNING comparing pointer to 0
>
> Signed-off-by: Haowen Bai
applied.
Thanks!
Helge
> ---
> drivers/video/fbdev/offb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
On 3/8/22 21:23, Colin Ian King wrote:
> Don't populate the read-only array ODValues on the stack but
> instead make it static const. Also makes the object code a little
> smaller.
>
> Signed-off-by: Colin Ian King
>
> ---
> drivers/video/fbdev/kyro/STG4000InitDevice.c | 2 +-
> 1 file changed, 1
roups in kobj_type
Guo Zhengkui (1):
video: fbdev: omapfb: Use sysfs_emit() instead of snprintf()
Haowen Bai (1):
video: fbdev: offb: fix warning comparing pointer to 0
Helge Deller (1):
video: fbdev: sm712fb: Fix crash in smtcfb_read()
Jiasheng Jiang (1):
video: fbdev: im
On 3/22/22 21:33, Christophe JAILLET wrote:
> of_parse_display_timing() already call memset(0) on its 2nd argument, so
> there is no need to clear it explicitly before calling this function.
>
> Use kmalloc() instead of kzalloc() to save a few cycles.
>
> Signed-off-by: Christophe JAILLET
applied
On 3/22/22 21:04, Pavel Skripkin wrote:
> syzbot reported warning in usb_submit_urb, which is caused by wrong
> endpoint type.
>
> This driver uses out bulk endpoint for communication, so
> let's check if this endpoint is present and bail out early if not.
>
> Fail log:
>
> usb 1-1: BOGUS urb xfer,
On 2/21/22 11:37, xkernel.w...@foxmail.com wrote:
> From: Xiaoke Wang
>
> kstrdup() is a memory allocation function which can return NULL when
> some internal memory errors happen. It is better to check the return
> value of it to catch the error in time during the setup of viafb.
>
> Signed-off-b
* Zheyu Ma :
> I found a minor in the smtcfb_read() function of the driver sm712fb.
>
> This read function can not handle the case that the size of the
> buffer is 3 and does not check for it, which may cause a page fault.
>
> The following log reveals it:
>
> [ 2432.614490] BUG: unable to handle p
On 3/2/22 15:33, Zheyu Ma wrote:
> When the sm712fb driver writes three bytes to the framebuffer, the
> driver will crash:
>
> BUG: unable to handle page fault for address: c90001ff
> RIP: 0010:smtcfb_write+0x454/0x5b0
> Call Trace:
> vfs_write+0x291/0xd60
> ? do_sys_o
On 3/2/22 04:44, Yihao Han wrote:
> Remove dev_err() messages after platform_get_irq*() failures.
> platform_get_irq() already prints an error.
>
> Generated by: scripts/coccinelle/api/platform_get_irq.cocci
>
> Signed-off-by: Yihao Han
applied to the fbdev for-next git tree.
Thanks!
Helge
> --
On 3/3/22 02:34, Zheyu Ma wrote:
> Hi,
>
> On Thu, Mar 3, 2022 at 12:49 AM Helge Deller wrote:
>>
>> On 3/2/22 15:33, Zheyu Ma wrote:
>>> When the sm712fb driver writes three bytes to the framebuffer, the
>>> driver will crash:
>>>
>
On 3/7/22 13:38, Miaoqian Lin wrote:
> The device_node pointer is returned by of_parse_phandle() with refcount
> incremented. We should use of_node_put() on it when done.
>
> Fixes: f76ee892a99e ("omapfb: copy omapdss & displays for omapfb")
> Signed-off-by: Miaoqian Lin
applied to the fbdev for
ric.c:1265:28: error: suggest braces around empty body in
an 'if' statement [-Werror=empty-body]
1265 | unmap_page_from_agp(page);
Change the definitions to a 'do { } while (0)' construct to
make these more reliable.
Signed-off-by: Arnd Bergmann
Acked-by: Helge Deller # p
The fbdev layer is orphaned, but seems to need some care.
So I'd like to step up as new maintainer.
Signed-off-by: Helge Deller
diff --git a/MAINTAINERS b/MAINTAINERS
index 5d0cd537803a..ce47dbc467cc 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -7583,11 +7583,12 @@ W:
code.
Helge Deller (1):
MAINTAINERS: Add Helge as fbdev maintainer
MAINTAINERS | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
On 1/17/22 05:33, Linus Torvalds wrote:
> On Sun, Jan 16, 2022 at 9:32 PM Helge Deller wrote:
>>
>> This pull request contains only one single initial patch which adds
>> myself to the MAINTAINERS file for the FRAMBUFFER LAYER.
>
> I'll pull this
Thanks!
>
Hello Jani,
On 1/17/22 11:49, Jani Nikula wrote:
> On Mon, 17 Jan 2022, Daniel Vetter wrote:
>> Hi Helge
>>
>> On Fri, Jan 14, 2022 at 7:18 PM Helge Deller wrote:
>>>
>>> The fbdev layer is orphaned, but seems to need some care.
>>> So I'd
Hi Thomas,
On 1/17/22 12:16, Thomas Zimmermann wrote:
> Hi
>
> Am 14.01.22 um 19:11 schrieb Helge Deller:
>> The fbdev layer is orphaned, but seems to need some care.
>> So I'd like to step up as new maintainer.
>>
>> Signed-off-by: Helge Deller
>
>
Hello Daniel,
On 1/17/22 11:02, Daniel Vetter wrote:
> Hi Helge
>
> On Fri, Jan 14, 2022 at 7:18 PM Helge Deller wrote:
>>
>> The fbdev layer is orphaned, but seems to need some care.
>> So I'd like to step up as new maintainer.
>>
>> Signed-off-by: He
On 1/17/22 15:10, Geert Uytterhoeven wrote:
> Hi Thomas,
>
> On Mon, Jan 17, 2022 at 2:51 PM Thomas Zimmermann wrote:
>> Am 17.01.22 um 14:29 schrieb Geert Uytterhoeven:
>>> On Mon, Jan 17, 2022 at 1:57 PM Gerd Hoffmann wrote:
> b) to include new drivers (for old hardware) if they arrive (pro
On 1/17/22 16:00, Daniel Vetter wrote:
> On Mon, Jan 17, 2022 at 1:16 PM Helge Deller wrote:
>>
>> Hello Daniel,
>>
>> On 1/17/22 11:02, Daniel Vetter wrote:
>>> Hi Helge
>>>
>>> On Fri, Jan 14, 2022 at 7:18 PM Helge Deller wrote:
>>
Hi Thomas,
On 1/17/22 16:05, Thomas Zimmermann wrote:
> Hi
>
> Am 17.01.22 um 15:47 schrieb Helge Deller:
>> On 1/17/22 15:10, Geert Uytterhoeven wrote:
>> [...]
>>> Using an XRGB32 intermediate would kill the user experience on old
>>> machines, due
On 1/17/22 16:58, Thomas Zimmermann wrote:
> Hi
>
> Am 17.01.22 um 16:42 schrieb Helge Deller:
>> [...]
>>>> c) reintroduce the state where fbcon is fast on fbdev. This is important
>>>> for non-DRM machines,
>>>> either when run on nativ
On 1/17/22 17:38, Daniel Vetter wrote:
> On Mon, Jan 17, 2022 at 5:22 PM Helge Deller wrote:
>>
>> On 1/17/22 16:58, Thomas Zimmermann wrote:
>>> Hi
>>>
>>> Am 17.01.22 um 16:42 schrieb Helge Deller:
>>>> [...]
>>>>>>
On 1/17/22 17:21, Helge Deller wrote:
> On 1/17/22 16:58, Thomas Zimmermann wrote:
>> Hi
>>
>> Am 17.01.22 um 16:42 schrieb Helge Deller:
>>> [...]
>>>>> c) reintroduce the state where fbcon is fast on fbdev. This is important
>>>>&g
On 1/17/22 16:03, Daniel Vetter wrote:
> On Mon, Jan 17, 2022 at 3:48 PM Helge Deller wrote:
>>
>> On 1/17/22 15:10, Geert Uytterhoeven wrote:
>>> Hi Thomas,
>>>
>>> On Mon, Jan 17, 2022 at 2:51 PM Thomas Zimmermann
>>> wrote:
>>>>
On 1/17/22 22:40, Jani Nikula wrote:
> On Mon, 17 Jan 2022, Thomas Zimmermann wrote:
>> Seems like few people read linux-fbdev these days.
>
> How much traffic is there to linux-fbdev that is *not* Cc'd to dri-devel
> also?
Doesn't seem like much traffic - which IMHO is OK for such a tree with
mo
On 1/18/22 07:11, Gerd Hoffmann wrote:
> On Mon, Jan 17, 2022 at 02:29:47PM +0100, Geert Uytterhoeven wrote:
>> Hi Gerd,
>>
>> On Mon, Jan 17, 2022 at 1:57 PM Gerd Hoffmann wrote:
b) to include new drivers (for old hardware) if they arrive (probably
happens rarely but there can be).
>>>
On 1/18/22 07:29, Gerd Hoffmann wrote:
>> Please correct me if I'm wrong, but text-console emulation/scrolling on DRM
>> is
>> currently unaccelerated and bound to Truecolour modes only,
>
> Yes. Adding support for formats beside argb to the drm fbcon
> emulation shouldn't be that much of a p
Hello Daniel,
On 1/17/22 16:00, Daniel Vetter wrote:
> On Mon, Jan 17, 2022 at 1:16 PM Helge Deller wrote:
>> On 1/17/22 11:02, Daniel Vetter wrote:
>>> On Fri, Jan 14, 2022 at 7:18 PM Helge Deller wrote:
>>>>
>>>> The fbdev layer is orphaned, but se
On 1/18/22 09:38, Jani Nikula wrote:
> On Mon, 17 Jan 2022, Helge Deller wrote:
>> On 1/17/22 22:40, Jani Nikula wrote:
>>> On Mon, 17 Jan 2022, Thomas Zimmermann wrote:
>>>> Seems like few people read linux-fbdev these days.
>>>
>>> How much traff
On 1/18/22 09:41, Helge Deller wrote:
> Hello Daniel,
>
> On 1/17/22 16:00, Daniel Vetter wrote:
>> On Mon, Jan 17, 2022 at 1:16 PM Helge Deller wrote:
>>> On 1/17/22 11:02, Daniel Vetter wrote:
>>>> On Fri, Jan 14, 2022 at 7:18 PM Helge Deller wrote:
>>
On 1/18/22 10:16, Gerd Hoffmann wrote:
> On Tue, Jan 18, 2022 at 09:20:43AM +0100, Helge Deller wrote:
>> On 1/18/22 07:29, Gerd Hoffmann wrote:
>>>> Please correct me if I'm wrong, but text-console emulation/scrolling on
>>>> DRM is
>>>> currentl
On 1/18/22 11:13, Helge Deller wrote:
> On 1/18/22 10:16, Gerd Hoffmann wrote:
>> On Tue, Jan 18, 2022 at 09:20:43AM +0100, Helge Deller wrote:
>>> On 1/18/22 07:29, Gerd Hoffmann wrote:
>>>>> Please correct me if I'm wrong, but text-console emulation/scro
On 1/18/22 12:18, Daniel Vetter wrote:
> On Tue, Jan 18, 2022 at 9:56 AM Helge Deller wrote:
>>
>> On 1/18/22 09:38, Jani Nikula wrote:
>>> On Mon, 17 Jan 2022, Helge Deller wrote:
>>>> On 1/17/22 22:40, Jani Nikula wrote:
>>>>> On Mon,
egression for fbdev drivers.
There isn't any impact on DRM when reverting those patches.
Helge Deller (2):
Revert "fbdev: Garbage collect fbdev scrolling acceleration, part 1
(from TODO list)"
Revert "fbcon: Disable accelerated scrolling"
Documentation/gpu/t
and more.
Reverting this commit has no impact on DRM, since none of the DRM drivers are
tagged with the acceleration flags FBINFO_HWACCEL_COPYAREA,
FBINFO_HWACCEL_FILLRECT or others.
Signed-off-by: Helge Deller
Cc: sta...@vger.kernel.org # v5.16
---
Documentation/gpu/todo.rst | 21
factor of 10 and more.
Reverting this commit has no impact on DRM, since none of the DRM drivers are
tagged with the acceleration flags FBINFO_HWACCEL_COPYAREA,
FBINFO_HWACCEL_FILLRECT or others.
Signed-off-by: Helge Deller
Cc: sta...@vger.kernel.org # v5.16
---
Documentation/gpu/todo.rst
Hello Greg,
On 1/19/22 12:47, Geert Uytterhoeven wrote:
> On Wed, Jan 19, 2022 at 12:28 PM Greg Kroah-Hartman
> wrote:
>> On Wed, Jan 19, 2022 at 12:22:55PM +0100, Greg Kroah-Hartman wrote:
>>> On Wed, Jan 19, 2022 at 12:08:39PM +0100, Helge Deller wrote:
>
This is just a heads-up, that I'm planning to send a pull request for
fbdev fixes to Linus later today.
Nothing really important - just fixes for various fbdev drivers.
It has been a few days in for-next and no DRM parts are touched.
Changelog is below, and it can be pulled from:
http://git.kern
On 1/19/22 15:01, Linus Torvalds wrote:
> On Wed, Jan 19, 2022 at 2:29 PM Helge Deller wrote:
>>
>>>>
>>>> Ah, no, that was just the soft scrollback code I was thinking of, which
>>
>> Right.
>> That was commit 973c096f6a85 and it was abou
On 1/19/22 15:34, Daniel Vetter wrote:
> On Wed, Jan 19, 2022 at 3:01 PM Linus Torvalds
> wrote:
>>
>> On Wed, Jan 19, 2022 at 2:29 PM Helge Deller wrote:
>>>
>>>>>
>>>>> Ah, no, that was just the soft scrollback code I was thinking of,
On 1/19/22 16:42, Daniel Vetter wrote:
> On Wed, Jan 19, 2022 at 4:06 PM Sven Schnelle wrote:
>>
>> Daniel Vetter writes:
>>
>>> On Wed, Jan 19, 2022 at 3:01 PM Linus Torvalds
>>> wrote:
>>> Irrespective of this code being buggy or not buggy I think the bigger
>>> pictures, and really the reason
pdates and fixes for the following fbdev & backlight drivers:
ocfb, aty128fb, mb862xx, omapfb, qcom-wled, dt-bindings, hyperv_fb,
lm3630a_bl, omap2, controlfb, matroxfb
Nothing really important, mostly cleanups, const conversions, added null
pointer/boundary checks and build fixes.
Signed-off-by
Hi Thomas,
On 1/19/22 16:37, Thomas Zimmermann wrote:
> Am 19.01.22 um 16:05 schrieb Sven Schnelle:
>> Daniel Vetter writes:
>>
>>> On Wed, Jan 19, 2022 at 3:01 PM Linus Torvalds
>>> wrote:
>>> Irrespective of this code being buggy or not buggy I think the bigger
>>> pictures, and really the rea
Hello Daniel,
On 1/20/22 15:30, Daniel Vetter wrote:
> On Wed, Jan 19, 2022 at 12:08:39PM +0100, Helge Deller wrote:
>> This reverts commit 39aead8373b3c20bb5965c024dfb51a94e526151.
>>
>> Revert this patch. This patch started to introduce the regression that
>> all ha
On 1/21/22 10:19, Lee Jones wrote:
> On Fri, 21 Jan 2022, Jani Nikula wrote:
>
>> On Fri, 21 Jan 2022, Daniel Vetter wrote:
>>> On Wed, Jan 19, 2022 at 5:02 PM Helge Deller wrote:
>>>> A first bunch of updates and fixes for the following fbdev & backlig
gt;
>>>>> Instead, validate the specified screen resolution by calculating
>>>>> its size, and comparing against the frame buffer size. Delete the
>>>>> code for calculating the max width and height from the list of
>>>>> resolution
On 1/21/22 08:20, Gerd Hoffmann wrote:
>>> So if this really has to come back then I think the pragmatic approach is
>>> to do it behind a CONFIG_FBCON_ACCEL, default n, and with a huge warning
>>> that enabling that shouldn't be done for any distro which only enables
>>> firmware and drm fbdev dri
On 1/24/22 14:31, Wei Liu wrote:
> On Mon, Jan 24, 2022 at 10:52:22AM +0100, Helge Deller wrote:
>> On 1/23/22 23:30, Wei Liu wrote:
>>> On Sun, Jan 23, 2022 at 10:27:56PM +, Michael Kelley (LINUX) wrote:
>>>> From: Wei Liu Sent: Sunday, January 23, 2022 1:56
On 1/24/22 12:50, Javier Martinez Canillas wrote:
> On 1/24/22 12:33, Thomas Zimmermann wrote:
>
> [snip]
>
>>> Thoughts?
>>
>> I can't say I approve keeping fbdev alive, but...
>>
>> With fbdev emulation, every DRM driver is an fbdev driver too. So
>> CONFIG_FB_DRIVER is somewhat misleading. Bette
those should be reverted into
the commit message. That simplifies to analyze later why they were
reverted.
- resorted the To an Cc mail recipient lists
Helge Deller (2):
Revert "fbdev: Garbage collect fbdev scrolling acceleration, part 1
(from TODO list)"
Revert "fbcon:
be reverted. By reverting we
reintroduce hardware-based scrolling acceleration and fix the
performance regression for fbdev drivers.
There isn't any impact on DRM when reverting those patches.
Signed-off-by: Helge Deller
Cc: sta...@vger.kernel.org # v5.10+
---
Documentation/gpu/todo.rst |
be reverted. By reverting we
reintroduce hardware-based scrolling acceleration and fix the
performance regression for fbdev drivers.
There isn't any impact on DRM when reverting those patches.
Signed-off-by: Helge Deller
Cc: sta...@vger.kernel.org # v5.16+
---
Documentation/gpu/todo.rst
On 1/24/22 23:19, Daniel Vetter wrote:
> On Mon, Jan 24, 2022 at 10:03:17PM +0100, Helge Deller wrote:
>> This series reverts two patches which disabled scrolling acceleration in
>> fbcon/fbdev. Those patches introduced a regression for fbdev-supported
>> graphic
&g
-> 19.0 seconds
b) time dmesg (with acceleration):
-> 2.6 seconds
Signed-off-by: Helge Deller
diff --git a/drivers/video/console/Kconfig b/drivers/video/console/Kconfig
index 840d9813b0bc..da84d1c21c21 100644
--- a/drivers/video/console/Kconfig
+++ b/drivers/video/console/Kc
On 1/25/22 20:12, Helge Deller wrote:
> Add a config option CONFIG_FRAMEBUFFER_CONSOLE_LEGACY_ACCELERATION to
> enable bitblt and fillrect hardware acceleration in the framebuffer
> console. If disabled, such acceleration will not be used, even if it is
> supported by the graphics har
On 1/25/22 20:17, Helge Deller wrote:
> On 1/25/22 20:12, Helge Deller wrote:
>> Add a config option CONFIG_FRAMEBUFFER_CONSOLE_LEGACY_ACCELERATION to
>> enable bitblt and fillrect hardware acceleration in the framebuffer
>> console. If disabled, such acceleration will not b
On 1/26/22 11:02, Andy Shevchenko wrote:
> On Wed, Jan 26, 2022 at 10:52 AM Thomas Zimmermann
> wrote:
>> Am 25.01.22 um 21:21 schrieb Andy Shevchenko:
>>> Since we got a maintainer for fbdev, I would like to
>>> unorphan fbtft (with the idea of sending PRs to Helge)
>>> and move it out of stagin
On 1/26/22 11:31, Daniel Vetter wrote:
> On Wed, Jan 26, 2022 at 9:31 AM Greg Kroah-Hartman
> wrote:
>>
>> On Tue, Jan 25, 2022 at 10:21:14PM +0200, Andy Shevchenko wrote:
>>> Let's maintain occasional fixes to the fbtft driver.
>>>
>>> Signed-off-by: Andy Shevchenko
>>> ---
>>> MAINTAINERS | 4
On 1/26/22 12:18, Javier Martinez Canillas wrote:
> On 1/26/22 11:59, Helge Deller wrote:
>> On 1/26/22 11:02, Andy Shevchenko wrote:
>
> [snip]
>
>>> P.S. For the record, I will personally NAK any attempts to remove that
>>> driver from the kernel. And this
On 1/26/22 12:24, Daniel Vetter wrote:
> On Wed, Jan 26, 2022 at 12:18 PM Javier Martinez Canillas
> wrote:
>>
>> On 1/26/22 11:59, Helge Deller wrote:
>>> On 1/26/22 11:02, Andy Shevchenko wrote:
>>
>> [snip]
>>
>>>> P.S. For the
On 1/26/22 12:38, Greg Kroah-Hartman wrote:
> On Wed, Jan 26, 2022 at 12:31:21PM +0100, Helge Deller wrote:
>> On 1/26/22 12:18, Javier Martinez Canillas wrote:
>>> On 1/26/22 11:59, Helge Deller wrote:
>>>> On 1/26/22 11:02, Andy Shevchenko wrote:
>>>
>
On 1/26/22 16:02, Thomas Zimmermann wrote:
> Hi
>
> Am 26.01.22 um 14:32 schrieb Andy Shevchenko:
>> On Wed, Jan 26, 2022 at 12:41:41PM +0100, Thomas Zimmermann wrote:
>>> Am 26.01.22 um 11:59 schrieb Helge Deller:
>>
>> ...
>>
>>
>>> It&
Hello DRI and fbdev developers,
I've now mostly checked all queued-up patches on the fbdev mailing list:
https://patchwork.kernel.org/project/linux-fbdev/list/
and applied the ones which seemed appropriate.
IMHO there is nothing really critical/important/conflicting in there.
Shortlog is below, t
On 1/31/22 22:05, Daniel Vetter wrote:
> This functionally undoes 39aead8373b3 ("fbcon: Disable accelerated
> scrolling"), but behind the FRAMEBUFFER_CONSOLE_LEGACY_ACCELERATION
> option.
you have two trivial copy-n-paste errors in this patch which still prevent the
console acceleration.
> diff -
On 2/1/22 11:16, Helge Deller wrote:
> On 1/31/22 22:05, Daniel Vetter wrote:
>> This functionally undoes 39aead8373b3 ("fbcon: Disable accelerated
>> scrolling"), but behind the FRAMEBUFFER_CONSOLE_LEGACY_ACCELERATION
>> option.
>
> you have two trivial co
s group maintained, I expect that to continue like
> we've done before, so no new expectations that patches all go through
> my hands. That would be silly. This also means I'm happy to put any
> other volunteer's name in the M: line, but otherwise git log says I'm
&
On 2/1/22 11:36, Daniel Vetter wrote:
> On Tue, Feb 1, 2022 at 11:16 AM Helge Deller wrote:
>>
>> On 1/31/22 22:05, Daniel Vetter wrote:
>>> This functionally undoes 39aead8373b3 ("fbcon: Disable accelerated
>>> scrolling"), but behind the FRAMEBU
On 2/1/22 07:26, Yang Li wrote:
> The print function dev_err() is redundant because platform_get_irq()
> already prints an error.
>
> Eliminate the follow coccicheck warning:
> ./drivers/video/fbdev/pxa168fb.c:621:2-9: line 621 is redundant because
> platform_get_irq() already prints an error
>
> R
On 2/1/22 14:45, Daniel Vetter wrote:
> On Tue, Feb 1, 2022 at 12:01 PM Helge Deller wrote:
>> On 2/1/22 11:36, Daniel Vetter wrote:
>>> On Tue, Feb 1, 2022 at 11:16 AM Helge Deller wrote:
>>>>
>>>> On 1/31/22 22:05, Daniel Vetter wrote:
>>&
On 1/31/22 07:57, Yizhuo Zhai wrote:
> In function do_fb_ioctl(), the "arg" is the type of unsigned long,
yes, because it comes from the ioctl framework...
> and in "case FBIOBLANK:" this argument is casted into an int before
> passig to fb_blank().
which makes sense IMHO.
> In fb_blank(), the
driver.
This series is being discussed on linux-fbdev and dri-devel mailing lists.
Helge
Helge Deller (3):
Revert "fbdev: Garbage collect fbdev scrolling acceleration, part 1
(from TODO list)"
Revert "fbcon: Disable accelerated scrolling"
fbcon: Add option to en
be reverted. By reverting we
reintroduce hardware-based scrolling acceleration and fix the
performance regression for fbdev drivers.
There isn't any impact on DRM when reverting those patches.
Signed-off-by: Helge Deller
Acked-by: Geert Uytterhoeven
Acked-by: Sven Schnelle
Cc: sta...@vger.ke
ay.
In this v3 patch version I additionally changed the GETVYRES() and GETVXRES()
macros to take a pointer to the fbcon_display struct. This fixes the build when
console rotation is enabled and helps the compiler again to optimize out code.
Signed-off-by: Helge Deller
Cc: sta...@vger.kernel.org
be reverted. By reverting we
reintroduce hardware-based scrolling acceleration and fix the
performance regression for fbdev drivers.
There isn't any impact on DRM when reverting those patches.
Signed-off-by: Helge Deller
Acked-by: Geert Uytterhoeven
Acked-by: Sven Schnelle
Cc: sta...@vger.ke
On 2/1/22 13:32, Yang Li wrote:
> The print function dev_err() is redundant because platform_get_irq()
> already prints an error.
>
> Eliminate the follow coccicheck warning:
> ./drivers/video/fbdev/pxa168fb.c:621:2-9: line 621 is redundant because
> platform_get_irq() already prints an error
>
> R
Hello Daniel,
On 2/1/22 21:11, Daniel Vetter wrote:
> On Tue, Feb 1, 2022 at 7:59 PM Helge Deller wrote:
>>
>> Add a config option CONFIG_FRAMEBUFFER_CONSOLE_LEGACY_ACCELERATION to
>> enable bitblt and fillrect hardware acceleration in the framebuffer
>> console. If
On 11/15/21 17:12, Geert Uytterhoeven wrote:
> On Mon, Nov 15, 2021 at 4:54 PM Geert Uytterhoeven
> wrote:
>> Below is the list of build error/warning regressions/improvements in
>> v5.16-rc1[1] compared to v5.15[2].
>>
>> Summarized:
>> - build errors: +20/-13
>> - build warnings: +3/-28
>>
On 11/17/21 03:19, Nick Terrell wrote:
>
>
>> On Nov 16, 2021, at 6:05 PM, Randy Dunlap wrote:
>>
>> On 11/16/21 5:59 PM, Nick Terrell wrote:
>>>> On Nov 15, 2021, at 8:44 AM, Helge Deller wrote:
>>>>
>>>> On 11/15/21 17:12, Geert Uyt
On 11/27/21 11:56, Rolf Eike Beer wrote:
> Am Samstag, 27. November 2021, 05:57:57 CET schrieb Randy Dunlap:
>> Fix section mismatch warning in parisc-agp:
Thanks Randy!
> Too late ;)
>
> https://lore.kernel.org/linux-parisc/20211126154754.263487-1-del...@gmx.de/
Being late doesn't matter!
I'm r
On 11/12/21 15:16, Thomas Zimmermann wrote:
> Fix the compiler warning
>
> drivers/char/agp/ati-agp.c: In function 'ati_create_page_map':
> drivers/char/agp/ati-agp.c:58:16: warning: variable 'err' set but not used
> [-Wunused-but-set-variable]
> 58 | int i, err = 0;
>
> by returin
On 11/12/21 15:16, Thomas Zimmermann wrote:
> Fix the compiler warning
>
> drivers/char/agp/nvidia-agp.c: In function 'nvidia_tlbflush':
> drivers/char/agp/nvidia-agp.c:264:22: warning: variable 'temp' set but not
> used [-Wunused-but-set-variable]
> 264 | u32 wbc_reg, temp;
>
> by
On 11/30/21 11:03, Thomas Zimmermann wrote:
> Ping! Any feedback on these patches?
I just reviewed those patches, and sent some feedback.
The others are:
Acked-by: Helge Deller
Helge
> Am 12.11.21 um 15:16 schrieb Thomas Zimmermann:
>> Fix a number of compiler warnings in the AGP
I may have missed some discussions, but I'm objecting against this patch:
b3ec8cdf457e5 ("fbdev: Garbage collect fbdev scrolling acceleration,
part 1 (from TODO list)")
Can we please (partly) revert it and restore the scrolling behaviour,
where fbcon uses fb_copyarea() to copy the screen
On 1/13/22 09:51, Thomas Zimmermann wrote:
> ping!
>
> This patchset got lost. Patches 4 and 5 still need a review.
for patches 4 & 5:
Acked-by: Helge Deller
Helge
>
> Am 01.12.21 um 12:46 schrieb Thomas Zimmermann:
>> Fix a number of compiler warnings in the A
first_fb_vc and last_fb_vc to unsigned
integers and check them against the upper boundary, and make sure that
first_fb_vc is smaller than last_fb_vc.
Signed-off-by: Helge Deller
Cc: sta...@vger.kernel.org
diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c
index 2fc1b80a26ad
FRAMEBUFFER_CONSOLE_LEGACY_ACCELERATION enabled, console scrolling is
slowed down by factors so that it feels as if you use a 9600 baud
terminal.
So, drop those unnecessary checks and speed up fbdev console
acceleration during bootup.
Signed-off-by: Helge Deller
Cc: sta...@vger.kernel.org
diff --git a/drivers/video/fbdev/core
On 6/5/22 10:59, Xiang wangx wrote:
> Delete the redundant word 'its'.
>
> Signed-off-by: Xiang wangx
applied to fbdev tree.
Thanks!
Helge
> ---
> drivers/video/fbdev/skeletonfb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/skeletonfb.c
> b/dri
On 6/8/22 20:09, Bjorn Helgaas wrote:
> On Wed, Jun 08, 2022 at 06:26:34PM +0200, Daniel Vetter wrote:
>> On Tue, Jun 07, 2022 at 06:11:10PM -0500, Bjorn Helgaas wrote:
>>> From: Bjorn Helgaas
>>>
>>> PCI-specific power management (pci_driver.suspend and pci_driver.resume) is
>>> deprecated. If d
orm devices
> for OF framebuffers")
>
> Include missing platform_device.h to allow cleaning asm/pci.h
>
> Cc: Thomas Zimmermann
> Fixes: 52b1b46c39ae ("of: Create platform devices for OF framebuffers")
> Signed-off-by: Christophe Leroy
Acked-by: Helge Deller
I as
On 6/8/22 13:43, Yihao Han wrote:
> clk_disable() already checks the clk ptr using IS_ERR_OR_NULL(clk)
> and clk_enable() checks the clk ptr using !clk, so there is no
> need to check clk ptr again before calling them.
>
> Signed-off-by: Yihao Han
applied to fbdev tree.
Thanks!
Helge
> ---
> d
On 6/2/22 12:50, Hans de Goede wrote:
> Hi,
>
> On 6/2/22 11:42, Yihao Han wrote:
>> clk_put() already checks the clk ptr using !clk and IS_ERR()
>> so there is no need to check it again before calling it.
>>
>> Signed-off-by: Yihao Han
>> ---
>> drivers/video/fbdev/simplefb.c | 3 +--
>> 1 file
On 6/21/22 20:54, Jiang Jian wrote:
> file: drivers/video/fbdev/omap/sossi.c
> line: 362
> * We set explicitly the the bus_pick_count as well, although
> changed to
> * We set explicitly the bus_pick_count as well, although
>
> Signed-off-by: Jiang Jian
Both patches applied.
Thanks!
He
On 2/2/22 12:05, Daniel Vetter wrote:
> On Tue, Feb 1, 2022 at 11:52 PM Helge Deller wrote:
>>
>> Hello Daniel,
>>
>> On 2/1/22 21:11, Daniel Vetter wrote:
>>> On Tue, Feb 1, 2022 at 7:59 PM Helge Deller wrote:
>>>>
>>>> Add a con
driver.
This series is being discussed on linux-fbdev and dri-devel mailing lists.
Updates in v3:
- respin with fixes to build rotation code
Updates in v4:
- changed the Kconfig option and Kconfig help text
Helge Deller (3):
Revert "fbdev: Garbage collect fbdev scrolling acceleration, p
be reverted. By reverting we
reintroduce hardware-based scrolling acceleration and fix the
performance regression for fbdev drivers.
There isn't any impact on DRM when reverting those patches.
Signed-off-by: Helge Deller
Acked-by: Geert Uytterhoeven
Acked-by: Sven Schnelle
Cc: sta...@vger.ke
be reverted. By reverting we
reintroduce hardware-based scrolling acceleration and fix the
performance regression for fbdev drivers.
There isn't any impact on DRM when reverting those patches.
Signed-off-by: Helge Deller
Acked-by: Geert Uytterhoeven
Acked-by: Sven Schnelle
Cc: sta...@vger.ke
ay.
In this v3 patch version I additionally changed the GETVYRES() and GETVXRES()
macros to take a pointer to the fbcon_display struct. This fixes the build when
console rotation is enabled and helps the compiler again to optimize out code.
Signed-off-by: Helge Deller
Cc: sta...@vger.kernel.org
On 2/2/22 18:27, Sam Ravnborg wrote:
> Hi Helge,
>
> On Tue, Feb 01, 2022 at 04:02:40PM +0100, Helge Deller wrote:
>> On 1/31/22 07:57, Yizhuo Zhai wrote:
>>> In function do_fb_ioctl(), the "arg" is the type of unsigned long,
>>
>> yes, because it c
1 - 100 of 691 matches
Mail list logo
