Re: [PATCH] drm/rockchip: Cope with endpoints that haven't been registered yet

2021-03-21 Thread Heiko Stuebner
Hi Jonathan, Am Dienstag, 16. März 2021, 19:27:53 CET schrieb Jonathan McDowell: > The Rockchip RGB CRTC output driver attempts to avoid probing Rockchip > subdrivers to see if they're a connected panel or bridge. However part > of its checks assumes that if no OF platform device is found then it

Re: [PATCH] drm/panel: panel-simple: add bus-format and connector-type to Innolux n116bge

2021-01-18 Thread Heiko Stuebner
On Sat, 9 Jan 2021 14:09:51 +0100, Heiko Stuebner wrote: > The Innolux n116bge panel has an eDP connector and 3*6 bits bus format. Applied, thanks! [1/1] drm/panel: panel-simple: add bus-format and connector-type to Innolux n116bge commit: 87969bcd49480508568070fd93d7367f03316aa9 B

[PATCH 1/6] drm/rockchip: dsi: add own additional pclk handling

2021-02-02 Thread Heiko Stuebner
From: Heiko Stuebner In a followup patch, we'll need to access the pclk ourself to enable some functionality, so get and store it in the rockchip dw-dsi variant as well. Clocks are refcounted, so possible cascading enablements are no problem. Signed-off-by: Heiko Stuebner --- drivers/gp

[PATCH 4/6] arm64: dts: rockchip: add #phy-cells to mipi-dsi1

2021-02-02 Thread Heiko Stuebner
From: Heiko Stuebner The dsi controller includes access to the dphy which might be used not only for dsi output but also for csi input on dsi1, so add the necessary #phy-cells to allow it to be used as phy. Signed-off-by: Heiko Stuebner --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 1 + 1

[PATCH 3/6] drm/rockchip: dsi: add ability to work as a phy instead of full dsi

2021-02-02 Thread Heiko Stuebner
From: Heiko Stuebner SoCs like the rk3288 and rk3399 have 3 mipi dphys on them. One is TX- only, one is RX-only and one can be configured to do either TX or RX. The RX phy is statically connected to the first Image Signal Processor, the TX phy is statically connected to the first DSI controller

[PATCH 2/6] dt-bindings: display: rockchip-dsi: add optional #phy-cells property

2021-02-02 Thread Heiko Stuebner
From: Heiko Stuebner The Rockchip DSI controller on some SoCs also controls a bidrectional dphy, which would be connected to an Image Signal Processor as a phy in the rx configuration. So allow a #phy-cells property for the dsi controller. Signed-off-by: Heiko Stuebner --- .../bindings

[PATCH 6/6] arm64: dts: rockchip: add isp1 node on rk3399

2021-02-02 Thread Heiko Stuebner
From: Heiko Stuebner ISP1 is supplied by the tx1rx1 dphy, that is controlled from inside the dsi1 controller, so include the necessary phy-link for it. Signed-off-by: Heiko Stuebner --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 26 1 file changed, 26 insertions

[PATCH 0/6] Support second Image Signal Processor on rk3399

2021-02-02 Thread Heiko Stuebner
That solution is needed at least on rk3399 and rk3288 but no-one has looked at camera support on rk3288 at all, so right now only implement the rk3399 specifics. Heiko Stuebner (6): drm/rockchip: dsi: add own additional pclk handling dt-bindings: display: rockchip-dsi: add optional #phy-cells pro

[PATCH 5/6] arm64: dts: rockchip: add cif clk-control pinctrl for rk3399

2021-02-02 Thread Heiko Stuebner
From: Heiko Stuebner This enables variant a of the clkout signal for camera applications and also the cifclkin pinctrl setting. Signed-off-by: Heiko Stuebner --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 12 1 file changed, 12 insertions(+) diff --git a/arch/arm64/boot/dts

[PATCH] drm/panel: kd35t133: allow using non-continuous dsi clock

2021-02-06 Thread Heiko Stuebner
upport for non-continuous HS clock") and without it the panel only emits stripes instead of output. Signed-off-by: Heiko Stuebner --- drivers/gpu/drm/panel/panel-elida-kd35t133.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-elida-kd35t1

[PATCH v2 0/6] Support second Image Signal Processor on rk3399

2021-02-10 Thread Heiko Stuebner
uring its probe - add Sebastian's Tested-by - add Rob's Ack for the phy-cells property Heiko Stuebner (6): drm/rockchip: dsi: add own additional pclk handling dt-bindings: display: rockchip-dsi: add optional #phy-cells property drm/rockchip: dsi: add ability to work as a phy inst

[PATCH 5/6] arm64: dts: rockchip: add cif clk-control pinctrl for rk3399

2021-02-10 Thread Heiko Stuebner
From: Heiko Stuebner This enables variant a of the clkout signal for camera applications and also the cifclkin pinctrl setting. Signed-off-by: Heiko Stuebner Tested-by: Sebastian Fricke --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 12 1 file changed, 12 insertions(+) diff

[PATCH v2 1/6] drm/rockchip: dsi: add own additional pclk handling

2021-02-10 Thread Heiko Stuebner
From: Heiko Stuebner In a followup patch, we'll need to access the pclk ourself to enable some functionality, so get and store it in the rockchip dw-dsi variant as well. Clocks are refcounted, so possible cascading enablements are no problem. Signed-off-by: Heiko Stuebner Tested-by: Seba

[PATCH 3/6] drm/rockchip: dsi: add ability to work as a phy instead of full dsi

2021-02-10 Thread Heiko Stuebner
From: Heiko Stuebner SoCs like the rk3288 and rk3399 have 3 mipi dphys on them. One is TX- only, one is RX-only and one can be configured to do either TX or RX. The RX phy is statically connected to the first Image Signal Processor, the TX phy is statically connected to the first DSI controller

[PATCH 4/6] arm64: dts: rockchip: add #phy-cells to mipi-dsi1

2021-02-10 Thread Heiko Stuebner
From: Heiko Stuebner The dsi controller includes access to the dphy which might be used not only for dsi output but also for csi input on dsi1, so add the necessary #phy-cells to allow it to be used as phy. Signed-off-by: Heiko Stuebner Tested-by: Sebastian Fricke --- arch/arm64/boot/dts

[PATCH 6/6] arm64: dts: rockchip: add isp1 node on rk3399

2021-02-10 Thread Heiko Stuebner
From: Heiko Stuebner ISP1 is supplied by the tx1rx1 dphy, that is controlled from inside the dsi1 controller, so include the necessary phy-link for it. Signed-off-by: Heiko Stuebner Tested-by: Sebastian Fricke --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 26 1 file

[PATCH v2 2/6] dt-bindings: display: rockchip-dsi: add optional #phy-cells property

2021-02-10 Thread Heiko Stuebner
From: Heiko Stuebner The Rockchip DSI controller on some SoCs also controls a bidrectional dphy, which would be connected to an Image Signal Processor as a phy in the rx configuration. So allow a #phy-cells property for the dsi controller. Signed-off-by: Heiko Stuebner Acked-by: Rob Herring

Re: [PATCH 0/6] Support second Image Signal Processor on rk3399

2021-02-13 Thread Heiko Stuebner
Hi Sebastian, Am Samstag, 13. Februar 2021, 12:19:57 CET schrieb Sebastian Fricke: > On 11.02.2021 15:42, Heiko Stübner wrote: > >Am Donnerstag, 11. Februar 2021, 06:25:15 CET schrieb Sebastian Fricke: > >> On 10.02.2021 12:15, Heiko Stübner wrote: > >> >Am Freitag, 5. Februar 2021, 15:55:56 CET s

Re: [PATCH] drm/panel: kd35t133: allow using non-continuous dsi clock

2021-02-23 Thread Heiko Stuebner
On Sat, 6 Feb 2021 14:50:20 +0100, Heiko Stuebner wrote: > The panel is able to work when dsi clock is non-continuous, thus > the system power consumption can be reduced using such feature. > > Add MIPI_DSI_CLOCK_NON_CONTINUOUS to panel's mode_flags. > > Also the flag act

Re: [PATCH] drm/rockchip: Require the YTR modifier for AFBC

2021-02-23 Thread Heiko Stuebner
] Applied, thanks! [1/1] drm/rockchip: Require the YTR modifier for AFBC commit: 0de764474e6e0a74bd75715fed227d82dcda054c Best regards, -- Heiko Stuebner ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/rockchip: Avoid uninitialized use of endpoint id in LVDS

2020-11-29 Thread Heiko Stuebner
int. > Initialize the endpoint_id variable to 0 to avoid using an > uninitialized variable in that case. Applied, thanks! [1/1] drm/rockchip: Avoid uninitialized use of endpoint id in LVDS commit: aec9fe892812ed10d0bffcf309d2a8fc380d8ce6 Best rega

Re: (subset) [PATCH v5 0/7] Enable rk3066a HDMI sound

2020-11-29 Thread Heiko Stuebner
_PARENT to sclk for rk3066a i2s and uart clocks commit: 5868491e1257786628fdd2457dfb77609f49f91d [2/7] clk: rockchip: fix i2s gate bits on rk3066 and rk3188 commit: caa2fd752ecb80faf7a2e1cdadc737187934675e Best regards, -- Heiko Stuebner ___

Re: [PATCH] drm/rockchip: vop: Add timeout for DSP hold

2021-10-17 Thread Heiko Stuebner
ock up the system. > > In local tests, this operation takes less than 20ms. Applied, thanks! [1/1] drm/rockchip: vop: Add timeout for DSP hold commit: 085af7d28897deb08a4f64a29e55525f963cc041 Best regards, -- Heiko Stuebner

Re: [PATCH v3 0/4] Fix Rockchip MIPI DSI display init timeouts

2021-10-17 Thread Heiko Stuebner
ip: dsi: Disable PLL clock on bind error commit: 5a614570172e1c9f59035d259dd735acd4f1c01b Best regards, -- Heiko Stuebner

Re: [PATCH v3 2/4] drm/rockchip: dsi: Reconfigure hardware on resume()

2021-10-17 Thread Heiko Stuebner
Am Dienstag, 28. September 2021, 23:35:50 CEST schrieb Brian Norris: > Since commit 43c2de1002d2, we perform most HW configuration in the > bind() function. This configuration may be lost on suspend/resume, so we > need to call it again. That may lead to errors like this after system > suspend/resu

Re: [PATCH] drm/rockchip: Implement mmap as GEM object function

2021-10-21 Thread Heiko Stuebner
t function commit: f8b5307074f8be80a9806d85b01e5ba933dd0360 Best regards, -- Heiko Stuebner

Re: [PATCH v3] drm/rockchip: Update crtc fixup to account for fractional clk change

2021-09-21 Thread Heiko Stuebner
fractional clk change commit: e93a3ccf76996df53ff6c2c03626b70bb0b0d55d Best regards, -- Heiko Stuebner

Re: [PATCH v2] drm/rockchip: cdn-dp-core: Fix cdn_dp_resume unused warning

2021-09-21 Thread Heiko Stuebner
thanks! [1/1] drm/rockchip: cdn-dp-core: Fix cdn_dp_resume unused warning commit: f7c57a4566115657c16fd6603b6ef8a21bae5194 Best regards, -- Heiko Stuebner

Re: [PATCH] drm/rockchip: Check iommu itself instead of it's parent for device_is_available

2021-09-21 Thread Heiko Stuebner
e commit: e1202c7a65b10258f9a11c1d2613c2aa91fe11cd Best regards, -- Heiko Stuebner

Re: [PATCH] drm/rockchip: add DRM_BRIDGE_ATTACH_NO_CONNECTOR flag to drm_bridge_attach

2021-09-21 Thread Heiko Stuebner
r. Applied, thanks! [1/1] drm/rockchip: add DRM_BRIDGE_ATTACH_NO_CONNECTOR flag to drm_bridge_attach commit: 2e87bf389e1396b9f1360e1a7cdc27f423f56463 Best regards, -- Heiko Stuebner

Re: [PATCH] drm/rockchip: dsi: Fix duplicate included linux/phy/phy.h

2021-09-21 Thread Heiko Stuebner
ux/phy/phy.h commit: d90def98f90fb166191f19b41620e1a54b6dac75 Best regards, -- Heiko Stuebner

Re: [PATCH] drm/rockchip: handle non-platform devices in rockchip_drm_endpoint_is_subdriver

2021-09-21 Thread Heiko Stuebner
] Applied, thanks! [1/1] drm/rockchip: handle non-platform devices in rockchip_drm_endpoint_is_subdriver commit: 37825e07ab413187e1ea078bc33dcdb835008be2 Best regards, -- Heiko Stuebner

Re: [PATCH] drm/rockchip: Make use of the helper function devm_platform_ioremap_resource()

2021-09-21 Thread Heiko Stuebner
_resource() commit: 61735698103fafb5bc0df4ab208fc140c27cabc6 Best regards, -- Heiko Stuebner

Re: [PATCH] drm/rockchip: dsi: make hstt_table static

2021-09-21 Thread Heiko Stuebner
27; was not declared. Should it be static? Applied, thanks! [1/1] drm/rockchip: dsi: make hstt_table static commit: adfeef9370ff8b53c5f73cda3a63531d92b1ca64 Best regards, -- Heiko Stuebner

Re: [PATCH] drm/rockchip: remove unused psr_list{,_lock}

2021-09-21 Thread Heiko Stuebner
1d Best regards, -- Heiko Stuebner

Re: [PATCH] drm/rockchip: remove of_match_ptr() from vop_driver_dt_match

2021-09-21 Thread Heiko Stuebner
tatic const struct of_device_id vop_driver_dt_match[] = { > > Fixed it by removing of_match_ptr(). Applied, thanks! [1/1] drm/rockchip: remove of_match_ptr() from vop_driver_dt_match commit: 87185cc823693933308bd33a190032e9c262c75f Best regards, -- Heiko Stuebner

Re: [PATCH v2] drm/rockchip: remove of_match_ptr()

2021-09-21 Thread Heiko Stuebner
iable] >static const struct of_device_id rockchip_dp_dt_ids[] = { > > [...] Applied, thanks! [1/1] drm/rockchip: remove of_match_ptr() commit: f7fc7a79bdbf20f2edef69dc62666a4f0cdac0e3 Best regards, -- Heiko Stuebner

Re: (subset) [PATCH v2 0/3] (Re)enable DP/HDMI audio for RK3399 Gru

2022-01-23 Thread Heiko Stuebner
: Switch RK3399-Gru DP to SPDIF output commit: b5fbaf7d779f5f02b7f75b080e7707222573be2a Best regards, -- Heiko Stuebner

Re: [PATCH 01/12] dt-bindings: display: rockchip: Add compatible for rk3568 HDMI

2021-11-27 Thread Heiko Stuebner
Hi, Am Mittwoch, 17. November 2021, 15:33:36 CET schrieb Sascha Hauer: > From: Benjamin Gaignard > > Define a new compatible for rk3568 HDMI. > This version of HDMI hardware block needs two new clocks hclk_vio and hclk > to provide phy reference clocks. > > Signed-off-by: Benjamin Gaignard > Re

Re: [PATCH 07/18] dt-bindings: display: rockchip: dw-hdmi: Allow "ref" as clock name

2021-12-12 Thread Heiko Stuebner
Am Mittwoch, 8. Dezember 2021, 16:12:19 CET schrieb Sascha Hauer: > "vpll" is a misnomer. A clock input to a device should be named after > the usage in the device, not after the clock that drives it. On the > rk3568 the same clock is driven by the HPLL. > To fix that, this patch renames the vpll c

[PATCH] drm/panel: panel-simple: add bus-format and connector-type to Innolux n116bge

2021-01-09 Thread Heiko Stuebner
From: Heiko Stuebner The Innolux n116bge panel has an eDP connector and 3*6 bits bus format. Signed-off-by: Heiko Stuebner --- drivers/gpu/drm/panel/panel-simple.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel

[PATCH v4 1/7] clk: rockchip: add clock flag parameter when register pll

2016-08-05 Thread Heiko Stuebner
Am Freitag, 29. Juli 2016, 15:56:55 schrieb Lin Huang: > From: Heiko Stübner > > add clock flag parameter so we can pass specific clock flag > (like CLK_GET_RATE_NOCACHE etc..)to pll driver. > > Signed-off-by: Heiko Stübner > Signed-off-by: Lin Huang applied to my clock branch for 4.9 after

[PATCH v4 3/7] clk: rockchip: rk3399: add SCLK_DDRCLK ID for ddrc

2016-08-05 Thread Heiko Stuebner
Am Freitag, 29. Juli 2016, 15:56:57 schrieb Lin Huang: > Signed-off-by: Lin Huang > --- > Changes in v4: > -None > > Changes in v3: > -None > > Changes in v2: > - None > Changes in v1: > - None > > include/dt-bindings/clock/rk3399-cru.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a

[PATCH v4 2/7] clk: rockchip: add new clock-type for the ddrclk

2016-08-05 Thread Heiko Stuebner
Am Donnerstag, 4. August 2016, 22:23:05 schrieb Heiko Stübner: > Hi Lin, > > Am Freitag, 29. Juli 2016, 15:56:56 schrieb Lin Huang: > > On new rockchip platform(rk3399 etc), there have dcf controller to > > do ddr frequency scaling, and this controller will implement in > > arm-trust-firmware. We

[PATCH v6 1/8] clk: rockchip: add new clock-type for the ddrclk

2016-08-19 Thread Heiko Stuebner
Hi Lin, Am Mittwoch, 17. August 2016, 06:36:22 CEST schrieb Lin Huang: > On new rockchip platform(rk3399 etc), there have dcf controller to > do ddr frequency scaling, and this controller will implement in > arm-trust-firmware. We add a special clock-type to handle that. > > Signed-off-by: Lin Hu

[PATCH v6 3/8] clk: rockchip: rk3399: add ddrc clock support

2016-08-19 Thread Heiko Stuebner
Am Mittwoch, 17. August 2016, 06:36:24 CEST schrieb Lin Huang: > add ddrc clock setting, so we can do ddr frequency > scaling on rk3399 platform in future. > > Signed-off-by: Lin Huang > --- > Changes in v6: > - None > > Changes in v5: > - fit for the ddr type > > Changes in v4: > - None > > C

Re: [PATCH 1/3] dt-bindings: Add binding for IT6505.

2019-05-16 Thread Heiko Stuebner
Hi Allen, Am Mittwoch, 8. Mai 2019, 09:48:40 CEST schrieb allen: > From: Allen Chen > > Add a DT binding documentation for IT6505. > > Signed-off-by: Allen Chen > > --- > .../bindings/display/bridge/ite,it6505.txt | 30 > ++ > .../devicetree/bindings/vendor-prefi

Re: [PATCH v2 1/3] dt-bindings: gpu: add #cooling-cells property to the ARM Mali Midgard GPU binding

2019-05-17 Thread Heiko Stuebner
Am Donnerstag, 16. Mai 2019, 19:40:38 CEST schrieb Doug Anderson: > Hi, > > On Thu, May 16, 2019 at 10:25 AM Matthias Kaehlcke wrote: > > > The GPU can be used as a thermal cooling device, add an optional > > '#cooling-cells' property. > > > > Signed-off-by: Matthias Kaehlcke > > --- > > Change

Re: [PATCH v2 1/3] dt-bindings: gpu: add #cooling-cells property to the ARM Mali Midgard GPU binding

2019-05-22 Thread Heiko Stuebner
Am Donnerstag, 16. Mai 2019, 19:25:08 CEST schrieb Matthias Kaehlcke: > The GPU can be used as a thermal cooling device, add an optional > '#cooling-cells' property. > > Signed-off-by: Matthias Kaehlcke applied to drm-misc-next for 5.3

Re: [PATCH v2 2/3] ARM: dts: rockchip: Add #cooling-cells entry for rk3288 GPU

2019-05-22 Thread Heiko Stuebner
Am Donnerstag, 16. Mai 2019, 19:25:09 CEST schrieb Matthias Kaehlcke: > The Mali GPU of the rk3288 can be used as cooling device, add > a #cooling-cells entry for it. > > Signed-off-by: Matthias Kaehlcke > Reviewed-by: Douglas Anderson applied patches 2+3 for 5.3 Thanks Heiko ___

Re: [PATCH v2] drm/rockchip: shutdown drm subsystem on shutdown

2019-04-18 Thread Heiko Stuebner
Am Dienstag, 2. April 2019, 13:37:53 CEST schrieb Heiko Stuebner: > From: Vicente Bergas > > As explained by Robin Murphy: > > the IOMMU shutdown disables paging, so if the VOP is still > > scanning out then that will result in whatever IOVAs it was using now going > >

Re: [PATCH] drm/bridge: dw-hdmi: fix SCDC configuration for ddc-i2c-bus

2019-04-23 Thread Heiko Stuebner
DC is not supported when there is no DDC bus. > > Fixes: 264fce6cc2c1 ("drm/bridge: dw-hdmi: Add SCDC and TMDS Scrambling > support") > Signed-off-by: Jonas Karlman I've looked that up and yeah, hdmi->ddc seems the right thing to use as it points either to the exter

Re: [PATCH] drm/rockchip: rgb: update SPDX license identifier

2019-01-25 Thread Heiko Stuebner
Am Mittwoch, 23. Januar 2019, 11:14:39 CET schrieb Sandy Huang: > update SPDX License Identifier from GPL-2.0+ to GPL-2.0 > and drop some GPL text. > > Signed-off-by: Sandy Huang I've added Fixes, Cc-stable and Reported-by (for Thomas) tags and applied it to drm-misc-fixes Thanks Heiko _

[PATCH] drm/rockchip: check yuv2yuv existence before assigning window data

2019-01-25 Thread Heiko Stuebner
: 1c21aa8f2b68 ("drm/rockchip: Fix YUV buffers color rendering") Signed-off-by: Heiko Stuebner --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip

Re: linux-next: Fixes tag needs some work in the drm-misc-fixes tree

2019-01-27 Thread Heiko Stuebner
Am Sonntag, 27. Januar 2019, 04:41:26 CET schrieb Stephen Rothwell: > Hi all, > > In commit > > 053ff09f1a8f ("drm/rockchip: rgb: update SPDX license identifier") > > Fixes tag > > Fixes: 1f0f01515172 ("Add support for Rockchip Soc RGB output interface") looks like I accidentially lost the

Re: [PATCH 21/26] drm/rockchip: Use drm_fb_helper_fill_info

2019-01-27 Thread Heiko Stuebner
adead.org After looking up the rest of the series and also realizing that fbi->par seems to be set when a client attaches to the fb, this looks good to me, so Reviewed-by: Heiko Stuebner > --- > drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c | 4 +--- > 1 file changed, 1 insertion(+

Re: [PATCH] drm/rockchip: check yuv2yuv existence before assigning window data

2019-01-27 Thread Heiko Stuebner
Am Samstag, 26. Januar 2019, 01:24:37 CET schrieb Heiko Stuebner: > Before assigning window data, we should check if the yuv2yuv vop-data > is set at all, because it looks like it can otherwise reference something > wrong, as I saw on my rk3188 today which ended up in a null pointer >

Re: [PATCH] drm/rockchip: fix for mailbox read validation.

2019-01-28 Thread Heiko Stuebner
Am Montag, 19. November 2018, 16:14:14 CET schrieb Damian Kos: > This is basically the same fix as in > commit fa68d4f8476b ("drm/rockchip: fix for mailbox read size") > but for cdn_dp_mailbox_validate_receive function. > > See patchwork.kernel.org/patch/10671981/ for details. > > Signed-off-by:

Re: [PATCHv2 4/9] drm/rockchip/rockchip_drm_gem.c: Convert to use vm_insert_range

2019-01-31 Thread Heiko Stuebner
Rockchip hardware and display is still working, including talking to Lima via prime. So if there aren't any big changes for v2, on Rockchip Tested-by: Heiko Stuebner Heiko ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.f

Re: [PATCHv2 1/9] mm: Introduce new vm_insert_range and vm_insert_range_buggy API

2019-01-31 Thread Heiko Stuebner
een v1 and v2. Nevertheless I managed to test v1 on Rockchip hardware and display is still working, including talking to Lima via prime. So if there aren't any big changes for v2, on Rockchip Tested-by: Heiko Stuebner Heiko ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCHv2 1/9] mm: Introduce new vm_insert_range and vm_insert_range_buggy API

2019-01-31 Thread Heiko Stuebner
Am Donnerstag, 31. Januar 2019, 13:31:52 CET schrieb Souptick Joarder: > On Thu, Jan 31, 2019 at 5:37 PM Heiko Stuebner wrote: > > > > Am Donnerstag, 31. Januar 2019, 04:08:12 CET schrieb Souptick Joarder: > > > Previouly drivers have their own way of mapping range of &

Re: [PATCH] dt-bindings: display: add binding for Innolux ee101ia-01d panel

2019-02-03 Thread Heiko Stuebner
Am Dienstag, 29. Januar 2019, 17:45:50 CET schrieb Daniel Vetter: > On Tue, Jan 29, 2019 at 02:37:23PM +0100, Heiko Stübner wrote: > > Hi Thierry, > > > > Am Dienstag, 13. November 2018, 13:42:05 CET schrieb Heiko Stuebner: > > > From: Heiko Stuebner > > >

Re: [PATCH v2 1/7] ARM: dts: rockchip: rk3066: add HCLK_HDMI to pmu node

2018-12-30 Thread Heiko Stuebner
Am Samstag, 29. Dezember 2018, 14:33:12 CET schrieb Johan Jonker: > A MK808 TV stick with rk3066 processor > boots normal with logo and console, > but after booting the monitor remains black. > This patch fixes a vblank wait time out > by adding HCLK_HDMI to the pmu node. > The HCLK_HDMI clock is n

Re: [PATCH v2 2/7] clk: rockchip: rk3188: add CLK_SET_RATE_PARENT for lcdc dclk

2018-12-30 Thread Heiko Stuebner
Am Samstag, 29. Dezember 2018, 14:33:13 CET schrieb Johan Jonker: > From: Finley Xiao > > Add CLK_SET_RATE_PARENT for lcdc dclk. > > Signed-off-by: Finley Xiao > Signed-off-by: Johan Jonker applied for 4.22 Thanks Heiko ___ dri-devel mailing list

Re: [PATCH v2 3/7] drm: rockchip: vop: add rk3066 vop definitions

2018-12-30 Thread Heiko Stuebner
Hi Johan, Am Samstag, 29. Dezember 2018, 14:33:14 CET schrieb Johan Jonker: > From: Mark Yao > > This patch adds the rk3066 VOP definitions. > > The VOP or LCD Controller serves as interface between > framebuffer memory and a display device (LCD panel or TV set). > > This SOC has two symmetric

Re: [PATCH v2] drm/rockchip: Fix YUV buffers color rendering

2019-01-07 Thread Heiko Stuebner
Hi, sorry, only now got to test this on actual hardware, Am Freitag, 14. Dezember 2018, 17:29:20 CET schrieb Ezequiel Garcia: > From: Daniele Castagna > > Currently, YUV hardware overlays are converted to RGB using > a color space conversion different than BT.601. > > The result is that colors

Re: [PATCH v3] drm/rockchip: Fix YUV buffers color rendering

2019-01-10 Thread Heiko Stuebner
Am Dienstag, 8. Januar 2019, 22:46:59 CET schrieb Ezequiel Garcia: > From: Daniele Castagna > > Currently, YUV hardware overlays are converted to RGB using > a color space conversion different than BT.601. > > The result is that colors of e.g. NV12 buffers don't match > colors of YUV hardware ov

Re: [PATCH v4] drm/rockchip: update cursors asynchronously through atomic.

2019-01-10 Thread Heiko Stuebner
Am Mittwoch, 5. Dezember 2018, 13:33:10 CET schrieb Helen Koike: > From: Enric Balletbo i Serra > > Add support to async updates of cursors by using the new atomic > interface for that. > > Signed-off-by: Enric Balletbo i Serra > [updated for upstream] > Signed-off-by: Helen Koike applied to

Re: [PATCH 0/3] Support reflect-x/y on RK3328, RK3368, and RK3399

2019-01-10 Thread Heiko Stuebner
Am Mittwoch, 9. Januar 2019, 19:56:36 CET schrieb Ezequiel Garcia: > Here's a small series supporting plane reflection (aka. mirroring) > properties on RK3328, RK3368, and RK3399 SoCs. > > Note that RK3288 specification doesn't seem to document registers > for plane mirroring, but instead it only

Re: [PATCH v2 3/7] drm: rockchip: vop: add rk3066 vop definitions

2019-01-12 Thread Heiko Stuebner
Am Freitag, 11. Januar 2019, 15:54:24 CET schrieb Rob Herring: > On Sun, Dec 30, 2018 at 06:22:00PM +0100, Heiko Stuebner wrote: > > Hi Johan, > > > > Am Samstag, 29. Dezember 2018, 14:33:14 CET schrieb Johan Jonker: > > > From: Mark Yao > > > > >

Re: [PATCH v2 5/7] ARM: dts: rockchip: add rk3066 vop display nodes

2019-01-12 Thread Heiko Stuebner
Am Samstag, 29. Dezember 2018, 14:33:16 CET schrieb Johan Jonker: > From: Mark Yao > > This patch adds the core display subsystem and vop nodes to rk3066. > > Signed-off-by: Mark Yao > Signed-off-by: Johan Jonker applied for 5.1 Thanks Heiko ___

Re: [PATCH 3/4] drm/rockchip: add missing of_node_put

2019-01-13 Thread Heiko Stuebner
Am Sonntag, 13. Januar 2019, 09:47:43 CET schrieb Julia Lawall: > The device node iterators perform an of_node_get on each iteration, so a > jump out of the loop requires an of_node_put. > > The semantic patch that fixes this problem is as follows > (http://coccinelle.lip6.fr): > > // > @@ > exp

Re: [PATCH 3/4] drm/rockchip: add missing of_node_put

2019-01-14 Thread Heiko Stuebner
Am Montag, 14. Januar 2019, 11:05:56 CET schrieb Daniel Vetter: > On Sun, Jan 13, 2019 at 07:48:49PM +0100, Heiko Stuebner wrote: > > Am Sonntag, 13. Januar 2019, 09:47:43 CET schrieb Julia Lawall: > > > The device node iterators perform an of_node_get on each iteration, so a >

Re: [v8, 2/3] drm/rockchip: Add support for Rockchip Soc RGB output interface

2019-01-18 Thread Heiko Stuebner
Hi Thomas, Am Freitag, 18. Januar 2019, 01:40:03 CET schrieb Thomas Gleixner: > On Thu, 30 Aug 2018, Heiko Stuebner wrote: > > +++ b/drivers/gpu/drm/rockchip/rockchip_rgb.c > > @@ -0,0 +1,173 @@ > > +//SPDX-License-Identifier: GPL-2.0+ > > +/* > > + * Copyrigh

Re: [PATCH v8] drm/lima: driver for ARM Mali4xx GPUs

2019-03-12 Thread Heiko Stuebner
argument check > > > - fix job finish fence leak since kernel 5.0 > > > - use drm syncobj to replace native fence > > > - move buffer object GPU va map into kernel > > > - reserve syscall argument space for future info > > > - remove kernel gem mod

Re: [PATCH 2/4] drm/rockchip: Enable DRM InfoFrame support on RK3328 and RK3399

2019-06-14 Thread Heiko Stuebner
Am Sonntag, 26. Mai 2019, 23:20:05 CEST schrieb Jonas Karlman: > This patch enables Dynamic Range and Mastering InfoFrame on RK3328 and RK3399. > > Cc: Sandy Huang > Cc: Heiko Stuebner > Signed-off-by: Jonas Karlman Reviewed-by: Heiko Stuebner > --- > drivers/gpu

Re: [PATCH v5 0/7] drm/panel: simple: Add mode support to devicetree

2019-06-14 Thread Heiko Stuebner
Am Montag, 1. April 2019, 19:17:17 CEST schrieb Douglas Anderson: > I'm reviving Sean Paul's old patchset to get mode support in device > tree. The cover letter for his v3 is at: > https://lists.freedesktop.org/archives/dri-devel/2018-February/165162.html > > No code is different between v4 and v

Re: [PATCH] DRM: Rockchip: correct rate in the struct drm_dp_link assignment

2019-06-14 Thread Heiko Stuebner
Hi, Am Mittwoch, 5. Juni 2019, 10:04:24 CEST schrieb sandor...@nxp.com: > From: Sandor Yu > > variable of rate in the struct drm_dp_link should assign to > 162000/27/54/81. > > Signed-off-by: Sandor Yu applied to drm-misc-next after fixing patch subject and description to be in li

Re: [PATCH] drm/rockchip: dw_hdmi: add basic rk3228 support

2019-06-14 Thread Heiko Stuebner
Am Donnerstag, 23. Mai 2019, 00:46:29 CEST schrieb Justin Swartz: > Like the RK3328, RK322x SoCs offer a Synopsis DesignWare HDMI transmitter > and an Innosilicon HDMI PHY. > > Add a new dw_hdmi_plat_data struct, rk3228_hdmi_drv_data. > Assign a set of mostly generic rk3228_hdmi_phy_ops functions.

Re: [PATCH 27/59] drm/rockchip: Drop drm_gem_prime_export/import

2019-06-15 Thread Heiko Stuebner
linux-arm-ker...@lists.infradead.org > Cc: linux-rockc...@lists.infradead.org On rk3399 with panfrost via prime Tested-by: Heiko Stuebner and it obviously looks correct, so Reviewed-by: Heiko Stuebner > --- > drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 2 -- > 1 file cha

Re: [PATCH v2 01/15] dt-bindings: display: rockchip-lvds: Remove panel references

2019-06-27 Thread Heiko Stuebner
Am Montag, 24. Juni 2019, 23:56:35 CEST schrieb Rob Herring: > The panel bindings are outside the scope of the Rockchip LVDS interface > binding. The references are about to change too, so rather than update > them just drop the section on the panel bindings. > > Cc: Sandy Huang > Cc: "Heiko Stüb

Re: [PATCH] drm: bridge: dw-hdmi: Fix overflow workaround for Rockchip SoCs

2019-03-30 Thread Heiko Stuebner
Am Mittwoch, 20. Februar 2019, 08:52:31 CET schrieb Jonas Karlman: > The Rockchip RK3288 SoC (v2.00a) and RK3328/RK3399 SoCs (v2.11a) have > also been identified as needing this workaround with a single iteration. > > Fixes: be41fc55f1aa ("drm: bridge: dw-hdmi: Handle overflow workaround based >

Re: [PATCH v6 4/4] dt-bindings: display: rockchip: add document for rk3066 hdmi

2019-03-31 Thread Heiko Stuebner
Am Samstag, 30. März 2019, 10:56:39 CEST schrieb Johan Jonker: > This patch adds a binding that describes the HDMI controller for > rk3066. > > Signed-off-by: Johan Jonker > Reviewed-by: Rob Herring applied to drm-misc-next, so should land in 5.2 Thanks Heiko

Re: [PATCH v6 1/4] drm: rockchip: introduce rk3066 hdmi

2019-03-31 Thread Heiko Stuebner
Hi Johan, Am Samstag, 30. März 2019, 10:56:36 CEST schrieb Johan Jonker: > From: Zheng Yang > > The RK3066 HDMI TX serves as interface between a LCD Controller and > a HDMI bus. A HDMI TX consists of one HDMI transmitter controller and > one HDMI transmitter PHY. The interface has three (3) 8-bi

Re: [PATCH v6 2/4] ARM: dts: rockchip: add rk3066 hdmi nodes

2019-03-31 Thread Heiko Stuebner
Am Samstag, 30. März 2019, 10:56:37 CEST schrieb Johan Jonker: > From: Zheng Yang > > This patch adds the hdmi nodes to rk3066. > > Signed-off-by: Zheng Yang > Signed-off-by: Johan Jonker applied for 5.2 after correcting the alphabetical sorting of some properties. Thanks Heiko ___

Re: [PATCH v6 3/4] ARM: dts: rockchip: rk3066a-mk808: enable vop0 and hdmi nodes

2019-03-31 Thread Heiko Stuebner
Am Samstag, 30. März 2019, 10:56:38 CEST schrieb Johan Jonker: > This patch enables the vop0 and hdmi nodes > for a MK808 with rk3066 processor. > > Signed-off-by: Johan Jonker applied for 5.2 Thanks Heiko ___ dri-devel mailing list dri-devel@lists.

Re: [PATCH v5 5/5] drm: rockchip: add fixed screen size DVI-D support for rk3066 hdmi

2019-03-31 Thread Heiko Stuebner
Hi Johan, Am Donnerstag, 21. März 2019, 01:14:40 CEST schrieb Johan Jonker: > Add fixed screen size DVI-D support > for rk3066 hdmi with an extra patch. > > Signed-off-by: Johan Jonker > +static const struct drm_display_mode edid_cea_modes[] = { > + /* 4 - 1280x720@60Hz 16:9 */ > + { DR

[PATCH v2] drm/rockchip: shutdown drm subsystem on shutdown

2019-04-02 Thread Heiko Stuebner
ted commit message to explain the history] Signed-off-by: Heiko Stuebner --- drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c index 8d7a634c12c2..cb93

Re: [PATCH] drm: rockchip: add shutdown function to poweroff VOP and HDMI TX

2019-04-02 Thread Heiko Stuebner
Hi Johan, Am Montag, 11. März 2019, 19:14:27 CEST schrieb Johan Jonker: > Hi, > > Just found out that this was patched and reverted before.(lol) > The revert was 3 months ago for RK3399 boards, but other processors > like RK3066 are left without shutdown now. > > What's the status for a fix? > K

Re: [PATCH v5 07/11] drm/rockchip: Check for fast link training before enabling psr

2019-07-25 Thread Heiko Stuebner
.218441-9-s...@poorly.run > > Link to v4: > > https://patchwork.freedesktop.org/patch/msgid/20190508160920.144739-8-s...@poorly.run > > > > Cc: Zain Wang > > Cc: Tomasz Figa > > Tested-by: Heiko Stuebner > > @Heiko, could you please review patches

Re: (subset) [PATCH v4 00/27] drm/rockchip: RK356x VOP2 support

2022-02-08 Thread Heiko Stuebner
fac3 [25/27] clk: rk3568: Add CLK_SET_RATE_PARENT to the HDMI reference clock commit: 6e69052f01d9131388cfcfaee929120118a267f4 Best regards, -- Heiko Stuebner

Re: (subset) [PATCH v4 00/27] drm/rockchip: RK356x VOP2 support

2022-02-08 Thread Heiko Stuebner
gt; I hope this is due to my low quality cable. > > [...] Applied, thanks! [18/27] arm64: dts: rockchip: rk3399: reorder hmdi clocks commit: 2e8a8b5955a000cc655f7e368670518cbb77fe58 Best regards, -- Heiko Stuebner

Re: [PATCH] drm/rockchip: vop: Correct RK3399 VOP register fields

2022-02-08 Thread Heiko Stuebner
in23_data[] .format field: > > RK3288's format: VOP_REG(RK3288_WIN2_CTRL0, 0x7, 1) > RK3368's format: VOP_REG(RK3368_WIN2_CTRL0, 0x3, 5) > > [...] Applied, thanks! [1/1] drm/rockchip: vop: Correct RK3399 VOP register fields commit: 9da1e9ab82c92d0e89fe44cad2cd7c2d18d64070 Best regards, -- Heiko Stuebner

Re: (subset) [PATCH v6 0/5] Add GPU for RK356x SoCs

2022-02-11 Thread Heiko Stuebner
s! [1/5] dt-bindings: gpu: mali-bifrost: describe clocks for the rk356x gpu commit: f1775c26e8b8809d922a29bb5e3df6ea503d2fa0 Best regards, -- Heiko Stuebner

Re: (subset) [PATCH v6 0/5] Add GPU for RK356x SoCs

2022-02-11 Thread Heiko Stuebner
383456452378de07e55fc687069d1898a567d [5/5] arm64: dts: rockchip: enable the gpu on rk3568-evb1-v10 commit: 679f048a10d8322d79010e0e52f18a6c17bdf306 [6] arm64: dts: rockchip: enable the tsadc on rk3568-evb1-v10 Best regards, -- Heiko Stuebner

Re: (subset) [PATCH 0/5] Replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi

2022-05-02 Thread Heiko Stuebner
i_monitor() with is_hdmi commit: d2eabdb64474c2101953859601794f1ea08ec1d9 Best regards, -- Heiko Stuebner

Re: [PATCH] drm/rockchip: cdn-dp: change rk3399_cdn_dp from global to static

2022-05-02 Thread Heiko Stuebner
tic. Applied, thanks! [1/1] drm/rockchip: cdn-dp: change rk3399_cdn_dp from global to static commit: 7494b1ed1df414e43dc8429f0c016b2054b1b5da Best regards, -- Heiko Stuebner

Re: [PATCH] drm/rockchip: Support YUV formats with U/V swapped

2022-05-02 Thread Heiko Stuebner
ecoders only output NV21, and supporting this pixel format in > the display pipeline would allow the decoded video frames to be output > directly. > > [...] Applied, thanks! [1/1] drm/rockchip: Support YUV formats with U/V swapped commit: 3fa50896c35982afb59ad5bcbe04ec2e91bb54a5

Re: [PATCH] drm/rockchip: Refactor IOMMU initialisation

2022-05-02 Thread Heiko Stuebner
ation commit: 421be3ee36a497949a4b564cd1e4f7f9fe755f57 Additionally tested on rk3288, rk3399 and px30. Best regards, -- Heiko Stuebner

Re: [PATCH] drm/rockchip: vop: fix possible null-ptr-deref in vop_bind()

2022-05-02 Thread Heiko Stuebner
[1/1] drm/rockchip: vop: fix possible null-ptr-deref in vop_bind() commit: f8c242908ad15bbd604d3bcb54961b7d454c43f8 Best regards, -- Heiko Stuebner

  1   2   3   4   5   6   7   8   9   >