+ pr_err("Could not get lvl-vdd reg, %ld", ret);
> ctrl->lvl_vreg = NULL;
> - return PTR_ERR(ctrl->lvl_vreg);
> + return ret;
> }
>
> return 0;
> --
> 2.1.4
Reviewed-by: Eric Engestrom
On Mon, Aug 08, 2016 at 06:24:16PM -0300, Gustavo Padovan wrote:
> From: Gustavo Padovan
>
> Hi Greg,
>
> This is the last step in the Sync Framwork de-stage task. It de-stage
> the SW_SYNC validation framework and the sync_debug info debugfs file.
>
> The first 2 patches are clean up and impro
On Mon, Aug 08, 2016 at 06:24:19PM -0300, Gustavo Padovan wrote:
> From: Gustavo Padovan
>
> The common behaviour for trace headers is to have them in the same folder
> they are used, instead of creating a special trace/ directory.
>
> Signed-off-by: Gustavo Padovan
++ b/drivers/staging/android/sync_debug.h
> @@ -1,5 +1,5 @@
> /*
> - * include/linux/sync.h
> + * Sync File validation framework
"and debug information"
With that added,
Reviewed-by: Eric Engestrom
> *
> * Copyright (C) 2012 Google, Inc.
> *
> --
> 2.5.5
t paragraph could use some love: comma before "SW_SYNC_IOC_INC",
"that has seqno smaller or equal to it."
> + *
> + * struct sw_sync_ioctl_create_fence
> + * @value: the seqno to initiate the fence with
s/initiate/initialise/
With these fixed,
Reviewed-by:
To create fences on this timeline the SW_SYNC_IOC_CREATE_FENCE
> ioctl should be used. To increment the timeline value use SW_SYNC_IOC_INC.
>
> Also it exports Sync information on
>
> /sync/info
>
> Signed-off-by: Gustavo Padovan
Reviewed-by: Eric Engestrom
> -
of this feature.
>
> v2: take in Eric suggestions for the Documentation
>
> Signed-off-by: Gustavo Padovan
> Reviewed-by: Eric Engestrom
> ---
> drivers/staging/android/sw_sync.c | 31 +++
> 1 file changed, 31 insertions(+)
>
> diff -
Signed-off-by: Eric Engestrom
---
I moved the main bits to be the first diffs, shouldn't affect anything
when applying the patch, but I wanted to ask:
I don't like the hard-coded `32` the appears in both kmalloc() and
snprintf(), what do you think? If you don't like it either,
On Fri, Aug 12, 2016 at 04:29:37PM -0400, Sean Paul wrote:
> This patch consolidates all the various log functions/macros into
> one uber function, drm_printk. It also introduces some new DRM_DEV_*
> variants that use dev_printk to print the device name, which helps
> delineate multiple devices of
On Mon, Aug 15, 2016 at 12:54:01PM +0300, Jani Nikula wrote:
> On Mon, 15 Aug 2016, Eric Engestrom wrote:
> > Signed-off-by: Eric Engestrom
> > ---
> >
> > I moved the main bits to be the first diffs, shouldn't affect anything
> > when applying the patch,
On Mon, Aug 15, 2016 at 03:52:07PM +0200, Daniel Vetter wrote:
> On Mon, Aug 15, 2016 at 04:13:54PM +0300, Jani Nikula wrote:
> > On Mon, 15 Aug 2016, Eric Engestrom wrote:
> > > On Mon, Aug 15, 2016 at 12:54:01PM +0300, Jani Nikula wrote:
> > >> On Mon, 15 A
Signed-off-by: Eric Engestrom
---
drivers/gpu/drm/amd/amdgpu/dce_v10_0.c | 2 +-
drivers/gpu/drm/amd/amdgpu/dce_v11_0.c | 2 +-
drivers/gpu/drm/amd/amdgpu/dce_v8_0.c | 2 +-
drivers/gpu/drm/drm_atomic.c| 2 +-
drivers/gpu/drm/drm_crtc.c
image growth due to passing NULL around (Chris Wilson)
>
> Changes in v4:
> - Pull format string out into #define (Eric Engestrom)
>
>
> drivers/gpu/drm/drm_drv.c | 27 ++---
> include/drm/drmP.h| 140
> +++---
On Tue, Aug 16, 2016 at 09:18:34AM -0700, Sean Paul wrote:
> On Tue, Aug 16, 2016 at 5:28 AM, Eric Engestrom
> wrote:
> > On Mon, Aug 15, 2016 at 04:18:04PM -0700, Sean Paul wrote:
> >> This patch consolidates all the various log functions/macros into
> >> one u
On Monday, 2019-04-29 18:10:52 +0900, Seung-Woo Kim wrote:
> In drmModeGetPropertyPtr(), from upper error path, it calls free
> but with just next error path, it does not call. Fix the possible
> memory leak.
>
> Signed-off-by: Seung-Woo Kim
Reviewed-by: Eric Engestrom
and
On Thursday, 2019-05-16 09:37:40 -0700, Eric Anholt wrote:
> Eric Anholt writes:
>
> > [ Unknown signature status ]
> > James Clarke writes:
> >
> >> Like GNU/Linux, GNU/kFreeBSD's sys/types.h does not define the uintX_t
> >> types, which differs from the BSDs' headers. Thus we should include
>
On Monday, 2019-04-08 13:44:17 +, Ayan Halder wrote:
> Generated using make headers_install from the drm-next
> tree - git://anongit.freedesktop.org/drm/drm
> branch - drm-next
> commit - 14d2bd53a47a7e1cb3e03d00a6b952734cf90f3f
>
> The changes were as follows :-
>
> core: (drm.h, drm_fourcc.
> drm_i915_gem_context_'
> - Added different modes of per-process Graphics Translation Table
>
> msm:
> - Added various get or set GEM buffer info flags
> - Added some MSM_SUBMIT_BO_ macros
> - Modified 'struct drm_msm_gem_info'
On Tuesday, 2019-04-09 12:59:13 +0100, Eric Engestrom wrote:
> On Tuesday, 2019-04-09 11:35:14 +, Ayan Halder wrote:
> > Generated using make headers_install from the drm-next
> > tree - git://anongit.freedesktop.org/drm/drm
> > branch
On Wednesday, 2019-04-10 21:49:33 -0400, Rob Clark wrote:
> On Tue, Apr 9, 2019 at 8:27 AM Eric Engestrom
> wrote:
> > > > diff --git a/include/drm/msm_drm.h b/include/drm/msm_drm.h
> > > > index c06d0a5..91a16b3 100644
> > > > --- a/include/drm/msm
On Wednesday, 2019-01-23 10:45:17 +, Emil Velikov wrote:
> From: Emil Velikov
>
> Some devices can lack OF data or it may not be available in the uevent
> file. Fallback to the MODALIAS data in those cases.
>
> We strip any leading "MODALIAS=.*:" thus the resulting information is
> compatibl
On Wednesday, 2019-01-23 10:45:18 +, Emil Velikov wrote:
> From: Emil Velikov
>
> The functions are virtually identical, fold them up.
>
> Signed-off-by: Emil Velikov
Assuming patch 1 is OK, and `foo` gets renamed to something better:
Reviewed-by: Eric Engestrom
I don&#
On Tuesday, 2019-01-29 14:21:53 +0100, Daniel Vetter wrote:
> I'm kinda fed up explaining why the have a confusing name :-)
>
> Cc: Noralf Trønnes
> Cc: Laurent Pinchart
> Signed-off-by: Daniel Vetter
> ---
> Documentation/gpu/todo.rst | 10 ++
> 1 file changed, 10 insertions(+)
>
> d
: https://bugs.freedesktop.org/show_bug.cgi?id=109587
Fixes: 17dfe3ac93217b43f93b "xf86drm: Add drmIsMaster()"
Cc: Christopher James Halse Rogers
Cc: Emil Velikov
Signed-off-by: Eric Engestrom
---
xf86drm.c | 2 +-
xf86drm.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
di
On Friday, 2019-02-08 16:50:44 +, Emil Velikov wrote:
> On Fri, 8 Feb 2019 at 16:51, Daniel Stone wrote:
> >
> > Hi Eric,
> >
> > On Fri, 8 Feb 2019 at 15:03, Eric Engestrom
> > wrote:
> > > Xserver has struct members named `bool`, which means t
JOR - they will need patching to
> > run :-(
>
> Major/minor numbers were required when device files had to be created on
> regular filesystem like UFS but when a devfs filesystem was implemented
> for DragonFly almost a decade ago, nobody thought it was important anymore.
>
> The
Saw a couple of typos fixes in the patch DragonFlyBSD carries [1], so
I ran codespell (a spell checker for code) on the whole repo.
[1]
https://github.com/DragonFlyBSD/DPorts/blob/master/graphics/libdrm/files/patch-xf86drm.c
Signed-off-by: Eric Engestrom
---
I discarded the fixes in include
Signed-off-by: Eric Engestrom
---
RELEASING | 27 ---
1 file changed, 8 insertions(+), 19 deletions(-)
diff --git a/RELEASING b/RELEASING
index 7e03e3b9acb1cbfb261a..d1ad8e3b4ad16d4ca14f 100644
--- a/RELEASING
+++ b/RELEASING
@@ -9,25 +9,14 @@ However, this is up to
Signed-off-by: Eric Engestrom
---
tests/amdgpu/vce_tests.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/tests/amdgpu/vce_tests.c b/tests/amdgpu/vce_tests.c
index b9e15ee97148ee3b38d4..0026826ea58bd9d9dd8b 100644
--- a/tests/amdgpu/vce_tests.c
+++ b/tests/amdgpu
Signed-off-by: Eric Engestrom
---
xf86drm.c | 86 +++
1 file changed, 23 insertions(+), 63 deletions(-)
diff --git a/xf86drm.c b/xf86drm.c
index 95854e153ec7e9d264bc..f8e4d11b8c6886d6a6b8 100644
--- a/xf86drm.c
+++ b/xf86drm.c
@@ -300,6
Adapted from a local patch carried by DragonFlyBSD:
https://github.com/DragonFlyBSD/DPorts/blob/bc056f88f7e4d468d8c9751f831a47b5ae1326e3/graphics/libdrm/files/patch-xf86drm.h
Patch is sadly uncredited (a bot authored the commit), so I can't credit
the author here either.
Signed-off-by:
Signed-off-by: Eric Engestrom
---
xf86drm.c | 4 ++--
xf86drm.h | 8
2 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/xf86drm.c b/xf86drm.c
index 07425b19897d00a19e8a..95854e153ec7e9d264bc 100644
--- a/xf86drm.c
+++ b/xf86drm.c
@@ -317,7 +317,7 @@ static int drmOpenDevice
On Wednesday, 2018-12-19 17:08:01 +, Eric Engestrom wrote:
> Adapted from a local patch carried by DragonFlyBSD:
> https://github.com/DragonFlyBSD/DPorts/blob/bc056f88f7e4d468d8c9751f831a47b5ae1326e3/graphics/libdrm/files/patch-xf86drm.h
>
> Patch is sadly uncredited (a bot
On Thursday, 2018-12-20 11:53:11 -0800, Dylan Baker wrote:
> Quoting Eric Engestrom (2018-12-19 08:23:40)
> > Signed-off-by: Eric Engestrom
> > ---
> > RELEASING | 27 ---
> > 1 file changed, 8 insertions(+), 19 deletions(-)
> >
>
On Friday, 2019-02-15 15:08:22 +, Emil Velikov via dri-devel wrote:
> On Fri, 15 Feb 2019 at 15:06, Rob Clark via dri-devel
> wrote:
> >
> > On Fri, Feb 15, 2019 at 8:42 AM Eric Engestrom
> > wrote:
> > >
> > > On Friday, 2019-02-15 13:36:39 +000
On Tuesday, 2019-02-19 13:53:25 +0100, Daniel Vetter wrote:
> On Tue, Feb 19, 2019 at 12:57 PM Emil Velikov
> wrote:
> >
> > On Mon, 18 Feb 2019 at 17:42, Eric Engestrom
> > wrote:
> > >
> > > On Thursday, 2018-12-20 11:53:11 -0800, Dylan Baker wrote:
On Tuesday, 2019-02-19 11:56:21 +, Emil Velikov wrote:
> On Tue, 19 Feb 2019 at 10:08, Eric Engestrom wrote:
> >
> > On Friday, 2019-02-15 15:08:22 +, Emil Velikov via dri-devel wrote:
> > > On Fri, 15 Feb 2019 at 15:06, Rob Clark via dri-devel
> > > wrot
CPPFLAGS instead of CFLAGS from configure.ac.
Thanks!
Reviewed-by: Eric Engestrom
Fixes: 0926f0af54d654b1a958 "meson,configure: include config.h automatically"
I'll push it in moment.
>
> Reference: https://bugs.freedesktop.org/show_bug.cgi?id=106561
> Signed-off-by:
On Monday, 2019-03-04 08:28:25 +0200, Tapani Pälli wrote:
> ping!
Reviewed-by: Eric Engestrom
>
> On 2/21/19 8:56 AM, Tapani Pälli wrote:
> > Add new iris driver, remove deprecated ilo driver.
> >
> > Signed-off-by: Tapani Pälli
> > ---
> > libkms/An
On Tuesday, 2019-03-05 21:54:47 +0530, Mamta Shukla wrote:
> Add overlay plane support in vkms aligned with cursor and primary
> plane with module option 'enable_overlay' to enable/disable overlay
> plane while testing.
>
> This currently passes plane-position-covered-pipe-A-plane subtest
> from I
ecks, just add sys/types.h to all header checks.
>
> v2 [Emil]
> - add inline comment
> - drop bash/sh hunk
>
> Signed-off-by: Emil Velikov
Series is:
Reviewed-by: Eric Engestrom
But I agree with Emil, it's a FreeBSD bug for it to not include
a required h
On Monday, 2019-06-17 11:20:43 +0200, Niclas Zeising wrote:
> On 2019-06-17 11:14, Eric Engestrom wrote:
> > On Sunday, 2019-06-16 14:23:43 +0100, Emil Velikov wrote:
> > > From: Niclas Zeising
> > >
> > > FreeBSD requires sys/types.h for sys/sysctl.h, add i
On Tuesday, 2019-06-18 16:02:41 +0200, Daniel Vetter wrote:
> I rushed merging this a bit too much, and Noralf pointed out that
> we're a lot better already and have made great progress.
>
> Let's try again.
>
> Fixes: 42dbbb4b54a3 ("drm/todo: Add new debugfs todo")
> Cc: Greg Kroah-Hartman
> Cc
ore OpenBSD had render nodes).
>
> Signed-off-by: Jonathan Gray
I didn't check that OpenBSD is the way you say, but the libdrm code here
matches with that, so this patch is
Acked-by: Eric Engestrom
and pushed :)
> ---
> xf86drm.c | 24 ++--
> 1 file cha
On Monday, 2019-05-13 02:50:49 +1000, Jonathan Gray wrote:
> Unlike Linux the OpenBSD primary "drm" device name is substring of the
> "drmR" render node device name and strncmp() tests resulted in render
> nodes being flagged as primary nodes.
>
> Signed-off-by
On Monday, 2019-12-16 16:51:28 +, Souza, Jose wrote:
> Hello
>
> I have being contributing to i915 for the past 2 years and part of my
> work is update the PCI ids of Intel devices in libdrm.
> Being able to push my reviewed patches would be really helpful, please
> consider this request.
Thi
On Thursday, 2019-10-03 16:53:18 +0300, Ville Syrjälä wrote:
> On Thu, Oct 03, 2019 at 09:51:18AM +0200, Andrzej Pietrasiewicz wrote:
> > To human readers
>
> The commit message is always for human readers, no need to point that
> out...
>
> >
> > "array of struct drm_format modifiers" is almost
On Thursday, 2020-02-06 17:46:36 +, Li, Juston wrote:
> On Wed, 2020-02-05 at 23:27 +0000, Eric Engestrom wrote:
> > On Wednesday, 2020-02-05 23:10:21 +, Li, Juston wrote:
> > > On Wed, 2020-02-05 at 22:25 +0000, Eric Engestrom wrote:
> > > > On Friday, 2020-0
ret = drmIoctl(bufmgr_gem->fd,
> +DRM_IOCTL_I915_GEM_GET_TILING,
> +&get_tiling);
You're missing `get_tiling.handle = gem_handle;`
Or better yet, just initialise `get_tiling` and get rid of the memclear():
struct drm_i915_gem_get_tiling get_tiling = {
.han
ok like this:
# From Niclas Zeising:
# FreeBSD requires sys/types.h for sys/sysctl.h, add it as part of the
# includes when checking for headers.
foreach header : ['sys/sysctl.h']
config.set10('HAVE_' + header.underscorify().to_upper(),
not ['linux'].contains(host
t; +{
> + struct drm_mode_fb_cmd2 get;
> + drmModeFB2Ptr ret;
> + int err;
> +
> + memclear(get);
> + get.fb_id = fb_id;
As mentioned on IRC, could you write it like this instead?
struct drm_mode_fb_cmd2 get = {
.fb_id = fb_id,
On Wednesday, 2020-02-05 23:10:21 +, Li, Juston wrote:
> On Wed, 2020-02-05 at 22:25 +0000, Eric Engestrom wrote:
> > On Friday, 2020-01-31 13:41:09 -0800, Juston Li wrote:
> > > From: Daniel Stone
> > >
> > > Add a wrapper around the getfb2 ioctl, whic
On Friday, 2019-09-13 14:51:39 +0300, Jani Nikula wrote:
> Add helper to check if a drm debug category is enabled. Convert drm core
> to use it. No functional changes.
>
> Signed-off-by: Jani Nikula
> ---
> drivers/gpu/drm/drm_atomic_uapi.c | 2 +-
> drivers/gpu/drm/drm_dp_mst_topology.c | 6
On Friday, 2019-09-13 16:26:55 -0700, Alan Coopersmith wrote:
> On 9/10/19 5:55 AM, Eric Engestrom wrote:
> > On Monday, 2019-09-09 16:51:16 -0700, Alan Coopersmith wrote:
> > > On Solaris, sys/sysmacros.h has long-deprecated copies of major() &
> > > minor()
> &
On Monday, 2019-09-16 11:53:24 +0300, Jani Nikula wrote:
> On Fri, 13 Sep 2019, Eric Engestrom wrote:
> > On Friday, 2019-09-13 14:51:39 +0300, Jani Nikula wrote:
> >> Add helper to check if a drm debug category is enabled. Convert drm core
> >> to use it. No functional
On Monday, 2019-09-16 12:35:41 +0200, Rohan Garg wrote:
> DRM_IOCTL_BO_SET_LABEL lets you label GEM objects, making it
> easier to debug issues in userspace applications.
>
> Signed-off-by: Rohan Garg
> ---
> drivers/gpu/drm/drm_gem.c | 51 ++
> drivers/gpu/d
t;
> However, now that it is a requirement for newer releases, I'd
> contend that being able to build/test libdrm/master against
> AOSP/master and recent releases is more valuable then soley
> maintaining support for old and unsupported Android releases.
Acked-by: Eric Engestrom
On Monday, 2019-09-16 16:23:13 +0300, Jani Nikula wrote:
> On Mon, 16 Sep 2019, Eric Engestrom wrote:
> > On Monday, 2019-09-16 11:53:24 +0300, Jani Nikula wrote:
> >> On Fri, 13 Sep 2019, Eric Engestrom wrote:
> >> > On Friday, 2019-09-13 14:51:39 +0300, Jani Nikul
On Tuesday, 2019-09-24 23:09:08 -0700, John Stultz wrote:
> On Tue, Sep 24, 2019 at 4:30 PM John Stultz wrote:
> > On Tue, Sep 24, 2019 at 3:24 PM Rob Herring wrote:
> > > Trying to maintain something that works across more than 3 releases or
> > > so is painful. I don't think android-x86 folks h
objections to that, we'll need to postpone the last patch until
> everything has been merged and converted in drm-next.
>
> BR,
> Jani.
>
> Cc: Eric Engestrom
> Cc: Alex Deucher
> Cc: Christian König
> Cc: David (ChunMing) Zhou
> Cc: amd-...@lists.freedesktop.or
On Tuesday, 2019-10-01 14:03:55 +0300, Jani Nikula wrote:
> On Thu, 26 Sep 2019, Eric Engestrom wrote:
> > On Tuesday, 2019-09-24 15:58:56 +0300, Jani Nikula wrote:
> >> Hi all, v2 of [1], a little refactoring around drm_debug access to
> >> abstract it better. There
r conditions (Eric)
>
> Cc: Eric Engestrom
Reviewed-by: Eric Engestrom
> Acked-by: Alex Deucher
> Signed-off-by: Jani Nikula
> ---
> drivers/gpu/drm/drm_atomic_uapi.c | 2 +-
> drivers/gpu/drm/drm_dp_mst_topology.c | 6 +++---
> drivers/gpu/drm/drm_edid.c
On Tuesday, 2019-12-03 06:37:36 -0800, Devarsh Thakkar wrote:
> Add function to derive floating value of vertical
> refresh rate from drm mode using pixel clock,
> horizontal total size and vertical total size.
>
> Use this function to find suitable mode having vrefresh
> value which is matching w
AC_HEADER_MAJOR does.
Reviewed-by: Eric Engestrom
Alternatively, how about this?
---8<---
diff --git a/meson.build b/meson.build
index bc5cfc588d0c621a9725..263f691ab2b9107f5be1 100644
--- a/meson.build
+++ b/meson.build
@@ -183,9 +183,14 @@ foreach header : ['sys/sysctl.h', 'sy
Hello everyone,
For many years now, we have maintained mirrors of numerous FDo projects
on GitHub, under the following organisations:
https://github.com/freedesktop
https://github.com/mesa3d
https://github.com/wayland-project
A bit over a month ago, a new security feature in git started preventin
fe5a66f91c88 ("drm/i915: Read PSR caps/intermediate freqs/etc. only
> once on eDP")
> Signed-off-by: Dan Carpenter
Good catch! What tool did you use to find it, or did you find it by
inspection?
Reviewed-by: Eric Engestrom
(btw, there's a missing `---` here, between the
warning.
>
> Signed-off-by: Laurent Pinchart
> Reviewed-by: Tomi Valkeinen
Reviewed-by: Eric Engestrom
> ---
> drivers/gpu/drm/drm_fourcc.c | 32
> drivers/gpu/drm/drm_framebuffer.c | 2 +-
> include/drm/drm_fourcc.h
It should not be used by new drivers, so inline it in its only caller.
>
> Signed-off-by: Laurent Pinchart
> Reviewed-by: Tomi Valkeinen
Reviewed-by: Eric Engestrom
> ---
> drivers/gpu/drm/drm_fourcc.c | 31 ---
> driver
irst.
>
> Fixes: 0853695c3ba4 ("drm: Add reference counting to drm_atomic_state")
> Cc: Chris Wilson
> Cc: Daniel Vetter
> Signed-off-by: Arnd Bergmann
Reviewed-by: Eric Engestrom
> ---
> drivers/gpu/drm/i915/intel_display.c | 5 +++--
> 1 file changed, 3 inse
e else
> should have lightweight pthread API in their C runtime library.
>
> Fixes: 4ecd1ef010b ("xf86drm: fix null termination of string buffer")
> Signed-off-by: Emil Velikov
Reviewed-by: Eric Engestrom
> ---
> configure.ac | 20
>
On Monday, 2017-03-27 10:45:44 +0200, Daniel Vetter wrote:
> I wanted to get Sean Paul to run the drm-misc show for a bit, for
> training reasons and to increase the bus factor. And then realized
> there's no docs about what maintainers are doing.
>
> Fix that.
>
> v2: Add backmerges and taking t
This fixes `make check` when dim is not configured.
Signed-off-by: Eric Engestrom
---
dim | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dim b/dim
index 588e859..b373901 100755
--- a/dim
+++ b/dim
@@ -197,7 +197,7 @@ export __dim_running=1
if [ "$subcommand"
Signed-off-by: Eric Engestrom
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index b4cea98..4291049 100644
--- a/Makefile
+++ b/Makefile
@@ -33,7 +33,7 @@ shellcheck:
shellcheck $(SC_EXCLUDE) dim bash_completion
mancheck
Suggest using git-config instead of a flag on format-patch.
While at it, use the more common "PATCH foo" subject prefix.
Signed-off-by: Eric Engestrom
---
dim.rst | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/dim.rst b/dim.rst
index b99248e..c650317 10
ave it.
Can I interest you in fixing a few more headers? :)
In any case, this patch is:
Reviewed-by: Eric Engestrom
(I assume you'll push it yourself?)
Btw, can you run this in your local libdrm repo?
$ git config --local format.subjectPrefix "PATCH libdrm"
Cheers,
Eric
>
On Wednesday, 2017-04-05 14:34:56 +0200, Philipp Zabel wrote:
> Add etna_cmd_stream_flush_explicit with in-fence fd and out-fence fd
> support for explicit fencing.
>
> Signed-off-by: Philipp Zabel
Series is:
Reviewed-by: Eric Engestrom
Do you have push access?
>
ne reports this breaks their platform?
Without knowing any more, it's almost as likely that this hypothetical
platform would match `*-gnu*` as well anyway.
Either way:
Reviewed-by: Eric Engestrom
> ---
> configure.ac | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
Signed-off-by: Eric Engestrom
---
intel/intel_bufmgr_gem.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/intel/intel_bufmgr_gem.c b/intel/intel_bufmgr_gem.c
index e260f2dc..45a26da1 100644
--- a/intel/intel_bufmgr_gem.c
+++ b/intel/intel_bufmgr_gem.c
@@ -655,15 +655,14
On Wednesday, 2017-04-26 07:53:10 +0200, Gerd Hoffmann wrote:
> On Di, 2017-04-25 at 12:18 +0900, Michel Dänzer wrote:
> > On 24/04/17 03:25 PM, Gerd Hoffmann wrote:
> > > Return correct fourcc codes on bigendian. Drivers must be adapted to
> > > this change.
> > >
> > > Signed-off-by: Gerd Hoffm
Signed-off-by: Eric Engestrom
---
Sending these patches here because I don't have commit access to the wiki.
---
DRMJanitors.mdwn | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/DRMJanitors.mdwn b/DRMJanitors.mdwn
index a191f154..4c4a978a 100644
--- a/DRMJanitors.mdwn
Underscores (`_`) have a special meaning in Markdown, and they are
unnecessary information here, so un-break the rendering by removing
them.
Signed-off-by: Eric Engestrom
---
DRMJanitors.mdwn | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/DRMJanitors.mdwn b
On Wednesday, 2017-01-25 07:26:45 +0100, Daniel Vetter wrote:
> I just learned that &struct_name.member_name works and looks pretty
> even. It doesn't (yet) link to the member directly though, which would
> be really good for big structures or vfunc tables (where the
> per-member kerneldoc tends to
C from its userspace ID. Only used by
> + * drivers for legacy IOCTLs and interface, nowadays extensions to the KMS
> + * userspace interface should be done using &drm_property.
> + */
> static inline struct drm_crtc *drm_crtc_find(struct drm_device *dev,
> uint32_t id)
> {
")
Reviewed-by: Eric Engestrom
> ---
> intel/intel_decode.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/intel/intel_decode.c b/intel/intel_decode.c
> index 803d202..2721ffd 100644
> --- a/intel/intel_decode.c
> +++ b/intel/intel_decode
Old values are of no interest to the user, so let's reduce the spam
a bit by hiding those.
Signed-off-by: Eric Engestrom
---
autogen.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/autogen.sh b/autogen.sh
index d82ab180..d0030969 100755
--- a/autogen.sh
If the build dir is outside of the git dir, the order matters :)
Signed-off-by: Eric Engestrom
---
autogen.sh | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/autogen.sh b/autogen.sh
index d0030969..13d6991e 100755
--- a/autogen.sh
+++ b/autogen.sh
@@ -6,15 +6,15
On Friday, 2017-02-03 19:07:08 +, Emil Velikov wrote:
> On 3 February 2017 at 18:21, Eric Engestrom wrote:
> > If the build dir is outside of the git dir, the order matters :)
> >
> > Signed-off-by: Eric Engestrom
> > ---
> Wondering if you've got hit
On Tuesday, 2017-02-07 15:59:32 +0100, Thomas H.P. Andersen wrote:
> On Fri, Feb 3, 2017 at 11:57 AM, Eric Engestrom
> wrote:
> >
> > On Thursday, 2017-02-02 23:57:29 +0100, Thomas Hindoe Paaboel Andersen
> > wrote:
> > > Introduced in 028715ee
> > >
f-by: Chris Wilson
Reviewed-by: Eric Engestrom
> ---
> drivers/gpu/drm/i915/intel_display.c | 6 +-
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c
> b/drivers/gpu/drm/i915/intel_display.c
> index 04ca4e7bbbe0..7f7f6de01
On Wednesday, 2017-02-15 15:33:18 -0800, Joe Perches wrote:
> drm_printf does not currently use the compiler to verify
> format and arguments. Make it do so.
>
> Miscellanea:
>
> o Add appropriate #include files for __printf and struct va_format
> o Convert dev_printk to dev_info
I think these
On Wednesday, 2017-02-22 14:17:41 +0530, Archit Taneja wrote:
> A couple of the kms functions didn't have the correct/newest names.
> This prevented them to be identified as refs in the html doc.
>
> Signed-off-by: Archit Taneja
Thanks!
Reviewed-by: Eric Engestrom
Tested-b
On Sunday, 2017-02-26 12:51:03 +0300, Andrey Ponomarenko wrote:
> Hello,
>
> I'd like to present the ABI Navigator project to search for binary symbols
> (functions, global data, etc.) across recent versions of the libdrm and other
> open-source libraries: https://abi-laboratory.pro/index.php?vi
m: make drm_get_format_name thread-safe
> >>
> >> Signed-off-by: Eric Engestrom
> >> [danvet: Clarify that the returned pointer must be freed with
> >> kfree().]
> >> Signed-off-by: Daniel Vetter
> >>
> >> Note: I think we nee
Fixes: 90844f00049e9f42573fd31d7c32e8fd31d3fd07
drm: make drm_get_format_name thread-safe
Signed-off-by: Eric Engestrom
[danvet: Clarify that the returned pointer must be freed with
kfree().]
Signed-off-by: Daniel Vetter
Note (Rob Clark):
I think we need to be a bit
On Friday, 2016-11-04 13:50:25 -0400, Rob Clark wrote:
> On Fri, Nov 4, 2016 at 1:32 PM, Eric Engestrom
> wrote:
> > On Friday, 2016-11-04 13:12:51 -0400, Rob Clark wrote:
> >> On Fri, Nov 4, 2016 at 12:27 PM, Ville Syrjälä
> >> wrote:
> >> > On Fri, N
Fixes: 90844f00049e9f42573fd31d7c32e8fd31d3fd07
drm: make drm_get_format_name thread-safe
Signed-off-by: Eric Engestrom
[danvet: Clarify that the returned pointer must be freed with
kfree().]
Signed-off-by: Daniel Vetter
Suggested-by: Ville Syrjälä
Signed-off-by: Eric
On Saturday, 2016-11-05 13:11:36 +0100, Christian König wrote:
> Am 05.11.2016 um 02:33 schrieb Eric Engestrom:
> > +typedef char drm_format_name_buf[32];
>
> Please don't use a typedef for this, just define the maximum size of
> characters the function might write somewhe
On Sunday, 2016-11-06 08:03:47 -0500, Rob Clark wrote:
> On Sun, Nov 6, 2016 at 4:47 AM, Christian König
> wrote:
> > Am 05.11.2016 um 17:49 schrieb Rob Clark:
> >>
> >> On Sat, Nov 5, 2016 at 12:38 PM, Eric Engestrom
> >> wrote:
> >>>
> &g
Fixes: 90844f00049e9f42573fd31d7c32e8fd31d3fd07
drm: make drm_get_format_name thread-safe
Signed-off-by: Eric Engestrom
[danvet: Clarify that the returned pointer must be freed with
kfree().]
Signed-off-by: Daniel Vetter
Cc: Rob Clark
Cc: Christian König
Suggested-by
On Monday, 2016-11-07 10:10:13 +0200, Jani Nikula wrote:
> On Mon, 07 Nov 2016, Eric Engestrom wrote:
> > Fixes: 90844f00049e9f42573fd31d7c32e8fd31d3fd07
> >
> > drm: make drm_get_format_name thread-safe
> >
> > Signed-off-by: Eric Engestrom
> >
1 - 100 of 422 matches
Mail list logo
