On Friday, 2019-02-08 16:50:44 +0000, Emil Velikov wrote: > On Fri, 8 Feb 2019 at 16:51, Daniel Stone <dan...@fooishbar.org> wrote: > > > > Hi Eric, > > > > On Fri, 8 Feb 2019 at 15:03, Eric Engestrom <eric.engest...@intel.com> > > wrote: > > > Xserver has struct members named `bool`, which means the last commit > > > breaks its build with errors like this: > > > > > > error: two or more data types in declaration specifiers > > > Bool bool; > > > ^ > > > > > > Fix this by making it return a 0/1 integer, with the same semantic as > > > the boolean it was before. > > > > Don't you need to drop the stdbool.h include for this to fix compilation?
Ahem... /me looks for his brown paper bag :] > > > Thanks Eric. With Dan's comment > Reviewed-by: Emil Velikov <emil.veli...@collabora.com> > > I really wonder if we cannot fix these trivial X nuisances? As-is > every project used has to either work around X mistakes :-( > Wrt libdrm that is fine, yet other projects might be less happy. Agreed :/ The issue is that you still won't be able to have bools in libdrm, because a new libdrm might be used with an old xserver... > > Thanks > -Emil _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
