Re: [PATCH v5 2/6] soc: mediatek: add mtk-mmsys support for mt8195 vdosys0

2021-07-30 Thread Enric Balletbo i Serra
Hi Jason, Thank you for your patch. On 29/7/21 19:07, jason-jh.lin wrote: > Add mt8195 vdosys0 clock driver name and routing table to > the driver data of mtk-mmsys. > This patch is the one that is really introducing mt8195 mmsys support. It is a bit confusing sent the binding on another patchs

Re: [PATCH v5 0/6] Add Mediatek Soc DRM (vdosys0) support for mt8195

2021-07-30 Thread Enric Balletbo i Serra
Hi Jason, Thank you for your patch. On 29/7/21 19:07, jason-jh.lin wrote: > The hardware path of vdosys0 with eDP panel output need to go through > by several modules, such as, OVL, RDMA, COLOR, CCORR, AAL, GAMMA, > DITHER, DSC and MERGE. > You said in other discussions that vdosys0 has eDP pa

[PATCH v3 0/7] Add support to the mmsys driver to be a reset controller

2021-08-25 Thread Enric Balletbo i Serra
robot - Added a new patch to describe the dsi reset optional property. Enric Balletbo i Serra (7): arm64: dts: mediatek: Move reset controller constants into common location dt-bindings: mediatek: Add #reset-cells to mmsys system controller dt-bindings: display: mediatek: add dsi reset opt

[PATCH v3 7/7] drm/mediatek: mtk_dsi: Reset the dsi0 hardware

2021-08-25 Thread Enric Balletbo i Serra
with all boards. Cc: Jitao Shi Suggested-by: Chun-Kuang Hu Signed-off-by: Enric Balletbo i Serra Acked-by: Chun-Kuang Hu Reviewed-by: Matthias Brugger --- Changes in v3: - Fix typo in the commit description drivers/gpu/drm/mediatek/mtk_dsi.c | 5 - 1 file changed, 4 insertions(+), 1

[PATCH v3 3/7] dt-bindings: display: mediatek: add dsi reset optional property

2021-08-25 Thread Enric Balletbo i Serra
Update device tree binding documentation for the dsi to add the optional property to reset the dsi controller. Signed-off-by: Enric Balletbo i Serra Acked-by: Rob Herring --- (no changes since v2) Changes in v2: - Added a new patch to describe the dsi reset optional property. .../devicetree

Re: [PATCH 1/2] drm/mediatek: Switch the hdmi bridge ops to the atomic versions

2021-03-25 Thread Enric Balletbo i Serra
Hi Dafna, Thank you for your patch. It'd be nice if you can cc the linux-mediatek ML for next version, so Mediatek people is more aware of this change. IMHO cc'ing the lkml is also a good practice. On 24/3/21 20:12, Dafna Hirschfeld wrote: > The bridge operation '.enable' and the audio cb '.get_e

Re: [PATCH] drm/mediatek: Add missing MODULE_DEVICE_TABLE()

2021-03-30 Thread Enric Balletbo i Serra
Hi, On 3/2/21 12:07, Enric Balletbo i Serra wrote: > From: Boris Brezillon > > This patch adds the missing MODULE_DEVICE_TABLE definitions on different > Mediatek drivers which generates correct modalias for automatic loading > when these drivers are compiled as an external modu

Re: [PATCH v5 1/2] dt-bindings: usb: add analogix,anx7688.yaml

2021-03-30 Thread Enric Balletbo i Serra
logix,anx7688.yaml >>>>> b/Documentation/devicetree/bindings/usb/analogix,anx7688.yaml >>>>> new file mode 100644 >>>>> index ..6c4dd6b4b28b >>>>> --- /dev/null >>>>> +++ b/Documentation/devicetree/bindings

Re: [PATCH v5 2/2] drm/bridge: anx7688: Add ANX7688 bridge driver support

2021-03-30 Thread Enric Balletbo i Serra
Hi Dafna, Thank you for your patch and to work on this. On 5/3/21 13:43, Dafna Hirschfeld wrote: > From: Enric Balletbo i Serra > > This driver adds support for the ANX7688 HDMI to DP converter block of the > ANX7688 device. > > For our use case, the only reason the Linu

Re: [PATCH v5 1/2] dt-bindings: usb: add analogix,anx7688.yaml

2021-04-06 Thread Enric Balletbo i Serra
Hi Laurent and Dafna, On 31/3/21 22:40, Laurent Pinchart wrote: > On Tue, Mar 30, 2021 at 05:14:44PM +0200, Enric Balletbo i Serra wrote: >> On 30/3/21 15:35, Dafna Hirschfeld wrote: >>> On 05.03.21 16:19, Laurent Pinchart wrote: >>>> On Fri, Mar 05, 2021 at 04:1

[PATCH] phy: mediatek: Add missing MODULE_DEVICE_TABLE()

2021-02-04 Thread Enric Balletbo i Serra
From: Boris Brezillon This patch adds the missing MODULE_DEVICE_TABLE definitions on different Mediatek phy drivers which generates correct modalias for automatic loading when these drivers are compiled as an external module. Signed-off-by: Boris Brezillon Signed-off-by: Enric Balletbo i Serra

[PATCH] drm/mediatek: Add missing MODULE_DEVICE_TABLE()

2021-02-04 Thread Enric Balletbo i Serra
From: Boris Brezillon This patch adds the missing MODULE_DEVICE_TABLE definitions on different Mediatek drivers which generates correct modalias for automatic loading when these drivers are compiled as an external module. Signed-off-by: Boris Brezillon Signed-off-by: Enric Balletbo i Serra

[PATCH] drm/mediatek: Use correct aliases name for ovl

2020-11-29 Thread Enric Balletbo i Serra
dd component OVL_2L1") Fixes: b17bdd0d7a73 ("drm/mediatek: add component OVL_2L0") Signed-off-by: Enric Balletbo i Serra --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b

[PATCH 0/6] Add support to the mmsys driver to be a reset controller

2021-06-30 Thread Enric Balletbo i Serra
Best regards, Enric [1] https://lore.kernel.org/linux-arm-kernel/20210420132614.150242-4-jitao@mediatek.com/ Enric Balletbo i Serra (6): arm64: dts: mediatek: Move reset controller constants into common location dt-bindings: mediatek: Add #reset-cells to mmsys system controller

[PATCH 6/6] drm/mediatek: mtk_dsi: Reset the dsi0 hardware

2021-06-30 Thread Enric Balletbo i Serra
with all boards. Cc: Jitao Shi Suggested-by: Chun-Kuang Hu Signed-off-by: Enric Balletbo i Serra --- drivers/gpu/drm/mediatek/mtk_dsi.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c index

[PATCH v2 0/7] Add support to the mmsys driver to be a reset controller

2021-07-14 Thread Enric Balletbo i Serra
Best regards, Enric [1] https://lore.kernel.org/linux-arm-kernel/20210420132614.150242-4-jitao@mediatek.com/ Changes in v2: - Fix build test ERROR Reported-by: kernel test robot - Added a new patch to describe the dsi reset optional property. Enric Balletbo i Serra (7): arm64

[PATCH v2 3/7] dt-bindings: display: mediatek: add dsi reset optional property

2021-07-14 Thread Enric Balletbo i Serra
Update device tree binding documentation for the dsi to add the optional property to reset the dsi controller. Signed-off-by: Enric Balletbo i Serra --- Changes in v2: - Added a new patch to describe the dsi reset optional property. .../devicetree/bindings/display/mediatek/mediatek,dsi.txt

[PATCH v2 7/7] drm/mediatek: mtk_dsi: Reset the dsi0 hardware

2021-07-14 Thread Enric Balletbo i Serra
with all boards. Cc: Jitao Shi Suggested-by: Chun-Kuang Hu Signed-off-by: Enric Balletbo i Serra --- (no changes since v1) drivers/gpu/drm/mediatek/mtk_dsi.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek

Re: [PATCH 0/4] soc: mediatek: Prepare MMSYS for DDP routing using tables

2020-11-04 Thread Enric Balletbo i Serra
Hi Matthias, On 6/10/20 21:33, Enric Balletbo i Serra wrote: > Dear all, > > The following series are intended to prepare the mtk-mmsys driver to > allow different DDP (Data Display Path) routing tables per SoC. Note > that the series has been tested only on MT8173 platform and co

Re: [PATCH] drm/mediatek: mtk_dpi: Fix unused variable 'mtk_dpi_encoder_funcs'

2020-11-04 Thread Enric Balletbo i Serra
Hi On 5/10/20 18:22, Enric Balletbo i Serra wrote: > Commit f89c696e7f63 ("drm/mediatek: mtk_dpi: Convert to bridge driver") > introduced the following build warning with W=1 > > drivers/gpu/drm/mediatek/mtk_dpi.c:530:39: warning: unused variable > 'mtk_dpi_

Re: [PATCH v10 01/17] dt-bindings: arm: mediatek: mmsys: add power and gce properties

2021-09-08 Thread Enric Balletbo i Serra
Hi Jason, Thank you for your patch. One small comment below. On 8/9/21 8:02, jason-jh.lin wrote: > Power: > 1. Add description for power-domains property. > > GCE: > 1. Add description for mboxes property. > 2. Add description for mediatek,gce-client-reg property. > > Signed-off-by: jason-jh.li

[PATCH v4 0/7] Add support to the mmsys driver to be a reset controller

2021-09-30 Thread Enric Balletbo i Serra
es in v2: - Fix build test ERROR Reported-by: kernel test robot - Added a new patch to describe the dsi reset optional property. Enric Balletbo i Serra (7): arm64: dts: mediatek: Move reset controller constants into common location dt-bindings: mediatek: Add #reset-cells to mmsys s

[PATCH v4 3/7] dt-bindings: display: mediatek: add dsi reset optional property

2021-09-30 Thread Enric Balletbo i Serra
Update device tree binding documentation for the dsi to add the optional property to reset the dsi controller. Signed-off-by: Enric Balletbo i Serra Acked-by: Rob Herring --- (no changes since v2) Changes in v2: - Added a new patch to describe the dsi reset optional property. .../devicetree

[PATCH v4 7/7] drm/mediatek: mtk_dsi: Reset the dsi0 hardware

2021-09-30 Thread Enric Balletbo i Serra
with all boards. Cc: Jitao Shi Suggested-by: Chun-Kuang Hu Signed-off-by: Enric Balletbo i Serra Acked-by: Chun-Kuang Hu Reviewed-by: Matthias Brugger --- (no changes since v3) Changes in v3: - Fix typo in the commit description drivers/gpu/drm/mediatek/mtk_dsi.c | 5 - 1 file changed

Re: [PATCH] drm/bridge: analogix_dp: Convert to GPIO descriptors

2019-06-10 Thread Enric Balletbo i Serra
Hi, On 10/6/19 1:13, Linus Walleij wrote: > This converts the Analogix display port to use GPIO descriptors > instead of DT-extracted numbers. > > Cc: Douglas Anderson > Cc: Sean Paul > Cc: Marek Szyprowski > Cc: Enric Balletbo i Serra > Signed-off-by: Linus Wall

Re: [PATCH] drm/bridge: analogix-anx78xx: Drop of_gpio.h include

2019-06-10 Thread Enric Balletbo i Serra
Hi, On 10/6/19 0:32, Linus Walleij wrote: > This include is only used for some gpio drivers and consumers > that look up GPIO numbers directly from the device tree. > This driver does not use it and only needs . > Delete the unused include. > > Cc: Enric Balletbo i Serra

Re: [PATCH] backlight: pwm_bl: Fix heuristic to determine number of brightness levels

2019-06-13 Thread Enric Balletbo i Serra
0 111 > 5000 416 > 1769 > 5 > 10 4096 > > Fixes: 88ba95bedb79 ("backlight: pwm_bl: Compute brightness of LED linearly > to human eye") > Signed-off-by: Matthias Kaehlcke Tested on Samsung

Re: [PATCH 3/4] backlight: pwm_bl: Set scale type for CIE 1931 curves

2019-06-19 Thread Enric Balletbo i Serra
off-by: Matthias Kaehlcke Tested on Samsung Chromebook Plus which uses the CIE 1931 algorithm. Tested-by: Enric Balletbo i Serra > --- > drivers/video/backlight/pwm_bl.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/video/backlight/pwm_bl

Re: [PATCH RESEND 2/4] drm: bridge: anx7688: Add anx7688 bridge driver support.

2019-12-13 Thread Enric Balletbo i Serra
his patch before sending and looks good to me now. Also I just tested with current mainline on my ELM device and I am happy to have display now, so thanks for sending this upstream: Tested-by: Enric Balletbo i Serra > drivers/gpu/drm/bridge/Kconfig| 9 + > drivers/gpu/drm/bri

Re: [PATCH RESEND 4/4] drm: bridge: Generic GPIO mux driver

2019-12-13 Thread Enric Balletbo i Serra
drm maintainers comment on this but if that's the way to go you can add my: Tested-by: Enric Balletbo i Serra Only one issue that needs to be solved in next version, see below. > --- > drivers/gpu/drm/bridge/Kconfig| 10 + > drivers/gpu/drm/bridge/Makefile |

[PATCH v21 0/2] drm/bridge: PS8640 MIPI-to-eDP bridge

2019-12-17 Thread Enric Balletbo i Serra
Hi all, This driver seems to continue failing to reach upstream. The latest version send by Ulrich [1] one month ago, seems to fix all the issues that prevented the driver to get merged, but, recent changes ended with this driver not building in current mainline. This new version is like a RESEND

[PATCH v21 1/2] Documentation: bridge: Add documentation for ps8640 DT properties

2019-12-17 Thread Enric Balletbo i Serra
From: Jitao Shi Add documentation for DT properties supported by ps8640 DSI-eDP converter. Signed-off-by: Jitao Shi Acked-by: Rob Herring Reviewed-by: Philipp Zabel Signed-off-by: Ulrich Hecht Signed-off-by: Enric Balletbo i Serra --- Changes in v21: None Changes in v19: None Changes in

[PATCH v21 2/2] drm/bridge: Add I2C based driver for ps8640 bridge

2019-12-17 Thread Enric Balletbo i Serra
From: Jitao Shi This patch adds drm_bridge driver for parade DSI to eDP bridge chip. Signed-off-by: Jitao Shi Reviewed-by: Daniel Kurtz Reviewed-by: Enric Balletbo i Serra [uli: followed API changes, removed FW update feature] Signed-off-by: Ulrich Hecht Signed-off-by: Enric Balletbo i

[PATCH] drm/bridge: panel: Fix typo in drm_panel_bridge_add docs

2019-12-18 Thread Enric Balletbo i Serra
Fix the 'manged' typo with 'managed' in the drm_panel_bridge_add kernel-doc documentation. Signed-off-by: Enric Balletbo i Serra --- drivers/gpu/drm/bridge/panel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/panel.c b/dr

Re: [PATCH v21 2/2] drm/bridge: Add I2C based driver for ps8640 bridge

2019-12-18 Thread Enric Balletbo i Serra
Hi Laurent, Many thanks for the quick response and the review. Just preparing a new version to send. On 16/12/19 17:32, Laurent Pinchart wrote: > Hello Enric and Jitao, > > Thank you for the patch. > > On Mon, Dec 16, 2019 at 02:58:34PM +0100, Enric Balletbo i Serra wrote: >

Re: [PATCH v21 2/2] drm/bridge: Add I2C based driver for ps8640 bridge

2019-12-19 Thread Enric Balletbo i Serra
Hi Ezequiel, Many thanks for the review, I am just preparing the next version to send. On 16/12/19 18:07, Ezequiel Garcia wrote: > On Mon, 2019-12-16 at 14:58 +0100, Enric Balletbo i Serra wrote: >> From: Jitao Shi >> >> This patch adds drm_bridge driver for parade D

Re: [PATCH v21 1/2] Documentation: bridge: Add documentation for ps8640 DT properties

2019-12-19 Thread Enric Balletbo i Serra
Hi Maxime, Thanks for your comment, just preparing another version. On 17/12/19 15:28, Maxime Ripard wrote: > On Mon, Dec 16, 2019 at 02:58:33PM +0100, Enric Balletbo i Serra wrote: >> From: Jitao Shi >> >> Add documentation for DT properties supported by >&g

Re: [PATCH v22 2/2] drm/bridge: Add I2C based driver for ps8640 bridge

2019-12-23 Thread Enric Balletbo i Serra
Hi Nicolas, Many thanks for you review. Just preparing a new version with your comments addressed. On 20/12/19 9:44, Nicolas Boichat wrote: > On Fri, Dec 20, 2019 at 4:17 PM Enric Balletbo i Serra > wrote: >> >> From: Jitao Shi >> >> This patch adds drm_bridg

[PATCH v22 2/2] drm/bridge: Add I2C based driver for ps8640 bridge

2019-12-23 Thread Enric Balletbo i Serra
From: Jitao Shi This patch adds drm_bridge driver for parade DSI to eDP bridge chip. Signed-off-by: Jitao Shi Reviewed-by: Daniel Kurtz Reviewed-by: Enric Balletbo i Serra [uli: followed API changes, removed FW update feature] Signed-off-by: Ulrich Hecht Signed-off-by: Enric Balletbo i

[PATCH v22 1/2] Documentation: bridge: Add documentation for ps8640 DT properties

2019-12-23 Thread Enric Balletbo i Serra
From: Jitao Shi Add documentation for DT properties supported by ps8640 DSI-eDP converter. Signed-off-by: Jitao Shi Acked-by: Rob Herring Reviewed-by: Philipp Zabel Signed-off-by: Ulrich Hecht Signed-off-by: Enric Balletbo i Serra --- I maintained the ack from Rob Herring and the review

[PATCH v22 0/2] drm/bridge: PS8640 MIPI-to-eDP bridge

2019-12-23 Thread Enric Balletbo i Serra
Hi all, This is another version of the driver. Note that the driver changed significally and is a more simply because now is using the panel_bridge helpers. Apart from this, I addressed the comments from Maxime, Laurent and Ezequiel. This bridge is required to have the embedded display working on

[PATCH v22 0/2] drm/bridge: PS8640 MIPI-to-eDP bridge

2019-12-24 Thread Enric Balletbo i Serra
Hi all, This is another version of the driver. Note that the driver changed significally and is a more simply because now is using the panel_bridge helpers. Apart from this, I addressed the comments from Maxime, Laurent and Ezequiel. This bridge is required to have the embedded display working on

[PATCH v22 1/2] Documentation: bridge: Add documentation for ps8640 DT properties

2019-12-24 Thread Enric Balletbo i Serra
From: Jitao Shi Add documentation for DT properties supported by ps8640 DSI-eDP converter. Signed-off-by: Jitao Shi Acked-by: Rob Herring Reviewed-by: Philipp Zabel Signed-off-by: Ulrich Hecht Signed-off-by: Enric Balletbo i Serra --- I maintained the ack from Rob Herring and the review

Re: [PATCH v22 2/2] drm/bridge: Add I2C based driver for ps8640 bridge

2019-12-24 Thread Enric Balletbo i Serra
Hi Nicolas, On 23/12/19 10:14, Nicolas Boichat wrote: > On Mon, Dec 23, 2019 at 3:10 PM Enric Balletbo i Serra > wrote: >> >> Hi Nicolas, >> >> Many thanks for you review. Just preparing a new version with your comments >> addressed. >> >> On 20/12

Re: [PATCH v22 2/2] drm/bridge: Add I2C based driver for ps8640 bridge

2019-12-24 Thread Enric Balletbo i Serra
Hi Laurent, On 23/12/19 15:35, Enric Balletbo i Serra wrote: > From: Jitao Shi > > This patch adds drm_bridge driver for parade DSI to eDP bridge chip. > > Signed-off-by: Jitao Shi > Reviewed-by: Daniel Kurtz > [uli: followed API changes, removed FW update feature] &g

[PATCH v22 2/2] drm/bridge: Add I2C based driver for ps8640 bridge

2019-12-24 Thread Enric Balletbo i Serra
From: Jitao Shi This patch adds drm_bridge driver for parade DSI to eDP bridge chip. Signed-off-by: Jitao Shi Reviewed-by: Daniel Kurtz [uli: followed API changes, removed FW update feature] Signed-off-by: Ulrich Hecht Signed-off-by: Enric Balletbo i Serra Tested-by: Hsin-Yi Wang --- One

Re: [PATCH v22 2/2] drm/bridge: Add I2C based driver for ps8640 bridge

2019-12-27 Thread Enric Balletbo i Serra
Hi Ezequiel, On 26/12/19 17:38, Ezequiel Garcia wrote: > Hi Enric, > > Note that this series is marked as v22, but it's really the 23th. > Some minor comments below, it's looking really now. > > Reviewed-by: Ezequiel Garcia > > On Mon, 2019-12-23 at 15:35 +

Re: [PATCH v22 1/2] Documentation: bridge: Add documentation for ps8640 DT properties

2019-12-27 Thread Enric Balletbo i Serra
Hi Ezequiel, On 26/12/19 15:27, Ezequiel Garcia wrote: > Hi Enric, Rob, > > On Mon, 2019-12-23 at 15:35 +0100, Enric Balletbo i Serra wrote: >> From: Jitao Shi >> >> Add documentation for DT properties supported by >> ps8640 DSI-eDP converter. >> >&g

[PATCH v24 1/2] Documentation: bridge: Add documentation for ps8640 DT properties

2019-12-31 Thread Enric Balletbo i Serra
From: Jitao Shi Add documentation for DT properties supported by ps8640 DSI-eDP converter. Signed-off-by: Jitao Shi Acked-by: Rob Herring Reviewed-by: Philipp Zabel Signed-off-by: Ulrich Hecht Signed-off-by: Enric Balletbo i Serra --- I maintained the ack from Rob Herring and the review

[PATCH v24 0/2] drm/bridge: PS8640 MIPI-to-eDP bridge

2019-12-31 Thread Enric Balletbo i Serra
Hi all, This is another version of the driver. Note that the driver changed significally and is a more simply because now is using the panel_bridge helpers. Apart from this, I addressed the comments from Maxime, Laurent and Ezequiel. This bridge is required to have the embedded display working on

[PATCH v24 2/2] drm/bridge: Add I2C based driver for ps8640 bridge

2019-12-31 Thread Enric Balletbo i Serra
From: Jitao Shi This patch adds drm_bridge driver for parade DSI to eDP bridge chip. Signed-off-by: Jitao Shi Reviewed-by: Daniel Kurtz [uli: followed API changes, removed FW update feature] Signed-off-by: Ulrich Hecht Signed-off-by: Enric Balletbo i Serra Tested-by: Hsin-Yi Wang Reviewed

[PATCH] drm/mediatek: Update the fb property mtk_plane_atomic_async_update

2020-02-14 Thread Enric Balletbo i Serra
ursors by using async atomic update") Signed-off-by: Enric Balletbo i Serra --- drivers/gpu/drm/mediatek/mtk_drm_plane.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_plane.c b/drivers/gpu/drm/mediatek/mtk_drm_plane.c index 914cc7619cd7..7eb10115e72a 1006

[PATCH v2 1/2] Documentation: bindings: Add ANX7688 HDMI to DP bridge binding

2020-02-14 Thread Enric Balletbo i Serra
From: Nicolas Boichat Add documentation for DT properties supported by anx7688 HDMI-DP converter. Signed-off-by: Nicolas Boichat Signed-off-by: Hsin-Yi Wang Signed-off-by: Enric Balletbo i Serra --- Changes in v2: - Improve a bit the descriptions using the info from the datasheet. - Convert

Re: [PATCH] drm/mediatek: Update the fb property mtk_plane_atomic_async_update

2020-02-14 Thread Enric Balletbo i Serra
Hi, On 13/2/20 13:01, Enric Balletbo i Serra wrote: > Commit 920fffcc8912 ("drm/mediatek: update cursors by using async atomic > update") added support to async updates of cursors by using the new atomic > interface for that. Unfortunately, introduced two issues. The first

[PATCH v2 2/2] drm/bridge: anx7688: Add anx7688 bridge driver support

2020-02-14 Thread Enric Balletbo i Serra
count are reported by the bridge via 2 registers on I2C. Signed-off-by: Nicolas Boichat Signed-off-by: Hsin-Yi Wang Signed-off-by: Enric Balletbo i Serra --- Changes in v2: - Move driver to drivers/gpu/drm/bridge/analogix. - Make the driver OF only so we can reduce the ifdefs. - Update the

Re: [PATCH v7 01/13] dt-bindings: arm: move mmsys description to display

2020-02-17 Thread Enric Balletbo i Serra
Hi CK, On 14/2/20 11:01, Matthias Brugger wrote: > > > On 14/02/2020 07:42, CK Hu wrote: >> Hi, Matthias: >> >> On Thu, 2020-02-13 at 21:19 +0100, matthias@kernel.org wrote: >>> From: Matthias Brugger >>> >>> The mmsys block provides registers and clocks for the display >>> subsystem. The b

[PATCH v8 3/6] media: mtk-mdp: Check return value of of_clk_get

2020-02-21 Thread Enric Balletbo i Serra
From: Matthias Brugger Check the return value of of_clk_get and print an error message if not EPROBE_DEFER. Signed-off-by: Matthias Brugger Signed-off-by: Enric Balletbo i Serra --- Changes in v8: None Changes in v7: - Fix check of return value of of_clk_get - Fix identation drivers/media

[PATCH v8 2/6] drm/mediatek: Omit warning on probe defers

2020-02-21 Thread Enric Balletbo i Serra
ed-by: CK Hu Signed-off-by: Enric Balletbo i Serra --- Changes in v8: None Changes in v7: - Add Rv-by from CK drivers/gpu/drm/mediatek/mtk_disp_color.c | 5 - drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 5 - drivers/gpu/drm/mediatek/mtk_disp_rdma.c | 5 - drivers/gpu/drm/med

Re: [PATCH v8 0/6] arm/arm64: mediatek: Fix mmsys device probing

2020-02-21 Thread Enric Balletbo i Serra
Hi CK, Thanks for your quick answer. On 21/2/20 5:39, CK Hu wrote: > Hi, Enric: > > On Thu, 2020-02-20 at 18:21 +0100, Enric Balletbo i Serra wrote: >> Dear all, >> >> Those patches are intended to solve an old standing issue on some >> Mediatek devices (mt8173,

Re: [PATCH v8 1/6] drm/mediatek: Use regmap for register access

2020-02-21 Thread Enric Balletbo i Serra
Hi Randy, On 21/2/20 0:48, Randy Dunlap wrote: > On 2/20/20 9:21 AM, Enric Balletbo i Serra wrote: >> From: Matthias Brugger >> >> The mmsys memory space is shared between the drm and the >> clk driver. Use regmap to access it. >> >> Signed-off-by: Matthias

[PATCH v8 6/6] clk/drm: mediatek: Fix mediatek-drm device probing

2020-02-21 Thread Enric Balletbo i Serra
t a system controller, and the drm driver is instantiated by that MMSYS driver. Signed-off-by: Enric Balletbo i Serra --- Changes in v8: - New patch introduced in this series. Changes in v7: None drivers/clk/mediatek/clk-mt2701-mm.c | 30 drivers/clk/mediatek/clk-mt2712-mm

[PATCH v8 0/6] arm/arm64: mediatek: Fix mmsys device probing

2020-02-21 Thread Enric Balletbo i Serra
: - Add R-by from CK - Add R-by from CK - Fix check of return value of of_clk_get - Fix identation - Free clk_data->clks as well - Get rid of private data structure Enric Balletbo i Serra (2): drm/mediatek: Move MMSYS configuration to include/linux/platform_data clk/drm: mediatek: Fix mediatek-

Re: [PATCH v8 6/6] clk/drm: mediatek: Fix mediatek-drm device probing

2020-02-21 Thread Enric Balletbo i Serra
Hi CK, Thanks for your quick feedback. On 21/2/20 6:18, CK Hu wrote: > Hi, Enric: > > On Thu, 2020-02-20 at 18:21 +0100, Enric Balletbo i Serra wrote: >> In the actual implementation the same compatible string >> "mediatek,-mmsys" is used to bind the clock drive

[PATCH v8 5/6] drm/mediatek: Move MMSYS configuration to include/linux/platform_data

2020-02-21 Thread Enric Balletbo i Serra
The MMSYS platform data and DDP enums will be needed to compile other drivers, so move it to a global location. Signed-off-by: Enric Balletbo i Serra --- Changes in v8: - New patch introduced in this series. Changes in v7: None drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h | 56

[PATCH v8 1/6] drm/mediatek: Use regmap for register access

2020-02-21 Thread Enric Balletbo i Serra
From: Matthias Brugger The mmsys memory space is shared between the drm and the clk driver. Use regmap to access it. Signed-off-by: Matthias Brugger Reviewed-by: Philipp Zabel Reviewed-by: CK Hu Signed-off-by: Enric Balletbo i Serra --- Changes in v8: None Changes in v7: - Add R-by from CK

[PATCH v8 4/6] clk: mediatek: mt8173: Switch MMSYS to platform driver

2020-02-21 Thread Enric Balletbo i Serra
other Mediatek MMSYS drivers. Signed-off-by: Matthias Brugger Signed-off-by: Enric Balletbo i Serra --- Changes in v8: - Be a builtin_platform_driver like other mediatek mmsys drivers. Changes in v7: - Free clk_data->clks as well - Get rid of private data structure drivers/clk/mediatek/Kcon

Re: [PATCH v8 0/6] arm/arm64: mediatek: Fix mmsys device probing

2020-02-21 Thread Enric Balletbo i Serra
Hi CK and Matthias, On 21/2/20 12:11, CK Hu wrote: > Hi, Matthias: > > On Fri, 2020-02-21 at 11:24 +0100, Matthias Brugger wrote: >> >> On 21/02/2020 10:27, CK Hu wrote: >>> Hi, Enric: >>> >>> On Fri, 2020-02-21 at 09:56 +0100, Enric Balletbo i Se

Re: [PATCH v8 0/6] arm/arm64: mediatek: Fix mmsys device probing

2020-02-24 Thread Enric Balletbo i Serra
Hi, On 21/2/20 12:53, Matthias Brugger wrote: > > > On 21/02/2020 12:37, Enric Balletbo i Serra wrote: >> Hi CK and Matthias, >> >> On 21/2/20 12:11, CK Hu wrote: >>> Hi, Matthias: >>> >>> On Fri, 2020-02-21 at 11:24 +0100, Matthias Bru

Re: [PATCH v8 0/6] arm/arm64: mediatek: Fix mmsys device probing

2020-02-26 Thread Enric Balletbo i Serra
On 24/2/20 6:52, CK Hu wrote: > > Hi, > > On Fri, 2020-02-21 at 18:10 +0100, Enric Balletbo i Serra wrote: >> Hi, >> >> On 21/2/20 12:53, Matthias Brugger wrote: >>> >>> >>> On 21/02/2020 12:37, Enric Balletbo i Serra wrote: >>

Re: [PATCH v8 0/6] arm/arm64: mediatek: Fix mmsys device probing

2020-02-26 Thread Enric Balletbo i Serra
Hi CK, On 26/2/20 6:32, CK Hu wrote: [snip] >> >> How do you see move mmsys to drivers/soc/mediatek and instantiate the clk and >> mediatek-drm driver >> >> mmsys: syscon@1400 { >> compatible = "mediatek,mt8173-mmsys", "syscon", "simple-mfd"; >> reg = <0 0x1400 0 0x1000>; >>

[PATCH v9 4/4] drm/mediatek: Fix mediatek-drm device probing

2020-02-27 Thread Enric Balletbo i Serra
ller but a system controller, and the drm driver is instantiated by that MMSYS driver. Signed-off-by: Enric Balletbo i Serra --- Changes in v9: - Do not move the display routing from the drm driver (CK) Changes in v8: - New patch introduced in this series. Changes in v7: None drivers/gpu/dr

[PATCH v9 2/4] drm/mediatek: Omit warning on probe defers

2020-02-27 Thread Enric Balletbo i Serra
ed-by: CK Hu Signed-off-by: Enric Balletbo i Serra --- Changes in v9: None Changes in v8: None Changes in v7: - Add Rv-by from CK drivers/gpu/drm/mediatek/mtk_disp_color.c | 5 - drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 5 - drivers/gpu/drm/mediatek/mtk_disp_rdma.c | 5 - dr

[PATCH] drm/mediatek: Remove debug messages for function calls

2020-02-27 Thread Enric Balletbo i Serra
Equivalent information can be nowadays obtained using function tracer. Signed-off-by: Enric Balletbo i Serra --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 5 - drivers/gpu/drm/mediatek/mtk_drm_drv.c | 2 -- 2 files changed, 7 deletions(-) diff --git a/drivers/gpu/drm/mediatek

[PATCH v9 1/4] drm/mediatek: Use regmap for register access

2020-02-27 Thread Enric Balletbo i Serra
From: Matthias Brugger The mmsys memory space is shared between the drm and the clk driver. Use regmap to access it. Signed-off-by: Matthias Brugger Reviewed-by: Philipp Zabel Reviewed-by: CK Hu Signed-off-by: Enric Balletbo i Serra --- Changes in v9: None Changes in v8: - Select REGMAP

[PATCH v9 3/4] soc: mediatek: Move mt8173 MMSYS to platform driver

2020-02-27 Thread Enric Balletbo i Serra
-off-by: Matthias Brugger Signed-off-by: Enric Balletbo i Serra --- Changes in v9: - Move mmsys to drivers/soc/mediatek (CK) Changes in v8: - Be a builtin_platform_driver like other mediatek mmsys drivers. Changes in v7: - Free clk_data->clks as well - Get rid of private data structure driv

[PATCH v9 0/4] arm64: mediatek: Fix mt8173 mmsys device probing

2020-02-27 Thread Enric Balletbo i Serra
. - New patch introduced in this series. Changes in v7: - Add R-by from CK - Free clk_data->clks as well - Get rid of private data structure Enric Balletbo i Serra (1): drm/mediatek: Fix mediatek-drm device probing Matthias Brugger (3): drm/mediatek: Use regmap for register access

Re: [PATCH v9 1/4] drm/mediatek: Use regmap for register access

2020-02-27 Thread Enric Balletbo i Serra
Hi CK, On 27/2/20 2:10, CK Hu wrote: > Hi, Enric: > > On Wed, 2020-02-26 at 11:54 +0100, Enric Balletbo i Serra wrote: >> From: Matthias Brugger >> >> The mmsys memory space is shared between the drm and the >> clk driver. Use regmap to access it. > >

[PATCH v10 4/5] soc / drm: mediatek: Move routing control to mmsys device

2020-02-28 Thread Enric Balletbo i Serra
Provide a mtk_mmsys_ddp_connect() and mtk_mmsys_disconnect() functions to replace mtk_ddp_add_comp_to_path() and mtk_ddp_remove_comp_from_path(). Those functions will allow DRM driver and others to control the data path routing. Signed-off-by: Enric Balletbo i Serra --- Changes in v10

[PATCH v10 0/5] arm/arm64: mediatek: Fix mt8173 mmsys device probing

2020-02-28 Thread Enric Balletbo i Serra
/mediatek (CK) - Do not move the display routing from the drm driver (CK) Changes in v8: - Be a builtin_platform_driver like other mediatek mmsys drivers. - New patch introduced in this series. Changes in v7: - Free clk_data->clks as well - Get rid of private data structure Enric Balletbo i Serra

[PATCH v10 5/5] soc / drm: mediatek: Fix mediatek-drm device probing

2020-02-28 Thread Enric Balletbo i Serra
ller but a system controller, and the drm driver is instantiated by that MMSYS driver. Signed-off-by: Enric Balletbo i Serra --- Changes in v10: - Match driver data to get display routing. Changes in v9: - Do not move the display routing from the drm driver (CK) Changes in v8: - New patch introduc

[PATCH v10 2/5] dt-bindings: mediatek: Update mmsys binding to reflect it is a system controller

2020-02-28 Thread Enric Balletbo i Serra
The mmsys system controller is not only a pure clock controller, so update the binding documentation to reflect that apart from providing clocks, it also provides routing and miscellaneous control registers. Signed-off-by: Enric Balletbo i Serra --- Changes in v10: - Update the binding

[PATCH v10 3/5] soc: mediatek: Move mt8173 MMSYS to platform driver

2020-02-28 Thread Enric Balletbo i Serra
-off-by: Matthias Brugger Signed-off-by: Enric Balletbo i Serra --- Changes in v10: - Renamed to be generic mtk-mmsys - Add driver data support to be able to support diferent SoCs Changes in v9: - Move mmsys to drivers/soc/mediatek (CK) Changes in v8: - Be a builtin_platform_driver like other

[PATCH v10 1/5] drm/mediatek: Omit warning on probe defers

2020-02-28 Thread Enric Balletbo i Serra
ed-by: CK Hu Signed-off-by: Enric Balletbo i Serra --- Changes in v10: None Changes in v9: None Changes in v8: None Changes in v7: None drivers/gpu/drm/mediatek/mtk_disp_color.c | 5 - drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 5 - drivers/gpu/drm/mediatek/mtk_disp_rdma.c

[PATCH v11 0/5] arm/arm64: mediatek: Fix mt8173 mmsys device probing

2020-03-03 Thread Enric Balletbo i Serra
builtin_platform_driver like other mediatek mmsys drivers. - New patch introduced in this series. Changes in v7: - Free clk_data->clks as well - Get rid of private data structure Enric Balletbo i Serra (3): dt-bindings: mediatek: Update mmsys binding to reflect it is a system controller soc /

[PATCH v11 5/5] soc / drm: mediatek: Fix mediatek-drm device probing

2020-03-03 Thread Enric Balletbo i Serra
ller but a system controller, and the drm driver is instantiated by that MMSYS driver. Signed-off-by: Enric Balletbo i Serra Reviewed-by: CK Hu --- Changes in v11: None Changes in v10: - Match driver data to get display routing. Changes in v9: - Do not move the display routing from the drm

[PATCH v11 2/5] dt-bindings: mediatek: Update mmsys binding to reflect it is a system controller

2020-03-03 Thread Enric Balletbo i Serra
The mmsys system controller is not only a pure clock controller, so update the binding documentation to reflect that apart from providing clocks, it also provides routing and miscellaneous control registers. Signed-off-by: Enric Balletbo i Serra Reviewed-by: Matthias Brugger Reviewed-by: CK Hu

[PATCH v11 1/5] drm/mediatek: Omit warning on probe defers

2020-03-03 Thread Enric Balletbo i Serra
ed-by: CK Hu Signed-off-by: Enric Balletbo i Serra --- Changes in v11: None Changes in v10: None Changes in v9: None Changes in v8: None Changes in v7: None drivers/gpu/drm/mediatek/mtk_disp_color.c | 5 - drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 5 - drivers/gpu/drm/med

[PATCH v11 3/5] soc: mediatek: Move mt8173 MMSYS to platform driver

2020-03-03 Thread Enric Balletbo i Serra
-off-by: Matthias Brugger Signed-off-by: Enric Balletbo i Serra Reviewed-by: CK Hu --- Changes in v11: None Changes in v10: - Renamed to be generic mtk-mmsys - Add driver data support to be able to support diferent SoCs Changes in v9: - Move mmsys to drivers/soc/mediatek (CK) Changes in v8: - Be

[PATCH v11 4/5] soc / drm: mediatek: Move routing control to mmsys device

2020-03-03 Thread Enric Balletbo i Serra
Provide a mtk_mmsys_ddp_connect() and mtk_mmsys_disconnect() functions to replace mtk_ddp_add_comp_to_path() and mtk_ddp_remove_comp_from_path(). Those functions will allow DRM driver and others to control the data path routing. Signed-off-by: Enric Balletbo i Serra Reviewed-by: Matthias Brugger

Re: [PATCH v11 4/5] soc / drm: mediatek: Move routing control to mmsys device

2020-03-03 Thread Enric Balletbo i Serra
Hi CK, On 3/3/20 3:52, CK Hu wrote: > Hi, Enric: > > On Mon, 2020-03-02 at 12:01 +0100, Enric Balletbo i Serra wrote: >> Provide a mtk_mmsys_ddp_connect() and mtk_mmsys_disconnect() functions to >> replace mtk_ddp_add_comp_to_path() and mtk_ddp_remove_comp_from_path(). &g

Re: [PATCH v2 2/2] drm/bridge: anx7688: Add anx7688 bridge driver support

2020-03-06 Thread Enric Balletbo i Serra
eb 14, 2020 at 1:53 PM Enric Balletbo Serra >>> wrote: >>>> >>>> Hi Vasily, >>>> >>>> Missatge de Vasily Khoruzhick del dia dv., 14 de >>>> febr. 2020 a les 22:36: >>>>> >>>>> On Thu, Feb 13, 2020 at

Re: [PATCH v2 2/2] drm/bridge: anx7688: Add anx7688 bridge driver support

2020-03-07 Thread Enric Balletbo i Serra
Hi Icenowy, On 5/3/20 19:35, Icenowy Zheng wrote: > > > 于 2020年3月6日 GMT+08:00 上午2:29:33, Vasily Khoruzhick 写到: >> On Thu, Mar 5, 2020 at 7:28 AM Enric Balletbo i Serra >> wrote: >>> >>> Hi Vasily, >> >> CC: Icenowy and Ondrej >>> &

Re: [PATCH v2 2/2] drm/bridge: anx7688: Add anx7688 bridge driver support

2020-03-07 Thread Enric Balletbo i Serra
Hi Ondrej, On 5/3/20 20:35, Ondřej Jirman wrote: > Hi, > > On Thu, Mar 05, 2020 at 10:29:33AM -0800, Vasily Khoruzhick wrote: >> On Thu, Mar 5, 2020 at 7:28 AM Enric Balletbo i Serra >> wrote: >>> >>> Hi Vasily, >> >> CC: Icenowy and Ondrej >

Re: [PATCH v11 3/5] soc: mediatek: Move mt8173 MMSYS to platform driver

2020-03-07 Thread Enric Balletbo i Serra
Hi Stephen, On 5/3/20 22:01, Stephen Boyd wrote: > Quoting Enric Balletbo i Serra (2020-03-02 03:01:26) >> From: Matthias Brugger >> >> There is no strong reason for this to use CLK_OF_DECLARE instead of >> being a platform driver. > > Cool. > >> Plus,

[PATCH v3 3/4] dt-bindings: Add ANX7688 HDMI to DP bridge binding

2020-03-07 Thread Enric Balletbo i Serra
From: Nicolas Boichat Add documentation for DT properties supported by the ANX7688 HDMI-DP converter. Signed-off-by: Nicolas Boichat Signed-off-by: Hsin-Yi Wang Signed-off-by: Enric Balletbo i Serra --- Changes in v3: - Adapt the bridge bindings for the multi-function device. Changes in v2

[PATCH v3 4/4] drm/bridge: anx7688: Add ANX7688 bridge driver support

2020-03-07 Thread Enric Balletbo i Serra
bandwidth and lane count are reported by the bridge via 2 registers and, as far as we know, only for chips that have a firmware version greather than 0.85 supports these two registers. Signed-off-by: Nicolas Boichat Signed-off-by: Hsin-Yi Wang Signed-off-by: Enric Balletbo i Serra --- Changes in

Re: [PATCH v2 2/2] drm/bridge: anx7688: Add anx7688 bridge driver support

2020-03-07 Thread Enric Balletbo i Serra
On 6/3/20 13:03, Ondřej Jirman wrote: > On Fri, Mar 06, 2020 at 09:46:51AM +0100, Enric Balletbo i Serra wrote: >> Hi Ondrej, >> >> On 5/3/20 20:35, Ondřej Jirman wrote: >>> Hi, >>> >>> On Thu, Mar 05, 2020 at 10:29:33AM -0800, Vasily Khoruzhick

Re: [PATCH v11 3/5] soc: mediatek: Move mt8173 MMSYS to platform driver

2020-03-10 Thread Enric Balletbo i Serra
Hi all, On 10/3/20 10:40, Matthias Brugger wrote: > > > On 09/03/2020 23:50, Stephen Boyd wrote: >> Quoting Enric Balletbo Serra (2020-03-06 14:09:50) >>> Missatge de Stephen Boyd del dia dv., 6 de mar >>> 2020 a les 22:37: >>>> >>>

[PATCH v11 3/5] clk / soc: mediatek: Move mt8173 MMSYS to platform driver

2020-03-12 Thread Enric Balletbo i Serra
new MMSYS platform driver in drivers/soc/mediatek that instantiates the clock driver. Signed-off-by: Matthias Brugger Signed-off-by: Enric Balletbo i Serra --- Changes in v11: - Leave the clocks part in drivers/clk (clk-mt8173-mm) - Instantiate the clock driver from the mtk-mmsys driver. - Add

[PATCH v12 4/5] soc / drm: mediatek: Move routing control to mmsys device

2020-03-12 Thread Enric Balletbo i Serra
Provide a mtk_mmsys_ddp_connect() and mtk_mmsys_disconnect() functions to replace mtk_ddp_add_comp_to_path() and mtk_ddp_remove_comp_from_path(). Those functions will allow DRM driver and others to control the data path routing. Signed-off-by: Enric Balletbo i Serra Reviewed-by: Matthias Brugger

  1   2   3   4   5   >