Hi Ville,
Two fixes inline...
On Wed, Jul 27, 2016 at 1:34 AM, wrote:
>
> From: Ville Syrjälä
>
> Add a version of drm_plane_helper_check_update() which takes a plane
> state instead of having the caller pass in everything.
>
> And to reduce code duplication, let's reimplement
> drm_plane_hel
On Thu, Sep 29, 2016 at 11:29 AM, Bibby Hsieh
wrote:
>
> Clean the interrupt status before enable interrupt
> and set the vblank_disable_allowed to fix the issue.
For the series:
Reviewed-by: Daniel Kurtz
>
> Bibby Hsieh (2):
> drm/mediatek: set vblank_disable_allow
On Tue, Oct 25, 2016 at 6:23 AM, Matthias Brugger
wrote:
>
> On 10/18/2016 04:37 PM, Enric Balletbo Serra wrote:
> [...]
>>> --- /dev/null
>>> +++ b/drivers/gpu/drm/bridge/parade-ps8640.c
> [...]
>>>
>>> +
>>> +/* Firmware */
>>> +#define PS_FW_NAME "ps864x_fw.bin"
>>> +
>>
>> From whe
> So need to multiply a coefficient to offset the extra signal's effect.
> coefficient = ((htotal*bpp/lane_number)+Tlpx+Ths_prep+Ths_zero+
> Ths_trail+Ths_exit)/(htotal*bpp/lane_number)
>
> Signed-off-by: Jitao Shi
For this patch,
Reviewed-by: Daniel Kurtz
B
Hi YT,
Sorry for the very late review.
My biggest problem with this patch is it describes itself as adding
support for a new use case "DSI -> panel", but makes many changes to
the existing working flow "DSI -> bridge -> panel".
If these changes are really needed, or improve the existing flow, I'd
Hi CK,
On Thu, Nov 17, 2016 at 1:36 PM, CK Hu wrote:
> Hi, Jitao:
>
>
> On Wed, 2016-11-16 at 11:20 +0800, Jitao Shi wrote:
>> Tune dsi frame rate by pixel clock, dsi add some extra signal (i.e.
>> Tlpx, Ths-prepare, Ths-zero, Ths-trail,Ths-exit) when enter and exit LP
>> mode, those signals will
Hi YT,
I don't see a reason to handle device_data in such a generic way at
the generic mtk_ddp_comp layer.
The device data is very component specific, so just define different
structs for different comp types, ie:
struct mtk_disp_ovl_driver_data {
unsigned int reg_ovl_addr;
unsigned int f
Hi YT,
On Fri, Nov 25, 2016 at 6:34 PM, YT Shen wrote:
>
> There are some hardware settings changed, between MT8173 & MT2701:
> DISP_OVL address offset changed, color format definition changed.
> DISP_RDMA fifo size changed.
> DISP_COLOR offset changed.
> MIPI_TX pll setting changed.
> And add p
On Wed, Sep 7, 2016 at 3:12 AM, Sean Paul wrote:
> The ->set() callback would always be called when transitioning
> from FLUSH->DISABLE since we assign state to psr->state right
> above the skip condition.
>
> Reported-by: Daniel Kurtz
> Signed-off-by: Sean Paul
Hi Sean,
On Sat, Sep 17, 2016 at 2:22 AM, Sean Paul wrote:
>
> Instead of assigning device managed resources to local variables,
> keep track of them in the vop struct.
Why this patch?
Is it fixing an issue?
Or, is it preparing for some future use of ahb_rst outside of vop_initial?
I thought th
On Sat, Sep 17, 2016 at 2:22 AM, Sean Paul wrote:
> If create_crtc fails in vop bind, ensure the irq refcount is zeroed
> back out before exiting.
>
> Signed-off-by: Sean Paul
Reviewed-by: Daniel Kurtz
> ---
> drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 6 +-
&g
On Wed, Sep 21, 2016 at 3:36 PM, Sean Paul wrote:
> On Mon, Sep 19, 2016 at 7:14 AM, Daniel Kurtz wrote:
>> Hi Sean,
>>
>> On Sat, Sep 17, 2016 at 2:22 AM, Sean Paul wrote:
>>>
>>> Instead of assigning device managed resources to local variables,
&
Hi Laurent,
On Mon, Sep 19, 2016 at 8:27 PM, Laurent Pinchart
wrote:
> The vblank interrupt is disabled after one occurrence, preventing the
> atomic update event from being processed twice. However, this also
> prevents the software frame counter from being updated correctly that
> would require
On Fri, Dec 30, 2016 at 2:26 PM, Bibby Hsieh
wrote:
>
> MT8173 overlay can support UYVY and YUYV format,
> we add the format in DRM driver.
>
> Signed-off-by: Bibby Hsieh
> Reviewed-by: Daniel Kurtz
> ---
> drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 21
Hi Kristian,
On Wed, Dec 21, 2016 at 8:12 AM, Kristian H. Kristensen
wrote:
> From: "Kristian H. Kristensen"
>
> This new ioctl exctends DRM_IOCTL_MODE_GETPLANE, by returning
> information about the modifiers that will work with each format.
>
> Signed-off-by: Kristian H. Kristensen
> ---
> dr
On Tue, Jan 24, 2017 at 9:35 AM, Bibby Hsieh wrote:
>
> Hi, Daniel,
>
> Thanks for your comment.
>
> On Tue, 2017-01-03 at 14:27 +0800, Daniel Kurtz wrote:
> > On Fri, Dec 30, 2016 at 2:26 PM, Bibby Hsieh
> > wrote:
> > >
> > > MT8173 overlay ca
Hi Jitao,
Getting very close now...
Comments inline...
On Tue, Feb 23, 2016 at 3:35 PM, Jitao Shi wrote:
> This patch adds drm_bridge driver for parade DSI to eDP bridge chip.
>
> Signed-off-by: Jitao Shi
> ---
> Changes since v10:
> - Tuning PS8640 reset sleep pins squence
>
> The following
Hi Jitao,
On Tue, Jan 12, 2016 at 6:18 PM, Jitao Shi wrote:
> This patch adds drm_bridge driver for parade DSI to eDP bridge chip.
>
> Signed-off-by: Jitao Shi
> ---
> Changes since v6:
> - Add ps8640 firmware update function
> - Change i2c to i2c_transfer from i2c_master_recv/i2c_master_send
NAK. The original code is correct.
On Thu, May 14, 2015 at 2:17 PM, Guo Yejun wrote:
> Signed-off-by: Guo Yejun
> ---
> xf86drm.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/xf86drm.c b/xf86drm.c
> index f7c45f8..5e7306e 100644
> --- a/xf86drm.c
> +++ b/xf86dr
It's not necessary if we are about to skip the rest of the if clause anyway
because name is NULL.
On May 28, 2015 9:14 PM, "Emil Velikov" wrote:
> On 28 May 2015 at 00:57, Joonyoung Shim wrote:
> > This is to remove to open the DRM device unnecessarily as call
> > drmAvailable() when name is NUL
Hi Philipp,
A bunch of review comments inline.
On Wed, Nov 4, 2015 at 7:44 PM, Philipp Zabel wrote:
> From: CK Hu
>
> This patch adds an initial DRM driver for the Mediatek MT8173 DISP
> subsystem. It currently supports two fixed output streams from the
> OVL0/OVL1 sources to the DSI0/DPI0 sink
Hi Tomeu,
On Tue, Oct 27, 2015 at 10:38 PM, Tomeu Vizoso
wrote:
> Adds a function that sets the pointer to dev_pm_domain in struct device
> and that warns if the device has already finished probing. The reason
> why we want to enforce that is because in the general case that can
> cause problems
Hi Jitao,
On Thu, Jun 2, 2016 at 5:57 PM, Jitao Shi wrote:
>
> This patch adds drm_bridge driver for parade DSI to eDP bridge chip.
>
> Signed-off-by: Jitao Shi
> Reviewed-by: Daniel Kurtz
> ---
> Changes since v15:
> - Drop drm_connector_(un)register calls from para
tly supports two fixed output streams from the
> OVL0/OVL1 sources to the DSI0/DPI0 sinks, respectively.
>
> Signed-off-by: CK Hu
> Signed-off-by: YT Shen
> Signed-off-by: Daniel Kurtz
> Signed-off-by: Philipp Zabel
[snip...]
> diff --git a/drivers/gpu/drm/mediatek/mt
On Fri, Jun 20, 2014 at 7:59 AM, Siarhei Siamashka
wrote:
>
> On Fri, 4 Apr 2014 17:22:01 +0800
> Daniel Kurtz wrote:
>
> > Kernel access to the eyxnos fbdev framebuffer is via its gem object's
> > kernel mapping (kvaddr, stored in info->screen_base).
> >
The following minor changes were needed to these headers:
* Convert // comments to /* */
* No , after final member of enum
With these changes, these header files can be included by a program that
is built with gcc options:
-std=c89 -Werror -pedantic
Signed-off-by: Daniel Kurtz
---
include
onf warnings.
>
> Signed-off-by: Emil Velikov
Reviewed-by: Daniel Kurtz
I've been carrying the same patch locally for a while.
> ---
>
> While this patch is not strictly speaking necessary for the full/correct
> build of libdrm, it cuts down the configure'n'compile
On Wed, May 14, 2014 at 2:26 PM, YoungJun Cho wrote:
>
> There could be the case that the page flip operation isn't finished correctly
> with some abnormal condition such as panel reset. So this patch replaces
> wait_event() with wait_event_timeout() to avoid waiting for page flip
> completion
>
On Wed, May 21, 2014 at 12:42 PM, YoungJun Cho wrote:
> There could be the case that the page flip operation isn't finished correctly
> with some abnormal condition such as panel reset. So this patch replaces
> wait_event() with wait_event_timeout() to avoid waiting for page flip
> completion
> i
On Wed, May 21, 2014 at 2:28 PM, YoungJun Cho wrote:
> Hi Daniel
>
>
> On 05/21/2014 03:01 PM, Daniel Kurtz wrote:
>>
>> On Wed, May 21, 2014 at 12:42 PM, YoungJun Cho
>> wrote:
>>>
>>> There could be the case that the page flip operation isn
On Mon, May 26, 2014 at 2:59 PM, Rahul Sharma
wrote:
>
> Hi Inki,
>
> Please review this patch.
>
> Regards,
> Rahul Sharma
>
> On 23 May 2014 17:17, Rahul Sharma wrote:
> > From: Rahul Sharma
> >
> > Fimd probe is accessing fimd Registers without enabling the fimd
> > gate clocks. If FIMD cloc
Hi YoungJun,
I am not famiilar with i80. Reading through this patch, it looks like
it works something like below for a page flip...
-> page_flip ioctl
exynos_drm_crtc_page_flip()
exynos_drm_crtc_mode_set_commit()
exynos_plane_mode_set()
exynos_drm_crtc_commit()
exynos_plane_commi
On Fri, Nov 14, 2014 at 7:13 PM, Zubair Lutfullah Kakakhel
wrote:
>
>
> On 14/11/14 11:08, Andy Yan wrote:
>>
>> On 2014å¹´11æ14æ¥ 18:55, Zubair Lutfullah Kakakhel wrote:
>>>
>>> On 14/11/14 10:53, Andy Yan wrote:
Hi ZubairLK:
Thanks for your review.
On 2014å¹´11æ14æ¥ 18:1
this statement
> + if (hdmi->hdmi_data.video_mode.mdvi)
> [...]
> + else {
> [...]
>
> Signed-off-by: Andy Yan
Reviewed-by: Daniel Kurtz
>
> ---
>
> Changes in v11: None
> Changes in v10: None
> Changes in v9: None
> Changes in v8: None
t for multi-byte register width access
> drm: bridge/dw_hdmi: add mode_valid support
> drm: bridge/dw_hdmi: clear i2cmphy_stat0 reg in hdmi_phy_wait_i2c_done
> drm: bridge/dw_hdmi: add function dw_hdmi_phy_enable_spare
> dt-bindings: Add documentation for rockchip dw hdmi
>
or multi-byte register width access
> drm: bridge/dw_hdmi: add mode_valid support
> drm: bridge/dw_hdmi: clear i2cmphy_stat0 reg in hdmi_phy_wait_i2c_done
> drm: bridge/dw_hdmi: add function dw_hdmi_phy_enable_spare
> dt-bindings: Add documentation for rockchip dw hdmi
> dr
->ddc) {
> dev_dbg(hdmi->dev, "failed to read ddc node\n");
> + of_node_put(ddc_node);
> + return -EPROBE_DEFER;
> + }
Nit: You could move "of_node_put()" above &quo
FORMAT_XRGB,
> DRM_FORMAT_ARGB,
> DRM_FORMAT_RGB565,
> + DRM_FORMAT_YUYV,
> + DRM_FORMAT_UYVY,
nit: probably better to alphabetize these.
Other than that,
Reviewed-by: Daniel Kurtz
>
> };
>
> static void mtk_plane_reset(struct drm_plane *plane)
> --
> 1.9.1
>
On Mon, Feb 1, 2016 at 12:13 PM, Jitao Shi wrote:
> This patch adds drm_bridge driver for parade DSI to eDP bridge chip.
>
> Signed-off-by: Jitao Shi
> ---
> Changes since v7:
> - Change ps8640_regw to ps8640_regw_bytes and remove devm_kzalloc
> - Fine tune ps8640 power squence
> - Add ps8640_
On Tue, Jan 5, 2016 at 1:36 AM, Philipp Zabel wrote:
> From: CK Hu
>
> This patch adds the device nodes for the DISP function blocks
> comprising the display subsystem.
>
> Signed-off-by: CK Hu
> Signed-off-by: Cawa Cheng
> Signed-off-by: Jie Qiu
> Signed-off-by: Da
Hi Philipp,
I ran into some issues when trying to bring up just the DSI path of
the Mediatek DRM driver.
Things were failing in probe/bind that triggered some oopses in the
unbind/error paths.
This resulted in the following review of the dsi patch...
On Tue, Jan 12, 2016 at 11:15 PM, Philipp Zabe
Hi Philipp,
Two more comments below...
On Tue, Feb 2, 2016 at 4:10 PM, Daniel Kurtz wrote:
> On Tue, Jan 5, 2016 at 1:36 AM, Philipp Zabel
> wrote:
>> From: CK Hu
>>
>> This patch adds the device nodes for the DISP function blocks
>> comprising the display subs
ubsystem. It currently supports two fixed output streams from the
> OVL0/OVL1 sources to the DSI0/DPI0 sinks, respectively.
>
> Signed-off-by: CK Hu
> Signed-off-by: YT Shen
> Signed-off-by: Daniel Kurtz
> Signed-off-by: Philipp Zabel
[snip]
> +int mtk_drm_crtc_
h adds an initial DRM driver for the Mediatek MT8173 DISP
> subsystem. It currently supports two fixed output streams from the
> OVL0/OVL1 sources to the DSI0/DPI0 sinks, respectively.
>
> Signed-off-by: CK Hu
> Signed-off-by: YT Shen
> Signed-off-by: Daniel Kurtz
> Signed-off-by:
Hi Jitao,
One more comment, inline...
On Mon, Feb 1, 2016 at 12:13 PM, Jitao Shi wrote:
> This patch adds drm_bridge driver for parade DSI to eDP bridge chip.
>
> Signed-off-by: Jitao Shi
[snip]
> +static int ps8640_probe(struct i2c_client *client,
> + const struct i2c_d
Hi Jitao,
Looks really good.
Just a couple of tiny things...
On Wed, Feb 3, 2016 at 4:48 PM, Jitao Shi wrote:
>
> This patch adds drm_bridge driver for parade DSI to eDP bridge chip.
>
> Signed-off-by: Jitao Shi
> ---
[snip]
> +static int ps8640_get_modes(struct drm_connector *connector)
>
On Thu, Feb 4, 2016 at 2:37 PM, CK Hu wrote:
> Hi Philipp:
>
> On Wed, 2016-02-03 at 12:01 +0100, Philipp Zabel wrote:
>> Hi Daniel,
>>
>
>> > > +static void mtk_output_dsi_disable(struct mtk_dsi *dsi)
>> > > +{
>> > > + if (!dsi->enabled)
>> > > + return;
>> > > +
>> > > +
Hi Philipp,
On Thu, Feb 4, 2016 at 3:25 AM, Philipp Zabel wrote:
> From: CK Hu
>
> This patch adds the device nodes for the DISP function blocks
> comprising the display subsystem.
>
> Signed-off-by: CK Hu
> Signed-off-by: Cawa Cheng
> Signed-off-by: Jie Qiu
>
Hi Philipp,
I tried using this driver with the Jitao Shi's latest Parade PS8640
driver from [0], which is based on Archit's recent DRM/DSI patch set
[1], and the parade bridge driver fails to find its DSI host using
of_find_mipi_dsi_host_by_node().
[0 ]https://patchwork.kernel.org/patch/8199281/
N116BGE panel support
The clock and htotal values from add by that patch are out of spec according to
the datasheets I have seen for the eDP N116BGE (-EA2 and -EB2).
This patch changes the values to the "Typ" values on the datasheet.
Signed-off-by: Daniel Kurtz
---
Thierry,
It is pos
Hi Thierry,
Congratulations! I saw in one thread that you said you are out on
paternity leave.
You mentioned that you would be back around v3.17-rc6, which should be
soonish, so just a gentle ping on this patch for when you return.
Thanks,
-Daniel
On Mon, Sep 22, 2014 at 4:39 PM, Thierry Reding
wrote:
>
> On Tue, Sep 02, 2014 at 10:56:46AM +0800, Daniel Kurtz wrote:
> > There are several different models of N116BGE. According to the commit
> > that added innolux_n116bge_mode [0], this N116BGE is for the eDP variety.
Hi Mark,
Please review comments inline...
On Wed, Sep 24, 2014 at 10:12 AM, Mark yao wrote:
> This patch adds the basic structure of a DRM Driver for Rockchip Socs.
>
> Signed-off-by: Mark yao
> ---
> Changes in v2:
> - use the component framework to defer main drm driver probe
> until all VO
On Thu, Sep 25, 2014 at 5:32 PM, Geert Uytterhoeven
wrote:
> On Sun, Aug 24, 2014 at 4:50 PM, Daniel Kurtz wrote:
>> Commit [0] stopped setting fix.smem_start and fix.smem_len when creating
>> the fbdev.
>>
>> [0] 2f1eab8d8ab59e799f7d51d62410b398607a7bc3
>> drm
Hi Mark,
More review comments inline... (sorry for the delay)
On Fri, Sep 26, 2014 at 6:55 PM, Mark Yao wrote:
> From: Mark yao
>
> This patch adds the basic structure of a DRM Driver for Rockchip Socs.
>
> Signed-off-by: Mark Yao
> Signed-off-by: Daniel Kurtz
> Ac
Hi Alex,
On Sun, Apr 15, 2018 at 9:48 PM Agrawal, Akshu wrote:
>
>
>
> On 4/13/2018 9:45 PM, Daniel Kurtz wrote:
> > Commit 51f7415039d4 ("drm/amd/amdgpu: creating two I2S instances for
> > stoney/cz") added support for the "BT_I2S" ACP i2s channel.
The following minor changes were needed to these headers:
* Convert // comments to /* */
* No , after final member of enum
With these changes, these header files can be included by a program that
is built with gcc options:
-std=c89 -Werror -pedantic
Signed-off-by: Daniel Kurtz
---
include
On Tue, Dec 17, 2013 at 11:12 PM, Daniel Drake wrote:
>
> On Mon, Dec 16, 2013 at 5:40 PM, Daniel Vetter wrote:
> > Have a bit of logic in the exynos ->detect function to re-try a 2nd
> > round of edid probing after each hdp interrupt if the first one
> > returns an -ENXIO. Only tricky part is to
3509] 880107d4dd00: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
fc
[6.613509]
==
Fixes: 51f7415039d4 ("drm/amd/amdgpu: creating two I2S instances for stoney/cz")
Signed-off-by: Daniel Kurtz
---
drivers/gpu/drm/amd
Hi Emil,
One answer inline below. The rest I leave to Jitao...
[snip...]
On Fri, Jun 17, 2016 at 3:14 AM, Emil Velikov
wrote:
>> +static ssize_t ps8640_update_fw_store(struct device *dev,
>> + struct device_attribute *attr,
>> +
Hi Philipp & Jie,
Sorry I only now had a chance to dig deeper and review the HDMI driver.
Lots of comments inline below...
On Tue, Mar 8, 2016 at 9:27 PM, Philipp Zabel wrote:
> From: Jie Qiu
>
> This patch adds drivers for the HDMI bridge connected to the DPI0
> display subsystem function blo
Hi Philipp, CK,
Some small comments.
Nothing that couldn't be addressed after merging, if you prefer.
On Tue, Mar 8, 2016 at 9:27 PM, Philipp Zabel wrote:
> From: CK Hu
>
> This patch add a drm encoder/connector driver for the MIPI DSI function
> block of the Mediatek display subsystem and a ph
Hi Philipp, Jie,
Some small comments.
Nothing that can't be fixed after merging if you prefer.
On Tue, Mar 8, 2016 at 9:27 PM, Philipp Zabel wrote:
> From: Jie Qiu
>
> Add DPI connector/encoder to support HDMI output via the
> attached HDMI bridge.
>
> Signed-off-by: Jie Qiu
> Signed-off-by: P
On Tue, Mar 15, 2016 at 7:49 PM, Philipp Zabel
wrote:
>
> Hi Daniel,
>
> Am Mittwoch, den 09.03.2016, 22:07 +0800 schrieb Daniel Kurtz:
> > Hi Philipp, CK,
> >
> > Some small comments.
> > Nothing that couldn't be addressed after merging, if you prefe
Hi Jitao,
This patch looks really good now.
Just saw small nits below.
Other than these small items, for the series:
Reviewed-by: Daniel Kurtz
On Thu, Mar 17, 2016 at 9:15 AM, Jitao Shi wrote:
> This patch adds drm_bridge driver for parade DSI to eDP bridge chip.
>
> Signed-off-by:
It is a bit more precise to compute the total number of pixels first and
then divide, rather than multiplying the line pixel count by the
already-rounded line duration.
Signed-off-by: Daniel Kurtz
---
drivers/gpu/drm/drm_irq.c |6 +-
1 files changed, 5 insertions(+), 1 deletions
te starts and completes before the interface is turned off.
> >
> > Fixed the former issue by using the same cycle selection as used in the
> > I2C_M_RD for the write case.
> > GMBUS_CYCLE_WAIT | (i + 1 == num ? GMBUS_CYCLE_STOP : 0)
> > Fixed the latter by waiting on GMBUS_ACTI
80 col, spaces around operators and other basic cleanup.
Signed-off-by: Daniel Kurtz
---
drivers/gpu/drm/i915/intel_i2c.c | 24
1 files changed, 16 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_i2c.c b/drivers/gpu/drm/i915/intel_i2c.c
index
i2c-core using the i2c adapter lock.
This patch adds a mutex to serialize access to the gmbus_xfer routine.
Note: the same mutex serializes both bit banged and native xfers.
Signed-off-by: Yufeng Shen
Signed-off-by: Daniel Kurtz
---
drivers/gpu/drm/i915/i915_drv.h |1 +
drivers/gpu/drm
pens first, during:
intel_modeset_init()
intel_setup_outputs()
intel_lvds_init()
drm_get_edid()
Is there a way to switch the order of these to events?
Or does it make more sense for the gmbus driver to check a "bool irq_enabled",
and choose whether to poll or use the GMBUS inte
action
will fail because it tries to use the wrong ("Reserved") pin pair.
However, the driver immediately falls back again to the bit-bang
method, which correctly uses GPIOF, so again, transfers succeed.
However, if gmbus mode is re-enabled and the GPIO fall-back mode is
dis
for another patch. We return -ETIMEDOUT if the hardware doesn't
deactivate after the STOP cycle.
This patch also takes advantage (in the write path) of the double-buffered
GMBUS3 data register by writing two 4-byte words before the first wait for
HW_RDY.
Signed-off-by: Daniel Kurtz
---
dr
the reserved port, either.
Tested on Sandybridge (gen 6, PCH == CougarPoint) hardware.
Signed-off-by: Daniel Kurtz
---
drivers/gpu/drm/i915/i915_reg.h |1 -
drivers/gpu/drm/i915/intel_i2c.c | 64 ++
2 files changed, 30 insertions(+), 35 deletions(-)
dif
ning in if condition'), but it seems
like the cleanest implementation.
Signed-off-by: Daniel Kurtz
---
drivers/gpu/drm/i915/intel_i2c.c | 19 ++-
1 files changed, 10 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_i2c.c b/drivers/gpu/drm/i915/intel_i2c.
cycle for performing
such a small write followed by a read. The INDEX can be either one or two
bytes long. The advantage of using such a cycle is that the CPU has
slightly less work to do once the read with INDEX cycle is started.
Signed-off-by: Daniel Kurtz
---
drivers/gpu/drm/i915/intel_i2
Return -ENXIO if a device NAKs a transaction.
Note: We should return -ETIMEDOUT, too if the transaction times out,
however, that error path is currently handled by the 'bit-bang fallback'.
Signed-off-by: Daniel Kurtz
---
drivers/gpu/drm/i915/intel_i2c.c |4 +++-
1 files
led before
intel_gmbus_get_bus().
Signed-off-by: Daniel Kurtz
---
drivers/gpu/drm/i915/i915_drv.h|4 +++-
drivers/gpu/drm/i915/intel_bios.c | 10 ++
drivers/gpu/drm/i915/intel_crt.c | 13 ++---
drivers/gpu/drm/i915/intel_drv.h |3 ++-
drivers/gpu/drm/i
On Wed, Mar 7, 2012 at 8:12 PM, Chris Wilson wrote:
> On Wed, 7 Mar 2012 19:50:47 +0800, Daniel Kurtz wrote:
>> Return -ENXIO if a device NAKs a transaction.
>>
>> Note: We should return -ETIMEDOUT, too if the transaction times out,
>> however, that error path is cu
On Wed, Mar 7, 2012 at 8:17 PM, Chris Wilson wrote:
> On Wed, 7 Mar 2012 19:50:45 +0800, Daniel Kurtz wrote:
>> There is no "disabled" port 0. So, don't even try to initialize/scan
>> it, etc. This saves a bit of time when initializing the driver, since
>
On Wed, Mar 7, 2012 at 9:23 PM, Chris Wilson wrote:
>
> On Wed, 7 Mar 2012 19:50:43 +0800, Daniel Kurtz
> wrote:
> > According to i915 documentation [1], "Port D" (DP/HDMI Port D) is
> > actually gmbus pin pair 6 (gmbus0.2:0 == 110b GPIOF), not 7 (111b).
&g
(thanks for the
review, Chris!), and adds the interrupt patch. There weren't any review
comments for patches 5, 7, or 8 of the first set. Hopefully they will get
more love the second time around :).
Daniel Kurtz (10):
drm/i915/intel_i2c: cleanup
drm/i915/intel_i2c: assign HDMI port D
cycle for performing
such a small write followed by a read. The INDEX can be either one or two
bytes long. The advantage of using such a cycle is that the CPU has
slightly less work to do once the read with INDEX cycle is started.
Signed-off-by: Daniel Kurtz
---
drivers/gpu/drm/i915/intel_i2
ets called before
intel_gmbus_get_adapter().
Signed-off-by: Daniel Kurtz
---
drivers/gpu/drm/i915/i915_drv.h|4 +++-
drivers/gpu/drm/i915/intel_bios.c | 11 +++
drivers/gpu/drm/i915/intel_crt.c | 13 ++---
drivers/gpu/drm/i915/intel_drv.h |3 ++-
drivers/gpu/
action
will fail because it tries to use the wrong ("Reserved") pin pair.
However, the driver immediately falls back again to the bit-bang
method, which correctly uses GPIOF, so again, transfers succeed.
However, if gmbus mode is re-enabled and the GPIO fall-back mode is
dis
i2c-core using the i2c adapter lock.
This patch adds a mutex to serialize access to the gmbus_xfer routine.
Note: the same mutex serializes both bit banged and native xfers.
Signed-off-by: Yufeng Shen
Signed-off-by: Daniel Kurtz
---
drivers/gpu/drm/i915/i915_drv.h |1 +
drivers/gpu/drm
"reserved" port 7, either.
Tested on Sandybridge (gen 6, PCH == CougarPoint) hardware.
Signed-off-by: Daniel Kurtz
---
drivers/gpu/drm/i915/i915_reg.h |1 -
drivers/gpu/drm/i915/intel_i2c.c | 64 +
2 files changed, 29 insertions(+), 36 deletions(-)
Save the GMBUS2 value read while polling for state changes, and then
reuse this value when determining for which reason the loops were exited.
This is a small optimization which saves a couple of bus accesses for
memory mapped IO registers.
Signed-off-by: Daniel Kurtz
Reviewed-by: Chris Wilson
Return -ENXIO if a device NAKs a transaction.
Note: We should return -ETIMEDOUT, too if the transaction times out,
however, that error path is currently handled by the 'bit-bang fallback'.
Signed-off-by: Daniel Kurtz
---
drivers/gpu/drm/i915/intel_i2c.c | 12 +++-
1 files c
80 col, spaces around operators and other basic cleanup.
Signed-off-by: Daniel Kurtz
---
drivers/gpu/drm/i915/intel_i2c.c | 19 +--
1 files changed, 13 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_i2c.c b/drivers/gpu/drm/i915/intel_i2c.c
index d30
from any active gmbus transactions, changing the interrupt
enable is protected by the gmbus transaction mutex.
Signed-off-by: Daniel Kurtz
---
drivers/gpu/drm/i915/i915_drv.h |2 +
drivers/gpu/drm/i915/i915_irq.c | 22 +-
drivers/gpu/drm/i915/i915_reg.h |1 +
drivers/gpu/drm
for another patch. We return -ETIMEDOUT if the hardware doesn't
deactivate after the STOP cycle.
This patch also takes advantage (in the write path) of the double-buffered
GMBUS3 data register by writing two 4-byte words before the first wait for
HW_RDY.
Signed-off-by: Daniel Kurtz
---
dr
action
will fail because it tries to use the wrong ("Reserved") pin pair.
However, the driver immediately falls back again to the bit-bang
method, which correctly uses GPIOF, so again, transfers succeed.
However, if gmbus mode is re-enabled and the GPIO fall-back mode is
dis
dybridge (gen 6, PCH == CougarPoint) hardware.
Signed-off-by: Daniel Kurtz
---
drivers/gpu/drm/i915/i915_drv.h |1 -
drivers/gpu/drm/i915/i915_reg.h |2 +-
drivers/gpu/drm/i915/intel_i2c.c | 63 ++---
3 files changed, 25 insertions(+), 41 deletions(-)
diff --g
rites
* Wait for IDLE before clearing NAK
Daniel Kurtz (11):
drm/i915/intel_i2c: cleanup
drm/i915/intel_i2c: assign HDMI port D to pin pair 6
drm/i915/intel_i2c: use i2c pre/post_xfer functions to setup gpio
xfers
drm/i915/intel_i2c: cleanup gmbus/gpio pin assignments
drm/i915/intel_
80 col, spaces around operators and other basic cleanup.
Some info message cleanup.
Signed-off-by: Daniel Kurtz
---
drivers/gpu/drm/i915/intel_i2c.c | 32 +---
1 files changed, 21 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_i2c.c b
cycle for performing
such a small write followed by a read. The INDEX can be either one or two
bytes long. The advantage of using such a cycle is that the CPU has
slightly less work to do once the read with INDEX cycle is started.
Signed-off-by: Daniel Kurtz
---
drivers/gpu/drm/i915/intel_i2
gmbus_func
use .force_bit to determine which i2c functionalities are available,
either i2c_bit_algo.functionality, or its own.
Signed-off-by: Daniel Kurtz
---
drivers/gpu/drm/i915/intel_i2c.c | 72 +++--
1 files changed, 45 insertions(+), 27 deletions(-)
diff --git a
device present on the bus with a given address.
Signed-off-by: Daniel Kurtz
---
drivers/gpu/drm/i915/intel_i2c.c |7 ---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_i2c.c b/drivers/gpu/drm/i915/intel_i2c.c
index a04f773..c467a2e 100644
--- a
This memory is always allocated, and it is always a fixed size, so just
allocate it along with the rest of the driver state.
Signed-off-by: Daniel Kurtz
---
drivers/gpu/drm/i915/i915_drv.h |2 +-
drivers/gpu/drm/i915/intel_i2c.c | 10 --
2 files changed, 1 insertions(+), 11
Save the GMBUS2 value read while polling for state changes, and then
reuse this value when determining for which reason the loops were exited.
This is a small optimization which saves a couple of bus accesses for
memory mapped IO registers.
Signed-off-by: Daniel Kurtz
Reviewed-by: Chris Wilson
1 - 100 of 366 matches
Mail list logo
