'ret' is know to be 0 a this point. Checking the return value of
'phy_init()' and 'phy_set_mode()' was intended instead.
So add the missing assignments.
Fixes: cca1705c3d89 ("drm/rockchip: lvds: Add PX30 support")
Signed-off-by: Christophe JAILLET
---
'ret' is know to be >=0 a this point. Checking the return value of
'mipi_dsi_dcs_enter_sleep_mode()' was intended instead.
So add the missing assignment.
Fixes: 6ea4383b9214 ("drm/panel: add panel driver for Leadtek LTK050H3146W")
Signed-off-by: Christophe JA
'ret' is know to be >=0 a this point. Checking the return value of
'mipi_dsi_dcs_enter_sleep_mode()' was intended instead.
So add the missing assignment.
Fixes: d1479d028af2 ("drm/panel: add panel driver for Xinpeng XPP055C272
panels")
Signed-off-by: Christo
'watermarks_table' must be freed instead 'clocks_table', because
'clocks_table' is known to be NULL at this point and 'watermarks_table' is
never freed if the last kzalloc fails.
Fixes: c98ee89736b8 ("drm/amd/pm: add the fine grain tuning function for
e the assignment to 'msm_dsi->phy_dev' a few lines above and remove the
unneeded 'get_device()' to solve both issues.
Fixes: ec31abf6684e ("drm/msm/dsi: Separate PHY to another platform device")
Signed-off-by: Christophe JAILLET
---
Review carefully, management of
Le 08/08/2021 à 15:45, Paul Cercueil a écrit :
By making the CRTC's .vblank_enable() function return an error when it
is known that the hardware won't deliver a VBLANK, we can drop the
ingenic_drm_atomic_helper_commit_tail() function and use the standard
drm_atomic_helper_commit_tail() function i
Le 08/08/2021 à 22:09, Paul Cercueil a écrit :
Hi Christophe,
Le dim., août 8 2021 at 21:50:04 +0200, Christophe JAILLET
a écrit :
Le 08/08/2021 à 15:45, Paul Cercueil a écrit :
By making the CRTC's .vblank_enable() function return an error when it
is known that the hardware won't
Hi,
Le 21/08/2021 à 04:08, CGEL a écrit :
From: Luo penghao
The first assignment is not used. In order to keep the code style
consistency of the whole file, the first 'data' assignment should be
deleted.
The clang_analyzer complains as follows:
drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c:2608:10:
gt;dev, e2)
@@
expression e1, e2;
@@
-pci_set_dma_mask(e1, e2)
+dma_set_mask(&e1->dev, e2)
@@
expression e1, e2;
@@
- pci_set_consistent_dma_mask(e1, e2)
+dma_set_coherent_mask(&e1->dev, e2)
Signed-off-by: Christophe JAILLET
---
If needed, see post from Christoph Hellwi
gt;dev, e2)
@@
expression e1, e2;
@@
-pci_set_dma_mask(e1, e2)
+dma_set_mask(&e1->dev, e2)
@@
expression e1, e2;
@@
- pci_set_consistent_dma_mask(e1, e2)
+dma_set_coherent_mask(&e1->dev, e2)
Signed-off-by: Christophe JAILLET
---
If needed, see post from Christoph Hellw
gt;dev, e2)
@@
expression e1, e2;
@@
-pci_set_dma_mask(e1, e2)
+dma_set_mask(&e1->dev, e2)
@@
expression e1, e2;
@@
- pci_set_consistent_dma_mask(e1, e2)
+dma_set_coherent_mask(&e1->dev, e2)
Signed-off-by: Christophe JAILLET
---
If needed, see post from Christoph Hellw
gt;dev, e2)
@@
expression e1, e2;
@@
-pci_set_dma_mask(e1, e2)
+dma_set_mask(&e1->dev, e2)
@@
expression e1, e2;
@@
- pci_set_consistent_dma_mask(e1, e2)
+dma_set_coherent_mask(&e1->dev, e2)
Signed-off-by: Christophe JAILLET
---
If needed, see post from Christoph Hellw
gt;dev, e2)
@@
expression e1, e2;
@@
-pci_set_dma_mask(e1, e2)
+dma_set_mask(&e1->dev, e2)
@@
expression e1, e2;
@@
- pci_set_consistent_dma_mask(e1, e2)
+dma_set_coherent_mask(&e1->dev, e2)
Signed-off-by: Christophe JAILLET
---
If needed, see post from Christoph Hellw
The wrappers in include/linux/pci-dma-compat.h should go away.
The patch has been generated with the coccinelle script below.
@@
expression e1, e2, e3, e4;
@@
-pci_free_consistent(e1, e2, e3, e4)
+dma_free_coherent(&e1->dev, e2, e3, e4)
Signed-off-by: Christophe JAILLET
---
If
Le 24/08/2021 à 12:24, Robin Murphy a écrit :
On 2021-08-23 22:30, Christophe JAILLET wrote:
The wrappers in include/linux/pci-dma-compat.h should go away.
The patch has been generated with the coccinelle script below.
@@
expression e1, e2, e3, e4;
@@
- pci_free_consistent(e1, e2, e3, e4
Le 15/01/2021 à 11:10, Colin Ian King a écrit :
On 15/01/2021 10:07, Christophe JAILLET wrote:
Le 15/01/2021 à 10:37, Colin Ian King a écrit :
On 12/01/2021 10:07, Dan Carpenter wrote:
On Mon, Jan 11, 2021 at 11:46:38AM +, Colin King wrote:
From: Colin Ian King
A recent change added a
Le 15/01/2021 à 10:37, Colin Ian King a écrit :
On 12/01/2021 10:07, Dan Carpenter wrote:
On Mon, Jan 11, 2021 at 11:46:38AM +, Colin King wrote:
From: Colin Ian King
A recent change added a new BOOTUP_DEFAULT power profile mode
to the PP_SMC_POWER_PROFILE enum but omitted updating the
co
'ret' is known to be 0 here.
No error code is available, so just remove it from the error message.
Fixes: 72330b0eeefc ("i.MX Framebuffer: Use readl/writel instead of direct
pointer deref")
Signed-off-by: Christophe JAILLET
---
drivers/video/fbdev/imxfb.c | 2 +-
1 file
Le 07/05/2021 à 07:05, Uwe Kleine-König a écrit :
Hello Christophe,
On Thu, May 06, 2021 at 08:57:05PM +0200, Christophe JAILLET wrote:
'ret' is known to be 0 here.
No error code is available, so just remove it from the error message.
Fixes: 72330b0eeefc ("i.MX Framebuffer: U
for MIPI-DCS compatible LCDs")
Signed-off-by: Christophe JAILLET
---
drivers/video/fbdev/omap/lcd_mipid.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/video/fbdev/omap/lcd_mipid.c
b/drivers/video/fbdev/omap/lcd_mipid.c
index a75ae0c9b14c..b4b93ff4b41a
If an error occurs after calling 'virtio_gpu_init()', 'virtio_gpu_deinit()'
must be called as already done in the remove function.
Fixes: d516e75c71c9 ("drm/virtio: Drop deprecated load/unload initialization")
Signed-off-by: Christophe JAILLET
---
drivers/gp
evice_init()'
fails.
Goto the error handling path instead to free some resources.
Fixes: 7f7b96a8a0a1 ("drm/kmb: Add support for KeemBay Display")
Signed-off-by: Christophe JAILLET
---
drivers/gpu/drm/kmb/kmb_drv.c | 8
1 file changed, 4 insertions(+), 4 deletions
'phys_addr' is of type 'dma_addr_t'.
Use '%pad' instead of '%x' to print this variable in an error message.
Signed-off-by: Christophe JAILLET
---
drivers/video/fbdev/ep93xx-fb.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/d
Use 'framebuffer_release()' instead of 'kfree()' to undo a
'framebuffer_alloc()' call, both in the error handling path of the probe
function and in remove function.
Signed-off-by: Christophe JAILLET
---
drivers/video/fbdev/ep93xx-fb.c | 4 ++--
1 file changed
of_parse_display_timing() already call memset(0) on its 2nd argument, so
there is no need to clear it explicitly before calling this function.
Use kmalloc() instead of kzalloc() to save a few cycles.
Signed-off-by: Christophe JAILLET
---
drivers/video/of_display_timing.c | 2 +-
1 file changed
e(E);
Signed-off-by: Christophe JAILLET
---
drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 1 -
drivers/gpu/drm/msm/dsi/dsi_host.c| 1 -
drivers/gpu/drm/msm/edp/edp_ctrl.c| 1 -
drivers/gpu/drm/msm/hdmi/hdmi.c | 4 +---
drivers/gpu/drm/tilcdc/tilcdc_drv.c | 4 +---
drivers/gpu/drm/vmwgfx/ttm
Le 30/09/2021 à 16:21, Daniel Vetter a écrit :
On Sat, Sep 25, 2021 at 08:46:12PM +0800, Cai Huoqing wrote:
Replace direction definition PCI_DMA_BIDIRECTIONAL
with DMA_BIDIRECTIONAL, because it helps to enhance readability
and avoid possible inconsistency.
Signed-off-by: Cai Huoqing
Applied
If lt9611_audio_init() fails, some resources still need to be released
before returning an error code.
Add the missing goto the error handling path.
Fixes: 23278bf54afe ("drm/bridge: Introduce LT9611 DSI to HDMI bridge")
Signed-off-by: Christophe JAILLET
---
drivers/gpu/drm/brid
: Implement buffer object cache")
Signed-off-by: Christophe JAILLET
---
Untested.
I hope that moving host1x_bo_cache_init() is just fine.
---
drivers/gpu/host1x/dev.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/host1x/dev.c b/drivers/gpu/h
Add a missing 'host1x_channel_list_free()' call in the remove function,
as already done in the error handling path of the probe function.
Fixes: 8474b02531c4 ("gpu: host1x: Refactor channel allocation code")
Signed-off-by: Christophe JAILLET
---
drivers/gpu/host1x/dev.c | 1
Le 21/11/2021 à 11:13, cgel@gmail.com a écrit :
From: yong yiran
The clang_analyzer complains as follows:
drivers/gpu/drm/i915/i915_request.c:2119:2 warning:
Value stored to 'x' is never read
Reported-by: Zeal Robot
Signed-off-by: yong yiran
---
drivers/gpu/drm/i915/i915_request.c | 3
'doorbell_bitmap' is a bitmap. So use 'bitmap_zalloc()' to simplify code,
improve the semantic and avoid some open-coded arithmetic in allocator
arguments.
Also change the corresponding 'kfree()' into 'bitmap_free()' to keep
consistency.
Signed-off-by:
The 'doorbell_bitmap' bitmap has just been allocated. So we can use the
non-atomic '__set_bit()' function to save a few cycles as no concurrent
access can happen.
Signed-off-by: Christophe JAILLET
---
bitmap_set() could certainly also be use, but range checking would be
tric
Le 22/11/2021 à 22:44, Felix Kuehling a écrit :
Am 2021-11-21 um 12:41 p.m. schrieb Christophe JAILLET:
The 'doorbell_bitmap' bitmap has just been allocated. So we can use the
non-atomic '__set_bit()' function to save a few cycles as no concurrent
access can happen.
Signe
to keep
consistency.
Reviewed-by: Felix Kuehling
Signed-off-by: Christophe JAILLET
---
v1 --> v2: Compile tested :)
Add a missing ',' (kernel test robot)
Add kfd_process_queue_manager.c (Felix Kuehling)
---
drivers/gpu/drm/amd/amdkfd/kfd_process.c | 7
The 'doorbell_bitmap' bitmap has just been allocated. So we can use the
non-atomic '__set_bit()' function to save a few cycles as no concurrent
access can happen.
Reviewed-by: Felix Kuehling
Signed-off-by: Christophe JAILLET
---
bitmap_set() could certainly also be use, but
'kfd->gtt_sa_bitmap' is a bitmap. So use 'bitmap_zalloc()' to simplify
code, improve the semantic and avoid some open-coded arithmetic in
allocator arguments.
Also change the corresponding 'kfree()' into 'bitmap_free()' to keep
consistency.
---
drivers/gpu/drm/amd/amdkfd/kfd_device.c | 12 +++
27; loops. These functions can work on several bits at a
time
Signed-off-by: Christophe JAILLET
---
drivers/gpu/drm/amd/amdkfd/kfd_device.c | 16 +---
1 file changed, 5 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device.c
b/drivers/gpu/drm/amd/amdkfd/kf
'bufs' is an array embedded in an structure (struct drm_device_dma) which
is kzalloc just a few lines above.
So there is no need to explicitly memset each element on the array. It is
already cleared.
Remove the useless memset.
Signed-off-by: Christophe JAILLET
---
drivers/gpu/drm/drm
The 'tcm->bitmap' is kzalloc'ed just a few lines above, at the same time as
'tcm'. There is no need to initialize it another time here.
Remove the useless bitmap_clear() call.
Signed-off-by: Christophe JAILLET
---
drivers/gpu/drm/omapdrm/tcm-sita.c | 1 -
1 file
dp_debug_init() always returns 0. So, make it a void function and simplify
the only caller accordingly.
While at it remove a useless 'rc' initialization in dp_debug_get()
Signed-off-by: Christophe JAILLET
---
drivers/gpu/drm/msm/dp/dp_debug.c | 13 +++--
1 file changed, 3
'dp_bridge' is devm_alloc'ed, so there is no need to free it explicitly or
there will be a double free().
Fixes: 8a3b4c17f863 ("drm/msm/dp: employ bridge mechanism for display enable
and disable")
Signed-off-by: Christophe JAILLET
---
drivers/gpu/drm/msm/dp/dp_drm.c
'priv' is a managed resource, so there is no need to free it explicitly or
there will be a double free().
Fixes: 90ad200b4cbc ("drm/armada: Use devm_drm_dev_alloc")
Signed-off-by: Christophe JAILLET
---
drivers/gpu/drm/armada/armada_drv.c | 1 -
1 file changed, 1 delet
sn65dsi83_parse_dt() takes a reference on 'ctx->host_node' that must be
released in the error handling path of the probe.
This is only done in the remove function up to now.
Fixes: ceb515ba29ba ("drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84
driver")
Signed-off
er")
Signed-off-by: Christophe JAILLET
---
v2: add error handling in sn65dsi83_parse_dt() [Laurent Pinchart]
---
drivers/gpu/drm/bridge/ti-sn65dsi83.c | 32 +++
1 file changed, 23 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi83.c
b/dr
Le 05/01/2022 à 21:09, Stephen Boyd a écrit :
Quoting Christophe JAILLET (2021-12-26 07:14:05)
'dp_bridge' is devm_alloc'ed, so there is no need to free it explicitly or
there will be a double free().
Fixes: 8a3b4c17f863 ("drm/msm/dp: employ bridge mechanism for display
Le 13/01/2022 à 08:31, Hsin-Yi Wang a écrit :
Use devm_kzalloc instead of kzalloc and drop kfree(). Let the memory
handled by driver detach.
Signed-off-by: Hsin-Yi Wang
Reviewed-by: Xin Ji
---
drivers/gpu/drm/bridge/analogix/anx7625.c | 9 +++--
1 file changed, 3 insertions(+), 6 deleti
dc8544 should be pcd8544. (d and c switched)
As I don't know the implication of such a change, I prefer to first
report the potential issue, before proposing a patch for it.
Any feedback back appreciated.
Best regards,
Christophe JAILLET
_
The description passed to 'devm_gpio_request_one()' should be related to
LMS283GF05, not LMS285GF05.
Signed-off-by: Christophe JAILLET
---
drivers/video/backlight/lms283gf05.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/backlight/lms283gf05.c
The driver is related to 'pcd8544'.
However, 2 strings are about pdc8544 (c and d switched)
Fix it.
Signed-off-by: Christophe JAILLET
---
This patch is only theorical. It is based on the fact that a part of the
filename (i.e. pcd8544) looks misspelled in the file itself.
I don&
Le 16/06/2022 à 07:18, Bo Liu a écrit :
Use ida_alloc_xxx()/ida_free() instead of
ida_simple_get()/ida_simple_remove().
The latter is deprecated and more verbose.
Signed-off-by: Bo Liu
---
drivers/gpu/drm/drm_connector.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
dif
bochs_hw_init() call.
Signed-off-by: Christophe JAILLET
---
I've not been able to find a Fixes: tag because of code re-arrangement
done in 796c3e35ac16.
---
drivers/gpu/drm/tiny/bochs.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/tiny/boch
Should component_add() fail, we should call analogix_dp_remove() in the
error handling path, as already done in the remove function.
Fixes: 152cce0006ab ("drm/bridge: analogix_dp: Split bind() into probe() and
real bind()")
Signed-off-by: Christophe JAILLET
---
drivers/gpu/dr
kmalloc_array()/kcalloc() should be used to avoid potential overflow when
a multiplication is needed to compute the size of the requested memory.
So turn a kzalloc()+explicit size computation into an equivalent kcalloc().
Signed-off-by: Christophe JAILLET
---
drivers/video/backlight/pwm_bl.c
kmalloc_array()/kcalloc() should be used to avoid potential overflow when
a multiplication is needed to compute the size of the requested memory.
So turn a kzalloc()+explicit size computation into an equivalent kcalloc().
Signed-off-by: Christophe JAILLET
---
drivers/gpu/drm/radeon
ixes: db1a0ae21461 ("drm/nouveau/bl: Assign different names to interfaces")
Signed-off-by: Christophe JAILLET
---
This patch is more a clean-up than a fix.
It is unlikely than >= 100 backlight devices will be registered, and the
over allocation would occur even much later when the und
NULL when this function is called.
Signed-off-by: Christophe JAILLET
---
drivers/video/backlight/backlight.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/video/backlight/backlight.c
b/drivers/video/backlight/backlight.c
index 4ae6fae94ac2..b788ff3d0f45 10
Use devm_add_action_or_reset() instead of hand writing it.
This is more straightforward and saves a few lines of code.
Signed-off-by: Christophe JAILLET
---
drivers/gpu/drm/i2c/tda9950.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i2c/tda9950.c b
,
No problem for me if you can add it. Thanks.
But if you prefer a v2, it is also fine for me.
BTW sorry for missing the SoB tag. This definitively means that I forgot
the checkpatch.pl step for this patch, which is bad.
CJ
Thanks,
Felix
Am 2021-11-28 um 11:45 schrieb Christophe JAILLET:
Le 15/08/2022 à 17:56, Wei Liu a écrit :
All that said, the fix looks good, so
Reviewed-by: Michael Kelley
I made the two changes listed above and applied this patch to
hyperv-fixes.
Thanks a lot, that saves me a v2.
CJ
Thanks,
Wei.
Le 23/05/2022 à 12:47, Guillaume Ranquet a écrit :
dpintf is the displayport interface hardware unit. This unit is similar
to dpi and can reuse most of the code.
This patch adds support for mt8195-dpintf to this dpi driver. Main
differences are:
- Some features/functional components are not av
Use bitmap_zalloc()/bitmap_free() instead of hand-writing them.
It is less verbose and it improves the semantic.
While at it, remove a useless bitmap_zero() call. The bitmap is already
zero'ed when allocated.
Signed-off-by: Christophe JAILLET
---
drivers/gpu/host1x/channel.c | 8 ++
Use bitmap_zalloc()/bitmap_free() instead of hand-writing them.
It is less verbose and it improves the semantic.
Signed-off-by: Christophe JAILLET
---
drivers/gpu/drm/vc4/vc4_validate_shaders.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/vc4
There is already a SPDX-License-Identifier tag, so the corresponding
license text can be removed.
Signed-off-by: Christophe JAILLET
---
include/uapi/drm/armada_drm.h | 4
include/uapi/drm/etnaviv_drm.h | 12
include/uapi/drm/exynos_drm.h | 5 -
include/uapi/drm
p and g are switched in 'amdpgu_dm'
Signed-off-by: Christophe JAILLET
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
b/drivers/gpu/drm/amd/display
A 'h' ismissing in' syncronization'
Signed-off-by: Christophe JAILLET
---
drivers/dma-buf/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma-buf/Kconfig b/drivers/dma-buf/Kconfig
index 0613bb7770f5..e7d820ce0724 100644
--- a/drivers/d
'dc_stream_release()' may be called twice. Once here, and once below in the
error handling path if we branch to the 'fail' label.
Set 'new_stream' to NULL, once released to avoid the duplicated release
function call.
Signed-off-by: Christophe JAILLET
---
Mayb
If this memory allocation fails, we have to go through the error handling
path to perform some clean-up, as already done in other other paths of
this function.
Fixes: db735fc4036b ("drm/msm: Set dma maximum segment size for mdss")
Signed-off-by: Christophe JAILLET
---
drivers/g
All error handling paths before and after this one go to the
'clk_disable' label in order to free some resources.
So the same here.
Fixes: ca5be902a87d ("drm/mcde: Fix uninitialized variable")
Signed-off-by: Christophe JAILLET
---
drivers/gpu/drm/mcde/mcde_drv.c | 3 ++
'in' is duplicated in the error message. Axe one of them.
While at it, slighly improve indentation.
Signed-off-by: Christophe JAILLET
---
drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/msm/adreno/a6x
If we don't find any matching components, we should go through the error
handling path, in order to free some resources.
Fixes: ca5be902a87d ("drm/mcde: Fix uninitialized variable")
Signed-off-by: Christophe JAILLET
---
drivers/gpu/drm/mcde/mcde_drv.c | 3 ++-
1 file changed, 2 i
ion.
Also, remove a useless 'PAGE_ALIGN()'. 'info->fix.smem_len' is already
PAGE_ALIGNed.
Fixes: 638772c7553f ("fb: add support of LCD display controller on pxa168/910
(base layer)")
Signed-off-by: Christophe JAILLET
---
The change about PAGE_ALIGN should proba
This should be 'amdgpu_dm', not 'amdpgu_dm'
Signed-off-by: Christophe JAILLET
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
b/drivers/gpu/drm/a
This should be 'dce_audio_mask', not 'dce_aduio_mask'.
Signed-off-by: Christophe JAILLET
---
drivers/gpu/drm/amd/display/dc/dce/dce_audio.c | 2 +-
drivers/gpu/drm/amd/display/dc/dce/dce_audio.h | 6 +++---
drivers/gpu/drm/amd/display/dc/dce100/d
'_navi10_ip_offset_HEADER' is already used in 'navi10_ip_offset.h', so use
'_navi12_ip_offset_HEADER' instead here.
Signed-off-by: Christophe JAILLET
---
drivers/gpu/drm/amd/include/navi12_ip_offset.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
di
rved_mem_device_init()'
fails.
Goto the error handling path instead to free some resources.
Fixes: 7f7b96a8a0a1 ("drm/kmb: Add support for KeemBay Display")
Signed-off-by: Christophe JAILLET
---
v2: Keep label name
Fix the commit message where a wrong function name was used
---
'ret' is known to be 0 at this point.
Reporting the error from the previous 'platform_get_irq()' call is likely,
so add the missing assignment.
Fixes: 7f7b96a8a0a1 ("drm/kmb: Add support for KeemBay Display")
Signed-off-by: Christophe JAILLET
---
v2: New patch
---
s/than/then/
Signed-off-by: Christophe JAILLET
---
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
index 89ebbf363e27..1476236f5c7c 100644
--- a/drivers
de")
Fixes: 8bdb3a2d7df4 ("uvesafb: the driver core")
Signed-off-by: Christophe JAILLET
---
Unsure about the Fixes tag, maybe it is 63e28a7a5ffc
---
drivers/video/fbdev/uvesafb.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/video/fbdev/uvesafb.c b/drivers/video/fbdev/uv
Instead of zeroing some memory and then copying data in part or all of it,
use memcpy_and_pad().
This avoids writing some memory twice and should save a few cycles.
Signed-off-by: Christophe JAILLET
---
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 11 ---
drivers/gpu/drm/amd/amdgpu
Le 21/02/2023 à 17:26, Felix Kuehling a écrit :
On 2023-02-21 06:35, qu.huang-fxuvxftifdnyg1zeobx...@public.gmane.org
wrote:
From: Qu Huang
In the kfd_wait_on_events() function, the kfd_event_waiter structure is
allocated by alloc_event_waiters(), but the event field of the waiter
structure
strtobool() is the same as kstrtobool().
However, the latter is more used within the kernel.
In order to remove strtobool() and slightly simplify kstrtox.h, switch to
the other function name.
While at it, include the corresponding header file ()
Signed-off-by: Christophe JAILLET
---
This patch
Le 22/01/2023 à 19:16, Diederik de Haas a écrit :
Signed-off-by: Diederik de Haas
---
drivers/char/agp/amd64-agp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/char/agp/amd64-agp.c b/drivers/char/agp/amd64-agp.c
index ce8651436609..3020fd92fd00 100644
--- a/driv
Le 07/10/2022 à 21:53, Colin Ian King a écrit :
The assignment to variable taken is redundant and so it can be
removed as well as the variable too.
Cleans up clang-scan build warnings:
warning: Although the value stored to 'taken' is used in the enclosing
expression, the value is never actually
strtobool() is the same as kstrtobool().
However, the latter is more used within the kernel.
In order to remove strtobool() and slightly simplify kstrtox.h, switch to
the other function name.
While at it, include the corresponding header file ()
Signed-off-by: Christophe JAILLET
---
This patch
("uvesafb: the driver core")
Signed-off-by: Christophe JAILLET
---
Unsure about the Fixes tag, maybe it is 63e28a7a5ffc
Change in v2:
- add arch_phys_wc_del() at the right place in the error handling path
v1 (a long time ago!):
https://lore.kernel.org/all/dd2a4806d3a570ab84947806f38a494
When the remove() function is called, we know that the probe() function has
successfully been executed. So 'info' is known to be not NULL.
Simplify the code accordingly.
Signed-off-by: Christophe JAILLET
---
Change in v2:
- new patch
---
drivers/video/fbdev/uves
If an error occurs after a successful msm_hdmi_get_phy() call, it must be
undone by a corresponding msm_hdmi_put_phy(), as already done in the
remove function.
Fixes: 437365464043 ("drm/msm/hdmi: move msm_hdmi_get_phy() to
msm_hdmi_dev_probe()")
Signed-off-by: Christophe JAILLET
---
N
If an error occurs after a successful msm_hdmi_get_phy() call, it must be
undone by a corresponding msm_hdmi_put_phy(), as already done in the
remove function.
Fixes: 437365464043 ("drm/msm/hdmi: move msm_hdmi_get_phy() to
msm_hdmi_dev_probe()")
Signed-off-by: Christophe JAILLET
R
Le 15/12/2022 à 17:36, Arnd Bergmann a écrit :
From: Arnd Bergmann
The activity_monitor_external[] array is too big to fit on the
kernel stack, resulting in this warning with clang:
drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu13/smu_v13_0_7_ppt.c:1438:12: error:
stack frame size (1040) exceeds
devm_add_action_or_reset().
Signed-off-by: Christophe JAILLET
---
drivers/gpu/drm/bridge/tc358767.c | 17 +
1 file changed, 1 insertion(+), 16 deletions(-)
diff --git a/drivers/gpu/drm/bridge/tc358767.c
b/drivers/gpu/drm/bridge/tc358767.c
index 2a58eb271f70..b95c36ca660d 100644
--- a/drivers
devm_add_action_or_reset().
Signed-off-by: Christophe JAILLET
Reviewed-by: Andrzej Hajda
---
Change in v2:
- Convert to dev_err_probe()[Andrzej Hajda]
- Update the error message[Andrzej Hajda]
- Add R-b tag[Andrzej Hajda]
v1:
https://lore.kernel.org/all
It is likely Height was expected here, instead of Width.
Test the correct variable.
Fixes: 17529ea2acfa ("drm/amd/display: Optimizations for DML math")
Signed-off-by: Christophe JAILLET
---
drivers/gpu/drm/amd/display/dc/dml/dcn21/display_mode_vba_21.c | 2 +-
1 file changed, 1 inser
It is likely p1_min_meta_chunk_bytes was expected here, instead of
min_meta_chunk_bytes.
Test the correct variable.
Fixes: dda4fb85e433 ("drm/amd/display: DML changes for DCN32/321")
Signed-off-by: Christophe JAILLET
---
.../gpu/drm/amd/display/dc/dml/dcn32/display_rq_dlg_calc_32.c
Le 19/04/2023 à 06:59, Dan Carpenter a écrit :
On Sat, Apr 15, 2023 at 04:09:03PM +0300, Dan Carpenter wrote:
On Thu, Apr 13, 2023 at 09:33:17PM +0200, Christophe JAILLET wrote:
When dev_err_probe() is called, 'ret' holds the value of the previous
successful devm_request_irq()
bda0322b8a ("drm/amd/display: Add DSC support for Navi (v2)")
Signed-off-by: Christophe JAILLET
---
NOT even compile-tested.
make -j7 drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.o
on my setup, it fails with:
CC drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.o
drivers/gpu/drm/amd/displa
Le 26/04/2023 à 20:54, Justin Chen a écrit :
Add support for the Broadcom ASP 2.0 Ethernet controller which is first
introduced with 72165. This controller features two distinct Ethernet
ports that can be independently operated.
This patch supports:
- Wake-on-LAN using magic packets
- basic eth
Le 26/12/2021 à 17:34, Christophe JAILLET a écrit :
'priv' is a managed resource, so there is no need to free it explicitly or
there will be a double free().
Fixes: 90ad200b4cbc ("drm/armada: Use devm_drm_dev_alloc")
Signed-off-by: Christophe JAILLET
---
drivers/gpu/drm
d
"-ENOENT" so that -EPROBE_DEFER is handled and propagated correctly.
Fixes: 81b63420564d ("video: fbdev: mmp: Make use of the helper function
dev_err_probe()")
Signed-off-by: Christophe JAILLET
---
drivers/video/fbdev/mmp/hw/mmp_ctrl.c | 2 +-
1 file changed, 1 insertion(+)
A kzalloc()+memcpy() can be optimized in a single kmemdup().
This saves a few cycles because some memory doesn't need to be zeroed.
Signed-off-by: Christophe JAILLET
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --
1 - 100 of 297 matches
Mail list logo
