[PATCH] drm/msm/dp: Simplify dp_debug_init() and dp_debug_get()

[Christophe JAILLET]

dp_debug_init() always returns 0. So, make it a void function and simplify
the only caller accordingly.

While at it remove a useless 'rc' initialization in dp_debug_get()

Signed-off-by: Christophe JAILLET <christophe.jail...@wanadoo.fr>
---
 drivers/gpu/drm/msm/dp/dp_debug.c | 13 +++----------
 1 file changed, 3 insertions(+), 10 deletions(-)

diff --git a/drivers/gpu/drm/msm/dp/dp_debug.c 
b/drivers/gpu/drm/msm/dp/dp_debug.c
index da4323556ef3..338f1f9c4d14 100644
--- a/drivers/gpu/drm/msm/dp/dp_debug.c
+++ b/drivers/gpu/drm/msm/dp/dp_debug.c
@@ -207,9 +207,8 @@ static const struct file_operations test_active_fops = {
        .write = dp_test_active_write
 };
 
-static int dp_debug_init(struct dp_debug *dp_debug, struct drm_minor *minor)
+static void dp_debug_init(struct dp_debug *dp_debug, struct drm_minor *minor)
 {
-       int rc = 0;
        struct dp_debug_private *debug = container_of(dp_debug,
                        struct dp_debug_private, dp_debug);
 
@@ -229,17 +228,15 @@ static int dp_debug_init(struct dp_debug *dp_debug, 
struct drm_minor *minor)
                        debug, &dp_test_type_fops);
 
        debug->root = minor->debugfs_root;
-
-       return rc;
 }
 
 struct dp_debug *dp_debug_get(struct device *dev, struct dp_panel *panel,
                struct dp_usbpd *usbpd, struct dp_link *link,
                struct drm_connector *connector, struct drm_minor *minor)
 {
-       int rc = 0;
        struct dp_debug_private *debug;
        struct dp_debug *dp_debug;
+       int rc;
 
        if (!dev || !panel || !usbpd || !link) {
                DRM_ERROR("invalid input\n");
@@ -266,11 +263,7 @@ struct dp_debug *dp_debug_get(struct device *dev, struct 
dp_panel *panel,
        dp_debug->hdisplay = 0;
        dp_debug->vrefresh = 0;
 
-       rc = dp_debug_init(dp_debug, minor);
-       if (rc) {
-               devm_kfree(dev, debug);
-               goto error;
-       }
+       dp_debug_init(dp_debug, minor);
 
        return dp_debug;
  error:
-- 
2.32.0