Prior to making the syncobj lookup lockless, update the idr to the new
XArray API.
Based on a patch by Matthew Wilcox
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/drm_syncobj.c | 64 ++-
include/drm/drm_file.h| 7 ++--
2 files changed, 21 insertions
Quoting Daniel Vetter (2019-11-05 19:38:29)
> It's broken.
So is the code that depends on it. Which is the entire point.
Don't select it then.
-Chris
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listin
Quoting Daniel Vetter (2019-11-05 19:38:29)
> It's broken.
>
> Reported-by: Stephen Rothwell
> References:
> https://lists.freedesktop.org/archives/dri-devel/2019-November/242625.html
> Signed-off-by: Daniel Vetter
> ---
> Note: Probably best to apply this directly onto drm-next to avoid
> havi
Quoting Daniel Vetter (2019-11-05 20:58:25)
> On Tue, Nov 5, 2019 at 9:38 PM Chris Wilson wrote:
> >
> > Quoting Daniel Vetter (2019-11-05 19:38:29)
> > > It's broken.
> > >
> > > Reported-by: Stephen Rothwell
> > > References:
>
Quoting Daniel Vetter (2019-11-05 20:58:25)
> On Tue, Nov 5, 2019 at 9:38 PM Chris Wilson wrote:
> >
> > Quoting Daniel Vetter (2019-11-05 19:38:29)
> > > It's broken.
> > >
> > > Reported-by: Stephen Rothwell
> > > References:
>
Currently the drm_prime mmap fallback uses a mock struct file to provide
the file pointer into the backend mmap routine. Now that we can create
fully fledged anonymous struct file around the drm device, put it to
use.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/drm_prime.c | 26
Provide a utility function to create a vma corresponding to an mmap() of
our device. And use it to exercise the equivalent of userspace
performing a GTT mmap of our objects.
Signed-off-by: Chris Wilson
Cc: Abdiel Janulgue
---
drivers/gpu/drm/i915/Makefile | 1 +
.../drm/i915
Sometimes we need to create a struct file to wrap a drm_device, as it
the user were to have opened /dev/dri/card0 but to do so anonymously
(i.e. for internal use). Provide a utility method to create a struct
file with the drm_device->driver.fops, that wrap the drm_device.
Signed-off-by: Ch
Quoting Daniel Vetter (2019-11-06 10:19:50)
> On Wed, Nov 06, 2019 at 10:07:14AM +0000, Chris Wilson wrote:
> > Sometimes we need to create a struct file to wrap a drm_device, as it
> > the user were to have opened /dev/dri/card0 but to do so anonymously
> > (i.e. for int
Quoting Chris Wilson (2019-11-06 10:26:48)
> Quoting Daniel Vetter (2019-11-06 10:19:50)
> > On Wed, Nov 06, 2019 at 10:07:14AM +0000, Chris Wilson wrote:
> > > Sometimes we need to create a struct file to wrap a drm_device, as it
> > > the user were to have opened
Quoting Daniel Vetter (2019-11-06 10:21:57)
> On Wed, Nov 06, 2019 at 10:07:16AM +0000, Chris Wilson wrote:
> > Currently the drm_prime mmap fallback uses a mock struct file to provide
> > the file pointer into the backend mmap routine. Now that we can create
> > fully fle
Quoting Daniel Vetter (2019-11-06 13:06:26)
> On Wed, Nov 6, 2019 at 11:45 AM Chris Wilson wrote:
> >
> > Quoting Daniel Vetter (2019-11-06 10:21:57)
> > > On Wed, Nov 06, 2019 at 10:07:16AM +, Chris Wilson wrote:
> > > > Currently the drm_prime mmap
Quoting Alexandru-Cosmin Gheorghe (2018-10-29 17:14:43)
> If we want to be able to write drmselftests for non-static core
> functions that are not intended to be used by drivers we need this
> functions to be exported.
>
> This adds a macro that is tied of CONFIG_DRM_DEBUG_SELFTEST, and uses
> tha
As drm now exports a method to create an anonymous struct file around a
drm_device for internal use, make use of it to avoid our horrible hacks.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/Kconfig.debug| 2 +
.../gpu/drm/i915/gem/selftests/huge_pages.c | 2 +-
.../drm
to selftests
Signed-off-by: Chris Wilson
Cc: Daniel Vetter
---
drivers/gpu/drm/Kconfig| 4
drivers/gpu/drm/drm_file.c | 42 ++
include/drm/drm_file.h | 3 +++
3 files changed, 49 insertions(+)
diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/
.
Signed-off-by: Chris Wilson
Cc: Abdiel Janulgue
---
.../drm/i915/gem/selftests/i915_gem_mman.c| 107 ++
1 file changed, 107 insertions(+)
diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c
b/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c
index
Provide a utility function to create a vma corresponding to an mmap() of
our device. And use it to exercise the equivalent of userspace
performing a GTT mmap of our objects.
Signed-off-by: Chris Wilson
Cc: Abdiel Janulgue
---
drivers/gpu/drm/i915/Makefile | 1 +
.../drm/i915
rmine whether or not the EXPORT_SYMBOL_FOR_TESTS_ONLY() takes
effect.
Signed-off-by: Chris Wilson
Cc: Daniel Vetter
---
drivers/gpu/drm/Kconfig | 4
include/drm/drm_util.h | 2 +-
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
to selftests
Signed-off-by: Chris Wilson
Cc: Daniel Vetter
---
drivers/gpu/drm/drm_file.c | 42 ++
include/drm/drm_file.h | 3 +++
2 files changed, 45 insertions(+)
diff --git a/drivers/gpu/drm/drm_file.c b/drivers/gpu/drm/drm_file.c
index ea34bc991
As drm now exports a method to create an anonymous struct file around a
drm_device for internal use, make use of it to avoid our horrible hacks.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/Kconfig.debug| 2 +
.../gpu/drm/i915/gem/selftests/huge_pages.c | 2 +-
.../drm
Like v2, but with more Kconfig hackery so that i915.ko can request
builtin-drm (and drm-selftests) export the symbols it requires for its
selftests.
-Chris
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/
.
Signed-off-by: Chris Wilson
Cc: Abdiel Janulgue
---
.../drm/i915/gem/selftests/i915_gem_mman.c| 107 ++
1 file changed, 107 insertions(+)
diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c
b/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c
index
Provide a utility function to create a vma corresponding to an mmap() of
our device. And use it to exercise the equivalent of userspace
performing a GTT mmap of our objects.
Signed-off-by: Chris Wilson
Cc: Abdiel Janulgue
---
drivers/gpu/drm/i915/Makefile | 1 +
.../drm/i915
Quoting Daniel Vetter (2019-11-07 08:39:24)
> On Wed, Nov 06, 2019 at 02:24:30PM +0000, Chris Wilson wrote:
> > As drm now exports a method to create an anonymous struct file around a
> > drm_device for internal use, make use of it to avoid our horrible hacks.
> >
> >
Quoting Masahiro Yamada (2019-11-08 05:42:33)
> On Fri, Nov 8, 2019 at 2:15 PM Masahiro Yamada
> wrote:
> >
> > The headers in the gem/selftests/, gt/selftests, gvt/, selftests/
> > directories have never been compile-tested, but it would be possible
> > to make them self-contained.
> >
> > This c
Quoting Masahiro Yamada (2019-11-08 05:13:55)
> Since this function is defined in a header file, it should be
> 'static inline' instead of 'static'.
>
> Signed-off-by: Masahiro Yamada
Reviewed-by: Chris Wilson
-Chris
__
truct declarations.
>
> Signed-off-by: Masahiro Yamada
Thanks a lot for doing this,
Reviewed-by: Chris Wilson
-Chris
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
D block is found")
Signed-off-by: Chris Wilson
Cc: Harry Wentland
Cc: Jean Delvare
Cc: Alex Deucher
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c
b/drivers/gpu/
Quoting Daniel Vetter (2019-11-18 10:35:27)
> No in-tree users left.
Fair enough then,
Reviewed-by: Chris Wilson
> Aside, I think mock_dmabuf would be a nice addition to drm
> mock/selftest helpers (we have some already), with an
> EXPORT_SYMBOL_FOR_TESTS_ONLY.
We've als
_only_ have a whole-object-at-a-time interface as we may have
to deal with objects larger than the aperture, or even larger than
system memory. I feel we have a bridge to cross in future...
Reviewed-by: Chris Wilson
-Chris
___
dri-devel mai
Quoting Colin Ian King (2019-12-12 19:53:33)
> Hi,
>
> Static analysis with Coverity has picked up an issue with the following
> commit:
>
> commit 65c29dbb19b2451990c5c477fef7ada3b8218f05
> Author: Chris Wilson
> Date: Wed Dec 11 15:02:04 2019 +
>
>
Quoting Jason Ekstrand (2019-12-14 00:36:19)
> On Fri, Dec 13, 2019 at 5:24 PM Niranjan Vishwanathapura <
> niranjana.vishwanathap...@intel.com> wrote:
>
> On Fri, Dec 13, 2019 at 04:58:42PM -0600, Jason Ekstrand wrote:
> >
> > +/**
> > + * struct drm_i915_gem_vm_bind
>
Quoting Niranjana Vishwanathapura (2019-12-13 21:56:04)
> Shared Virtual Memory (SVM) runtime allocator support allows
> binding a shared virtual address to a buffer object (BO) in the
> device page table through an ioctl call.
>
> Cc: Joonas Lahtinen
> Cc: Jon Bloomfield
> Cc: Daniel Vetter
>
Quoting Niranjana Vishwanathapura (2019-12-13 21:56:05)
> +int i915_gem_object_migrate_region(struct drm_i915_gem_object *obj,
> + u32 *regions, int size)
> +{
> + struct drm_i915_private *dev_priv = to_i915(obj->base.dev);
> + struct intel_context *ce =
gt; are null. Fix this by ensuring to and from are initialized to NULL.
>
> Addresses-Coverity: ("Uninitialised pointer read)"
> Fixes: da42104f589d ("drm/i915: Hold reference to intel_frontbuffer as we
> track activity")
> Signed-off-by: Coli
Mark up the stub drm_of_lvds_get_dual_link_pixel_order() as being a
static inline to avoid a double definition.
Fixes: 6529007522de ("drm: of: Add drm_of_lvds_get_dual_link_pixel_order")
Signed-off-by: Chris Wilson
Cc: Fabrizio Castro
Cc: Laurent Pinchart
---
include/drm/drm_of.h |
tions of the function to be linked when the CONFIG_OF
> option isn't set. Fix it by making the stub static inline.
>
> Fixes: 6529007522de ("drm: of: Add drm_of_lvds_get_dual_link_pixel_order")
> Reported-by: kbuild test robot
> Signed-off-by: Laurent P
Quoting Joonas Lahtinen (2019-12-19 12:46:35)
> Hi Dave & Daniel,
>
> Another -rc, another CI fire due to regressions elsewhere.
>
> Our CI needed the following patches to get machines boot with -rc2:
>
> Revert "devtmpfs: use do_mount() instead of ksys_mount()"
> (commit 5e787db
ing the bridge pointer when that happens.
> >
> > Reported-by: Chris Wilson
> > Fixes: b86d895524ab ("drm/bridge: Add an ->atomic_check() hook")
> > Signed-off-by: Boris Brezillon
>
> Reviewed-by: Laurent Pinchar
Quoting YueHaibing (2020-01-07 13:50:14)
> Fix build error:
> ./drivers/gpu/drm/i915/selftests/i915_random.h: In function
> i915_prandom_u32_max_state:
> ./drivers/gpu/drm/i915/selftests/i915_random.h:48:23: error:
> implicit declaration of function mul_u32_u32; did you mean mul_u64_u32_div?
> [
mul_u64_u32_div?
> [-Werror=implicit-function-declaration]
> return upper_32_bits(mul_u32_u32(prandom_u32_state(state), ep_ro));
>
> Reported-by: Hulk Robot
> Fixes: 7ce5b6850b47 ("drm/i915/selftests: Use mul_u32_u32() for 32b x 32b ->
> 64b result")
> Signed-off-
Quoting Jani Nikula (2020-01-08 09:40:40)
> On Wed, 08 Jan 2020, Joonas Lahtinen wrote:
> > Quoting Wambui Karuga (2020-01-07 17:13:29)
> >> Convert the use of the DRM_DEBUG_KMS() logging macro to the new struct
> >> drm_device based drm_dbg_kms() logging macro in i915/intel_pch.c.
> >>
> >> Sign
Quoting Jani Nikula (2020-01-08 14:44:38)
> On Wed, 08 Jan 2020, Chris Wilson wrote:
> > Quoting Jani Nikula (2020-01-08 09:40:40)
> >> On Wed, 08 Jan 2020, Joonas Lahtinen
> >> wrote:
> >> > Quoting Wambui Karuga (2020-01-07 17:13:29)
> >> &
A straightforward conversion of assignment and checking of the boolean
state flags (allocated, scanned) into non-atomic bitops. The caller
remains responsible for all locking around the drm_mm and its nodes.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/drm_mm.c | 18
with removal or eviction scanning.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/drm_mm.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/drm_mm.c b/drivers/gpu/drm/drm_mm.c
index a9cab5e53731..2a6e34663146 100644
--- a/drivers/gpu/drm/drm_mm.c
If we unwind the active requests, and on resubmission discover that we
intend to preempt the active context with itself, simply skip the ELSP
submission.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/gt/intel_lrc.c | 17 -
1 file changed, 16 insertions(+), 1 deletion
(by signaling) on retirement before freeing the
fence, it can do so in a race-free manner.
See also 0fc89b6802ba ("dma-fence: Simply wrap dma_fence_signal_locked
with dma_fence_signal").
v2: Refactor all 3 enable_signaling paths to use a common function.
Signed-off-by: Chris Wilson
---
dr
In preparation for rearranging the booleans into a flags field, ensure
all the current users are using the inline helpers and not directly
accessing the members.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/drm_mm.c | 19 ---
.../gpu/drm/i915/gem
tracepoint in the existing spot.
Signed-off-by: Chris Wilson
Cc: Tvrtko Ursulin
---
drivers/dma-buf/dma-fence.c | 78 +
1 file changed, 35 insertions(+), 43 deletions(-)
diff --git a/drivers/dma-buf/dma-fence.c b/drivers/dma-buf/dma-fence.c
index 2c136aee3e79..0
Quoting Tvrtko Ursulin (2019-10-04 10:15:20)
>
> On 03/10/2019 22:01, Chris Wilson wrote:
> > A few callers need to serialise the destruction of their drm_mm_node and
> > ensure it is removed from the drm_mm before freeing. However, to be
> > completely sure that any acces
Quoting Chris Wilson (2019-10-04 12:07:10)
> Quoting Tvrtko Ursulin (2019-10-04 10:15:20)
> >
> > On 03/10/2019 22:01, Chris Wilson wrote:
> > > A few callers need to serialise the destruction of their drm_mm_node and
> > > ensure it is removed from the drm_
Quoting Zbigniew Kempczyński (2019-10-04 13:16:52)
> Remove dead code, likely overseened during review process.
Hint: It's not dead.
-Chris
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-deve
as passed to the GPU instruction, negative used is invalid.
Then it is used as an offset into a memblock, where a negative offset
would be very bad.
Reviewed-by: Chris Wilson
-Chris
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoting Chris Wilson (2019-10-04 15:08:57)
> Quoting Dan Carpenter (2019-10-04 11:22:51)
> > The "used" variables here come from the user in the ioctl and it can be
> > negative. It could result in an out of bounds write.
> >
> > Signed-off-by: Dan Carpent
340044388 320 387129738 gpu/drm/i915/gt/intel_reset.o
>
> After:
>textdata bss dec hex filename
> 335284548 320 3839695fc gpu/drm/i915/gt/intel_reset.o
>
> (gcc version 9.2.1, amd64)
>
> Signed-off-by: Colin Ian King
Reviewed-by: Chris Wilson
-Chris
Quoting Chris Wilson (2019-10-07 17:22:52)
> Quoting Colin King (2019-10-07 16:41:51)
> > From: Colin Ian King
> >
> > Don't populate the array hw_engine_mask on the stack but instead make it
> > static. Makes the object code smaller by 316 bytes.
> >
&
Quoting Colin King (2019-10-09 10:39:35)
> From: Colin Ian King
>
> An earlier commit removed any error assignments to err and we
> are now left with a zero assignment to err and a check that is
> always false. Clean this up by removing the redundant variable
> err and the error check.
Oh, we ad
void the null pointer
> dereference.
>
> Addresses-Coverity: ("Dereference after null check")
> Fixes: 50d16d44cce4 ("drm/i915/selftests: Exercise context switching in
> parallel")
> Signed-off-by: Colin Ian King
Reviewed-by: Chris Wilson
-Chris
Quoting Sebastian Andrzej Siewior (2019-10-10 17:06:40)
> The locks (active.lock and rq->lock) need to be taken with disabled
> interrupts. This is done in i915_request_retire() by disabling the
> interrupts independently of the locks itself.
> While local_irq_disable()+spin_lock() equals spin_lock
Quoting Sebastian Andrzej Siewior (2019-10-10 19:26:10)
> On 2019-10-10 19:11:27 [+0100], Chris Wilson wrote:
> > > --- a/drivers/gpu/drm/i915/i915_request.c
> > > +++ b/drivers/gpu/drm/i915/i915_request.c
> > > @@ -251,15 +251,13 @@ static boo
n_lock() equals spin_lock_irq() on vanilla
> it does not on PREEMPT_RT.
> Chris Wilson confirmed that local_irq_disable() was just introduced as
> an optimisation to avoid enabling/disabling interrupts during
> lock/unlock combo.
>
> Enable/disable interrupts as part of the locking i
in a dma-fence-chain.
Report a NULL fence and success if the seqno has already been signaled.
Signed-off-by: Chris Wilson
---
drivers/dma-buf/dma-fence-chain.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/dma-buf/dma-fence-chain.c
b/drivers/dma-buf/dma-fence-chain.c
index
Inside dma-fence-chain, we use a cmpxchg on an RCU-protected pointer. To
avoid the sparse warning for using the RCU pointer directly, we have to
cast away the __rcu annotation. However, we don't need to use void*
everywhere and can stick to the dma_fence*.
Signed-off-by: Chris W
A few very simple testcases to exercise the dma-fence-chain API.
Signed-off-by: Chris Wilson
---
drivers/dma-buf/Makefile | 3 +-
drivers/dma-buf/selftests.h | 1 +
drivers/dma-buf/st-dma-fence-chain.c | 713 +++
3 files changed, 716 insertions
need to trade off having to perform
the search again after ERESTARTSYS, which again may form a trap of
making no forward progress.)
Reported-by: Zbigniew Kempczyński
Signed-off-by: Chris Wilson
Cc: Zbigniew Kempczyński
Cc: Joonas Lahtinen
---
drivers/gpu/drm/drm_mm.c | 8 +++-
1 file
here was making
> dev->open_count atomic, which was done in
>
> commit 7e13ad896484a0165a68197a2e64091ea28c9602
> Author: Chris Wilson
> Date: Fri Jan 24 13:01:07 2020 +
>
> drm: Avoid drm_global_mutex for simple inc/dec of dev->open_count
>
> v2:
>
ually push this stuff correctly, don't unlock twice (Chris)
> - Fix typo on commit message, plus explain why BKL = drm_global_mutex
> (Sam)
>
> Cc: Sam Ravnborg
> Cc: Chris Wilson
> Signed-off-by: Daniel Vetter
Reviewed-by: Chris Wilson
-Chris
Quoting Andi Shyti (2020-02-11 22:56:44)
> Hi Chris,
>
> On Fri, Feb 07, 2020 at 03:17:20PM +0000, Chris Wilson wrote:
> > We try hard to select a suitable hole in the drm_mm first time. But if
> > that is unsuccessful, we then have to look at neighbouring nodes, and
> &g
Quoting Jani Nikula (2020-02-14 06:36:15)
> On Thu, 13 Feb 2020, Nathan Chancellor wrote:
> > A recent commit in clang added -Wtautological-compare to -Wall, which is
> > enabled for i915 after -Wtautological-compare is disabled for the rest
> > of the kernel so we see the following warning on x86
Quoting Alex Deucher (2020-02-20 02:52:32)
> On Wed, Feb 19, 2020 at 7:42 PM Paul E. McKenney wrote:
> >
> > Hello!
> >
> > A box with GCC 4.8.3 compiler didn't like drm_dp_mst_topology.c. The
> > following (lightly tested) patch makes it happy and seems OK for newer
> > compilers as well.
> >
>
. This should help us to more quickly and clearly
identify lost races.
Signed-off-by: Chris Wilson
Cc: Daniel Vetter
---
include/linux/dma-fence.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/include/linux/dma-fence.h b/include/linux/dma-fence.h
index 3347c54f3a87..2805edd74738 100644
t;f21613797bae98773"
>
> v3-v4: none
>
> Signed-off-by: Mika Kuoppala
> Signed-off-by: Prathap Kumar Valsan
> Signed-off-by: Akeem G Abodunrin
> Cc: Chris Wilson
> Cc: Balestrieri Francesco
> Cc: Bloomfield Jon
> Cc: Dutt Sudeep
Reviewed-by: Chris
desc_count);
> +
> + for (i = 0; i < bv->max_primitives; i++)
> + gen7_emit_media_object(&cmds, i);
> +
> + batch_add(&cmds, MI_BATCH_BUFFER_END);
> +}
I can't comment on t
Quoting Daniel Vetter (2020-02-21 15:17:24)
> On Fri, Feb 21, 2020 at 3:38 PM Chris Wilson wrote:
> > dma_fence_get_rcu() is used to acquire a reference to under a dma-fence
> > under racey conditions -- a perfect recipe for a disaster. As we know
> > the caller may be handl
Quoting Chris Wilson (2020-02-21 15:23:38)
> Quoting Daniel Vetter (2020-02-21 15:17:24)
> > On Fri, Feb 21, 2020 at 3:38 PM Chris Wilson
> > wrote:
> > > dma_fence_get_rcu() is used to acquire a reference to under a dma-fence
> > > under racey conditions -- a
Quoting Daniel Vetter (2020-02-21 21:02:30)
> For two reasons:
>
> - The driver core clears this already for us after we're unloaded in
> __device_release_driver().
Even if we abort before loading?
History notes that i915_pci_remove was called with a stale pointer on
error.
-Chris
> Signed-off-by: Colin Ian King
Reviewed-by: Chris Wilson
-Chris
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoting Jani Nikula (2020-02-15 18:33:09)
> On Sat, 15 Feb 2020, Emmanuel Vadot wrote:
> > From: Emmanuel Vadot
> >
> > Contributors for this file are :
> > Chris Wilson
> > Denis Efremov
> > Jani Nikula
> > Maxime Ripard
> > Nora
Quoting Pankaj Bharadiya (2020-02-25 13:47:00)
> Now that we have struct drm_device based drm_WARN, introduce struct
> drm_i915_private based i915_MISSING_CASE macro which uses drm_WARN so
> that device specific information will also get printed in backtrace.
>
> i915_MISSING_CASE macro should be
Quoting Gustavo A. R. Silva (2020-02-25 14:03:47)
> The current codebase makes use of the zero-length array language
> extension to the C90 standard, but the preferred mechanism to declare
> variable-length types such as these ones is a flexible array member[1][2],
> introduced in C99:
I remember
Rather than put sensitive, and often voluminous, user details into a
global dmesg, report the error and debug messages directly back to the
user via the kernel tracing mechanism.
Signed-off-by: Chris Wilson
Cc: Steven Rostedt (VMware)
---
drivers/gpu/drm/i915/gem/i915_gem_context.c | 104
encapsulating the trace ringbuffer into a struct
file that can be opened via the tracefs, and so with a couple of minor
tweaks can provide the same access via an anonymous inode.
Signed-off-by: Chris Wilson
Cc: Steven Rostedt (VMware)
---
include/linux/trace.h | 4 ++
kernel/trace/trace.c | 142
Quoting Lionel Landwerlin (2020-03-01 16:27:24)
> On 01/03/2020 17:52, Chris Wilson wrote:
> > Rather than put sensitive, and often voluminous, user details into a
> > global dmesg, report the error and debug messages directly back to the
> > user via the kernel tracing mech
Quoting Steven Rostedt (2020-03-01 18:18:16)
> On Sun, 1 Mar 2020 15:52:47 +
> Chris Wilson wrote:
>
> > To facilitate construction of per-client event ringbuffers, in
> > particular for a per-client debug and error report log, it would be
> > extremely useful
inuity.
I suspect it was me, thanks for fixing it!
> Fixes: 6349120ddcbf ("drm: Move EXPORT_SYMBOL_FOR_TESTS_ONLY under a separate
> Kconfig")
> Signed-off-by: Randy Dunlap
> Cc: Chris Wilson
> Cc: Daniel Vetter
Reviewed-by: Chris Wilson
-Chris
___
Pull the drm_pci_agp_init() underneath the legacy ifdeffry alongside its
only caller.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/drm_pci.c | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/gpu/drm/drm_pci.c b/drivers/gpu/drm/drm_pci.c
/0x120
[ 1715.900291] drm_ioctl+0x297/0x4c7
[ 1715.900316] ksys_ioctl+0x89/0xb0
[ 1715.900340] __x64_sys_ioctl+0x42/0x60
[ 1715.900363] do_syscall_64+0x6e/0x2c0
[ 1715.900388] entry_SYSCALL_64_after_hwframe+0x44/0xa9
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/drm_gem.c | 2 +-
1 file
[ 121.107464] ksys_ioctl+0x89/0xb0
[ 121.107489] __x64_sys_ioctl+0x42/0x60
[ 121.107511] do_syscall_64+0x6e/0x2c0
[ 121.107535] entry_SYSCALL_64_after_hwframe+0x44/0xa9
Signed-off-by: Chris Wilson
---
include/drm/drm_mm.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
being used correctly.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/Kconfig | 13 +++
drivers/gpu/drm/drm_mm.c | 54
drivers/gpu/drm/i915/gt/gen6_ppgtt.c | 2 --
drivers/gpu/drm/i915/i915_vma.c | 17 +++--
include/drm/drm_mm.h
being used correctly.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/Kconfig | 13 +++
drivers/gpu/drm/drm_mm.c | 55
drivers/gpu/drm/i915/gt/gen6_ppgtt.c | 2 -
drivers/gpu/drm/i915/i915_vma.c | 17 +++--
include/drm/drm_mm.h
being used correctly.
Signed-off-by: Chris Wilson
---
And now switch on for CI. Expect failure from unmarked drm_mm_nodes.
---
drivers/gpu/drm/Kconfig | 13 +++
drivers/gpu/drm/drm_mm.c | 113 +++
drivers/gpu/drm/i915/Kconfig.debug | 1 +
drivers
O: We may want to consider calling drm_mode_config_init()
> unconditionally to avoid similar issues elsewhere...
>
> Fixes: 74d2aacbe840 ("drm: Validate encoder->possible_clones")
> Signed-off-by: Ville Syrjälä
Reviewed-by: Chris Wilson
-Chris
_
Quoting Arnd Bergmann (2020-01-10 15:17:54)
> Splitting up the i915_gem_gtt caused a build failure in some configurations:
>
> drivers/gpu/drm/i915/gt/intel_ggtt.c: In function 'ggtt_restore_mappings':
> drivers/gpu/drm/i915/gt/intel_ggtt.c:1239:3: error: implicit declaration of
> function 'wbinv
Quoting Wambui Karuga (2020-01-13 11:10:25)
> fn(...) {
> ...
> struct intel_engine_cs *E = ...;
> +struct drm_i915_private *dev_priv = E->i915;
No new dev_priv.
There should be no reason for drm_dbg here, as the rest of the debug is
behind ENGINE_TRACE and so the vestigial debug should be moved
Quoting Jani Nikula (2020-01-14 11:43:22)
>
> Hi Dave & Daniel -
>
> Last batch for v5.6, slightly delayed I'm afraid.
I'd like to close https://gitlab.freedesktop.org/drm/intel/issues/738
for 5.6, otherwise we'll have some more nasty emails from bewildered
users/devs.
https://patchwork.freedes
tch buffer with dedicated HW
> context to the GPU with ring allocation for each context switching.
>
> Signed-off-by: Mika Kuoppala
> Signed-off-by: Prathap Kumar Valsan
> Signed-off-by: Akeem G Abodunrin
> Cc: Chris Wilson
> Cc: Balestrieri Francesco
> Cc: Bloomfield Jon
>
Quoting Sean Paul (2020-01-14 17:21:43)
> From: Sean Paul
>
> This patch uses a ring_buffer to keep a "flight recorder" (name credit Weston)
> of DRM logs for a specified set of debug categories. The user writes a
> bitmask of debug categories to the "trace_mask" node and can read log
> messages
Quoting Sean Paul (2020-01-15 13:41:58)
> On Wed, Jan 15, 2020 at 10:36:36AM +0000, Chris Wilson wrote:
> > Quoting Sean Paul (2020-01-14 17:21:43)
> > > From: Sean Paul
> > >
> > > This patch uses a ring_buffer to keep a "flight recorder" (name
Quoting Sean Paul (2020-01-15 14:21:18)
> On Wed, Jan 15, 2020 at 02:01:19PM +0000, Chris Wilson wrote:
> > Quoting Sean Paul (2020-01-15 13:41:58)
> > > On Wed, Jan 15, 2020 at 10:36:36AM +, Chris Wilson wrote:
> > > > Quoting Sean Paul (2020-01-14 17:21
takes a demonstrable amount to time
to flush all the cachelines, clflush is still preferred over a
system-wide wbinvd as the latter has unpredictable latencies affecting
the whole system not just the local task.
Reported-by: David Laight
Signed-off-by: Chris Wilson
Cc: David Laight
---
drivers
301 - 400 of 3785 matches
Mail list logo
