Re: [RFC PATCH v3 1/6] drm/doc: Color Management and HDR10 RFC

2021-08-02 Thread Brian Starkey
Hi, Thanks for having a stab at this, it's a massive complex topic to solve. Do you have the the HTML rendered somewhere for convenience? On Fri, Jul 30, 2021 at 04:41:29PM -0400, Harry Wentland wrote: > Use the new DRM RFC doc section to capture the RFC previously only > described in the cover

Re: [RFC PATCH v3 1/6] drm/doc: Color Management and HDR10 RFC

2021-08-16 Thread Brian Starkey
On Fri, Aug 13, 2021 at 10:42:12AM +0530, Sharma, Shashank wrote: > Hello Brian, > (+Uma in cc) > > Thanks for your comments, Let me try to fill-in for Harry to keep the design > discussion going. Please find my comments inline. > > On 8/2/2021 10:00 PM, Brian Starke

Re: [PATCH] drm/rockchip: Require the YTR modifier for AFBC

2021-02-23 Thread Brian Starkey
Hi, On Tue, Feb 23, 2021 at 02:27:11PM +, Daniel Stone wrote: > Mark, or others from Rockchip, can you please: > - explain if there is a way to enable/disable the YTR transform in the > VOP's AFBC decoder, similar to the split-block control bit? > - ack this patch which correctly declares that

Re: [PATCH] drm/rockchip: Require the YTR modifier for AFBC

2021-02-23 Thread Brian Starkey
On Tue, Feb 23, 2021 at 03:29:13PM +, Daniel Stone wrote: > On Tue, 23 Feb 2021 at 14:58, Brian Starkey wrote: > > On Tue, Feb 23, 2021 at 02:27:11PM +, Daniel Stone wrote: > > > Mark, or others from Rockchip, can you please: > > > - explain if there is a wa

Re: [PATCH] drm/rockchip: Require the YTR modifier for AFBC

2021-02-23 Thread Brian Starkey
On Tue, Feb 23, 2021 at 05:10:16PM +, Alyssa Rosenzweig wrote: > > If YTR can't be turned off, then according to the AFBC spec - correct. > > There is no public AFBC spec, so I'm not sure how to respond to this. > > > If the hardware allows it to be configured to use YTR with other > > compon

Re: [PATCH] drm/rockchip: Require the YTR modifier for AFBC

2021-02-24 Thread Brian Starkey
On Wed, Feb 24, 2021 at 04:06:05PM +, Daniel Stone wrote: > Android punted on that from the beginning and just uses > XBGR for everything ... so it's not really a matter of dumb vs. smart > userspace, just equally dumb userspaces which disagree with each > other. ;) ...apart from HAL_PIXEL_FOR

Re: [PATCH] drm/komeda: Fix off-by-1 when with readback conn due to rounding

2021-03-09 Thread Brian Starkey
Hi Carsten, (+James for komeda) Thanks for typing this up. On Fri, Mar 05, 2021 at 04:38:53PM +, carsten.haitz...@foss.arm.com wrote: > From: Carsten Haitzler > > When setting up a readback conenctor that writes data back to memory s/readback conenctor/writeback connector/ (similar in the

Re: [PATCH] drm/komeda: Fix off-by-1 when with readback conn due to rounding

2021-03-12 Thread Brian Starkey
is in-keeping with the rest of the file, so meh :-) > + u32 ctrl = LW_TRC | L_EN | LW_OFM; > + u32 mask = LW_TRC | L_EN | LW_OFM | LW_TBU_EN; If you were aiming for matching register order, this should be: L_EN | LW_TRC | LW_OFM | LW_TBU_EN I think it'd be nice to have

Re: [PATCH v4] Add power/gpu_frequency tracepoint.

2020-12-02 Thread Brian Starkey
Hi Peiyong, On Mon, Nov 30, 2020 at 02:33:59PM -0800, Peiyong Lin wrote: > On Tue, Nov 17, 2020 at 1:31 PM Peiyong Lin wrote: > > > > On Thu, Oct 22, 2020 at 10:34 AM Peiyong Lin wrote: > > > > > > Historically there is no common trace event for GPU frequency, in > > > downstream Android each di

Re: [PATCH] drm: check drm_format_info hsub and vsub to avoid divide by zero

2021-10-29 Thread Brian Starkey
Hi, On Fri, Oct 29, 2021 at 09:15:28AM -0400, George Kennedy wrote: > > Asking if you have any input on how to deal with hsub and vsub = zero? That's just a straight mistake on those formats - they should be 1. My bad for not spotting it in review. On the one hand, having formats in this table

Re: [PATCH] drm/arm/mali: potential dereference of null pointer

2021-12-14 Thread Brian Starkey
t; failure of alloc. > > Fixes: 8cbc5caf36ef ("drm: mali-dp: Add writeback connector") > Signed-off-by: Jiasheng Jiang > --- Reviewed-by: Brian Starkey > drivers/gpu/drm/arm/malidp_mw.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/

Re: [PATCH] drm: mali-dp: potential dereference of null pointer

2021-12-14 Thread Brian Starkey
Hi, On Tue, Dec 14, 2021 at 06:08:37PM +0800, Jiasheng Jiang wrote: > The return value of kzalloc() needs to be checked. > To avoid use of null pointer '&state->base' in case of the > failure of alloc. > > Fixes: 99665d072183 ("drm: mali-dp: add malidp_crtc_state struct") > Signed-off-by: Jiashen

[PATCH] drm/i2c: tda998x: don't register the connector

2016-08-08 Thread Brian Starkey
Hi, On Mon, Jul 25, 2016 at 05:08:21PM +0200, Daniel Vetter wrote: >On Mon, Jul 25, 2016 at 01:54:06PM +0100, Brian Starkey wrote: >> Hi Russell, >> >> On Mon, Jul 25, 2016 at 01:25:04PM +0100, Russell King - ARM Linux wrote: >> > On Mon, Jul 25, 2016 at 11:55:4

Re: [PATCH] drm/komeda: Added AFBC support for komeda driver

2019-05-24 Thread Brian Starkey
Hi, On Tue, May 21, 2019 at 09:45:58AM +0100, james qian wang (Arm Technology China) wrote: > On Thu, May 16, 2019 at 09:57:49PM +0800, Ayan Halder wrote: > > On Thu, Apr 04, 2019 at 12:06:14PM +0100, james qian wang (Arm Technology > > China) wrote: > > > > > > +static int > > > +komeda_fb_af

Re: [PATCH] drm/komeda: Added AFBC support for komeda driver

2019-05-28 Thread Brian Starkey
Hi James, On Mon, May 27, 2019 at 07:51:18AM +0100, james qian wang (Arm Technology China) wrote: > Hi Brian & Ville: > > komed has a format+modifier check before the fb size check. > and for komeda_fb_create, the first step is do the format+modifier > check, the size check is the furthur check

Re: [PATCH 13/14] staging: android: ion: Do not sync CPU cache on map/unmap

2019-01-21 Thread Brian Starkey
16/19 4:54 PM, Liam Mark wrote: > >>> On Wed, 16 Jan 2019, Andrew F. Davis wrote: > >>> > >>>> On 1/16/19 9:19 AM, Brian Starkey wrote: > >>>>> Hi :-) > >>>>> > >>>>> On Tue, Jan 15, 2019 at 12:40:16PM -0600,

Re: [PATCH] drm/doc: Make igts for cross-driver stuff mandatory

2019-01-21 Thread Brian Starkey
Hi Daniel, On Thu, Jan 17, 2019 at 12:52:16PM +0100, Daniel Vetter wrote: > On Thu, Jan 17, 2019 at 12:38 PM Liviu Dudau wrote: > > > > On Wed, Jan 16, 2019 at 05:39:03PM +0100, Daniel Vetter wrote: > > > Compared to the RFC[1] no changes to the patch itself, but igt moved > > > forward a lot: >

Re: [PATCH 4/4] staging: android: ion: Support for mapping with dma mapping attributes

2019-01-21 Thread Brian Starkey
Hi Liam, On Fri, Jan 18, 2019 at 10:37:47AM -0800, Liam Mark wrote: > Add support for configuring dma mapping attributes when mapping > and unmapping memory through dma_buf_map_attachment and > dma_buf_unmap_attachment. > > For example this will allow ION clients to skip cache maintenance, by > u

Re: [PATCH] drm/doc: Make igts for cross-driver stuff mandatory

2019-01-22 Thread Brian Starkey
Hi, On Tue, Jan 22, 2019 at 09:53:20AM +0100, Daniel Vetter wrote: > On Mon, Jan 21, 2019 at 6:21 PM Daniel Vetter wrote: > > > > On Mon, Jan 21, 2019 at 12:54 PM Brian Starkey > > wrote: > > > > > > Hi Daniel, > > > > > > On T

Re: [PATCH] drm/doc: Make igts for cross-driver stuff mandatory

2019-01-22 Thread Brian Starkey
On Tue, Jan 22, 2019 at 03:03:59PM +0100, Daniel Vetter wrote: > On Tue, Jan 22, 2019 at 2:27 PM Brian Starkey wrote: [snip] > > > > That doesn't really address my issue, but no matter. I guess I'm > > having a hard time separating the existing igts from _new

Re: [igt-dev] [PATCH] drm/doc: Make igts for cross-driver stuff mandatory

2019-01-23 Thread Brian Starkey
On Tue, Jan 22, 2019 at 08:19:10PM +0100, Daniel Vetter wrote: > On Tue, Jan 22, 2019 at 8:00 PM Wentland, Harry > wrote: > > On 2019-01-16 11:39 a.m., Daniel Vetter wrote: > > > Compared to the RFC[1] no changes to the patch itself, but igt moved > > > forward a lot: > > > > > > - gitlab CI buil

Re: [igt-dev] [PATCH] drm/doc: Make igts for cross-driver stuff mandatory

2019-01-23 Thread Brian Starkey
On Tue, Jan 22, 2019 at 02:53:37PM -0500, Sean Paul wrote: > On Tue, Jan 22, 2019 at 07:42:30PM +, Wentland, Harry wrote: > > > > > > On 2019-01-22 2:19 p.m., Daniel Vetter wrote: > > > On Tue, Jan 22, 2019 at 8:00 PM Wentland, Harry > > > wrote: > > >> On 2019-01-16 11:39 a.m., Daniel Vett

Re: [PATCH 13/14] staging: android: ion: Do not sync CPU cache on map/unmap

2019-01-23 Thread Brian Starkey
since he has been one of the > > core guys who shaped up dma-buf as it is today. > > > > On Tue, 22 Jan 2019 at 02:51, Andrew F. Davis wrote: > >> > >> On 1/21/19 5:22 AM, Brian Starkey wrote: > > [snip] > > >>> > >>> A

Re: [PATCH] staging: android: ion: Allocate from heap ID directly without mask

2019-01-24 Thread Brian Starkey
Hi Andrew, On Wed, Jan 23, 2019 at 01:28:35PM -0600, Andrew F. Davis wrote: > Previously the heap to allocate from was selected by a mask of allowed > heap types. This may have been done as a primitive form of constraint > solving, the first heap type that matched any set bit of the heap mask > wa

Re: [PATCH 13/14] staging: android: ion: Do not sync CPU cache on map/unmap

2019-01-24 Thread Brian Starkey
On Thu, Jan 24, 2019 at 10:04:46AM -0600, Andrew F. Davis wrote: > On 1/23/19 11:11 AM, Brian Starkey wrote: [snip] > > I'm very new to all this, so any pointers to history in this area are > appreciated. > [snip] > > > In case you didn't come across it

Re: [PATCH] staging: android: ion: Allocate from heap ID directly without mask

2019-01-24 Thread Brian Starkey
On Thu, Jan 24, 2019 at 10:12:10AM -0600, Andrew F. Davis wrote: > On 1/24/19 9:24 AM, Brian Starkey wrote: [snip] > > > > What do you think about renaming ion_allocation_data.unused to heap_id > > and adding a flag instead? It's adding cruft to a staging API, b

Re: [PATCH 0/5] tda998x updates

2019-01-25 Thread Brian Starkey
Hi Russell, On Fri, Jan 25, 2019 at 09:40:38AM +, Russell King - ARM Linux admin wrote: > Hi, > > This series adds support for programming the SPD and vendor infoframes. > > It also adds support for pixel repeated modes - we were not rejecting > these modes, but we also didn't have the imple

Re: [PATCH 0/5] tda998x updates

2019-01-25 Thread Brian Starkey
ion. > > On Fri, Jan 25, 2019 at 11:45:10AM +0000, Brian Starkey wrote: > > Hi Russell, > > > > On Fri, Jan 25, 2019 at 09:40:38AM +, Russell King - ARM Linux admin > > wrote: > > > Hi, > > > > > > This series adds support for pro

Re: [PATCH] drm/doc: Make igts for cross-driver stuff strongly suggested

2019-01-29 Thread Brian Starkey
gt; what can be tested (Harry, Eric, Sean, ...). > > 1: https://patchwork.kernel.org/patch/10648851/ > Cc: Petri Latvala > Cc: Arkadiusz Hiler > Cc: Liviu Dudau > Cc: Sean Paul > Cc: Eric Anholt > Cc: Alex Deucher > Cc: Dave Airlie > Cc: Daniel Stone > Cc: &

Re: [Intel-gfx] [v7 1/2] drm: Add colorspace connector property

2019-01-29 Thread Brian Starkey
Hi Uma, On Tue, Jan 29, 2019 at 01:30:43PM +, Shankar, Uma wrote: > > > >-Original Message- > >From: Maarten Lankhorst [mailto:maarten.lankho...@linux.intel.com] > >Sent: Tuesday, January 29, 2019 5:54 PM > >To: Shankar, Uma ; intel-...@lists.freedesktop.org; > >dri-devel@lists.freed

Re: [Intel-gfx] [PATCH] drm: Constify drm_color_lut_check()

2019-01-29 Thread Brian Starkey
On Tue, Jan 29, 2019 at 07:06:09PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > drm_color_lut_check() doens't modify the passed in blob so s/doens't/doesn't/ Otherwise, LGTM. Reviewed-by: > let's make it const. > > Also s/uint32_y/u32/ while at it. > > Cc: Matt Roper > Signed-off

Re: [PATCH 2/4] staging: android: ion: Restrict cache maintenance to dma mapped memory

2019-01-30 Thread Brian Starkey
s above make ION align > > more with the way the DMA APIs are used. Basically when the buffer is not > > dma-mapped the CPU doesn't need to do any CMOs to access the buffer (and > > ION ensures not CMOs are applied) but if the CPU does want to access the > > buff

Re: [PATCH 3/5] drm/i2c: tda998x: add support for writing SPD

2019-01-30 Thread Brian Starkey
Hi Russell, These did eventually reach me on Saturday evening. On Fri, Jan 25, 2019 at 09:43:19AM +, Russell King wrote: > Add support for writing the SPD infoframe to the TDA998x. Identify us > as "Generic" vendor "PC" product, and as "PC general" source device > information. > > Signed-of

Re: [PATCH 5/5] drm/i2c: tda998x: improve correctness of quantisation range

2019-01-30 Thread Brian Starkey
Hi Russell, On Fri, Jan 25, 2019 at 09:43:29AM +, Russell King wrote: > CEA-861 says: "A Source shall not send a non-zero Q value that does > not correspond to the default RGB Quantization Range for the > transmitted Picture unless the Sink indicates support for the Q bit > in a Video Capabili

Re: [PATCH 4/5] drm/i2c: tda998x: add vendor specific infoframe support

2019-01-30 Thread Brian Starkey
On Fri, Jan 25, 2019 at 09:43:24AM +, Russell King wrote: > Add support for the vendor specific infoframe. > > Signed-off-by: Russell King LGTM. Reviewed-by: Brian Starkey > --- > drivers/gpu/drm/i2c/tda998x_drv.c | 14 ++ > 1 file changed, 14 insertions(+)

Re: [PATCH 3/5] drm/i2c: tda998x: add support for writing SPD

2019-01-30 Thread Brian Starkey
On Wed, Jan 30, 2019 at 05:23:40PM +, Russell King - ARM Linux admin wrote: > On Wed, Jan 30, 2019 at 03:41:04PM +0000, Brian Starkey wrote: > > Hi Russell, > > > > These did eventually reach me on Saturday evening. > > > > On Fri, Jan 25, 2019 at 09:

Re: [PATCH 5/5] drm/i2c: tda998x: improve correctness of quantisation range

2019-01-31 Thread Brian Starkey
On Wed, Jan 30, 2019 at 06:18:44PM +, Russell King - ARM Linux admin wrote: > On Wed, Jan 30, 2019 at 03:53:04PM +0000, Brian Starkey wrote: > > Hi Russell, > > > > On Fri, Jan 25, 2019 at 09:43:29AM +, Russell King wrote: > > > > >

Re: [PATCH v2 1/2] drm: Add color management LUT validation helper (v2)

2018-12-21 Thread Brian Starkey
ust be > equal. Let's add a helper function that drivers can use to test that a > userspace-provided LUT is valid and doesn't violate hardware > requirements. > > v2: > - Combine into a single helper that just takes a bitmask of the tests >to apply. (Bri

Re: [PATCH v4 2/3] drm: Add CRTC background color property (v4)

2019-01-07 Thread Brian Starkey
rnal representation of the u64, it can >still be confusing to look at code that uses 'rgba' terminology, but > stores values with argb ordering. (Ville) > > v4: > - Drop the bgcolor_changed flag. (Ville, Brian Starkey) > - Clarify in kerneldoc that background

Re: [PATCH 1/7] drm/komeda: Add d71_enum_resources and d71_cleanup

2019-01-07 Thread Brian Starkey
Hi James, A few minor comments. On Mon, Dec 24, 2018 at 08:58:46AM +, james qian wang (Arm Technology China) wrote: > D71 consists of a number of Register Blocks, every Block controls a > specific HW function, every block has a common block_header to represent > its type and pipeline informa

Re: Expose more EDID fields to userspace

2019-01-07 Thread Brian Starkey
On Mon, Jan 07, 2019 at 07:57:54AM -0800, Keith Packard wrote: > Daniel Vetter writes: > > > Best to pull in some other compositor people and get them to agree. From a > > kernel pov I'm fine with whatever userspace preferes. > > Hrm. It would be good to have everyone using the same interpretati

Re: [v6 0/2] Add Colorspace connector property interface

2019-01-08 Thread Brian Starkey
Hi Uma, On Thu, Dec 27, 2018 at 11:22:36PM +0530, Uma Shankar wrote: > This patch series creates a new connector property to program > colorspace to sink devices. Modern sink devices support more > than 1 type of colorspace like 601, 709, BT2020 etc. This helps > to switch based on content type wh

Re: [v6 1/2] drm: Add colorspace connector property

2019-01-08 Thread Brian Starkey
Hi Uma, On Thu, Dec 27, 2018 at 11:22:37PM +0530, Uma Shankar wrote: > This patch adds a colorspace connector property, enabling > userspace to switch to various supported colorspaces. > This will help enable BT2020 along with other colorspaces. > > v2: Addressed Maarten and Ville's review commen

Re: [RFC AFBC 03/12] drm/afbc: Add AFBC modifier usage documentation

2019-01-14 Thread Brian Starkey
Hi Jani, On Mon, Jan 14, 2019 at 02:23:46PM +0200, Jani Nikula wrote: > On Fri, 11 Jan 2019, Liviu Dudau wrote: > > On Thu, Jan 03, 2019 at 05:44:26PM -0300, Ezequiel Garcia wrote: > >> Hi Liviu, > >> > >> On Mon, 2018-12-03 at 11:31 +0000, Ayan Hald

Re: [PATCH] drm/fourcc: Add modifier defininitions for AFBC 1.3

2019-01-15 Thread Brian Starkey
-by on any patches that you send, but otherwise this is: Reviewed-by: Brian Starkey Thanks! -Brian > --- > include/uapi/drm/drm_fourcc.h | 23 +++ > 1 file changed, 23 insertions(+) > > diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.

Re: [PATCH 13/14] staging: android: ion: Do not sync CPU cache on map/unmap

2019-01-16 Thread Brian Starkey
Hi :-) On Tue, Jan 15, 2019 at 12:40:16PM -0600, Andrew F. Davis wrote: > On 1/15/19 12:38 PM, Andrew F. Davis wrote: > > On 1/15/19 11:45 AM, Liam Mark wrote: > >> On Tue, 15 Jan 2019, Andrew F. Davis wrote: > >> > >>> On 1/14/19 11:13 AM, Liam Mark wrote: > On Fri, 11 Jan 2019, Andrew F. Da

Re: [PATCH 11/14] staging: android: ion: Allow heap name to be null

2019-01-16 Thread Brian Starkey
Hi Andrew, On Fri, Jan 11, 2019 at 12:05:20PM -0600, Andrew F. Davis wrote: > The heap name can be used for debugging but otherwise does not seem > to be required and no other part of the code will fail if left NULL > except here. We can make it required and check for it at some point, > for now l

Re: [PATCH 1/2] drm/fourcc: add ARM tiled format modifier

2019-02-14 Thread Brian Starkey
Hi, On Wed, Feb 06, 2019 at 09:14:56PM +0800, Qiang Yu wrote: > Signed-off-by: Qiang Yu > --- > include/uapi/drm/drm_fourcc.h | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h > index 0b44260a5ee9..953b59eb3fd2 100644

Re: [PATCH 1/2] drm/fourcc: add ARM tiled format modifier

2019-02-15 Thread Brian Starkey
On Fri, Feb 15, 2019 at 09:48:47AM +0800, Qiang Yu wrote: > On Thu, Feb 14, 2019 at 11:27 PM Brian Starkey wrote: > > > > Hi, > > > > On Wed, Feb 06, 2019 at 09:14:56PM +0800, Qiang Yu wrote: > > > Signed-off-by: Qiang Yu > > > --- > > > inc

Re: [PATCH v2] staging: android: ion: Allocate from heap ID directly without mask

2019-02-15 Thread Brian Starkey
Hi John, On Thu, Feb 14, 2019 at 09:38:29AM -0800, John Stultz wrote: > [snip] > Some thoughts, as this ABI break has the potential to be pretty painful. > > 1) Unfortunately, this ABI is exposed *through* libion via > ion_alloc/ion_alloc_fd out to gralloc implementations. Which means it > will

Re: [PATCH v2] staging: android: ion: Allocate from heap ID directly without mask

2019-02-18 Thread Brian Starkey
On Fri, Feb 15, 2019 at 11:01:59AM -0800, John Stultz wrote: > On Fri, Feb 15, 2019 at 2:51 AM Brian Starkey wrote: > > > > Hi John, > > > > On Thu, Feb 14, 2019 at 09:38:29AM -0800, John Stultz wrote: > > > > > [snip] > > > > > Some t

Re: [EARLY RFC][PATCH 0/4] ION per heap devices

2019-02-18 Thread Brian Starkey
hat? Thanks, -Brian > > Feedback would be greatly appreciated! > thanks > -john > > Cc: Laura Abbott > Cc: Sumit Semwal > Cc: Liam Mark > Cc: Brian Starkey > Cc: Andrew F. Davis > Cc: Alistair Strachan > Cc: dri-devel@lists.freedesktop.org > > Jo

Re: [PATCH v4 0/7] VSP1: Display writeback support

2019-02-18 Thread Brian Starkey
Hi Laurent, On Sun, Feb 17, 2019 at 04:48:45AM +0200, Laurent Pinchart wrote: > Hello, > > This patch series implements display writeback support for the R-Car > Gen3 platforms in the VSP1 driver. > > DRM/KMS provides a writeback API through a special type of writeback > connectors. This series

Re: [EARLY RFC][PATCH 3/4] ion: Add HEAP_INFO ioctl to be able to fetch heap type

2019-02-20 Thread Brian Starkey
On Tue, Feb 19, 2019 at 01:47:36PM -0800, John Stultz wrote: > On Tue, Feb 19, 2019 at 1:13 PM Laura Abbott wrote: > > > > On 2/15/19 12:24 PM, John Stultz wrote: > > > The per-device heaps don't support HEAP_QUERY ioctl, since > > > the name is provided in the devnode path and the heapid isn't >

Re: [PATCH] drm/writeback: Delete drm_writeback_cleanup_job

2019-02-21 Thread Brian Starkey
it got lost between v9 and v10. I saw a patch internally, but looks like James didn't send it to the list yet. @James, could you send out your patch which fixes the cleanup on failure? Thanks, -Brian > > > Cc: Brian Starkey > > Cc: Liviu Dudau > > Cc: Eric Anholt > &

Re: [PATCH v4 0/7] VSP1: Display writeback support

2019-02-21 Thread Brian Starkey
Hi Laurent, On Thu, Feb 21, 2019 at 10:23:17AM +0200, Laurent Pinchart wrote: > Hi Brian, > > On Mon, Feb 18, 2019 at 12:22:58PM +0000, Brian Starkey wrote: > > On Sun, Feb 17, 2019 at 04:48:45AM +0200, Laurent Pinchart wrote: > > > Hello, > > > > >

Re: [PATCH v4 0/7] VSP1: Display writeback support

2019-02-21 Thread Brian Starkey
Hi Laurent, On Thu, Feb 21, 2019 at 12:02:57PM +0200, Laurent Pinchart wrote: > Hi Brian, > > On Thu, Feb 21, 2019 at 09:50:19AM +0000, Brian Starkey wrote: > > On Thu, Feb 21, 2019 at 10:23:17AM +0200, Laurent Pinchart wrote: > > > On Mon, Feb 18, 2019 at 12:22:58PM +0

Re: [PATCH v4 0/7] VSP1: Display writeback support

2019-02-21 Thread Brian Starkey
On Thu, Feb 21, 2019 at 02:23:10PM +0200, Laurent Pinchart wrote: > On Thu, Feb 21, 2019 at 12:19:13PM +0000, Brian Starkey wrote: [snip] > > > > I used a pre-existing internal tool which does exactly that. > > Any hope of sharing the sources ? > Not in a timescal

Re: [PATCH v5 12/19] drm: writeback: Cleanup job ownership handling when queuing job

2019-02-21 Thread Brian Starkey
b pointer to NULL internally. LGTM, it was a mistake not doing it like this from the start. I do have one suggestion below, but either way: Reviewed-by: Brian Starkey > > > > Signed-off-by: Laurent Pinchart > > --- > > drivers/gpu/drm/arm/malidp_mw.c | 3 +-- > >

Re: [PATCH v5 13/19] drm: writeback: Fix leak of writeback job

2019-02-21 Thread Brian Starkey
ered, but > never addressed. > > Signed-off-by: Laurent Pinchart Thanks for fixing this, it looks like it got dropped in one of the rework/rebases. Reviewed-by: Brian Starkey > --- > drivers/gpu/drm/drm_atomic_state_helper.c | 4 > drivers/gpu/drm/drm_writeback.c

Re: [PATCH v5 14/19] drm: writeback: Add job prepare and cleanup operations

2019-02-21 Thread Brian Starkey
Hi Laurent, On Thu, Feb 21, 2019 at 12:32:07PM +0200, Laurent Pinchart wrote: > As writeback jobs contain a framebuffer, drivers may need to prepare and > cleanup them the same way they can prepare and cleanup framebuffers for > planes. Add two new optional connector helper operations, > .prepare_

Re: [PATCH v5 12/19] drm: writeback: Cleanup job ownership handling when queuing job

2019-02-22 Thread Brian Starkey
On Thu, Feb 21, 2019 at 11:56:09PM +0200, Laurent Pinchart wrote: > Hi Brian, > > On Thu, Feb 21, 2019 at 04:02:37PM +0000, Brian Starkey wrote: > > On Thu, Feb 21, 2019 at 12:42:25PM +0200, Laurent Pinchart wrote: > > > On Thu, Feb 21, 2019 at 12:32:05PM +0200, Laurent Pi

Re: [PATCH v5 14/19] drm: writeback: Add job prepare and cleanup operations

2019-02-22 Thread Brian Starkey
On Fri, Feb 22, 2019 at 12:12:00AM +0200, Laurent Pinchart wrote: > Hi Brian, > > On Thu, Feb 21, 2019 at 06:12:03PM +0000, Brian Starkey wrote: > > On Thu, Feb 21, 2019 at 12:32:07PM +0200, Laurent Pinchart wrote: > > > As writeback jobs contain a framebuffer, drivers

Re: [PATCH v5 00/19] R-Car DU display writeback support

2019-02-22 Thread Brian Starkey
Hi, On Thu, Feb 21, 2019 at 12:31:53PM +0200, Laurent Pinchart wrote: > Hello everybody, > > This patch series implements display writeback support for the R-Car > Gen3 platforms in the VSP1 and DU drivers. > > Patches 01/19 to 11/19 prepare the VSP1 driver for writeback support > with all the n

Re: [PATCH v5 07/19] media: vsp1: dl: Support one-shot entries in the display list

2019-02-22 Thread Brian Starkey
Hi Laurent, On Thu, Feb 21, 2019 at 12:32:00PM +0200, Laurent Pinchart wrote: > One-shot entries are used as an alternative to committing a complete new > display list when a couple of registers need to be written for one frame > and then reset to another value for all subsequent frames. This will

Re: [PATCH v5 07/19] media: vsp1: dl: Support one-shot entries in the display list

2019-02-22 Thread Brian Starkey
On Fri, Feb 22, 2019 at 04:46:29PM +0200, Laurent Pinchart wrote: > Hi Brian, > > On Fri, Feb 22, 2019 at 02:30:03PM +0000, Brian Starkey wrote: > > On Thu, Feb 21, 2019 at 12:32:00PM +0200, Laurent Pinchart wrote: > > > One-shot entries are used as an alternative to c

Re: [PATCH v5 14/19] drm: writeback: Add job prepare and cleanup operations

2019-02-22 Thread Brian Starkey
On Fri, Feb 22, 2019 at 04:49:53PM +0200, Laurent Pinchart wrote: > > That would be the connector helper functions, not the connector > functions, right ? Yes, sorry. ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.

Re: [PATCH] drm: Fix writeback_job leak when state is check only or check failed

2019-02-22 Thread Brian Starkey
Hi James, On Fri, Feb 22, 2019 at 07:39:55AM +, james qian wang (Arm Technology China) wrote: > On Thu, Feb 21, 2019 at 02:56:56PM +0100, Maarten Lankhorst wrote: > > Hey > > > > Op 21-02-2019 om 12:14 schreef james qian wang (Arm Technology China): > > > The writeback job will not be added

Re: [EARLY RFC][PATCH] dma-buf: Add dma-buf heaps framework

2019-03-01 Thread Brian Starkey
Hi Andrew, Sorry for not managing to comment on this sooner, I've had a crazy few days. As the others have said, I quite like the direction here. On Mon, Feb 25, 2019 at 08:36:04AM -0600, Andrew F. Davis wrote: > This framework allows a unified userspace interface for dma-buf > exporters, allowi

Re: [EARLY RFC][PATCH] dma-buf: Add dma-buf heaps framework

2019-03-05 Thread Brian Starkey
On Mon, Mar 04, 2019 at 08:53:42AM -0600, Andrew F. Davis wrote: > On 3/1/19 6:06 AM, Brian Starkey wrote: > > > > Am I right in thinking "cmd" comes from userspace? It might be a good > > idea to not trust _IOC_SIZE(cmd) and use our own. I'm looking at

Re: [PATCH v5 07/19] media: vsp1: dl: Support one-shot entries in the display list

2019-03-06 Thread Brian Starkey
Hi, On Wed, Mar 06, 2019 at 01:14:40AM +0200, Laurent Pinchart wrote: > Hi Brian, > > On Fri, Feb 22, 2019 at 03:06:19PM +0000, Brian Starkey wrote: > > On Fri, Feb 22, 2019 at 04:46:29PM +0200, Laurent Pinchart wrote: > > > On Fri, Feb 22, 2019 at 02:30:03PM +0

Re: [PATCH v5 07/19] media: vsp1: dl: Support one-shot entries in the display list

2019-03-07 Thread Brian Starkey
On Wed, Mar 06, 2019 at 08:22:44PM +0200, Laurent Pinchart wrote: [snip] > > I can always queue a new one, but I have no way of telling if the newly > queued list raced with the frame end interrupt. > > There's another register I'm not using that contains a shadow copy of > the registers list D

Re: [PATCH v5 1/5] dma-buf: Add dma-buf heaps framework

2019-06-07 Thread Brian Starkey
f the Android ION implementation, > and a big thanks is due to its authors/maintainers over time > for their effort: > Rebecca Schultz Zavin, Colin Cross, Benjamin Gaignard, > Laura Abbott, and many other contributors! > > Cc: Laura Abbott > Cc: Benjamin Gaignard > Cc: S

Re: [PATCH v5 2/5] dma-buf: heaps: Add heap helpers

2019-06-07 Thread Brian Starkey
riginal authors and maintainters: > Rebecca Schultz Zavin, Colin Cross, Laura Abbott, and others! > > Cc: Laura Abbott > Cc: Benjamin Gaignard > Cc: Sumit Semwal > Cc: Liam Mark > Cc: Pratik Patel > Cc: Brian Starkey > Cc: Vincent Donnefort > Cc: Sudipto Paul &

Re: [PATCH v5 3/5] dma-buf: heaps: Add system heap to dmabuf heaps

2019-06-07 Thread Brian Starkey
implementation, so > thanks to its original authors and maintainters: > Rebecca Schultz Zavin, Colin Cross, Laura Abbott, and others! > > Cc: Laura Abbott > Cc: Benjamin Gaignard > Cc: Sumit Semwal > Cc: Liam Mark > Cc: Pratik Patel > Cc: Brian Starkey > Cc: Vince

Re: [PATCH v5 4/5] dma-buf: heaps: Add CMA heap to dmabuf heaps

2019-06-07 Thread Brian Starkey
nd maintainters: > Benjamin Gaignard, Laura Abbott, and others! > > Cc: Laura Abbott > Cc: Benjamin Gaignard > Cc: Sumit Semwal > Cc: Liam Mark > Cc: Pratik Patel > Cc: Brian Starkey > Cc: Vincent Donnefort > Cc: Sudipto Paul > Cc: Andrew F. Davis

Re: [PATCH v5 5/5] kselftests: Add dma-heap test

2019-06-07 Thread Brian Starkey
; Cc: Liam Mark > Cc: Pratik Patel > Cc: Brian Starkey > Cc: Vincent Donnefort > Cc: Sudipto Paul > Cc: Andrew F. Davis > Cc: Christoph Hellwig > Cc: Chenbo Feng > Cc: Alistair Strachan > Cc: dri-devel@lists.freedesktop.org > Reviewed

Re: [PATCH 2/2] drm/vkms: Add support for writeback

2019-06-07 Thread Brian Starkey
Hi Rodrigo, On Thu, Jun 06, 2019 at 07:41:01PM -0300, Rodrigo Siqueira wrote: > This patch implements the necessary functions to add writeback support > for vkms. This feature is useful for testing compositors if you don’t > have hardware with writeback support. > > Signed-off-by: Rodrigo Siqueir

Re: [PATCH] drm/fourcc: Add Arm 16x16 block modifier

2019-06-21 Thread Brian Starkey
On Fri, Jun 21, 2019 at 11:21:08AM +0100, Raymond Smith wrote: > Add the DRM_FORMAT_MOD_ARM_16X16_BLOCK_U_INTERLEAVED modifier to > denote the 16x16 block u-interleaved format used in Arm Utgard and > Midgard GPUs. > > Signed-off-by: Raymond Smith Reviewed-by: Brian Starkey Tha

Re: [PATCH] drm/fourcc: Add Arm 16x16 block modifier

2019-06-24 Thread Brian Starkey
Hi Daniel, On Fri, Jun 21, 2019 at 05:27:00PM +0200, Daniel Vetter wrote: > On Fri, Jun 21, 2019 at 12:21 PM Raymond Smith wrote: > > > > Add the DRM_FORMAT_MOD_ARM_16X16_BLOCK_U_INTERLEAVED modifier to > > denote the 16x16 block u-interleaved format used in Arm Utgard and > > Midgard GPUs. > > >

Re: [PATCH] drm/fourcc: Add Arm 16x16 block modifier

2019-06-24 Thread Brian Starkey
On Mon, Jun 24, 2019 at 11:58:59AM +0200, Daniel Vetter wrote: > On Mon, Jun 24, 2019 at 11:32 AM Brian Starkey wrote: > > > > Hi Daniel, > > > > On Fri, Jun 21, 2019 at 05:27:00PM +0200, Daniel Vetter wrote: > > > On Fri, Jun 21, 2019 at 12:21 PM Raymond Smit

Re: [PATCH] drm/komeda: Adds VRR support

2019-07-04 Thread Brian Starkey
Hi, On Thu, Jul 04, 2019 at 11:57:00AM +0100, james qian wang (Arm Technology China) wrote: > On Wed, Jul 03, 2019 at 12:01:49PM +0200, Daniel Vetter wrote: > > > > Uh, what exactly are you doing reinventing uapi properties that we already > > standardized? > > > > Sorry, Will use the mode_con

Re: [PATCH v4 01/10] drm/fourcc: Add AFBC yuv fourccs for Mali

2019-03-18 Thread Brian Starkey
Hi, On Mon, Mar 18, 2019 at 11:17:55AM +0100, Maarten Lankhorst wrote: > Hey.. > > There's a conflict with this patch and the merge of topic/hdr-formats, > resulting in double definitions for Y210, Y410 and P010. > > Worse still is that one has set has_alpha to true for Y41x and other to fal

Re: [PATCH v5 07/19] media: vsp1: dl: Support one-shot entries in the display list

2019-03-18 Thread Brian Starkey
Hi Laurent, Sorry for the delay, I was travelling last week and didn't find a chance to digest your diagrams (thanks for all the detail!) On Fri, Mar 08, 2019 at 02:24:40PM +0200, Laurent Pinchart wrote: > Hi Brian, > > On Thu, Mar 07, 2019 at 12:28:08PM +, Brian Starkey wro

Re: [PATCH v3] drm/fourcc: add ARM GPU tile modifier

2019-03-18 Thread Brian Starkey
: separate AFBC and GPU encoding > > v3: rename device to type and GPU modifer name > > Cc: Brian Starkey > Cc: Rob Herring > Cc: Alyssa Rosenzweig > Cc: Ayan Halder > Signed-off-by: Qiang Yu > --- > include/uapi/drm/drm_fourcc.h | 31 ++

Re: [PATCH v4 01/10] drm/fourcc: Add AFBC yuv fourccs for Mali

2019-03-18 Thread Brian Starkey
On Mon, Mar 18, 2019 at 07:12:24PM +0100, Maarten Lankhorst wrote: > Op 18-03-2019 om 16:40 schreef Brian Starkey: > > Hi, > > > > On Mon, Mar 18, 2019 at 11:17:55AM +0100, Maarten Lankhorst wrote: > > > > > > > >> Hey.. > >> > >

Re: [PATCH v4 01/10] drm/fourcc: Add AFBC yuv fourccs for Mali

2019-03-18 Thread Brian Starkey
On Mon, Mar 18, 2019 at 07:00:57PM +, Brian Starkey wrote: > On Mon, Mar 18, 2019 at 07:12:24PM +0100, Maarten Lankhorst wrote: > > Op 18-03-2019 om 16:40 schreef Brian Starkey: > > > Hi, > > > > > > On Mon, Mar 18, 2019 at 11:17

Re: [PATCH v4 01/10] drm/fourcc: Add AFBC yuv fourccs for Mali

2019-03-18 Thread Brian Starkey
On Mon, Mar 18, 2019 at 07:06:39PM +, Brian Starkey wrote: > > [1] > > https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/commit/0ac7d1187b234e86157ad74937c249a3c016807c > > Eh. I'm not familiar enough with the gitlab UI. Looks like this didn't > merge i

Re: [RFC][PATCH 1/5 v2] dma-buf: Add dma-buf heaps framework

2019-03-19 Thread Brian Starkey
Hi John, On Tue, Mar 05, 2019 at 12:54:29PM -0800, John Stultz wrote: > From: "Andrew F. Davis" [snip] > + > +#define NUM_HEAP_MINORS 128 > +static DEFINE_IDR(dma_heap_idr); > +static DEFINE_MUTEX(minor_lock); /* Protect idr accesses */ I saw that Matthew Wilcox is trying to nuke idr: https://

Re: [PATCH v3] drm/fourcc: add ARM GPU tile modifier

2019-03-19 Thread Brian Starkey
On Tue, Mar 19, 2019 at 08:05:32PM +0800, Qiang Yu wrote: > Hi Brian, > > > Since your first patch set, I did raise this internally. The request > > has been making it's way through: > > > > - GPU engineering, to determine what exactly this format is, and > >what other variants there might be

Re: [RFC][PATCH 2/5 v2] dma-buf: heaps: Add heap helpers

2019-03-19 Thread Brian Starkey
Hi John, On Tue, Mar 05, 2019 at 12:54:30PM -0800, John Stultz wrote: ... > + > +void dma_heap_buffer_destroy(struct dma_heap_buffer *heap_buffer) > +{ > + struct heap_helper_buffer *buffer = to_helper_buffer(heap_buffer); > + > + if (buffer->kmap_cnt > 0) { > + pr_warn_once(

Re: [RFC][PATCH 4/5 v2] dma-buf: heaps: Add CMA heap to dmabuf heapss

2019-03-19 Thread Brian Starkey
nd maintainters: > Benjamin Gaignard, Laura Abbott, and others! > > Cc: Laura Abbott > Cc: Benjamin Gaignard > Cc: Greg KH > Cc: Sumit Semwal > Cc: Liam Mark > Cc: Brian Starkey > Cc: Andrew F. Davis > Cc: Chenbo Feng > Cc: Alistair Strachan > Cc: dri-devel

Re: [v6 03/13] drm: Parse Colorimetry data block from EDID

2019-03-21 Thread Brian Starkey
Hi Uma, On Wed, Mar 20, 2019 at 04:18:16PM +0530, Uma Shankar wrote: > CEA 861.3 spec adds colorimetry data block for HDMI. > Parsing the block to get the colorimetry data from > panel. > While code which parses these parts (patches 2 and 3) out of EDID could be useful - it doesn't seem to actua

Re: [v6 01/13] drm: Add HDR source metadata property

2019-03-21 Thread Brian Starkey
Hi Uma, On Wed, Mar 20, 2019 at 04:18:14PM +0530, Uma Shankar wrote: > This patch adds a blob property to get HDR metadata > information from userspace. This will be send as part > of AVI Infoframe to panel. > > v2: Rebase and modified the metadata structure elements > as per Ville's POC changes.

Re: [v6 06/13] drm: Enable HDR infoframe support

2019-03-21 Thread Brian Starkey
On Wed, Mar 20, 2019 at 04:18:19PM +0530, Uma Shankar wrote: > Enable Dynamic Range and Mastering Infoframe for HDR > content, which is defined in CEA 861.3 spec. > > The metadata will be computed based on blending > policy in userspace compositors and passed as a connector > property blob to driv

Re: [v6 05/13] drm: Implement HDR output metadata set and get property handling

2019-03-21 Thread Brian Starkey
Hi, On Wed, Mar 20, 2019 at 04:18:18PM +0530, Uma Shankar wrote: > This patch implements get() and set() functions for HDR output > metadata property.The blob data is received from userspace and > saved in connector state, the same is returned as blob in get > property call to userspace. > > v2:

Re: [v6 13/13] video/hdmi: Add const variants for drm infoframe

2019-03-21 Thread Brian Starkey
Hi, On Wed, Mar 20, 2019 at 04:18:26PM +0530, Uma Shankar wrote: > Added the const version of infoframe for DRM metadata > for HDR. > > Signed-off-by: Uma Shankar Unless there's a strong reason not to, I think this can be squashed into patch 6. > --- > drivers/video/hdmi.c | 63 > +++

Re: [PATCH v8] drm/lima: driver for ARM Mali4xx GPUs

2019-03-27 Thread Brian Starkey
Hi Neil, On Wed, Mar 27, 2019 at 10:15:48AM +0100, Neil Armstrong wrote: > Hi, > > On 26/03/2019 21:40, Vasily Khoruzhick wrote: > > Hi, > > > > So what's the status of it? > > We are waiting on ARM to give a feedback on the ARM GPU tile modifier, > see https://patchwork.freedesktop.org/patch/2

Re: [PATCH] drm/komeda: Skips the invalid writeback job

2019-07-26 Thread Brian Starkey
On Fri, Jul 26, 2019 at 04:23:56PM +0200, Daniel Vetter wrote: > On Fri, Jul 26, 2019 at 08:13:00AM +, Lowry Li (Arm Technology China) > wrote: > > Current DRM-CORE accepts the writeback_job with a empty fb, but that > > is an invalid job for HW, so need to skip it when commit it to HW. > > >

Re: [PATCH v1 2/2] drm: Clear the fence pointer when writeback job signaled

2019-07-31 Thread Brian Starkey
Hi Lowry, Thanks for this cleanup. On Wed, Jul 31, 2019 at 11:04:45AM +, Lowry Li (Arm Technology China) wrote: > During it signals the completion of a writeback job, after releasing > the out_fence, we'd clear the pointer. > > Check if fence left over in drm_writeback_cleanup_job(), release

  1   2   3   4   5   >