[PATCH 5/9] drm: Change create block to reserve node

2013-07-05 Thread Ben Widawsky
nveniently this is the only user of the interface. CC: David Airlie CC: Signed-off-by: Ben Widawsky --- drivers/gpu/drm/drm_mm.c | 19 ++- drivers/gpu/drm/i915/i915_gem_gtt.c| 8 drivers/gpu/drm/i915/i915_gem_stolen.c | 14 -- include/dr

[PATCH 9/9] drm: Optionally create mm blocks from top-to-bottom

2013-07-05 Thread Ben Widawsky
removal v4: by Ben: Rebased on reserve_node addition. Signed-off-by: Chris Wilson CC: Signed-off-by: Ben Widawsky Conflicts: drivers/gpu/drm/drm_mm.c include/drm/drm_mm.h Conflicts: drivers/gpu/drm/drm_mm.c drivers/gpu/drm/i915/i915_gem_gtt.c drivers/gpu/drm

[PATCH] drm/i915: yet another forcewake lock fix

2011-06-16 Thread Ben Widawsky
Resume is missing a locks on gt sleepable registers. --- drivers/gpu/drm/i915/i915_suspend.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_suspend.c b/drivers/gpu/drm/i915/i915_suspend.c index 60a94d2..9259dcf 100644 --- a/drivers/gpu/drm/i91

[PATCH 01/11] intel: shared header for shader debugging

2011-06-24 Thread Ben Widawsky
Signed-off-by: Ben Widawsky --- intel/Makefile.am |3 ++- intel/intel_debug.h | 44 2 files changed, 46 insertions(+), 1 deletions(-) diff --git a/intel/Makefile.am b/intel/Makefile.am index b6a9014..7a44aaf 100644 --- a/intel/Makefile.am

[PATCH 01/10] intel: shared header for shader debugging

2011-07-13 Thread Ben Widawsky
Signed-off-by: Ben Widawsky --- intel/Makefile.am |3 ++- intel/intel_debug.h | 44 2 files changed, 46 insertions(+), 1 deletions(-) diff --git a/intel/Makefile.am b/intel/Makefile.am index b6a9014..7a44aaf 100644 --- a/intel/Makefile.am

[PATCH 0/10] fs shader debugging

2011-07-13 Thread Ben Widawsky
Version 2 of the patch series is pretty much the same as version 1. 2 of the patches have already been picked up by the kernel and mesa so they are gone. The only major change is in mesa where I no longer load a binary blob from an environment variable, but instead compile the bytes directly in

Re: [PATCH 0/10] fs shader debugging

2011-07-13 Thread Ben Widawsky
On Wed, Jul 13, 2011 at 01:51:42PM -0700, Ben Widawsky wrote: > > > Version 2 of the patch series is pretty much the same as version 1. 2 of the > patches have already been picked up by the kernel and mesa so they are > gone. > > The only major change is in mesa where I no

[PATCH 00/10] fs debugging: incorporated Chris' feedback

2011-07-17 Thread Ben Widawsky
This is the revised patch series for fragment shader debugging. There is no major change, though of interest are: * forcewaked acts more like a daemon * forcewaked isn't needed for debugging only there for sample * i915 detection is now done by stating i915_forcewake_user_lock * register r

[PATCH 01/10] intel: shared header for shader debugging

2011-07-17 Thread Ben Widawsky
Cc: Chris Wilson Signed-off-by: Ben Widawsky --- intel/Makefile.am |3 ++- intel/intel_debug.h | 44 2 files changed, 46 insertions(+), 1 deletions(-) diff --git a/intel/Makefile.am b/intel/Makefile.am index b6a9014..7a44aaf 100644 --- a

Re: [Intel-gfx] [PATCH 01/10] intel: shared header for shader debugging

2011-07-21 Thread Ben Widawsky
On Tue, Jul 19, 2011 at 11:06:17PM +0200, Julien Cristau wrote: > On Wed, Jul 13, 2011 at 13:51:43 -0700, Ben Widawsky wrote: > > > +#define SHADER_DEBUG_SOCKET "/tmp/gen_debug" > > Not sure what this is used for, but does it really need to be in /tmp? It is the s

Re: [Intel-gfx] [PATCH 01/10] intel: shared header for shader debugging

2011-07-27 Thread Ben Widawsky
On Thu, Jul 21, 2011 at 11:22:12PM +0200, Julien Cristau wrote: > On Thu, Jul 21, 2011 at 13:54:41 +0000, Ben Widawsky wrote: > > > On Tue, Jul 19, 2011 at 11:06:17PM +0200, Julien Cristau wrote: > > > On Wed, Jul 13, 2011 at 13:51:43 -0700, Ben Widawsky wrote: &g

Re: [Intel-gfx] [PATCH 01/10] intel: shared header for shader debugging

2011-07-27 Thread Ben Widawsky
On Wed, Jul 27, 2011 at 05:16:31PM +0200, Julien Cristau wrote: > On Wed, Jul 27, 2011 at 15:08:08 +0000, Ben Widawsky wrote: > > > On Thu, Jul 21, 2011 at 11:22:12PM +0200, Julien Cristau wrote: > > > On Thu, Jul 21, 2011 at 13:54:41 +, Ben Widawsky wrote: > > >

Re: Whitespace cleanups in drm/i915

2011-09-16 Thread Ben Widawsky
On Thu, 15 Sep 2011 18:37:33 -0700 "Keith Packard" wrote: > > I've got this nice patch from Akshay Joshi that removes almost all of > the checkpatch.pl warnings from drm/i915. If I don't merge it now, > it's going to go stale and be useless; if I merge it only to > drm-intel-next, it will be the

[Intel-gfx] [PATCH 2/2] Check if the bus is valid prior to discovering edid.

2011-10-08 Thread Ben Widawsky
On Fri, Oct 07, 2011 at 07:00:42PM -0300, Eugeni Dodonov wrote: > This adds a new function intel_drm_get_valid_edid, which is used instead > of drm_get_edid within the i915 driver. > > It does a similar check to the one in previous patch, but it is limited to > i915 driver. > > The check is simil

[PATCH 11/12] i915: Move i915_read/write out of line

2011-10-17 Thread Ben Widawsky
tatic inline void i915_write##x(struct drm_i915_private *dev_priv, u32 reg, > u##x val) { \ > - trace_i915_reg_rw(true, reg, val, sizeof(val)); \ > - if (NEEDS_FORCE_WAKE((dev_priv), (reg))) { \ > - __gen6_gt_wait_for_fifo(dev_priv); \ > - } \ > - write##

[Intel-gfx] [PATCH] agp: iommu_gfx_mapped only available if CONFIG_INTEL_IOMMU is set

2011-10-28 Thread Ben Widawsky
: Keith Packard > Cc: Ben Widawsky > --- wfm Reviewed-by: Ben Widawsky

Whitespace cleanups in drm/i915

2011-09-16 Thread Ben Widawsky
On Thu, 15 Sep 2011 18:37:33 -0700 "Keith Packard" wrote: > > I've got this nice patch from Akshay Joshi that removes almost all of > the checkpatch.pl warnings from drm/i915. If I don't merge it now, > it's going to go stale and be useless; if I merge it only to > drm-intel-next, it will be the

Massive power regression going 3.4->3.5

2012-08-02 Thread Ben Widawsky
On 2012-08-02 00:20, James Bottomley wrote: > On Wed, 2012-08-01 at 22:08 -0700, bwidawsk wrote: >> On 2012-08-01 03:06, Chris Wilson wrote: >> > On Wed, 01 Aug 2012 10:38:36 +0100, James Bottomley >> > wrote: >> >> On Wed, 2012-08-01 at 09:58 +0100, Chris Wilson wrote: >> >> > On Wed, 01 Aug 2012

[PATCH] drm/i915: make forcewake work again

2012-08-06 Thread Ben Widawsky
h the old macro. In any case, I think this warrants further review. Signed-off-by: Ben Widawsky --- drivers/gpu/drm/i915/i915_drv.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c index ff569cc..

[Intel-gfx] [PATCH] drm/i915: make forcewake work again

2012-08-07 Thread Ben Widawsky
On Mon, 6 Aug 2012 12:31:31 -0700 Ben Widawsky wrote: > While trying to track down the power regression, I noticed that on my > SNB I had more severe problems, ie. forcewake seemed to never happen > once i915 was loaded. After a bit of bisection, I tracked the bad commit > to:

Massive power regression going 3.4->3.5

2012-08-07 Thread Ben Widawsky
the >> old >> kernel when booting with i915.i915_semaphores=1? > > It idles at around 13W, which means the history of the problem must > be > this: > > What looks to have happened seems to be because of a merge failure in > drm: > > In 3.2 Keith Packard

v3.5 Oops in i2c_algo_bit.c:bit_xfer+0x23/0x870: i915 or i2c?

2012-08-12 Thread Ben Widawsky
b/drivers/gpu/drm/i915/intel_i2c.c index 1991a44..fd04e89 100644 --- a/drivers/gpu/drm/i915/intel_i2c.c +++ b/drivers/gpu/drm/i915/intel_i2c.c @@ -494,7 +494,7 @@ int intel_setup_gmbus(struct drm_device *dev) bus->reg0 = port | GMBUS_RATE_100KHZ; /* gmbus seems to be broken on i830 */ - if (IS_I830(dev)) + if (1) bus->force_bit = true; intel_gpio_setup(bus, port); -- Ben Widawsky, Intel Open Source Technology Center

[RFC PATCH] drm/vgem: virtual GEM provider

2012-02-08 Thread Ben Widawsky
On Wed, Jan 11, 2012 at 04:04:20PM -0500, Adam Jackson wrote: > On Wed, 2012-01-11 at 12:16 -0800, Eric Anholt wrote: > > > I remember at one point you had a plan along the lines of passing shmem > > fds across the protocol. I'm curious what happened to that -- too hard > > to get the passing to

[PATCH 1/5] drm/vgem: virtual GEM provider

2012-02-09 Thread Ben Widawsky
From: Adam Jackson This is about as minimal of a virtual GEM service as possible. My plan is to use this with non-native-3D hardware for buffer sharing between X and DRI. The current drisw winsys assumes an unmodified X server, which means it's hopelessly inefficient for both the push direction

[RFCv2 PATCH 0/5] virtual GEM provider

2012-02-09 Thread Ben Widawsky
he most basic of tests for this are here: git://people.freedesktop.org/~bwidawsk/vgem-gpu-tools master I've also pushed this repo here: git://people.freedesktop.org/~bwidawsk/drm-intel vgem Adam Jackson (1): drm/vgem: virtual GEM provider Ben Widawsky (4): drm/vgem: fops should

[PATCH 2/5] drm/vgem: fops should be separate and constified

2012-02-09 Thread Ben Widawsky
...or else it just won't build. Signed-off-by: Ben Widawsky --- drivers/gpu/drm/vgem/vgem_drv.c | 20 +++- 1 files changed, 11 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/vgem/vgem_drv.c b/drivers/gpu/drm/vgem/vgem_drv.c index 82c6787..3084389 100644

[PATCH 3/5] drm/vgem: Add a drm_vgem_gem_object

2012-02-09 Thread Ben Widawsky
and use it Signed-off-by: Ben Widawsky --- drivers/gpu/drm/vgem/vgem_drv.c | 13 ++--- 1 files changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/vgem/vgem_drv.c b/drivers/gpu/drm/vgem/vgem_drv.c index 3084389..d47bd71 100644 --- a/drivers/gpu/drm/vgem/vgem_drv.c

[PATCH 4/5] drm/vgem: getparam ioctl

2012-02-09 Thread Ben Widawsky
Similar to i915, it's nice to be able to query this device uniquely and get some info Signed-off-by: Ben Widawsky --- drivers/gpu/drm/vgem/vgem_drv.c | 29 + include/drm/vgem_drm.h | 11 +++ 2 files changed, 32 insertions(+), 8 deletions(-)

[PATCH 5/5] drm/vgem: properly implement mmap

2012-02-09 Thread Ben Widawsky
after I figure out if locking is actually required right now. Hmm, and now that I think about it, mremap, and munmap may not work either. Signed-off-by: Ben Widawsky --- drivers/gpu/drm/vgem/vgem_drv.c | 105 -- 1 files changed, 99 insertions(+), 6 deletions

[PATCH 5/5] drm/vgem: properly implement mmap

2012-02-09 Thread Ben Widawsky
On 02/09/2012 12:36 AM, Chris Wilson wrote: > On Thu, 9 Feb 2012 00:19:31 +0100, Ben Widawsky wrote: >> Mostly copied from i915 gtt mmaps, this will properly fault in pages as >> the user tries to use them. The only thing of note are that no >> prefaulting occurs, so perhaps

[PATCH 1/2] intel: Mark up with valgrind intrinsics to reduce false positives

2012-02-09 Thread Ben Widawsky
On 02/09/2012 11:43 AM, Chris Wilson wrote: > In particular, declare the hidden CPU mmaps to valgrind so that it knows > about those memory regions. > > References: https://bugs.freedesktop.org/show_bug.cgi?id=35071 > Signed-off-by: Chris Wilson Acked-by: Ben Widawsky > -

[PATCH] [PATCH] drm/i915: Fix race condition in accessing GMBUS

2012-02-13 Thread Ben Widawsky
On Fri, Feb 10, 2012 at 12:50:01PM -0500, Yufeng Shen wrote: > GMBUS has several ports and each has it's own corresponding > I2C adpater. When multiple I2C adapters call gmbus_xfer() at > the same time there is a race condition in using the underlying > GMBUS controller. Fixing this by adding a mut

[PATCH 4/5] drm/vgem: getparam ioctl

2012-02-20 Thread Ben Widawsky
On Thu, 16 Feb 2012 07:23:52 + Dave Airlie wrote: > On Wed, Feb 15, 2012 at 9:22 PM, Adam Jackson wrote: > > On 2/8/12 6:19 PM, Ben Widawsky wrote: > >> > >> Similar to i915, it's nice to be able to query this device uniquely and > >> get some i

[PATCH 1/5] drm/vgem: virtual GEM provider

2012-02-20 Thread Ben Widawsky
On Thu, 16 Feb 2012 05:52:12 -0800 (PST) Jakob Bornecrantz wrote: > - Original Message - > > From: Adam Jackson > > > > This is about as minimal of a virtual GEM service as possible. My > > plan is to use this with non-native-3D hardware for buffer sharing > > between X and DRI. > > >

[PATCH 1/5] drm/vgem: virtual GEM provider

2012-02-21 Thread Ben Widawsky
On Tue, 21 Feb 2012 11:08:52 -0500 Adam Jackson wrote: > On Tue, 2012-02-21 at 15:34 +, Dave Airlie wrote: > > > Not sure what you mean there, those 3 APIs are just to create dumb > > unaccelerated objects, > > probably are fine for vgem's use. For scanout we create framebuffer > > objects f

[PATCH 1/7] drm: base prime support

2012-02-22 Thread Ben Widawsky
From: Dave Airlie --- drivers/gpu/drm/Makefile|2 +- drivers/gpu/drm/drm_drv.c |3 + drivers/gpu/drm/drm_gem.c |3 +- drivers/gpu/drm/drm_prime.c | 126 +++ include/drm/drm.h | 10 +++- include/drm/drmP.h | 35 ++

[PATCH 0/7] RFCv3 VGEM Prime (dma-buf)

2012-02-22 Thread Ben Widawsky
to work on, I can even do better tests with just VGEM. Adam Jackson (1): drm/vgem: virtual GEM provider Ben Widawsky (5): drm: DRM_DEBUG_PRIME drm: per device prime dma buf hash drm/vgem: prime export support drm/vgem: import support drm: actually enable PRIME Dave Airlie (1):

[PATCH 2/7] DRM_DEBUG_PRIME

2012-02-22 Thread Ben Widawsky
--- include/drm/drmP.h |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/include/drm/drmP.h b/include/drm/drmP.h index 9558111..5ed9b41 100644 --- a/include/drm/drmP.h +++ b/include/drm/drmP.h @@ -91,6 +91,7 @@ struct drm_device; #define DRM_UT_CORE0x01 #

[PATCH 2/7] drm: DRM_DEBUG_PRIME

2012-02-22 Thread Ben Widawsky
Signed-off-by: Ben Widawsky --- include/drm/drmP.h |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/include/drm/drmP.h b/include/drm/drmP.h index 9558111..5ed9b41 100644 --- a/include/drm/drmP.h +++ b/include/drm/drmP.h @@ -91,6 +91,7 @@ struct drm_device; #define

[PATCH 3/7] drm/vgem: virtual GEM provider

2012-02-22 Thread Ben Widawsky
am Jackson [RFCv2] Reviewed-by: Adam Jackson Signed-off-by: Ben Widawsky --- drivers/gpu/drm/Kconfig |8 + drivers/gpu/drm/Makefile|1 + drivers/gpu/drm/vgem/Makefile |4 + drivers/gpu/drm/vgem/vgem_drv.c | 382 +++ drivers/gpu/drm/v

[PATCH 4/7] drm: per device prime dma buf hash

2012-02-22 Thread Ben Widawsky
lso a lock introduced to help with the various ref count dances (and subsequent hash list traversals). Cc: Daniel Vetter Cc: Dave Airlie Signed-off-by: Ben Widawsky --- drivers/gpu/drm/drm_gem.c |3 ++ drivers/gpu/drm/drm_prime.c | 46 +++ drivers/gp

[PATCH 5/7] drm/vgem: prime export support

2012-02-22 Thread Ben Widawsky
dma-buf export implementation. Heavily influenced by Dave Airlie's proof of concept work. Cc: Daniel Vetter Cc: Dave Airlie Signed-off-by: Ben Widawsky --- drivers/gpu/drm/vgem/Makefile |2 +- drivers/gpu/drm/vgem/vgem_dma_buf.c | 128 +++ dr

[PATCH 6/7] drm/vgem: import support

2012-02-22 Thread Ben Widawsky
detailed explanation. Cc: Daniel Vetter Cc: Dave Airlie Signed-off-by: Ben Widawsky --- drivers/gpu/drm/vgem/vgem_dma_buf.c | 120 +++ 1 files changed, 120 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/vgem/vgem_dma_buf.c b/drivers/gpu/drm/vgem

[PATCH 7/7] drm: actually enable PRIME

2012-02-22 Thread Ben Widawsky
Enable prime in both Kconfig and vgem. Signed-off-by: Ben Widawsky --- drivers/gpu/drm/Kconfig |1 + drivers/gpu/drm/vgem/vgem_drv.c |3 ++- 2 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig index 566c468..c893f1e

[Intel-gfx] [PULL] drm-intel-next

2012-01-05 Thread Ben Widawsky
On 01/05/2012 07:24 AM, Daniel Vetter wrote: > On Wed, Jan 04, 2012 at 07:35:41PM -0800, Keith Packard wrote: >> >> Here are the rest of the 3.3 pending changes. >> >> This has a bunch of small bug fixes and overlay plane support for i915. >> >> The following changes since commit 7a7e8734ac3235efaf

[PATCH libdrm] intel: Fix build failure in test_decode.c

2012-07-02 Thread Ben Widawsky
t_decode.c > +++ b/intel/test_decode.c > @@ -21,6 +21,8 @@ > * IN THE SOFTWARE. > */ > > +#define _GNU_SOURCE > + > #include > #include > #include I can't reproduce this. Can anyone else confirm this is broken, and if so that the above patch fixes it? -- Ben Widawsky, Intel Open Source Technology Center

[ANNOUNCE] libdrm 2.4.37

2012-07-03 Thread Ben Widawsky
The link generated by the release script was incorrect. They should be http://dri.freedesktop.org/libdrm/libdrm-2.4.37.tar.gz http://dri.freedesktop.org/libdrm/libdrm-2.4.37.tar.bz2 On Fri, 29 Jun 2012 11:17:47 -0700 Ben Widawsky wrote: > I botched the 2.3.36 release quite royally. Here

[PATCH libdrm] intel: Fix build failure in test_decode.c

2012-07-03 Thread Ben Widawsky
On Tue, 3 Jul 2012 12:21:27 +0300 Lauri Kasanen wrote: > On Mon, 2 Jul 2012 14:54:58 -0700 > Ben Widawsky wrote: > > > > +#define _GNU_SOURCE > > > + > > > #include > > > #include > > > #include > > > > I can't rep

[Intel-gfx] [PATCH] drm/i915: fix infinite recursion on unbind due to ilk vt-d w/a

2011-12-06 Thread Ben Widawsky
On Tue, Dec 06, 2011 at 12:12:33PM +0100, Daniel Vetter wrote: > The recursion loop goes retire_requests->unbind->gpu_idle->retire_reqeusts. > > Every time we go through this we need a > - active object that can be retired > - and there are no other references to that object than the one from >

Memory corruption starting in i915 code, in 3.2-rc5

2011-12-16 Thread Ben Widawsky
On 12/16/2011 11:22 AM, Keith Packard wrote: > On Tue, 13 Dec 2011 19:26:50 +0100, Daniel Vetter wrote: >> On Tue, Dec 13, 2011 at 10:14:46AM -0800, Keith Packard wrote: >>> On Tue, 13 Dec 2011 10:14:15 -0500, Alex Villac??s Lasso >> palosanto.com> wrote: >>> By using a bootable USB stick, I

[PATCH] drm/i915: iommu workaround related cleanups

2011-11-01 Thread Ben Widawsky
Cleanups recommended by Dave Airlie. Cc: Keith Packard Signed-off-by: Ben Widawsky --- drivers/char/agp/intel-agp.h |6 ++ drivers/char/agp/intel-gtt.c |7 --- 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/char/agp/intel-agp.h b/drivers/char/agp/intel

[PATCH] drm/i915: iommu workaround related cleanups

2011-11-01 Thread Ben Widawsky
On Tue, 1 Nov 2011 11:29:49 -0700 Ben Widawsky wrote: > Cleanups recommended by Dave Airlie. > > Cc: Keith Packard > Signed-off-by: Ben Widawsky > --- > drivers/char/agp/intel-agp.h |6 ++ > drivers/char/agp/intel-gtt.c |7 --- > 2 files chan

[Intel-gfx] [PATCH 01/13] drm/i915: fall through pwrite_gtt_slow to the shmem slow path

2011-11-20 Thread Ben Widawsky
patches in this series fix this up further, so instead of figuring out all the failure conditions pwrite can cause, let's just go with Acked-by: Ben Widawsky

[Intel-gfx] [PATCH 02/13] drm/i915: rewrite shmem_pwrite_slow to use copy_from_user

2011-11-20 Thread Ben Widawsky
On Sun, 6 Nov 2011 20:13:49 +0100 Daniel Vetter wrote: > ... instead of get_user_pages, because that fails on non page-backed > user addresses like e.g. a gtt mapping of a bo. > > To get there essentially copy the vfs read path into pagecache. We > can't call that right away because we have to

[Intel-gfx] [PATCH 02/13] drm/i915: rewrite shmem_pwrite_slow to use copy_from_user

2011-11-21 Thread Ben Widawsky
On Mon, Nov 21, 2011 at 05:02:44PM +0100, Daniel Vetter wrote: > On Sun, Nov 20, 2011 at 09:56:32PM -0800, Ben Widawsky wrote: > [snip the patch] > > Bikeshed, but I would much prefer a #define for the swizzle > > bit/cacheline size. > > I've looked at this stuff way

[Intel-gfx] [PATCH 02/13] drm/i915: rewrite shmem_pwrite_slow to use copy_from_user

2011-11-21 Thread Ben Widawsky
On Mon, Nov 21, 2011 at 09:55:07AM -0800, Ben Widawsky wrote: > On Mon, Nov 21, 2011 at 05:02:44PM +0100, Daniel Vetter wrote: > > On Sun, Nov 20, 2011 at 09:56:32PM -0800, Ben Widawsky wrote: > > [snip the patch] > > > Bikeshed, but I would much prefer a #define f

[Intel-gfx] [PATCH 06/13] drm: add helper to clflush a virtual address range

2011-11-21 Thread Ben Widawsky
On Sun, Nov 06, 2011 at 08:13:53PM +0100, Daniel Vetter wrote: > Useful when the page is already mapped to copy date in/out. > > Cc: dri-devel at lists.freedesktop.org > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/drm_cache.c | 23 +++ > include/drm/drmP.h

[ANNOUNCE] libdrm 2.4.47

2013-10-12 Thread Ben Widawsky
Alex Deucher (2): radeon: add berlin pci ids radeon: pad CS to 8 DW Ben Widawsky (1): libdrm: bump to 2.4.47 Chia-I Wu (1): intel: silence valgrind warnings for unsynchronized maps Damien Lespiau (3): drm: Synchronize the stereo 3D mode flags from the kernel

Re: [ANNOUNCE] libdrm 2.4.47

2013-10-12 Thread Ben Widawsky
@bolo_yeung ~/intel-gfx/libdrm (master)$ md5sum libdrm-2.4.47.tar.gz 3ec2d63dbbbd357d386e39587e0d332f libdrm-2.4.47.tar.gz Sorry everyone for the confusion. I've PGP signed the mail in the hopes that we avoid needing to release for my blunder. On Fri, Oct 11, 2013 at 10:11:18AM -0700, Ben Wid

Re: [ANNOUNCE] libdrm 2.4.47

2013-10-12 Thread Ben Widawsky
On Sat, Oct 12, 2013 at 12:32:59PM -0700, Ben Widawsky wrote: > Regarding the checksums... > > The release script in xorg/util/modular failed for me during the > release. As a result, I had to munge the script to generate the announce > without rerunning the script (which the scri

[RE-ANNOUNCE] libdrm 2.4.47 (re-uploaded with correct checksums)

2013-10-12 Thread Ben Widawsky
who caught this error. Alex Deucher (2): radeon: add berlin pci ids radeon: pad CS to 8 DW Ben Widawsky (1): libdrm: bump to 2.4.47 Chia-I Wu (1): intel: silence valgrind warnings for unsynchronized maps Damien Lespiau (3): drm: Synchronize the stereo 3D mode flags

Re: [PATCH v6] drm: add fourcc codes for 16bit R and RG

2017-01-11 Thread Ben Widawsky
On 17-01-11 17:05:04, Ville Syrjälä wrote: On Thu, Jan 05, 2017 at 02:45:37PM +0100, Christian König wrote: Am 05.01.2017 um 12:37 schrieb Ville Syrjälä: > On Wed, Jan 04, 2017 at 07:38:55PM +0100, Rainer Hochecker wrote: >> From: Rainer Hochecker >> >> This adds fourcc codes for 16bit planes r

[PATCH 2/3] drm/i915: Add format modifiers for Intel

2017-01-11 Thread Ben Widawsky
This was based on a patch originally by Kristian. It has been modified pretty heavily to use the new callbacks from the previous patch. Cc: Kristian H. Kristensen Signed-off-by: Ben Widawsky --- drivers/gpu/drm/i915/intel_display.c | 109 ++- drivers/gpu/drm

[PATCH 0/3] GET_PLANE2 w/ i915 implementation

2017-01-11 Thread Ben Widawsky
://lists.freedesktop.org/archives/dri-devel/2016-December/127942.html Ben Widawsky (3): drm: Add new DRM_IOCTL_MODE_GETPLANE2 drm/i915: Add format modifiers for Intel drm/i915: Add support for GET_PLANE2 CCS modifiers drivers/gpu/drm/arc/arcpgu_crtc.c | 1 + drivers/gpu/drm/arm

[PATCH 3/3] drm/i915: Add support for GET_PLANE2 CCS modifiers

2017-01-11 Thread Ben Widawsky
Cc: Kristian Høgsberg Signed-off-by: Ben Widawsky --- drivers/gpu/drm/i915/intel_display.c | 10 -- drivers/gpu/drm/i915/intel_sprite.c | 2 ++ 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c

[PATCH 1/3] drm: Add new DRM_IOCTL_MODE_GETPLANE2

2017-01-11 Thread Ben Widawsky
e the modifiers array a sentinel based structure instead of a sized one. Upon discussion on IRC, it was determined that having an invalid modifier might make sense in general as well. References: https://patchwork.kernel.org/patch/9482393/ Signed-off-by: Ben Widawsky --- drivers/gpu/drm/ar

Re: [PATCH 2/3] drm/i915: Add format modifiers for Intel

2017-01-12 Thread Ben Widawsky
On 17-01-12 12:51:20, Ville Syrjälä wrote: On Wed, Jan 11, 2017 at 04:51:17PM -0800, Ben Widawsky wrote: This was based on a patch originally by Kristian. It has been modified pretty heavily to use the new callbacks from the previous patch. Cc: Kristian H. Kristensen Signed-off-by: Ben

Re: [PATCH 2/3] drm/i915: Add format modifiers for Intel

2017-01-12 Thread Ben Widawsky
On 17-01-12 20:32:07, Ville Syrjälä wrote: On Thu, Jan 12, 2017 at 10:00:55AM -0800, Ben Widawsky wrote: On 17-01-12 12:51:20, Ville Syrjälä wrote: >On Wed, Jan 11, 2017 at 04:51:17PM -0800, Ben Widawsky wrote: >> This was based on a patch originally by Kristian. It has been modified

[PATCH 01/10] intel: shared header for shader debugging

2011-07-13 Thread Ben Widawsky
Signed-off-by: Ben Widawsky --- intel/Makefile.am |3 ++- intel/intel_debug.h | 44 2 files changed, 46 insertions(+), 1 deletions(-) diff --git a/intel/Makefile.am b/intel/Makefile.am index b6a9014..7a44aaf 100644 --- a/intel/Makefile.am

[PATCH 0/10] fs shader debugging

2011-07-13 Thread Ben Widawsky
Version 2 of the patch series is pretty much the same as version 1. 2 of the patches have already been picked up by the kernel and mesa so they are gone. The only major change is in mesa where I no longer load a binary blob from an environment variable, but instead compile the bytes directly in

[PATCH 0/10] fs shader debugging

2011-07-13 Thread Ben Widawsky
On Wed, Jul 13, 2011 at 01:51:42PM -0700, Ben Widawsky wrote: > > > Version 2 of the patch series is pretty much the same as version 1. 2 of the > patches have already been picked up by the kernel and mesa so they are > gone. > > The only major change is in mesa where I no

[PATCH 00/10] fs debugging: incorporated Chris' feedback

2011-07-17 Thread Ben Widawsky
This is the revised patch series for fragment shader debugging. There is no major change, though of interest are: * forcewaked acts more like a daemon * forcewaked isn't needed for debugging only there for sample * i915 detection is now done by stating i915_forcewake_user_lock * register r

[PATCH 01/10] intel: shared header for shader debugging

2011-07-17 Thread Ben Widawsky
Cc: Chris Wilson Signed-off-by: Ben Widawsky --- intel/Makefile.am |3 ++- intel/intel_debug.h | 44 2 files changed, 46 insertions(+), 1 deletions(-) diff --git a/intel/Makefile.am b/intel/Makefile.am index b6a9014..7a44aaf 100644 --- a

[Intel-gfx] [PATCH 01/10] intel: shared header for shader debugging

2011-07-21 Thread Ben Widawsky
On Tue, Jul 19, 2011 at 11:06:17PM +0200, Julien Cristau wrote: > On Wed, Jul 13, 2011 at 13:51:43 -0700, Ben Widawsky wrote: > > > +#define SHADER_DEBUG_SOCKET "/tmp/gen_debug" > > Not sure what this is used for, but does it really need to be in /tmp? It is the s

[Intel-gfx] [PATCH 01/10] intel: shared header for shader debugging

2011-07-27 Thread Ben Widawsky
On Thu, Jul 21, 2011 at 11:22:12PM +0200, Julien Cristau wrote: > On Thu, Jul 21, 2011 at 13:54:41 +0000, Ben Widawsky wrote: > > > On Tue, Jul 19, 2011 at 11:06:17PM +0200, Julien Cristau wrote: > > > On Wed, Jul 13, 2011 at 13:51:43 -0700, Ben Widawsky wrote: &g

[Intel-gfx] [PATCH 01/10] intel: shared header for shader debugging

2011-07-27 Thread Ben Widawsky
On Wed, Jul 27, 2011 at 05:16:31PM +0200, Julien Cristau wrote: > On Wed, Jul 27, 2011 at 15:08:08 +0000, Ben Widawsky wrote: > > > On Thu, Jul 21, 2011 at 11:22:12PM +0200, Julien Cristau wrote: > > > On Thu, Jul 21, 2011 at 13:54:41 +, Ben Widawsky wrote: > > >

[PATCH] drm/i915: yet another forcewake lock fix

2011-06-16 Thread Ben Widawsky
Resume is missing a locks on gt sleepable registers. --- drivers/gpu/drm/i915/i915_suspend.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_suspend.c b/drivers/gpu/drm/i915/i915_suspend.c index 60a94d2..9259dcf 100644 --- a/drivers/gpu/drm/i91

[PATCH 01/11] intel: shared header for shader debugging

2011-06-24 Thread Ben Widawsky
Signed-off-by: Ben Widawsky --- intel/Makefile.am |3 ++- intel/intel_debug.h | 44 2 files changed, 46 insertions(+), 1 deletions(-) diff --git a/intel/Makefile.am b/intel/Makefile.am index b6a9014..7a44aaf 100644 --- a/intel/Makefile.am

[Intel-gfx] linux-next: build failure after merge of the drm-intel tree

2014-03-18 Thread Ben Widawsky
option set :-( The woe of using localmodconfig. I > should have picked the box with the i915. :-/ > > Below is the fix. I'll repost a v2 of the original patch. > > Sorry about that. > I was about to send out the same fix when I saw this. Reviewed-by: Ben Widawsky &

[PATCH 20/34] drm/doc: Repleace LOCKING kerneldoc sections in drm_modes.c

2014-03-21 Thread Ben Widawsky
Mar 20 01:14:21 crydee kernel: [] > __pci_register_driver+0x5b/0x5e > Mar 20 01:14:21 crydee kernel: [] ? 0xffffa01c0fff > Mar 20 01:14:21 crydee kernel: [] > drm_pci_init+0x69/0xec [drm] > Mar 20 01:14:21 crydee kernel: [] ? 0xa01c0fff > Mar 20 01:14:21 crydee kernel: [] > radeon_init+0x97/0xb5 [radeon] > > Dave. i915 gets 3 distinct WARNs from this patch. -- Ben Widawsky, Intel Open Source Technology Center

[drm-intel:drm-intel-nightly 40/142] drivers/gpu/drm/i915/i915_sysfs.c:228:49: error: 'rc6_attr_group' undeclared

2012-09-18 Thread Ben Widawsky
dev.kobj, > &rc6_attr_group); >229} > > --- > 0-DAY kernel build testing backend Open Source Technology Centre > Fengguang Wu, Yuanhan Liu Intel Corporation Darn. I'll send a patch to the list tonight. (It's weird because I thought I tested this). -- Ben Widawsky, Intel Open Source Technology Center

[PATCH] drm/i915: Fix !CONFIG_PM sysfs for real this time

2012-09-19 Thread Ben Widawsky
Somehow this hunk got dropped from my last patch. We do not have the rc6_attrs when there is no CONFIG_PM so this causes a compilation error. Reported-by: Fengguang Wu Signed-off-by: Ben Widawsky --- drivers/gpu/drm/i915/i915_sysfs.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a

[PATCH 4/5] drm: WARN when removing unallocated node

2013-08-09 Thread Ben Widawsky
an not frequently occuring error path. Another was fixed during patch iteration, so it's hard to see from the patch: commit c6cfb325677ea6305fb19acf3a4d14ea267f923e Author: Ben Widawsky Date: Fri Jul 5 14:41:06 2013 -0700 drm/i915: Embed drm_mm_node in i915 gem obj >From the i

[PATCH 00/25] i915 HW context support

2012-06-04 Thread Ben Widawsky
Setting myself up for a late night crying session once again. Most of the people reading this probably know the history and reasons for the patches. If not, you can search the intel-gfx mailing list to try to learn more. I won't recap the whole thing here, and instead let the patches speak for them

[PATCH 17/25] intel: wait render placeholder

2012-06-04 Thread Ben Widawsky
The patches have already been sucked in to the kernel. So we need a placeholder for this IOCTL until the libdrm wait render patches land. --- include/drm/i915_drm.h |1 + 1 file changed, 1 insertion(+) diff --git a/include/drm/i915_drm.h b/include/drm/i915_drm.h index af3ce17..6d9a9f1 100644

[PATCH 18/25] intel: Merge updated kernel header

2012-06-04 Thread Ben Widawsky
Signed-off-by: Ben Widawsky --- include/drm/i915_drm.h | 24 +++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/include/drm/i915_drm.h b/include/drm/i915_drm.h index 6d9a9f1..0ca2d4f 100644 --- a/include/drm/i915_drm.h +++ b/include/drm/i915_drm.h @@ -192,6

[PATCH 19/25] intel/context: Add drm_intel_context type

2012-06-04 Thread Ben Widawsky
Add an opaque type representing a HW context. Signed-off-by: Ben Widawsky --- intel/intel_bufmgr.h |1 + intel/intel_bufmgr_priv.h |5 + 2 files changed, 6 insertions(+) diff --git a/intel/intel_bufmgr.h b/intel/intel_bufmgr.h index c197abc..83a43cb 100644 --- a/intel

[PATCH 20/25] intel/context: new execbuf interface for contexts

2012-06-04 Thread Ben Widawsky
To support this we extract the common execbuf2 functionality to be called with, or without contexts. The context'd execbuf does not support some of the dri1 stuff. Signed-off-by: Ben Widawsky --- intel/intel_bufmgr.h |5 + intel/intel_bufmgr_gem.c |

[PATCH 21/25] intel: add decoding of MI_SET_CONTEXT

2012-06-04 Thread Ben Widawsky
Signed-off-by: Ben Widawsky --- intel/intel_decode.c | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/intel/intel_decode.c b/intel/intel_decode.c index bf23706..5f90a47 100644 --- a/intel/intel_decode.c +++ b/intel/intel_decode.c @@ -139,6 +139,22

[PATCH 25/25] i965: hw context support

2012-06-04 Thread Ben Widawsky
Based off of a patch from Ken Graunke. I just modified it for a more modern mesa (also don't allow contexts on blit ring). Signed-off-by: Ben Widawsky --- src/mesa/drivers/dri/i965/brw_context.c|1 + src/mesa/drivers/dri/i965/brw_vtbl.c |5 - src/mesa/driver

[Intel-gfx] [PATCH 25/25] i965: hw context support

2012-06-04 Thread Ben Widawsky
On Mon, 4 Jun 2012 16:01:54 -0700 Paul Berry wrote: > On 4 June 2012 14:43, Ben Widawsky wrote: > > > Based off of a patch from Ken Graunke. I just modified it for a more > > modern mesa (also don't allow contexts on blit ring). > > > > Signed-off-by:

[Mesa-dev] [PATCH 00/25] i915 HW context support

2012-06-05 Thread Ben Widawsky
we'd like to get it in place; we can cut more state uploads > and tune Mesa further once it's there. Also, my testing was far from comprehensive. -- Ben Widawsky, Intel Open Source Technology Center

[PATCH 1/3] intel: sanitize i915_drm.h

2012-06-05 Thread Ben Widawsky
run make headers_isntall on d-i-n, copy to here Signed-off-by: Ben Widawsky --- include/drm/i915_drm.h |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/include/drm/i915_drm.h b/include/drm/i915_drm.h index af3ce17..725a8de 100644 --- a/include/drm/i915_drm.h +++ b

[PATCH 2/3] intel: wait render header updates

2012-06-05 Thread Ben Widawsky
make headers_install in kernel. Copy to here. Signed-off-by: Ben Widawsky --- include/drm/i915_drm.h | 11 +++ 1 file changed, 11 insertions(+) diff --git a/include/drm/i915_drm.h b/include/drm/i915_drm.h index 725a8de..1881f8a 100644 --- a/include/drm/i915_drm.h +++ b/include/drm

[PATCH 3/3] intel: wait render timeout implementation

2012-06-05 Thread Ben Widawsky
int drm_intel_gem_bo_wait(drm_intel_bo *bo, uint64_t timeout_ns) This should bump the libdrm version. We're waiting for context support so we can do both features in one bump. v2: don't return remaining timeout amount use get param and fallback for older kernels Signed-off-by: Be

[PATCH 3/3] intel: wait render timeout implementation

2012-06-05 Thread Ben Widawsky
am at init Signed-off-by: Ben Widawsky --- intel/intel_bufmgr.h |1 + intel/intel_bufmgr_gem.c | 30 ++ 2 files changed, 31 insertions(+) diff --git a/intel/intel_bufmgr.h b/intel/intel_bufmgr.h index c197abc..10ccc25 100644 --- a/intel/intel_bufmgr.h +

[PATCH 2/3] intel: wait render header updates

2012-06-05 Thread Ben Widawsky
make headers_install in kernel. Copy to here. v2: signed ns_timeout Cc: Chris Wilson Signed-off-by: Ben Widawsky --- include/drm/i915_drm.h | 11 +++ 1 file changed, 11 insertions(+) diff --git a/include/drm/i915_drm.h b/include/drm/i915_drm.h index 725a8de..4931107 100644 --- a

[PATCH 3/3] intel: wait render timeout implementation

2012-06-05 Thread Ben Widawsky
am at init prototypes now have a signed input value Cc: Chris Wilson Signed-off-by: Ben Widawsky --- intel/intel_bufmgr.h |1 + intel/intel_bufmgr_gem.c | 30 ++ 2 files changed, 31 insertions(+) diff --git a/intel/intel_bufmgr.h b/intel/intel_bufmgr.h ind

[PATCH 2/3] intel: wait render header updates

2012-06-06 Thread Ben Widawsky
On Tue, 5 Jun 2012 15:42:39 -0700 Ben Widawsky wrote: > make headers_install in kernel. Copy to here. > > v2: signed ns_timeout > > Cc: Chris Wilson > Signed-off-by: Ben Widawsky This has been pushed with IRC Acked-by Kenneth Graunke > --- > inclu

[PATCH 1/3] intel: sanitize i915_drm.h

2012-06-06 Thread Ben Widawsky
On Tue, 5 Jun 2012 11:58:11 -0700 Ben Widawsky wrote: > run make headers_isntall on d-i-n, copy to here > > Signed-off-by: Ben Widawsky This has been pushed with IRC Acked-by Kenneth Graunke > --- > include/drm/i915_drm.h |4 +++- > 1 file changed, 3 inserti

<    1   2   3   4   >