On 17-03-29 23:17:13, Ville Syrjälä wrote:
On Fri, Mar 24, 2017 at 02:29:50PM -0700, Ben Widawsky wrote:
This was based on a patch originally by Kristian. It has been modified
pretty heavily to use the new callbacks from the previous patch.
v2:
- Add LINEAR and Yf modifiers to list (Ville
make sprite and cursor have separate functions
---
Ville, I think this addresses most of your comments. I'm guessing you're going
to ask for separate gen sprite plane functions, but I think this looks pretty
decent as is.
---
drivers/gpu/drm/i915/intel_display.c | 26 --
drivers
. Kristensen
Signed-off-by: Ben Widawsky
---
drivers/gpu/drm/i915/intel_display.c | 132 +--
drivers/gpu/drm/i915/intel_sprite.c | 76 +++-
2 files changed, 202 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b
o the binary blob props, so if anyone has a strong opinion on how it should
look, please speak now. Otherwise, I'll just wire up something.
--
Ben Widawsky, Intel Open Source Technology Center
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
ht
On 17-04-28 14:11:56, Lucas Stach wrote:
Hi Ben,
Am Dienstag, den 04.04.2017, 12:41 -0700 schrieb Ben Widawsky:
On 17-04-04 11:07:26, Daniel Stone wrote:
>Hi,
>
>On 1 April 2017 at 19:47, Rob Clark wrote:
>> On Tue, Dec 20, 2016 at 7:12 PM, Kristian H. Kristensen
>> wrot
. Kristensen
Signed-off-by: Ben Widawsky
---
drivers/gpu/drm/i915/intel_display.c | 131 +--
drivers/gpu/drm/i915/intel_sprite.c | 76 +++-
2 files changed, 201 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b
Updated blob layout (Rob, Daniel, Kristian, xerpi)
Cc: Rob Clark
Cc: Daniel Stone
Cc: Kristian H. Kristensen
Signed-off-by: Ben Widawsky
---
drivers/gpu/drm/drm_mode_config.c | 7 +++
drivers/gpu/drm/drm_plane.c | 119 ++
include/drm
v2: A minor addition from Daniel
Cc: Daniel Stone
Signed-off-by: Ben Widawsky
---
drivers/gpu/drm/arc/arcpgu_crtc.c | 1 +
drivers/gpu/drm/arm/hdlcd_crtc.c| 1 +
drivers/gpu/drm/arm/malidp_planes.c | 2 +-
drivers/gpu/drm/armada/armada_crtc.c
.kernel.org/patch/9482393/
Signed-off-by: Ben Widawsky
---
drivers/gpu/drm/arc/arcpgu_crtc.c | 1 +
drivers/gpu/drm/arm/hdlcd_crtc.c| 1 +
drivers/gpu/drm/arm/malidp_planes.c | 2 +-
drivers/gpu/drm/armada/armada_crtc.c| 1 +
drivers/gpu/dr
ces: https://patchwork.kernel.org/patch/9482393/
Signed-off-by: Ben Widawsky
---
drivers/gpu/drm/arc/arcpgu_crtc.c | 1 +
drivers/gpu/drm/arm/hdlcd_crtc.c| 1 +
drivers/gpu/drm/arm/malidp_planes.c | 2 +-
drivers/gpu/drm/armada/armada_crtc.c
>
> v2: Drop the 'dev' argument from the hook
> v3: Include the description of the CCS surface layout
>
> Cc: Vandana Kannan
> Cc: Daniel Vetter
> Cc: Ben Widawsky
> Cc: Jason Ekstrand
> Reviewed-by: Ben Widawsky
> Signed-off-by: Ville Syrjälä
> ---
> dri
From: Ben Widawsky
Signed-off-by: Ben Widawsky
---
intel/intel_chipset.h | 13 ++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/intel/intel_chipset.h b/intel/intel_chipset.h
index 514f659..41fc0da 100644
--- a/intel/intel_chipset.h
+++ b/intel/intel_chipset.h
Acked-by: Ben Widawsky
On 16-11-16 13:33:16, Ville Syrjälä wrote:
>From: Ville Syrjälä
>
>It has been suggested that having per-plane modifiers is making life
>more difficult for userspace, so let's just retire modifier[1-3] and
>use modifier[0] to apply to th
rs. But that does sound a bit wasteful space wise.
>
>Cc: Ben Widawsky
>Cc: intel-gfx at lists.freedesktop.org
>Signed-off-by: Ville Syrjälä
I have a comment below however, you can consider it:
Reviewed-by: Ben Widawsky
>---
> drivers/gpu/drm/i915/intel_display.c | 37 +
ent adjustments (Liviu)
v5: Some new platforms added due to rebase
v6: Add some missed plane inits (or maybe they're new - who knows at
this point) (Daniel)
Signed-off-by: Ben Widawsky
Reviewed-by: Daniel Stone (v2)
Reviewed-by: Liviu Dudau
---
drivers/gpu/drm/arc/arcpgu_crtc.c
v2:
Support sprite plane.
Support pipe C/D limitation on GEN9.
This requires rebase on the correct Ville patches
Cc: Daniel Stone
Cc: Kristian Høgsberg
Signed-off-by: Ben Widawsky
---
drivers/gpu/drm/i915/intel_display.c | 34 +--
drivers/gpu/drm/i915
of things came
up and it took a while to spin this rev. Nothing was missing intentionally.
[1] The bitmask is used to show the connection between which modifiers are
supported by which formats.
Ben Widawsky (4):
drm: Plumb modifiers through plane init
drm: Create a format/modifier blob
drm
funcs (Emil)
- Use unreachable (Emil)
v7:
- Only allow Intel modifiers and LINEAR (Ben)
v8
- Fix spite assert introduced in v6 (Daniel)
Cc: Ville Syrjälä
Cc: Kristian H. Kristensen
Cc: Emil Velikov
Signed-off-by: Ben Widawsky
---
drivers/gpu/drm/i915/intel_display.c | 136
viu)
* Fix data types (Ben)
* Make the blob part of uapi (Daniel)
v3:
Remove unused ret field.
Change i, and j to unsigned int (Emil)
v4:
Use plane->modifier_count instead of recounting (Daniel)
Cc: Rob Clark
Cc: Kristian H. Kristensen
Signed-off-by: Ben Widawsky
Reviewed-by: Daniel Ston
ces,
and eg. 90/270 degree rotation is not supported in combination with
decompression either.
This patch may contain work from at least the following people:
* Vandana Kannan
* Daniel Vetter
* Ben Widawsky
v2: Deal with display workarounds 0390, 0531, 1125 (Paulo)
Cc: Paulo Zanoni
Cc: Van
ces,
and eg. 90/270 degree rotation is not supported in combination with
decompression either.
This patch may contain work from at least the following people:
* Vandana Kannan
* Daniel Vetter
* Ben Widawsky
v2: Deal with display workarounds 0390, 0531, 1125 (Paulo)
Cc: Paulo Zanoni
Cc: Van
On 17-03-01 12:51:17, Ville Syrjälä wrote:
On Tue, Feb 28, 2017 at 03:20:38PM -0800, Ben Widawsky wrote:
On 17-02-28 12:18:39, Jason Ekstrand wrote:
>I've said it before but reading through Ben's patches again make me want to
>be peskier about it. I would really like the U
t the restriction.
Let's start to round up when computing the color plane dimesions
so that we'll not end up with too low an estimate for the memory
requirements and whatnot.
Cc: Ben Widawsky
Cc: Jason Ekstrand
Signed-off-by: Ville Syrjälä
Both 1 and 2 are:
Reviewed-by: Ben Widawsky
"Kristian H. Kristensen"
References: https://patchwork.kernel.org/patch/9482393/
Signed-off-by: Ben Widawsky
---
drivers/gpu/drm/arc/arcpgu_crtc.c | 1 +
drivers/gpu/drm/arm/hdlcd_crtc.c| 1 +
drivers/gpu/drm/arm/malidp_planes.c | 2 +-
dri
)
v3:
- Handle cursor formats (Ville)
- Put handling for LINEAR in the mod_support functions (Ville)
Cc: Ville Syrjälä
Cc: Kristian H. Kristensen
Signed-off-by: Ben Widawsky
---
drivers/gpu/drm/i915/intel_display.c | 112 +--
drivers/gpu/drm/i915/intel_sprite.c
They're the same, so use the one which makes more sense.
Signed-off-by: Ben Widawsky
---
drivers/gpu/drm/i915/intel_display.c | 28 ++--
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm
On 17-05-03 14:45:26, Daniel Stone wrote:
Hi Liviu,
On 3 May 2017 at 11:34, Liviu Dudau wrote:
On Tue, May 02, 2017 at 10:14:26PM -0700, Ben Widawsky wrote:
v2: A minor addition from Daniel
You are *really* pushing your luck by not Cc-ing *any* of the maintainers of
the drivers you touch
s not the only IP capable of producing AFBC data, so there might be
another driver
in the making that will be open source.
Best regards,
Liviu
But besides that, it works
perfectly fine for arm render compression format too.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.c
On 17-05-10 18:24:52, Liviu Dudau wrote:
On Wed, May 10, 2017 at 09:34:40AM -0700, Ben Widawsky wrote:
On 17-05-03 18:30:07, Liviu Dudau wrote:
> On Wed, May 03, 2017 at 06:45:05PM +0200, Daniel Vetter wrote:
> > On Wed, May 03, 2017 at 03:52:23PM +0100, Liviu Dudau wrote:
> > &
On 17-05-03 14:15:15, Liviu Dudau wrote:
On Tue, May 02, 2017 at 10:14:27PM -0700, Ben Widawsky wrote:
Updated blob layout (Rob, Daniel, Kristian, xerpi)
Cc: Rob Clark
Cc: Daniel Stone
Cc: Kristian H. Kristensen
Signed-off-by: Ben Widawsky
---
drivers/gpu/drm/drm_mode_config.c | 7
On 17-05-03 17:08:27, Daniel Vetter wrote:
On Tue, May 02, 2017 at 10:14:27PM -0700, Ben Widawsky wrote:
Updated blob layout (Rob, Daniel, Kristian, xerpi)
Cc: Rob Clark
Cc: Daniel Stone
Cc: Kristian H. Kristensen
Signed-off-by: Ben Widawsky
---
drivers/gpu/drm/drm_mode_config.c | 7
. Kristensen
Signed-off-by: Ben Widawsky
---
drivers/gpu/drm/i915/intel_display.c | 131 +--
drivers/gpu/drm/i915/intel_sprite.c | 76 +++-
2 files changed, 201 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b
viu)
* Fix data types (Ben)
* Make the blob part of uapi (Daniel)
Cc: Rob Clark
Cc: Daniel Stone
Cc: Kristian H. Kristensen
Cc: Liviu Dudau
Signed-off-by: Ben Widawsky
Reviewed-by: Daniel Stone
---
drivers/gpu/drm/drm_mode_config.c | 7 +++
drivers/gpu/drm/drm_plane.c |
-by: Daniel Stone (v2)
Signed-off-by: Ben Widawsky
---
drivers/gpu/drm/arc/arcpgu_crtc.c | 1 +
drivers/gpu/drm/arm/hdlcd_crtc.c| 1 +
drivers/gpu/drm/arm/malidp_planes.c | 2 +-
drivers/gpu/drm/armada/armada_crtc.c| 1 +
drivers/gpu/drm/arm
On 17-05-17 13:31:44, Daniel Vetter wrote:
On Tue, May 16, 2017 at 02:19:12PM -0700, Ben Widawsky wrote:
On 17-05-03 17:08:27, Daniel Vetter wrote:
> On Tue, May 02, 2017 at 10:14:27PM -0700, Ben Widawsky wrote:
> > +struct drm_format_modifier_blob {
> > +#define FORMAT
On 17-05-17 11:17:57, Liviu Dudau wrote:
On Tue, May 16, 2017 at 02:31:24PM -0700, Ben Widawsky wrote:
This is the plumbing for supporting fb modifiers on planes. Modifiers
have already been introduced to some extent, but this series will extend
this to allow querying modifiers per plane. Based
On 17-05-17 01:06:16, Emil Velikov wrote:
Hi Ben,
On 16 May 2017 at 22:31, Ben Widawsky wrote:
Updated blob layout (Rob, Daniel, Kristian, xerpi)
v2:
* Removed __packed, and alignment (.+)
* Fix indent in drm_format_modifier fields (Liviu)
* Remove duplicated modifier > 64 check (Li
On 17-05-17 01:20:50, Emil Velikov wrote:
Hi Ben,
A couple of small questions/suggestions that I hope you find useful.
Please don't block any of this work based on my comments.
On 16 May 2017 at 22:31, Ben Widawsky wrote:
+static bool intel_primary_plane_format_mod_supported(s
Don't pass 'dev' to the new hook (Laurent)
>
>Cc: Laurent Pinchart
>Cc: Ben Widawsky
>Signed-off-by: Ville Syrjälä
>---
> drivers/gpu/drm/drm_fb_cma_helper.c | 2 +-
> drivers/gpu/drm/drm_fourcc.c | 25 +
> driv
l planes will be capable of scanning out compressed surfaces,
>and eg. 90/270 degree rotation is not supported in combination with
>decompression either.
>
>This patch may contain work from at least the following people:
>* Vandana Kannan
>* Daniel Vetter
>* Ben Widawsky
>
>
ise.
>>
>>v2: Drop the 'dev' argument from the hook
>>v3: Include the description of the CCS surface layout
>>
>>Cc: Vandana Kannan
>>Cc: Daniel Vetter
>>Cc: Ben Widawsky
>>Cc: Jason Ekstrand
>>Reviewed-by: Ben Widawsky
>>Signed
o figure out which parts came from where.
>
>Entire series available here:
>git://github.com/vsyrjala/linux.git fb_format_dedup_4_ccs
>
>Cc: Vandana Kannan
>Cc: Daniel Vetter
>Cc: Ben Widawsky
>Cc: Jason Ekstrand
>Cc: Laurent Pinchart
>
In addition to review c
On Tue, Feb 16, 2016 at 03:42:45PM -0800, Ben Widawsky wrote:
> A new list yielded new devices that apparently have shipped, or will ship.
>
> v2: I can't read. 0x192d is GT3
>
> Signed-off-by: Ben Widawsky
> ---
> intel/intel_chipset.h | 11 ---
> 1 fil
an not frequently occuring error path. Another was fixed during
patch iteration, so it's hard to see from the patch:
commit c6cfb325677ea6305fb19acf3a4d14ea267f923e
Author: Ben Widawsky
Date: Fri Jul 5 14:41:06 2013 -0700
drm/i915: Embed drm_mm_node in i915 gem obj
>From the i
an not frequently occuring error path. Another was fixed during
patch iteration, so it's hard to see from the patch:
commit c6cfb325677ea6305fb19acf3a4d14ea267f923e
Author: Ben Widawsky
Date: Fri Jul 5 14:41:06 2013 -0700
drm/i915: Embed drm_mm_node in i915 gem obj
>From the i
On Mon, Aug 19, 2013 at 09:59:14AM +0300, Dan Carpenter wrote:
> Hello Ben Widawsky,
>
> Here is another use after free warning. It's some new static checker
> stuff that I haven't pushed because it has lots of false postives.
>
> The patch f7795b1d0b47: "drm/
(r);
>+ r = 0;
> }
>
> err_allocs:
> drmFree(U642VOID(ovr.format_type_ptr));
>+ drmFree(U642VOID(ovr.format_modifier_ptr));
>
> return r;
> }
>
>+drmModePlanePtr drmModeGetPlane2(int fd, uint32_t plane_id)
>+{
>+ drmModePlaneP
On 16-12-20 16:13:33, Kristian H. Kristensen wrote:
>From: "Kristian H. Kristensen"
>
>BUG=chrome-os-partner:56407
>TEST=modetest on a KMS driver that exposes modifiers should print those
>
>Change-Id: I91b2a408b1c8f112d7ba5d0998119b3c800b199c
>---
> tests/modetest/modetest.c | 40
A new list yielded new devices that apparently have shipped, or will ship.
Signed-off-by: Ben Widawsky
---
intel/intel_chipset.h | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/intel/intel_chipset.h b/intel/intel_chipset.h
index 35148e5..392f7ba 100644
--- a/intel
A new list yielded new devices that apparently have shipped, or will ship.
v2: I can't read. 0x192d is GT3
Signed-off-by: Ben Widawsky
---
intel/intel_chipset.h | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/intel/intel_chipset.h b/intel/intel_chipset.h
an not frequently occuring error path. Another was fixed during
patch iteration, so it's hard to see from the patch:
commit c6cfb325677ea6305fb19acf3a4d14ea267f923e
Author: Ben Widawsky
Date: Fri Jul 5 14:41:06 2013 -0700
drm/i915: Embed drm_mm_node in i915 gem obj
>From the i
On Mon, Aug 19, 2013 at 09:59:14AM +0300, Dan Carpenter wrote:
> Hello Ben Widawsky,
>
> Here is another use after free warning. It's some new static checker
> stuff that I haven't pushed because it has lots of false postives.
>
> The patch f7795b1d0b47: "drm/
't fully know how it
works yet. Trying to fully describe it is premature.
Signed-off-by: Jason Ekstrand
Cc: Ben Widawsky
Cc: Ville Syrjälä
---
include/uapi/drm/drm_fourcc.h | 35 ++-
1 file changed, 22 insertions(+), 13 deletions(-)
diff --git a/include/uapi/d
some point.
v5:
Rename modifiers to modifiers_property (Ville)
Use sizeof(__u32) instead to reflect UAPI nature (Ville)
Make BUILD_BUG_ON for blob header size
Reviewed-by: Ben Widawsky
-Emil
___
dri-devel mailing list
dri-
hanging this, but tell me what you want.
BUILD_BUG_ON sounds good to me regardless.
[snip]
--
Ben Widawsky, Intel Open Source Technology Center
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
On 17-07-14 22:10:15, Ville Syrjälä wrote:
On Fri, Jul 14, 2017 at 11:41:49AM -0700, Ben Widawsky wrote:
On 17-06-29 22:49:44, Ville Syrjälä wrote:
[snip]
>
>... but here it's ALIGN(formats_offset+formats_size). I think we should
>be aligning the same thing in both case
On 17-06-29 23:02:08, Ville Syrjälä wrote:
On Fri, Jun 23, 2017 at 09:45:44AM -0700, Ben Widawsky wrote:
v2:
Support sprite plane.
Support pipe C/D limitation on GEN9.
This requires rebase on the correct Ville patches
Cc: Daniel Stone
Cc: Kristian Høgsberg
Signed-off-by: Ben Widawsky
interface will allow clients to create buffers for
scanout with a good set of modifiers, and later import those buffers (through
EGL already, and Vulkan WSI later) into a graphics runtime. EGL/WSI will provide
similar interfaces for rendering - modifiers which can be used for rendering.
Ben Widawsky (4
ent adjustments (Liviu)
v5: Some new platforms added due to rebase
v6: Add some missed plane inits (or maybe they're new - who knows at
this point) (Daniel)
Signed-off-by: Ben Widawsky
Reviewed-by: Daniel Stone (v2)
Reviewed-by: Liviu Dudau
---
drivers/gpu/drm/arc/arcpgu_crtc.c
v2:
Support sprite plane.
Support pipe C/D limitation on GEN9.
v3:
Rename structure (Ville)
Handle GLK (Ville)
This requires rebase on the correct Ville patches
Cc: Daniel Stone
Cc: Kristian Høgsberg
Signed-off-by: Ben Widawsky
---
drivers/gpu/drm/i915/intel_display.c | 30
)
- rename local variable intel_format_modifiers to modifiers (Ville)
- actually use sprite modifiers
- split out modifier/formats by platform (Ville)
Cc: Ville Syrjälä
Cc: Kristian H. Kristensen
Reviewed-by: Emil Velikov (v8)
Signed-off-by: Ben Widawsky
---
drivers/gpu/drm/i915
(Ville)
Make BUILD_BUG_ON for blob header size
Cc: Rob Clark
Cc: Kristian H. Kristensen
Signed-off-by: Ben Widawsky
Reviewed-by: Daniel Stone (v2)
Reviewed-by: Liviu Dudau (v2)
Reviewed-by: Emil Velikov (v3)
---
drivers/gpu/drm/drm_mode_config.c | 7
drivers/gpu/drm/drm_plane.c
that does sound a bit wasteful space wise.
v2: Drop the 'dev' argument from the hook
v3: Include the description of the CCS surface layout
v4: Pretend CCS tiles are regular 128 byte wide Y tiles (Jason)
Cc: Daniel Vetter
Cc: Ben Widawsky
Cc: Jason Ekstrand
Reviewed-by: Ben Widaw
rotation is not supported in combination
with
decompression either.
This patch may contain work from at least the following people:
* Vandana Kannan
* Daniel Vetter
* Ben Widawsky
v2: Deal with display workaro
ent adjustments (Liviu)
v5: Some new platforms added due to rebase
v6: Add some missed plane inits (or maybe they're new - who knows at
this point) (Daniel)
v7: Add sun8i (Daniel)
Signed-off-by: Ben Widawsky
Reviewed-by: Daniel Stone (v2)
Reviewed-by: Liviu Dudau
Acked-by: Philippe Cornu
(Ville)
Make BUILD_BUG_ON for blob header size
Cc: Rob Clark
Cc: Kristian H. Kristensen
Signed-off-by: Ben Widawsky
Reviewed-by: Daniel Stone (v2)
Reviewed-by: Liviu Dudau (v2)
Reviewed-by: Emil Velikov (v3)
---
drivers/gpu/drm/drm_mode_config.c | 7
drivers/gpu/drm/drm_plane.c
v2:
Support sprite plane.
Support pipe C/D limitation on GEN9.
v3:
Rename structure (Ville)
Handle GLK (Ville)
This requires rebase on the correct Ville patches
Cc: Daniel Stone
Cc: Kristian Høgsberg
Signed-off-by: Ben Widawsky
---
drivers/gpu/drm/i915/intel_display.c | 30
)
- rename local variable intel_format_modifiers to modifiers (Ville)
- actually use sprite modifiers
- split out modifier/formats by platform (Ville)
Cc: Ville Syrjälä
Cc: Kristian H. Kristensen
Reviewed-by: Emil Velikov (v8)
Signed-off-by: Ben Widawsky
---
drivers/gpu/drm/i915
On 17-07-29 13:53:10, Daniel Stone wrote:
Hi Ben,
On 26 July 2017 at 19:08, Ben Widawsky wrote:
+ } else if (INTEL_GEN(dev_priv) >= 9) {
intel_primary_formats = skl_primary_formats;
num_formats = ARRAY_SIZE(skl_primary_formats);
- modifi
On 17-07-31 10:29:55, Daniel Vetter wrote:
On Sat, Jul 29, 2017 at 09:25:50AM -0700, Ben Widawsky wrote:
On 17-07-29 13:53:10, Daniel Stone wrote:
> Hi Ben,
>
> On 26 July 2017 at 19:08, Ben Widawsky wrote:
> > + } else if (INTEL_GEN
rotation is not supported in combination
with
decompression either.
This patch may contain work from at least the following people:
* Vandana Kannan
* Daniel Vetter
* Ben Widawsky
v2: Deal with display workaro
that does sound a bit wasteful space wise.
v2: Drop the 'dev' argument from the hook
v3: Include the description of the CCS surface layout
v4: Pretend CCS tiles are regular 128 byte wide Y tiles (Jason)
Cc: Daniel Vetter
Cc: Ben Widawsky
Cc: Jason Ekstrand
Reviewed-by: Ben Widaw
(Ville)
Make BUILD_BUG_ON for blob header size
Cc: Rob Clark
Cc: Kristian H. Kristensen
Signed-off-by: Ben Widawsky
Reviewed-by: Daniel Stone (v2)
Reviewed-by: Liviu Dudau (v2)
Reviewed-by: Emil Velikov (v3)
---
drivers/gpu/drm/drm_mode_config.c | 7
drivers/gpu/drm/drm_plane.c
)
- rename local variable intel_format_modifiers to modifiers (Ville)
- actually use sprite modifiers
- split out modifier/formats by platform (Ville)
v10:
- Undo vendor check from v9
Cc: Ville Syrjälä
Cc: Kristian H. Kristensen
Reviewed-by: Emil Velikov (v8)
Signed-off-by: Ben
v2:
- Support sprite plane.
- Support pipe C/D limitation on GEN9.
v3:
- Rename structure (Ville)
- Handle GLK (Ville)
v4:
- Fix PIPE_C check, introduced in v2 (Daniel)
- Whitespace fix (Daniel)
Cc: Daniel Stone
Cc: Kristian Høgsberg
Signed-off-by: Ben Widawsky
---
drivers/gpu
ent adjustments (Liviu)
v5: Some new platforms added due to rebase
v6: Add some missed plane inits (or maybe they're new - who knows at
this point) (Daniel)
v7: Add sun8i (Daniel)
Signed-off-by: Ben Widawsky
Reviewed-by: Daniel Stone (v2)
Reviewed-by: Liviu Dudau
Acked-by: Philippe Cornu
On 17-08-01 15:43:50, Kenneth Graunke wrote:
On Tuesday, August 1, 2017 9:58:17 AM PDT Ben Widawsky wrote:
v2:
- Support sprite plane.
- Support pipe C/D limitation on GEN9.
v3:
- Rename structure (Ville)
- Handle GLK (Ville)
v4:
- Fix PIPE_C check, introduced in v2 (Daniel
On 17-08-02 12:14:15, Daniel Vetter wrote:
On Tue, Aug 01, 2017 at 09:14:50AM -0700, Ben Widawsky wrote:
On 17-07-31 10:29:55, Daniel Vetter wrote:
> On Sat, Jul 29, 2017 at 09:25:50AM -0700, Ben Widawsky wrote:
> > On 17-07-29 13:53:10, Daniel Stone wrote:
> > > Hi Ben,
>
On 17-08-03 10:08:51, Daniel Vetter wrote:
On Wed, Aug 2, 2017 at 5:43 PM, Ben Widawsky wrote:
On 17-08-02 12:14:15, Daniel Vetter wrote:
On Tue, Aug 01, 2017 at 09:14:50AM -0700, Ben Widawsky wrote:
On 17-07-31 10:29:55, Daniel Vetter wrote:
> On Sat, Jul 29, 2017 at 09:25:50AM -0700,
On 17-08-03 12:00:56, Daniel Stone wrote:
Hi,
On 1 August 2017 at 17:58, Ben Widawsky wrote:
@@ -1240,6 +1253,19 @@ intel_sprite_plane_create(struct drm_i915_private
*dev_priv,
plane_formats = skl_plane_formats;
num_plane_formats = ARRAY_SIZE(skl_plane_formats
> Ok, thanks. I will try.
>
> Best wishes
>
> Norbert
Hi Norbert. In addition to the above, if this truly appears to be
related to i/o, can we try to decrease the time to failure with some
serious i/o tests? Off the top of my head I am not sure what's
available, but surely Google should be able to find something.
--
Ben Widawsky, Intel Open Source Technology Center
tools.
>
> Cc: Arjan van de Ven
> Signed-off-by: Daniel Vetter
I can't help but think it's equally interesting to know when the queue
the work as well.
--
Ben Widawsky, Intel Open Source Technology Center
On 2012-09-01 11:28, Arjan van de Ven wrote:
> On 9/1/2012 11:26 AM, Ben Widawsky wrote:
>> On 2012-08-30 04:26, Daniel Vetter wrote:
>>> We've had and still have too many issues where the gpu turbot
>>> doesn't
>>> quite to what it's supposed
On 2012-09-01 12:22, Chris Wilson wrote:
> On Sat, 01 Sep 2012 11:35:13 -0700, Ben Widawsky
> wrote:
>> I have no problem with Daniel's patch. It's just a matter of cutting
>> through some scheduler BS of "when the GPU wants to change
>> frequency&q
On 2012-09-01 12:14, Daniel Vetter wrote:
> On Sat, Sep 1, 2012 at 8:35 PM, Ben Widawsky
> wrote:
>> On 2012-09-01 11:28, Arjan van de Ven wrote:
>>>
>>> On 9/1/2012 11:26 AM, Ben Widawsky wrote:
>>>>
>>>> On 2012-08-30 04:26, Daniel Vette
On 2012-09-01 19:44, Arjan van de Ven wrote:
> On 9/1/2012 6:36 PM, Ben Widawsky wrote:
>
>> It depends on what you're trying to measure. I think this patch is
>> quite useful but I think I'll make you defend your patch now since
>> you're the maintainer an
On 2012-09-01 20:06, Arjan van de Ven wrote:
> On 9/1/2012 8:05 PM, Ben Widawsky wrote:
>> , from a single trace event you should know the current frequency
>> and the previous frequency.
> but if you're doing a heavy game or whatever... you may stay at the
> highest al
42.html
Thanks.
--
Ben Widawsky, Intel Open Source Technology Center
On Sun, 9 Sep 2012 12:42:55 -0700
Ben Widawsky wrote:
> On the Intel driver we've developed and reviewed some patches which
> enable GPU frequency settings in sysfs. Similar interfaces have
> existed for some time in our debugfs, but now we're getting interest
> from users
ude/drm/drm.h |2 +
> > include/drm/drmP.h| 32 ++
> > include/drm/drm_crtc.h| 140 --
> > include/drm/drm_mode.h| 48 ++
> > 16 files changed, 1378 insertions(+), 600 deletions(-)
> > create mode 100644 drivers/staging/omapdrm/omap_atomic.c
> > create mode 100644 drivers/staging/omapdrm/omap_atomic.h
> >
> > --
> > 1.7.9.5
> >
> ___
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Ben Widawsky, Intel Open Source Technology Center
drivers/gpu/drm/i915/i915_drv.h:1545:2: warning: '__f' is static but
declared in inline function 'i915_gem_chipset_flush' which is not static
Reported-by: kbuild test robot
dri-devel-Reference: <50a4d41c.586vhmwghpukzbkb%fengguang...@intel.com>
Signed-off-by: Ben
4 has type 'long unsigned int'
Found by Fenguang's 0-DAY kernel build testing
Recommend to squash this in to, since it is not on an upstream branch
yet.
commit 00fc2c3c53d7bfc9a29e5f4bdf2677f0c399f3bc
Author: Ben Widawsky
Date: Thu Jan 17 12:45:14 2013 -0800
drm/i
bus->force_bit = true;
intel_gpio_setup(bus, port);
--
Ben Widawsky, Intel Open Source Technology Center
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
tter
I can't help but think it's equally interesting to know when the queue
the work as well.
--
Ben Widawsky, Intel Open Source Technology Center
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
On 2012-09-01 11:28, Arjan van de Ven wrote:
On 9/1/2012 11:26 AM, Ben Widawsky wrote:
On 2012-08-30 04:26, Daniel Vetter wrote:
We've had and still have too many issues where the gpu turbot
doesn't
quite to what it's supposed to do (or what we want it to do).
Adding a trac
On 2012-09-01 12:22, Chris Wilson wrote:
On Sat, 01 Sep 2012 11:35:13 -0700, Ben Widawsky
wrote:
I have no problem with Daniel's patch. It's just a matter of cutting
through some scheduler BS of "when the GPU wants to change
frequency"
vs. "when we actually change th
On 2012-09-01 12:14, Daniel Vetter wrote:
On Sat, Sep 1, 2012 at 8:35 PM, Ben Widawsky
wrote:
On 2012-09-01 11:28, Arjan van de Ven wrote:
On 9/1/2012 11:26 AM, Ben Widawsky wrote:
On 2012-08-30 04:26, Daniel Vetter wrote:
We've had and still have too many issues where the gpu t
On 2012-09-01 19:44, Arjan van de Ven wrote:
On 9/1/2012 6:36 PM, Ben Widawsky wrote:
It depends on what you're trying to measure. I think this patch is
quite useful but I think I'll make you defend your patch now since
you're the maintainer and you took
your own patch and
On 2012-09-01 20:06, Arjan van de Ven wrote:
On 9/1/2012 8:05 PM, Ben Widawsky wrote:
, from a single trace event you should know the current frequency
and the previous frequency.
but if you're doing a heavy game or whatever... you may stay at the
highest all the time,
and I get no inform
42.html
Thanks.
--
Ben Widawsky, Intel Open Source Technology Center
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
1 - 100 of 384 matches
Mail list logo
