Re: [PATCH v3 2/2] drm/tidss: Add support for AM625 DSS

2022-08-08 Thread Aradhya Bhatia
Hi Tomi, On 28-Jul-22 17:34, Tomi Valkeinen wrote: On 27/06/2022 18:12, Aradhya Bhatia wrote: Add support for the DSS IP on TI's new AM625 SoC in the tidss driver. Signed-off-by: Aradhya Bhatia Reviewed-by: Rahul T R ---   drivers/gpu/drm/tidss/tidss_dispc.c

[RFC PATCH v5 1/6] dt-bindings: display: ti, am65x-dss: Add am625 dss compatible

2022-09-28 Thread Aradhya Bhatia
Add ti,am625-dss compatible string. The DSS IP on TI's AM625 SoC is an update from the DSS on TI's AM65X SoC. The former has an additional OLDI TX to enable a 2K resolution on OLDI displays or enable 2 duplicated displays with a smaller resolution. Signed-off-by: Aradhya Bhatia R

[RFC PATCH v5 4/6] drm/tidss: Add support to configure OLDI mode for am625-dss.

2022-09-28 Thread Aradhya Bhatia
+ +---+ Following the above pathways for different modes, 2 encoder/panel-bridge pipes get created for clone mode, and 1 pipe in cases of single link and dual link mode. Add support for confgure the OLDI modes using of and lvds DRM helper functions. Signed-off-by: Aradhya Bhatia

[RFC PATCH v5 2/6] dt-bindings: display: ti: am65x-dss: Add new port for am625-dss

2022-09-28 Thread Aradhya Bhatia
Add 3rd "port" property for am625-dss. This port represents the output from the 2nd OLDI TX (OLDI TX 1) latched onto the first video port (VP0) from the DSS controller on AM625 SOC. Signed-off-by: Aradhya Bhatia --- .../bindings/display/ti/ti,am65x-dss.yaml | 18

[RFC PATCH v5 6/6] drm/tidss: Enable Dual and Duplicate Modes for OLDI

2022-09-28 Thread Aradhya Bhatia
-off-by: Aradhya Bhatia --- drivers/gpu/drm/tidss/tidss_dispc.c | 28 ++-- 1 file changed, 26 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/tidss/tidss_dispc.c b/drivers/gpu/drm/tidss/tidss_dispc.c index 68444e0cd8d7..fd7f49535f0c 100644 --- a/drivers/gpu/drm

[RFC PATCH v5 3/6] drm/tidss: Add support for AM625 DSS

2022-09-28 Thread Aradhya Bhatia
Add support for the DSS controller on TI's new AM625 SoC in the tidss driver. The first video port (VP0) in am625-dss can output OLDI signals through 2 OLDI TXes. A 3rd port has been added with "DISPC_VP_OLDI" bus type. Signed-off-by: Aradhya Bhatia --- drivers/gpu/drm/tidss/tid

[RFC PATCH v5 5/6] drm/tidss: Add IO CTRL and Power support for OLDI TX in am625

2022-09-28 Thread Aradhya Bhatia
The ctrl mmr module of the AM625 is different from the AM65X SoC. Thus the ctrl mmr registers that supported the OLDI TX power have become different in AM625 SoC. Add IO CTRL support and control the OLDI TX power for AM625. Signed-off-by: Aradhya Bhatia --- drivers/gpu/drm/tidss/tidss_dispc.c

[RFC PATCH v5 0/6] Add DSS support for AM625 SoC

2022-09-28 Thread Aradhya Bhatia
rop the OLDI clock set patch 5. Drop rgb565-to-888 patch V4: - Rebase for current merge window - Add acked and reviewed by tags V3: - Change yaml enum in alphabetical order - Correct a typo V2: - Remove redundant regsiter array Aradhya Bhatia (6): dt-bindings: display: ti,am65x-

Re: [PATCH v2 3/4] dt-bindings: panel: Introduce dual-link LVDS panel

2023-02-02 Thread Aradhya Bhatia
Hi Rob, On 30-Jan-23 22:34, Rob Herring wrote: > On Tue, Jan 24, 2023 at 03:42:37PM +0530, Aradhya Bhatia wrote: >> Dual-link LVDS interfaces have 2 links, with even pixels traveling on >> one link, and odd pixels on the other. These panels are also generic in >> natur

Re: [PATCH v7 1/6] drm/tidss: Remove Video Port to Output Port coupling

2023-02-05 Thread Aradhya Bhatia
Hi Tomi, Thanks for the review! On 03-Feb-23 16:53, Tomi Valkeinen wrote: > On 25/01/2023 13:35, Aradhya Bhatia wrote: >> Make DSS Video Ports agnostic of output bus types. >> >> DSS controllers have had a 1-to-1 coupling between its VPs and its >> output ports. Thi

Re: [PATCH v7 4/6] drm/tidss: Add support to configure OLDI mode for am625-dss

2023-02-05 Thread Aradhya Bhatia
Hi Tomi, On 03-Feb-23 20:42, Tomi Valkeinen wrote: > On 25/01/2023 13:35, Aradhya Bhatia wrote: >> The newer version of DSS (AM625-DSS) has 2 OLDI TXes at its disposal. >> These can be configured to support the following modes: >> >> 1. OLDI_SINGLE_LINK_SINGLE_MODE &

Re: [PATCH v7 5/6] drm/tidss: Add IO CTRL and Power support for OLDI TX in am625

2023-02-05 Thread Aradhya Bhatia
On 03-Feb-23 20:49, Tomi Valkeinen wrote: > On 25/01/2023 13:35, Aradhya Bhatia wrote: >> The ctrl mmr module of the AM625 is different from the AM65X SoC. Thus >> the ctrl mmr registers that supported the OLDI TX power have become >> different in AM625 SoC. >> >&g

Re: [PATCH v7 3/6] drm/tidss: Add support for AM625 DSS

2023-02-05 Thread Aradhya Bhatia
On 03-Feb-23 21:03, Tomi Valkeinen wrote: > On 25/01/2023 13:35, Aradhya Bhatia wrote: >> Add support for the DSS controller on TI's new AM625 SoC in the tidss >> driver. >> >> The first video port (VP0) in am625-dss can output OLDI signals through >> 2

Re: [PATCH v7 3/6] drm/tidss: Add support for AM625 DSS

2023-02-06 Thread Aradhya Bhatia
Hi Tomi, On 06-Feb-23 16:28, Tomi Valkeinen wrote: > On 05/02/2023 16:31, Aradhya Bhatia wrote: >> >> >> On 03-Feb-23 21:03, Tomi Valkeinen wrote: >>> On 25/01/2023 13:35, Aradhya Bhatia wrote: >>>> Add support for the DSS controller on TI's new AM

Re: [PATCH v7 1/6] drm/tidss: Remove Video Port to Output Port coupling

2023-02-06 Thread Aradhya Bhatia
On 06-Feb-23 18:35, Tomi Valkeinen wrote: > On 05/02/2023 15:08, Aradhya Bhatia wrote: >> Hi Tomi, >> >> Thanks for the review! >> >> On 03-Feb-23 16:53, Tomi Valkeinen wrote: >>> On 25/01/2023 13:35, Aradhya Bhatia wrote: >>>> Make DSS V

Re: [PATCH v7 4/6] drm/tidss: Add support to configure OLDI mode for am625-dss

2023-02-06 Thread Aradhya Bhatia
On 06-Feb-23 19:12, Tomi Valkeinen wrote: > On 05/02/2023 15:42, Aradhya Bhatia wrote: >> Hi Tomi, >> >> On 03-Feb-23 20:42, Tomi Valkeinen wrote: >>> On 25/01/2023 13:35, Aradhya Bhatia wrote: >>>> The newer version of DSS (AM625-DSS) has 2 OL

Re: [RFC PATCH 0/4] dt-bindings: Introduce dual-link panels & panel-vendors

2023-01-17 Thread Aradhya Bhatia
Hi Laurent, Thank you for taking a look at this! On 16-Jan-23 15:00, Laurent Pinchart wrote: Hi Aradhya, On Tue, Jan 03, 2023 at 12:16:11PM +0530, Aradhya Bhatia wrote: Hi all, Microtips Technology Solutions USA, and Lincoln Technology Solutions are 2 display panel vendors, and the first 2

Re: [RFC PATCH 3/4] dt-bindings: panel: Introduce dual-link LVDS panel

2023-01-19 Thread Aradhya Bhatia
Hi Tomi, Thank you for taking a look at the patches! On 17-Jan-23 18:08, Tomi Valkeinen wrote: On 09/01/2023 18:21, Aradhya Bhatia wrote: Hi Angelo, Thanks for taking a look at the patches! On 03-Jan-23 17:21, AngeloGioacchino Del Regno wrote: Il 03/01/23 07:46, Aradhya Bhatia ha scritto

Re: [PATCH v6 3/5] drm/tidss: Add support to configure OLDI mode for am625-dss.

2023-01-23 Thread Aradhya Bhatia
Hi Tomi, Thanks for reviewing the patch series. I have implemented the most of your suggestions, but for the others, I needed to clarify things. I have made some comments there. On 20-Dec-22 18:22, Tomi Valkeinen wrote: Hi, On 19/11/2022 19:30, Aradhya Bhatia wrote: The newer version of DSS

[PATCH v2 3/4] dt-bindings: panel: Introduce dual-link LVDS panel

2023-01-24 Thread Aradhya Bhatia
t;, and a dt-binding document for these panels. Signed-off-by: Aradhya Bhatia --- .../display/panel/panel-dual-lvds.yaml| 149 ++ MAINTAINERS | 1 + 2 files changed, 150 insertions(+) create mode 100644 Documentation/devicetree/bindings

[PATCH v2 1/4] dt-bindings: vendor-prefixes: Add microtips

2023-01-24 Thread Aradhya Bhatia
Add document vendor prefix for Microtips Technology USA (microtips). Signed-off-by: Aradhya Bhatia Acked-by: Krzysztof Kozlowski Reviewed-by: Laurent Pinchart --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation

[PATCH v2 4/4] drm: panel-lvds: Introduce dual-link panels

2023-01-24 Thread Aradhya Bhatia
uot;. Signed-off-by: Aradhya Bhatia --- drivers/gpu/drm/panel/panel-lvds.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/panel/panel-lvds.c b/drivers/gpu/drm/panel/panel-lvds.c index de8758c30e6e..bf6f84af0730 100644 --- a/drivers/gpu/drm/panel/panel-lvds.c +++ b/drivers/gpu/dr

[PATCH v2 2/4] dt-bindings: vendor-prefixes: Add lincolntech

2023-01-24 Thread Aradhya Bhatia
Add document vendor prefix for Lincoln Technology Solutions (lincolntech). Signed-off-by: Aradhya Bhatia Acked-by: Krzysztof Kozlowski Reviewed-by: Laurent Pinchart --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation

[PATCH v2 0/4] dt-bindings: Introduce dual-link panels & panel-vendors

2023-01-24 Thread Aradhya Bhatia
.kernel.org/all/20230103064615.5311-1-a-bhat...@ti.com/ Aradhya Bhatia (4): dt-bindings: vendor-prefixes: Add microtips dt-bindings: vendor-prefixes: Add lincolntech dt-bindings: panel: Introduce dual-link LVDS panel drm: panel-lvds: Introduce dual-link panels .../display/panel/panel

[PATCH v7 0/6] Add DSS support for AM625 SoC

2023-01-25 Thread Aradhya Bhatia
very was separated from the panel/bridge discovery loop during modeset initialization. Aradhya Bhatia (6): drm/tidss: Remove Video Port to Output Port coupling dt-bindings: display: ti,am65x-dss: Add support for am625 dss drm/tidss: Add support for AM625 DSS drm/tidss: Add support to confi

[PATCH v7 1/6] drm/tidss: Remove Video Port to Output Port coupling

2023-01-25 Thread Aradhya Bhatia
because the VPs are essentially agnostic of the bus type and it is the output ports which have a bus type. The AM625 DSS has 2 VPs but requires 3 output ports to support its Dual-Link OLDI video output coming from a single VP. Signed-off-by: Aradhya Bhatia --- drivers/gpu/drm/tids

[PATCH v7 2/6] dt-bindings: display: ti, am65x-dss: Add support for am625 dss

2023-01-25 Thread Aradhya Bhatia
tput. Add the new controller's compatible and a port property for the 2nd OLDI TX (OLDI TX 1). Signed-off-by: Aradhya Bhatia Reviewed-by: Krzysztof Kozlowski Reviewed-by: Rahul T R --- .../bindings/display/ti/ti,am65x-dss.yaml | 23 +-- 1 file changed, 21 insertions(

[PATCH v7 6/6] drm/tidss: Enable Dual and Duplicate Modes for OLDI

2023-01-25 Thread Aradhya Bhatia
required modes configurations. Signed-off-by: Aradhya Bhatia Reviewed-by: Tomi Valkeinen --- drivers/gpu/drm/tidss/tidss_dispc.c | 24 ++-- 1 file changed, 22 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/tidss/tidss_dispc.c b/drivers/gpu/drm/tidss/tidss_dispc.c

[PATCH v7 3/6] drm/tidss: Add support for AM625 DSS

2023-01-25 Thread Aradhya Bhatia
Add support for the DSS controller on TI's new AM625 SoC in the tidss driver. The first video port (VP0) in am625-dss can output OLDI signals through 2 OLDI TXes. A 3rd output port has been added with "DISPC_PORT_OLDI" bus type. Signed-off-by: Aradhya Bhatia --- driver

[PATCH v7 4/6] drm/tidss: Add support to configure OLDI mode for am625-dss

2023-01-25 Thread Aradhya Bhatia
+ +---+ Following the above pathways for different modes, 2 encoder/panel-bridge pipes get created for clone mode, and 1 pipe in cases of single link and dual link mode. Add support for confguring the OLDI modes using OF and LVDS DRM helper functions. Signed-off-by: Aradhya Bhatia

[PATCH v7 5/6] drm/tidss: Add IO CTRL and Power support for OLDI TX in am625

2023-01-25 Thread Aradhya Bhatia
bandgap reference circuit for the LVDS signals. Signed-off-by: Aradhya Bhatia --- Note: - Dropped Tomi Valkeinen's reviewed-by tag in this patch because I did not implement one of his comments which suggested to remove the 'oldi_supported' variable. While the oldi support is

Re: [RFC PATCH v5 4/6] drm/tidss: Add support to configure OLDI mode for am625-dss.

2022-10-18 Thread Aradhya Bhatia
Hi Tomi Thank you for the comprehensive feedback across all the patches. I am working on them. I do have some concerns which I have talked about, below. On 12-Oct-22 17:53, Tomi Valkeinen wrote: On 28/09/2022 20:52, Aradhya Bhatia wrote: The newer version of DSS (AM625-DSS) has 2 OLDI TXes

Re: [RFC PATCH v5 5/6] drm/tidss: Add IO CTRL and Power support for OLDI TX in am625

2022-10-19 Thread Aradhya Bhatia
Hi Tomi On 12-Oct-22 17:59, Tomi Valkeinen wrote: On 28/09/2022 20:52, Aradhya Bhatia wrote: The ctrl mmr module of the AM625 is different from the AM65X SoC. Thus the ctrl mmr registers that supported the OLDI TX power have become different in AM625 SoC. Add IO CTRL support and control the

[PATCH v6 1/5] dt-bindings: display: ti, am65x-dss: Add support for am625 dss

2022-11-19 Thread Aradhya Bhatia
tput. Add the new controller's compatible and a port property for the 2nd OLDI TX (OLDI TX 1). Signed-off-by: Aradhya Bhatia Reviewed-by: Krzysztof Kozlowski Reviewed-by: Rahul T R --- .../bindings/display/ti/ti,am65x-dss.yaml | 23 +-- 1 file changed, 21 insertions(

[PATCH v6 2/5] drm/tidss: Add support for AM625 DSS

2022-11-19 Thread Aradhya Bhatia
ween Videoports and Output Ports. Since this stands no longer to be true for AM625 DSS, this couppling has been separated with the introduction of output port based variables. This will help address the addition of the 2nd OLDI TX over VP0 as the 3rd output port. Signed-off-by: Aradhya Bhatia -

[PATCH v6 4/5] drm/tidss: Add IO CTRL and Power support for OLDI TX in am625

2022-11-19 Thread Aradhya Bhatia
The ctrl mmr module of the AM625 is different from the AM65X SoC. Thus the ctrl mmr registers that supported the OLDI TX power have become different in AM625 SoC. Add IO CTRL support and control the OLDI TX power for AM625. Signed-off-by: Aradhya Bhatia --- drivers/gpu/drm/tidss/tidss_dispc.c

[PATCH v6 0/5] Add DSS support for AM625 SoC

2022-11-19 Thread Aradhya Bhatia
Change yaml enum in alphabetical order - Correct a typo V2: - Remove redundant regsiter array Aradhya Bhatia (5): dt-bindings: display: ti,am65x-dss: Add support for am625 dss drm/tidss: Add support for AM625 DSS drm/tidss: Add support to configure OLDI mode for am625-dss. drm/tidss: Add IO CTRL

[PATCH v6 5/5] drm/tidss: Enable Dual and Duplicate Modes for OLDI

2022-11-19 Thread Aradhya Bhatia
required modes configurations. Signed-off-by: Aradhya Bhatia --- drivers/gpu/drm/tidss/tidss_dispc.c | 24 ++-- 1 file changed, 22 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/tidss/tidss_dispc.c b/drivers/gpu/drm/tidss/tidss_dispc.c index f26129fb1d8f..cf43de6216a5

[PATCH v6 3/5] drm/tidss: Add support to configure OLDI mode for am625-dss.

2022-11-19 Thread Aradhya Bhatia
+ +---+ Following the above pathways for different modes, 2 encoder/panel-bridge pipes get created for clone mode, and 1 pipe in cases of single link and dual link mode. Add support for confguring the OLDI modes using OF and LVDS DRM helper functions. Signed-off-by: Aradhya Bhatia

Re: [PATCH] drm: tidss: Fix pixel format definition

2022-12-04 Thread Aradhya Bhatia
table we have the later entries should have been for Alpha-X instead. Fixes 32a1795f57eecc Acked-by: Andrew Davis Signed-off-by: Randolph Sapp Reviewed-by: Aradhya Bhatia ---   drivers/gpu/drm/tidss/tidss_dispc.c | 4 ++--   1 file changed, 2 insertions(+), 2 deletions(-) diff --git a

[RFC PATCH 0/4] dt-bindings: Introduce dual-link panels & panel-vendors

2023-01-02 Thread Aradhya Bhatia
om the "required" section. Thank you! [1]: https://patchwork.freedesktop.org/patch/357122/ [2]: https://patchwork.freedesktop.org/patch/471228/ Aradhya Bhatia (4): dt-bindings: vendor-prefixes: Add microtips dt-bindings: vendor-prefixes: Add lincolntech dt-bindings: panel: Introduc

[RFC PATCH 4/4] drm: panel-lvds: Introduce dual-link panels

2023-01-02 Thread Aradhya Bhatia
uot;. Signed-off-by: Aradhya Bhatia --- drivers/gpu/drm/panel/panel-lvds.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/panel/panel-lvds.c b/drivers/gpu/drm/panel/panel-lvds.c index de8758c30e6e..bf6f84af0730 100644 --- a/drivers/gpu/drm/panel/panel-lvds.c +++ b/drivers/gpu/dr

[RFC PATCH 3/4] dt-bindings: panel: Introduce dual-link LVDS panel

2023-01-02 Thread Aradhya Bhatia
t;, and a dt-binding document for these panels. Signed-off-by: Aradhya Bhatia --- .../display/panel/panel-dual-lvds.yaml| 157 ++ MAINTAINERS | 1 + 2 files changed, 158 insertions(+) create mode 100644 Documentation/devicetree/bindings

[RFC PATCH 2/4] dt-bindings: vendor-prefixes: Add lincolntech

2023-01-02 Thread Aradhya Bhatia
Add document vendor prefix for Lincoln Technology Solutions (lincolntech). Signed-off-by: Aradhya Bhatia --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation

[RFC PATCH 1/4] dt-bindings: vendor-prefixes: Add microtips

2023-01-02 Thread Aradhya Bhatia
Add document vendor prefix for Microtips Technology USA (microtips). Signed-off-by: Aradhya Bhatia --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree

Re: [RFC PATCH 3/4] dt-bindings: panel: Introduce dual-link LVDS panel

2023-01-03 Thread Aradhya Bhatia
Hi Krzysztof, Thank you for reviewing the patches! On 03-Jan-23 14:02, Krzysztof Kozlowski wrote: On 03/01/2023 07:46, Aradhya Bhatia wrote: Dual-link LVDS interfaces have 2 links, with even pixels traveling on one link, and odd pixels on the other. These panels are also generic in nature

Re: [RFC PATCH 3/4] dt-bindings: panel: Introduce dual-link LVDS panel

2023-01-09 Thread Aradhya Bhatia
Hi Krzysztof, On 03-Jan-23 16:58, Krzysztof Kozlowski wrote: On 03/01/2023 12:02, Aradhya Bhatia wrote: But this is throwing an error. I am confused what else could be done. Can you please suggest what might be a more accurate check here? + required: +- dual

Re: [RFC PATCH 3/4] dt-bindings: panel: Introduce dual-link LVDS panel

2023-01-09 Thread Aradhya Bhatia
Hi Angelo, Thanks for taking a look at the patches! On 03-Jan-23 17:21, AngeloGioacchino Del Regno wrote: Il 03/01/23 07:46, Aradhya Bhatia ha scritto: Dual-link LVDS interfaces have 2 links, with even pixels traveling on one link, and odd pixels on the other. These panels are also generic in

Re: [RFC PATCH 3/4] dt-bindings: panel: Introduce dual-link LVDS panel

2023-01-09 Thread Aradhya Bhatia
Hi Laurent, Thank you for reviewing the patches! On 08-Jan-23 12:26, Laurent Pinchart wrote: Hi Aradhya, Thank you for the patch. On Tue, Jan 03, 2023 at 12:16:14PM +0530, Aradhya Bhatia wrote: Dual-link LVDS interfaces have 2 links, with even pixels traveling on one link, and odd pixels on

Re: [PATCH v4 5/7] drm/tidss: Set bus_format correctly from bridge/connector

2023-04-14 Thread Aradhya Bhatia
Hi Francesco, On 30-Mar-23 22:47, Francesco Dolcini wrote: > Hello, > chiming in in this *old* email thread. > > Adding in copy a few more *@ti.com people recently involved in other tidss > changes [1] > > > [1] https://lore.kernel.org/all/20230125113529.13952-1-a-bhat...@ti.com/ > > > On Fri

Re: [PATCH v4 5/7] drm/tidss: Set bus_format correctly from bridge/connector

2023-04-14 Thread Aradhya Bhatia
Hi Francesco, On 14-Apr-23 14:00, Francesco Dolcini wrote: > Hello Aradhya, > > On Fri, Apr 14, 2023 at 01:19:38PM +0530, Aradhya Bhatia wrote: >> On 30-Mar-23 22:47, Francesco Dolcini wrote: >>> Hello, >>> chiming in in this *old* email thread. >>> >

Re: [PATCH v8 2/2] drm/tidss: Add support for AM625 DSS

2023-06-16 Thread Aradhya Bhatia
Hi Tomi, Thank you for the reviews! On 16-Jun-23 18:15, Tomi Valkeinen wrote: > Hi, > > On 08/06/2023 19:37, Aradhya Bhatia wrote: >> Add support for the DSS controller on TI's AM625 SoC in the tidss >> driver. >> >> The AM625 DSS supports 2 video plan

[PATCH v9 0/2] Add DSS support for AM625 SoC

2023-06-16 Thread Aradhya Bhatia
ch. 2. Add port #3 for 2nd OLDI TX. 3. Configure 2 panel-bridges for cloned panels. 4. Drop the OLDI clock set patch. 5. Drop rgb565-to-888 patch. V3: - Change yaml enum in alphabetical order. - Correct a typo. V2: - Remove redundant register array. Aradhya Bhatia (2): dt-bi

[PATCH v9 2/2] drm/tidss: Add support for AM625 DSS

2023-06-16 Thread Aradhya Bhatia
ort outputs DPI data directly out of the SoC. It has 24 data lines and can support a maximum of RGB888 output bus format. Signed-off-by: Aradhya Bhatia Reviewed-by: Tomi Valkeinen --- Notes: Changes from v8: * Update commit message. * Add Tomi Valkeinen's R-b tag. Changes from v7:

[PATCH v9 1/2] dt-bindings: display: ti, am65x-dss: Add am625 dss compatible

2023-06-16 Thread Aradhya Bhatia
The second video port is same from AM65x DSS and it outputs DPI video data. It can support 2K resolutions @ 60fps, independently. Add the new controller's compatible and update descriptions. Signed-off-by: Aradhya Bhatia Acked-by: Krzysztof Kozlowski Reviewed-by: Tomi Valkeinen --- Notes:

[PATCH v6 3/8] drm/bridge: mhdp8546: Add minimal format negotiation

2023-05-09 Thread Aradhya Bhatia
From: Nikhil Devshatwar With new connector model, mhdp bridge will not create the connector and SoC driver will rely on format negotiation to setup the encoder format. Support minimal format negotiations hooks in the drm_bridge_funcs. Complete format negotiation can be added based on EDID data.

[PATCH v6 2/8] drm/bridge: tfp410: Set input_bus_flags in atomic_check

2023-05-09 Thread Aradhya Bhatia
From: Nikhil Devshatwar input_bus_flags are specified in drm_bridge_timings (legacy) as well as drm_bridge_state->input_bus_cfg.flags The flags from the timings will be deprecated. Bridges are supposed to validate and set the bridge state flags from atomic_check. Implement atomic_check hook for

[PATCH v6 0/8] drm/tidss: Use new connector model for tidss

2023-05-09 Thread Aradhya Bhatia
Creates 'simple' encoder for userspace exposure. 3. Creates a tidss connector. 4. Attaches the next-bridge to encoder with the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag. - Add format negotiation support for sii902x driver. Previous series: V1 to V5: https://patchwork.

[PATCH v6 5/8] drm/bridge: sii902x: Support format negotiation hooks

2023-05-09 Thread Aradhya Bhatia
format is selected to MEDIA_BUS_FMT_RGB888_1X24 as default, as is the case with older model. Signed-off-by: Aradhya Bhatia --- drivers/gpu/drm/bridge/sii902x.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/drivers/gpu/drm/bridge/sii902x.c b/drivers/gpu/drm/bridge

[PATCH v6 7/8] drm/tidss: Update encoder/bridge chain connect model

2023-05-09 Thread Aradhya Bhatia
rm_encoder entity to expose it to userspace. Update the encoder/bridge initialization sequence in tidss as per the new model. Signed-off-by: Aradhya Bhatia --- Notes: changes from v5: * Dropped patches 5 and 6 from the original series. * Instead added this patch that addre

[PATCH v6 8/8] drm/bridge: cdns-mhdp8546: Fix the interrupt enable/disable

2023-05-09 Thread Aradhya Bhatia
From: Nikhil Devshatwar When removing the tidss driver, there is a warning reported by kernel about an unhandled interrupt for mhdp driver. [ 43.238895] irq 31: nobody cared (try booting with the "irqpoll" option) ... [snipped backtrace] [ 43.330735] handlers: [ 43.333020] [<5367c4

[PATCH v6 4/8] drm/bridge: mhdp8546: Set input_bus_flags from atomic_check

2023-05-09 Thread Aradhya Bhatia
hil Devshatwar [a-bhatia1: replace timings in cdns_mhdp_platform_info by input_bus_flags] Signed-off-by: Aradhya Bhatia --- Notes: changes from v5: * removed the wrongly addded return statement in tfp410 driver. * replaced the timings field in cdns_mhdp_platform_info by input_bus_fl

[PATCH v6 1/8] drm/bridge: tfp410: Support format negotiation hooks

2023-05-09 Thread Aradhya Bhatia
selected by the bridge from DT properties. Signed-off-by: Nikhil Devshatwar [a-bhatia1: Removed output fmt condition check] Signed-off-by: Aradhya Bhatia --- Notes: changes from v1: * Use only MEDIA_BUS_FMT_FIXED for output changes from V5: * Dropped the output format check condition

[PATCH v6 6/8] drm/bridge: sii902x: Set input_bus_flags in atomic_check

2023-05-09 Thread Aradhya Bhatia
-by: Aradhya Bhatia --- drivers/gpu/drm/bridge/sii902x.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/gpu/drm/bridge/sii902x.c b/drivers/gpu/drm/bridge/sii902x.c index 662b6cb4aa62..4d1f10532fa6 100644 --- a/drivers/gpu/drm/bridge/sii902x.c +++ b/drivers/gpu/drm/bri

Re: [PATCH v6 3/8] drm/bridge: mhdp8546: Add minimal format negotiation

2023-05-15 Thread Aradhya Bhatia
Hi Tomi, On 12-May-23 14:45, Tomi Valkeinen wrote: > On 09/05/2023 12:30, Aradhya Bhatia wrote: >> From: Nikhil Devshatwar >> >> With new connector model, mhdp bridge will not create the connector and >> SoC driver will rely on format negotiation to setup the en

Re: [PATCH v6 3/8] drm/bridge: mhdp8546: Add minimal format negotiation

2023-05-16 Thread Aradhya Bhatia
Hi Neil, Thank you for reviewing the patch. On 16-May-23 12:51, Neil Armstrong wrote: > On 15/05/2023 17:59, Aradhya Bhatia wrote: >> Hi Tomi, >> >> On 12-May-23 14:45, Tomi Valkeinen wrote: >>> On 09/05/2023 12:30, Aradhya Bhatia wrote: >>>> From: Nikhi

Re: [PATCH v6 2/8] drm/bridge: tfp410: Set input_bus_flags in atomic_check

2023-05-16 Thread Aradhya Bhatia
Hi Neil, On 16-May-23 12:55, Neil Armstrong wrote: > On 09/05/2023 11:30, Aradhya Bhatia wrote: >> From: Nikhil Devshatwar >> >> input_bus_flags are specified in drm_bridge_timings (legacy) as well >> as drm_bridge_state->input_bus_cfg.flags >> >> The

Re: [PATCH v6 4/8] drm/bridge: mhdp8546: Set input_bus_flags from atomic_check

2023-05-16 Thread Aradhya Bhatia
Hi Neil, On 16-May-23 12:54, Neil Armstrong wrote: > On 09/05/2023 11:30, Aradhya Bhatia wrote: >> From: Nikhil Devshatwar >> >> input_bus_flags are specified in drm_bridge_timings (legacy) as well >> as drm_bridge_state->input_bus_cfg.flags >> >> The

Re: [PATCH v6 4/8] drm/bridge: mhdp8546: Set input_bus_flags from atomic_check

2023-05-22 Thread Aradhya Bhatia
Hi Neil, On 22-May-23 13:35, neil.armstr...@linaro.org wrote: > On 17/05/2023 07:48, Aradhya Bhatia wrote: >> Hi Neil, >> >> On 16-May-23 12:54, Neil Armstrong wrote: >>> On 09/05/2023 11:30, Aradhya Bhatia wrote: >>>> From: Nikhil Devshatwar

Re: [PATCH v6 3/8] drm/bridge: mhdp8546: Add minimal format negotiation

2023-05-28 Thread Aradhya Bhatia
Hi Tomi, Thank you for taking a look at this. On 26/05/23 14:59, Tomi Valkeinen wrote: > On 16/05/2023 17:25, Aradhya Bhatia wrote: >> Hi Neil, >> >> Thank you for reviewing the patch. >> >> On 16-May-23 12:51, Neil Armstrong wrote: >>> On 15/05/2023

[PATCH v7 2/8] drm/bridge: tfp410: Set input_bus_flags in atomic_check

2023-06-06 Thread Aradhya Bhatia
ook for the same. Signed-off-by: Nikhil Devshatwar Signed-off-by: Aradhya Bhatia Reviewed-by: Neil Armstrong --- Notes: changes from v4: * fix a warning Reported-by: kernel test robot changes from v5: * Move the return statement here from patch 4 (where it was added by mist

[PATCH v7 5/8] drm/bridge: sii902x: Support format negotiation hooks

2023-06-06 Thread Aradhya Bhatia
format is selected to MEDIA_BUS_FMT_RGB888_1X24 as default, as is the case with older model. Signed-off-by: Aradhya Bhatia Reviewed-by: Neil Armstrong --- Notes: changes from v6: * Add Neil Armstrong's R-b tag. drivers/gpu/drm/bridge/sii902x.c | 25 + 1

[PATCH v7 1/8] drm/bridge: tfp410: Support format negotiation hooks

2023-06-06 Thread Aradhya Bhatia
selected by the bridge from DT properties. Signed-off-by: Nikhil Devshatwar [a-bhatia1: Removed output fmt condition check] Signed-off-by: Aradhya Bhatia --- Notes: changes from v1: * Use only MEDIA_BUS_FMT_FIXED for output changes from V5: * Drop the output format check condition

[PATCH v7 0/8] drm/tidss: Use new connector model for tidss

2023-06-06 Thread Aradhya Bhatia
r. 4. Attaches the next-bridge to encoder with the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag. - Add format negotiation support for sii902x driver. Previous versions: V1 to V6: https://patchwork.freedesktop.org/series/82765/ Aradhya Bhatia (3): drm/bridge: sii902x: Support format negotia

[PATCH v7 4/8] drm/bridge: mhdp8546: Set input_bus_flags from atomic_check

2023-06-06 Thread Aradhya Bhatia
hil Devshatwar [a-bhatia1: replace timings in cdns_mhdp_platform_info by input_bus_flags] Signed-off-by: Aradhya Bhatia Reviewed-by: Neil Armstrong --- Notes: changes from v5: * remove the wrongly addded return statement in tfp410 driver. * replace the timings field in cdns_mhdp_platform_i

[PATCH v7 3/8] drm/bridge: mhdp8546: Add minimal format negotiation

2023-06-06 Thread Aradhya Bhatia
. This patch adds the minimal required support to avoid failure after moving to new connector model. Signed-off-by: Nikhil Devshatwar [a-bhatia1: Drop the output_fmt check condition] Signed-off-by: Aradhya Bhatia --- Notes: changes from v1: * cosmetic fixes, commit message update

[PATCH v7 6/8] drm/bridge: sii902x: Set input_bus_flags in atomic_check

2023-06-06 Thread Aradhya Bhatia
-by: Aradhya Bhatia Reviewed-by: Neil Armstrong --- Notes: changes from v6: * Add Neil Armstrong's R-b tag. drivers/gpu/drm/bridge/sii902x.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/gpu/drm/bridge/sii902x.c b/drivers/gpu/drm/bridge/sii902x

[PATCH v7 8/8] drm/bridge: cdns-mhdp8546: Fix the interrupt enable/disable

2023-06-06 Thread Aradhya Bhatia
lkeinen Signed-off-by: Aradhya Bhatia --- Notes: changes from v2: * Fix the interrupt enable logic at other places in code * Reorder functions so that they can be used earlier in the program changes from v5: * Manual rebase to linux-next. .../drm/bridge/cadence/cdns-

[PATCH v7 7/8] drm/tidss: Update encoder/bridge chain connect model

2023-06-06 Thread Aradhya Bhatia
rm_encoder entity to expose it to userspace. Update the encoder/bridge initialization sequence in tidss as per the new model. Signed-off-by: Aradhya Bhatia --- Notes: changes from v5: * Drop patches 5 and 6 from the original series. * Instead add this patch that addresses Boris B

Re: [PATCH v7 0/8] drm/tidss: Use new connector model for tidss

2023-06-06 Thread Aradhya Bhatia
Hi Neil, Thank you for reviewing the previous patches! On 06-Jun-23 14:37, Neil Armstrong wrote: > Hi, > > On 06/06/2023 10:21, Aradhya Bhatia wrote: >> Hi all, >> >> I have picked up this long standing series from Nikhil Devshatwar[1]. >> >> This series

[PATCH v8 0/2] Add DSS support for AM625 SoC

2023-06-08 Thread Aradhya Bhatia
. 3. Configure 2 panel-bridges for cloned panels. 4. Drop the OLDI clock set patch. 5. Drop rgb565-to-888 patch. V3: - Change yaml enum in alphabetical order. - Correct a typo. V2: - Remove redundant register array. Aradhya Bhatia (2): dt-bindings: display: ti,am65x-dss: Add am62

[PATCH v8 1/2] dt-bindings: display: ti, am65x-dss: Add am625 dss compatible

2023-06-08 Thread Aradhya Bhatia
The second video port is same from AM65x DSS and it outputs DPI video data. It can support 2K resolutions @ 60fps, independently. Add the new controller's compatible and update descriptions. Signed-off-by: Aradhya Bhatia --- Notes: Changes from v7: * Drop the 3rd port property and upda

[PATCH v8 2/2] drm/tidss: Add support for AM625 DSS

2023-06-08 Thread Aradhya Bhatia
Signed-off-by: Aradhya Bhatia --- Notes: Changes from v7: * Drop all changes made after v3. - Drop output bus type support. All outputs from DSS will be the video port outptus. * Make the first video port type as INTERNAL from OLDI. drivers/gpu/drm/tidss/tid

[PATCH 2/2] drivers/tidss: Add support for AM62A7 DSS

2023-08-18 Thread Aradhya Bhatia
tied off inside the SoC. Signed-off-by: Aradhya Bhatia --- drivers/gpu/drm/tidss/tidss_dispc.c | 53 + drivers/gpu/drm/tidss/tidss_dispc.h | 2 ++ drivers/gpu/drm/tidss/tidss_drv.c | 1 + 3 files changed, 56 insertions(+) diff --git a/drivers/gpu/drm/

[PATCH 0/2] Add DSS support for TI AM62A7 SoC

2023-08-18 Thread Aradhya Bhatia
[0] in the branch "next_am62a". Regards Aradhya [0]: https://github.com/aradhya07/linux-ab/tree/next_am62a Aradhya Bhatia (2): dt-bindings: display: ti: Add support for am62a7 dss drivers/tidss: Add support for AM62A7 DSS .../bindings/display/ti/ti,am65x-dss.yaml | 14 + d

Re: [PATCH 2/2] drivers/tidss: Add support for AM62A7 DSS

2023-08-18 Thread Aradhya Bhatia
On 18-Aug-23 18:47, Aradhya Bhatia wrote: > Add support for the DSS controller on TI's AM62A7 SoC in the tidss > driver. > > This contrller has 2 video pipelines that can render 2 video planes on > over a screen, using the overlay managers. The output of the DSS comes >

[PATCH 1/2] dt-bindings: display: ti: Add support for am62a7 dss

2023-08-18 Thread Aradhya Bhatia
Signed-off-by: Aradhya Bhatia --- .../bindings/display/ti/ti,am65x-dss.yaml | 14 ++ 1 file changed, 14 insertions(+) diff --git a/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml b/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml index ae09cd3cbce

[PATCH v2 0/2] Add DSS support for TI AM62A7 SoC

2023-08-18 Thread Aradhya Bhatia
[0] in the branch "next_am62a-v2". Regards Aradhya [0]: https://github.com/aradhya07/linux-ab/tree/next_am62a-v2 Change Log: V1 -> V2: - Correctly sort DISPC_AM62A7 macro after DISPC_AM625 in patch 2/2. Previous Versions: V1: https://lore.kernel.org/all/20230818131750.4779-1-a-b

[PATCH v2 1/2] dt-bindings: display: ti: Add support for am62a7 dss

2023-08-18 Thread Aradhya Bhatia
Signed-off-by: Aradhya Bhatia --- Notes: Changes from V1: * No change from V1. .../bindings/display/ti/ti,am65x-dss.yaml | 14 ++ 1 file changed, 14 insertions(+) diff --git a/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml b/Documentation/devi

[PATCH v2 2/2] drivers/tidss: Add support for AM62A7 DSS

2023-08-18 Thread Aradhya Bhatia
tied off inside the SoC. Signed-off-by: Aradhya Bhatia --- Notes: Changes from V1: * Correctly sort DISPC_AM62A7 macro after DISPC_AM625. drivers/gpu/drm/tidss/tidss_dispc.c | 53 + drivers/gpu/drm/tidss/tidss_dispc.h | 2 ++ drivers/gpu/drm/

Re: [PATCH v7 5/8] drm/bridge: sii902x: Support format negotiation hooks

2023-07-13 Thread Aradhya Bhatia
Hi Sam, On 10-Jul-23 20:38, Sam Ravnborg wrote: > Hi Aradhya, > > On Tue, Jun 06, 2023 at 01:51:39PM +0530, Aradhya Bhatia wrote: >> With new connector model, sii902x will not create the connector, when >> DRM_BRIDGE_ATTACH_NO_CONNECTOR is set and SoC driver will rely on for

Re: [PATCH v3 2/4] dt-bindings: display: ti: Add schema for AM625 OLDI Transmitter

2024-08-25 Thread Aradhya Bhatia
Hi Krzysztof, Thank you for the reviewing the patches. On 7/21/24 21:06, Krzysztof Kozlowski wrote: > On 16/07/2024 10:42, Aradhya Bhatia wrote: >> The OLDI (transmitters) TXes do not have registers of their own, and are >> dependent on the source video-ports from the

Re: [PATCH v3 3/4] dt-bindings: display: ti,am65x-dss: Add OLDI properties for AM625 DSS

2024-08-26 Thread Aradhya Bhatia
Hi Krzysztof, On 7/21/24 21:09, Krzysztof Kozlowski wrote: > On 16/07/2024 10:42, Aradhya Bhatia wrote: >> The DSS in AM625 SoC has 2 OLDI TXes. Refer the OLDI schema to add the >> support for the OLDI TXes. >> >> The AM625 DSS VP1 (port@0) can connect and control 2 O

Re: [PATCH v3 0/4] drm/tidss: Add OLDI bridge support

2024-09-09 Thread Aradhya Bhatia
Hi, Thank you, Francesco and Max, for testing and reporting this! On 09/09/24 13:45, Tomi Valkeinen wrote: > Hi, > > On 06/09/2024 14:43, Francesco Dolcini wrote: >> +Max >> >> Hello Aradhya, >> >> On Tue, Jul 16, 2024 at 02:12:44PM +0530, Aradhya Bhatia

Re: [PATCH] drm: bridge: it66121: Fix invalid connector dereference

2023-08-28 Thread Aradhya Bhatia
Hi Jai, Thanks for debugging the issue. On 25-Aug-23 16:32, Jai Luthra wrote: > Fix the NULL pointer dereference when no monitor is connected, and the > sound card is opened from userspace. > > Instead return an error as EDID information cannot be provided to > the sound framework if there is no

Re: [PATCH v2] drm: bridge: it66121: Fix invalid connector dereference

2023-09-01 Thread Aradhya Bhatia
hed. > > Fixes: e0fd83dbe924 ("drm: bridge: it66121: Add audio support") > Reported-by: Nishanth Menon > Closes: https://lore.kernel.org/all/20230825105849.crhon42qndxqif4i@gondola/ > Reviewed-by: Helen Koike > Signed-off-by: Jai Luthra Reviewed-by: Aradhya Bhat

Re: [PATCH v4 07/11] drm/bridge: cdns-dsi: Reset the DCS write FIFO

2024-07-11 Thread Aradhya Bhatia
On 26/06/24 16:33, Tomi Valkeinen wrote: > On 22/06/2024 14:09, Aradhya Bhatia wrote: >> If any normal DCS write command has already been transmitted prior to >> transmitting any Zero-Parameter DCS command, then it is necessary to >> clear the TX FIFO by resetting it. Other

Re: [PATCH v4 10/11] drm/atomic-helper: Re-order bridge chain pre-enable and post-disable

2024-07-11 Thread Aradhya Bhatia
On 26/06/24 18:37, Maxime Ripard wrote: > On Wed, Jun 26, 2024 at 02:28:57PM GMT, Tomi Valkeinen wrote: >> On 22/06/2024 14:09, Aradhya Bhatia wrote: >>> Move the bridge pre_enable call before crtc enable, and the bridge >>> post_disable call after the crtc disab

Re: [PATCH 4/4] drm/tidss: Add OLDI bridge support

2024-07-15 Thread Aradhya Bhatia
Hi Tomi, Thank you for reviewing the patches! On 27/06/24 18:41, Tomi Valkeinen wrote: > On 11/05/2024 22:30, Aradhya Bhatia wrote: >> Up till now, the OLDI support in tidss was integrated within the tidss >> dispc. >> This was fine till the OLDI was one-to-mapped with the

[PATCH v2 0/4] drm/tidss: Add OLDI bridge support

2024-07-15 Thread Aradhya Bhatia
929.3115714-11-a-bhat...@ti.com/ [1]: AM62 OLDI Series - v7 https://lore.kernel.org/all/20230125113529.13952-1-a-bhat...@ti.com/ [2]: AM62 DSS Series - v9 https://lore.kernel.org/all/20230616150900.6617-1-a-bhat...@ti.com/ [3]: GitHub Fork for OLDI tests https://github.com/aradhya07/linux-ab/tree/nex

  1   2   3   4   >