[PATCH v3] drm: add overview diagram for drm stack

2025-05-27 Thread Abdulrasaq Lawani
revert promotion of overview diagram title to that of previous commit in introduction.rst Signed-off-by: Abdulrasaq Lawani --- Changes in v3: - revert the promotion of the overview diagram header - Link to v2: https://lore.kernel.org/r/20250523-drm-doc-updates-v2-0-e517df152...@gmail.com Change

Re: [RFC PATCH v2 1/3] drm/bridge: cadence: cdns-mhdp8546-core: Remove legacy support for connector initialisation in bridge

2025-05-27 Thread Tomi Valkeinen
Hi, On 21/05/2025 10:32, Jayesh Choudhary wrote: > Now that we have DBANC framework, remove the connector initialisation code > as that piece of code is not called if DRM_BRIDGE_ATTACH_NO_CONNECTOR flag > is used. Only TI K3 platforms consume this driver and tidss (their display > controller) has

Re: [PATCH v2 03/18] drm/tidss: Adjust the pclk based on the HW capabilities

2025-05-27 Thread Michael Walle
Hi Tomi, While testing Aardhya's OLDI support patches [1], I've noticed that the resulting LVDS clock is wrong if this patch is applied. > In practice, with the current K3 SoCs, the display PLL is capable of > producing very exact clocks, so most likely the rounded rate is the same > as the origi

Re: [RFC PATCH v2 2/3] drm/bridge: cadence: cdns-mhdp8546*: Change drm_connector from pointer to structure

2025-05-27 Thread Jayesh Choudhary
Hello Tomi, On 27/05/25 13:28, Tomi Valkeinen wrote: Hi, On 21/05/2025 10:32, Jayesh Choudhary wrote: After adding DBANC framework, mhdp->connector is not initialised during bridge calls. But the asyncronous work scheduled depends on the connector. We cannot get to drm_atomic_state in these as

Re: [RFC PATCH v2 1/3] drm/bridge: cadence: cdns-mhdp8546-core: Remove legacy support for connector initialisation in bridge

2025-05-27 Thread Tomi Valkeinen
Hi, On 27/05/2025 11:41, Jayesh Choudhary wrote: > Hello Tomi, > > On 27/05/25 13:08, Tomi Valkeinen wrote: >> Hi, >> >> On 21/05/2025 10:32, Jayesh Choudhary wrote: >>> Now that we have DBANC framework, remove the connector initialisation >>> code >>> as that piece of code is not called if DRM_B

Re: [PATCH v3 02/22] drm: convert many bridge drivers from devm_kzalloc() to devm_drm_bridge_alloc() API

2025-05-27 Thread Luca Ceresoli
Hello Adam, On Sun, 25 May 2025 14:40:46 -0500 Adam Ford wrote: > For: imx8mp-hdmi-pvi.c and adv7511_drv.c > > Tested-by: Adam Ford #imx8mp-beacon-kit Thanks for your testing, on the v1 as well! Sadly your Tested-by tag won't be in the commit because the patch had already been applied, but i

[PATCH] drm/arm/hdlcd: Replace struct simplefb_format with custom type

2025-05-27 Thread Thomas Zimmermann
Map DRM FourCC codes to pixel descriptions with internal type struct hdlcd_format. Reorder formats by preference. Avoid simplefb's struct simplefb_format, which is for parsing "simple-framebuffer" DT nodes. The HDLCD drivers uses struct simplefb_format and its default initializer SIMPLEFB_FORMATS

[PATCH v2] drm/sched/tests: Use one lock for fence context

2025-05-27 Thread Philipp Stanner
There is no need for separate locks for single jobs and the entire scheduler. The dma_fence context can be protected by the scheduler lock, allowing for removing the jobs' locks. This simplifies things and reduces the likelyhood of deadlocks etc. Replace the jobs' locks with the mock scheduler loc

Re: [PATCH RESEND] drm/amd/display: Adjust prefix of dcn31_apg construct function name

2025-05-27 Thread Leonardo Gomes
Hi Alex, Thanks for your answer! On Mon, 26 May 2025 at 23:50 Alex Hung wrote: > Hi Leonardo, > > Thank you for this patch, but unfortunately some unit test suites depend > on the names. > > On 5/21/25 07:58, Leonardo Gomes wrote: > > From: Leonardo da Silva Gomes > > > > Adjust the dcn31_apg

Re: (subset) [PATCH v3 00/22] drm: convert all bridges to devm_drm_bridge_alloc()

2025-05-27 Thread Luca Ceresoli
On Fri, 09 May 2025 15:53:26 +0200, Luca Ceresoli wrote: > devm_drm_bridge_alloc() [0] is the new API to allocate and initialize a DRM > bridge, and the only one supported from now on. It is the first milestone > towards removal of bridges from a still existing DRM pipeline without > use-after-fr

Re: [PATCH 31/45] drm/msm/dp: add dp_mst_drm to manage DP MST bridge operations

2025-05-27 Thread Yongxing Mou
On 2024/12/6 18:12, Dmitry Baryshkov wrote: On Thu, Dec 05, 2024 at 08:32:02PM -0800, Abhinav Kumar wrote: Add a new file dp_mst_drm to manage the DP MST bridge operations similar to the dp_drm file which manages the SST bridge operations. Each MST encoder creates one bridge and each bridge i

[PATCH v10 6/9] ref_tracker: automatically register a file in debugfs for a ref_tracker_dir

2025-05-27 Thread Jeff Layton
Currently, there is no convenient way to see the info that the ref_tracking infrastructure collects. Attempt to create a file in debugfs when called from ref_tracker_dir_init(). The file is given the name "class@%px", as having the unmodified address is helpful for debugging. This should be safe s

Re: [RFC PATCH v2 2/3] drm/bridge: cadence: cdns-mhdp8546*: Change drm_connector from pointer to structure

2025-05-27 Thread Jayesh Choudhary
On 27/05/25 14:59, Jayesh Choudhary wrote: Hello Tomi, On 27/05/25 13:28, Tomi Valkeinen wrote: Hi, On 21/05/2025 10:32, Jayesh Choudhary wrote: After adding DBANC framework, mhdp->connector is not initialised during bridge calls. But the asyncronous work scheduled depends on the connecto

[PATCH v10 8/9] net: add symlinks to ref_tracker_dir for netns

2025-05-27 Thread Jeff Layton
After assigning the inode number to the namespace, use it to create a unique name for each netns refcount tracker with the ns.inum and net_cookie values in it, and register a symlink to the debugfs file for it. init_net is registered before the ref_tracker dir is created, so add a late_initcall()

[PATCH v10 3/9] ref_tracker: have callers pass output function to pr_ostream()

2025-05-27 Thread Jeff Layton
In a later patch, we'll be adding a 3rd mechanism for outputting ref_tracker info via seq_file. Instead of a conditional, have the caller set a pointer to an output function in struct ostream. As part of this, the log prefix must be explicitly passed in, as it's too late for the pr_fmt macro. Revi

[PATCH v10 0/9] ref_tracker: add ability to register a debugfs file for a ref_tracker_dir

2025-05-27 Thread Jeff Layton
Thought I had sent this a week or so ago, but I dropped the ball in the midst of some travel. The only difference from v9 is that this posting drops the i915 symlink patch. I got a CI report [1] that showed some EEXIST errors when trying to create those symlinks, which tells me that the names are

[PATCH v10 1/9] ref_tracker: don't use %pK in pr_ostream() output

2025-05-27 Thread Jeff Layton
As Thomas Weißschuh points out [1], it is now preferable to use %p instead of hashed pointers with printk(), since raw pointers should no longer be leaked into the kernel log. Change the ref_tracker infrastructure to use %p instead of %pK in its formats. [1]: https://lore.kernel.org/netdev/202504

[PATCH v10 9/9] ref_tracker: eliminate the ref_tracker_dir name field

2025-05-27 Thread Jeff Layton
Now that we have dentries and the ability to create meaningful symlinks to them, don't keep a name string in each tracker. Switch the output format to print "class@address", and drop the name field. Also, add a kerneldoc header for ref_tracker_dir_init(). Signed-off-by: Jeff Layton --- drivers/

[PATCH v10 7/9] ref_tracker: add a way to create a symlink to the ref_tracker_dir debugfs file

2025-05-27 Thread Jeff Layton
Add the ability for a subsystem to add a user-friendly symlink that points to a ref_tracker_dir's debugfs file. Signed-off-by: Jeff Layton --- include/linux/ref_tracker.h | 13 + lib/ref_tracker.c | 28 2 files changed, 41 insertions(+) diff --

[PATCH v10 2/9] ref_tracker: add a top level debugfs directory for ref_tracker

2025-05-27 Thread Jeff Layton
Add a new "ref_tracker" directory in debugfs. Each individual refcount tracker can register files under there to display info about currently-held references. Reviewed-by: Andrew Lunn Signed-off-by: Jeff Layton --- lib/ref_tracker.c | 16 1 file changed, 16 insertions(+) diff

Re: [RFC PATCH v2 2/3] drm/bridge: cadence: cdns-mhdp8546*: Change drm_connector from pointer to structure

2025-05-27 Thread Tomi Valkeinen
Hi, On 27/05/2025 13:39, Jayesh Choudhary wrote: > > > On 27/05/25 14:59, Jayesh Choudhary wrote: >> Hello Tomi, >> >> On 27/05/25 13:28, Tomi Valkeinen wrote: >>> Hi, >>> >>> On 21/05/2025 10:32, Jayesh Choudhary wrote: After adding DBANC framework, mhdp->connector is not initialised durin

[PATCH v10 4/9] ref_tracker: add a static classname string to each ref_tracker_dir

2025-05-27 Thread Jeff Layton
A later patch in the series will be adding debugfs files for each ref_tracker that get created in ref_tracker_dir_init(). The format will be "class@%px". The current "name" string can vary between ref_tracker_dir objects of the same type, so it's not suitable for this purpose. Add a new "class" st

[PATCH v9 1/6] PCI/IOV: Restore VF resizable BAR state after reset

2025-05-27 Thread Michał Winiarski
Similar to regular resizable BAR, VF BAR can also be resized, e.g. by the system firmware or the PCI subsystem itself. The capability layout is the same as PCI_EXT_CAP_ID_REBAR. Add the capability ID and restore it as a part of IOV state. See PCIe r6.2, sec 7.8.7. Signed-off-by: Michał Winiarsk

[PATCH v5 16/19] drm/tests: hdmi: Rename max TMDS rate fallback tests

2025-05-27 Thread Cristian Ciocaltea
In preparation to extend the max TMDS rate fallback tests for covering YUV420 output, update the rather generic function names drm_test_check_max_tmds_rate_{bpc|format}_fallback() to properly indicate the intended test cases. Acked-by: Maxime Ripard Signed-off-by: Cristian Ciocaltea --- drivers

Re: [PATCH v2 03/18] drm/tidss: Adjust the pclk based on the HW capabilities

2025-05-27 Thread Tomi Valkeinen
Hi Michael (and Aradhya, Devarsh), On 27/05/2025 12:13, Michael Walle wrote: > Hi Tomi, > > While testing Aardhya's OLDI support patches [1], I've noticed that > the resulting LVDS clock is wrong if this patch is applied. > >> In practice, with the current K3 SoCs, the display PLL is capable of

Re: [PATCH v3 1/3] Documentation: dma-buf: heaps: Fix code markup

2025-05-27 Thread Maxime Ripard
On Thu, 22 May 2025 12:14:16 -0700, Jared Kangas wrote: > Code snippets should be wrapped in double backticks to follow > reStructuredText semantics; the use of single backticks uses the > :title-reference: role by default, which isn't quite what we want. > Add double backticks to code snippets to

Re: [PATCH v3 2/3] dma-buf: heaps: Parameterize heap name in __add_cma_heap()

2025-05-27 Thread Maxime Ripard
On Thu, 22 May 2025 12:14:17 -0700, Jared Kangas wrote: > Prepare for the introduction of a fixed-name CMA heap by replacing the > unused void pointer parameter in __add_cma_heap() with the heap name. > > Signed-off-by: Jared Kangas Reviewed-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v3 3/3] dma-buf: heaps: Give default CMA heap a fixed name

2025-05-27 Thread Maxime Ripard
Hi, On Thu, May 22, 2025 at 12:14:18PM -0700, Jared Kangas wrote: > The CMA heap's name in devtmpfs can vary depending on how the heap is > defined. Its name defaults to "reserved", but if a CMA area is defined > in the devicetree, the heap takes on the devicetree node's name, such as > "default-p

Re: [PATCH 4/5] drm/mediatek: Add eDP driver for mt8196

2025-05-27 Thread 胡俊光

Re: [PATCH] drm/bridge: adv7511: Do not merge adv7511_mode_set() with atomic_enable()

2025-05-27 Thread Tommaso Merciai
Hi All, On 26/05/25 18:43, Tommaso Merciai wrote: Hi All, On 26/05/25 16:28, Laurent Pinchart wrote: On Mon, May 26, 2025 at 04:13:23PM +0200, Tommaso Merciai wrote: On 26/05/25 16:02, Tommaso Merciai wrote: On 26/05/25 15:18, Dmitry Baryshkov wrote: On 26/05/2025 14:40, Maxime Ripard wrote

Re: [RFC PATCH v2 1/3] drm/bridge: cadence: cdns-mhdp8546-core: Remove legacy support for connector initialisation in bridge

2025-05-27 Thread Jayesh Choudhary
On 27/05/25 14:47, Tomi Valkeinen wrote: Hi, On 27/05/2025 11:41, Jayesh Choudhary wrote: Hello Tomi, On 27/05/25 13:08, Tomi Valkeinen wrote: Hi, On 21/05/2025 10:32, Jayesh Choudhary wrote: Now that we have DBANC framework, remove the connector initialisation code as that piece of code

Re: [PATCH v4 5/5] arm64: dts: qcom: Add Lenovo ThinkBook 16 G7 QOY device tree

2025-05-27 Thread Konrad Dybcio
On 5/26/25 5:28 PM, Rob Clark wrote: > On Mon, May 26, 2025 at 1:36 AM Dmitry Baryshkov > wrote: >> >> On Sun, May 25, 2025 at 09:43:36PM +0200, Aleksandrs Vinarskis wrote: >>> On Sun, 25 May 2025 at 15:33, Dmitry Baryshkov >>> wrote: [...] >> Yes, please. Don't set okay status for the GPU

[PATCH v9 0/6] PCI: VF resizable BAR

2025-05-27 Thread Michał Winiarski
Hi, This revision fixes compile-errors found by LKP on 32bit and PCI_ATS=n configs. v8 can be found here: https://lore.kernel.org/linux-pci/20250526214257.3481760-1-michal.winiar...@intel.com For regular BAR, drivers can use pci_resize_resource to resize it to the desired size provided that it i

[PATCH v9 2/6] PCI: Add a helper to convert between VF BAR number and IOV resource

2025-05-27 Thread Michał Winiarski
There are multiple places where conversions between IOV resources and corresponding VF BAR numbers are done. Extract the logic to pci_resource_num_from_vf_bar() and pci_resource_num_to_vf_bar() helpers. Suggested-by: Ilpo Järvinen Signed-off-by: Michał Winiarski Acked-by: Christian König Revie

[PATCH v9 3/6] PCI: Allow IOV resources to be resized in pci_resize_resource()

2025-05-27 Thread Michał Winiarski
Similar to regular resizable BAR, VF BAR can also be resized. The capability layout is the same as PCI_EXT_CAP_ID_REBAR, which means we can reuse most of the implementation, the only difference being resource size calculation (which is multiplied by total VFs) and memory decoding (which is control

[PATCH v9 4/6] PCI/IOV: Check that VF BAR fits within the reservation

2025-05-27 Thread Michał Winiarski
When the resource representing VF MMIO BAR reservation is created, its size is always large enough to accommodate the BAR of all SR-IOV Virtual Functions that can potentially be created (total VFs). If for whatever reason it's not possible to accommodate all VFs - the resource is not assigned and n

[PATCH v9 6/6] drm/xe/pf: Set VF LMEM BAR size

2025-05-27 Thread Michał Winiarski
LMEM is partitioned between multiple VFs and we expect that the more VFs we have, the less LMEM is assigned to each VF. This means that we can achieve full LMEM BAR access without the need to attempt full VF LMEM BAR resize via pci_resize_resource(). Always try to set the largest possible BAR size

[PATCH v5 10/19] drm/tests: hdmi: Replace open coded EDID setup

2025-05-27 Thread Cristian Ciocaltea
Make use of the recently introduced macros to reduce boilerplate code around EDID setup. This also helps dropping the redundant calls to set_connector_edid(). No functional changes intended. Acked-by: Maxime Ripard Signed-off-by: Cristian Ciocaltea --- drivers/gpu/drm/tests/drm_hdmi_state_help

[PATCH v5 11/19] drm/tests: hdmi: Drop unused drm_kunit_helper_connector_hdmi_init_funcs()

2025-05-27 Thread Cristian Ciocaltea
After updating the code to make use of the new EDID setup helper, drm_kunit_helper_connector_hdmi_init_funcs() became unused, hence drop it. Acked-by: Maxime Ripard Signed-off-by: Cristian Ciocaltea --- drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c | 10 -- 1 file changed, 10 delet

[PATCH v5 05/19] drm/connector: hdmi: Factor out bpc and format computation logic

2025-05-27 Thread Cristian Ciocaltea
In preparation to support fallback to an alternative output format, e.g. YUV420, when RGB cannot be used for any of the available color depths, move the bpc try loop out of hdmi_compute_config() and, instead, make it part of hdmi_compute_format(), while adding a new parameter to the latter holding

[PATCH v5 04/19] drm/connector: hdmi: Add missing bpc debug info to hdmi_try_format_bpc()

2025-05-27 Thread Cristian Ciocaltea
The very first debug message in hdmi_try_format_bpc() is incomplete, as it doesn't provide the given bpc in addition to the tried format. Add the missing debug information and drop the now redundant message from hdmi_compute_config(). Reviewed-by: Dmitry Baryshkov Signed-off-by: Cristian Ciocalt

[PATCH v5 14/19] drm/tests: hdmi: Provide EDID supporting 4K@30Hz with YUV420 only

2025-05-27 Thread Cristian Ciocaltea
Create a test EDID advertising the following capabilities: Max resolution: - 1920x1080@60Hz with RGB, YUV444, YUV422 - 3840x2160@30Hz with YUV420 only Max BPC: 16 for all modes Max TMDS clock: 200 MHz Acked-by: Maxime Ripard Signed-off-by: Cristian Ciocaltea --- drivers/gpu/drm/tests

[PATCH v5 03/19] drm/connector: hdmi: Improve debug message for supported format

2025-05-27 Thread Cristian Ciocaltea
Add the missing 'bpc' string to the debug message indicating the supported format identified within hdmi_try_format_bpc() helper. Reviewed-by: Maxime Ripard Signed-off-by: Cristian Ciocaltea --- drivers/gpu/drm/display/drm_hdmi_state_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-

[PATCH v5 01/19] drm/connector: hdmi: Evaluate limited range after computing format

2025-05-27 Thread Cristian Ciocaltea
Evaluating the requirement to use a limited RGB quantization range involves a verification of the output format, among others, but this is currently performed before actually computing the format, hence relying on the old connector state. Move the call to hdmi_is_limited_range() after hdmi_compute

[PATCH v5 00/19] drm/connector: hdmi: Allow using the YUV420 output format

2025-05-27 Thread Cristian Ciocaltea
Provide the basic support to enable using YUV420 as an RGB fallback when computing the best output format and color depth. Signed-off-by: Cristian Ciocaltea --- Changes in v5: - Collected R-b/A-b tags from Maxime and Dmitry - Got rid of the condition inversion in "drm/connector: hdmi: Use YUV420

[PATCH v5 09/19] drm/tests: hdmi: Add macro to simplify EDID setup

2025-05-27 Thread Cristian Ciocaltea
Factor out the HDMI connector initialization from drm_kunit_helper_connector_hdmi_init_funcs() into a common __connector_hdmi_init() function, while extending its functionality to allow setting custom (i.e. non-default) EDID data. Introduce a macro as a wrapper over the new helper to allow droppin

[PATCH v5 06/19] drm/connector: hdmi: Use YUV420 output format as an RGB fallback

2025-05-27 Thread Cristian Ciocaltea
Try to make use of YUV420 when computing the best output format and RGB cannot be supported for any of the available color depths. Signed-off-by: Cristian Ciocaltea --- drivers/gpu/drm/display/drm_hdmi_state_helper.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff

[PATCH v5 17/19] drm/tests: hdmi: Provide EDID supporting 4K@30Hz with RGB/YUV

2025-05-27 Thread Cristian Ciocaltea
Create a test EDID advertising the following capabilities: Max resolution: 3840x2160@30Hz with RGB, YUV444, YUV422, YUV420 Max BPC:16 for all modes Max TMDS clock: 340 MHz Acked-by: Maxime Ripard Signed-off-by: Cristian Ciocaltea --- drivers/gpu/drm/tests/drm_kunit_edid.h | 114 +++

[PATCH v5 18/19] drm/tests: hdmi: Add max TMDS rate fallback tests for YUV420 mode

2025-05-27 Thread Cristian Ciocaltea
Provide tests to verify drm_atomic_helper_connector_hdmi_check() helper fallback behavior when using YUV420 output format. Acked-by: Maxime Ripard Signed-off-by: Cristian Ciocaltea --- drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c | 154 + 1 file changed, 154 insertions

[PATCH v5 19/19] drm/tests: hdmi: Add test for unsuccessful fallback to YUV420

2025-05-27 Thread Cristian Ciocaltea
Provide test to verify a mandatory fallback to YUV420 output cannot succeed when driver doesn't advertise YUV420 support. Acked-by: Maxime Ripard Signed-off-by: Cristian Ciocaltea --- drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c | 87 ++ 1 file changed, 87 insertions(+

[PATCH v5 02/19] drm/connector: hdmi: Add support for YUV420 format verification

2025-05-27 Thread Cristian Ciocaltea
Provide the necessary constraints verification in sink_supports_format_bpc() in order to support handling of YUV420 output format. Reviewed-by: Maxime Ripard Signed-off-by: Cristian Ciocaltea --- drivers/gpu/drm/display/drm_hdmi_state_helper.c | 39 +++-- 1 file changed, 36

[PATCH v5 15/19] drm/tests: hdmi: Add limited range tests for YUV420 mode

2025-05-27 Thread Cristian Ciocaltea
Provide tests to verify that drm_atomic_helper_connector_hdmi_check() helper behaviour when using YUV420 output format is to always set the limited RGB quantization range to 'limited', no matter what the value of Broadcast RGB property is. Acked-by: Maxime Ripard Signed-off-by: Cristian Ciocaltea

[PATCH v5 13/19] drm/tests: hdmi: Switch to drm_atomic_get_new_connector_state() where possible

2025-05-27 Thread Cristian Ciocaltea
Replace the calls to drm_atomic_get_connector_state() with drm_atomic_get_new_connector_state() for cases which do not require allocating the connector state, e.g. after drm_atomic_check_only() when the intent is to only read the new connector state. The rational is to avoid the need to handle the

[PATCH v5 12/19] drm/tests: hdmi: Setup ycbcr_420_allowed before initializing connector

2025-05-27 Thread Cristian Ciocaltea
Initializing HDMI connector via drmm_connector_hdmi_init() requires its ->ycbcr_420_allowed flag to be adjusted according to the supported formats passed as function argument, prior to the actual invocation. In order to allow providing test coverage for YUV420 modes, ensure the flag is properly se

[PATCH v9 5/6] PCI: Allow drivers to control VF BAR size

2025-05-27 Thread Michał Winiarski
Drivers could leverage the fact that the VF BAR MMIO reservation is created for total number of VFs supported by the device by resizing the BAR to larger size when smaller number of VFs is enabled. Add a pci_iov_vf_bar_set_size() function to control the size and a pci_iov_vf_bar_get_sizes() helper

Re: [PATCH v4 23/23] drm/tests: hdmi: Add test for unsupported RGB/YUV420 mode

2025-05-27 Thread Maxime Ripard
On Thu, May 22, 2025 at 08:37:31PM +0300, Cristian Ciocaltea wrote: > Hi Maxime, > > On 5/22/25 7:16 PM, Maxime Ripard wrote: > > Hi, > > > > On Mon, May 19, 2025 at 01:55:10PM +0300, Cristian Ciocaltea wrote: > >> On 5/19/25 11:42 AM, Maxime Ripard wrote: > >>> Hi, > >>> > >>> On Fri, Apr 25, 20

Re: [PATCH v10 8/9] net: add symlinks to ref_tracker_dir for netns

2025-05-27 Thread Eric Dumazet
On Tue, May 27, 2025 at 4:34 AM Jeff Layton wrote: > > After assigning the inode number to the namespace, use it to create a > unique name for each netns refcount tracker with the ns.inum and > net_cookie values in it, and register a symlink to the debugfs file for > it. > > init_net is registered

Re: [PATCH] Documentation : fb : sstfb.rst : Fixed spelling mistake.

2025-05-27 Thread Helge Deller
On 5/19/25 16:38, rujra wrote: fixed document with spelling mistake changes made : 1. "tweeks" to "tweaks" Signed-off-by: Rujra Bhatt applied to fbdev tree with small changes... Thanks! Helge Documentation/fb/sstfb.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/

Re: [rfc] drm/ttm/memcg: simplest initial memcg/ttm integration (v2)

2025-05-27 Thread Christian König
On 5/26/25 22:13, Dave Airlie wrote: > On Mon, 26 May 2025 at 18:19, Christian König > wrote: >> >> For the HPC/ML use case this feature is completely irrelevant. ROCm, Cuda, >> OpenCL, OpenMP etc... don't even expose something like this in their higher >> level APIs as far as I know. > > What

Re: [PATCH RFC drm-misc-next v2 1/1] drm/hyperv: Add support for drm_panic

2025-05-27 Thread Jocelyn Falempe
On 26/05/2025 11:01, Ryosuke Yasuoka wrote: Add drm_panic module for hyperv drm so that panic screen can be displayed on panic. Thanks, it looks good to me. Reviewed-by: Jocelyn Falempe Signed-off-by: Ryosuke Yasuoka --- drivers/gpu/drm/hyperv/hyperv_drm_modeset.c | 36 ++

[PATCH v3] drm/rockchip: cdn-dp: Convert to drm bridge

2025-05-27 Thread Chaoyi Chen
From: Chaoyi Chen Convert it to drm bridge driver, it will be convenient for us to migrate the connector part to the display driver later. Considering that some code depend on the connector, the following changes have been made: - Only process edid in &drm_bridge_funcs.edid_read(), so no need to

Re: linux-next: build warning after merge of the drm tree

2025-05-27 Thread Stephen Rothwell
Hi all, On Wed, 21 May 2025 20:49:11 +1000 Stephen Rothwell wrote: > > After merging the drm tree, today's linux-next build (htmldocs) produced > this warning: > > Error: Cannot open file drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c > > Introduced by commit > > c472d828348c ("drm/nouveau/

Re: [PATCH v2] drm/sitronix: Remove broken backwards-compatibility layer

2025-05-27 Thread Javier Martinez Canillas
Javier Martinez Canillas writes: > Geert Uytterhoeven writes: > > Hello Geert, > >> When moving the Sitronix DRM drivers and renaming their Kconfig symbols, >> the old symbols were kept, aiming to provide a seamless migration path >> when running "make olddefconfig" or "make oldconfig". >> >> Ho

Re: [RFC PATCH v2 1/3] drm/bridge: cadence: cdns-mhdp8546-core: Remove legacy support for connector initialisation in bridge

2025-05-27 Thread Jayesh Choudhary
Hello Tomi, On 27/05/25 13:08, Tomi Valkeinen wrote: Hi, On 21/05/2025 10:32, Jayesh Choudhary wrote: Now that we have DBANC framework, remove the connector initialisation code as that piece of code is not called if DRM_BRIDGE_ATTACH_NO_CONNECTOR flag is used. Only TI K3 platforms consume this

Re: [PATCH] media: dt-bindings: mediatek: Constrain iommus

2025-05-27 Thread Daniel Stone
Hi, On Sun, 25 May 2025 at 11:51, Krzysztof Kozlowski wrote: > On 25/05/2025 12:48, Daniel Stone wrote: > > On Sun, 25 May 2025 at 06:16, Krzysztof Kozlowski > > wrote: > >> --- > >> a/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl-2l.yaml > >> +++ > >> b/Documentation/devicet

Re: [PATCH] drm/vc4: tests: pv_muxing: Fix locking

2025-05-27 Thread Maxime Ripard
On Sat, May 24, 2025 at 08:09:36AM -0300, Maíra Canal wrote: > On 20/05/25 09:08, Maxime Ripard wrote: > > Commit 30188df0c387 ("drm/tests: Drop drm_kunit_helper_acquire_ctx_alloc()") > > removed a kunit-managed function to get a drm_modeset_acquire_ctx. > > > > It converted the vc4_pv_muxing_test

[PATCH v5 07/19] drm/tests: hdmi: Replace '[_]MHz' with 'mhz'

2025-05-27 Thread Cristian Ciocaltea
Improve consistency throughout drm_hdmi_state_helper_test.c by replacing the two occurrences of '[_]MHz' substring with 'mhz'. As a bonus, this also helps getting rid of checkpatch.pl complaint: CHECK: Avoid CamelCase: Reviewed-by: Dmitry Baryshkov Signed-off-by: Cristian Ciocaltea --- dri

Re: [PATCH v10 8/9] net: add symlinks to ref_tracker_dir for netns

2025-05-27 Thread Eric Dumazet
On Tue, May 27, 2025 at 6:35 AM Eric Dumazet wrote: > > On Tue, May 27, 2025 at 4:34 AM Jeff Layton wrote: > > > > After assigning the inode number to the namespace, use it to create a > > unique name for each netns refcount tracker with the ns.inum and > > net_cookie values in it, and register a

Re: [PATCH v18 6/8] drm/vkms: Create KUnit tests for YUV conversions

2025-05-27 Thread Louis Chauvet
Le 22/05/2025 à 17:39, Maxime Ripard a écrit : On Mon, May 12, 2025 at 03:07:55PM +0200, Louis Chauvet wrote: Hi Maxime, Did you have the time to look at this patch? Pekka added his Acked-by, but as you made some remarks about this patch, I would like to have your validation before applying

[PATCH RFC 0/4] drm/bridge: samsung-dsim: Stop controlling vsync display FIFO flush in panels

2025-05-27 Thread Philipp Zabel
el/panel-samsung-s6d7aa0.c | 2 +- drivers/gpu/drm/panel/panel-samsung-s6e8aa0.c | 2 +- include/drm/drm_mipi_dsi.h| 2 -- 4 files changed, 2 insertions(+), 6 deletions(-) --- base-commit: 99764593528f9e0ee9509f9e4a4eb21db99d0681 change-id: 20250527-dsi-vsync-flush-8f8cc91a6

[PATCH RFC 2/4] drm/panel: samsung-s6d7aa0: Drop MIPI_DSI_MODE_VSYNC_FLUSH flag

2025-05-27 Thread Philipp Zabel
Drop the MIPI_DSI_MODE_VSYNC_FLUSH flag from DSI mode_flags. It has no effect anymore. Signed-off-by: Philipp Zabel --- drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c b/drivers/gpu/d

[PATCH RFC 3/4] drm/panel: samsung-s6e8aa0: Drop MIPI_DSI_MODE_VSYNC_FLUSH flag

2025-05-27 Thread Philipp Zabel
Drop the MIPI_DSI_MODE_VSYNC_FLUSH flag from DSI mode_flags. It has no effect anymore. Signed-off-by: Philipp Zabel --- drivers/gpu/drm/panel/panel-samsung-s6e8aa0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-samsung-s6e8aa0.c b/drivers/gpu/d

[PATCH 2/2] drm/bridge: samsung-dsim: Use HZ_PER_MHZ macro from units.h

2025-05-27 Thread Philipp Zabel
Drop the custom MHZ macro and replace it with HZ_PER_MHZ. Signed-off-by: Philipp Zabel --- drivers/gpu/drm/bridge/samsung-dsim.c | 26 -- 1 file changed, 12 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge/samsun

[PATCH 0/2] drm/bridge: samsung-dsim: Small cleanups

2025-05-27 Thread Philipp Zabel
from units.h drivers/gpu/drm/bridge/samsung-dsim.c | 77 +++ 1 file changed, 33 insertions(+), 44 deletions(-) --- base-commit: 99764593528f9e0ee9509f9e4a4eb21db99d0681 change-id: 20250527-samsung-dsim-2bae3b45f77b Best regards, -- Philipp Zabel

[PATCH RFC 4/4] drm/mipi-dsi: Drop MIPI_DSI_MODE_VSYNC_FLUSH flag

2025-05-27 Thread Philipp Zabel
Drop the unused MIPI_DSI_MODE_VSYNC_FLUSH flag. Whether or not a display FIFO flush on vsync is required to avoid sending garbage to the panel is not a property of the DSI link, but of the integration between display controller and DSI host bridge. Signed-off-by: Philipp Zabel --- include/drm/dr

[PATCH 1/2] drm/bridge: samsung-dsim: use while loop in samsung_dsim_transfer_start

2025-05-27 Thread Philipp Zabel
Turn the open-coded goto-again construct into a while loop, to make samsung_dsim_transfer_start() a bit shorter and easier to read. Hold the spinlock when looping back around and avoid the duplicated list_empty() check. Signed-off-by: Philipp Zabel --- drivers/gpu/drm/bridge/samsung-dsim.c | 51

Re: [PATCH v9 6/9] tee: add tee_shm_alloc_dma_mem()

2025-05-27 Thread Jens Wiklander
On Mon, May 26, 2025 at 11:33 AM Sumit Garg wrote: > > On Mon, May 26, 2025 at 11:21:47AM +0200, Jens Wiklander wrote: > > On Mon, May 26, 2025 at 9:22 AM Sumit Garg wrote: > > > > > > On Tue, May 20, 2025 at 05:16:49PM +0200, Jens Wiklander wrote: > > > > Add tee_shm_alloc_dma_mem() to allocate

RE: [PATCH 2/2] dmabuf/heaps: implement DMA_BUF_IOCTL_RW_FILE for system_heap

2025-05-27 Thread wangtao
> -Original Message- > From: Christian König > Sent: Thursday, May 22, 2025 7:58 PM > To: wangtao ; T.J. Mercier > > Cc: sumit.sem...@linaro.org; benjamin.gaign...@collabora.com; > brian.star...@arm.com; jstu...@google.com; linux-me...@vger.kernel.org; > dri-devel@lists.freedesktop.org;

[PATCH RFC 1/4] drm/bridge: samsung-dsim: Always flush display FIFO on vsync pulse

2025-05-27 Thread Philipp Zabel
Always flush the display FIFO on vsync pulse, even if not explicitly requested by the panel via MIPI_DSI_MODE_VSYNC_FLUSH mode_flag. The display FIFO should be empty at vsync. Flushing it at vsync pulses helps to remove garbage that may have entered the FIFO during startup (if synchronisation betw

Re: [PATCH v8 4/4] drm/tidss: Add OLDI bridge support

2025-05-27 Thread Aradhya Bhatia
Hi Michael, On 27/05/25 11:32, Michael Walle wrote: > Hi Aradhya, > > On Mon May 26, 2025 at 4:17 PM CEST, Aradhya Bhatia wrote: >> Thank you for reviewing and testing the patches! =) > > Thank you for your dedication to bring this feature upstream :) > >> On 26/05/25 15:05, Michael Walle wrote

Re: [PATCH v9 7/9] optee: support protected memory allocation

2025-05-27 Thread Jens Wiklander
On Mon, May 26, 2025 at 9:33 AM Sumit Garg wrote: > > On Tue, May 20, 2025 at 05:16:50PM +0200, Jens Wiklander wrote: > > Add support in the OP-TEE backend driver for protected memory > > allocation. The support is limited to only the SMC ABI and for secure > > video buffers. > > > > OP-TEE is pro

Re: [PATCH 1/2] drm/bridge: samsung-dsim: use while loop in samsung_dsim_transfer_start

2025-05-27 Thread Frieder Schrempf
Am 27.05.25 um 16:21 schrieb Philipp Zabel: > Turn the open-coded goto-again construct into a while loop, to make > samsung_dsim_transfer_start() a bit shorter and easier to read. > > Hold the spinlock when looping back around and avoid the duplicated > list_empty() check. > > Signed-off-by: Phil

Re: [PATCH 2/2] drm/bridge: samsung-dsim: Use HZ_PER_MHZ macro from units.h

2025-05-27 Thread Frieder Schrempf
Am 27.05.25 um 16:21 schrieb Philipp Zabel: > Drop the custom MHZ macro and replace it with HZ_PER_MHZ. > > Signed-off-by: Philipp Zabel Reviewed-by: Frieder Schrempf > --- > drivers/gpu/drm/bridge/samsung-dsim.c | 26 -- > 1 file changed, 12 insertions(+), 14 deletion

Re: [PATCH v4 2/4] drm/panel: Add refcount support

2025-05-27 Thread Jani Nikula
On Tue, 27 May 2025, Maxime Ripard wrote: > On Tue, May 20, 2025 at 01:09:47PM +0300, Jani Nikula wrote: >> >> Maxime - >> >> I'm cutting a lot of context here. Not because I don't think it deserves >> an answer, but because I seem to be failing at communication. >> >> On Mon, 19 May 2025, Maxi

Re: [PATCH v4 2/4] drm/panel: Add refcount support

2025-05-27 Thread Jani Nikula
On Tue, 27 May 2025, Maxime Ripard wrote: > Hi, > > On Fri, May 23, 2025 at 02:34:05PM +0300, Jani Nikula wrote: >> On Tue, 20 May 2025, Jani Nikula wrote: >> > Maxime - >> > >> > I'm cutting a lot of context here. Not because I don't think it deserves >> > an answer, but because I seem to be fai

[PATCH 2/2] drm/amdgpu: Dirty cleared blocks on allocation

2025-05-27 Thread Natalie Vock
If we hand out cleared blocks to users, they are expected to write at least some non-zero values somewhere. If we keep the CLEAR bit set on the block, amdgpu_fill_buffer will assume there is nothing to do and incorrectly skip clearing the block. Ultimately, the (still dirty) block will be reused as

[PATCH 0/2] Fix AMDGPU VRAM zeroing

2025-05-27 Thread Natalie Vock
Hi all, I've stumbled upon this while investigating why AMDGPU seems to fail at providing cleared VRAM allocations despite being explicitly asked to with AMDGPU_GEM_CREATE_VRAM_CLEARED[1]. After some code inspection, I believe the problem is actually much worse than not providing cleared VRAM. AM

[PATCH 1/2] drm/buddy: Add public helper to dirty blocks

2025-05-27 Thread Natalie Vock
Cleared blocks that are handed out to users after allocation cannot be presumed to remain cleared. Thus, allocators using drm_buddy need to dirty all blocks on the allocation success path. Provide a helper for them to use. Fixes: 96950929eb232 ("drm/buddy: Implement tracking clear page feature") C

Re: [PATCH v8] drm/bridge: analogix_dp: Remove the unnecessary calls to clk_disable_unprepare() during probing

2025-05-27 Thread Heiko Stübner
Am Sonntag, 2. März 2025, 09:30:43 Mitteleuropäische Sommerzeit schrieb Damon Ding: > With the commit f37952339cc2 ("drm/bridge: analogix_dp: handle clock via > runtime PM"), the PM operations can help enable/disable the clock. The > err_disable_clk label and clk_disable_unprepare() operations are

[RESEND] Re: [PATCH v8] drm/bridge: analogix_dp: Remove the unnecessary calls to clk_disable_unprepare() during probing

2025-05-27 Thread Heiko Stübner
[resending to update to Dmitry's new address] Am Sonntag, 2. März 2025, 09:30:43 Mitteleuropäische Sommerzeit schrieb Damon Ding: > With the commit f37952339cc2 ("drm/bridge: analogix_dp: handle clock via > runtime PM"), the PM operations can help enable/disable the clock. The > err_disable_clk l

Re: [PATCH v9 8/9] optee: FF-A: dynamic protected memory allocation

2025-05-27 Thread Jens Wiklander
On Mon, May 26, 2025 at 10:09 AM Sumit Garg wrote: > > On Tue, May 20, 2025 at 05:16:51PM +0200, Jens Wiklander wrote: > > Add support in the OP-TEE backend driver dynamic protected memory > > allocation with FF-A. > > > > The protected memory pools for dynamically allocated protected memory > > a

Re: [PATCH v10 2/5] rust: support formatting of foreign types

2025-05-27 Thread Tamir Duberstein
On Tue, May 27, 2025 at 8:44 AM Alice Ryhl wrote: > > On Tue, May 27, 2025 at 12:18 AM Tamir Duberstein wrote: > > > > +} > > > > + > > > > +fn make_ident<'a, T: IntoIterator>( > > > > +span: Span, > > > > +names: T, > > > > +) -> impl Iterator + use<'a, T> { > > > > +names.into_iter(

Re: [PATCH v10 2/5] rust: support formatting of foreign types

2025-05-27 Thread Tamir Duberstein
On Mon, May 26, 2025 at 7:01 PM Benno Lossin wrote: > > On Tue May 27, 2025 at 12:17 AM CEST, Tamir Duberstein wrote: > > On Mon, May 26, 2025 at 10:48 AM Benno Lossin wrote: > >> On Sat May 24, 2025 at 10:33 PM CEST, Tamir Duberstein wrote: > >> > Introduce a `fmt!` macro which wraps all argumen

[PATCH v10 5/9] ref_tracker: allow pr_ostream() to print directly to a seq_file

2025-05-27 Thread Jeff Layton
Allow pr_ostream to also output directly to a seq_file without an intermediate buffer. The first caller of +ref_tracker_dir_seq_print() will come in a later patch, so mark that __maybe_unused for now. That designation will be removed once it is used. Reviewed-by: Andrew Lunn Signed-off-by: Jeff L

Re: [PATCH 2/2] dmabuf/heaps: implement DMA_BUF_IOCTL_RW_FILE for system_heap

2025-05-27 Thread Christian König
On 5/27/25 16:35, wangtao wrote: >> -Original Message- >> From: Christian König >> Sent: Thursday, May 22, 2025 7:58 PM >> To: wangtao ; T.J. Mercier >> >> Cc: sumit.sem...@linaro.org; benjamin.gaign...@collabora.com; >> brian.star...@arm.com; jstu...@google.com; linux-me...@vger.kernel.o

[PATCH 6.12 626/626] drm/gem: Internally test import_attach for imported objects

2025-05-27 Thread Greg Kroah-Hartman
6.12-stable review patch. If anyone has any objections, please let me know. -- From: Thomas Zimmermann commit 8260731ccad0451207b45844bb66eb161a209218 upstream. Test struct drm_gem_object.import_attach to detect imported objects. During object clenanup, the dma_buf field migh

Re: [PATCH v10 8/9] net: add symlinks to ref_tracker_dir for netns

2025-05-27 Thread Jeff Layton
On Tue, 2025-05-27 at 06:37 -0700, Eric Dumazet wrote: > On Tue, May 27, 2025 at 6:35 AM Eric Dumazet wrote: > > > > On Tue, May 27, 2025 at 4:34 AM Jeff Layton wrote: > > > > > > After assigning the inode number to the namespace, use it to create a > > > unique name for each netns refcount tra

Re: [PATCH] Revert "drm/amd/display: no 3D and blnd LUT as DPP color caps for DCN401"

2025-05-27 Thread Aurabindo Pillai
On 2025-05-27 13:06, Alex Hung wrote: This reverts commit 46e68dd5066c9831e9695c1756db017bb9c3762c since it breaks color enhancement in another OS, indicating these two fields are still used by color management in dcn401. Fixes: 46e68dd5066c ("drm/amd/display: no 3D and blnd LUT as DPP color

[PATCH] drm/connector: only call HDMI audio helper plugged cb if non-null

2025-05-27 Thread Nicolas Frattaroli
c_dev, connector->hdmi_audio.last_state); + if (fn) + fn(codec_dev, connector->hdmi_audio.last_state); mutex_unlock(&connector->hdmi_audio.lock); --- base-commit: 502d44c1a440c5f428f50f02e58cd5633454ea8d change-id: 20250527-hdmi-audio-helper-remove-fix-43b2cd0e64

Re: [PATCH] drm/connector: only call HDMI audio helper plugged cb if non-null

2025-05-27 Thread Dmitry Baryshkov
On 27/05/2025 20:57, Nicolas Frattaroli wrote: On driver remove, sound/soc/codecs/hdmi-codec.c calls the plugged_cb with NULL as the callback function and codec_dev, as seen in its hdmi_remove function. The HDMI audio helper then happily tries calling said null function pointer, and produces an

  1   2   >