Hi, On Sun, 25 May 2025 at 11:51, Krzysztof Kozlowski <k...@kernel.org> wrote: > On 25/05/2025 12:48, Daniel Stone wrote: > > On Sun, 25 May 2025 at 06:16, Krzysztof Kozlowski > > <krzysztof.kozlow...@linaro.org> wrote: > >> --- > >> a/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl-2l.yaml > >> +++ > >> b/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl-2l.yaml > >> @@ -45,9 +45,8 @@ properties: > >> - description: OVL-2L Clock > >> > >> iommus: > >> - description: > >> - This property should point to the respective IOMMU block with > >> master port as argument, > >> - see Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml for > >> details. > >> + minItems: 1 > >> + maxItems: 2 > > > > The comment removals are not documented in the commit message, and > > it's not clear why removing information and references would be a good > > thing. > It's obvious, isn't? The consumer shall not define which provider has to > use or how many cells provider has.
If you feel the change is good, then document it in the commit message, and ideally also use separate commits rather than throwing in unrelated changes into a commit which does not explain anything. Again, the kernel documentation explains how you can structure your commits in a better way. Cheers, Daniel
