Re: [PATCH v3 5/6] arm64: dts: qcom: x1p42100: Add Lenovo ThinkBook 16 G7 QOY

2025-05-24 Thread Dmitry Baryshkov
On Sat, May 24, 2025 at 11:19:12AM +0200, Jens Glathe via B4 Relay wrote: > From: Jens Glathe > > The Thinkbook 16 appears to be an X1 / X1 Plus only design. > Add make targets for normal and -el2 variant. > > Signed-off-by: Jens Glathe > --- > arch/arm64/boot/dts/qcom/Makefile | 3 +++ > 1 fi

Re: [PATCH 1/4] drm/sched: optimize drm_sched_job_add_dependency

2025-05-24 Thread Danilo Krummrich
On Fri, May 23, 2025 at 04:11:39PM +0200, Danilo Krummrich wrote: > On Fri, May 23, 2025 at 02:56:40PM +0200, Christian König wrote: > > + if (xas_nomem(&xas, GFP_KERNEL)) { > > + xa_lock(&job->dependencies); > > + goto retry; > > Please don't use a goto here, if we would hav

[PATCH v2] drivers: gpu: drm: msm: registers: improve reproducibility

2025-05-24 Thread Viswanath Kraleti
From: Ryan Eatmon The files generated by gen_header.py capture the source path to the input files and the date. While that can be informative, it varies based on where and when the kernel was built as the full path is captured. Since all of the files that this tool is run on is under the driver

Re: [PATCH] drivers: gpu: drm: msm: registers: improve reproducibility

2025-05-24 Thread Viswanath Kraleti
On Fri, May 23, 2025 at 10:30 PM Dmitry Baryshkov wrote: > > On Fri, May 23, 2025 at 06:36:16PM +0530, Viswanath Kraleti wrote: > > The files generated by gen_header.py capture the source path to the > > input files and the date. While that can be informative, it varies > > You are not the author

[PATCH v10 4/5] rust: replace `kernel::c_str!` with C-Strings

2025-05-24 Thread Tamir Duberstein
C-String literals were added in Rust 1.77. Replace instances of `kernel::c_str!` with C-String literals where possible and rename `kernel::c_str!` to `c_str_avoid_literals` to clarify its intended use. Closes: https://github.com/Rust-for-Linux/linux/issues/1075 Signed-off-by: Tamir Duberstein ---

[syzbot] Monthly dri report (May 2025)

2025-05-24 Thread syzbot
Hello dri maintainers/developers, This is a 31-day syzbot report for the dri subsystem. All related reports/information can be found at: https://syzkaller.appspot.com/upstream/s/dri During the period, 3 new issues were detected and 0 were fixed. In total, 18 issues are still open and 32 have alre

Re: [PATCH v3 4/6] firmware: qcom: scm: Allow QSEECOM on Lenovo Thinkbook 16

2025-05-24 Thread Dmitry Baryshkov
On Sat, May 24, 2025 at 11:19:11AM +0200, Jens Glathe via B4 Relay wrote: > From: Jens Glathe > > Allow particular machine accessing eg. efivars. > > Signed-off-by: Jens Glathe > --- > drivers/firmware/qcom/qcom_scm.c | 1 + > 1 file changed, 1 insertion(+) > Reviewed-by: Dmitry Baryshkov

Re: [PATCH] drm/vc4: tests: pv_muxing: Fix locking

2025-05-24 Thread Maíra Canal
On 20/05/25 09:08, Maxime Ripard wrote: Commit 30188df0c387 ("drm/tests: Drop drm_kunit_helper_acquire_ctx_alloc()") removed a kunit-managed function to get a drm_modeset_acquire_ctx. It converted the vc4_pv_muxing_test_init() function, used by drm_vc4_test_pv_muxing() and drm_vc4_test_pv_muxing

Re: [PATCH] drm/mediatek: Add wait_event_timeout when disabling plane

2025-05-24 Thread Daniel Stone
Hi Jason, On Thu, 22 May 2025 at 09:52, Jason-JH Lin wrote: > Our hardware registers are set through GCE, not by the CPU. > DRM might assume the hardware is disabled immediately after calling > atomic_disable() of drm_plane, but it is only truly disabled after the > GCE IRQ is triggered. > > Addi

Re: [PATCH v3 5/6] arm64: dts: qcom: x1p42100: Add Lenovo ThinkBook 16 G7 QOY

2025-05-24 Thread Konrad Dybcio
On 5/24/25 12:36 PM, Jens Glathe wrote: > Am 24.05.25 um 12:11 schrieb Dmitry Baryshkov: >> This will break without the next patch. They need to be squashet into a >> single patch. >> > Changing the order wouldn't suffice? It would, but that would then mean you're introducing dead (i.e. not compil

Re: [PATCH v4 5/5] arm64: dts: qcom: Add Lenovo ThinkBook 16 G7 QOY device tree

2025-05-24 Thread Aleksandrs Vinarskis
On Sat, 24 May 2025 at 17:33, Dmitry Baryshkov wrote: > > On Sat, May 24, 2025 at 01:48:40PM +0200, Jens Glathe via B4 Relay wrote: > > From: Jens Glathe > > > > Device tree for the Lenovo Thinkbook 16 G7 QOY > > > > The Laptop is a Snapdragon X1 / X1 Plus (Purwa) based device [1]. > > > > Suppor

[PATCH] drm/amd/display: Constify struct timing_generator_funcs

2025-05-24 Thread Christophe JAILLET
'struct timing_generator_funcs' are not modified in these drivers. Constifying these structures moves some data to a read-only section, so increases overall security, especially when the structure holds some function pointers. Signed-off-by: Christophe JAILLET --- This is NOT compile tested, bec

Re: [PATCH v10 08/10] drm/xe/nvm: add on-die non-volatile memory device

2025-05-24 Thread Raag Jadav
On Thu, May 15, 2025 at 04:33:43PM +0300, Alexander Usyskin wrote: > Enable access to internal non-volatile memory on DGFX > with GSC/CSC devices via a child device. > The nvm child device is exposed via auxiliary bus. ... > +void xe_nvm_init(struct xe_device *xe) > +{ Same as patch 6, please ha

Re: [PATCH 1/8] drm/sched: Allow drivers to skip the reset and keep on running

2025-05-24 Thread Maíra Canal
Hi Philipp, Sorry, I was OoO for a couple of weeks. On 13/05/25 04:26, Philipp Stanner wrote: On Sat, 2025-05-03 at 17:59 -0300, Maíra Canal wrote: When the DRM scheduler times out, it's possible that the GPU isn't hung; instead, a job may still be running, and there may be no valid reason to

Re: [PATCH v10 05/10] mtd: intel-dg: align 64bit read and write

2025-05-24 Thread Raag Jadav
On Thu, May 15, 2025 at 04:33:40PM +0300, Alexander Usyskin wrote: > GSC NVM controller HW errors on quad access overlapping 1K border. > Align 64bit read and write to avoid readq/writeq over 1K border. > > Acked-by: Miquel Raynal > Signed-off-by: Alexander Usyskin > --- > drivers/mtd/devices/m

Re: [PATCH v4] drm/panthor: Make the timeout per-queue instead of per-job

2025-05-24 Thread Daniel Stone
Hi Ashley, On Fri, 23 May 2025 at 16:10, Ashley Smith wrote: > The timeout logic provided by drm_sched leads to races when we try > to suspend it while the drm_sched workqueue queues more jobs. Let's > overhaul the timeout handling in panthor to have our own delayed work > that's resumed/suspende

[PATCH v10 2/5] rust: support formatting of foreign types

2025-05-24 Thread Tamir Duberstein
Introduce a `fmt!` macro which wraps all arguments in `kernel::fmt::Adapter` This enables formatting of foreign types (like `core::ffi::CStr`) that do not implement `fmt::Display` due to concerns around lossy conversions which do not apply in the kernel. Replace all direct calls to `format_args!`

[PATCH v10 5/5] rust: remove core::ffi::CStr reexport

2025-05-24 Thread Tamir Duberstein
Clean up references to `kernel::str::CStr`. Signed-off-by: Tamir Duberstein --- drivers/gpu/drm/drm_panic_qr.rs | 3 ++- drivers/gpu/nova-core/firmware.rs | 2 +- drivers/net/phy/ax88796b_rust.rs | 1 + drivers/net/phy/qt2025.rs | 1 + rust/kernel/device.rs | 3 +-- r

[PATCH v10 3/5] rust: replace `CStr` with `core::ffi::CStr`

2025-05-24 Thread Tamir Duberstein
`std::ffi::CStr` was moved to `core::ffi::CStr` in Rust 1.64. Replace `kernel::str::CStr` with `core::ffi::CStr` now that we can. C-String literals were added in Rust 1.77. Opportunistically replace instances of `kernel::c_str!` with C-String literals where other code changes were already necessar

[PATCH v10 1/5] rust: retitle "Example" section as "Examples"

2025-05-24 Thread Tamir Duberstein
This title is consistent with all other macros' documentation, regardless of the number of examples contained in their "Examples" sections. Signed-off-by: Tamir Duberstein --- rust/macros/lib.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rust/macros/lib.rs b/rust/macros/

[PATCH v10 0/5] rust: replace kernel::str::CStr w/ core::ffi::CStr

2025-05-24 Thread Tamir Duberstein
This picks up from Michal Rostecki's work[0]. Per Michal's guidance I have omitted Co-authored tags, as the end result is quite different. Link: https://lore.kernel.org/rust-for-linux/20240819153656.28807-2-vadorov...@protonmail.com/t/#u [0] Closes: https://github.com/Rust-for-Linux/linux/issues

Re: [PATCH v4 3/5] usb: misc: onboard_usb_dev: Add Bison Electronics Inc. Integrated Camera

2025-05-24 Thread Dmitry Baryshkov
On Sat, May 24, 2025 at 01:48:38PM +0200, Jens Glathe via B4 Relay wrote: > From: Jens Glathe > > The Camera is built into the Thinkbook 16 G7 QOY and directly attached on the > usb_2 controller (dwc3 USB2 only). It has a separate power supply that needs > to be controlled for PM. > > Add the su

Re: [PATCH v4 5/5] arm64: dts: qcom: Add Lenovo ThinkBook 16 G7 QOY device tree

2025-05-24 Thread Dmitry Baryshkov
On Sat, May 24, 2025 at 01:48:40PM +0200, Jens Glathe via B4 Relay wrote: > From: Jens Glathe > > Device tree for the Lenovo Thinkbook 16 G7 QOY > > The Laptop is a Snapdragon X1 / X1 Plus (Purwa) based device [1]. > > Supported features: > > - USB type-c and type-a ports > - Keyboard > - Touc

[PATCH v4 1/5] dt-bindings: arm: qcom: Add Lenovo TB16 support

2025-05-24 Thread Jens Glathe via B4 Relay
From: Jens Glathe Document the x1p-42-100/x1-26-100 variants of the Thinkbook 16 G7 QOY. [1]: https://psref.lenovo.com/syspool/Sys/PDF/ThinkBook/ThinkBook_16_G7_QOY/ThinkBook_16_G7_QOY_Spec.pdf Signed-off-by: Jens Glathe --- Documentation/devicetree/bindings/arm/qcom.yaml | 1 + 1 file chang

[PATCH v4 5/5] arm64: dts: qcom: Add Lenovo ThinkBook 16 G7 QOY device tree

2025-05-24 Thread Jens Glathe via B4 Relay
From: Jens Glathe Device tree for the Lenovo Thinkbook 16 G7 QOY The Laptop is a Snapdragon X1 / X1 Plus (Purwa) based device [1]. Supported features: - USB type-c and type-a ports - Keyboard - Touchpad (all that are described in the dsdt) - Touchscreen (described in the dsdt, no known SKUss)

[PATCH v4 2/5] drm/panel-edp: add N160JCE-ELL CMN panel for Lenovo Thinkbook 16

2025-05-24 Thread Jens Glathe via B4 Relay
From: Jens Glathe Panel is widely used in 16" laptops, and also in my Thinkbook 16 G7 QOY. CMN N160JCE-ELL EDID edid-decode (hex): 00 ff ff ff ff ff ff 00 0d ae 2b 16 00 00 00 00 20 20 01 04 a5 22 16 78 03 28 65 97 59 54 8e 27 1e 50 54 00 00 00 01 01 01 01 01 01 01 01 01 01 01 01 01 01 01 01 42

[PATCH v4 0/5] arm64: dts: qcom: Add Lenovo ThinkBook 16 device tree

2025-05-24 Thread Jens Glathe via B4 Relay
efile and dts commits to one - picked up r-b from Dmitry Baryshkov - Link to v3: https://lore.kernel.org/r/20250524-tb16-dt-v3-0-17e26d935...@oldschoolsolutions.biz Changes in v3: - removed changes in x1e80100.dtsi and x1p42100.dtsi - resolved with [2] - fixed schema errors with correct compatible s

[PATCH v4 4/5] firmware: qcom: scm: Allow QSEECOM on Lenovo Thinkbook 16

2025-05-24 Thread Jens Glathe via B4 Relay
From: Jens Glathe Allow particular machine accessing eg. efivars. Reviewed-by: Dmitry Baryshkov Signed-off-by: Jens Glathe --- drivers/firmware/qcom/qcom_scm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/firmware/qcom/qcom_scm.c b/drivers/firmware/qcom/qcom_scm.c index f63b71

[PATCH v4 3/5] usb: misc: onboard_usb_dev: Add Bison Electronics Inc. Integrated Camera

2025-05-24 Thread Jens Glathe via B4 Relay
From: Jens Glathe The Camera is built into the Thinkbook 16 G7 QOY and directly attached on the usb_2 controller (dwc3 USB2 only). It has a separate power supply that needs to be controlled for PM. Add the support for this device for the power supply. Signed-off-by: Jens Glathe --- drivers/us

[PATCH] media: dt-bindings: mediatek: Constrain iommus

2025-05-24 Thread Krzysztof Kozlowski
Lists should have fixed constraints, because binding must be specific in respect to hardware. Add missing constraints to number of iommus in Mediatek media devices. Signed-off-by: Krzysztof Kozlowski --- .../bindings/display/mediatek/mediatek,ovl-2l.yaml | 5 ++--- .../devicetree/bind

MT8183: Only maximum resolution 1280x720?

2025-05-24 Thread Paul Menzel
Dear Linux folks, On the older MT8183 device Lenovo IdeaPad Duet Chromebook, running ChromeOS with their Linux 5.10.x, connecting a 1920x1080 Dell monitor to a USB-C adapter using HDMI, only the resolution of 1280x720 is configured, although the adapter also support 1920x1080. It happens with

Re: [PATCH v3 5/6] arm64: dts: qcom: x1p42100: Add Lenovo ThinkBook 16 G7 QOY

2025-05-24 Thread Jens Glathe
Am 24.05.25 um 12:11 schrieb Dmitry Baryshkov: This will break without the next patch. They need to be squashet into a single patch. Changing the order wouldn't suffice? No problem, will squash with best regards Jens

Re: [PATCH v2] drivers: gpu: drm: msm: registers: improve reproducibility

2025-05-24 Thread Dmitry Baryshkov
On Sat, May 24, 2025 at 09:25:37PM +0530, Viswanath Kraleti wrote: > From: Ryan Eatmon > > The files generated by gen_header.py capture the source path to the > input files and the date. While that can be informative, it varies > based on where and when the kernel was built as the full path is >

Re: [PATCH v10 06/10] drm/i915/nvm: add nvm device for discrete graphics

2025-05-24 Thread Raag Jadav
On Thu, May 15, 2025 at 04:33:41PM +0300, Alexander Usyskin wrote: > Enable access to internal non-volatile memory on > DGFX devices via a child device. > The nvm child device is exposed via auxiliary bus. ... > +void intel_nvm_init(struct drm_i915_private *i915) > +{ Lucas recently revamped xe

Re: [PATCH] drm: add overview diagram for drm stack

2025-05-24 Thread Abdulrasaq Lawani
Thanks for the feedback. I have added the fix and sent another version (v2) of the patch. https://lore.kernel.org/all/20250523-drm-doc-updates-v2-0-e517df152...@gmail.com/ best regards, Abdulrasaq On Fri, May 23, 2025 at 7:58 AM Jonathan Corbet wrote: > Abdulrasaq Lawani writes: > > > Add an

Re: [PATCH] drm: add overview diagram for drm stack

2025-05-24 Thread Abdulrasaq Lawani
Thanks for the feedback. I have added the fix and sent another version (v2) of the patch. best regards, Abdulrasaq On Fri, May 23, 2025 at 7:58 AM Jonathan Corbet wrote: > Abdulrasaq Lawani writes: > > > Add an overview diagram of Linux DRM architecture for > > graphics and compute to introdu

Re: [PATCH] drm: add overview diagram for drm stack

2025-05-24 Thread Abdulrasaq Lawani
Thanks for the feedback. I have added the fix and sent another version (v2) of the patch. https://lore.kernel.org/all/20250523-drm-doc-updates-v2-0-e517df152...@gmail.com/ best regards, Abdulrasaq On Fri, May 23, 2025 at 7:58 AM Jonathan Corbet wrote: > > Abdulrasaq Lawani writes: > > > Add a

Re: [PATCH v3 0/4] drm: panel: add support for panels used in LG P880/P895

2025-05-24 Thread Dmitry Baryshkov
On Tue, 06 May 2025 12:27:14 +0300, Svyatoslav Ryhel wrote: > Add support for panels used in LG P880/P895 which are based on Renesas IC > (not related to Renesas RISC-V architecture just the same manufacturer). > Applied to drm-misc-next, thanks! [1/4] dt-bindings: display: panel: Document Renes

RE: [PATCH v2] drm: renesas: rz-du: Add atomic_pre_enable

2025-05-24 Thread Biju Das
Hi Chris, Thanks for the patch. > -Original Message- > From: Chris Brandt > Sent: 21 May 2025 22:04 > Subject: [PATCH v2] drm: renesas: rz-du: Add atomic_pre_enable > > When drm_panel.prepare_prev_first is set to true in a panel driver, the panel > expects the MIPI DSI > hardware to be

Re: [PATCH v3 3/4] fbdev/deferred-io: Support contiguous kernel memory framebuffers

2025-05-24 Thread kernel test robot
-base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/mhkelley58-gmail-com/mm-Export-vmf_insert_mixed_mkwrite/20250524-001707 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-

Re: [PATCH v3 2/9] drm/bridge: synopsys: Add DW DPTX Controller support library

2025-05-24 Thread Dmitry Baryshkov
On Wed, May 14, 2025 at 08:15:55PM +0800, Andy Yan wrote: > Hello Dmitry, > > Would it be convenient for you to continue reviewing this patch at your > convenience? > Or let me know your opinion on this patch. > >There is still one unresolved issue highlighted by you in the first > ver

[PATCH] drm: Fix potential null pointer dereference issues in drm_managed.c

2025-05-24 Thread Haoxiang Li
Add check for the return value of kstrdup_const() in drm_managed.c to prevent potential null pointer dereference. Fixes: c6603c740e0e ("drm: add managed resources tied to drm_device") Cc: sta...@vger.kernel.org Signed-off-by: Haoxiang Li --- drivers/gpu/drm/drm_managed.c | 9 + 1 file ch

Re:Re: [PATCH v3 2/9] drm/bridge: synopsys: Add DW DPTX Controller support library

2025-05-24 Thread Andy Yan
Hello Dmitry, 在 2025-05-24 15:46:15,"Dmitry Baryshkov" 写道: >On Wed, May 14, 2025 at 08:15:55PM +0800, Andy Yan wrote: >> Hello Dmitry, >> >> Would it be convenient for you to continue reviewing this patch at your >> convenience? >> Or let me know your opinion on this patch. >> >>Th

Re: [PATCH v5 04/16] drm/atomic: Introduce helper to lookup connector by encoder

2025-05-24 Thread Dmitry Baryshkov
On Sun, Mar 23, 2025 at 04:22:27AM +0200, Dmitry Baryshkov wrote: > On Fri, Mar 21, 2025 at 10:46:56AM +0100, Maxime Ripard wrote: > > On Tue, Mar 18, 2025 at 09:00:29PM +0200, Dmitry Baryshkov wrote: > > > On Tue, Mar 18, 2025 at 04:51:19PM +0100, Maxime Ripard wrote: > > > > On Fri, Mar 14, 2025

Re: [PATCH v3 2/9] drm/bridge: synopsys: Add DW DPTX Controller support library

2025-05-24 Thread Dmitry Baryshkov
On Sat, May 24, 2025 at 03:59:52PM +0800, Andy Yan wrote: > > > Hello Dmitry, > > > 在 2025-05-24 15:46:15,"Dmitry Baryshkov" > 写道: > >On Wed, May 14, 2025 at 08:15:55PM +0800, Andy Yan wrote: > >> Hello Dmitry, > >> > >> Would it be convenient for you to continue reviewing this patch at

[PATCH v3 1/6] dt-bindings: arm: qcom: Add Lenovo TB16 support

2025-05-24 Thread Jens Glathe via B4 Relay
From: Jens Glathe Document the x1p-42-100/x1-26-100 variants of the Thinkbook 16 G7 QOY. [1]: https://psref.lenovo.com/syspool/Sys/PDF/ThinkBook/ThinkBook_16_G7_QOY/ThinkBook_16_G7_QOY_Spec.pdf Signed-off-by: Jens Glathe --- Documentation/devicetree/bindings/arm/qcom.yaml | 1 + 1 file chang

[PATCH v3 3/6] usb: misc: onboard_usb_dev: Add Bison Electronics Inc. Integrated Camera

2025-05-24 Thread Jens Glathe via B4 Relay
From: Jens Glathe The Camera is built into the Thinkbook 16 G7 QOY and directly attached on the usb_2 controller (dwc3 USB2 only). It has a separate power supply that needs to be controlled for PM. Add the support for this device for the power supply. Signed-off-by: Jens Glathe --- drivers/us

[PATCH v3 2/6] drm/panel-edp: add N160JCE-ELL CMN panel for Lenovo Thinkbook 16

2025-05-24 Thread Jens Glathe via B4 Relay
From: Jens Glathe Panel is widely used in 16" laptops, and also in my Thinkbook 16 G7 QOY. CMN N160JCE-ELL EDID edid-decode (hex): 00 ff ff ff ff ff ff 00 0d ae 2b 16 00 00 00 00 20 20 01 04 a5 22 16 78 03 28 65 97 59 54 8e 27 1e 50 54 00 00 00 01 01 01 01 01 01 01 01 01 01 01 01 01 01 01 01 42

[PATCH v3 5/6] arm64: dts: qcom: x1p42100: Add Lenovo ThinkBook 16 G7 QOY

2025-05-24 Thread Jens Glathe via B4 Relay
From: Jens Glathe The Thinkbook 16 appears to be an X1 / X1 Plus only design. Add make targets for normal and -el2 variant. Signed-off-by: Jens Glathe --- arch/arm64/boot/dts/qcom/Makefile | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/bo

[PATCH v3 6/6] arm64: dts: qcom: Add Lenovo ThinkBook 16 device tree

2025-05-24 Thread Jens Glathe via B4 Relay
From: Jens Glathe Device tree for the Lenovo Thinkbook 16 G7 QOY The Laptop is a Snapdragon X1 / X1 Plus (Purwa) based device [1]. Supported features: - USB type-c and type-a ports - Keyboard - Touchpad (all that are described in the dsdt) - Touchscreen (described in the dsdt, no known SKUss)

[PATCH v3 0/6] arm64: dts: qcom: Add Lenovo ThinkBook 16 device tree

2025-05-24 Thread Jens Glathe via B4 Relay
Device tree for the Lenovo Thinkbook 16 G7 QOY The Laptop is a Snapdragon X1 / X1 Plus (Purwa) based device [1]. Supported features: - USB type-c and type-a ports - Keyboard - Touchpad (all that are described in the dsdt) - Touchscreen (described in the dsdt, no known SKUss) - Display including

[PATCH v3 4/6] firmware: qcom: scm: Allow QSEECOM on Lenovo Thinkbook 16

2025-05-24 Thread Jens Glathe via B4 Relay
From: Jens Glathe Allow particular machine accessing eg. efivars. Signed-off-by: Jens Glathe --- drivers/firmware/qcom/qcom_scm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/firmware/qcom/qcom_scm.c b/drivers/firmware/qcom/qcom_scm.c index f63b716be5b027550ae3a987e784f0814ea6d