Re: [PATCH v4 3/5] usb: misc: onboard_usb_dev: Add Bison Electronics Inc. Integrated Camera

[Dmitry Baryshkov]

On Sat, May 24, 2025 at 01:48:38PM +0200, Jens Glathe via B4 Relay wrote:
> From: Jens Glathe <jens.gla...@oldschoolsolutions.biz>
> 
> The Camera is built into the Thinkbook 16 G7 QOY and directly attached on the
> usb_2 controller (dwc3 USB2 only). It has a separate power supply that needs
> to be controlled for PM.
> 
> Add the support for this device for the power supply.
> 
> Signed-off-by: Jens Glathe <jens.gla...@oldschoolsolutions.biz>
> ---
>  drivers/usb/misc/onboard_usb_dev.c | 2 ++
>  drivers/usb/misc/onboard_usb_dev.h | 8 ++++++++
>  2 files changed, 10 insertions(+)
> 
> diff --git a/drivers/usb/misc/onboard_usb_dev.c 
> b/drivers/usb/misc/onboard_usb_dev.c
> index 
> 1048e3912068ced166c76838cf7306d86e192fe4..17b1f345b6b65bf25e68e77b0a345936825e1d04
>  100644
> --- a/drivers/usb/misc/onboard_usb_dev.c
> +++ b/drivers/usb/misc/onboard_usb_dev.c
> @@ -569,6 +569,7 @@ static struct platform_driver onboard_dev_driver = {
>  #define VENDOR_ID_TI         0x0451
>  #define VENDOR_ID_VIA                0x2109
>  #define VENDOR_ID_XMOS               0x20B1
> +#define VENDOR_ID_BISON              0x5986

The list seems sorted alphabetically. Please follow the lead.

>  
>  /*
>   * Returns the onboard_dev platform device that is associated with the USB
> @@ -677,6 +678,7 @@ static const struct usb_device_id onboard_dev_id_table[] 
> = {
>       { USB_DEVICE(VENDOR_ID_VIA, 0x0817) }, /* VIA VL817 3.1 HUB */
>       { USB_DEVICE(VENDOR_ID_VIA, 0x2817) }, /* VIA VL817 2.0 HUB */
>       { USB_DEVICE(VENDOR_ID_XMOS, 0x0013) }, /* XMOS XVF3500 Voice Processor 
> */
> +     { USB_DEVICE(VENDOR_ID_BISON, 0x1198) }, /* Bison Electronics Inc. 
> Integrated Camera */

This one too.

>       {}
>  };
>  MODULE_DEVICE_TABLE(usb, onboard_dev_id_table);
> diff --git a/drivers/usb/misc/onboard_usb_dev.h 
> b/drivers/usb/misc/onboard_usb_dev.h
> index 
> e017b8e22f936be66da73789abb4f620e6af4d6a..816d9ce71eaddc7ab0cb4517558dd44a591d6c28
>  100644
> --- a/drivers/usb/misc/onboard_usb_dev.h
> +++ b/drivers/usb/misc/onboard_usb_dev.h
> @@ -115,6 +115,13 @@ static const struct onboard_dev_pdata xmos_xvf3500_data 
> = {
>       .is_hub = false,
>  };
>  
> +static const struct onboard_dev_pdata bison_intcamera_data = {
> +     .reset_us = 1000,
> +     .num_supplies = 1,
> +     .supply_names = { "vdd" },
> +     .is_hub = false,
> +};
> +
>  static const struct of_device_id onboard_dev_match[] = {
>       { .compatible = "usb424,2412", .data = &microchip_usb424_data, },
>       { .compatible = "usb424,2514", .data = &microchip_usb2514_data, },
> @@ -144,6 +151,7 @@ static const struct of_device_id onboard_dev_match[] = {
>       { .compatible = "usb2109,817", .data = &vialab_vl817_data, },
>       { .compatible = "usb2109,2817", .data = &vialab_vl817_data, },
>       { .compatible = "usb20b1,0013", .data = &xmos_xvf3500_data, },
> +     { .compatible = "usb5986,1198", .data = &bison_intcamera_data, },

And these two.

>       {}
>  };
>  
> 
> -- 
> 2.48.1
> 
> 

-- 
With best wishes
Dmitry