Re: [PATCH v3 16/19] nova-core: Add support for VBIOS ucode extraction for boot

2025-05-19 Thread Joel Fernandes
On 5/16/2025 4:38 PM, Timur Tabi wrote: > n Wed, 2025-05-07 at 22:52 +0900, Alexandre Courbot wrote: >> +impl FwSecBiosImage { >> +    fn setup_falcon_data( >> +    &mut self, >> +    pdev: &pci::Device, >> +    pci_at_image: &PciAtBiosImage, >> +    first_fwsec_image: &FwSecBios

Re: [PATCH v6] backlight: led-backlight: add devlink to supplier LEDs

2025-05-19 Thread Herve Codina
Hi Luca, On Mon, 19 May 2025 22:19:11 +0200 Luca Ceresoli wrote: > led-backlight is a consumer of one or multiple LED class devices, but > devlink is currently unable to create correct supplier-producer links when > the supplier is a class device. It creates instead a link where the > supplier i

Re: [PATCH v1] misc: fastrpc: Fix channel resource access in device_open

2025-05-19 Thread Ekansh Gupta
On 5/18/2025 4:33 PM, Dmitry Baryshkov wrote: > On Sat, May 17, 2025 at 12:54:32PM +0530, Ekansh Gupta wrote: >> During rpmsg_probe, fastrpc device nodes are created first, then >> channel specific resources are initialized, followed by >> of_platform_populate, which triggers context bank probin

Re: [PATCH v4 2/2] dt-bindings: display: rockchip: Convert cdn-dp-rockchip.txt to yaml

2025-05-19 Thread Chaoyi Chen
Hi Krzysztof, On 2025/5/19 14:16, Krzysztof Kozlowski wrote: On 19/05/2025 03:26, Chaoyi Chen wrote: +maintainers: + - Andy Yan + - Heiko Stuebner + - Sandy Huang + +allOf: + - $ref: /schemas/sound/dai-common.yaml# + +properties: + compatible: +items: + - const: rockchip,rk3399

Re: [PATCH v2 5/8] KVM: SEV: Prefer WBNOINVD over WBINVD for cache maintenance efficiency

2025-05-19 Thread Francesco Lavra
On 2025-05-16 at 21:28, Sean Christopherson wrote: > @@ -3901,7 +3908,7 @@ void sev_snp_init_protected_guest_state(struct > kvm_vcpu *vcpu) >   * From this point forward, the VMSA will always be a guest- > mapped page >   * rather than the initial one allocated by KVM in svm- > >sev_es.vm

[PATCH] dummycon: Trigger redraw when switching consoles with deferred takeover

2025-05-19 Thread Thomas Zimmermann
Signal vt subsystem to redraw console when switching to dummycon with deferred takeover enabled. Makes the console switch to fbcon and displays the available output. With deferred takeover enabled, dummycon acts as the placeholder until the first output to the console happens. At that point, fbcon

Re: [PATCH v4 14/23] drm/tests: hdmi: Add macro to support EDEADLK handling

2025-05-19 Thread Maxime Ripard
Hi, On Fri, Apr 25, 2025 at 01:27:05PM +0300, Cristian Ciocaltea wrote: > In preparation to improve error handling throughout all test cases, > introduce a macro to check for EDEADLK and automate the restart of the > atomic sequence. > > Signed-off-by: Cristian Ciocaltea > --- > drivers/gpu/drm

Re: [PATCH v4 16/23] drm/tests: hdmi: Switch to drm_atomic_get_new_connector_state() where possible

2025-05-19 Thread Maxime Ripard
On Fri, 25 Apr 2025 13:27:07 +0300, Cristian Ciocaltea wrote: > Replace the calls to drm_atomic_get_connector_state() with > drm_atomic_get_new_connector_state() for cases which do not require > allocating the connector state, e.g. after drm_atomic_check_only() when > the intent is to only read the

Re: [PATCH v6 03/10] drm/connector: add CEC-related fields

2025-05-19 Thread Maxime Ripard
On Sat, 17 May 2025 04:59:39 +0300, Dmitry Baryshkov wrote: > As a preparation to adding HDMI CEC helper code, add CEC-related fields > to the struct drm_connector. The callbacks abstract CEC infrastructure > in order to support CEC adapters and CEC notifiers in a universal way. > > CEC data is a

Re: [PATCH v6 07/10] drm/vc4: hdmi: switch to generic CEC helpers

2025-05-19 Thread Maxime Ripard
On Sat, 17 May 2025 04:59:43 +0300, Dmitry Baryshkov wrote: > Switch VC4 driver to using CEC helpers code, simplifying hotplug and > registration / cleanup. The existing vc4_hdmi_cec_release() is kept for > now. > > Signed-off-by: Dmitry Baryshkov > > [ ... ] Reviewed-by: Maxime Ripard Thanks

Re: [PATCH v6 10/10] drm/bridge: adv7511: switch to the HDMI connector helpers

2025-05-19 Thread Maxime Ripard
On Sat, 17 May 2025 04:59:46 +0300, Dmitry Baryshkov wrote: > Rewrite the ADV7511 driver to use implementation provided by the DRM > HDMI connector framework, including the Audio and CEC bits. Drop the > in-bridge connector support and use drm_bridge_connector if the host > requires the connector t

Re: [PATCH v6 05/10] drm/display: add CEC helpers code

2025-05-19 Thread Maxime Ripard
On Sat, 17 May 2025 04:59:41 +0300, Dmitry Baryshkov wrote: > Add generic CEC helpers to be used by HDMI drivers. Both notifier and > and adapter are supported for registration. Once registered, the driver > can call common set of functions to update physical address, to > invalidate it or to unreg

Re: [PATCH 2/2] dmabuf/heaps: implement DMA_BUF_IOCTL_RW_FILE for system_heap

2025-05-19 Thread Christian König
On 5/19/25 06:08, wangtao wrote: > > >> -Original Message- >> From: Christian König >> Sent: Friday, May 16, 2025 6:29 PM >> To: wangtao ; sumit.sem...@linaro.org; >> benjamin.gaign...@collabora.com; brian.star...@arm.com; >> jstu...@google.com; tjmerc...@google.com >> Cc: linux-me...@vg

Re: [PATCH v4 17/23] drm/tests: hdmi: Provide EDID supporting 4K@30Hz with YUV420 only

2025-05-19 Thread Maxime Ripard
On Fri, 25 Apr 2025 13:27:08 +0300, Cristian Ciocaltea wrote: > Create a test EDID advertising the following capabilities: > > Max resolution: > - 1920x1080@60Hz with RGB, YUV444, YUV422 > - 3840x2160@30Hz with YUV420 only > > [ ... ] Acked-by: Maxime Ripard Thanks! Maxime

Re: [PATCH 5/8] drm/msm/dp: Add support for lane mapping configuration

2025-05-19 Thread Xiangxu Yin
On 3/6/2025 5:14 AM, Dmitry Baryshkov wrote: > On Wed, Mar 05, 2025 at 06:16:45PM +0800, Xiangxu Yin wrote: >> >> >> On 12/20/2024 5:45 AM, Dmitry Baryshkov wrote: >>> On Thu, Dec 19, 2024 at 06:36:38PM +0800, Xiangxu Yin wrote: On 12/5/2024 7:40 PM, Dmitry Baryshkov wrote: >

Re: [PATCH v4 2/2] dt-bindings: display: rockchip: Convert cdn-dp-rockchip.txt to yaml

2025-05-19 Thread Krzysztof Kozlowski
On Mon, May 19, 2025 at 02:56:03PM GMT, Chaoyi Chen wrote: > Hi Krzysztof, > > On 2025/5/19 14:16, Krzysztof Kozlowski wrote: > > On 19/05/2025 03:26, Chaoyi Chen wrote: > > > +maintainers: > > > + - Andy Yan > > > + - Heiko Stuebner > > > + - Sandy Huang > > > + > > > +allOf: > > > + - $re

Re: [PATCH v3 02/10] arm64: dts: rockchip: Add nodes for NPU and its MMU to rk3588s

2025-05-19 Thread Tomeu Vizoso
On Mon, May 19, 2025 at 8:08 AM Krzysztof Kozlowski wrote: > > On 16/05/2025 18:53, Tomeu Vizoso wrote: > > See Chapter 36 "RKNN" from the RK3588 TRM (Part 1). > > > > This is a derivative of NVIDIA's NVDLA, but with its own front-end > > processor. > > > > The IP is divided in three cores, progra

Re: [PATCH v4 22/23] drm/tests: hdmi: Add test for unsuccessful fallback to YUV420

2025-05-19 Thread Maxime Ripard
On Fri, 25 Apr 2025 13:27:13 +0300, Cristian Ciocaltea wrote: > Provide test to verify a mandatory fallback to YUV420 output cannot > succeed when driver doesn't advertise YUV420 support. > > Signed-off-by: Cristian Ciocaltea Acked-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v4 23/23] drm/tests: hdmi: Add test for unsupported RGB/YUV420 mode

2025-05-19 Thread Maxime Ripard
Hi, On Fri, Apr 25, 2025 at 01:27:14PM +0300, Cristian Ciocaltea wrote: > Provide a test to verify that if both driver and screen support RGB and > YUV420 formats, drm_atomic_helper_connector_hdmi_check() cannot succeed > when trying to set a mode unsupported by the display. > > Signed-off-by: Cr

Re: [PATCH] drm/virtio: implement virtio_gpu_shutdown

2025-05-19 Thread Maxime Ripard
On Sun, May 18, 2025 at 05:53:59PM -0400, Michael S. Tsirkin wrote: > On Tue, May 13, 2025 at 12:18:44PM +0200, Gerd Hoffmann wrote: > > > > diff --git a/drivers/gpu/drm/virtio/virtgpu_drv.c > > > > b/drivers/gpu/drm/virtio/virtgpu_drv.c > > > > index e32e680c7197..71c6ccad4b99 100644 > > > > ---

Re: [PATCH v4 2/2] dt-bindings: display: rockchip: Convert cdn-dp-rockchip.txt to yaml

2025-05-19 Thread Chaoyi Chen
Hi Krzysztof, On 2025/5/19 16:23, Krzysztof Kozlowski wrote: On Mon, May 19, 2025 at 02:56:03PM GMT, Chaoyi Chen wrote: Hi Krzysztof, On 2025/5/19 14:16, Krzysztof Kozlowski wrote: On 19/05/2025 03:26, Chaoyi Chen wrote: +maintainers: + - Andy Yan + - Heiko Stuebner + - Sandy Huang + +

Re: [PATCH 1/3] drm/sched: add drm_sched_prealloc_dependency_slots v3

2025-05-19 Thread Tvrtko Ursulin
On 16/05/2025 18:16, Philipp Stanner wrote: On Fri, 2025-05-16 at 15:30 +0100, Tvrtko Ursulin wrote: On 16/05/2025 14:38, Philipp Stanner wrote: On Fri, 2025-05-16 at 13:10 +0100, Tvrtko Ursulin wrote: On 16/05/2025 12:53, Tvrtko Ursulin wrote: On 16/05/2025 08:28, Philipp Stanner wrote:

Re: [PATCH 1/3] drm/sched: add drm_sched_prealloc_dependency_slots v3

2025-05-19 Thread Philipp Stanner
On Mon, 2025-05-19 at 09:51 +0100, Tvrtko Ursulin wrote: > > On 16/05/2025 18:16, Philipp Stanner wrote: > > On Fri, 2025-05-16 at 15:30 +0100, Tvrtko Ursulin wrote: > > > > > > On 16/05/2025 14:38, Philipp Stanner wrote: > > > > On Fri, 2025-05-16 at 13:10 +0100, Tvrtko Ursulin wrote: > > > > >

[PATCH v16 00/42] DEPT(DEPendency Tracker)

2025-05-19 Thread Byungchul Park
Found out a recent deadlock issue can be reported by dept. The issue is: https://lore.kernel.org/all/20250513093448.592150-1-gavin...@igalia.com/ I'm happy to see that dept reported real problems in practice. See: https://lore.kernel.org/lkml/6383cde5-cf4b-facf-6e07-1378a4856...@i-love.

[PATCH v16 01/42] llist: move llist_{head, node} definition to types.h

2025-05-19 Thread Byungchul Park
llist_head and llist_node can be used by some other header files. For example, dept for tracking dependencies uses llist in its header. To avoid header dependency, move them to types.h. Signed-off-by: Byungchul Park --- include/linux/llist.h | 8 include/linux/types.h | 8 2

[PATCH v16 15/42] dept: apply sdt_might_sleep_{start, end}() to waitqueue wait

2025-05-19 Thread Byungchul Park
Make dept able to track dependencies by waitqueue waits. Signed-off-by: Byungchul Park --- include/linux/wait.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/linux/wait.h b/include/linux/wait.h index 965a19809c7e..aae161e500dc 100644 --- a/include/linux/wait.h +++ b/include/linu

[PATCH v16 04/42] dept: add lock dependency tracker APIs

2025-05-19 Thread Byungchul Park
Wrap the base APIs for easier annotation on typical lock. Signed-off-by: Byungchul Park --- include/linux/dept_ldt.h | 78 1 file changed, 78 insertions(+) create mode 100644 include/linux/dept_ldt.h diff --git a/include/linux/dept_ldt.h b/include/linux

[PATCH v16 24/42] dept: make dept able to work with an external wgen

2025-05-19 Thread Byungchul Park
There is a case where the total map size of waits of a class is so large. For instance, PG_locked is the case if every struct page embeds its regular map for PG_locked. The total size for the maps will be 'the # of pages * sizeof(struct dept_map)', which is too big to accept. Keep the minimum dat

[PATCH v16 23/42] dept: apply timeout consideration to dma fence wait

2025-05-19 Thread Byungchul Park
Now that CONFIG_DEPT_AGGRESSIVE_TIMEOUT_WAIT was introduced, apply the consideration to dma fence wait. Signed-off-by: Byungchul Park --- drivers/dma-buf/dma-fence.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/dma-buf/dma-fence.c b/drivers/dma-buf/dma-fence.c

[PATCH v16 05/42] dept: tie to lockdep and IRQ tracing

2025-05-19 Thread Byungchul Park
How to place dept this way looks so ugly. However, it's inevitable for now. The way should be enhanced gradually. Signed-off-by: Byungchul Park --- include/linux/irqflags.h| 7 +- include/linux/local_lock_internal.h | 1 + include/linux/lockdep.h | 102 +

[PATCH v16 22/42] dept: apply timeout consideration to hashed-waitqueue wait

2025-05-19 Thread Byungchul Park
Now that CONFIG_DEPT_AGGRESSIVE_TIMEOUT_WAIT was introduced, apply the consideration to hashed-waitqueue wait, assuming an input 'ret' in ___wait_var_event() macro is used as a timeout value. Signed-off-by: Byungchul Park --- include/linux/wait_bit.h | 2 +- 1 file changed, 1 insertion(+), 1 del

[PATCH v16 26/42] dept: print staged wait's stacktrace on report

2025-05-19 Thread Byungchul Park
Currently, print nothing about what event wakes up in report. However, it makes hard to interpret dept's report. Make it print wait's stacktrace that the event wakes up. Signed-off-by: Byungchul Park --- include/linux/dept.h | 5 include/linux/sched.h| 2 ++ kernel/dependency/de

[PATCH v16 18/42] dept: track timeout waits separately with a new Kconfig

2025-05-19 Thread Byungchul Park
Waits with valid timeouts don't actually cause deadlocks. However, dept has been reporting the cases as well because it's worth informing the circular dependency for some cases where, for example, timeout is used to avoid a deadlock. However, yes, there are also a lot of, even more, cases where t

[PATCH v16 03/42] dept: add single event dependency tracker APIs

2025-05-19 Thread Byungchul Park
Wrapped the base APIs for easier annotation on wait and event. Start with supporting waiters on each single event. More general support for multiple events is a future work. Do more when the need arises. How to annotate: 1. Initaialize a map for the interesting wait. /* * Place along w

[PATCH v16 17/42] dept: apply sdt_might_sleep_{start, end}() to dma fence

2025-05-19 Thread Byungchul Park
Make dept able to track dependencies by dma fence waits and signals. Signed-off-by: Byungchul Park --- drivers/dma-buf/dma-fence.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/dma-buf/dma-fence.c b/drivers/dma-buf/dma-fence.c index f0cdd3e99d36..5d2fd2f6a46d 100644 --- a/driv

[PATCH v16 14/42] dept: apply sdt_might_sleep_{start,end}() to swait

2025-05-19 Thread Byungchul Park
Make dept able to track dependencies by swaits. Signed-off-by: Byungchul Park --- include/linux/swait.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/linux/swait.h b/include/linux/swait.h index d324419482a0..277ac74f61c3 100644 --- a/include/linux/swait.h +++ b/include/linux/swa

[PATCH v16 35/42] i2c: rename wait_for_completion callback to wait_for_completion_cb

2025-05-19 Thread Byungchul Park
Functionally no change. This patch is a preparation for DEPT(DEPendency Tracker) to track dependencies related to a scheduler API, wait_for_completion(). Unfortunately, struct i2c_algo_pca_data has a callback member named wait_for_completion, that is the same as the scheduler API, which makes it

[PATCH v16 21/42] dept: apply timeout consideration to waitqueue wait

2025-05-19 Thread Byungchul Park
Now that CONFIG_DEPT_AGGRESSIVE_TIMEOUT_WAIT was introduced, apply the consideration to waitqueue wait, assuming an input 'ret' in ___wait_event() macro is used as a timeout value. Signed-off-by: Byungchul Park --- include/linux/wait.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH v16 29/42] cpu/hotplug: use a weaker annotation in AP thread

2025-05-19 Thread Byungchul Park
cb92173d1f0 ("locking/lockdep, cpu/hotplug: Annotate AP thread") was introduced to make lockdep_assert_cpus_held() work in AP thread. However, the annotation is too strong for that purpose. We don't have to use more than try lock annotation for that. rwsem_acquire() implies: 1. might be a wa

[PATCH v16 28/42] dept: add documentation for dept

2025-05-19 Thread Byungchul Park
This document describes the concept and APIs of dept. Signed-off-by: Byungchul Park --- Documentation/dependency/dept.txt | 735 ++ Documentation/dependency/dept_api.txt | 117 2 files changed, 852 insertions(+) create mode 100644 Documentation/dependency/dept.t

[PATCH v16 27/42] locking/lockdep: prevent various lockdep assertions when lockdep_off()'ed

2025-05-19 Thread Byungchul Park
lockdep provides APIs for assertion only if lockdep is enabled at the moment asserting to avoid unnecessary confusion, using the following condition, debug_locks && !this_cpu_read(lockdep_recursion). However, lockdep_{off,on}() are also used for disabling and enabling lockdep for a simular purpose

[PATCH v16 30/42] fs/jbd2: use a weaker annotation in journal handling

2025-05-19 Thread Byungchul Park
jbd2 journal handling code doesn't want jbd2_might_wait_for_commit() to be placed between start_this_handle() and stop_this_handle(). So it marks the region with rwsem_acquire_read() and rwsem_release(). However, the annotation is too strong for that purpose. We don't have to use more than try l

[PATCH v16 11/42] dept: add a mechanism to refill the internal memory pools on running out

2025-05-19 Thread Byungchul Park
dept engine works in a constrained environment. For example, dept cannot make use of dynamic allocation e.g. kmalloc(). So dept has been using static pools to keep memory chunks dept uses. However, dept would barely work once any of the pools gets run out. So implemented a mechanism for the ref

[PATCH v16 37/42] completion, dept: introduce init_completion_dmap() API

2025-05-19 Thread Byungchul Park
Currently, dept uses dept's map embedded in task_struct to track dependencies related to wait_for_completion() and its family. So it doesn't need an explicit map basically. However, for those who want to set the maps with customized class or key, introduce a new API to use external maps. Signed-

[PATCH v16 39/42] dept: add module support for struct dept_event_site and dept_event_site_dep

2025-05-19 Thread Byungchul Park
struct dept_event_site and struct dept_event_site_dep have been introduced to track dependencies between multi event sites for a single wait, that will be loaded to data segment. Plus, a custom section, '.dept.event_sites', also has been introduced to keep pointers to the objects to make sure all

[PATCH v16 13/42] dept: apply sdt_might_sleep_{start, end}() to wait_for_completion()/complete()

2025-05-19 Thread Byungchul Park
Make dept able to track dependencies by wait_for_completion()/complete(). Signed-off-by: Byungchul Park --- include/linux/completion.h | 30 +- 1 file changed, 25 insertions(+), 5 deletions(-) diff --git a/include/linux/completion.h b/include/linux/completion.h index

[PATCH v16 10/42] dept: distinguish each work from another

2025-05-19 Thread Byungchul Park
Workqueue already provides concurrency control. By that, any wait in a work doesn't prevents events in other works with the control enabled. Thus, each work would better be considered a different context. So let dept assign a different context id to each work. Signed-off-by: Byungchul Park ---

[PATCH v16 38/42] dept: introduce a new type of dependency tracking between multi event sites

2025-05-19 Thread Byungchul Park
It's worth reporting wait-event circular dependency even if it doesn't lead to an actual deadlock, because it's a good information about a circular dependency anyway. However, it should be suppressed once turning out it doesn't lead an actual deadlock, for instance, there are other wake-up(or even

[PATCH v16 36/42] dept: assign unique dept_key to each distinct wait_for_completion() caller

2025-05-19 Thread Byungchul Park
wait_for_completion() can be used at various points in the code and it's very hard to distinguish wait_for_completion()s between different usages. Using a single dept_key for all the wait_for_completion()s could trigger false positive reports. Assign unique dept_key to each distinct wait_for_compl

[PATCH v16 41/42] dept: implement a basic unit test for dept

2025-05-19 Thread Byungchul Park
Implement CONFIG_DEPT_UNIT_TEST introducing a kernel module that runs basic unit test for dept. Signed-off-by: Byungchul Park --- include/linux/dept_unit_test.h | 67 +++ kernel/dependency/Makefile | 1 + kernel/dependency/dept.c | 12 ++ kernel/dependency/dept_

[PATCH v16 40/42] dept: introduce event_site() to disable event tracking if it's recoverable

2025-05-19 Thread Byungchul Park
With multi event sites for a single wait, dept allows to skip tracking an event that is recoverable by other recover paths. Introduce an API, event_site(), to skip tracking the event in the case. Signed-off-by: Byungchul Park --- include/linux/dept.h | 30 ++ inc

Re: [PATCH v1 1/5] misc: fastrpc: Add NULL check to fastrpc_buf_free to prevent crash

2025-05-19 Thread Srinivas Kandagatla
On 5/13/25 05:28, Ekansh Gupta wrote: > The fastrpc_buf_free function currently does not handle the case where > the input buffer pointer (buf) is NULL. This can lead to a null pointer > dereference, causing a crash or undefined behavior when the function > attempts to access members of the buf str

[PATCH v16 25/42] dept: track PG_locked with dept

2025-05-19 Thread Byungchul Park
Makes dept able to track PG_locked waits and events, which will be useful in practice. See the following link that shows dept worked with PG_locked and detected real issues in practice: https://lore.kernel.org/lkml/1674268856-31807-1-git-send-email-byungchul.p...@lge.com/ Signed-off-by: Byun

Re: [rfc] drm/ttm/memcg: simplest initial memcg/ttm integration (v2)

2025-05-19 Thread Christian König
On 5/19/25 08:18, Dave Airlie wrote: > On Mon, 19 May 2025 at 02:28, Christian König > wrote: >> >> On 5/16/25 22:25, Dave Airlie wrote: >>> On Sat, 17 May 2025 at 06:04, Johannes Weiner wrote: > The memory properties are similar to what GFP_DMA or GFP_DMA32 > provide. > > The re

[PATCH v16 08/42] x86_64, dept: add support CONFIG_ARCH_HAS_DEPT_SUPPORT to x86_64

2025-05-19 Thread Byungchul Park
dept needs to notice every entrance from user to kernel mode to treat every kernel context independently when tracking wait-event dependencies. Roughly, system call and user oriented fault are the cases. Make dept aware of the entrances of x86_64 and add support CONFIG_ARCH_HAS_DEPT_SUPPORT to x86

[PATCH v16 09/42] arm64, dept: add support CONFIG_ARCH_HAS_DEPT_SUPPORT to arm64

2025-05-19 Thread Byungchul Park
dept needs to notice every entrance from user to kernel mode to treat every kernel context independently when tracking wait-event dependencies. Roughly, system call and user oriented fault are the cases. Make dept aware of the entrances of arm64 and add support CONFIG_ARCH_HAS_DEPT_SUPPORT to arm6

Re: [PATCH v4 21/23] drm/tests: hdmi: Add max TMDS rate fallback tests for YUV420 mode

2025-05-19 Thread Maxime Ripard
On Fri, 25 Apr 2025 13:27:12 +0300, Cristian Ciocaltea wrote: > Provide tests to verify drm_atomic_helper_connector_hdmi_check() helper > fallback behavior when using YUV420 output format. > > Signed-off-by: Cristian Ciocaltea Acked-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v4 19/23] drm/tests: hdmi: Rename max TMDS rate fallback tests

2025-05-19 Thread Maxime Ripard
On Fri, 25 Apr 2025 13:27:10 +0300, Cristian Ciocaltea wrote: > In preparation to extend the max TMDS rate fallback tests for covering > YUV420 output, update the rather generic function names > drm_test_check_max_tmds_rate_{bpc|format}_fallback() to properly > indicate the intended test cases. >

Re: [PATCH 5/8] drm/msm/dp: Add support for lane mapping configuration

2025-05-19 Thread Dmitry Baryshkov
On Mon, 19 May 2025 at 11:20, Xiangxu Yin wrote: > > > > On 3/6/2025 5:14 AM, Dmitry Baryshkov wrote: > > On Wed, Mar 05, 2025 at 06:16:45PM +0800, Xiangxu Yin wrote: > >> > >> > >> On 12/20/2024 5:45 AM, Dmitry Baryshkov wrote: > >>> On Thu, Dec 19, 2024 at 06:36:38PM +0800, Xiangxu Yin wrote: >

Re: [PATCH v1 1/5] misc: fastrpc: Add NULL check to fastrpc_buf_free to prevent crash

2025-05-19 Thread Dmitry Baryshkov
On Mon, May 19, 2025 at 10:25:46AM +0100, Srinivas Kandagatla wrote: > On 5/13/25 05:28, Ekansh Gupta wrote: > > The fastrpc_buf_free function currently does not handle the case where > > the input buffer pointer (buf) is NULL. This can lead to a null pointer > > dereference, causing a crash or und

Re: [PATCH v3 02/10] arm64: dts: rockchip: Add nodes for NPU and its MMU to rk3588s

2025-05-19 Thread Tomeu Vizoso
On Mon, May 19, 2025 at 10:47 AM Krzysztof Kozlowski wrote: > > On 19/05/2025 10:27, Tomeu Vizoso wrote: > > On Mon, May 19, 2025 at 8:08 AM Krzysztof Kozlowski wrote: > >> > >> On 16/05/2025 18:53, Tomeu Vizoso wrote: > >>> See Chapter 36 "RKNN" from the RK3588 TRM (Part 1). > >>> > >>> This is

Re: [PATCH v1 3/5] misc: fastrpc: Fix initial memory allocation for Audio PD memory pool

2025-05-19 Thread Dmitry Baryshkov
On Tue, May 13, 2025 at 09:58:23AM +0530, Ekansh Gupta wrote: > The initially allocated memory is not properly included in the pool, > leading to potential issues with memory management. Set the number What is 'properly'? Which issues? > of pages to one to ensure that the initially allocated memo

Re: [PATCH v1 4/5] misc: fastrpc: Remove buffer from list prior to unmap operation

2025-05-19 Thread Dmitry Baryshkov
On Tue, May 13, 2025 at 09:58:24AM +0530, Ekansh Gupta wrote: > fastrpc_req_munmap_impl() is called to unmap any buffer. The buffer is > getting removed from the list after it is unmapped from DSP. This can > create potential race conditions if any other thread removes the entry > from list while u

Re: [PATCH v4 12/23] drm/tests: helpers: Add a (re)try helper variant to enable CRTC connector

2025-05-19 Thread Cristian Ciocaltea
Hi Maxime, On 5/16/25 4:15 PM, Maxime Ripard wrote: > Hi, > > On Fri, Apr 25, 2025 at 01:27:03PM +0300, Cristian Ciocaltea wrote: >> Provide a wrapper over drm_kunit_helper_enable_crtc_connector() to >> automatically handle EDEADLK. >> >> This is going to help improve the error handling in a bunc

Re: [PATCH v3 02/10] arm64: dts: rockchip: Add nodes for NPU and its MMU to rk3588s

2025-05-19 Thread Krzysztof Kozlowski
On 19/05/2025 10:27, Tomeu Vizoso wrote: > On Mon, May 19, 2025 at 8:08 AM Krzysztof Kozlowski wrote: >> >> On 16/05/2025 18:53, Tomeu Vizoso wrote: >>> See Chapter 36 "RKNN" from the RK3588 TRM (Part 1). >>> >>> This is a derivative of NVIDIA's NVDLA, but with its own front-end >>> processor. >>>

Re: [PATCH v4 14/23] drm/tests: hdmi: Add macro to support EDEADLK handling

2025-05-19 Thread Cristian Ciocaltea
On 5/19/25 10:22 AM, Maxime Ripard wrote: > Hi, > > On Fri, Apr 25, 2025 at 01:27:05PM +0300, Cristian Ciocaltea wrote: >> In preparation to improve error handling throughout all test cases, >> introduce a macro to check for EDEADLK and automate the restart of the >> atomic sequence. >> >> Signed-

[PATCH v16 19/42] dept: apply timeout consideration to wait_for_completion()/complete()

2025-05-19 Thread Byungchul Park
Now that CONFIG_DEPT_AGGRESSIVE_TIMEOUT_WAIT was introduced, apply the consideration to wait_for_completion()/complete(). Signed-off-by: Byungchul Park --- include/linux/completion.h | 4 ++-- kernel/sched/completion.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/inclu

Re: [PATCH v3 0/2] drm/ci: mesa uprev and python-artifacts fixes

2025-05-19 Thread Daniel Stone
Hi Vignesh, On Wed, 14 May 2025 at 06:04, Vignesh Raman wrote: > The python-artifacts job has a timeout of 10 minutes, which causes > build failures as it was unable to clone the repository within the > specified limits. Set GIT_DEPTH to 10 to speed up cloning and avoid > build failures due to ti

Re: [PATCH v1 2/5] misc: fastrpc: Move all remote heap allocations to a new list

2025-05-19 Thread Dmitry Baryshkov
On Tue, May 13, 2025 at 09:58:22AM +0530, Ekansh Gupta wrote: > Remote heap allocations are not organized in a maintainable manner, > leading to potential issues with memory management. As the remote Which issues? I think I have been asking this question previously. Please expand the commit messag

Re: [PATCH v1 1/5] misc: fastrpc: Add NULL check to fastrpc_buf_free to prevent crash

2025-05-19 Thread Ekansh Gupta
On 5/19/2025 4:10 PM, Srinivas Kandagatla wrote: > On 5/19/25 11:09, Dmitry Baryshkov wrote: >> On Mon, May 19, 2025 at 10:25:46AM +0100, Srinivas Kandagatla wrote: >>> On 5/13/25 05:28, Ekansh Gupta wrote: The fastrpc_buf_free function currently does not handle the case where the inpu

Re: [PATCH v1 5/5] misc: fastrpc: Add missing unmapping user-requested remote heap

2025-05-19 Thread Ekansh Gupta
On 5/19/2025 4:22 PM, Dmitry Baryshkov wrote: > On Tue, May 13, 2025 at 09:58:25AM +0530, Ekansh Gupta wrote: >> User request for remote heap allocation is supported using ioctl >> interface but support for unmap is missing. This could result in >> memory leak issues. Add unmap user request supp

Re: [PATCH v7 1/2] arm64: dts: qcom: sa8775p: add Display Serial Interface device nodes

2025-05-19 Thread Ayushi Makhija
On 5/19/2025 6:31 AM, Dmitry Baryshkov wrote: > On Tue, May 13, 2025 at 03:56:10PM +0530, Ayushi Makhija wrote: >> From: Ayushi Makhija >> >> Add device tree nodes for the DSI0 and DSI1 controllers >> with their corresponding PHYs found on Qualcomm SA8775P SoC. >> >> Signed-off-by: Ayushi Makhija

Re: [PATCH v4 23/23] drm/tests: hdmi: Add test for unsupported RGB/YUV420 mode

2025-05-19 Thread Cristian Ciocaltea
On 5/19/25 11:42 AM, Maxime Ripard wrote: > Hi, > > On Fri, Apr 25, 2025 at 01:27:14PM +0300, Cristian Ciocaltea wrote: >> Provide a test to verify that if both driver and screen support RGB and >> YUV420 formats, drm_atomic_helper_connector_hdmi_check() cannot succeed >> when trying to set a mode

Re: [PATCH v1 2/5] misc: fastrpc: Move all remote heap allocations to a new list

2025-05-19 Thread Ekansh Gupta
On 5/19/2025 3:46 PM, Dmitry Baryshkov wrote: > On Tue, May 13, 2025 at 09:58:22AM +0530, Ekansh Gupta wrote: >> Remote heap allocations are not organized in a maintainable manner, >> leading to potential issues with memory management. As the remote > Which issues? I think I have been asking thi

Re: [PATCH v9 02/10] drm/sched: store the drm client_id in drm_sched_fence

2025-05-19 Thread Pierre-Eric Pelloux-Prayer
Le 15/05/2025 à 08:53, Pierre-Eric Pelloux-Prayer a écrit : Hi, Le 14/05/2025 à 14:44, Philipp Stanner a écrit : On Thu, 2025-04-24 at 10:38 +0200, Pierre-Eric Pelloux-Prayer wrote: This will be used in a later commit to trace the drm client_id in some of the gpu_scheduler trace events. Th

Re: [PATCH v1 1/5] misc: fastrpc: Add NULL check to fastrpc_buf_free to prevent crash

2025-05-19 Thread Srinivas Kandagatla
On 5/19/25 11:09, Dmitry Baryshkov wrote: > On Mon, May 19, 2025 at 10:25:46AM +0100, Srinivas Kandagatla wrote: >> On 5/13/25 05:28, Ekansh Gupta wrote: >>> The fastrpc_buf_free function currently does not handle the case where >>> the input buffer pointer (buf) is NULL. This can lead to a null po

[PATCH] drm/connector: move HDR sink metadata to display info

2025-05-19 Thread Jani Nikula
Information parsed from the display EDID should be stored in display info. Move HDR sink metadata there. Signed-off-by: Jani Nikula --- This depends on commit 6692dbc15e5e ("drm/edid: fixed the bug that hdr metadata was not reset") in drm-misc-fixes. Will need to wait for backmerge. --- driver

Re: [PATCH v1 2/5] misc: fastrpc: Move all remote heap allocations to a new list

2025-05-19 Thread Srinivas Kandagatla
On 5/13/25 05:28, Ekansh Gupta wrote: > Remote heap allocations are not organized in a maintainable manner, > leading to potential issues with memory management. As the remote > heap allocations are maintained in fl mmaps list, the allocations > will go away if the audio daemon process is killed bu

Re: [PATCH] dummycon: Trigger redraw when switching consoles with deferred takeover

2025-05-19 Thread Thomas Zimmermann
Am 19.05.25 um 11:04 schrieb Javier Martinez Canillas: Thomas Zimmermann writes: Hello Thomas, Signal vt subsystem to redraw console when switching to dummycon with deferred takeover enabled. Makes the console switch to fbcon and displays the available output. With deferred takeover enabl

[PATCH v16 34/42] dept: make dept stop from working on debug_locks_off()

2025-05-19 Thread Byungchul Park
For many reasons, debug_locks_off() is called to stop lock debuging feature e.g. on panic(). dept should also stop it in the conditions. Signed-off-by: Byungchul Park --- include/linux/dept.h | 2 ++ kernel/dependency/dept.c | 6 ++ lib/debug_locks.c| 2 ++ 3 files changed, 10 i

[PATCH v16 33/42] dept: make dept aware of lockdep_set_lock_cmp_fn() annotation

2025-05-19 Thread Byungchul Park
commit eb1cfd09f788e (lockdep: Add lock_set_cmp_fn() annotation) has been added to address the issue that lockdep was not able to detect a true deadlock like the following: https://lore.kernel.org/lkml/20220510232633.GA18445@X58A-UD3R/ The approach is only for lockdep but dept should work bein

[PATCH v16 31/42] dept: assign dept map to mmu notifier invalidation synchronization

2025-05-19 Thread Byungchul Park
Resolved the following false positive by introducing explicit dept map and annotations for dealing with this case: *** DEADLOCK *** context A [S] (unknown)(:0) [W] lock(&mm->mmap_lock:0) [E] try_to_wake_up(:0) context B [S] lock(&mm->mmap_lock:0) [W] mm

[PATCH v16 32/42] dept: assign unique dept_key to each distinct dma fence caller

2025-05-19 Thread Byungchul Park
dma fence can be used at various points in the code and it's very hard to distinguish dma fences between different usages. Using a single dept_key for all the dma fences could trigger false positive reports. Assign unique dept_key to each distinct dma fence wait to avoid false positive reports.

[PATCH v16 07/42] dept: distinguish each kernel context from another

2025-05-19 Thread Byungchul Park
Each unique kernel context, in dept's point of view, should be identified on every entrance to kernel mode e.g. system call or user oriented fault. Otherwise, dept may track meaningless dependencies across different kernel context. Plus, in order to update kernel context id at the very beginning

[PATCH v16 42/42] dept: call dept_hardirqs_off() in local_irq_*() regardless of irq state

2025-05-19 Thread Byungchul Park
For dept to function properly, dept_task()->hardirqs_enabled must be set correctly. If it fails to set this value to false, for example, dept may mistakenly think irq is still enabled even when it's not. Do dept_hardirqs_off() regardless of irq state not to miss any unexpected cases by any chance

[PATCH v16 02/42] dept: implement DEPT(DEPendency Tracker)

2025-05-19 Thread Byungchul Park
CURRENT STATUS -- lockdep tracks acquisition order of locks in order to detect deadlock, and IRQ and IRQ enable/disable state as well to take accident acquisitions into account. lockdep should be turned off once it detects and reports a deadlock since the data structure and algorithm a

[PATCH v16 20/42] dept: apply timeout consideration to swait

2025-05-19 Thread Byungchul Park
Now that CONFIG_DEPT_AGGRESSIVE_TIMEOUT_WAIT was introduced, apply the consideration to swait, assuming an input 'ret' in ___swait_event() macro is used as a timeout value. Signed-off-by: Byungchul Park --- include/linux/swait.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PATCH v16 06/42] dept: add proc knobs to show stats and dependency graph

2025-05-19 Thread Byungchul Park
It'd be useful to show dept internal stats and dependency graph on runtime via proc for better information. Introduce the knobs. Signed-off-by: Byungchul Park --- kernel/dependency/Makefile| 1 + kernel/dependency/dept.c | 50 +++- kernel/dependency/dept_internal.h

[PATCH v16 16/42] dept: apply sdt_might_sleep_{start, end}() to hashed-waitqueue wait

2025-05-19 Thread Byungchul Park
Make dept able to track dependencies by hashed-waitqueue waits. Signed-off-by: Byungchul Park --- include/linux/wait_bit.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/linux/wait_bit.h b/include/linux/wait_bit.h index 9e29d79fc790..179a616ad245 100644 --- a/include/linux/wait_b

Re: [PATCH v9 02/10] drm/sched: store the drm client_id in drm_sched_fence

2025-05-19 Thread Philipp Stanner
On Mon, 2025-05-19 at 13:02 +0200, Pierre-Eric Pelloux-Prayer wrote: > > > Le 15/05/2025 à 08:53, Pierre-Eric Pelloux-Prayer a écrit : > > Hi, > > > > Le 14/05/2025 à 14:44, Philipp Stanner a écrit : > > > On Thu, 2025-04-24 at 10:38 +0200, Pierre-Eric Pelloux-Prayer > > > wrote: > > > > This wi

RE: [PATCH 2/2] dmabuf/heaps: implement DMA_BUF_IOCTL_RW_FILE for system_heap

2025-05-19 Thread wangtao
> -Original Message- > From: T.J. Mercier > Sent: Saturday, May 17, 2025 2:37 AM > To: Christian König > Cc: wangtao ; sumit.sem...@linaro.org; > benjamin.gaign...@collabora.com; brian.star...@arm.com; > jstu...@google.com; linux-me...@vger.kernel.org; dri- > de...@lists.freedesktop.org

Re: [PATCH v1 3/5] misc: fastrpc: Fix initial memory allocation for Audio PD memory pool

2025-05-19 Thread Srinivas Kandagatla
On 5/13/25 05:28, Ekansh Gupta wrote: > The initially allocated memory is not properly included in the pool, > leading to potential issues with memory management. Set the number > of pages to one to ensure that the initially allocated memory is > correctly added to the Audio PD memory pool. > > Fi

Re: [PATCH v1 3/5] misc: fastrpc: Fix initial memory allocation for Audio PD memory pool

2025-05-19 Thread Ekansh Gupta
On 5/19/2025 3:47 PM, Dmitry Baryshkov wrote: > On Tue, May 13, 2025 at 09:58:23AM +0530, Ekansh Gupta wrote: >> The initially allocated memory is not properly included in the pool, >> leading to potential issues with memory management. Set the number > What is 'properly'? Which issues? inbuf.p

Re: [PATCH v1 4/5] misc: fastrpc: Remove buffer from list prior to unmap operation

2025-05-19 Thread Ekansh Gupta
On 5/19/2025 3:50 PM, Dmitry Baryshkov wrote: > On Tue, May 13, 2025 at 09:58:24AM +0530, Ekansh Gupta wrote: >> fastrpc_req_munmap_impl() is called to unmap any buffer. The buffer is >> getting removed from the list after it is unmapped from DSP. This can >> create potential race conditions if

Re: [PATCH v1 5/5] misc: fastrpc: Add missing unmapping user-requested remote heap

2025-05-19 Thread Dmitry Baryshkov
On Tue, May 13, 2025 at 09:58:25AM +0530, Ekansh Gupta wrote: > User request for remote heap allocation is supported using ioctl > interface but support for unmap is missing. This could result in > memory leak issues. Add unmap user request support for remote heap. Can this memory be in use by the

Re: [PATCH v3] drm/edid: fixed the bug that hdr metadata was not reset

2025-05-19 Thread Jani Nikula
On Wed, 14 May 2025, Jani Nikula wrote: > On Wed, 14 May 2025, "feijuan.li" wrote: >> When DP connected to a device with HDR capability, >> the hdr structure was filled.Then connected to another >> sink device without hdr capability, but the hdr info >> still exist. >> >> Signed-off-by: feijuan.l

Re: [PATCH v4 2/4] drm/panel: Add refcount support

2025-05-19 Thread Jani Nikula
On Fri, 16 May 2025, Anusha Srivatsa wrote: > On Wed, May 14, 2025 at 5:22 AM Jani Nikula > wrote: > >> On Tue, 13 May 2025, Maxime Ripard wrote: >> > Is it really surprising you get some pushback when you are using a >> > design that is the complete opposite to what every user of it for the >>

Re: [PATCH 1/3] drm: Add DRM prime interfaces to reassign GEM handle

2025-05-19 Thread Christian König
On 5/16/25 21:33, David Francis wrote: > CRIU restore of drm buffer objects requires the ability to create > or import a buffer object with a specific gem handle. > > Add new drm ioctl DRM_IOCTL_PRIME_CHANGE_GEM_HANDLE, which takes > the gem handle of an object and moves that object to a > specifi

[PATCH 00/10] Introduce drm sharpness property

2025-05-19 Thread Nemesa Garg
Many a times images are blurred or upscaled content is also not as crisp as original rendered image. Traditional sharpening techniques often apply a uniform level of enhancement across entire image, which sometimes result in over-sharpening of some areas and potential loss of natural detail

[PATCH 03/10] drm/i915/display: Add strength and winsize register

2025-05-19 Thread Nemesa Garg
The sharpness strength value is determined by user input, while the winsize is based on the resolution. The casf_enable flag should be set if the platform supports sharpness adjustments and the user API strength is not zero. Once sharpness is enabled, update the strength bit of the register wheneve

  1   2   3   >