[PATCH] drm/i915/pch: fix warning for coffeelake on SunrisePoint PCH

2025-04-18 Thread Jiajia Liu
i915/pch reports a warning on a mini PC which has a CoffeeLake-S GT2 [UHD Graphics 630] [8086:3e92] and an ISA bridge - H110 LPC Controller [8086:a143]. [3.490423] i915 :00:02.0: [drm] Found coffeelake (device ID 3e92) integrated display version 9.00 stepping N/A [3.507160] [ cut

[PATCH v5 02/10] dt-bindings: display/msm: dsi-controller-main: describe SAR2130P

2025-04-18 Thread Dmitry Baryshkov
From: Dmitry Baryshkov Describe MIPI DSI controller present on Qualcomm SAR2130P platform. Signed-off-by: Dmitry Baryshkov Reviewed-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documen

Re: [PATCH v4] drm/rockchip: Disable AFBC for res >2560 on rk3399

2025-04-18 Thread Daniel Stone
Hi Andy, On Fri, 18 Apr 2025 at 01:16, Andy Yan wrote: > I prefer the V1 version PATCH[0]. This is because we do not deal with > hardware-related > differences at this level. It involves a VOP-related restriction and we > always handle > limitiation like this within the VOP driver . As said

[PATCH v6 2/2] drm/imagination: Add reset controller support for GPU initialization

2025-04-18 Thread Michal Wilczynski
All IMG Rogue GPUs include a reset line that participates in the power-up sequence. On some SoCs (e.g., T-Head TH1520 and Banana Pi BPI-F3), this reset line is exposed and must be driven explicitly to ensure proper initialization. On others, such as the currently supported TI SoC, the reset logic

[PATCH v6 0/2] Add optional reset for the drm/imagination driver

2025-04-18 Thread Michal Wilczynski
| 9 + drivers/gpu/drm/imagination/pvr_power.c| 22 +- 4 files changed, 54 insertions(+), 1 deletion(-) --- base-commit: fc96b232f8e7c0a6c282f47726b2ff6a5fb341d2 change-id: 20250418-apr_18_reset_img-b102988052de Best regards, -- Michal Wilczynski

[PATCH v6 1/2] dt-bindings: gpu: Add 'resets' property for GPU initialization

2025-04-18 Thread Michal Wilczynski
All IMG Rogue GPUs include a reset line that participates in the power-up sequence. On some SoCs (e.g., T-Head TH1520 and Banana Pi BPI-F3), this reset line is exposed and must be driven explicitly to ensure proper initialization. To support this, add a 'resets' property to the GPU device tree bin

[PATCH v5 09/10] iommu/arm-smmu-qcom: Add SAR2130P MDSS compatible

2025-04-18 Thread Dmitry Baryshkov
From: Dmitry Baryshkov Add the SAR2130P compatible to clients compatible list, the device require identity domain. Signed-off-by: Dmitry Baryshkov Reviewed-by: Konrad Dybcio --- drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/iommu/arm/ar

Re:Re: [PATCH v4] drm/rockchip: Disable AFBC for res >2560 on rk3399

2025-04-18 Thread Andy Yan
Hi At 2025-04-18 17:43:19, "Daniel Stone" wrote: >Hi Andy, > >On Fri, 18 Apr 2025 at 01:16, Andy Yan wrote: >> I prefer the V1 version PATCH[0]. This is because we do not deal with >> hardware-related >> differences at this level. It involves a VOP-related restriction and we >> always handl

Re: [PATCH v2 01/15] clk: renesas: rzv2h-cpg: Add support for DSI clocks

2025-04-18 Thread Lad, Prabhakar
Hi Geert, Thank you for the review. On Tue, Apr 15, 2025 at 4:57 PM Geert Uytterhoeven wrote: > > Hi Prabhakar, > > On Tue, 8 Apr 2025 at 22:09, Prabhakar wrote: > > From: Lad Prabhakar > > > > Add support for PLLDSI and PLLDSI divider clocks. > > > > The `renesas-rzv2h-dsi.h` header file is a

Re: [PATCH 5/5] drm/mediatek: Add eDP phy driver for mt8196

2025-04-18 Thread Vinod Koul
On 18-04-25, 14:52, Bincai Liu wrote: > Add code to support eDP phy for mt8196. Why is the patch title not "phy: add eDP phy" why is this tagged drm? > > Signed-off-by: Bincai Liu > --- > drivers/phy/mediatek/Makefile | 1 + > drivers/phy/mediatek/phy-mtk-edp.c | 262 ++

[RFC] drm/sched: Allow drivers to register for pending list cleanup

2025-04-18 Thread Tvrtko Ursulin
Quick sketch idea for an alternative to https://lore.kernel.org/dri-devel/20250407152239.34429-2-pha...@kernel.org/. It is possible it achieves the same effect but with less code and not further growing the internal state machine. The callback it adds is also aligned in spirit (prototype) with oth

Re: [PATCH 1/1] dt-bindings: display: imx: convert fsl,tcon.txt to yaml format

2025-04-18 Thread Stefan Agner
On 2025-04-17 17:11, Frank Li wrote: > Convert fsl,tcon.txt to yaml format. > > Signed-off-by: Frank Li Reviewed-by: Stefan Agner > --- > .../devicetree/bindings/display/fsl,tcon.txt | 17 > .../bindings/display/fsl,vf610-tcon.yaml | 43 +++ > MAINTAINERS

Re: [PATCH v9 4/4] drm/panthor: show device-wide list of DRM GEM objects over DebugFS

2025-04-18 Thread Boris Brezillon
On Fri, 18 Apr 2025 10:11:56 +0200 Boris Brezillon wrote: > On Fri, 18 Apr 2025 03:27:07 +0100 > Adrián Larumbe wrote: > > > + static const char * const gem_state_flags_names[] = { > > + [PANTHOR_DEBUGFS_GEM_STATE_FLAG_IMPORTED] = "imported", FYI, the compiler seems to be happy wit

[PATCH v2] drm/amdgpu: check a user-provided number of BOs in list

2025-04-18 Thread Denis Arefev
The user can set any value to the variable ‘bo_number’, via the ioctl command DRM_IOCTL_AMDGPU_BO_LIST. This will affect the arithmetic expression ‘in->bo_number * in->bo_info_size’, which is prone to overflow. Add a valid value check. Found by Linux Verification Center (linuxtesting.org) with SVA

[PATCH v2] backlight: ktd2801: depend on GPIOLIB

2025-04-18 Thread Duje Mihanović via B4 Relay
From: Duje Mihanović The ExpressWire library used by the driver depends on GPIOLIB, and by extension the driver does as well. This is not reflected in the driver's Kconfig entry, potentially causing Kconfig warnings. Fix this by adding the dependency. Closes: https://lore.kernel.org/all/5cf231e

[PATCH v5 00/10] drm/msm: add support for SAR2130P

2025-04-18 Thread Dmitry Baryshkov
Add support for the Mobile Display SubSystem (MDSS) device present on the Qualcomm SAR2130P platform. The MDSS device is similar to SM8550, it features two MIPI DSI controllers, two MIPI DSI PHYs and one DisplayPort controller. Note, due to the technical limitations DP controller wasn't completely

[PATCH v5 05/10] dt-bindings: display/msm: Add Qualcomm SAR2130P

2025-04-18 Thread Dmitry Baryshkov
From: Dmitry Baryshkov Describe the Mobile Display SubSystem (MDSS) device present on the Qualcomm SAR2130P platform. It looks pretty close to SM8550 on the system level. SAR2130P features two DSI hosts and single DisplayPort controller. Signed-off-by: Dmitry Baryshkov Reviewed-by: Krzysztof Ko

[PATCH v5 06/10] drm/msm/mdss: add SAR2130P device configuration

2025-04-18 Thread Dmitry Baryshkov
From: Dmitry Baryshkov Add compatible and device configuration for the Qualcomm SAR2130P platform. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_mdss.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c

[PATCH v5 01/10] dt-bindings: display/msm: dp-controller: describe SAR2130P

2025-04-18 Thread Dmitry Baryshkov
From: Dmitry Baryshkov Describe DisplayPort controller present on Qualcomm SAR2130P platform. Signed-off-by: Dmitry Baryshkov Reviewed-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/display/msm/dp-controller.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation

[PATCH v5 08/10] drm/msm/dpu: add catalog entry for SAR2130P

2025-04-18 Thread Dmitry Baryshkov
From: Dmitry Baryshkov Add DPU driver support for the Qualcomm SAR2130P platform. It is mostly the same as SM8550, minor differences in the CDP configuration. Signed-off-by: Dmitry Baryshkov --- .../drm/msm/disp/dpu1/catalog/dpu_9_1_sar2130p.h | 434 + drivers/gpu/drm/msm

[PATCH v5 03/10] dt-bindings: display/msm: dsi-phy-7nm: describe SAR2130P

2025-04-18 Thread Dmitry Baryshkov
From: Dmitry Baryshkov Describe MIPI DSI PHY present on Qualcomm SAR2130P platform. Signed-off-by: Dmitry Baryshkov Reviewed-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/

[PATCH v5 04/10] dt-bindings: display/msm: qcom,sc7280-dpu: describe SAR2130P

2025-04-18 Thread Dmitry Baryshkov
From: Dmitry Baryshkov Describe DPU controller present on Qualcomm SAR2130P platform. Signed-off-by: Dmitry Baryshkov Reviewed-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/display/msm/qcom,sc7280-dpu.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devic

[PATCH v5 10/10] arm64: dts: qcom: sar2130p: add display nodes

2025-04-18 Thread Dmitry Baryshkov
From: Dmitry Baryshkov Add display controller, two DSI hosts, two DSI PHYs and a single DP controller. Link DP to the QMP Combo PHY. Signed-off-by: Dmitry Baryshkov Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/sar2130p.dtsi | 395 +++

[PATCH v5 07/10] drm/msm/dsi/phy: add configuration for SAR2130P

2025-04-18 Thread Dmitry Baryshkov
From: Dmitry Baryshkov Qualcomm SAR2130P requires slightly different setup for the DSI PHY. It is a 5nm PHY (like SM8450), so supplies are the same, but the rest of the configuration is the same as SM8550 DSI PHY. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dsi/phy/dsi_phy.c |

Re: [PATCH v9 4/4] drm/panthor: show device-wide list of DRM GEM objects over DebugFS

2025-04-18 Thread Boris Brezillon
On Fri, 18 Apr 2025 03:27:07 +0100 Adrián Larumbe wrote: > +#ifdef CONFIG_DEBUG_FS > +static void > +panthor_gem_debugfs_format_flags(char flags_str[], int flags_len, > + const char * const names[], u32 name_count, > + u32 flags) > +{ > +

Re: [PATCH v2 15/15] drm: renesas: rz-du: mipi_dsi: Add support for RZ/V2H(P) SoC

2025-04-18 Thread Lad, Prabhakar
Hi Biju, Thank you for the review. On Sat, Apr 12, 2025 at 9:01 AM Biju Das wrote: > > Hi Prabhakar, > > Thanks for the patch. > > > -Original Message- > > From: Prabhakar > > Sent: 08 April 2025 21:09 > > Subject: [PATCH v2 15/15] drm: renesas: rz-du: mipi_dsi: Add support for > > RZ/

Re: [PATCH 1/2] drm/ttm: fix the warning for hit_low and evict_low

2025-04-18 Thread Khatri, Sunil
On 4/17/2025 5:01 PM, Tvrtko Ursulin wrote: On 17/04/2025 10:34, Sunil Khatri wrote: fix the below warning messages: ttm/ttm_bo.c:1098: warning: Function parameter or struct member 'hit_low' not described in 'ttm_bo_swapout_walk' ttm/ttm_bo.c:1098: warning: Function parameter or struct membe

Re: [PATCH v2 01/15] clk: renesas: rzv2h-cpg: Add support for DSI clocks

2025-04-18 Thread Lad, Prabhakar
Hi Geert, Thank you for the review. On Wed, Apr 16, 2025 at 10:27 AM Geert Uytterhoeven wrote: > > Hi Prabhakar, Fabrizio, > > Thanks for your patch! > > On Tue, 8 Apr 2025 at 22:09, Prabhakar wrote: > > From: Lad Prabhakar > > > > Add support for PLLDSI and PLLDSI divider clocks. > > > > The

Re: [PATCH v9 4/6] rust: enable `clippy::as_underscore` lint

2025-04-18 Thread Boqun Feng
On Fri, Apr 18, 2025 at 08:08:02AM -0400, Tamir Duberstein wrote: > On Thu, Apr 17, 2025 at 4:12 PM Boqun Feng wrote: > > > > On Thu, Apr 17, 2025 at 03:26:14PM -0400, Tamir Duberstein wrote: > > [...] > > > > > > > > > Ok(()) > > > > > } > > > > > diff --git a/rust/kernel/device_id.

Re: [PATCH v9 4/6] rust: enable `clippy::as_underscore` lint

2025-04-18 Thread Tamir Duberstein
On Fri, Apr 18, 2025 at 11:09 AM Boqun Feng wrote: > > On Fri, Apr 18, 2025 at 08:08:02AM -0400, Tamir Duberstein wrote: > > On Thu, Apr 17, 2025 at 4:12 PM Boqun Feng wrote: > > > > > > On Thu, Apr 17, 2025 at 03:26:14PM -0400, Tamir Duberstein wrote: > > > [...] > > > > > > > > > > > O

Re: [PATCH v2 15/15] drm: renesas: rz-du: mipi_dsi: Add support for RZ/V2H(P) SoC

2025-04-18 Thread Lad, Prabhakar
Hi Geert, Thank you for the review. On Wed, Apr 16, 2025 at 10:35 AM Geert Uytterhoeven wrote: > > Hi Prabhakar, Fabrizio, > > On Tue, 8 Apr 2025 at 22:09, Prabhakar wrote: > > From: Lad Prabhakar > > > > Add DSI support for Renesas RZ/V2H(P) SoC. > > > > Co-developed-by: Fabrizio Castro > >

Re: [PATCH] accel/ivpu: Correct DCT interrupt handling

2025-04-18 Thread Jeff Hugo
On 4/16/2025 4:26 AM, Maciej Falkowski wrote: From: Karol Wachowski Fix improper use of dct_active_percent field in DCT interrupt handler causing DCT to never get enabled. Set dct_active_percent internally before IPC to ensure correct driver value even if IPC fails. Set default DCT value to 30

Re: [PATCH] accel/ivpu: Fix the D0i2 disable test mode

2025-04-18 Thread Jeff Hugo
On 4/16/2025 4:26 AM, Maciej Falkowski wrote: From: Andrzej Kacprowski Correct setup of D0i2 disable which was by mistake set up to value 1 and use BIT(1) instead. Fixes: 011529fe8112 ("accel/ivpu: Implement D0i2 disable test mode") Signed-off-by: Andrzej Kacprowski Signed-off-by: Maciej Falk

[PATCH v10 0/6] rust: reduce `as` casts, enable related lints

2025-04-18 Thread Tamir Duberstein
This started with a patch that enabled `clippy::ptr_as_ptr`. Benno Lossin suggested I also look into `clippy::ptr_cast_constness` and I discovered `clippy::as_ptr_cast_mut`. This series now enables all 3 lints. It also enables `clippy::as_underscore` which ensures other pointer casts weren't missed

[PATCH v10 1/6] rust: enable `clippy::ptr_as_ptr` lint

2025-04-18 Thread Tamir Duberstein
In Rust 1.51.0, Clippy introduced the `ptr_as_ptr` lint [1]: > Though `as` casts between raw pointers are not terrible, > `pointer::cast` is safer because it cannot accidentally change the > pointer's mutability, nor cast the pointer to other types like `usize`. There are a few classes of changes

[PATCH v10 6/6] rust: enable `clippy::ref_as_ptr` lint

2025-04-18 Thread Tamir Duberstein
In Rust 1.78.0, Clippy introduced the `ref_as_ptr` lint [1]: > Using `as` casts may result in silently changing mutability or type. While this doesn't eliminate unchecked `as` conversions, it makes such conversions easier to scrutinize. It also has the slight benefit of removing a degree of free

[PATCH v10 5/6] rust: enable `clippy::cast_lossless` lint

2025-04-18 Thread Tamir Duberstein
Before Rust 1.29.0, Clippy introduced the `cast_lossless` lint [1]: > Rust’s `as` keyword will perform many kinds of conversions, including > silently lossy conversions. Conversion functions such as `i32::from` > will only perform lossless conversions. Using the conversion functions > prevents con

[PATCH v10 3/6] rust: enable `clippy::as_ptr_cast_mut` lint

2025-04-18 Thread Tamir Duberstein
In Rust 1.66.0, Clippy introduced the `as_ptr_cast_mut` lint [1]: > Since `as_ptr` takes a `&self`, the pointer won’t have write > permissions unless interior mutability is used, making it unlikely > that having it as a mutable pointer is correct. There is only one affected callsite, and the chan

[PATCH v10 4/6] rust: enable `clippy::as_underscore` lint

2025-04-18 Thread Tamir Duberstein
In Rust 1.63.0, Clippy introduced the `as_underscore` lint [1]: > The conversion might include lossy conversion or a dangerous cast that > might go undetected due to the type being inferred. > > The lint is allowed by default as using `_` is less wordy than always > specifying the type. Always sp

Re: [PATCH 2/4] bpf: Add dmabuf iterator

2025-04-18 Thread T.J. Mercier
On Thu, Apr 17, 2025 at 1:26 PM Song Liu wrote: > > On Thu, Apr 17, 2025 at 9:05 AM T.J. Mercier wrote: > > > > On Wed, Apr 16, 2025 at 9:56 PM Song Liu wrote: > > > > > > On Wed, Apr 16, 2025 at 7:09 PM T.J. Mercier wrote: > > > > > > > > On Wed, Apr 16, 2025 at 6:26 PM Song Liu wrote: > > >

Re: [PATCH] accel/ivpu: Implement heartbeat-based TDR mechanism

2025-04-18 Thread Jeffrey Hugo
On 4/16/2025 4:25 AM, Maciej Falkowski wrote: From: Karol Wachowski Introduce a heartbeat-based Timeout Detection and Recovery (TDR) mechanism. The enhancement aims to improve the reliability of device hang detection by monitoring heartbeat updates. Each progressing inference will update heart

Re: [PATCH] drm/panic: use `///` for private items too

2025-04-18 Thread Jocelyn Falempe
On 16/04/2025 14:24, Miguel Ojeda wrote: On Wed, Apr 16, 2025 at 2:21 PM Miguel Ojeda wrote: `///` should still be used for private items [1]. Some of the items in this file do so already, so do it for a few other clear candidates in the file. I just pushed it to drm-misc-next Thanks, --

Re: [PATCH v2 3/4] drm/msm/a6xx: Get HBB dynamically, if available

2025-04-18 Thread Akhil P Oommen
On 4/18/2025 6:40 AM, Connor Abbott wrote: > On Thu, Apr 17, 2025, 1:50 PM Akhil P Oommen wrote: >> >> On 4/17/2025 9:02 PM, Connor Abbott wrote: >>> On Thu, Apr 17, 2025 at 3:45 AM Akhil P Oommen >>> wrote: On 4/10/2025 11:13 PM, Konrad Dybcio wrote: > From: Konrad Dybcio > >

[PATCH v6 4/5] drm/amdgpu: change DRM_ERROR to drm_file_err in amdgpu_userqueue.c

2025-04-18 Thread Sunil Khatri
change the DRM_ERROR to drm_file_err to ad process name and pid to the logging. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c | 52 +++ 1 file changed, 29 insertions(+), 23 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c b

[PATCH 2/5] dt-bindings: dvo: mediatek: add dvo yaml for mt8196

2025-04-18 Thread Bincai Liu
Add compatible string to support dvo for MT8196. Signed-off-by: Bincai Liu --- .../devicetree/bindings/display/mediatek/mediatek,dpi.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml b/Documentation/devicetree/bi

Re: [PATCH 4/4] drm/amd/display: Remove unused *vbios_smu_set_dprefclk

2025-04-18 Thread Alex Deucher
Applied patches 1, 3, 4. Thanks! On Thu, Apr 17, 2025 at 8:28 PM wrote: > > From: "Dr. David Alan Gilbert" > > rn_vbios_smu_set_dprefclk() was added in 2019 by > commit 4edb6fc91878 ("drm/amd/display: Add Renoir clock manager") > rv1_vbios_smu_set_dprefclk() was also added in 2019 by > commit d

Re: [PATCH 1/1] dt-bindings: display: imx: convert fsl,dcu.txt to yaml format

2025-04-18 Thread Stefan Agner
On 2025-04-17 17:19, Frank Li wrote: > Convert fsl,dcu.txt to yaml format. > > Additional changes: > - remove label in example. > - change node to display-controller in example. > - use 32bit address in example. > > Signed-off-by: Frank Li Reviewed-by: Stefan Agner > --- > .../devicetree/bin

Re: [PATCH V6 1/5] drm: add drm_file_err function to add process info

2025-04-18 Thread Khatri, Sunil
For rest of the patches which are part of the amdgpu tree will push incorporating changes as shared by @Tvrtko Ursulin once drm change is merged. Thanks a lot all for the reviews. Regards Sunil Khatri On 4/17/2025 6:01 PM, Sunil Khatri wrote: Add a drm helper function which append the proc

[PATCH 0/5] eDP driver for mt8196

2025-04-18 Thread Bincai Liu
Bincai Liu (5): dt-bindings: eDP: mediatek: add eDP yaml for mt8196 dt-bindings: dvo: mediatek: add dvo yaml for mt8196 drm/mediatek: Add dvo driver for mt8196 drm/mediatek: Add eDP driver for mt8196 drm/mediatek: Add eDP phy driver for mt8196 .../display/mediatek/mediatek,dp.yaml

[PATCH 5/5] drm/mediatek: Add eDP phy driver for mt8196

2025-04-18 Thread Bincai Liu
Add code to support eDP phy for mt8196. Signed-off-by: Bincai Liu --- drivers/phy/mediatek/Makefile | 1 + drivers/phy/mediatek/phy-mtk-edp.c | 262 + 2 files changed, 263 insertions(+) create mode 100644 drivers/phy/mediatek/phy-mtk-edp.c diff --git a/driver

[PATCH 3/5] drm/mediatek: Add dvo driver for mt8196

2025-04-18 Thread Bincai Liu
Add code to support dvo for mt8196. Signed-off-by: Bincai Liu --- drivers/gpu/drm/mediatek/mtk_ddp_comp.c | 5 +- drivers/gpu/drm/mediatek/mtk_ddp_comp.h | 1 + drivers/gpu/drm/mediatek/mtk_dpi.c | 240 drivers/gpu/drm/mediatek/mtk_dpi_regs.h | 66 +++ driv

[pull] drm/msm: drm-msm-fixes-2025-04-18 for v6.15-rc3

2025-04-18 Thread Rob Clark
Hi Dave, Simona, A few fixes for v6.15, as described below. The following changes since commit 83ee6d2ec52f1378f3473ee8657d559bebdbda44: dt-bindings: display/msm: dsi-controller-main: Add missing minItems (2025-03-08 03:06:00 +0200) are available in the Git repository at: https://gitlab.fr

[RFC PATCH 1/2] drm/virtio: Freeze and restore hooks to support suspend and resume

2025-04-18 Thread dongwon . kim
From: Dongwon Kim virtio device needs to delete before VM suspend happens then reinitialize all virtqueues again upon resume Cc: Dmitry Osipenko Cc: Vivek Kasireddy Signed-off-by: Dongwon Kim --- drivers/gpu/drm/virtio/virtgpu_drv.c | 53 +++- drivers/gpu/drm/virtio/v

[RFC PATCH 0/2] Virtio-GPU suspend and resume

2025-04-18 Thread dongwon . kim
From: Dongwon Kim This patch series introduces a freeze and restore mechanism for the virtio-gpu driver: First patch adds `virtgpu_freeze` and `virtgpu_restore` functions. These functions handle the deletion of virtio queues before suspension and their recreation during the restoration process.

[RFC PATCH 2/2] drm/virtio: Implement save and restore for virtio_gpu_objects

2025-04-18 Thread dongwon . kim
From: Dongwon Kim Host KVM/QEMU loses all graphics resources submitted by the guest OS upon resumption from sleep or hibernation. This results in invalid resource errors when the guest OS attempts to interact with the host regarding those resources. To address this issue, the virtio-gpu driver n

Re: [PATCH v3] drm/panthor: Don't create a file offset for NO_MMAP BOs

2025-04-18 Thread Adrián Larumbe
On 17.04.2025 14:19, Boris Brezillon wrote: > Right now the DRM_PANTHOR_BO_NO_MMAP flag is ignored by > panthor_ioctl_bo_mmap_offset(), meaning BOs with this flag set can > have a file offset but can't be mapped anyway, because > panthor_gem_mmap() will filter them out. > > If we error out at mmap_

Re: [PATCH 2/4] drm/radeon: Remove unused radeon_doorbell_free

2025-04-18 Thread Alex Deucher
On Fri, Apr 18, 2025 at 2:18 AM Christophe JAILLET wrote: > > Le 18/04/2025 à 02:21, li...@treblig.org a écrit : > > From: "Dr. David Alan Gilbert" > > > > radeon_doorbell_free() was added in 2013 by > > commit 75efdee11b5d ("drm/radeon: implement simple doorbell page > > allocator") > > but neve

Re: [PATCH v2 1/8] drm: drv: implement __drm_dev_alloc()

2025-04-18 Thread Lyude Paul
(JFYI: I really like this and I think I'm going to use this approach in the KMS bindings as well 👀) On Fri, 2025-04-11 at 01:55 +0200, Danilo Krummrich wrote: > In the Rust DRM device abstraction we need to allocate a struct > drm_device. > > Currently, there are two options, the deprecated drm_d

Re: [PATCH v9 4/6] rust: enable `clippy::as_underscore` lint

2025-04-18 Thread Tamir Duberstein
On Thu, Apr 17, 2025 at 4:12 PM Boqun Feng wrote: > > On Thu, Apr 17, 2025 at 03:26:14PM -0400, Tamir Duberstein wrote: > [...] > > > > > > > Ok(()) > > > > } > > > > diff --git a/rust/kernel/device_id.rs b/rust/kernel/device_id.rs > > > > index e5859217a579..4063f09d76d9 100644 > >

[PATCH] drm/doc: Start documenting aspects specific to tile-based renderers

2025-04-18 Thread Boris Brezillon
Tile-based GPUs come with a set of constraints that are not present when immediate rendering is used. This new document tries to explain the differences between tile/immediate rendering, the problems that come with tilers, and how we plan to address them. This is just a started point, this documen

Re: [PATCH v2 02/15] clk: renesas: r9a09g057: Add clock and reset entries for DSI and LCDC

2025-04-18 Thread Lad, Prabhakar
Hi Geert, Thank you for the review. On Tue, Apr 15, 2025 at 4:51 PM Geert Uytterhoeven wrote: > > Hi Prabhakar, > > On Tue, 8 Apr 2025 at 22:09, Prabhakar wrote: > > From: Lad Prabhakar > > > > Add clock and reset entries for the DSI and LCDC peripherals. > > > > Co-developed-by: Fabrizio Cast

RE: [PATCH v2 01/15] clk: renesas: rzv2h-cpg: Add support for DSI clocks

2025-04-18 Thread Fabrizio Castro
Hi Geert, Thanks for your feedback! > From: Geert Uytterhoeven > Sent: 16 April 2025 10:27 > Subject: Re: [PATCH v2 01/15] clk: renesas: rzv2h-cpg: Add support for DSI > clocks > > Hi Prabhakar, Fabrizio, > > Thanks for your patch! > > On Tue, 8 Apr 2025 at 22:09, Prabhakar wrote: > > From:

Re: [PATCH v2 7/8] rust: drm: gem: Add GEM object abstraction

2025-04-18 Thread Danilo Krummrich
On Thu, Apr 17, 2025 at 02:42:24PM -0400, Lyude Paul wrote: > On Fri, 2025-04-11 at 01:55 +0200, Danilo Krummrich wrote: > > +/// A base GEM object. > > +/// > > +/// Invariants > > +/// > > +/// `self.dev` is always a valid pointer to a `struct drm_device`. > > +#[repr(C)] > > +#[pin_data] > > +pu

drm/msm/dp: Introduce link training per-segment for LTTPRs

2025-04-18 Thread Aleksandrs Vinarskis
Recently added Initial LTTPR support in msm/dp has configured LTTPR(s) to non-transparent mode to enable video output on X1E-based devices that come with LTTPR on the motherboards. However, video would not work if additional LTTPR(s) are present between sink and source, which is the case for USB Ty

Re: [PATCH v2 0/8] DRM Rust abstractions

2025-04-18 Thread Lyude Paul
Left a few tiny comments to address before pushing upstream, mostly just style stuff. With those addressed, for the whole series: Reviewed-by: Lyude Paul On Fri, 2025-04-11 at 01:55 +0200, Danilo Krummrich wrote: > This is the series for the initial DRM Rust abstractions, including DRM > devic

[RFC 3/4] drm/sched: Keep module reference while there are active fences

2025-04-18 Thread Tvrtko Ursulin
Continuing the theme from previous patches. This time round we deal with the problem that it is possible to unbind the driver from the PCI device with an active sync file fence. Signed-off-by: Tvrtko Ursulin Cc: Christian König Cc: Danilo Krummrich Cc: Lucas De Marchi Cc: Matthew Brost Cc: Ph

[PATCH V6 2/5] drm/amdgpu: add drm_file reference in userq_mgr

2025-04-18 Thread Sunil Khatri
drm_file will be used in usermode queues code to enable better process information in logging and hence add drm_file part of the userq_mgr struct. update the drm_file pointer in userq_mgr for each amdgpu_driver_open_kms. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c

Re: [PATCH] drm/bridge: select DRM_KMS_HELPER for AUX_BRIDGE

2025-04-18 Thread Dmitry Baryshkov
On Fri, 11 Apr 2025 18:09:40 +0300, Dmitry Baryshkov wrote: > The aux bridge uses devm_drm_of_get_bridge() from the panel bridge (and > correctly selects DRM_PANEL_BRIDGE). However panel bridge is not a > separate module, it is compiled into the drm_kms_helper.o. Select > DRM_KMS_HELPER too to expr

[PATCH v3 1/4] drm/msm/dp: Fix support of LTTPR initialization

2025-04-18 Thread Aleksandrs Vinarskis
Initialize LTTPR before msm_dp_panel_read_sink_caps, as DPTX shall (re)read DPRX caps after LTTPR detection, as required by DP 2.1, Section 3.6.7.6.1. Signed-off-by: Aleksandrs Vinarskis --- drivers/gpu/drm/msm/dp/dp_display.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-)

[PULL] drm-xe-next

2025-04-18 Thread Thomas Hellstrom
Hi Dave, Simona The first drm-xe-next PR towards 6.16 Nothing major worth pointing out, a lot of work and improvents all over the drivers. There is a drm_gpusvm kernel-doc fix that touches core drm. Thanks, Thomas drm-xe-next-2025-04-17: Core Changes: Fix drm_gpusvm kernel-doc (Lucas) Driver Ch

[PATCH v2 1/5] drm/gpusvm: Introduce vram_only flag for VRAM allocation

2025-04-18 Thread Matthew Brost
From: Himal Prasad Ghimiray This commit adds a new flag, vram_only, to the drm_gpusvm structure. The purpose of this flag is to ensure that the get_pages function allocates memory exclusively from the device's VRAM. If the allocation from VRAM fails, the function will return an -EFAULT error. Si

Re: [PATCH v3 2/3] drm/panel: simple: Tianma TM070JDHG34-00: add delays

2025-04-18 Thread Neil Armstrong
On 11/04/2025 21:19, Luca Ceresoli wrote: Add power on/off delays for the Tianma TM070JDHG34-00. Fixes: bf6daaa281f7 ("drm/panel: simple: Add Tianma TM070JDHG34-00 panel support") Cc: sta...@vger.kernel.org Signed-off-by: Luca Ceresoli --- Changed in v3: - add Fixes: and Cc: - remove regulat

[PATCH 1/1] dt-bindings: display: imx: convert fsl, tcon.txt to yaml format

2025-04-18 Thread Frank Li
Convert fsl,tcon.txt to yaml format. Signed-off-by: Frank Li --- .../devicetree/bindings/display/fsl,tcon.txt | 17 .../bindings/display/fsl,vf610-tcon.yaml | 43 +++ MAINTAINERS | 2 +- 3 files changed, 44 insertions(+), 18 delet

[PATCH v2 1/1] dt-bindings: display: imx: convert ldb.txt to yaml format

2025-04-18 Thread Frank Li
Convert ldb.txt to yaml format. Additional changes - fix clock-names order to match existed dts file. - remove lvds-panel and iomuxc-gpr node in examples. - fsl,imx6q-ldb fail back to fsl,imx53-ldb. - add fsl,panel property to match existed dts. Signed-off-by: Frank Li --- change from v1 to v2 -

Re: [PATCH v8 4/4] drm/panthor: show device-wide list of DRM GEM objects over DebugFS

2025-04-18 Thread Adrián Larumbe
Hi Steve, On 17.04.2025 15:25, Steven Price wrote: > On 15/04/2025 20:15, Adrián Larumbe wrote: > > Add a device DebugFS file that displays a complete list of all the DRM > > GEM objects that are exposed to UM through a DRM handle. > > > > Since leaking object identifiers that might belong to a di

[PATCH V8 2/5] drm/amdgpu: add drm_file reference in userq_mgr

2025-04-18 Thread Sunil Khatri
drm_file will be used in usermode queues code to enable better process information in logging and hence add drm_file part of the userq_mgr struct. update the drm_file pointer in userq_mgr for each amdgpu_driver_open_kms. Signed-off-by: Sunil Khatri Reviewed-by: Tvrtko Ursulin --- drivers/gpu/d

Re: [PATCH 1/7] drm/bridge: analogix_dp: drop extra calls to analogix_dp_prepare_panel()

2025-04-18 Thread Neil Armstrong
On 01/04/2025 07:11, Dmitry Baryshkov wrote: The analogix_dp_prepare_panel() returns immediately if there is no attached panel. Drop several calls to this function which are performed when dp->plat_data->panel is NULL. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/bridge/analogix/analog

Re: [PATCH v2 3/8] rust: drm: add driver abstractions

2025-04-18 Thread Lyude Paul
On Fri, 2025-04-11 at 01:55 +0200, Danilo Krummrich wrote: > From: Asahi Lina > > Implement the DRM driver abstractions. > > The `Driver` trait provides the interface to the actual driver to fill > in the driver specific data, such as the `DriverInfo`, driver features > and IOCTLs. > > Reviewed

Re: [PATCH v2 2/8] rust: drm: ioctl: Add DRM ioctl abstraction

2025-04-18 Thread Lyude Paul
Not a review comment (but I should finish reading through this series in just a moment) for On Fri, 2025-04-11 at 01:55 +0200, Danilo Krummrich wrote: > +    // SAFETY: > +    // - The DRM core ensures the device lives while > callbacks are being >

Re: [PATCH v2 5/8] rust: drm: add DRM driver registration

2025-04-18 Thread Lyude Paul
On Fri, 2025-04-11 at 01:55 +0200, Danilo Krummrich wrote: > From: Asahi Lina > > Implement the DRM driver `Registration`. > > The `Registration` structure is responsible to register and unregister a > DRM driver. It makes use of the `Devres` container in order to allow the > `Registration` to b

Re: [PATCH v2 6/8] rust: drm: file: Add File abstraction

2025-04-18 Thread Lyude Paul
On Fri, 2025-04-11 at 01:55 +0200, Danilo Krummrich wrote: > + > +/// The open callback of a `struct drm_file`. > +pub(crate) extern "C" fn open_callback( > +raw_dev: *mut bindings::drm_device, > +raw_file: *mut bindings::drm_file, > +) -> core::ffi::c_int { > +/

[PATCH][next] drm/exynos: Fix spelling mistake "enqueu" -> "enqueue"

2025-04-18 Thread Colin Ian King
There is a spelling mistake in a DRM_DEV_DEBUG_KMS message. Fix it. Signed-off-by: Colin Ian King --- drivers/gpu/drm/exynos/exynos_drm_fimc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimc.c b/drivers/gpu/drm/exynos/exynos_drm_fimc.c

Re: [PATCH] drm/vmgfx: Use non-hybrid PCI devres API

2025-04-18 Thread kernel test robot
6-2-phasta%40kernel.org patch subject: [PATCH] drm/vmgfx: Use non-hybrid PCI devres API config: i386-buildonly-randconfig-001-20250418 (https://download.01.org/0day-ci/archive/20250418/202504182115.mqoln7fu-...@intel.com/config) compiler: clang version 20.1.2 (https://github.com/llvm/ll

Re: [PATCH 0/7] drm/panel: make prepare / enable / disable / unprepare return void

2025-04-18 Thread Neil Armstrong
On 01/04/2025 07:11, Dmitry Baryshkov wrote: While it makes sense for panel callbacks to be able to return an error, the state-management functions from drm_panel API are usually called from atomic callbacks, which can not fails and must return void. Make drm_panel_prepare(), drm_panel_enable(),

Re: [PATCH AUTOSEL 5.10 8/8] fbdev: omapfb: Add 'plane' value check

2025-04-18 Thread Pavel Machek
Hi! > Function dispc_ovl_setup is not intended to work with the value OMAP_DSS_WB > of the enum parameter plane. > > The value of this parameter is initialized in dss_init_overlays and in the > current state of the code it cannot take this value so it's not a real > problem. > > For the purposes

[PATCH v4 02/11] dt-bindings: msm: dsi-controller-main: document the SA8775P DSI CTRL

2025-04-18 Thread Ayushi Makhija
From: Ayushi Makhija Document the DSI CTRL on the SA8775P Platform. Signed-off-by: Ayushi Makhija Reviewed-by: Krzysztof Kozlowski --- .../devicetree/bindings/display/msm/dsi-controller-main.yaml| 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/displ

Re: [PATCH v9 4/4] drm/panthor: show device-wide list of DRM GEM objects over DebugFS

2025-04-18 Thread Boris Brezillon
On Fri, 18 Apr 2025 03:27:07 +0100 Adrián Larumbe wrote: > + static const char * const gem_state_flags_names[] = { > + [PANTHOR_DEBUGFS_GEM_STATE_FLAG_IMPORTED] = "imported", > + [PANTHOR_DEBUGFS_GEM_STATE_FLAG_EXPORTED] = "exported", Okay, I think I know where the fl

[RFC 2/4] dma-fence: Slightly safer dma_fence_set_deadline

2025-04-18 Thread Tvrtko Ursulin
Similar to the previous patch lets precede the fence->ops dereference with the signaled check. This reduces the window to hit the race where sync file can get into a signaled DRM scheduler fence which was left "dangling" after the driver had potentially torn down the corresponding internal state.

Re: [PATCH v1] drm/sched: fix the warning in drm_sched_job_done

2025-04-18 Thread Khatri, Sunil
On 4/17/2025 3:51 PM, Tvrtko Ursulin wrote: On 17/04/2025 11:01, Sunil Khatri wrote: Fix the below warning. scheduler/sched_main.c:397: warning: Function parameter or struct member 'result' not described in 'drm_sched_job_done' Reviewed-by: Tvrtko Ursulin Signed-off-by: Sunil Khatri ---

[RFC 4/4] drm/xe: Keep module reference while there are active fences

2025-04-18 Thread Tvrtko Ursulin
Continuing the theme from previous patches. This time round we deal with the problem that it is possible to unbind the driver from the PCI device with an active sync file fence. Signed-off-by: Tvrtko Ursulin Cc: Christian König Cc: Danilo Krummrich Cc: Lucas De Marchi Cc: Matthew Brost Cc: Ph

[PATCH v9 1/4] drm/panthor: Introduce BO labeling

2025-04-18 Thread Adrián Larumbe
Add a new character string Panthor BO field, and a function that allows setting it from within the driver. Driver takes care of freeing the string when it's replaced or no longer needed at object destruction time, but allocating it is the responsibility of callers. Signed-off-by: Adrián Larumbe

[RFC 0/4] Some (drm_sched_|dma_)fence lifetime issues

2025-04-18 Thread Tvrtko Ursulin
Hi all, Recently I mentioned to Danilo about some fence lifetime issues so here is a rough series, more than anything intended to start the discussion. Most of the problem statement can be found in the first patch but to briefly summarise - because sched fence can outlive the scheduler, we can tr

Re: [PATCH] drm/mgag200: Fix value in register

2025-04-18 Thread Wakko Warner
Thomas Zimmermann wrote: > Hi > > Am 16.04.25 um 17:22 schrieb Wakko Warner: > > Thomas Zimmermann wrote: > > > Fix an off-by-one error when setting the vblanking start in > > > . Commit d6460bd52c27 ("drm/mgag200: Add dedicated > > > variables for blanking fields") switched the value from > > > c

[RFC 1/4] sync_file: Weakly paper over one use-after-free resulting race

2025-04-18 Thread Tvrtko Ursulin
Xe and probably some other drivers can tear down the internal state referenced by exported sync file fence which then causes a null pointer derefences on accessing said fence. This is somewhat related to DRM scheduler design where sched fence is supposed to be allowed to outlive the scheduler inst

Re: [PATCH v9 4/4] drm/panthor: show device-wide list of DRM GEM objects over DebugFS

2025-04-18 Thread Adrián Larumbe
Hi Boris, On 18.04.2025 10:04, Boris Brezillon wrote: > On Fri, 18 Apr 2025 03:27:07 +0100 > Adrián Larumbe wrote: > > > +#ifdef CONFIG_DEBUG_FS > > +static void > > +panthor_gem_debugfs_format_flags(char flags_str[], int flags_len, > > +const char * const names[], u32

Re: [PATCH v9 4/4] drm/panthor: show device-wide list of DRM GEM objects over DebugFS

2025-04-18 Thread Adrián Larumbe
On 18.04.2025 10:26, Boris Brezillon wrote: On Fri, 18 Apr 2025 10:11:56 +0200 Boris Brezillon wrote: > On Fri, 18 Apr 2025 03:27:07 +0100 > Adrián Larumbe wrote: > > > + static const char * const gem_state_flags_names[] = { > > + [PANTHOR_DEBUGFS_GEM_STATE_FLAG_IMPORTED] = "imported

[PATCH v3 3/4] scripts/kernel-doc.py: don't create *.pyc files

2025-04-18 Thread Mauro Carvalho Chehab
As reported by Andy, kernel-doc.py is creating a __pycache__ directory at build time. Disable creation of __pycache__ for the libraries used by kernel-doc.py, when excecuted via the build system or via scripts/find-unused-docs.sh. Reported-by: Andy Shevchenko Closes: https://lore.kernel.org/linu

[PATCH v3 0/4] Don't create Python bytecode when building the kernel

2025-04-18 Thread Mauro Carvalho Chehab
As reported by Andy, the Kernel build system runs kernel-doc script for DRM, when W=1. Due to Python's normal behavior, its JIT compiler will create a bytecode and store it under scripts/lib/*/__pycache__. As one may be using O= and even having the sources on a read-only mount point, disable its c

Re: [PATCH v3 1/2] scripts/kernel-doc.py: don't create *.pyc files

2025-04-18 Thread Mauro Carvalho Chehab
Hi Andy, Em Wed, 16 Apr 2025 12:41:29 +0300 Andy Shevchenko escreveu: > On Wed, Apr 16, 2025 at 05:38:11PM +0800, Mauro Carvalho Chehab wrote: > > Em Wed, 16 Apr 2025 17:29:01 +0800 > > Mauro Carvalho Chehab escreveu: > > ... > > > Heh, trying to quickly write a patch before calling it a da

[PATCH 0/2] Transition remaining mipi_dsi_dcs_write_seq commands and remove it

2025-04-18 Thread Tejas Vipin
panel-samsung-sofef00 is the last remaining user of mipi_dsi_dcs_write_seq, so mipi_dsi_dcs_write_seq can be removed after the panel has been changed to use mipi_dsi_*_multi functions. Tejas Vipin (2): drm/panel: panel-samsung-sofef00: transition to mipi_dsi wrapped functions drm/mipi-dsi:

  1   2   >