Re: [PATCH v3 1/2] drm/panthor: Add 64-bit and poll register accessors

2025-04-15 Thread Liviu Dudau
On Mon, Apr 14, 2025 at 11:41:19AM +0100, Steven Price wrote: > Hi Karunika, > > Minor process thing: There's generally no need to resend a series just > to add R-b tags - they'll get picked up when the series is merged. > > On 11/04/2025 17:48, Karunika Choo wrote: > > This patch adds 64-bit reg

[PATCH v2 4/4] drm/amdgpu: change DRM_ERROR to drm_err in amdgpu_userqueue.c

2025-04-15 Thread Sunil Khatri
change the DRM_ERROR to drm_err which gives the drm device information too which is useful in case of multiple GPU's. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c | 75 ++- 1 file changed, 41 insertions(+), 34 deletions(-) diff --git a/drivers/gp

[PATCH v2 2/4] drm/amdgpu: add drm_file reference in userq_mgr

2025-04-15 Thread Sunil Khatri
drm_file will be used in usermode queues code to enable better process information in logging and hence add drm_file part of the userq_mgr struct. update the drm_file pointer in userq_mgr for each amdgpu_driver_open_kms. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c

[PATCH v9 21/23] drm/mediatek: mtk_hdmi_common: Add var to enable interlaced modes

2025-04-15 Thread AngeloGioacchino Del Regno
Add an interlace_allowed bool member to struct mtk_hdmi_ver_conf which will be used to signal whether interlaced modes are supported by the bridge (in our case, the HDMI IP), and enable it for HDMIv2. Reviewed-by: CK Hu Signed-off-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/mediatek/mtk

Re: [PATCH v2] drm/amd/pm/powerplay/smumgr/fiji_smumgr: Add error check in fiji_populate_smc_boot_level()

2025-04-15 Thread Markus Elfring
> The return value of fiji_populate_smc_boot_level() is needs to be checked. should? > An error handling is also needed to phm_find_boot_level() to reset the > boot level when the function fails. A proper implementation can be found > in tonga

[PATCH] drm/amd/pm/powerplay/smumgr/vegam_smumgr: Fix error handling in vegam_populate_smc_boot_level()

2025-04-15 Thread Wentao Liang
In vegam_populate_smc_boot_level(), the return value of phm_find_boot_level() is 0 or negative error code and the "if (result)" branch statement will never run into the true branch. Besides, this will skip setting the voltages later below. Returning early may break working devices. Add an error ha

Re: [PATCH v4 05/16] drm/vkms: Allow to configure multiple CRTCs via configfs

2025-04-15 Thread Louis Chauvet
Le 07/04/2025 à 10:14, José Expósito a écrit : From: Louis Chauvet Create a default subgroup at /config/vkms/crtcs to allow to create as many CRTCs as required. Reviewed-by: Louis Chauvet Signed-off-by: Louis Chauvet Co-developed-by: José Expósito Signed-off-by: José Expósito --- D

Re: [PATCH v7 1/2] drm/bridge: documentat bridge allocation and lifecycle

2025-04-15 Thread Luca Ceresoli
On Mon, 14 Apr 2025 17:40:46 +0200 Maxime Ripard wrote: > Hi, > > On Wed, Apr 09, 2025 at 04:50:34PM +0200, Luca Ceresoli wrote: > > Document in detail the DRM bridge allocation and refcounting process based > > on the recently introduced devm_drm_bridge_alloc(). > > > > Signed-off-by: Luca Cer

Re: [PATCH v7 2/2] drm/tests: bridge: add a KUnit test for devm_drm_bridge_alloc()

2025-04-15 Thread Luca Ceresoli
Hi Maxime, thanks for the careful review. On Mon, 14 Apr 2025 17:49:16 +0200 Maxime Ripard wrote: > Hi, > > On Wed, Apr 09, 2025 at 04:50:35PM +0200, Luca Ceresoli wrote: > > Add a basic KUnit test for the newly introduced drm_bridge_alloc(). > > > > Signed-off-by: Luca Ceresoli > > > > ---

[PATCH v9 02/23] dt-bindings: display: mediatek: Add binding for MT8195 HDMI-TX v2

2025-04-15 Thread AngeloGioacchino Del Regno
Add a binding for the HDMI TX v2 Encoder found in MediaTek MT8195 and MT8188 SoCs. This fully supports the HDMI Specification 2.0b, hence it provides support for 3D-HDMI, Polarity inversion, up to 16 bits Deep Color, color spaces including RGB444, YCBCR420/422/444 (ITU601/ITU709) and xvYCC, with o

Re: [PATCH 02/10] panel/arm-versatile: Use the refcounted allocation in place of devm_kzalloc()

2025-04-15 Thread Linus Walleij
On Tue, Apr 1, 2025 at 7:05 PM Anusha Srivatsa wrote: > Move to using the new API devm_drm_panel_alloc() to allocate the > panel. > > Signed-off-by: Anusha Srivatsa Acked-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH v2 1/4] drm: function to get process name and pid

2025-04-15 Thread Tvrtko Ursulin
On 15/04/2025 12:25, Sunil Khatri wrote: Add helper function which get the process information for the drm_file and updates the user provided character buffer with the information of process name and pid as a string. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/drm_file.c | 34 ++

Re: [PATCH v3 19/54] dyndbg: detect class_id reservation conflicts

2025-04-15 Thread Louis Chauvet
Le 02/04/2025 à 19:41, Jim Cromie a écrit : If a module _DEFINEs + _USEs 2 or more classmaps, it must devise them to share the per-module 0..62 class-id space; ie their respective base,+length reservations cannot overlap. To detect conflicts at modprobe, add ddebug_class_range_overlap(), call

Re: [PATCH v4 06/16] drm/vkms: Allow to configure CRTC writeback support via configfs

2025-04-15 Thread Louis Chauvet
Le 07/04/2025 à 10:14, José Expósito a écrit : From: Louis Chauvet When a CRTC is created, add a `writeback` file to allow to enable or disable writeback connector support Reviewed-by: Louis Chauvet Signed-off-by: Louis Chauvet Co-developed-by: José Expósito Signed-off-by: José Expósi

Re: [PATCH] drm/gem: Internally test import_attach for imported objects

2025-04-15 Thread Christian König
Am 15.04.25 um 12:45 schrieb Thomas Zimmermann: > Hi > > Am 15.04.25 um 11:39 schrieb Christian König: >> Am 15.04.25 um 11:20 schrieb Thomas Zimmermann: >>> Test struct drm_gem_object.import_attach to detect imported objects >>> during cleanup. At that point, the imported DMA buffer might have >>>

[PATCH v2 2/2] drm/nouveau: nouveau_fence: Standardize list iterations

2025-04-15 Thread Philipp Stanner
nouveau_fence.c iterates over lists in a non-canonical way. Since the operations done are just basic for-each-loops, they should be written in the standard form. Use for_each_safe() instead of the custom loop iterations. Signed-off-by: Philipp Stanner --- drivers/gpu/drm/nouveau/nouveau_fence.c

Re: [PATCH] drm/gem: Internally test import_attach for imported objects

2025-04-15 Thread Christian König
Am 15.04.25 um 14:40 schrieb Thomas Zimmermann: > Hi > > Am 15.04.25 um 14:19 schrieb Christian König: >> Am 15.04.25 um 12:45 schrieb Thomas Zimmermann: >>> Hi >>> >>> Am 15.04.25 um 11:39 schrieb Christian König: Am 15.04.25 um 11:20 schrieb Thomas Zimmermann: > Test struct drm_gem_objec

Re: [PATCH v4 1/8] driver core: auxiliary bus: add device creation helpers

2025-04-15 Thread Jerome Brunet
On Wed 19 Feb 2025 at 15:20, Greg Kroah-Hartman wrote: > On Tue, Feb 18, 2025 at 08:29:46PM +0100, Jerome Brunet wrote: >> Add helper functions to create a device on the auxiliary bus. >> >> This is meant for fairly simple usage of the auxiliary bus, to avoid having >> the same code repeated in

Re: [PATCH v4 16/16] drm/vkms: Allow to configure connector status via configfs

2025-04-15 Thread Louis Chauvet
Le 07/04/2025 à 10:14, José Expósito a écrit : When a connector is created, add a `status` file to allow to update the connector status to: - 1 connector_status_connected - 2 connector_status_disconnected - 3 connector_status_unknown If the device is enabled, updating the status hot-pl

[PATCH v2 0/3] Rework/Correction on minimum hblank calculation

2025-04-15 Thread Arun R Murthy
Signed-off-by: Arun R Murthy --- Changes in v2: - EDITME: describe what is new in this series revision. - EDITME: use bulletpoints and terse descriptions. - Link to v1: https://lore.kernel.org/r/20250408-hblank-v1-0-4ba17aebe...@intel.com --- Arun R Murthy (3): drm/display/dp: Export fn to

Re: [PATCH 1/3] drm/nouveau: Prevent signaled fences in pending list

2025-04-15 Thread Philipp Stanner
On Tue, 2025-04-15 at 11:56 +0200, Christian König wrote: > Am 14.04.25 um 16:27 schrieb Danilo Krummrich: > > On Mon, Apr 14, 2025 at 10:54:25AM +0200, Philipp Stanner wrote: > > > @Danilo: > > > We have now 2 possible solutions for the firing WARN_ON floating. > > > > > > Version A (Christian) >

Re: [PATCH] drm/gem: Internally test import_attach for imported objects

2025-04-15 Thread Thomas Zimmermann
Hi Am 15.04.25 um 14:19 schrieb Christian König: Am 15.04.25 um 12:45 schrieb Thomas Zimmermann: Hi Am 15.04.25 um 11:39 schrieb Christian König: Am 15.04.25 um 11:20 schrieb Thomas Zimmermann: Test struct drm_gem_object.import_attach to detect imported objects during cleanup. At that point,

Re: [PATCH v2 3/3] drm/i915/display: move min_hblank from dp_mst.c to dp.c

2025-04-15 Thread Imre Deak
On Tue, Apr 15, 2025 at 01:25:09PM +0530, Arun R Murthy wrote: > Minimum HBlank is programmed to address jitter for high resolutions with > high refresh rates that have small Hblank, specifically where Hblank is > smaller than one MTP. > > TODO: Add the min_hblank calculation for hdmi as well. >

[PATCH v9 08/23] drm/mediatek: mtk_hdmi: Disgregate function mtk_hdmi_audio_set_param()

2025-04-15 Thread AngeloGioacchino Del Regno
As a cleanup, and in preparation for splitting common bits of this driver, disgregate the code in function mtk_hdmi_audio_set_param() to the beginning and end of function mtk_hdmi_audio_hw_params(). In a later commit, the hw_params callback function will also be disgregated so that the code will g

Re: [PATCH v4 08/16] drm/vkms: Allow to configure multiple encoders via configfs

2025-04-15 Thread Louis Chauvet
Le 07/04/2025 à 10:14, José Expósito a écrit : From: Louis Chauvet Create a default subgroup at /config/vkms/encoders to allow to create as many encoders as required. Reviewed-by: Louis Chauvet Signed-off-by: Louis Chauvet Co-developed-by: José Expósito Signed-off-by: José Expósito -

Re: [PATCH v4 09/16] drm/vkms: Allow to attach encoders and CRTCs via configfs

2025-04-15 Thread Louis Chauvet
Le 07/04/2025 à 10:14, José Expósito a écrit : From: Louis Chauvet Create a default subgroup at /config/vkms/encoders/encoder/possible_crtcs that will contain symbolic links to the possible CRTCs for the encoder. Reviewed-by: Louis Chauvet Signed-off-by: Louis Chauvet Co-developed-by:

Re: [PATCH v4 07/16] drm/vkms: Allow to attach planes and CRTCs via configfs

2025-04-15 Thread Louis Chauvet
Le 07/04/2025 à 10:14, José Expósito a écrit : From: Louis Chauvet Create a default subgroup at /config/vkms/planes/plane/possible_crtcs that will contain symbolic links to the possible CRTCs for the plane. Reviewed-by: Louis Chauvet Signed-off-by: Louis Chauvet Co-developed-by: José E

Re: [PATCH v4 11/16] drm/vkms: Allow to attach connectors and encoders via configfs

2025-04-15 Thread Louis Chauvet
Le 07/04/2025 à 10:14, José Expósito a écrit : From: Louis Chauvet Create a default subgroup at /config/vkms/connectors/connector/possible_encoders that will contain symbolic links to the possible encoders for the connector. Reviewed-by: Louis Chauvet Signed-off-by: Louis Chauvet Co-de

Re: [PATCH v2 1/4] drm: function to get process name and pid

2025-04-15 Thread Christian König
Am 15.04.25 um 13:25 schrieb Sunil Khatri: > Add helper function which get the process information for > the drm_file and updates the user provided character buffer > with the information of process name and pid as a string. > > Signed-off-by: Sunil Khatri > --- > drivers/gpu/drm/drm_file.c | 34

Re: [PATCH v2 2/2] drm/nouveau: nouveau_fence: Standardize list iterations

2025-04-15 Thread Christian König
Am 15.04.25 um 14:19 schrieb Philipp Stanner: > nouveau_fence.c iterates over lists in a non-canonical way. Since the > operations done are just basic for-each-loops, they should be written in > the standard form. > > Use for_each_safe() instead of the custom loop iterations. > > Signed-off-by: Phi

Re: [PATCH v2 1/4] drm: function to get process name and pid

2025-04-15 Thread Christian König
Am 15.04.25 um 13:40 schrieb Tvrtko Ursulin: > > On 15/04/2025 12:25, Sunil Khatri wrote: >> Add helper function which get the process information for >> the drm_file and updates the user provided character buffer >> with the information of process name and pid as a string. >> >> Signed-off-by: Sun

Re: [PATCH v4 09/16] drm/vkms: Allow to attach encoders and CRTCs via configfs

2025-04-15 Thread Louis Chauvet
Le 07/04/2025 à 10:14, José Expósito a écrit : From: Louis Chauvet Create a default subgroup at /config/vkms/encoders/encoder/possible_crtcs that will contain symbolic links to the possible CRTCs for the encoder. Reviewed-by: Louis Chauvet Signed-off-by: Louis Chauvet Co-developed-by:

Re: [PATCH v4 10/16] drm/vkms: Allow to configure multiple connectors via configfs

2025-04-15 Thread Louis Chauvet
Le 07/04/2025 à 10:14, José Expósito a écrit : From: Louis Chauvet Create a default subgroup at /config/vkms/connectors to allow to create as many connectors as required. Reviewed-by: Louis Chauvet Signed-off-by: Louis Chauvet Co-developed-by: José Expósito Signed-off-by: José Expósit

Re: [PATCH v3 0/8] drm: Introduce sparse GEM shmem

2025-04-15 Thread Daniel Stone
Hi, On Mon, 14 Apr 2025 at 16:34, Steven Price wrote: > On 14/04/2025 13:47, Boris Brezillon wrote: > > Hm, I might have been too prompt at claiming this was doable. In > > practice, doing that might regress Lima and Panfrost in situations > > where trying harder than GFP_NOWAIT would free up som

Re: [PATCH DO NOT MERGE v6 17/18] arm64: dts: ti: k3-am62: New GPU binding details

2025-04-15 Thread Matt Coster
On 10/04/2025 10:55, Matt Coster wrote: > Use the new compatible string introduced earlier (in "dt-bindings: gpu: > img: More explicit compatible strings") and add a name to the single power > domain for this GPU (introduced in "dt-bindings: gpu: img: Power domain > details"). Hi Nishanth, Vignesh

[PATCH v9 07/23] drm/mediatek: hdmi: Use regmap instead of iomem for main registers

2025-04-15 Thread AngeloGioacchino Del Regno
From: Guillaume Ranquet In preparation for the addition of a new version of the HDMI IP which will need to share its iospace between multiple subdrivers, and in preparation for moving out the common bits between the two, migrate this driver to fully use regmap. Signed-off-by: Guillaume Ranquet

[PATCH v2 1/4] drm: function to get process name and pid

2025-04-15 Thread Sunil Khatri
Add helper function which get the process information for the drm_file and updates the user provided character buffer with the information of process name and pid as a string. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/drm_file.c | 34 ++ include/drm/drm_file

[PATCH v2 3/4] drm/amdgpu: update the error logging for more information

2025-04-15 Thread Sunil Khatri
add process and pid information in the userqueue error logging to make it more useful in resolving the error by logs. Sample log: [ 42.444297] [drm:amdgpu_userqueue_wait_for_signal [amdgpu]] *ERROR* Timed out waiting for fence f=1c74d978 for comm:Xwayland pid:3427 [ 42.444669] [drm:am

Re: [PATCH v4 14/16] drm/vkms: Allow to configure connector status

2025-04-15 Thread Louis Chauvet
Le 07/04/2025 à 10:14, José Expósito a écrit : Allow to store the connector status in vkms_config_connector and add a getter and a setter functions as well a KUnit test. This change only adds the configuration, the connector status is not used yet. Signed-off-by: José Expósito Reviewed-by

Re: [PATCH v4 15/16] drm/vkms: Allow to update the connector status

2025-04-15 Thread Louis Chauvet
Le 07/04/2025 à 10:14, José Expósito a écrit : Implement the drm_connector_funcs.detect() callback to update the connector status by returning the status stored in the configuration. Signed-off-by: José Expósito Reviewed-by: Louis Chauvet --- drivers/gpu/drm/vkms/vkms_connector.c | 28

Re: [PATCH v1 4/4] misc: fastrpc: Add debugfs support for fastrpc

2025-04-15 Thread Greg KH
On Mon, Apr 14, 2025 at 12:41:47PM +0530, Deepika Singh wrote: > > > On 4/11/2025 1:55 PM, Ekansh Gupta wrote: > > > > > > On 12/3/2024 5:27 PM, Dmitry Baryshkov wrote: > > > On Tue, 3 Dec 2024 at 07:22, Ekansh Gupta > > > wrote: > > > > > > > > > > > > On 12/2/2024 6:18 PM, Dmitry Baryshko

Re: [PATCH v3 09/17] drm/bridge: cdns-dsi: Drop checks that shouldn't be in .mode_valid()

2025-04-15 Thread Aradhya Bhatia
On 14/04/25 16:41, Tomi Valkeinen wrote: > The docs say about mode_valid(): > > "it is not allowed to look at anything else but the passed-in mode, and > validate it against configuration-invariant hardware constraints" > > We're doing a lot more than just looking at the mode. The main issue >

Re: [PATCH v4 1/8] driver core: auxiliary bus: add device creation helpers

2025-04-15 Thread Jerome Brunet
On Tue 15 Apr 2025 at 14:59, Greg Kroah-Hartman wrote: > On Tue, Apr 15, 2025 at 02:52:47PM +0200, Jerome Brunet wrote: >> On Wed 19 Feb 2025 at 15:20, Greg Kroah-Hartman >> wrote: >> >> > On Tue, Feb 18, 2025 at 08:29:46PM +0100, Jerome Brunet wrote: >> >> Add helper functions to create a de

Re: [PATCH] drm/gem: Internally test import_attach for imported objects

2025-04-15 Thread Boris Brezillon
On Tue, 15 Apr 2025 14:19:20 +0200 Christian König wrote: > Am 15.04.25 um 12:45 schrieb Thomas Zimmermann: > > Hi > > > > Am 15.04.25 um 11:39 schrieb Christian König: > >> Am 15.04.25 um 11:20 schrieb Thomas Zimmermann: > >>> Test struct drm_gem_object.import_attach to detect imported > >>>

Re: [PATCH v3 02/17] drm/tidss: Use the crtc_* timings when programming the HW

2025-04-15 Thread Aradhya Bhatia
Hi Tomi, Thank you for the patches! On 14/04/25 16:41, Tomi Valkeinen wrote: > Use the crtc_* fields from drm_display_mode, instead of the "logical" > fields. This shouldn't change anything in practice, but afaiu the crtc_* > fields are the correct ones to use here. > > Signed-off-by: Tomi Valke

Re: [PATCH v3 06/17] drm/bridge: cdns-dsi: Remove extra line at the end of the file

2025-04-15 Thread Aradhya Bhatia
Hi, On 14/04/25 16:41, Tomi Valkeinen wrote: > Remove extra line at the end of the file. > > Signed-off-by: Tomi Valkeinen > --- > drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c | 1 - > 1 file changed, 1 deletion(-) Reviewed-by: Aradhya Bhatia -- Regards Aradhya

[PATCH v3 09/10] iommu/arm-smmu-qcom: Add SAR2130P MDSS compatible

2025-04-15 Thread Dmitry Baryshkov
From: Dmitry Baryshkov Add the SAR2130P compatible to clients compatible list, the device require identity domain. Signed-off-by: Dmitry Baryshkov --- drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c b/dr

Re: [PATCH v3 10/17] drm/bridge: cdns-dsi: Update htotal in cdns_dsi_mode2cfg()

2025-04-15 Thread Aradhya Bhatia
On 14/04/25 16:41, Tomi Valkeinen wrote: > cdns_dsi_mode2cfg() calculates the dsi timings, but for some reason > doesn't set the htotal based on those timings. It is set only later, in > cdns_dsi_adjust_phy_config(). > > As cdns_dsi_mode2cfg() is the logical place to calculate it, let's move >

[PATCH v18 2/8] drm/vkms: Add YUV support

2025-04-15 Thread Louis Chauvet
From: Arthur Grillo Add support to the YUV formats bellow: - NV12/NV16/NV24 - NV21/NV61/NV42 - YUV420/YUV422/YUV444 - YVU420/YVU422/YVU444 The conversion from yuv to rgb is done with fixed-point arithmetic, using 32.32 fixed-point numbers and the drm_fixed helpers. To do the conversion, a spec

[PATCH v18 8/8] drm/vkms: Add support for DRM_FORMAT_R*

2025-04-15 Thread Louis Chauvet
This add the support for: - R1/R2/R4/R8 R1 format was tested with [1] and [2]. [1]: https://lore.kernel.org/r/20240313-new_rotation-v2-0-6230fd5ca...@bootlin.com [2]: https://lore.kernel.org/igt-dev/20240306-b4-kms_tests-v1-0-8fe451efd...@bootlin.com/ Reviewed-by: Pekka Paalanen Signed-off-by

[PATCH v18 4/8] drm/vkms: Drop YUV formats TODO

2025-04-15 Thread Louis Chauvet
From: Arthur Grillo VKMS has support for YUV formats now. Remove the task from the TODO list. Signed-off-by: Arthur Grillo Acked-by: Pekka Paalanen Signed-off-by: Louis Chauvet --- Documentation/gpu/vkms.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentatio

[PATCH v18 5/8] drm: Export symbols to use in tests

2025-04-15 Thread Louis Chauvet
The functions drm_get_color_encoding_name and drm_get_color_range_name are useful for clarifying test results. Therefore, export them so they can be used in tests built as modules. Reviewed-by: José Expósito Signed-off-by: Louis Chauvet --- drivers/gpu/drm/drm_color_mgmt.c | 3 +++ 1 file chang

Re: [PATCH] drm/gem: Internally test import_attach for imported objects

2025-04-15 Thread Christian König
Am 15.04.25 um 15:10 schrieb Simona Vetter: >> This is for devices who only want to do a vmap of the buffer, isn't it? > ... it's for the vmap only case, where you might not even have a struct > device. Or definitely not a reasonable one, like maybe a faux_bus device > or some device on a bus that

Re: [PATCH] drm/gem: Internally test import_attach for imported objects

2025-04-15 Thread Christian König
Am 15.04.25 um 15:14 schrieb Thomas Zimmermann: >> >>> The long-term goal is to make import_attach optional because its setup >>> requires a DMA-capable device. >> HUI WHAT? >> >> Dmitry and I put quite some effort into being able to create an >> import_attach without the requirement to have a DM

[PATCH v2 3/3] drm/i915/display: move min_hblank from dp_mst.c to dp.c

2025-04-15 Thread Arun R Murthy
Minimum HBlank is programmed to address jitter for high resolutions with high refresh rates that have small Hblank, specifically where Hblank is smaller than one MTP. TODO: Add the min_hblank calculation for hdmi as well. v2: move from intel_audio.c to intel_dp.c some correction in link_bpp_x

[PATCH v2 0/2] drm/nouveau: Don't set signaled fences' error codes

2025-04-15 Thread Philipp Stanner
Changes in v2: - Only fix the issue by checking for a fence being signaled in nouveau_fence_context_kill(), before setting the fence's error. (Christian, Danilo) - Drop cleanup patches. Instead, idiomaticize for-each-loops. Was called "Fix & improve nouveau_fence_done()" before. I've

Re: [PATCH v2] virtgpu: don't reset on shutdown

2025-04-15 Thread Michael S. Tsirkin
On Tue, Apr 15, 2025 at 01:16:32PM +0200, Gerd Hoffmann wrote: > Hi, > > > +static void virtio_gpu_shutdown(struct virtio_device *vdev) > > +{ > > + /* > > +* drm does its own synchronization on shutdown. > > +* Do nothing here, opt out of device reset. > > +*/ > > I think a call

[PATCH v2] drm/gem: Internally test import_attach for imported objects

2025-04-15 Thread Thomas Zimmermann
Test struct drm_gem_object.import_attach.dmabuf to detect imported objects. Warn if the stored state is inconsistent. During object clenaup, the dma_buf field might be NULL. Testing it in an object's free callback then incorrectly does a cleanup as for native objects. Happens for calls to drm_mode

Re: [PATCH v2] drm/gem: Internally test import_attach for imported objects

2025-04-15 Thread Boris Brezillon
On Tue, 15 Apr 2025 16:02:20 +0200 Thomas Zimmermann wrote: > Test struct drm_gem_object.import_attach.dmabuf to detect imported > objects. Warn if the stored state is inconsistent. > > During object clenaup, the dma_buf field might be NULL. Testing it in > an object's free callback then incorre

[PATCH v9 09/23] drm/mediatek: mtk_hdmi: Move audio params selection to new function

2025-04-15 Thread AngeloGioacchino Del Regno
In preparation for splitting common bits of this driver, move the audio params (codec, sample rate/size, input type, i2s format, etc) selection to a new function called mtk_hdmi_audio_params(). While at it, also rename "hdmi_params" to "aud_params" both to match the mtk_hdmi struct member name and

[PATCH v18 6/8] drm/vkms: Create KUnit tests for YUV conversions

2025-04-15 Thread Louis Chauvet
From: Arthur Grillo Create KUnit tests to test the conversion between YUV and RGB. Test each conversion and range combination with some common colors. The code used to compute the expected result can be found in comment. [Louis Chauvet: - fix minor formating issues (whitespace, double line) - c

Re: [PATCH v2 1/4] drm: function to get process name and pid

2025-04-15 Thread Khatri, Sunil
On 4/15/2025 5:10 PM, Tvrtko Ursulin wrote: On 15/04/2025 12:25, Sunil Khatri wrote: Add helper function which get the process information for the drm_file and updates the user provided character buffer with the information of process name and pid as a string. Signed-off-by: Sunil Khatri --

RE: [PATCH v18 4/5] drm/xe/xe_vm: Add per VM fault info

2025-04-15 Thread Cavitt, Jonathan
-Original Message- From: Auld, Matthew Sent: Tuesday, April 15, 2025 4:20 AM To: Cavitt, Jonathan ; intel...@lists.freedesktop.org Cc: Gupta, saurabhg ; Zuo, Alex ; joonas.lahti...@linux.intel.com; Brost, Matthew ; Zhang, Jianxun ; Lin, Shuicheng ; dri-devel@lists.freedesktop.org; Wajd

[PATCH v18 0/8] drm/vkms: Add support for YUV and DRM_FORMAT_R*

2025-04-15 Thread Louis Chauvet
This patchset is extracted from [1]. The goal is to introduce the YUV support, thanks to Arthur's work. - PATCH 2: Document pixel_arbg_u16 - PATCH 3: Add the support of YUV formats - PATCH 4: Add some drm properties to expose more YUV features - PATCH 5: Cleanup the todo - PATCH 6..7: Add some kun

Re: Pipeline vs. no pipeline (Re: [PATCH V8 06/43] drm/colorop: Add 1D Curve subtype)

2025-04-15 Thread Harry Wentland
On 2025-04-10 03:53, Pekka Paalanen wrote: > On Tue, 8 Apr 2025 13:30:46 -0400 > Harry Wentland wrote: > >> On 2025-04-08 12:40, Daniel Stone wrote: >>> Hi there, >>> >>> On Tue, 1 Apr 2025 at 20:53, Simon Ser wrote: On Tuesday, April 1st, 2025 at 17:14, Daniel Stone wrote: >

Re: [PATCH 1/2] drm/virtio: Test for imported buffers with drm_gem_is_imported()

2025-04-15 Thread Dmitry Osipenko
On 4/14/25 16:12, Thomas Zimmermann wrote: > Instead of testing import_attach for imported GEM buffers, invoke > drm_gem_is_imported() to do the test. The helper tests the dma_buf > itself while import_attach is just an artifact of the import. Prepares > to make import_attach optional. > > Signed-

Re: [PATCH v1 1/4] dt-bindings: display: panel: Document Renesas R61307 based DSI panel

2025-04-15 Thread Svyatoslav Ryhel
ср, 16 квіт. 2025 р. о 00:55 Rob Herring пише: > > On Sun, Apr 13, 2025 at 02:23:58PM +0300, Svyatoslav Ryhel wrote: > > R61307 is liquid crystal driver for high-definition amorphous silicon > > (a-Si) panels and is ideal for tablets and smartphones. > > > > Signed-off-by: Svyatoslav Ryhel > > --

Re: [PATCH 2/2] drm/virtio: Use dma_buf from GEM object instance

2025-04-15 Thread Dmitry Osipenko
On 4/14/25 16:12, Thomas Zimmermann wrote: > Avoid dereferencing struct drm_gem_object.import_attach for the > imported dma-buf. The dma_buf field in the GEM object instance refers > to the same buffer. Prepares to make import_attach optional. > > Signed-off-by: Thomas Zimmermann > --- > drivers

Re: [PATCH] dma-buf: heaps: Set allocation orders for larger page sizes

2025-04-15 Thread Juan Yescas
On Tue, Apr 15, 2025 at 7:28 PM 김재원 wrote: > > > > > -Original Message- > > From: T.J. Mercier [mailto:tjmerc...@google.com] > > Sent: Wednesday, April 16, 2025 5:57 AM > > To: Juan Yescas > > Cc: Sumit Semwal ; Benjamin Gaignard > > ; Brian Starkey ; > > John Stultz ; Christian König > >

[PATCH v2] dma-buf: system_heap: Set allocation orders for larger page sizes

2025-04-15 Thread Juan Yescas
This change sets the allocation orders for the different page sizes (4k, 16k, 64k) based on PAGE_SHIFT. Before this change, the orders for large page sizes were calculated incorrectly, this caused system heap to allocate from 2% to 4% more memory on 16KiB page size kernels. This change was tested

RE: [PATCH RESEND v13 0/5] Expose modifiers/formats supported by async flips

2025-04-15 Thread Borah, Chaitanya Kumar
Hello Alexander, > -Original Message- > From: Murthy, Arun R > Sent: Monday, April 7, 2025 11:14 AM > To: dri-devel@lists.freedesktop.org; intel-...@lists.freedesktop.org; intel- > x...@lists.freedesktop.org > Cc: Jani Nikula ; Borah, Chaitanya Kumar > ; Syrjala, Ville ; > Murthy, Arun R

Re: [PATCH v3 20/54] dyndbg: check DYNAMIC_DEBUG_CLASSMAP_DEFINE args at compile-time

2025-04-15 Thread Louis Chauvet
Le 15/04/2025 à 21:54, jim.cro...@gmail.com a écrit : On Tue, Apr 15, 2025 at 4:04 AM Louis Chauvet wrote: Le 02/04/2025 à 19:41, Jim Cromie a écrit : Add __DYNAMIC_DEBUG_CLASSMAP_CHECK to implement the following arg-checks at compile-time: 0 <= _base < 63 class_names is n

Re: [PATCH v9 17/23] drm/mediatek: mtk_hdmi: Split driver and add common probe function

2025-04-15 Thread 胡俊光

[PATCH v2 1/2] scripts/kernel-doc.py: don't create *.pyc files

2025-04-15 Thread Mauro Carvalho Chehab
As reported by Andy, kernel-doc.py is creating a __pycache__ directory at build time. Disable creation of __pycache__ for the libraries used by kernel-doc.py, when excecuted via the build system or via scripts/find-unused-docs.sh. Reported-by: Andy Shevchenko Closes: https://lore.kernel.org/linu

[PATCH v2 0/2] Don't create Python bytecode when building the kernel

2025-04-15 Thread Mauro Carvalho Chehab
As reported by Andy, the Kernel build system runs kernel-doc script for DRM, when W=1. Due to Python's normal behavior, its JIT compiler will create a bytecode and store it under scripts/lib/*/__pycache__. As one may be using O= and even having the sources on a read-only mount point, disable its

Re: Reggression caused by "drm/fb-helper: Don't use the preferred depth for the BPP default"

2025-04-15 Thread Thomas Zimmermann
Hi, thanks for the bug report. Am 16.04.25 um 04:23 schrieb Fabio Estevam: Hi, I have a custom board populated with a cfaf240320x panel connected via SPI and driven by the drivers/gpu/drm/tiny/panel-mipi-dbi.c driver. It works well on kernel 6.1. After upgrading the kernel to 6.12 (also test

[PATCH] scripts/kernel-doc.py: don't create *.pyc files

2025-04-15 Thread Mauro Carvalho Chehab
As reported by Andy, kernel-doc.py is creating a __pycache__ directory at build time. Disable creation of __pycache__ for the libraries used by kernel-doc.py, when excecuted via the build system or via scripts/find-unused-docs.sh. Reported-by: Andy Shevchenko Closes: https://lore.kernel.org/linu

Re: [PATCH 17/19] drm/virtio: Pass along the format info from .fb_create() to drm_helper_mode_fill_fb_struct()

2025-04-15 Thread Dmitry Osipenko
On 4/10/25 19:32, Ville Syrjala wrote: > From: Ville Syrjälä > > Plumb the format info from .fb_create() all the way to > drm_helper_mode_fill_fb_struct() to avoid the redundant > lookup. > > Cc: David Airlie > Cc: Gerd Hoffmann > Cc: Dmitry Osipenko > Cc: Gurchetan Singh > Cc: Chia-I Wu >

Re: [PATCH v8 6/6] rust: enable `clippy::ref_as_ptr` lint

2025-04-15 Thread Tamir Duberstein
On Tue, Apr 15, 2025 at 2:18 PM Boqun Feng wrote: > > On Tue, Apr 15, 2025 at 01:58:41PM -0400, Tamir Duberstein wrote: > > Hi Boqun, thanks for having a look! > > > > On Tue, Apr 15, 2025 at 1:37 PM Boqun Feng wrote: > > > > > > On Wed, Apr 09, 2025 at 10:47:23AM -0400, Tamir Duberstein wrote: >

Re: [PATCH v3 13/17] drm/bridge: cdns-dsi: Fix REG_WAKEUP_TIME value

2025-04-15 Thread Aradhya Bhatia
Hi Tomi, On 14/04/25 16:41, Tomi Valkeinen wrote: > The driver tries to calculate the value for REG_WAKEUP_TIME. However, > the calculation itself is not correct, and to add on it, the resulting > value is almost always larger than the field's size, so the actual > result is more or less random.>

Re: [PATCH] dma-buf: heaps: Set allocation orders for larger page sizes

2025-04-15 Thread John Stultz
On Tue, Apr 15, 2025 at 10:20 AM Juan Yescas wrote: > > This change sets the allocation orders for the different page sizes > (4k, 16k, 64k) based on PAGE_SHIFT. Before this change, the orders > for large page sizes were calculated incorrectly, this caused system > heap to allocate from 2% to 4% m

Re: [PATCH v3 21/54] dyndbg-test: change do_prints testpoint to accept a loopct

2025-04-15 Thread jim . cromie
On Tue, Apr 15, 2025 at 4:04 AM Louis Chauvet wrote: > > > > Le 02/04/2025 à 19:41, Jim Cromie a écrit : > > echo 1000 > /sys/module/test_dynamic_debug/parameters/do_prints > > > > This allows its use as a scriptable load generator, to generate > > dynamic-prefix-emits for flag combinations vs und

Re: [PATCH v3 23/54] dyndbg: treat comma as a token separator

2025-04-15 Thread jim . cromie
On Tue, Apr 15, 2025 at 4:05 AM Louis Chauvet wrote: > > > > Le 02/04/2025 à 19:41, Jim Cromie a écrit : > > Treat comma as a token terminator, just like a space. This allows a > > user to avoid quoting hassles when spaces are otherwise needed: > > > > :#> modprobe drm dyndbg=class,DRM_UT_CORE,

[GIT PULL] Immutable branch between Backlight, fbdev and LEDs for the v6.16 merge window

2025-04-15 Thread Lee Jones
Enjoy! The following changes since commit 0af2f6be1b4281385b618cb86ad946eded089ac8: Linux 6.15-rc1 (2025-04-06 13:11:33 -0700) are available in the Git repository at: ssh://g...@gitolite.kernel.org/pub/scm/linux/kernel/git/lee/backlight.git tags/ib-backlight-leds-fbdev-v6.16 for you to fe

Re: [PATCH v8 6/6] rust: enable `clippy::ref_as_ptr` lint

2025-04-15 Thread Boqun Feng
On Wed, Apr 09, 2025 at 10:47:23AM -0400, Tamir Duberstein wrote: > In Rust 1.78.0, Clippy introduced the `ref_as_ptr` lint [1]: > > > Using `as` casts may result in silently changing mutability or type. > > While this doesn't eliminate unchecked `as` conversions, it makes such > conversions easi

RE: [PATCH v12 2/8] drm/xe/uapi: Introduce API for EU stall sampling

2025-04-15 Thread Chegondi, Harish
I will send out a patch to replace __copy_from_user() with copy_from_user(). -Harish PS: Having issues with mutt, hence replying from Outlook -Original Message- From: Kees Cook Sent: Friday, April 4, 2025 10:56 AM To: Chegondi, Harish Cc: intel...@lists.freedesktop.org; Dixit, Ashutos

Re: [PATCH v2 10/10] arm64: dts: qcom: sar2130p: add display nodes

2025-04-15 Thread Konrad Dybcio
On 4/14/25 2:14 PM, Dmitry Baryshkov wrote: > On Mon, Apr 14, 2025 at 01:39:56PM +0200, Konrad Dybcio wrote: >> On 4/14/25 1:37 PM, Dmitry Baryshkov wrote: >>> On Mon, Apr 14, 2025 at 01:13:28PM +0200, Konrad Dybcio wrote: On 3/14/25 7:09 AM, Dmitry Baryshkov wrote: > From: Dmitry Baryshko

Re: [PATCH 13/13] drm/amd/display: move dc_sink from dc_edid to drm_edid

2025-04-15 Thread Jani Nikula
On Fri, 11 Apr 2025, Melissa Wen wrote: > +void dc_edid_copy_edid_to_sink(struct dc_sink *sink) > +{ > + const struct edid *edid; > + uint32_t edid_length; > + > + edid = drm_edid_raw(sink->drm_edid); // FIXME: Get rid of drm_edid_raw() > + edid_length = EDID_LENGTH * (edid->extens

Re: [PATCH 01/13] drm/amd/display: make sure drm_edid stored in aconnector doesn't leak

2025-04-15 Thread Mario Limonciello
On 4/11/2025 3:08 PM, Melissa Wen wrote: Make sure the drm_edid container stored in aconnector is freed when detroying the aconnector. destroying Fixes: 48edb2a4 ("drm/amd/display: switch amdgpu_dm_connector to use struct drm_edid") Signed-off-by: Melissa Wen Minor nit above. Add to nex

Re: [PATCH v7 1/2] drm/bridge: documentat bridge allocation and lifecycle

2025-04-15 Thread Maxime Ripard
Hi, On Wed, Apr 09, 2025 at 04:50:34PM +0200, Luca Ceresoli wrote: > Document in detail the DRM bridge allocation and refcounting process based > on the recently introduced devm_drm_bridge_alloc(). > > Signed-off-by: Luca Ceresoli There's a typo in your commit title. > --- > > Changes in v7:

Re: [PATCH v2 2/2] drm/amdgpu: Clean up error handling in amdgpu_userq_fence_driver_alloc()

2025-04-15 Thread Alex Deucher
Applied the series. Thanks! On Mon, Apr 14, 2025 at 12:48 AM Yadav, Arvind wrote: > > Reviewed-by:Arvind Yadav > > On 4/12/2025 8:09 PM, Dan Carpenter wrote: > > 1) Checkpatch complains if we print an error message for kzalloc() > > failure. The kzalloc() failure already has it's own error

[PATCH 1/2] Revert "udmabuf: fix vmap_udmabuf error page set"

2025-04-15 Thread Huan Yang
This reverts commit 18d7de823b7150344d242c3677e65d68c5271b04. This given a misuse of vmap_pfn, vmap_pfn only allow none-page based user invoke, i.e. PCIe BARs and other. Signed-off-by: Huan Yang Reported-by: Bingbu Cao Closes: https://lore.kernel.org/dri-devel/eb7e0137-3508-4287-98c4-816c5fd98

[PATCH v8 3/4] drm/panthor: Label all kernel BO's

2025-04-15 Thread Adrián Larumbe
Kernel BO's aren't exposed to UM, so labelling them is the responsibility of the driver itself. This kind of tagging will prove useful in further commits when want to expose these objects through DebugFS. Expand panthor_kernel_bo_create() interface to take a NUL-terminated string. No bounds checki

[PATCH v8 4/4] drm/panthor: show device-wide list of DRM GEM objects over DebugFS

2025-04-15 Thread Adrián Larumbe
Add a device DebugFS file that displays a complete list of all the DRM GEM objects that are exposed to UM through a DRM handle. Since leaking object identifiers that might belong to a different NS is inadmissible, this functionality is only made available in debug builds with DEBUGFS support enabl

[PATCH v8 2/4] drm/panthor: Add driver IOCTL for setting BO labels

2025-04-15 Thread Adrián Larumbe
Allow UM to label a BO for which it possesses a DRM handle. Signed-off-by: Adrián Larumbe Reviewed-by: Liviu Dudau Reviewed-by: Boris Brezillon Reviewed-by: Steven Price --- drivers/gpu/drm/panthor/panthor_drv.c | 64 ++- drivers/gpu/drm/panthor/panthor_gem.h | 2 + i

[PATCH v8 1/4] drm/panthor: Introduce BO labeling

2025-04-15 Thread Adrián Larumbe
Add a new character string Panthor BO field, and a function that allows setting it from within the driver. Driver takes care of freeing the string when it's replaced or no longer needed at object destruction time, but allocating it is the responsibility of callers. Signed-off-by: Adrián Larumbe

[PATCH v8 0/4] Panthor BO tagging and GEMS debug display

2025-04-15 Thread Adrián Larumbe
This patch series is aimed at providing UM with detailed memory profiling information in debug builds. It is achieved through a device-wide list of DRM GEM objects, and also implementing the ability to label BO's from UM through a new IOCTL. The new debugfs file shows a list of driver DRM GEM obje

[PATCH v2] docs: backlight: Clarify `actual_brightness`

2025-04-15 Thread Mario Limonciello
From: Mario Limonciello Currently userspace software systemd treats `brightness` and `actual_brightness` identically due to a bug found in an out of tree driver. This however causes problems for in-tree drivers that use brightness to report user requested `brightness` and `actual_brightness` to

Re: [PATCH v3 18/54] selftests-dyndbg: add tools/testing/selftests/dynamic_debug/*

2025-04-15 Thread jim . cromie
On Tue, Apr 15, 2025 at 4:02 AM Louis Chauvet wrote: > > > > Le 02/04/2025 à 19:41, Jim Cromie a écrit : > > Add a selftest script for dynamic-debug. The config requires > > CONFIG_TEST_DYNAMIC_DEBUG=m and CONFIG_TEST_DYNAMIC_DEBUG_SUBMOD=m, > > which tacitly requires either CONFIG_DYNAMIC_DEBUG=

Re: [PATCH v3 20/54] dyndbg: check DYNAMIC_DEBUG_CLASSMAP_DEFINE args at compile-time

2025-04-15 Thread jim . cromie
On Tue, Apr 15, 2025 at 4:04 AM Louis Chauvet wrote: > > > > Le 02/04/2025 à 19:41, Jim Cromie a écrit : > > Add __DYNAMIC_DEBUG_CLASSMAP_CHECK to implement the following > > arg-checks at compile-time: > > > > 0 <= _base < 63 > > class_names is not empty > > class_names[0] is a

  1   2   3   >