Re: [PATCH 01/13] drm/amd/display: make sure drm_edid stored in aconnector doesn't leak

[Mario Limonciello]

On 4/11/2025 3:08 PM, Melissa Wen wrote:

Make sure the drm_edid container stored in aconnector is freed when
detroying the aconnector.

destroying

Fixes: 48edb2a4 ("drm/amd/display: switch amdgpu_dm_connector to use struct 
drm_edid")
Signed-off-by: Melissa Wen <m...@igalia.com>

Minor nit above.  Add to next version:

Reviewed-by: Mario Limonciello <mario.limoncie...@amd.com>

---
  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c 
b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index 8665bd3cb75a..960bb8c62ffe 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -7397,6 +7397,8 @@ static void amdgpu_dm_connector_destroy(struct 
drm_connector *connector)
                dc_sink_release(aconnector->dc_sink);
        aconnector->dc_sink = NULL;

+ drm_edid_free(aconnector->drm_edid);

+
        drm_dp_cec_unregister_connector(&aconnector->dm_dp_aux.aux);
        drm_connector_unregister(connector);
        drm_connector_cleanup(connector);