[PATCH v4] dma-buf: heap: Replace nested max() with single max3()

2025-03-17 Thread feng.wei8
From: FengWei Use max3() macro instead of nesting max() to simplify the return statement. Signed-off-by: FengWei --- v3 -> v4 fix the format of this patch. drivers/dma-buf/dma-heap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma-buf/dma-heap.c b/drivers/dma-bu

Re: [PATCH v5 4/6] dt-bindings: gpu: v3d: Add additional examples to improve binding checks

2025-03-17 Thread Krzysztof Kozlowski
On 16/03/2025 18:42, Maíra Canal wrote: > Hi Krzysztof, > > On 16/03/25 13:43, Krzysztof Kozlowski wrote: >> On Sun, Mar 16, 2025 at 11:15:11AM -0300, Maíra Canal wrote: >>> To prevent future changes that might inadvertently break the ABI, add >>> more examples to the binding. These examples impro

Re: [PATCH 3/4] drm/panthor: show device-wide list of DRM GEM objects over DebugFS

2025-03-17 Thread Boris Brezillon
On Sun, 16 Mar 2025 21:51:34 + Adrián Larumbe wrote: > Add a device DebugFS file that displays a complete list of all the DRM GEM > objects that are exposed to UM through a DRM handle. > > Since leaking object identifiers that might belong to a different NS is > inadmissible, this functional

Re: [PATCH 2/4] drm/panthor: Add driver IOCTL for setting BO labels

2025-03-17 Thread Boris Brezillon
On Sun, 16 Mar 2025 21:51:33 + Adrián Larumbe wrote: > Allow UM to label a BO for which it possesses a DRM handle. > > Signed-off-by: Adrián Larumbe > --- > drivers/gpu/drm/panthor/panthor_drv.c | 31 +++ > include/uapi/drm/panthor_drm.h| 14 >

Re: [PATCH v6 2/4] drm/bridge: add function interface for DisplayPort audio implementation

2025-03-17 Thread Maxime Ripard
On Fri, Mar 14, 2025 at 08:55:05PM +0200, Dmitry Baryshkov wrote: > On Fri, Mar 14, 2025 at 05:54:14PM +, Maxime Ripard wrote: > > On Fri, 14 Mar 2025 11:36:49 +0200, Dmitry Baryshkov wrote: > > > It is common for the DisplayPort bridges to implement audio support. In > > > preparation to provi

Re: [PATCH v4 3/6] dt-bindings: drm/msm/gpu: Document AON clock for A505/A506/A510

2025-03-17 Thread Barnabás Czémán
On March 17, 2025 10:21:50 AM GMT+01:00, Krzysztof Kozlowski wrote: >On Sat, Mar 15, 2025 at 03:57:37PM +0100, Barnabás Czémán wrote: >> From: Adam Skladowski >> >> Adreno 505 (MSM8937), Adreno 506(MSM8953) and Adreno 510(MSM8976) >> require Always-on branch clock to be enabled, describe it.

Re: [PATCH v4 1/6] dt-bindings: clock: qcom: Add MSM8937 Global Clock Controller

2025-03-17 Thread Barnabás Czémán
On March 17, 2025 10:17:46 AM GMT+01:00, Krzysztof Kozlowski wrote: >On Sat, Mar 15, 2025 at 03:57:35PM +0100, Barnabás Czémán wrote: >> Add device tree bindings for the global clock controller on Qualcomm >> MSM8937 platform. >> >> Signed-off-by: Barnabás Czémán >> --- >> .../bindings/cloc

[PATCH v2 RESEND] drm/msm/dpu: reorder pointer operations after sanity checks to avoid NULL deref

2025-03-17 Thread Qasim Ijaz
_dpu_encoder_trigger_start dereferences "struct dpu_encoder_phys *phys" before the sanity checks which can lead to a NULL pointer dereference if phys is NULL. Fix this by reordering the dereference after the sanity checks. Fixes: 8144d17a81d9 ("drm/msm/dpu: Skip trigger flush and start for CWB"

Re: [PATCH v2 03/12] dt-bindings: connector: Add the GOcontroll Moduline module slot bindings

2025-03-17 Thread Krzysztof Kozlowski
On Sat, Mar 15, 2025 at 07:32:28AM +, Maud Spierings | GOcontroll wrote: > >> +required: > >> + - compatible > >> + - reg > >> + - reset-gpios > >> + - interrupts > >> + - sync-gpios > >> + - i2c-bus > >> + - slot-number > >> + > >> +additionalProperties: false > >> + > >> +examples: > >

Re: [PATCH v2 03/12] dt-bindings: connector: Add the GOcontroll Moduline module slot bindings

2025-03-17 Thread Maud Spierings | GOcontroll
From: Krzysztof Kozlowski Sent: Monday, March 17, 2025 11:34 AM   >On Sat, Mar 15, 2025 at 07:32:28AM +, Maud Spierings | GOcontroll wrote: >> >> +required: >> >> +  - compatible >> >> +  - reg >> >> +  - reset-gpios >> >> +  - interrupts >> >> +  - sync-gpios >> >> +  - i2c-bus >> >> +  - slo

Re: [PATCH 1/4] drm/panthor: Introduce BO labeling

2025-03-17 Thread Boris Brezillon
On Sun, 16 Mar 2025 21:51:32 + Adrián Larumbe wrote: > Add a new character string Panthor BO field, and a function that allows > setting it from within the driver. > > Driver takes care of freeing the string when it's replaced or no longer > needed at object destruction time, but allocating

[PATCH] drm/bridge: sil-sii8620: Use dev_err_probe()

2025-03-17 Thread zhang.enpei
From: ZhangEnpei Replace the open-code with dev_err_probe() to simplify the code. Signed-off-by: ZhangEnpei --- drivers/gpu/drm/bridge/sil-sii8620.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/bridge/sil-sii8620.c b/drivers/gpu/drm/bridge/sil-s

[PATCH 11/15] drm/vc4: Test for imported buffers with drm_gem_is_imported()

2025-03-17 Thread Thomas Zimmermann
Instead of testing import_attach for imported GEM buffers, invoke drm_gem_is_imported() to do the test. The helper tests the dma_buf itself while import_attach is just an artifact of the import. Prepares to make import_attach optional. Signed-off-by: Thomas Zimmermann Cc: Maxime Ripard Cc: Dave

[PATCH v4 4/6] drm/panfrost: Add support for AARCH64_4K page table format

2025-03-17 Thread Ariel D'Alessandro
Currently, Panfrost only supports MMU configuration in "LEGACY" (as Bifrost calls it) mode, a (modified) version of LPAE "Large Physical Address Extension", which in Linux we've called "mali_lpae". This commit adds support for conditionally enabling AARCH64_4K page table format. To achieve that, a

[PATCH v4 6/6] drm/panfrost: Force AARCH64_4K page table format on MediaTek MT8192

2025-03-17 Thread Ariel D'Alessandro
MediaTek MT8192 SoC has an ARM Mali-G57 MC5 GPU (Valhall-JM). Now that Panfrost supports AARCH64_4K page table format, let's enable it on this SoC. Running glmark2-es2-drm [0] benchmark, reported the same performance score on both modes Mali LPAE (LEGACY) vs. AARCH64_4K, before and after this comm

[PATCH v4 5/6] drm/panfrost: Force AARCH64_4K page table format on MediaTek MT8188

2025-03-17 Thread Ariel D'Alessandro
MediaTek MT8188 SoC has an ARM Mali-G57 MC3 GPU (Valhall-JM), which constantly faults with the current panfrost support. For instance, running `glmark2-es2-drm` benchmark test: ``` [ 79.617461] panfrost 1300.gpu: js fault, js=1, status=JOB_BUS_FAULT, head=0xaadc380, tail=0xaadc380 [ 80.11

Re: [PATCH v7 00/11] drm/bridge: add devm_drm_bridge_alloc() with bridge refcount

2025-03-17 Thread Luca Ceresoli
Hello Maxime, On Fri, 14 Mar 2025 19:21:01 +0100 Maxime Ripard wrote: > Hi, > > On Fri, Mar 14, 2025 at 11:31:13AM +0100, Luca Ceresoli wrote: > > This series improves the way DRM bridges are allocated and > > initialized and makes them reference-counted. The goal of reference > > counting is t

Re: [PATCH v7 02/11] drm/bridge: add support for refcounting

2025-03-17 Thread Luca Ceresoli
Hello Maxime, thanks for the very prompt feedback! On Fri, 14 Mar 2025 19:04:40 +0100 Maxime Ripard wrote: > On Fri, Mar 14, 2025 at 11:31:15AM +0100, Luca Ceresoli wrote: > > DRM bridges are currently considered as a fixed element of a DRM card, and > > thus their lifetime is assumed to extend

Re: [PATCH v7 06/11] drm/bridge: get the bridge returned by drm_bridge_chain_get_first_bridge()

2025-03-17 Thread Luca Ceresoli
On Fri, 14 Mar 2025 19:10:41 +0100 Maxime Ripard wrote: > On Fri, Mar 14, 2025 at 11:31:19AM +0100, Luca Ceresoli wrote: > > drm_bridge_chain_get_first_bridge() returns a bridge pointer that the > > caller could hold for a long time. Increment the refcount of the returned > > bridge and document

[PATCH] drm/msm/a6xx+: Don't let IB_SIZE overflow

2025-03-17 Thread Rob Clark
From: Rob Clark IB_SIZE is only b0..b19. Starting with a6xx gen3, additional fields were added above the IB_SIZE. Accidentially setting them can cause badness. Fix this by properly defining the CP_INDIRECT_BUFFER packet and using the generated builder macro to ensure unintended bits are not se

Re: [RFC 13/29] drm/gpuvm: Introduce MADVISE Operations

2025-03-17 Thread Danilo Krummrich
(Cc: dri-devel@lists.freedesktop.org, Boris) Hi Himal, Please make sure to copy in dri-devel for such patches. On Fri, Mar 14, 2025 at 01:32:10PM +0530, Himal Prasad Ghimiray wrote: > Introduce MADVISE operations that do not unmap the GPU VMA. These > operations split VMAs if the start or end ad

[PATCH v4 2/6] drm/panfrost: Use GPU_MMU_FEATURES_VA_BITS/PA_BITS macros

2025-03-17 Thread Ariel D'Alessandro
As done in panthor, define and use these GPU_MMU_FEATURES_* macros, which makes code easier to read and reuse. Signed-off-by: Ariel D'Alessandro Reviewed-by: Boris Brezillon Reviewed-by: Steven Price Reviewed-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/panfrost/panfrost_mmu.c | 6 +++

[PATCH v4 3/6] drm/panfrost: Set HW_FEATURE_AARCH64_MMU feature flag on Bifrost models

2025-03-17 Thread Ariel D'Alessandro
Set this feature flag on all Mali Bifrost platforms as the MMU supports AARCH64 4K page table format. Signed-off-by: Ariel D'Alessandro Reviewed-by: Boris Brezillon Reviewed-by: Steven Price Reviewed-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/panfrost/panfrost_features.h | 3 +++ 1 f

[PATCH v4 1/6] drm/panfrost: Set IOMMU_CACHE flag

2025-03-17 Thread Ariel D'Alessandro
Panfrost does not support uncached mappings, so flag them properly. Also flag the pages that are mapped as response to a page fault as cached. Signed-off-by: Boris Brezillon Signed-off-by: Ariel D'Alessandro Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Steven Price --- drivers/gpu/dr

Re: [PATCH v3 4/6] drm/panfrost: Add support for AARCH64_4K page table format

2025-03-17 Thread Boris Brezillon
On Mon, 17 Mar 2025 09:40:42 -0300 Ariel D'Alessandro wrote: > +static int panfrost_mmu_cfg_init(struct panfrost_mmu *mmu, > + enum io_pgtable_fmt fmt) > +{ > + struct panfrost_device *pfdev = mmu->pfdev; > + > + switch (fmt) { > + case ARM_64_LPAE_S1: >

Re: [PATCH 06/15] drm/msm: Test for imported buffers with drm_gem_is_imported()

2025-03-17 Thread Dmitry Baryshkov
On Mon, Mar 17, 2025 at 02:06:44PM +0100, Thomas Zimmermann wrote: > Instead of testing import_attach for imported GEM buffers, invoke > drm_gem_is_imported() to do the test. The helper tests the dma_buf > itself while import_attach is just an artifact of the import. Prepares > to make import_attac

[PATCH][next] ice: make const read-only array dflt_rules static

2025-03-17 Thread Colin Ian King
Don't populate the const read-only array dflt_rules on the stack at run time, instead make it static. Signed-off-by: Colin Ian King --- drivers/gpu/drm/i915/intel_memory_region.c| 2 +- drivers/net/ethernet/intel/ice/ice_ethtool_fdir.c | 2 +- 2 files changed, 2 insertions(+), 2 deletion

[PATCH v9 3/4] rust: replace `kernel::c_str!` with C-Strings

2025-03-17 Thread Tamir Duberstein
C-String literals were added in Rust 1.77. Replace instances of `kernel::c_str!` with C-String literals where possible and rename `kernel::c_str!` to `c_str_avoid_literals` to clarify its intended use. Closes: https://github.com/Rust-for-Linux/linux/issues/1075 Signed-off-by: Tamir Duberstein ---

[PATCH v9 4/4] rust: remove core::ffi::CStr reexport

2025-03-17 Thread Tamir Duberstein
Clean up references to `kernel::str::CStr`. Signed-off-by: Tamir Duberstein --- drivers/gpu/drm/drm_panic_qr.rs | 4 ++-- drivers/net/phy/ax88796b_rust.rs | 1 + drivers/net/phy/qt2025.rs| 1 + rust/kernel/device.rs| 3 +-- rust/kernel/driver.rs| 4 ++-- rus

[PATCH v9 0/4] rust: replace kernel::str::CStr w/ core::ffi::CStr

2025-03-17 Thread Tamir Duberstein
This picks up from Michal Rostecki's work[0]. Per Michal's guidance I have omitted Co-authored tags, as the end result is quite different. Link: https://lore.kernel.org/rust-for-linux/20240819153656.28807-2-vadorov...@protonmail.com/t/#u [0] Closes: https://github.com/Rust-for-Linux/linux/issues

Re: [PATCH v4 3/6] dt-bindings: drm/msm/gpu: Document AON clock for A505/A506/A510

2025-03-17 Thread Krzysztof Kozlowski
On 17/03/2025 10:48, Barnabás Czémán wrote: > > > On March 17, 2025 10:21:50 AM GMT+01:00, Krzysztof Kozlowski > wrote: >> On Sat, Mar 15, 2025 at 03:57:37PM +0100, Barnabás Czémán wrote: >>> From: Adam Skladowski >>> >>> Adreno 505 (MSM8937), Adreno 506(MSM8953) and Adreno 510(MSM8976) >>> re

Re: [PATCH v5 2/3] drm/i915: Fix PXP cleanup missing from probe error rewind

2025-03-17 Thread Krzysztof Niemiec
Hi Janusz, On 2025-03-14 at 21:38:34 GMT, Janusz Krzysztofik wrote: > Commit f67986b0119c04 ("drm/i915/pxp: Promote pxp subsystem to top-level > of i915") added PXP initialization to driver probe path, but didn't add a > respective PXP cleanup on probe error. That lack of cleanup seems > harmless

Re: [PATCH v5 1/3] drm/i915: Downgrade device register error if injected

2025-03-17 Thread Krzysztof Niemiec
Hi Janusz, thanks for the series. On 2025-03-14 at 21:38:33 GMT, Janusz Krzysztofik wrote: > Commit 8f460e2c78f2 ("drm/i915: Demidlayer driver loading") which > introduced manual device registration also added a message that is > submitted on device registration failure as an error. If that fail

Re: [PATCH v5 3/3] drm/i915: Fix harmful driver register/unregister asymmetry

2025-03-17 Thread Krzysztof Niemiec
Hi Janusz, On 2025-03-14 at 21:38:35 GMT, Janusz Krzysztofik wrote: > Starting with commit ec3e00b4ee27 ("drm/i915: stop registering if > drm_dev_register() fails"), we return from i915_driver_register() > immediately if drm_dev_register() fails, skipping remaining registration > steps, and contin

RE: [PATCH v8 2/6] drm/xe/xe_gt_pagefault: Move pagefault struct to header

2025-03-17 Thread Cavitt, Jonathan
-Original Message- From: Wajdeczko, Michal Sent: Saturday, March 15, 2025 7:45 AM To: Cavitt, Jonathan ; intel...@lists.freedesktop.org Cc: Gupta, saurabhg ; Zuo, Alex ; joonas.lahti...@linux.intel.com; Brost, Matthew ; Zhang, Jianxun ; Lin, Shuicheng ; dri-devel@lists.freedesktop.org;

Re: [PATCH] drm/panel/sharp-ls043t1le01: Use _multi variants

2025-03-17 Thread Anusha Srivatsa
On Sun, Mar 16, 2025 at 7:32 PM Dmitry Baryshkov < dmitry.barysh...@oss.qualcomm.com> wrote: > On Sun, Mar 16, 2025 at 02:58:22PM -0400, Anusha Srivatsa wrote: > > Move away from using deprecated API and use _multi > > variants if available. Use mipi_dsi_msleep() > > and mipi_dsi_usleep_range() in

[PATCH v6 2/5] dt-bindings: gpu: v3d: Add per-compatible register restrictions

2025-03-17 Thread Maíra Canal
In order to enforce per-SoC register rules, add per-compatible restrictions. For example, V3D 3.3 (used in brcm,7268-v3d) has a cache controller (GCA), which is not present in other V3D generations. Declaring these differences helps ensure the DTB accurately reflect the hardware design. The exampl

[PATCH v2 4/5] drm/bridge: anx78xx: Switch to common helpers to power up/down dp link

2025-03-17 Thread Andy Yan
From: Andy Yan Use the common dp link power up/down helpers to avoid duplicating code. Signed-off-by: Andy Yan Reviewed-by: Dmitry Baryshkov --- (no changes since v1) .../drm/bridge/analogix/analogix-anx78xx.c| 30 +-- 1 file changed, 1 insertion(+), 29 deletions(-) dif

[PATCH v2 5/5] drm/bridge: it6505: Switch to common helpers to power up/down dp link

2025-03-17 Thread Andy Yan
From: Andy Yan Use the common dp link power up/down helpers to avoid duplicating code. Signed-off-by: Andy Yan Reviewed-by: Dmitry Baryshkov --- (no changes since v1) drivers/gpu/drm/bridge/ite-it6505.c | 46 +++-- 1 file changed, 4 insertions(+), 42 deletions(-) di

[PATCH v2 1/5] drm/dp: Pull drm_dp_link_power_up/down from Tegra to common drm_dp_helper

2025-03-17 Thread Andy Yan
From: Andy Yan The helper functions drm_dp_link_power_up/down were moved to Tegra DRM in commit 9a42c7c647a9 ("drm/tegra: Move drm_dp_link helpers to Tegra DRM")". Now since more and more users are duplicating the same code in their own drivers, it's time to make them as DRM DP common helpers a

[PATCH v2 3/5] drm/bridge: anx6345: Switch to common helpers to power up/down dp link

2025-03-17 Thread Andy Yan
From: Andy Yan Use the common dp link power up/down helpers to avoid duplicating code. Signed-off-by: Andy Yan Reviewed-by: Dmitry Baryshkov --- (no changes since v1) .../drm/bridge/analogix/analogix-anx6345.c| 30 +-- 1 file changed, 1 insertion(+), 29 deletions(-) dif

[PATCH v2 2/5] drm/bridge: cdns-mhdp8546: Switch to common helpers to power up/down dp link

2025-03-17 Thread Andy Yan
From: Andy Yan Use the common dp link power up/down helpers to avoid duplicating code. Signed-off-by: Andy Yan Reviewed-by: Dmitry Baryshkov --- (no changes since v1) .../drm/bridge/cadence/cdns-mhdp8546-core.c | 74 +-- 1 file changed, 2 insertions(+), 72 deletions(-) di

[PATCH RESEND] agp: Fix a potential memory leak bug in agp_amdk7_probe()

2025-03-17 Thread Haoxiang Li
Variable "bridge" is allocated by agp_alloc_bridge() and have to be released by agp_put_bridge() if something goes wrong. In this patch, add the missing call of agp_put_bridge() in agp_amdk7_probe() to prevent potential memory leak bug. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Cc: sta...@vger.kern

Re: [PATCH] docs: driver-api: firmware: clarify userspace requirements

2025-03-17 Thread Jonathan Corbet
Dave Airlie writes: >> Dave, you're the only one with fingerprints on this document; is the >> change OK with you? > > LGTM, > > Acked-by: Dave Airlie OK, applied - thanks. jon

Re: [PATCH] docs: driver-api: firmware: clarify userspace requirements

2025-03-17 Thread Jonathan Corbet
Jacek Lawrynowicz writes: > The guidelines mention that firmware updates can't break the kernel, > but it doesn't state directly that they can't break userspace programs. > Make it explicit that firmware updates cannot break UAPI. > > Signed-off-by: Jacek Lawrynowicz > --- > .../driver-api/firm

Re: [PATCH v6 drm-dp 0/9] Add HPD, getting EDID, colorbar features in DP function

2025-03-17 Thread Yongbang Shi
Gently ping! Hi, Dmitry. There is no more comment for this patch set for one week, I wonder, could this patch be applied, or wait for more comments. Thanks, Baihan From: Baihan Li To support DP HPD, edid printing, and colorbar display features based on the Hisislcon DP devices. --- ChangeLo

[PATCH v6 1/5] drm/v3d: Associate a V3D tech revision to all supported devices

2025-03-17 Thread Maíra Canal
The V3D driver currently determines the GPU tech version (33, 41...) by reading a register. This approach has worked so far since this information wasn’t needed before powering on the GPU. V3D 7.1 introduces new registers that must be written to power on the GPU, requiring us to know the V3D versi

[PATCH v6 5/5] drm/v3d: Use V3D_SMS registers for power on/off and reset on V3D 7.x

2025-03-17 Thread Maíra Canal
In addition to the standard reset controller, V3D 7.x requires configuring the V3D_SMS registers for proper power on/off and reset. Add the new registers to `v3d_regs.h` and ensure they are properly configured during device probing, removal, and reset. This change fixes GPU reset issues on the Ras

[PATCH v6 4/5] dt-bindings: gpu: v3d: Add V3D driver maintainer as DT maintainer

2025-03-17 Thread Maíra Canal
As established in commit 89d04995f76c ("MAINTAINERS: Drop Emma Anholt from all M lines."), Emma is no longer active in the Linux kernel and dropped the V3D maintainership. Therefore, remove Emma as one of the DT maintainers and add the current V3D driver maintainer. Acked-by: Emma Anholt Acked-by

[PATCH] drm/rockchip: vop2: Make overlay layer select register configuration take effect by vsync

2025-03-17 Thread Andy Yan
From: Andy Yan Because the layer/window enable/disable is take effect by vsync, if the overlay configuration of these layers does not follow vsync and takes effect immediately instead, when multiple layers are dynamically enable/disable, inconsistent display contents may be seen on the screen. S

Re: (subset) [PATCH v2 2/9] rtc: pcf50633: Remove

2025-03-17 Thread Alexandre Belloni
On Tue, 11 Mar 2025 01:49:52 +, li...@treblig.org wrote: > The pcf50633 was used as part of the OpenMoko devices but > the support for its main chip was recently removed in: > commit 61b7f8920b17 ("ARM: s3c: remove all s3c24xx support") > > See https://lore.kernel.org/all/Z8z236h4B5A6Ki3D@gall

Re: [PATCH] docs: driver-api: firmware: clarify userspace requirements

2025-03-17 Thread Dave Airlie
On Tue, 18 Mar 2025 at 08:53, Jonathan Corbet wrote: > > Jacek Lawrynowicz writes: > > > The guidelines mention that firmware updates can't break the kernel, > > but it doesn't state directly that they can't break userspace programs. > > Make it explicit that firmware updates cannot break UAPI. >

Re: [PATCH v1 1/7] virtio-gpu api: add blob userptr resource

2025-03-17 Thread Gurchetan Singh
On Thu, Mar 6, 2025 at 2:52 AM Huang, Honglei1 wrote: > > On 2025/3/1 5:21, Demi Marie Obenour wrote: > > On 2/28/25 12:36 AM, Honglei Huang wrote: > >> From: Honglei Huang > >> > >> Add a new resource for blob resource, called userptr, used for let > >> host access guest user space memory, to a

Re: [PATCH 1/5] drm: panel-orientation-quirks: Add OneXPlayer X1 AMD and Intel quirk

2025-03-17 Thread Hans de Goede
Hi, On 22-Feb-25 17:43, Antheas Kapenekakis wrote: > The OneXPlayer X1 series features a 2k 10.95 display with a portrait > orientation. Add a quirk to set the panel orientation to portrait mode > to both the Intel and AMD variants. > > Signed-off-by: Antheas Kapenekakis Thanks, patch looks goo

Re: [PATCH 2/5] drm: panel-orientation-quirks: Add OneXPlayer X1 Mini (AMD) quirk

2025-03-17 Thread Hans de Goede
Hi, On 22-Feb-25 17:43, Antheas Kapenekakis wrote: > The OneXPlayer X1 mini features a 2k 8.8 display with a portrait > orientation. Add a quirk to set the panel orientation to portrait > mode. There is no Intel variant. > > Signed-off-by: Antheas Kapenekakis Thanks, patch looks good to me: Re

Re: [PATCH 3/5] drm: panel-orientation-quirks: Add OneXPlayer F1Pro quirk

2025-03-17 Thread Hans de Goede
Hi, On 22-Feb-25 17:43, Antheas Kapenekakis wrote: > The OneXPlayer F1Pro has a 144hz 1920x1080 portrait OLED panel. > Add a quirk to correct the panel portrait orientation. In addition, > it comes with a red limited edition variant in the Chinese market, > so add that as well. > > Signed-off-by:

Re: [PATCH v4 1/6] dt-bindings: clock: qcom: Add MSM8937 Global Clock Controller

2025-03-17 Thread Krzysztof Kozlowski
On Sat, Mar 15, 2025 at 03:57:35PM +0100, Barnabás Czémán wrote: > Add device tree bindings for the global clock controller on Qualcomm > MSM8937 platform. > > Signed-off-by: Barnabás Czémán > --- > .../bindings/clock/qcom,gcc-msm8937.yaml | 75 > ++ > include/dt-b

Re: [PATCH v2 4/6] drm/panfrost: Add support for AARCH64_4K page table format

2025-03-17 Thread Ariel D'Alessandro
Boris, On 3/15/25 5:43 AM, Boris Brezillon wrote: On Fri, 14 Mar 2025 14:38:56 -0300 Ariel D'Alessandro wrote: Currently, Panfrost only supports MMU configuration in "LEGACY" (as Bifrost calls it) mode, a (modified) version of LPAE "Large Physical Address Extension", which in Linux we've call

[PATCH v3 4/6] drm/panfrost: Add support for AARCH64_4K page table format

2025-03-17 Thread Ariel D'Alessandro
Currently, Panfrost only supports MMU configuration in "LEGACY" (as Bifrost calls it) mode, a (modified) version of LPAE "Large Physical Address Extension", which in Linux we've called "mali_lpae". This commit adds support for conditionally enabling AARCH64_4K page table format. To achieve that, a

[PATCH v3 5/6] drm/panfrost: Force AARCH64_4K page table format on MediaTek MT8188

2025-03-17 Thread Ariel D'Alessandro
MediaTek MT8188 SoC has an ARM Mali-G57 MC3 GPU (Valhall-JM), which constantly faults with the current panfrost support. For instance, running `glmark2-es2-drm` benchmark test: ``` [ 79.617461] panfrost 1300.gpu: js fault, js=1, status=JOB_BUS_FAULT, head=0xaadc380, tail=0xaadc380 [ 80.11

[PATCH v3 0/6] drm/panfrost: Add support for AARCH64_4K page table format

2025-03-17 Thread Ariel D'Alessandro
Hi all, This is a new iteration on Panfrost support for AARCH64_4K page table format. The main reason behind this patchset is that MediaTek MT8188 SoC (ARM Mali-G57 MC3 GPU) constantly faults due to the actual Panfrost cache configuration. Currently, Panfrost only supports MMU configuration in "L

[PATCH v3 1/6] drm/panfrost: Set IOMMU_CACHE flag

2025-03-17 Thread Ariel D'Alessandro
Panfrost does not support uncached mappings, so flag them properly. Also flag the pages that are mapped as response to a page fault as cached. Signed-off-by: Boris Brezillon Signed-off-by: Ariel D'Alessandro Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Steven Price --- drivers/gpu/dr

[PATCH v3 3/6] drm/panfrost: Set HW_FEATURE_AARCH64_MMU feature flag on Bifrost models

2025-03-17 Thread Ariel D'Alessandro
Set this feature flag on all Mali Bifrost platforms as the MMU supports AARCH64 4K page table format. Signed-off-by: Ariel D'Alessandro Reviewed-by: Boris Brezillon Reviewed-by: Steven Price Reviewed-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/panfrost/panfrost_features.h | 3 +++ 1 f

[PATCH v3 2/6] drm/panfrost: Use GPU_MMU_FEATURES_VA_BITS/PA_BITS macros

2025-03-17 Thread Ariel D'Alessandro
As done in panthor, define and use these GPU_MMU_FEATURES_* macros, which makes code easier to read and reuse. Signed-off-by: Ariel D'Alessandro Reviewed-by: Boris Brezillon Reviewed-by: Steven Price Reviewed-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/panfrost/panfrost_mmu.c | 6 +++

[PATCH v3 6/6] drm/panfrost: Force AARCH64_4K page table format on MediaTek MT8192

2025-03-17 Thread Ariel D'Alessandro
MediaTek MT8192 SoC has an ARM Mali-G57 MC5 GPU (Valhall-JM). Now that Panfrost supports AARCH64_4K page table format, let's enable it on this SoC. Running glmark2-es2-drm [0] benchmark, reported the same performance score on both modes Mali LPAE (LEGACY) vs. AARCH64_4K, before and after this comm

Re: [PATCH v4] dma-buf: heap: Replace nested max() with single max3()

2025-03-17 Thread Krzysztof Kozlowski
On 17/03/2025 03:37, feng.w...@zte.com.cn wrote: > From: FengWei > > Use max3() macro instead of nesting max() to simplify the return > statement. > > Signed-off-by: FengWei > --- > v3 -> v4 > fix the format of this patch. > drivers/dma-buf/dma-heap.c | 2 +- You sent five versions per day of t

[PATCH v2] drm/rockchip: dw_hdmi_qp: Fix io init for dw_hdmi_qp_rockchip_resume

2025-03-17 Thread Andy Yan
From: Andy Yan Use cfg->ctrl_ops->io_init callback make it work for all platform. And it's also gets rid of code duplication Fixes: 3f60dbd40d3f ("drm/rockchip: dw_hdmi_qp: Add platform ctrl callback") Signed-off-by: Andy Yan Reviewed-by: Sebastian Reichel --- Changes in v2: - Store the ctrl

Re: [PATCH v6 2/4] drm/bridge: add function interface for DisplayPort audio implementation

2025-03-17 Thread Dmitry Baryshkov
On Mon, Mar 17, 2025 at 10:45:16AM +0100, Maxime Ripard wrote: > On Fri, Mar 14, 2025 at 08:55:05PM +0200, Dmitry Baryshkov wrote: > > On Fri, Mar 14, 2025 at 05:54:14PM +, Maxime Ripard wrote: > > > On Fri, 14 Mar 2025 11:36:49 +0200, Dmitry Baryshkov wrote: > > > > It is common for the Displa

Re: drm-ci: vkms: kms_flip@modeset-vs-vblank-race flake

2025-03-17 Thread Vignesh Raman
Hi Louis, On 14/03/25 20:01, Louis Chauvet wrote: Le 14/03/2025 à 13:11, Vignesh Raman a écrit : Hi Louis, On 13/03/25 19:30, Louis Chauvet wrote: Le 13/03/2025 à 11:45, Vignesh Raman a écrit : Hi Maintainers, Hi Vignesh, Thanks for the report. On my setup, this test passed, and the

Re: [PATCH v5 1/6] PCI/IOV: Restore VF resizable BAR state after reset

2025-03-17 Thread Michał Winiarski
On Thu, Mar 13, 2025 at 11:50:37AM +0200, Ilpo Järvinen wrote: > On Thu, 13 Mar 2025, Ilpo Järvinen wrote: > > > On Wed, 12 Mar 2025, Michał Winiarski wrote: > > > > > Similar to regular resizable BAR, VF BAR can also be resized, e.g. by > > > the system firmware or the PCI subsystem itself. > >

Re: [PATCH] drm/bridge: sil-sii8620: Use dev_err_probe()

2025-03-17 Thread Dmitry Baryshkov
On Mon, Mar 17, 2025 at 02:04:56PM +0800, zhang.en...@zte.com.cn wrote: > From: ZhangEnpei > > Replace the open-code with dev_err_probe() to simplify the code. > > Signed-off-by: ZhangEnpei > --- > drivers/gpu/drm/bridge/sil-sii8620.c | 9 +++-- > 1 file changed, 3 insertions(+), 6 deletio

Re: [PATCH v2 4/6] drm/panfrost: Add support for AARCH64_4K page table format

2025-03-17 Thread AngeloGioacchino Del Regno
Il 14/03/25 18:38, Ariel D'Alessandro ha scritto: Currently, Panfrost only supports MMU configuration in "LEGACY" (as Bifrost calls it) mode, a (modified) version of LPAE "Large Physical Address Extension", which in Linux we've called "mali_lpae". This commit adds support for conditionally enabl

Re: [PATCH -next] drm/i915/display: Fix build error without DRM_FBDEV_EMULATION

2025-03-17 Thread Thomas Zimmermann
Am 15.03.25 um 13:01 schrieb Yue Haibing: In file included from : ./drivers/gpu/drm/i915/display/intel_fbdev.h: In function ‘intel_fbdev_framebuffer’: ./drivers/gpu/drm/i915/display/intel_fbdev.h:32:16: error: ‘NULL’ undeclared (first use in this function) 32 | return NULL;

Re: [PATCH v2 2/6] drm/panfrost: Use GPU_MMU_FEATURES_VA_BITS/PA_BITS macros

2025-03-17 Thread AngeloGioacchino Del Regno
Il 14/03/25 18:38, Ariel D'Alessandro ha scritto: As done in panthor, define and use these GPU_MMU_FEATURES_* macros, which makes code easier to read and reuse. Signed-off-by: Ariel D'Alessandro Reviewed-by: Boris Brezillon Reviewed-by: Steven Price Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v2 3/6] drm/panfrost: Set HW_FEATURE_AARCH64_MMU feature flag on Bifrost models

2025-03-17 Thread AngeloGioacchino Del Regno
Il 14/03/25 18:38, Ariel D'Alessandro ha scritto: Set this feature flag on all Mali Bifrost platforms as the MMU supports AARCH64 4K page table format. Signed-off-by: Ariel D'Alessandro Reviewed-by: Boris Brezillon Reviewed-by: Steven Price Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v2 6/6] drm/panfrost: Force AARCH64_4K page table format on MediaTek MT8192

2025-03-17 Thread AngeloGioacchino Del Regno
Il 14/03/25 18:38, Ariel D'Alessandro ha scritto: MediaTek MT8192 SoC has an ARM Mali-G57 MC5 GPU (Valhall-JM). Now that Panfrost supports AARCH64_4K page table format, let's enable it on this SoC. Running glmark2-es2-drm [0] benchmark, reported the same performance score on both modes Mali LPAE

[Bug 219888] amdgpu: Oops connecting HDMI/DVI/DP on DCE6

2025-03-17 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=219888 Alexandre Demers (alexandre.f.dem...@gmail.com) changed: What|Removed |Added Summary|amdgpu: Oops connecting |amdgpu:

RE: [PATCH v8 1/3] drm/plane: Add new plane property IN_FORMATS_ASYNC

2025-03-17 Thread Borah, Chaitanya Kumar
> -Original Message- > From: Murthy, Arun R > Sent: Wednesday, March 12, 2025 6:39 PM > To: dri-devel@lists.freedesktop.org; intel-...@lists.freedesktop.org; intel- > x...@lists.freedesktop.org > Cc: Borah, Chaitanya Kumar ; > 20250219093211.4059187-1-arun.r.mur...@intel.com; > 202503110

RE: [PATCH v8 3/3] drm/i915/display: Add i915 hook for format_mod_supported_async

2025-03-17 Thread Borah, Chaitanya Kumar
> -Original Message- > From: Murthy, Arun R > Sent: Wednesday, March 12, 2025 6:39 PM > To: dri-devel@lists.freedesktop.org; intel-...@lists.freedesktop.org; intel- > x...@lists.freedesktop.org > Cc: Borah, Chaitanya Kumar ; > 20250219093211.4059187-1-arun.r.mur...@intel.com; > 202503110

Re: [PATCH] drm/panel/synaptics-r63353: Use _multi variants

2025-03-17 Thread Neil Armstrong
On 16/03/2025 18:40, Anusha Srivatsa wrote: On Fri, Mar 14, 2025 at 10:20 AM Doug Anderson mailto:diand...@chromium.org>> wrote: Hi, On Thu, Mar 13, 2025 at 9:47 PM Anusha Srivatsa mailto:asriv...@redhat.com>> wrote: > > @@ -181,24 +162,15 @@ static int r63353_panel_prepare(

Re: [PATCH] drm/rockchip: dw_hdmi_qp: Fix io init for dw_hdmi_qp_rockchip_resume

2025-03-17 Thread Sebastian Reichel
Hi, On Mon, Mar 17, 2025 at 04:20:39PM +0800, Andy Yan wrote: > From: Andy Yan > > Use cfg->ctrl_ops->io_init callback make it work for all platform. > > Fixes: 3f60dbd40d3f ("drm/rockchip: dw_hdmi_qp: Add platform ctrl callback") > Signed-off-by: Andy Yan > --- It also gets rid of code dupli

Re: [PATCH RFC 2/2] drm/panel/panel-simple: Use the new allocation in place of devm_kzalloc()

2025-03-17 Thread Neil Armstrong
On 13/03/2025 01:54, Anusha Srivatsa wrote: Start using the new helper that does the refcounted allocations. Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/panel/panel-simple.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/

Re: [PATCH v6 03/10] optee: account for direction while converting parameters

2025-03-17 Thread Jens Wiklander
Hi Sumit, On Thu, Mar 13, 2025 at 11:41 AM Sumit Garg wrote: > > Hi Jens, > > On Wed, Mar 05, 2025 at 02:04:09PM +0100, Jens Wiklander wrote: > > The OP-TEE backend driver has two internal function pointers to convert > > between the subsystem type struct tee_param and the OP-TEE type struct > >

Re: [PATCH] MAINTAINERS: update Microchip's Atmel-HLCDC driver maintainers

2025-03-17 Thread Hari.PrasathGE
Hello, On 6/20/24 7:43 PM, Boris Brezillon wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Thu, 20 Jun 2024 15:28:56 +0530 > Manikandan Muralidharan wrote: > >> Drop Sam Ravnborg and Boris Brezillon as they are no longer interested i

Re: [PATCH 4/4] drm/panthor: Display heap chunk entries in DebugFS GEMS file

2025-03-17 Thread Boris Brezillon
On Sun, 16 Mar 2025 21:51:35 + Adrián Larumbe wrote: > Expand the driver's DebugFS GEMS file to display entries for the heap > chunks' GEM objects, both those allocated at heap creation time through an > ioctl(), or in response to a tiler OOM event. > > Signed-off-by: Adrián Larumbe > --- >

[PATCH] drm/rockchip: dw_hdmi_qp: Fix io init for dw_hdmi_qp_rockchip_resume

2025-03-17 Thread Andy Yan
From: Andy Yan Use cfg->ctrl_ops->io_init callback make it work for all platform. Fixes: 3f60dbd40d3f ("drm/rockchip: dw_hdmi_qp: Add platform ctrl callback") Signed-off-by: Andy Yan --- .../gpu/drm/rockchip/dw_hdmi_qp-rockchip.c| 23 +++ 1 file changed, 3 insertions(+), 2

Re: [PATCH v3 00/11] backlight, lcd, led: Remove fbdev dependencies

2025-03-17 Thread Thomas Zimmermann
Hi Am 13.03.25 um 17:51 schrieb Lee Jones: On Thu, 06 Mar 2025, Thomas Zimmermann wrote: This series removes the remaining dependencies on fbdev from the backlight, lcd and led subsystems. Each depends on fbdev events to track display state. Make fbdev inform each subsystem via a dedicated int

Re: [PATCH v5 3/6] PCI: Allow IOV resources to be resized in pci_resize_resource()

2025-03-17 Thread Michał Winiarski
On Thu, Mar 13, 2025 at 11:56:07AM +0200, Ilpo Järvinen wrote: > On Wed, 12 Mar 2025, Michał Winiarski wrote: > > > Similar to regular resizable BAR, VF BAR can also be resized. > > > > The structures are very similar, which means we can reuse most of the > > implementation. > > > > Extend the p

Re: [PATCH 2/4] drm/panthor: Add driver IOCTL for setting BO labels

2025-03-17 Thread Boris Brezillon
On Sun, 16 Mar 2025 21:51:33 + Adrián Larumbe wrote: > Allow UM to label a BO for which it possesses a DRM handle. > > Signed-off-by: Adrián Larumbe > --- > drivers/gpu/drm/panthor/panthor_drv.c | 31 +++ > include/uapi/drm/panthor_drm.h| 14 >

[Bug 219888] amdgpu: Oops connecting HDMI/DVI/DP on HD 7850 (Pitcairn)

2025-03-17 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=219888 --- Comment #7 from Alexandre Demers (alexandre.f.dem...@gmail.com) --- DCE6's dce60_tg_funcs structure is missing .is_two_pixels_per_container = dce110_is_two_pixels_per_container It seems the fix is already in 6.14-rc7. -- You may reply to th

Re: [PATCH v4 3/6] dt-bindings: drm/msm/gpu: Document AON clock for A505/A506/A510

2025-03-17 Thread Krzysztof Kozlowski
On Sat, Mar 15, 2025 at 03:57:37PM +0100, Barnabás Czémán wrote: > From: Adam Skladowski > > Adreno 505 (MSM8937), Adreno 506(MSM8953) and Adreno 510(MSM8976) > require Always-on branch clock to be enabled, describe it. > > Signed-off-by: Adam Skladowski > [reword commit, move alwayson on the f

Re: [PATCH 3/5] drm: panel-orientation-quirks: Add OneXPlayer F1Pro quirk

2025-03-17 Thread Antheas Kapenekakis
On Mon, 17 Mar 2025 at 10:15, Hans de Goede wrote: > > Hi, > > On 22-Feb-25 17:43, Antheas Kapenekakis wrote: > > The OneXPlayer F1Pro has a 144hz 1920x1080 portrait OLED panel. > > Add a quirk to correct the panel portrait orientation. In addition, > > it comes with a red limited edition variant

Re: [PATCH 5/5] drm: panel-orientation-quirks: Add Zotac Gaming Zone quirk

2025-03-17 Thread Hans de Goede
Hi, On 22-Feb-25 17:43, Antheas Kapenekakis wrote: > The Zotac Gaming Zone handheld features a 1080p portrait OLED screen. > Add the rotation to the panel orientation quirks. > > Signed-off-by: Antheas Kapenekakis > --- > drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++ > 1 file chang

Re: [RFC PATCH 00/19] drm, drm/xe: Multi-device GPUSVM

2025-03-17 Thread Thomas Hellström
On Thu, 2025-03-13 at 13:57 +0100, Christian König wrote: > Am 13.03.25 um 13:50 schrieb Thomas Hellström: > > Hi, Christian > > > > On Thu, 2025-03-13 at 11:19 +0100, Christian König wrote: > > > Am 12.03.25 um 22:03 schrieb Thomas Hellström: > > > > This RFC implements and requests comments for

Re: [PATCH 5/5] drm: panel-orientation-quirks: Add Zotac Gaming Zone quirk

2025-03-17 Thread Antheas Kapenekakis
On Mon, 17 Mar 2025 at 10:20, Hans de Goede wrote: > > Hi, > > On 22-Feb-25 17:43, Antheas Kapenekakis wrote: > > The Zotac Gaming Zone handheld features a 1080p portrait OLED screen. > > Add the rotation to the panel orientation quirks. > > > > Signed-off-by: Antheas Kapenekakis > > --- > > dri

Re: [PATCH 5/5] drm: panel-orientation-quirks: Add Zotac Gaming Zone quirk

2025-03-17 Thread Antheas Kapenekakis
On Mon, 17 Mar 2025 at 10:23, Antheas Kapenekakis wrote: > > On Mon, 17 Mar 2025 at 10:20, Hans de Goede wrote: > > > > Hi, > > > > On 22-Feb-25 17:43, Antheas Kapenekakis wrote: > > > The Zotac Gaming Zone handheld features a 1080p portrait OLED screen. > > > Add the rotation to the panel orient

[PATCH 00/15] drm: Do not use import_attach in drivers

2025-03-17 Thread Thomas Zimmermann
Avoid struct drm_gem_object.import_attach in many DRM drivers that use it to get the object's dma-buf or test for an imported buffer. The helper drm_gem_is_imported() tests if a GEM object's buffer has been imported into the driver. The corresponding dma-buf is referenced by the object itself. Bot

[PATCH 04/15] drm/exynos: Test for imported buffers with drm_gem_is_imported()

2025-03-17 Thread Thomas Zimmermann
Instead of testing import_attach for imported GEM buffers, invoke drm_gem_is_imported() to do the test. The helper tests the dma_buf itself while import_attach is just an artifact of the import. Prepares to make import_attach optional. Signed-off-by: Thomas Zimmermann Cc: Inki Dae Cc: Seung-Woo

[PATCH 06/15] drm/msm: Test for imported buffers with drm_gem_is_imported()

2025-03-17 Thread Thomas Zimmermann
Instead of testing import_attach for imported GEM buffers, invoke drm_gem_is_imported() to do the test. The helper tests the dma_buf itself while import_attach is just an artifact of the import. Prepares to make import_attach optional. Signed-off-by: Thomas Zimmermann Cc: Rob Clark Cc: Abhinav K

[PATCH 08/15] drm/panfrost: Test for imported buffers with drm_gem_is_imported()

2025-03-17 Thread Thomas Zimmermann
Instead of testing import_attach for imported GEM buffers, invoke drm_gem_is_imported() to do the test. The helper tests the dma_buf itself while import_attach is just an artifact of the import. Prepares to make import_attach optional. Signed-off-by: Thomas Zimmermann Cc: Boris Brezillon Cc: Rob

  1   2   >