[PATCH v2] drm/mgag200: fix division by zero in mgag200_g200_pixpllc_atomic_check()

2025-03-08 Thread Vitaliy Shevtsov
There is a small chance to perform a division by zero. According to the driver code, clock may have a value less than (p_clk_min >> 3). p_clk_min itself may have a value up to 2032000 in case of a BIOS PINS version 5. If this is the case, then f_vco gets the value greater than delta and the condit

Re: [PATCH] drm/panel/synaptics-r63353: Use _multi variants

2025-03-08 Thread Anusha Srivatsa
On Thu, Mar 6, 2025 at 11:29 AM Dmitry Baryshkov < dmitry.barysh...@linaro.org> wrote: > On Thu, 6 Mar 2025 at 17:10, Anusha Srivatsa wrote: > > > > > > > > On Thu, Mar 6, 2025 at 4:31 AM Maxime Ripard wrote: > >> > >> Hi Anusha, > >> > >> On Wed, Mar 05, 2025 at 07:01:41PM -0500, Anusha Srivats

Re: [PATCH RESEND] video: au1100fb: Move a variable assignment behind a null pointer check in au1100fb_setmode()

2025-03-08 Thread Helge Deller
On 3/3/25 10:19, Uwe Kleine-König wrote: Hello, On Sun, Mar 02, 2025 at 07:02:12PM +0100, Markus Elfring wrote: From: Markus Elfring Date: Thu, 13 Apr 2023 21:35:36 +0200 The address of a data structure member was determined before a corresponding null pointer check in the implementation of t

Re: [PATCH] drm/panel/synaptics-r63353: Use _multi variants

2025-03-08 Thread Maxime Ripard
Hi Anusha, On Wed, Mar 05, 2025 at 07:01:41PM -0500, Anusha Srivatsa wrote: > Move away from using deprecated API and use _multi > variants if available. Use mipi_dsi_msleep() > and mipi_dsi_usleep_range() instead of msleep() > and usleep_range() respectively. > > Used Coccinelle to find the mult

[PATCH v2] accel/qaic: Fix integer overflow in qaic_validate_req()

2025-03-08 Thread Dan Carpenter
These are u64 variables that come from the user via qaic_attach_slice_bo_ioctl(). Use check_add_overflow() to ensure that the math doesn't have an integer wrapping bug. Cc: sta...@vger.kernel.org Fixes: ff13be830333 ("accel/qaic: Add datapath") Signed-off-by: Dan Carpenter --- v2: use check_add_

Re: [PATCH 1/3] dummycon: only build module if there are users

2025-03-08 Thread Helge Deller
On 2/25/25 17:44, Arnd Bergmann wrote: From: Arnd Bergmann Dummycon is used as a fallback conswitchp for vgacon and fbcon in the VT code, and there are no references to it if all three are disabled, so just leave it out of the kernel image for configurations without those. Signed-off-by: Arnd

Re: [PATCH v5 1/7] bits: split the definition of the asm and non-asm GENMASK()

2025-03-08 Thread David Laight
On Fri, 7 Mar 2025 18:58:08 +0900 Vincent Mailhol wrote: > On 07/03/2025 at 04:23, David Laight wrote: > > On Thu, 06 Mar 2025 20:29:52 +0900 > > Vincent Mailhol via B4 Relay > > wrote: > > > >> From: Vincent Mailhol > >> > >> In an upcoming change, GENMASK() and its friends will indirectly

Re: [PATCH] fbdev: lcdcfb: Register sysfs groups through driver core

2025-03-08 Thread Helge Deller
On 2/19/25 09:44, oushixiong1...@163.com wrote: From: Shixiong Ou [WHY] 1. The driver forgot to call device_remove_file() in sh_mobile_lcdc_overlay_fb_unregister(), and there was no error handling when calling device_create_file() failed. 2. This should probably use device_add_

Re: [PATCH 06/10] drm/msm/mdss: add SAR2130P device configuration

2025-03-08 Thread kernel test robot
Hi Dmitry, kernel test robot noticed the following build errors: [auto build test ERROR on 0a2f889128969dab41861b6e40111aa03dc57014] url: https://github.com/intel-lab-lkp/linux/commits/Dmitry-Baryshkov/dt-bindings-display-msm-dp-controller-describe-SAR2130P/20250308-094544 base

Re: [PATCH 0/1] Refactoring of framebuffer drawing routines

2025-03-08 Thread Helge Deller
On 2/24/25 21:59, Zsolt Kajtar wrote: Proper refactoring of the framebuffer drawing routines. This time it's not only the merging of duplicated code. It isn't half finished either so the various combinations of foreign endianness, pixel reversing, bits per pixel, cpu word sizes and byte order sho

Re: [PATCH 1/1] fbdev: hyperv_fb: Fix hang in kdump kernel when on Hyper-V Gen 2 VMs

2025-03-08 Thread Helge Deller
On 2/19/25 00:01, mhkelle...@gmail.com wrote: From: Michael Kelley Gen 2 Hyper-V VMs boot via EFI and have a standard EFI framebuffer device. When the kdump kernel runs in such a VM, loading the efifb driver may hang because of accessing the framebuffer at the wrong memory address. The scenari

Re: [PATCH 06/10] drm/msm/mdss: add SAR2130P device configuration

2025-03-08 Thread kernel test robot
Hi Dmitry, kernel test robot noticed the following build errors: [auto build test ERROR on 0a2f889128969dab41861b6e40111aa03dc57014] url: https://github.com/intel-lab-lkp/linux/commits/Dmitry-Baryshkov/dt-bindings-display-msm-dp-controller-describe-SAR2130P/20250308-094544 base

[PATCH v3] drm/panel: novatek-nt36523: transition to mipi_dsi wrapped functions

2025-03-08 Thread Tejas Vipin
Changes the novatek-nt36523 panel to use multi style functions for improved error handling. Signed-off-by: Tejas Vipin --- Changes in v3: - Remove mipi_dsi_dual_msleep - Change mipi_dsi_dual_dcs_write_seq_multi to use the same dsi_ctx by swapping the dsi accordingly. Link to v2: h

RE: [PATCH 1/1] fbdev: hyperv_fb: Fix hang in kdump kernel when on Hyper-V Gen 2 VMs

2025-03-08 Thread Michael Kelley
From: Helge Deller Sent: Saturday, March 8, 2025 6:59 PM > > On 2/19/25 00:01, mhkelle...@gmail.com wrote: > > From: Michael Kelley > > [snip] > > > > Reported-by: Thomas Tai > > Fixes: c25a19afb81c ("fbdev/hyperv_fb: Do not clear global screen_info") > > Signed-off-by: Michael Kelley > > ---

Re: [PATCH V2 2/2] drm/vc4: hdmi: Add jack detection to HDMI audio driver

2025-03-08 Thread Maxime Ripard
Hi, On Tue, Mar 04, 2025 at 08:39:12PM +0100, Stefan Wahren wrote: > From: David Turner > > Add ALSA jack detection to the vc4-hdmi audio driver so userspace knows > when to add/remove HDMI audio devices. > > Signed-off-by: David Turner > Signed-off-by: Stefan Wahren > --- > drivers/gpu/drm/

Re: [PATCH v3 4/7] drm/msm/mdp4: use parent_data for LVDS PLL

2025-03-08 Thread Konrad Dybcio
On 27.02.2025 3:25 AM, Dmitry Baryshkov wrote: > Instead of using .parent_names, use .parent_data, which binds parent > clocks by using relative names specified in DT in addition to using global > system clock names. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH 3/5] dt-bindings: display: simple-bridge: Document DPI color encoder

2025-03-08 Thread Maxime Ripard
On Thu, Mar 06, 2025 at 03:02:41PM +0800, Liu Ying wrote: > On 03/06/2025, Rob Herring wrote: > > On Wed, Mar 05, 2025 at 10:35:26AM +0100, Alexander Stein wrote: > >> Hi, > >> > >> Am Dienstag, 4. März 2025, 16:23:20 CET schrieb Rob Herring: > >>> On Tue, Mar 04, 2025 at 06:15:28PM +0800, Liu Ying

Re: [PATCH 2/2] drm: ensure drm headers are self-contained and pass kernel-doc

2025-03-08 Thread Masahiro Yamada
On Wed, Mar 5, 2025 at 10:59 PM Maxime Ripard wrote: > > On Wed, Mar 05, 2025 at 03:05:25AM +0900, Masahiro Yamada wrote: > > > IMO headers should almost invariably be self-contained, instead of > > > putting the burden on their users to include other headers to make it > > > work. It's a PITA in

[PATCH] drm/gma500: Remove unused psb_mmu_virtual_to_pfn

2025-03-08 Thread linux
From: "Dr. David Alan Gilbert" psb_mmu_virtual_to_pfn() was added in 2011 by commit 8c8f1c958ab5 ("gma500: introduce the GTT and MMU handling logic") but hasn't been used. Remove it. Signed-off-by: Dr. David Alan Gilbert --- drivers/gpu/drm/gma500/mmu.c | 41 --

[PATCH] drm/gma500/psb_intel_modes: Remove unused psb_intel_ddc_probe

2025-03-08 Thread linux
From: "Dr. David Alan Gilbert" psb_intel_ddc_probe() was added in 2011 by commit 89c78134cc54 ("gma500: Add Poulsbo support") but has remained unused (probably because drm_get_edid is used instead). Remove it. Signed-off-by: Dr. David Alan Gilbert --- drivers/gpu/drm/gma500/psb_intel_drv.h

Re: [PATCH] drm/nouveau: fix hibernate on disabled GPU

2025-03-08 Thread Lyude Paul
Reviewed-by: Lyude Paul I will push to drm-misc in a moment, thank you for the patch! On Tue, 2025-03-04 at 22:08 +0100, chr[] wrote: > Hibernate bricks the machine if a discrete GPU was disabled via > > echo IGD > /sys/kernel/debug/vgaswitcheroo/switch > > The freeze and thaw handler lacks ch

Re: [PATCH] fbdev: fsl-diu-fb: add missing device_remove_file()

2025-03-08 Thread Helge Deller
On 2/8/25 11:23, oushixiong1...@163.com wrote: From: Shixiong Ou Call device_remove_file() when driver remove. Signed-off-by: Shixiong Ou --- drivers/video/fbdev/fsl-diu-fb.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/video/fbdev/fsl-diu-fb.c b/drivers/video/fbdev/fsl-

Re: [PATCH 2/2] dt-bindings: display: mitsubishi,aa104xd12: Adjust allowed and required properties

2025-03-08 Thread Rob Herring (Arm)
On Tue, 25 Feb 2025 15:03:15 -0600, Rob Herring (Arm) wrote: > The Mitsubishi aa104xd12 panel requires an external backlight driver > circuit, so allow the "backlight" property. > > There are users of this panel without a vcc-supply, so it shouldn't be > required. > > Signed-off-by: Rob Herring

Re: [PATCH 2/6] drm/bridge: synopsys: Add DW DPTX Controller support library

2025-03-08 Thread FUKAUMI Naoki
Hi Andy, On 2/23/25 20:30, Andy Yan wrote: (snip) +struct dw_dp *dw_dp_bind(struct device *dev, struct drm_encoder *encoder, +const struct dw_dp_plat_data *plat_data) +{ + struct platform_device *pdev = to_platform_device(dev); + struct dw_dp *dp; + stru

Re: [PATCH 6/6] arm64: dts: rockchip: Enable DisplayPort for rk3588s Cool Pi 4B

2025-03-08 Thread FUKAUMI Naoki
Hi Andy, On 2/23/25 20:30, Andy Yan wrote: From: Andy Yan Enable the Mini DisplayPort on this board. Note that ROCKCHIP_VOP2_EP_DP0 is defined as 10 in dt-binding header, but it will trigger a dtc warning like "graph node unit address error, expected "a"" if we use it directly after endpoint,

Re: [PATCH v6 1/7] bits: split the definition of the asm and non-asm GENMASK()

2025-03-08 Thread Vincent Mailhol
On 08/03/2025 at 02:42, Andy Shevchenko wrote: > On Sat, Mar 08, 2025 at 01:48:48AM +0900, Vincent Mailhol via B4 Relay wrote: >> From: Vincent Mailhol >> >> In an upcoming change, GENMASK() and its friends will indirectly >> depend on sizeof() which is not available in asm. >> >> Instead of addin

[PATCH v2 5/6] drm/v3d: Use V3D_SMS registers for power on/off and reset on V3D 7.x

2025-03-08 Thread Maíra Canal
In addition to the standard reset controller, V3D 7.x requires configuring the V3D_SMS registers for proper power on/off and reset. Add the new registers to `v3d_regs.h` and ensure they are properly configured during device probing, removal, and reset. This change fixes GPU reset issues on the Ras

[PATCH v2 6/6] dt-bindings: gpu: Add V3D driver maintainer as DT maintainer

2025-03-08 Thread Maíra Canal
As established in commit 89d04995f76c ("MAINTAINERS: Drop Emma Anholt from all M lines."), Emma is no longer active in the Linux kernel and dropped the V3D maintainership. Therefore, remove Emma as one of the DT maintainers and add the current V3D driver maintainer. Cc: Krzysztof Kozlowski Cc: Co

[PATCH] drm/msm/dpu: reorder pointer operations after sanity checks to avoid NULL deref

2025-03-08 Thread Qasim Ijaz
_dpu_encoder_trigger_start dereferences "struct dpu_encoder_phys *phys" before the sanity checks which can lead to a NULL pointer dereference if phys is NULL. Fix this by reordering the dereference after the sanity checks. Signed-off-by: Qasim Ijaz Fixes: 8144d17a81d9 ("drm/msm/dpu: Skip trig

Re: [PATCH v3 2/2] mfd: lm3533: convert to use OF

2025-03-08 Thread Jonathan Cameron
On Wed, 5 Mar 2025 16:18:38 +0200 Svyatoslav Ryhel wrote: > ср, 5 бер. 2025 р. о 15:45 Jonathan Cameron пише: > > > > On Fri, 28 Feb 2025 11:30:51 +0200 > > Svyatoslav Ryhel wrote: > > > > > пт, 28 лют. 2025 р. о 10:59 Lee Jones пише: > > > > > > > > On Mon, 24 Feb 2025, Svyatoslav Ryhel w

[bug report] drm/gpusvm: Add support for GPU Shared Virtual Memory

2025-03-08 Thread Dan Carpenter
Hello Matthew Brost, Commit 99624bdff867 ("drm/gpusvm: Add support for GPU Shared Virtual Memory") from Mar 5, 2025 (linux-next), leads to the following Smatch static checker warning: drivers/gpu/drm/drm_gpusvm.c:794 drm_gpusvm_range_alloc() error: 'range' dereferencing possible E

Re: [PATCH v6 4/7] drm/i915: Convert REG_GENMASK*() to fixed-width GENMASK_U*()

2025-03-08 Thread Vincent Mailhol
On 08/03/2025 at 02:54, Andy Shevchenko wrote: > On Sat, Mar 08, 2025 at 01:48:51AM +0900, Vincent Mailhol via B4 Relay wrote: >> From: Lucas De Marchi >> >> Now that include/linux/bits.h implements fixed-width GENMASK_U*(), use >> them to implement the i915/xe specific macros. Converting each dri

Re: [PATCH v6 0/7] bits: Fixed-type GENMASK_U*() and BIT_U*()

2025-03-08 Thread Vincent Mailhol
On 08/03/2025 at 02:50, Andy Shevchenko wrote: > On Fri, Mar 07, 2025 at 12:48:36PM -0500, Yury Norov wrote: >> On Fri, Mar 07, 2025 at 07:43:57PM +0200, Andy Shevchenko wrote: >>> On Fri, Mar 07, 2025 at 12:18:02PM -0500, Yury Norov wrote: No rush, please allow your reviewers a week or two be

Re: [PATCH v5 1/7] bits: split the definition of the asm and non-asm GENMASK()

2025-03-08 Thread Vincent Mailhol
On 06/03/2025 at 23:34, Lucas De Marchi wrote: > On Thu, Mar 06, 2025 at 08:29:52PM +0900, Vincent Mailhol via B4 Relay > wrote: (...) > it seems we now have 1 inconsistency that we comment why > GENMASK_U128() is not available in asm, but we don't comment why > GENMASK_INPUT_CHECK() is not avail

[PATCH v3 01/11] fbdev: Rework fb_blank()

2025-03-08 Thread Thomas Zimmermann
Reimplement fb_blank() to return early on errors. No functional changes. Prepares the helper for tracking the blanking state in struct fb_info. Signed-off-by: Thomas Zimmermann --- drivers/video/fbdev/core/fbmem.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --

Re: [PATCH RFC v2 0/7] drm/display: dp: add new DPCD access functions

2025-03-08 Thread Jani Nikula
On Sat, 01 Mar 2025, Dmitry Baryshkov wrote: > Existing DPCD access functions return an error code or the number of > bytes being read / write in case of partial access. However a lot of > drivers either (incorrectly) ignore partial access or mishandle error > codes. In other cases this results in

[PATCH v2 3/6] drm/v3d: Associate a V3D tech revision to all supported devices

2025-03-08 Thread Maíra Canal
The V3D driver currently determines the GPU tech version (33, 41...) by reading a register. This approach has worked so far since this information wasn’t needed before powering on the GPU. V3D 7.1 introduces new registers that must be written to power on the GPU, requiring us to know the V3D versi

[PATCH v2 4/6] dt-bindings: gpu: v3d: Add SMS to the registers' list

2025-03-08 Thread Maíra Canal
V3D 7.1 exposes a new register block, called V3D_SMS. As BCM2712 has a V3D 7.1 core, add a new register item to the list. Similar to the GCA and bridge register, SMS is optional and should only be added for V3D 7.1 variants. In order to enforce per-SoC register rules, add per-compatible restrictio

[PATCH v2 1/6] drm/v3d: Don't run jobs that have errors flagged in its fence

2025-03-08 Thread Maíra Canal
The V3D driver still relies on `drm_sched_increase_karma()` and `drm_sched_resubmit_jobs()` for resubmissions when a timeout occurs. The function `drm_sched_increase_karma()` marks the job as guilty, while `drm_sched_resubmit_jobs()` sets an error (-ECANCELED) in the DMA fence of that guilty job.

[PATCH v2 2/6] drm/v3d: Set job pointer to NULL when the job's fence has an error

2025-03-08 Thread Maíra Canal
Similar to commit e4b5ccd392b9 ("drm/v3d: Ensure job pointer is set to NULL after job completion"), ensure the job pointer is set to `NULL` when a job's fence has an error. Failing to do so can trigger kernel warnings in specific scenarios, such as: 1. v3d_csd_job_run() assigns `v3d->csd_job = job

[PATCH] drm/mgag200: fix division by zero in mgag200_g200_pixpllc_atomic_check()

2025-03-08 Thread Vitaliy Shevtsov
There is a small chance to perform a division by zero. According to the driver code, clock may have a value less than (p_clk_min >> 3). p_clk_min itself may have a value up to 2032000 in case of a BIOS PINS version 5. If this is the case, then f_vco gets the value greater than delta and the condit

Re: [v5,0/2,RESEND] Add driver for Novatek NT35596S panel

2025-03-08 Thread David Heidelberg
Could you please resend the series again? Consider driver Acked-by: David Heidelberg and device-tree bindings: Reviewed-by: David Heidelberg I guess second resend could be more lucky then the 1st one! Thank you David

Re: [PATCH v4 00/14] drm/vkms: Allow to configure device

2025-03-08 Thread Maxime Ripard
On Tue, Mar 04, 2025 at 10:43:12AM +0100, Louis Chauvet wrote: > > > Le 18/02/2025 à 11:12, José Expósito a écrit : > > Hi everyone, > > > > In preparation for ConfigFS support, a flexible way to configure VKMS > > device(s) > > is required. > > This series adds the required APIs to create a co

Re: [PATCH v3 06/11] backlight: Replace fb events with a dedicated function call

2025-03-08 Thread kernel test robot
e: https://git.kernel.org/pub/scm/linux/kernel/git/lee/backlight.git for-backlight-next patch link: https://lore.kernel.org/r/20250306140947.580324-7-tzimmermann%40suse.de patch subject: [PATCH v3 06/11] backlight: Replace fb events with a dedicated function call config: i386-randconfig-005-202503

Re: [PATCH v3 06/11] backlight: Replace fb events with a dedicated function call

2025-03-08 Thread kernel test robot
t.git for-backlight-next patch link: https://lore.kernel.org/r/20250306140947.580324-7-tzimmermann%40suse.de patch subject: [PATCH v3 06/11] backlight: Replace fb events with a dedicated function call config: x86_64-randconfig-005-20250308 (https://download.01.org/0day-ci/archive/20250308/20

Re: [PATCH 07/10] drm/msm/dsi/phy: add configuration for SAR2130P

2025-03-08 Thread Konrad Dybcio
On 8.03.2025 2:42 AM, Dmitry Baryshkov wrote: > From: Dmitry Baryshkov > > Qualcomm SAR2130P requires slightly different setup for the DSI PHY. It > is a 5nm PHY (like SM8450), so supplies are the same, but the rest of > the configuration is the same as SM8550 DSI PHY. > > Signed-off-by: Dmitry

[PATCH v5 7/7] test_bits: add tests for BIT_U*()

2025-03-08 Thread Vincent Mailhol via B4 Relay
From: Vincent Mailhol Add some additional tests in lib/test_bits.c to cover the expected results of the fixed type BIT_U*() macros. Signed-off-by: Vincent Mailhol --- Changelog v4 -> v5: - BIT_U8()/BIT_U16() are now back to u8/u16. v3 -> v4: - New patch. --- lib/test_bits.c | 1

Re: [PATCH v3 1/4] drm/i915: Skip harmful unregister steps if not registered

2025-03-08 Thread Janusz Krzysztofik
Hi Jani, On Thursday, 6 March 2025 11:25:52 CET Jani Nikula wrote: > On Wed, 05 Mar 2025, Janusz Krzysztofik > wrote: > > Starting with commit ec3e00b4ee27 ("drm/i915: stop registering if > > drm_dev_register() fails"), we return from i915_driver_register() > > immediately if drm_dev_register()

Re: [PATCH v6 3/7] bits: introduce fixed-type BIT_U*()

2025-03-08 Thread Vincent Mailhol
On 08/03/2025 at 02:49, Andy Shevchenko wrote: > On Fri, Mar 07, 2025 at 07:48:01PM +0200, Andy Shevchenko wrote: >> On Sat, Mar 08, 2025 at 01:48:50AM +0900, Vincent Mailhol via B4 Relay wrote: > > ... > >>> /* >>> * Missing asm support >>> * >>> - * GENMASK_U*() depends on BITS_PER_TYPE()

Re: Time for drm-ci-next?

2025-03-08 Thread Rob Clark
On Fri, Mar 7, 2025 at 7:14 PM Dmitry Baryshkov wrote: > > On Fri, Mar 07, 2025 at 09:26:54AM -0800, Rob Clark wrote: > > On Fri, Mar 7, 2025 at 9:00 AM Maxime Ripard wrote: > > > > > > On Fri, Mar 07, 2025 at 08:42:46AM -0800, Rob Clark wrote: > > > > On Tue, Sep 24, 2024 at 5:27 AM Vignesh Rama

Re: [PATCH] drm/panthor: Make the timeout per-queue instead of per-job

2025-03-08 Thread kernel test robot
: b72f66f22c0e39ae6684c43fead774c13db24e73 patch link: https://lore.kernel.org/r/2025030716.173494-1-ashley.smith%40collabora.com patch subject: [PATCH] drm/panthor: Make the timeout per-queue instead of per-job config: i386-buildonly-randconfig-004-20250308 (https://download.01.org/0day-ci/archive

Re: [PATCH] drm/msm/dpu: Clear perf params before calculating bw

2025-03-08 Thread Abhinav Kumar
On 3/5/2025 7:46 PM, Jessica Zhang wrote: To prevent incorrect BW calculation, zero out dpu_core_perf_params before it is passed into dpu_core_perf_aggregate(). Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletio