Re: [PATCH] gpu: drm_dp_cec: fix broken CEC adapter properties check

2025-01-29 Thread Dmitry Baryshkov
On Wed, Jan 29, 2025 at 10:51:48AM +0100, Hans Verkuil wrote: > If the hotplug detect of a display is low for longer than one second > (configurable through drm_dp_cec_unregister_delay), then the CEC adapter > is unregistered since we assume the display was disconnected. If the > HPD went low for l

Re: [PATCH v2 2/5] misc: fastrpc: Introduce context params structure

2025-01-29 Thread Dmitry Baryshkov
On Wed, Jan 29, 2025 at 10:27:45AM +0530, Ekansh Gupta wrote: > > > > On 1/27/2025 9:13 PM, Dmitry Baryshkov wrote: > > On Mon, Jan 27, 2025 at 10:12:36AM +0530, Ekansh Gupta wrote: > >> Add structure to invoke context parameterms. This structure is meant > > Nit: for invoke context parameters.

Re: [PATCH v2 5/5] misc: fastrpc: Modify context id mask to support polling mode

2025-01-29 Thread Dmitry Baryshkov
On Wed, Jan 29, 2025 at 11:13:05AM +0530, Ekansh Gupta wrote: > > > > On 1/29/2025 5:00 AM, Dmitry Baryshkov wrote: > > On Mon, Jan 27, 2025 at 10:12:39AM +0530, Ekansh Gupta wrote: > >> DSP needs last 4 bits of context id to be 0 for polling mode to be > >> supported as setting of last 8 is int

[PATCH 01/13] drm/vkms: Extract vkms_connector header

2025-01-29 Thread José Expósito
Up until now, the logic to manage connectors was in vkms_output.c. Since more options will be added to connectors in the future, extract the code to its own file. Refactor, no functional changes. Signed-off-by: José Expósito --- drivers/gpu/drm/vkms/Makefile | 3 +- drivers/gpu/drm/vk

Re: [PATCH] gpu: drm_dp_cec: fix broken CEC adapter properties check

2025-01-29 Thread Hans Verkuil
On 29/01/2025 10:51, Hans Verkuil wrote: > If the hotplug detect of a display is low for longer than one second > (configurable through drm_dp_cec_unregister_delay), then the CEC adapter > is unregistered since we assume the display was disconnected. If the > HPD went low for less than one second,

Re: [PATCH v5 04/10] drm/bridge: add documentation of refcounted bridges

2025-01-29 Thread Dmitry Baryshkov
On Wed, Jan 29, 2025 at 12:51:53PM +0100, Luca Ceresoli wrote: > Hi Maxime, > > On Tue, 28 Jan 2025 15:49:23 +0100 > Maxime Ripard wrote: > > > Hi, > > > > On Wed, Jan 22, 2025 at 05:12:30PM +0100, Luca Ceresoli wrote: > > > On Wed, 8 Jan 2025 17:02:04 +0100 > > > Maxime Ripard wrote: > > > >

[PATCH v2 3/4] drm/tests: hdmi: Reorder DRM entities variables assignment

2025-01-29 Thread Maxime Ripard
The tests all deviate slightly in how they assign their local pointers to DRM entities. This makes refactoring pretty difficult, so let's just move the assignment as soon as the entities are allocated. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c | 81 +

[PATCH v2 1/4] drm/tests: hdmi: Fix WW_MUTEX_SLOWPATH failures

2025-01-29 Thread Maxime Ripard
The light_up_connector helper function in the HDMI infrastructure unit tests uses drm_atomic_set_crtc_for_connector(), but fails when it returns an error. This function can return EDEADLK though if the sequence needs to be restarted, and WW_MUTEX_SLOWPATH is meant to test that we handle it properl

[PATCH v2 2/4] drm/tests: hdmi: Remove redundant assignments

2025-01-29 Thread Maxime Ripard
Some tests have the drm pointer assigned multiple times to the same value. Drop the redundant assignments. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c

[PATCH v2 0/4] drm/tests: Fix locking issues (kind of)

2025-01-29 Thread Maxime Ripard
ts: hdmi: Reorder DRM entities variables assignment drm/tests: hdmi: Fix recursive locking drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c | 200 +++-- 1 file changed, 103 insertions(+), 97 deletions(-) --- base-commit: e2a81c0cd7de6cb063058be304b18f200c64802b change-id

[PATCH v2 4/4] drm/tests: hdmi: Fix recursive locking

2025-01-29 Thread Maxime Ripard
The find_preferred_mode() functions takes the mode_config mutex, but due to the order most tests have, is called with the crtc_ww_class_mutex taken. This raises a warning for a circular dependency when running the tests with lockdep. Reorder the tests to call find_preferred_mode before the acquire

[PATCH v2] drm/vkms: Add support for ABGR8888 pixel format

2025-01-29 Thread Paz Zcharya
From: Paz Zcharya Add support for pixel format ABGR, which is the default format on Android devices. This will allow us to use VKMS as the default display driver in Android Emulator (Cuttlefish) and increase VKMS adoption. Signed-off-by: Paz Zcharya --- Changes in v2: - Rebased on top of

Re: [PATCH] drm/vkms: Add support for ABGR8888 pixel format

2025-01-29 Thread Paz Zcharya
On Wed, Jan 29, 2025 at 11:18:26AM +0100, Louis Chauvet wrote: > And I just noticed that "changes in v2" is in the commit log. It should > not be there. > > To add a changelog, you must put it after ---, so in your case your commit > should be something like: > > drm/vkms: Add support for

Re: lockdep and ww mutex debug interactions in hdmi tests

2025-01-29 Thread Maxime Ripard
se+0x62/0xd0 [kunit] > [ 50.788662] ? lockdep_hardirqs_on+0x7c/0x100 > [ 50.788668] ? _raw_spin_unlock_irqrestore+0x39/0x70 > [ 50.788675] kunit_generic_run_threadfn_adapter+0x1e/0x40 [kunit] > [ 50.788684] kthread+0xef/0x120 > [ 50.788688] ? __pfx_kthread+0x10/0x10 > [ 50.788693] ret_from_fork+0x31/0x50 > [ 50.788698] ? __pfx_kthread+0x10/0x10 > [ 50.788703] ret_from_fork_asm+0x1a/0x30 > [ 50.788711] Yeah, sorry. I finally got the time to look into it a bit, and it's (almost) fixed now: https://lore.kernel.org/dri-devel/20250129-test-kunit-v2-0-fe59c4380...@kernel.org/ Maxime signature.asc Description: PGP signature

Re: [PATCH 14/14] Documentation: Update the todo

2025-01-29 Thread Maxime Ripard
Hi Thomas, On Wed, Jan 29, 2025 at 02:06:15PM +0100, Thomas Zimmermann wrote: > Am 28.01.25 um 23:29 schrieb Anusha Srivatsa: > > Remove the TODO now that this series addresses > > the changes needed. > > While your series is fine, this TODO item is unrelated. It's about various > ancient fbdev d

Re: [PATCH RFC] drm/msm/dsi/phy: Program clock inverters in correct register

2025-01-29 Thread Dmitry Baryshkov
On Wed, Jan 29, 2025 at 12:55:04PM +0100, Krzysztof Kozlowski wrote: > Since SM8250 all downstream sources program clock inverters in > PLL_CLOCK_INVERTERS_1 register and leave the PLL_CLOCK_INVERTERS as > reset value (0x0). The most recent Hardware Programming Guide for 3 nm, > 4 nm, 5 nm and 7 n

Re: [PATCH v12 2/2] drm/amdgpu: Enable async flip on overlay planes

2025-01-29 Thread Xaver Hugl
Am Mo., 27. Jan. 2025 um 21:00 Uhr schrieb André Almeida : > > amdgpu can handle async flips on overlay planes, so allow it for atomic > async checks. > > Signed-off-by: André Almeida > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c | 10 ++ > 1 file changed, 6 insertions(+

Re: [PATCH v2] drm/virtio: Align host mapping request to maximum platform page size

2025-01-29 Thread Dmitry Osipenko
On 1/26/25 00:08, Sasha Finkelstein via B4 Relay wrote: > --- a/drivers/gpu/drm/virtio/virtgpu_vram.c > +++ b/drivers/gpu/drm/virtio/virtgpu_vram.c > @@ -150,8 +150,8 @@ static int virtio_gpu_vram_map(struct virtio_gpu_object > *bo) > return -EINVAL; > > spin_lock(&vgdev->hos

Re: [PATCH 14/14] Documentation: Update the todo

2025-01-29 Thread Thierry Reding
On Wed, Jan 29, 2025 at 03:31:50PM +0100, Maxime Ripard wrote: > Hi Thomas, > > On Wed, Jan 29, 2025 at 02:06:15PM +0100, Thomas Zimmermann wrote: > > Am 28.01.25 um 23:29 schrieb Anusha Srivatsa: > > > Remove the TODO now that this series addresses > > > the changes needed. > > > > While your se

Re: [Question] Are "device exclusive non-swap entries" / "SVM atomics in Nouveau" still getting used in practice?

2025-01-29 Thread Simona Vetter
On Tue, Jan 28, 2025 at 09:24:33PM +0100, David Hildenbrand wrote: > On 28.01.25 21:14, Simona Vetter wrote: > > On Tue, Jan 28, 2025 at 11:09:24AM +1100, Alistair Popple wrote: > > > On Fri, Jan 24, 2025 at 06:54:02PM +0100, David Hildenbrand wrote: > > > > > > > On integrated the gpu is tied into

Re: [PATCH v2 14/16] drm/ast: astdp: Look up mode index from table

2025-01-29 Thread Jocelyn Falempe
On 29/01/2025 10:55, Thomas Zimmermann wrote: Replace the large switch statement with a look-up table when selecting the mode index. Makes the code easier to read. The table is sorted by resolutions; if run-time overhead from traversal becomes significant, binary search would be a possible optimi

[PATCH 0/6] accel/ivpu: Changes for 6.15

2025-01-29 Thread Jacek Lawrynowicz
Most notable is the addition of hardware fault injection support which allows to test error handling paths in the driver. Jacek Lawrynowicz (2): accel/ivpu: Add support for hardware fault injection accel/ivpu: Update last_busy in IRQ handler Karol Wachowski (3): accel/ivpu: Fix missing MMU

[PATCH 1/6] accel/ivpu: Add support for hardware fault injection

2025-01-29 Thread Jacek Lawrynowicz
This commit introduces the capability to simulate hardware faults for testing purposes. The new `fail_hw` fault can be injected in `ivpu_hw_reg_poll_fld()`, which is used in various parts of the driver to wait for the hardware to reach a specific state. This allows to test failures during NPU boot

[PATCH 5/6] accel/ivpu: Enable recovery and adjust timeouts for fpga

2025-01-29 Thread Jacek Lawrynowicz
From: Tomasz Rusinowicz Recovery now works on fpga. JSM state dump timeout needs to be really long for the new fpga model releases. Enable punit on fpga. Reviewed-by: Jacek Lawrynowicz Signed-off-by: Tomasz Rusinowicz Signed-off-by: Jacek Lawrynowicz --- drivers/accel/ivpu/ivpu_hw.c | 10 ++

[PATCH 4/6] accel/ivpu: Turn on HWS by default on all platforms

2025-01-29 Thread Jacek Lawrynowicz
From: Karol Wachowski Hardware scheduling (HWS) is supposed to be supported on all existing platform with recent FW including pre-silicon ones. Turn on HWS by default. Reviewed-by: Jacek Lawrynowicz Signed-off-by: Karol Wachowski Signed-off-by: Jacek Lawrynowicz --- drivers/accel/ivpu/ivpu_f

[PATCH 3/6] accel/ivpu: Fix missing MMU events if file_priv is unbound

2025-01-29 Thread Jacek Lawrynowicz
From: Karol Wachowski Move the ivpu_mmu_discard_events() function to the common portion of the abort work function. This ensures it is called only once, even if there are no faulty contexts in context_xa, to guarantee that MMU events are discarded and new events are not missed. Reviewed-by: Jace

[PATCH 2/6] accel/ivpu: Update last_busy in IRQ handler

2025-01-29 Thread Jacek Lawrynowicz
Call pm_runtime_mark_last_busy() in top half of IRQ handler to prevent device from being runtime suspended before bottom half is executed on a workqueue. Reviewed-by: Karol Wachowski Signed-off-by: Jacek Lawrynowicz --- drivers/accel/ivpu/ivpu_hw.c | 9 ++--- 1 file changed, 6 insertions(+)

Re: [PATCH 14/14] Documentation: Update the todo

2025-01-29 Thread Thomas Zimmermann
Hi Am 28.01.25 um 23:29 schrieb Anusha Srivatsa: Remove the TODO now that this series addresses the changes needed. While your series is fine, this TODO item is unrelated. It's about various ancient fbdev drivers that do not reserve their memory regions correctly. So please drop patch 14 fo

Re: [PATCH] dma-buf: fix timeout handling in dma_resv_wait_timeout v2

2025-01-29 Thread Lucas Stach
Am Mittwoch, dem 29.01.2025 um 11:58 +0100 schrieb Christian König: > Even the kerneldoc says that with a zero timeout the function should not > wait for anything, but still return 1 to indicate that the fences are > signaled now. > > Unfortunately that isn't what was implemented, instead of only

[PATCH 6/6] accel/ivpu: Move recovery work to system_unbound_wq

2025-01-29 Thread Jacek Lawrynowicz
From: Karol Wachowski Recovery work doesn't need to be bound to any specific CPU, so move it to unbound workqueue to improve execution time and system latency. Reviewed-by: Jacek Lawrynowicz Signed-off-by: Karol Wachowski Signed-off-by: Jacek Lawrynowicz --- drivers/accel/ivpu/ivpu_pm.c | 2

Re: [PATCH 14/14] Documentation: Update the todo

2025-01-29 Thread Maxime Ripard
On Wed, Jan 29, 2025 at 03:41:32PM +0100, Thierry Reding wrote: > On Wed, Jan 29, 2025 at 03:31:50PM +0100, Maxime Ripard wrote: > > Hi Thomas, > > > > On Wed, Jan 29, 2025 at 02:06:15PM +0100, Thomas Zimmermann wrote: > > > Am 28.01.25 um 23:29 schrieb Anusha Srivatsa: > > > > Remove the TODO now

[PATCH 1/2] drm/ttm: test private resv obj on release/destroy

2025-01-29 Thread Christian König
Test the fences in the private dma_resv object instead of the pointer to a potentially shared dma_resv object. This only matters for imported BOs with an SG table since those don't get their dma_resv pointer replaced on release. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c |

Re: [PATCH 12/14] drm/tiny: move to devm_platform_ioremap_resource() usage

2025-01-29 Thread Maxime Ripard
On Tue, Jan 28, 2025 at 05:29:36PM -0500, Anusha Srivatsa wrote: > Replace platform_get_resource + devm_ioremap_resource > with just devm_platform_ioremap_resource() > > Used Coccinelle to do this change. SmPl patch: > @rule_1@ > identifier res; > expression ioremap_res; > identifier pdev; > @@ >

Re: [PATCH 02/14] drm/fsl-dcu: move to devm_platform_ioremap_resource() usage

2025-01-29 Thread Maxime Ripard
On Tue, Jan 28, 2025 at 05:29:26PM -0500, Anusha Srivatsa wrote: > Replace platform_get_resource + devm_ioremap_resource > with just devm_platform_ioremap_resource() > > Used Coccinelle to do this change. SmPl patch: > @rule_1@ > identifier res; > expression ioremap_res; > identifier pdev; > @@ >

Re: [PATCH 01/14] drm/aspeed: move to devm_platform_ioremap_resource() usage

2025-01-29 Thread Maxime Ripard
On Tue, Jan 28, 2025 at 05:29:25PM -0500, Anusha Srivatsa wrote: > Replace platform_get_resource + devm_ioremap_resource > with just devm_platform_ioremap_resource() > > Used Coccinelle to do this change. SmPl patch: > @rule_1@ > identifier res; > expression ioremap_res; > identifier pdev; > @@ >

Re: [PATCH 03/14] drm/hisilicon: move to devm_platform_ioremap_resource() usage

2025-01-29 Thread Maxime Ripard
On Tue, Jan 28, 2025 at 05:29:27PM -0500, Anusha Srivatsa wrote: > Replace platform_get_resource + devm_ioremap_resource > with just devm_platform_ioremap_resource() > > Used Coccinelle to do this change. SmPl patch: > @rule_1@ > identifier res; > expression ioremap_res; > identifier pdev; > @@ >

Re: [PATCH v2 10/16] drm/ast: Add helpers for VBIOS mode lookup

2025-01-29 Thread Jocelyn Falempe
On 29/01/2025 10:54, Thomas Zimmermann wrote: Mode lines are independent from hardware Gen or TX chip, so hide all VBIOS mode tables in ast_vbios.c. Move the look-up code for VBIOS modes from ast_vbios_get_mode_info() to ast_vbios_find_mode(). The new look-up function respects the supported-mode

[PATCH 08/13] drm/vkms: Allow to configure multiple CRTCs

2025-01-29 Thread José Expósito
Add a list of CRTCs to vkms_config and helper functions to add and remove as many CRTCs as wanted. For backwards compatibility, add one CRTC to the default configuration. A future patch will allow to attach planes and CRTCs, but for the moment there are no changes in the way the output is configu

Re: [PATCH v2 06/16] drm/ast: Add support_wuxga flag to struct ast_device

2025-01-29 Thread Jocelyn Falempe
On 29/01/2025 10:54, Thomas Zimmermann wrote: Detect support for 1920x1200 (WUXGA) in ast_detect_widescreen(). The flag is cleared by default. The test logic has been taken from existing code in ast_crtc_helper_mode_valid(). The code in that function is being replaced by the new flag. v2: - move

Re: [PATCH v2 04/16] drm/ast: Reorganize widescreen test around hardware Gens

2025-01-29 Thread Jocelyn Falempe
On 29/01/2025 10:54, Thomas Zimmermann wrote: Testing for support of widescreen modes mixes up various hardware Gens. First branch by hardware Gen, then do specific tests for each Gen. By default, widesscreen support is disabled. Later patches will add more specific tests for each Gen. v2: - mo

[PATCH 11/13] drm/vkms: Allow to attach encoders and CRTCs

2025-01-29 Thread José Expósito
Add a list of possible CRTCs to the encoder configuration and helpers to attach and detach them. Now that the default configuration has its encoder and CRTC correctly attached, configure the output following the configuration. Signed-off-by: Louis Chauvet Signed-off-by: José Expósito --- drive

[PATCH 04/13] drm/vkms: Move default_config creation to its own function

2025-01-29 Thread José Expósito
Extract the initialization of the default configuration to a function. Refactor, no functional changes. Signed-off-by: Louis Chauvet Signed-off-by: José Expósito --- drivers/gpu/drm/vkms/tests/vkms_config_test.c | 38 +++ drivers/gpu/drm/vkms/vkms_config.c| 17 ++

[PATCH v2 06/16] drm/ast: Add support_wuxga flag to struct ast_device

2025-01-29 Thread Thomas Zimmermann
Detect support for 1920x1200 (WUXGA) in ast_detect_widescreen(). The flag is cleared by default. The test logic has been taken from existing code in ast_crtc_helper_mode_valid(). The code in that function is being replaced by the new flag. v2: - move shared detection code into helper (Jocelyn) Si

[PATCH v2 11/16] drm/ast: Validate DRM display modes against VBIOS modes

2025-01-29 Thread Thomas Zimmermann
Test DRM display modes against the list of modes supported by the VBIOS. The helper will respect the supported-modes flags in struct ast_device. Hence only DRM display modes supported by the VBIOS will be reported; without the current duplication of this information. Signed-off-by: Thomas Zimmerma

[PATCH v2 04/16] drm/ast: Reorganize widescreen test around hardware Gens

2025-01-29 Thread Thomas Zimmermann
Testing for support of widescreen modes mixes up various hardware Gens. First branch by hardware Gen, then do specific tests for each Gen. By default, widesscreen support is disabled. Later patches will add more specific tests for each Gen. v2: - move shared detection code into helper (Jocelyn)

[PATCH v2 09/16] drm/ast: Add empty initializer for VBIOS modes

2025-01-29 Thread Thomas Zimmermann
VBIOS mode tables are terminated by an entry with a refresh rate of 0xff. The code is hard to read and fragile to use. Therefore create an empty entry with AST_VBIOS_MODE_INVALID to terminate each mode list. Stop at the invalid entry when searching for modes in the tables. Instead of testing for r

[PATCH v2 05/16] drm/ast: Add support_fullhd flag to struct ast_device

2025-01-29 Thread Thomas Zimmermann
Detect support for 1920x1080 (FullHD) in ast_detect_widescreen(). The flag is cleared by default. The test logic has been taken from existing code in ast_crtc_helper_mode_valid(). The code in that function is being replaced by the new flag. For Gen3, a new branch duplicates the Gen2 logic and adds

[PATCH v2 14/16] drm/ast: astdp: Look up mode index from table

2025-01-29 Thread Thomas Zimmermann
Replace the large switch statement with a look-up table when selecting the mode index. Makes the code easier to read. The table is sorted by resolutions; if run-time overhead from traversal becomes significant, binary search would be a possible optimization. The mode index requires a refresh-rate

[PATCH v2 08/16] drm/ast: Find VBIOS mode from regular display size

2025-01-29 Thread Thomas Zimmermann
The ast driver looks up supplied display modes from an internal list of display modes supported by the VBIOS. Do not use the crtc_-prefixed display values from struct drm_display_mode for looking up the VBIOS mode. The fields contain raw values that the driver programs to hardware. They are affect

[PATCH v2 15/16] drm/ast: Remove struct ast_vbios_mode_info

2025-01-29 Thread Thomas Zimmermann
The type struct ast_vbios_mode_info used to store information about the color format and display mode. It has outlived its purpose. Inline its fields into struct ast_crtc_state and replace all instances. Signed-off-by: Thomas Zimmermann Reviewed-by: Jocelyn Falempe --- drivers/gpu/drm/ast/ast_d

[PATCH v2 02/16] drm/ast: Align naming in widescreen detection code to manual

2025-01-29 Thread Thomas Zimmermann
Rename variables and register constants to align with the programming manual. Add new constants where necessary. Signed-off-by: Thomas Zimmermann Reviewed-by: Jocelyn Falempe --- drivers/gpu/drm/ast/ast_drv.c | 2 +- drivers/gpu/drm/ast/ast_main.c | 8 drivers/gpu/drm/ast/ast_post.c

[PATCH v2 00/16] drm/ast: Clean up display-mode detection and validation

2025-01-29 Thread Thomas Zimmermann
The ast driver detects support for display modes from hardware features and internal mode tables. Streamline the detection code and put all validation into a single place. Patches 1 to 6 refactor the code for detecting support for widescreen modes. Regular 4:3 modes are supported by all hardware G

[PATCH v2 03/16] drm/ast: Rename support_wide_screen to support_wsxga_p

2025-01-29 Thread Thomas Zimmermann
The flag support_wide_screen in struct ast_device selects devices that support resolutions of at least 1680x1050 (WSXGA+). Name it accordingly. Signed-off-by: Thomas Zimmermann Reviewed-by: Jocelyn Falempe --- drivers/gpu/drm/ast/ast_drv.h | 2 +- drivers/gpu/drm/ast/ast_main.c | 16 -

Re: [PATCH v2] drm/sched: Use struct for drm_sched_init() params

2025-01-29 Thread Frank Binns
On Tue, 2025-01-28 at 15:29 +0100, Philipp Stanner wrote: > drm_sched_init() has a great many parameters and upcoming new > functionality for the scheduler might add even more. Generally, the > great number of parameters reduces readability and has already caused > one missnaming in: > > commit 6f

Re: [PATCH v2] drm/sched: Use struct for drm_sched_init() params

2025-01-29 Thread Maíra Canal
Hi Philipp, On 28/01/25 11:29, Philipp Stanner wrote: drm_sched_init() has a great many parameters and upcoming new functionality for the scheduler might add even more. Generally, the great number of parameters reduces readability and has already caused one missnaming in: commit 6f1cacf4eba7 ("

Re: [PATCH] dma-buf: fix timeout handling in dma_resv_wait_timeout

2025-01-29 Thread Christian König
Am 28.01.25 um 15:41 schrieb Lucas Stach: Am Dienstag, dem 28.01.2025 um 15:28 +0100 schrieb Christian König: Am 28.01.25 um 11:48 schrieb Lucas Stach: Hi Christian, Am Dienstag, dem 28.01.2025 um 11:08 +0100 schrieb Christian König: Even the kerneldoc says that with a zero timeout the functi

Re: [PATCH v4 09/18] reset: thead: Add TH1520 reset controller driver

2025-01-29 Thread Philipp Zabel
On Di, 2025-01-28 at 20:48 +0100, Michal Wilczynski wrote: > Add reset controller driver for the T-HEAD TH1520 SoC that manages > hardware reset lines for various subsystems. The driver currently > implements support for GPU reset control, with infrastructure in place > to extend support for NPU an

Re: [PATCH RFC] drm/msm/dsi/phy: Program clock inverters in correct register

2025-01-29 Thread Krzysztof Kozlowski
On 29/01/2025 15:31, Dmitry Baryshkov wrote: > On Wed, Jan 29, 2025 at 12:55:04PM +0100, Krzysztof Kozlowski wrote: >> Since SM8250 all downstream sources program clock inverters in >> PLL_CLOCK_INVERTERS_1 register and leave the PLL_CLOCK_INVERTERS as >> reset value (0x0). The most recent Hardwar

Re: [PATCH v2] drm/sched: Use struct for drm_sched_init() params

2025-01-29 Thread Maíra Canal
Hi Philipp, On 29/01/25 09:39, Philipp Stanner wrote: On Wed, 2025-01-29 at 07:53 -0300, Maíra Canal wrote: Hi Philipp, On 28/01/25 11:29, Philipp Stanner wrote: drm_sched_init() has a great many parameters and upcoming new functionality for the scheduler might add even more. Generally, the g

Re: [PATCH 13/26] RFC drm/xe/eudebug: userptr vm pread/pwrite

2025-01-29 Thread Christian König
Am 29.01.25 um 09:03 schrieb Joonas Lahtinen: Quoting Christian König (2024-12-20 14:56:14) Am 20.12.24 um 12:31 schrieb Mika Kuoppala: Implement debugger vm access for userptrs. When bind is done, take ref to current task so that we know from which vm the address was bound. Then during debugg

Re: [PATCH 04/16] ALSA: ac97: convert timeouts to secs_to_jiffies()

2025-01-29 Thread Takashi Iwai
On Tue, 28 Jan 2025 19:21:49 +0100, Easwar Hariharan wrote: > > Commit b35108a51cf7 ("jiffies: Define secs_to_jiffies()") introduced > secs_to_jiffies(). As the value here is a multiple of 1000, use > secs_to_jiffies() instead of msecs_to_jiffies to avoid the multiplication. > > This is converte

Re: [PATCH v2 4/5] misc: fastrpc: Add polling mode support for fastRPC driver

2025-01-29 Thread Dmitry Baryshkov
On Wed, Jan 29, 2025 at 11:12:16AM +0530, Ekansh Gupta wrote: > > > > On 1/29/2025 4:59 AM, Dmitry Baryshkov wrote: > > On Mon, Jan 27, 2025 at 10:12:38AM +0530, Ekansh Gupta wrote: > >> For any remote call to DSP, after sending an invocation message, > >> fastRPC driver waits for glink response

Re: [PATCH v2 3/5] misc: fastrpc: Add CRC support using invokeV2 request

2025-01-29 Thread Dmitry Baryshkov
On Mon, Jan 27, 2025 at 10:12:37AM +0530, Ekansh Gupta wrote: > InvokeV2 request is intended to support multiple enhanced invoke > requests like CRC check, performance counter enablement and polling > mode for RPC invocations. CRC check is getting enabled as part of > this patch. CRC check for inpu

Re: [PATCH v2 14/16] drm/ast: astdp: Look up mode index from table

2025-01-29 Thread Jocelyn Falempe
On 29/01/2025 13:01, Thomas Zimmermann wrote: Hi Am 29.01.25 um 12:27 schrieb Jocelyn Falempe: On 29/01/2025 10:55, Thomas Zimmermann wrote: Replace the large switch statement with a look-up table when selecting the mode index. Makes the code easier to read. The table is sorted by resolutions

Re: [Question] Are "device exclusive non-swap entries" / "SVM atomics in Nouveau" still getting used in practice?

2025-01-29 Thread Simona Vetter
On Wed, Jan 29, 2025 at 12:31:14PM +0100, David Hildenbrand wrote: > On 29.01.25 12:28, Simona Vetter wrote: > > On Wed, Jan 29, 2025 at 11:48:03AM +0100, Simona Vetter wrote: > > > On Tue, Jan 28, 2025 at 09:24:33PM +0100, David Hildenbrand wrote: > > > > On 28.01.25 21:14, Simona Vetter wrote: >

Re: [PATCH v2 0/5] kci-gitlab: Introducing GitLab-CI Pipeline for Kernel Testing

2025-01-29 Thread Vignesh Raman
Hi Leo, On 28/01/25 00:35, Leonardo Brás wrote: On Mon, 2025-01-27 at 13:02 +0530, Vignesh Raman wrote: Hi Leo, On 24/01/25 13:42, Laurent Pinchart wrote: On Fri, Jan 24, 2025 at 02:11:26AM -0300, Leonardo Brás wrote: On Thu, 2025-01-23 at 19:23 +0530, Vignesh Raman wrote: This patch series

Re: [01/16] coccinelle: misc: secs_to_jiffies: Patch expressions too

2025-01-29 Thread Markus Elfring
>> … >>> +++ b/scripts/coccinelle/misc/secs_to_jiffies.cocci >>> @@ -11,12 +11,22 @@ >>> >>> virtual patch >> … >>> -@depends on patch@ constant C; @@ >>> +@depends on patch@ >>> +expression E; >>> +@@ >>> >>> -- msecs_to_jiffies(C * MSEC_PER_SEC) >>> -+ secs_to_jiffies(C) >>> +-msecs_to_jiffies >

[PATCH] gpu: drm_dp_cec: fix broken CEC adapter properties check

2025-01-29 Thread Hans Verkuil
If the hotplug detect of a display is low for longer than one second (configurable through drm_dp_cec_unregister_delay), then the CEC adapter is unregistered since we assume the display was disconnected. If the HPD went low for less than one second, then we check if the properties of the CEC adapte

Re: [PATCH] drm/vkms: Add support for ABGR8888 pixel format

2025-01-29 Thread Louis Chauvet
On 28/01/25 - 15:08, Paz Zcharya wrote: > On Tue, Jan 28, 2025 at 11:04:33AM +0100, Louis Chauvet wrote: > > On 27/01/25 - 23:59, Paz Zcharya wrote: > > > Add support for pixel format ABGR, which is the default format > > > on Android devices. This will allow us to use VKMS as the default > > >

[PATCH] dma-buf: fix timeout handling in dma_resv_wait_timeout v2

2025-01-29 Thread Christian König
Even the kerneldoc says that with a zero timeout the function should not wait for anything, but still return 1 to indicate that the fences are signaled now. Unfortunately that isn't what was implemented, instead of only returning 1 we also waited for at least one jiffies. Fix that by adjusting th

[PATCH 05/13] drm/vkms: Set device name from vkms_config

2025-01-29 Thread José Expósito
In order to be able to create multiple devices, the device name needs to be unique. Allow to set it in the VKMS configuration. Signed-off-by: José Expósito --- drivers/gpu/drm/vkms/tests/vkms_config_test.c | 7 ++- drivers/gpu/drm/vkms/vkms_config.c| 14 -- drivers/

[PATCH 07/13] drm/vkms: Allow to configure multiple planes

2025-01-29 Thread José Expósito
Add a list of planes to vkms_config and create as many planes as configured during output initialization. For backwards compatibility, add one primary plane and, if configured, one cursor plane and NUM_OVERLAY_PLANES planes to the default configuration. Signed-off-by: Louis Chauvet Signed-off-by

[PATCH 02/13] drm/vkms: Add KUnit test scaffolding

2025-01-29 Thread José Expósito
Add the required boilerplate to start creating KUnit test. To run the tests: $ ./tools/testing/kunit/kunit.py run \ --kunitconfig=drivers/gpu/drm/vkms/tests Signed-off-by: Arthur Grillo Signed-off-by: Louis Chauvet Signed-off-by: José Expósito --- drivers/gpu/drm/vkms/Kconfig

[PATCH 10/13] drm/vkms: Allow to configure multiple encoders

2025-01-29 Thread José Expósito
Add a list of encoders to vkms_config and helper functions to add and remove as many encoders as wanted. For backwards compatibility, add one encoder to the default configuration. A future patch will allow to attach encoders and CRTCs, but for the moment there are no changes in the way the output

[PATCH 03/13] drm/vkms: Extract vkms_config header

2025-01-29 Thread José Expósito
Creating a new vkms_config structure will be more complex once we start adding more options. Extract the vkms_config structure to its own header and source files and add functions to create and delete a vkms_config and to initialize debugfs. Refactor, no functional changes. Signed-off-by: Louis

[PATCH 09/13] drm/vkms: Allow to attach planes and CRTCs

2025-01-29 Thread José Expósito
Add a list of possible CRTCs to the plane configuration and helpers to attach, detach and get the primary and cursor planes attached to a CRTC. Now that the default configuration has its planes and CRTC correctly attached, configure the output following the configuration. Signed-off-by: Louis Cha

[PATCH 12/13] drm/vkms: Allow to configure multiple connectors

2025-01-29 Thread José Expósito
Add a list of connectors to vkms_config and helper functions to add and remove as many connectors as wanted. Unlike planes, CRTCs and encoders, connectors can be added and removed once the device is created. To reflect it, add an "enabled" flag in the configuration and filter disabled connectors i

[PATCH 13/13] drm/vkms: Allow to attach connectors and encoders

2025-01-29 Thread José Expósito
Add a list of possible encoders to the connector configuration and helpers to attach and detach them. Now that the default configuration has its connector and encoder correctly, configure the output following the configuration. Signed-off-by: Louis Chauvet Signed-off-by: José Expósito --- driv

[PATCH 06/13] drm/vkms: Add a validation function for VKMS configuration

2025-01-29 Thread José Expósito
From: Louis Chauvet As the configuration will be used by userspace, add a validator to avoid creating a broken DRM device. For the moment, the function always returns true, but rules will be added in future patches. Signed-off-by: José Expósito Signed-off-by: Louis Chauvet --- drivers/gpu/dr

[PATCH 00/13] drm/vkms: Allow to configure device

2025-01-29 Thread José Expósito
Hi everyone, In preparation for ConfigFS support, a flexible way to configure VKMS device(s) is required. This series adds the required APIs to create a configuration, the code changes required to apply it and KUnit test validating the changes. Louis Chauvet and I are working on ConfigFS support.

Re: [RFC 1/5] mm/hmm: HMM API to enable P2P DMA for device private pages

2025-01-29 Thread Simona Vetter
On Tue, Jan 28, 2025 at 01:21:23PM -0400, Jason Gunthorpe wrote: > On Tue, Jan 28, 2025 at 05:32:23PM +0100, Thomas Hellström wrote: > > > This series supports three case: > > > > > >  1) pgmap->owner == range->dev_private_owner > > >     This is "driver private fast interconnect" in this case HMM

Re: [RFC 1/5] mm/hmm: HMM API to enable P2P DMA for device private pages

2025-01-29 Thread Jason Gunthorpe
On Wed, Jan 29, 2025 at 02:38:58PM +0100, Simona Vetter wrote: > > The pgmap->owner doesn't *have* to fixed, certainly during early boot before > > you hand out any page references it can be changed. I wouldn't be > > surprised if this is useful to some requirements to build up the > > private int

Re: [Question] Are "device exclusive non-swap entries" / "SVM atomics in Nouveau" still getting used in practice?

2025-01-29 Thread David Hildenbrand
On 29.01.25 15:05, Simona Vetter wrote: On Wed, Jan 29, 2025 at 12:31:14PM +0100, David Hildenbrand wrote: On 29.01.25 12:28, Simona Vetter wrote: On Wed, Jan 29, 2025 at 11:48:03AM +0100, Simona Vetter wrote: On Tue, Jan 28, 2025 at 09:24:33PM +0100, David Hildenbrand wrote: On 28.01.25 21:1

Re: [PATCH 13/26] RFC drm/xe/eudebug: userptr vm pread/pwrite

2025-01-29 Thread Joonas Lahtinen
Quoting Christian König (2024-12-20 14:56:14) > Am 20.12.24 um 12:31 schrieb Mika Kuoppala: > > Implement debugger vm access for userptrs. > > > > When bind is done, take ref to current task so that > > we know from which vm the address was bound. Then during > > debugger pread/pwrite we use this t

Re: [PATCH v2] drm/sched: Use struct for drm_sched_init() params

2025-01-29 Thread Boris Brezillon
On Tue, 28 Jan 2025 15:29:27 +0100 Philipp Stanner wrote: > drm_sched_init() has a great many parameters and upcoming new > functionality for the scheduler might add even more. Generally, the > great number of parameters reduces readability and has already caused > one missnaming in: > > commit

Re: [PATCH v2] drm/sched: Use struct for drm_sched_init() params

2025-01-29 Thread Christian Gmeiner
> > drm_sched_init() has a great many parameters and upcoming new > functionality for the scheduler might add even more. Generally, the > great number of parameters reduces readability and has already caused > one missnaming in: > > commit 6f1cacf4eba7 ("drm/nouveau: Improve variable name in > nou

Re: Re: Re: Re: Re: [PATCH v2] treewide: const qualify ctl_tables where applicable

2025-01-29 Thread Joel Granados
On Tue, Jan 28, 2025 at 10:43:10AM -0500, Paul Moore wrote: > On Tue, Jan 28, 2025 at 6:22 AM Joel Granados > wrote: > > On Mon, Jan 27, 2025 at 03:42:39PM +, Matthew Wilcox wrote: > > > On Mon, Jan 27, 2025 at 04:55:58PM +0200, Jani Nikula wrote: > > > > You could have static const within fu

Re: [PATCH 10/14] drm/stm: move to devm_platform_ioremap_resource() usage

2025-01-29 Thread Raphael Gallais-Pou
On 1/28/25 23:29, Anusha Srivatsa wrote: > Replace platform_get_resource + devm_ioremap_resource > with just devm_platform_ioremap_resource() > > Used Coccinelle to do this change. SmPl patch: > @rule_1@ > identifier res; > expression ioremap_res; > identifier pdev; > @@ > -struct resource *res;

Re: [PATCH 09/14] drm/sti: move to devm_platform_ioremap_resource() usage

2025-01-29 Thread Raphael Gallais-Pou
On 1/28/25 23:29, Anusha Srivatsa wrote: > Replace platform_get_resource/_byname + devm_ioremap > with just devm_platform_ioremap_resource() > > Used Coccinelle to do this change. SmPl patch: > > @rule@ > identifier res; > expression ioremap; > identifier pdev; > constant mem; > expression name;

Re: [PATCH v5 02/14] drm/msm/dpu: move resource allocation to CRTC

2025-01-29 Thread Dmitry Baryshkov
On Tue, Jan 28, 2025 at 07:20:34PM -0800, Jessica Zhang wrote: > From: Dmitry Baryshkov > > All resource allocation is centered around the LMs. Then other blocks > (except DSCs) are allocated basing on the LMs that was selected, and LM > powers up the CRTC rather than the encoder. > > Moreover i

Re: [PATCH v5 07/14] drm/msm/dpu: Reserve resources for CWB

2025-01-29 Thread Dmitry Baryshkov
On Tue, Jan 28, 2025 at 07:20:39PM -0800, Jessica Zhang wrote: > Add support for RM to reserve dedicated CWB PINGPONGs and CWB muxes > > For concurrent writeback, even-indexed CWB muxes must be assigned to > even-indexed LMs and odd-indexed CWB muxes for odd-indexed LMs. The same > even/odd rule a

Re: [PATCH v5 06/14] drm/msm/dpu: Fail atomic_check if multiple outputs request CDM block

2025-01-29 Thread Dmitry Baryshkov
On Tue, Jan 28, 2025 at 07:20:38PM -0800, Jessica Zhang wrote: > Currently, our hardware only supports a single output using CDM block at > most. Because of this, we cannot support cases where both writeback and DP > output request CDM simultaneously > > To avoid this happening when CWB is enabled

Re: [PATCH v1 4/4] mm/memory: document restore_exclusive_pte()

2025-01-29 Thread Alistair Popple
On Wed, Jan 29, 2025 at 12:58:02PM +0100, David Hildenbrand wrote: > Let's document how this function is to be used, and why the requirement > for the folio lock might maybe be dropped in the future. Sorry, only just catching up on your other thread. The folio lock was to ensure the GPU got a chan

Re: [PATCH v1 1/4] lib/test_hmm: make dmirror_atomic_map() consume a single page

2025-01-29 Thread Alistair Popple
On Wed, Jan 29, 2025 at 12:57:59PM +0100, David Hildenbrand wrote: > The caller now always passes a single page; let's simplify, and return > "0" on success. Thanks for cleaning that up. Reviewed-by: Alistair Popple > Signed-off-by: David Hildenbrand > --- > lib/test_hmm.c | 33 ++

Re: [PATCH 1/2] drm/ttm: test private resv obj on release/destroy

2025-01-29 Thread James Zhu
Reviewed-and-Tested-by: James Zhu for the series On 2025-01-29 10:28, Christian König wrote: Test the fences in the private dma_resv object instead of the pointer to a potentially shared dma_resv object. This only matters for imported BOs with an SG table since those don't get their dma_resv p

[PATCH v4 15/33] drm/xe: Add SVM garbage collector

2025-01-29 Thread Matthew Brost
Add basic SVM garbage collector which destroy a SVM range upon a MMU UNMAP event. The garbage collector runs on worker or in GPU fault handler and is required as locks in the path of reclaim are required and cannot be taken the notifier. v2: - Flush garbage collector in xe_svm_close v3: - Better

Re: [RFC PATCH 3/3] drm/virtio: implement blob userptr resource object

2025-01-29 Thread Demi Marie Obenour
On 1/8/25 12:05 PM, Simona Vetter wrote: > On Fri, Dec 27, 2024 at 10:24:29AM +0800, Huang, Honglei1 wrote: >> >> On 2024/12/22 9:59, Demi Marie Obenour wrote: >>> On 12/20/24 10:35 AM, Simona Vetter wrote: On Fri, Dec 20, 2024 at 06:04:09PM +0800, Honglei Huang wrote: > From: Honglei Huan

Re: [PATCH 06/16] rbd: convert timeouts to secs_to_jiffies()

2025-01-29 Thread Easwar Hariharan
On 1/28/2025 10:21 AM, Easwar Hariharan wrote: > Commit b35108a51cf7 ("jiffies: Define secs_to_jiffies()") introduced > secs_to_jiffies(). As the value here is a multiple of 1000, use > secs_to_jiffies() instead of msecs_to_jiffies to avoid the multiplication. > > This is converted using scripts/

Re: [PATCH v2] drm/aspeed: Use devm_platform_get_and_ioremap_resource()

2025-01-29 Thread Andrew Jeffery
On Wed, 2025-01-22 at 11:01 +0800, oushixiong1...@163.com wrote: > From: Shixiong Ou > > Convert platform_get_resource(), devm_ioremap_resource() to a single > call to > devm_platform_get_and_ioremap_resource(). > > Signed-off-by: Shixiong Ou > --- > V1 -> V2: Add Missing commit message. > >  

Re: [PATCH v1 2/4] mm/mmu_notifier: drop owner from MMU_NOTIFY_EXCLUSIVE

2025-01-29 Thread Alistair Popple
On Wed, Jan 29, 2025 at 12:58:00PM +0100, David Hildenbrand wrote: > We no longer get a MMU_NOTIFY_EXCLUSIVE on conversion with the owner set > that one has to filter out: if there already *is* a device-exclusive > entry (e.g., other device, we don't have that information), GUP will > convert it ba

  1   2   3   >