On 28/01/25 - 15:08, Paz Zcharya wrote:
> On Tue, Jan 28, 2025 at 11:04:33AM +0100, Louis Chauvet wrote:
> > On 27/01/25 - 23:59, Paz Zcharya wrote:
> > > Add support for pixel format ABGR8888, which is the default format
> > > on Android devices. This will allow us to use VKMS as the default
> > > display driver in Android Emulator (Cuttlefish) and increase VKMS
> > > adoption.
> > >
> > > Changes in v2:
> > > - Rebased on top of tip of tree because it has been 3 months.
> > > - No functional changes.
> > >
> > > Signed-off-by: Paz Zcharya <p...@google.com>
> >
> > Hi Paz,
> >
> > Reviewed-by: Louis Chauvet <louis.chau...@bootlin.com>
> >
> > When applying a patch I got a small warning about a missmatch between your
> > author email and the Signed-off-by:
> >
> > -:106: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email
> > address mismatch: 'From: Paz Zcharya <p...@chromium.org>' !=
> > 'Signed-off-by: Paz Zcharya <p...@google.com>'
> >
> > I can fix it for you by adding a Author: / changing the Sign-of-by before
> > applying on drm-misc-next.
> >
> > What mail do you want to use? p...@google.com or p...@chromium.org?
> >
> > Thanks!
> > Louis Chauvet
>
> Thank you for the quick review, Louis!
>
> Let's use p...@google.com.
> I apologize about the mistake -- I'll make sure to fix that in the
> future.
And I just noticed that "changes in v2" is in the commit log. It should
not be there.
To add a changelog, you must put it after ---, so in your case your commit
should be something like:
drm/vkms: Add support for ABGR8888 pixel format
Add support for [...] adoption.
Signed-off-by: Paz Zcharya <p...@google.com>
---
Changes in v2:
[...]
Can you send a "real" v2 with the correct commit message and the correct
author?
If you don't know it, you can use b4[1] to help you manage your series and
iterations.
[1]:https://b4.docs.kernel.org/en/latest/
> Greatly appericiate your help!
>
> Thanks a lot,
> Paz
>
