RE: [PATCH v2 2/5] drm/virtio: Add a helper to map and note the dma addrs and lengths

2024-11-18 Thread Kasireddy, Vivek
Hi Dmitry, > > Subject: Re: [PATCH v2 2/5] drm/virtio: Add a helper to map and note the > > dma addrs and lengths > > > > On 10/29/24 09:18, Kasireddy, Vivek wrote: > > BTW, is any DG2 GPU suitable for testing of this patchset? Will I be > > able to test it using a regular consumer A750

[RFC PATCH 09/29] FIXME: drm/xe: Add pad to ring and indirect state

2024-11-18 Thread Matthew Brost
Unsure why, but without this intermittent hangs occur on GuC context switching. Signed-off-by: Matthew Brost --- drivers/gpu/drm/xe/xe_lrc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/xe/xe_lrc.c b/drivers/gpu/drm/xe/xe_lrc.c index e3c1773191bd..9633

[RFC PATCH 29/29] drm/xe: Add user fence TDR

2024-11-18 Thread Matthew Brost
We cannot let user fences exported as dma-fence run forever. Add a TDR to protect against this. If the TDR fires the entire VM is killed as dma-fences are not tied to an individual queue. Signed-off-by: Matthew Brost --- drivers/gpu/drm/xe/xe_vm.c | 164 +-- dri

[RFC PATCH 02/29] dma-fence: Add dma_fence_user_fence

2024-11-18 Thread Matthew Brost
Normalize user fence attachment to a DMA fence. A user fence is a simple seqno write to memory, implemented by attaching a DMA fence callback that writes out the seqno. Intended use case is importing a dma-fence into kernel and exporting a user fence. Helpers added to allocate, attach, and free a

[RFC PATCH 23/29] drm/xe: Add user fence IRQ handler

2024-11-18 Thread Matthew Brost
Imported user fences will not be tied to a specific queue or hardware engine class. Therefore, a device IRQ handler is needed to signal the associated exported DMA fences. Signed-off-by: Matthew Brost --- drivers/gpu/drm/xe/xe_device.c | 4 drivers/gpu/drm/xe/xe_device_types.h | 3 +++

[RFC PATCH 25/29] drm/xe: Add a message lock to the Xe GPU scheduler

2024-11-18 Thread Matthew Brost
Stop abusing job list lock for message, use a dedicated lock. This lock will soon be able to be taken in IRQ contexts, using irqsave for simplicity. Can to tweaked in a follow up as needed. Signed-off-by: Matthew Brost --- drivers/gpu/drm/xe/xe_gpu_scheduler.c | 19 --- dri

[RFC PATCH 00/29] UMD direct submission in Xe

2024-11-18 Thread Matthew Brost
This is an RFC, or possibly even a proof of concept, for UMD (User Mode Driver) direct submission in Xe. It is similar to AMD's design [1] [2] or ARM's design [3], utilizing a uAPI to convert user-space syncs (memory writes) to kernel-space syncs (DMA fences). It is built around the existing Xe pre

[RFC PATCH 04/29] drm/xe: Allocate doorbells for UMD exec queues

2024-11-18 Thread Matthew Brost
These will be mapped to user space for UMD submission. Add infrastructure to GuC submission backend to manage these. Signed-off-by: Matthew Brost --- drivers/gpu/drm/xe/xe_exec_queue_types.h | 2 + drivers/gpu/drm/xe/xe_guc_exec_queue_types.h | 7 ++ drivers/gpu/drm/xe/xe_guc_submit.c

[RFC PATCH 05/29] drm/xe: Add doorbell ID to snapshot capture

2024-11-18 Thread Matthew Brost
Useful for debugging hangs with doorbells. Signed-off-by: Matthew Brost --- drivers/gpu/drm/xe/xe_guc_submit.c | 2 ++ drivers/gpu/drm/xe/xe_guc_submit_types.h | 2 ++ 2 files changed, 4 insertions(+) diff --git a/drivers/gpu/drm/xe/xe_guc_submit.c b/drivers/gpu/drm/xe/xe_guc_submit.c in

[RFC PATCH 08/29] drm/xe: Clear GGTT in xe_bo_restore_kernel

2024-11-18 Thread Matthew Brost
Part of what xe_bo_restore_kernel does, is restore BO's GGTT mappings which may have been lost during a power state change. Missing is restoring the GGTT entries without BO mappings to a known state (e.g., scratch pages). Update xe_bo_restore_kernel to clear the entire GGTT before restoring BO's GG

[RFC PATCH 07/29] drm/xe: Break indirect ring state out into its own BO

2024-11-18 Thread Matthew Brost
Start laying the ground work for UMD submission. This will allow mmaping the indirect ring state to user space. Signed-off-by: Matthew Brost --- drivers/gpu/drm/xe/xe_lrc.c | 79 ++- drivers/gpu/drm/xe/xe_lrc_types.h | 7 ++- 2 files changed, 63 insertions(+),

[RFC PATCH 03/29] drm/xe: Use dma_fence_preempt base class

2024-11-18 Thread Matthew Brost
Use the dma_fence_preempt base class in Xe instead of open-coding the preemption implementation. Cc: Dave Airlie Cc: Simona Vetter Cc: Christian Koenig Signed-off-by: Matthew Brost --- drivers/dma-buf/dma-fence-preempt.c | 5 +- drivers/gpu/drm/xe/xe_guc_submit.c | 3 + dri

[RFC PATCH 17/29] drm/xe: Add usermap exec queue extension

2024-11-18 Thread Matthew Brost
Implement uAPI which maps submit rings, indirect LRC state, and doorbells to user space. This is required for UMD direction submission. Signed-off-by: Matthew Brost --- drivers/gpu/drm/xe/xe_exec_queue.c | 125 ++- drivers/gpu/drm/xe/xe_exec_queue_types.h | 13 +++ dri

[RFC PATCH 11/29] drm/xe: Don't add pinned mappings to VM bulk move

2024-11-18 Thread Matthew Brost
We don't want kernel pinned resources (ring, indirect state) in the VM's bulk move as these are unevictable. Signed-off-by: Matthew Brost --- drivers/gpu/drm/xe/xe_bo.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/xe/xe_bo.c b/drivers/gpu/drm/xe/

[RFC PATCH 06/29] drm/xe: Break submission ring out into its own BO

2024-11-18 Thread Matthew Brost
Start laying the ground work for UMD submission. This will allow mmaping the submission ring to user space. Signed-off-by: Matthew Brost --- drivers/gpu/drm/xe/xe_lrc.c | 38 +-- drivers/gpu/drm/xe/xe_lrc_types.h | 9 ++-- 2 files changed, 38 insertions(+),

[RFC PATCH 10/29] drm/xe: Enable indirect ring on media GT

2024-11-18 Thread Matthew Brost
The media GT supports this, required for UMD submission, so enable by default. Signed-off-by: Matthew Brost --- drivers/gpu/drm/xe/xe_pci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c index 9b81e7d00a86..a27450e63cf9 100644 --- a/

[RFC PATCH 14/29] drm/xe: Add support for mmapping doorbells to user space

2024-11-18 Thread Matthew Brost
Doorbells need to be mapped to user space for UMD direct submisssion, add support for this. FIXME: Wildly insecure as anyone can pick MMIO doorbell offset, will need to randomize and tie unique offset to FD. Can be done in later revs before upstreaming. Signed-off-by: Matthew Brost --- drivers/

[RFC PATCH 16/29] drm/xe/uapi: Define UMD exec queue mapping uAPI

2024-11-18 Thread Matthew Brost
Define UMD exec queue mapping uAPI. The submit ring, indirect LRC state (ring head, tail, etc...), and doorbell are securly mapped to user space. The ring is a VM PPGTT addres, while indirect LRC state and doorbell mapping is provided via a fake offset like BOs. Signed-off-by: Matthew Brost ---

[RFC PATCH 20/29] drm/xe: Teach GuC backend to kill usermap queues

2024-11-18 Thread Matthew Brost
Usermap exec queue's teardown (kill) differs from other exec queues as no job is available, a doorbell is mapped, and the kill should be immediate. A follow up could unify LR queue cleanup with usermap but keeping this a seperate flow for now. Signed-off-by: Matthew Brost --- drivers/gpu/drm/xe

[RFC PATCH 18/29] drm/xe: Drop EXEC_QUEUE_FLAG_UMD_SUBMISSION flag

2024-11-18 Thread Matthew Brost
Use xe_exec_queue_is_usermap helper instead. Signed-off-by: Matthew Brost --- drivers/gpu/drm/xe/xe_exec_queue.c | 3 +-- drivers/gpu/drm/xe/xe_exec_queue.h | 5 + drivers/gpu/drm/xe/xe_exec_queue_types.h | 2 -- drivers/gpu/drm/xe/xe_guc_submit.c | 4 ++-- drivers/gpu/drm/

[RFC PATCH 24/29] drm/xe: Add xe_hw_fence_user_init

2024-11-18 Thread Matthew Brost
Add xe_hw_fence_user_init which can create a struct xe_hw_fence from a user input rather than internal LRC state. Used to import user fence and export them as dma fences. Signed-off-by: Matthew Brost --- drivers/gpu/drm/xe/xe_hw_fence.c | 17 + drivers/gpu/drm/xe/xe_hw_fence.h |

Re: [PATCH v9 4/4] drm/i915: Use device wedged event

2024-11-18 Thread Aravind Iddamsetty
On 15/11/24 10:37, Raag Jadav wrote: > Now that we have device wedged event provided by DRM core, make use > of it and support both driver rebind and bus-reset based recovery. > With this in place, userspace will be notified of wedged device on > gt reset failure. > > Signed-off-by: Raag Jadav >

[PATCH v3 0/5] drm/virtio: Import scanout buffers from other devices

2024-11-18 Thread Vivek Kasireddy
Having virtio-gpu import scanout buffers (via prime) from other devices means that we'd be adding a head to headless GPUs assigned to a Guest VM or additional heads to regular GPU devices that are passthrough'd to the Guest. In these cases, the Guest compositor can render into the scanout buffer us

[PATCH v3 2/5] drm/virtio: Add a helper to map and note the dma addrs and lengths

2024-11-18 Thread Vivek Kasireddy
This helper would be used when first initializing the object as part of import and also when updating the plane where we need to ensure that the imported object's backing is valid. Cc: Gerd Hoffmann Cc: Dmitry Osipenko Cc: Rob Clark Cc: Gurchetan Singh Cc: Chia-I Wu Signed-off-by: Vivek Kasir

[PATCH v3 1/5] drm/virtio: Implement VIRTIO_GPU_CMD_RESOURCE_DETACH_BACKING cmd

2024-11-18 Thread Vivek Kasireddy
This cmd is useful to let the VMM (i.e, Qemu) know that the backing store associated with a resource is no longer valid, so that the VMM can perform any cleanup or unmap operations. The fence related changes and virtio_gpu_object_detach()/ virtio_gpu_detach_object_fenced() routines are extracted f

[PATCH v3 4/5] drm/virtio: Import prime buffers from other devices as guest blobs

2024-11-18 Thread Vivek Kasireddy
By importing scanout buffers from other devices, we should be able to use the virtio-gpu driver in KMS only mode. Note that we attach dynamically and register a move_notify() callback so that we can let the VMM know of any location changes associated with the backing store of the imported object by

Re: [PATCH] drm/mediatek: Add no pending_planes flag checking for mtk_crtc_finish_page_flip()

2024-11-18 Thread 林睿祥

[PATCH v3 3/5] drm/virtio: Add helpers to initialize and free the imported object

2024-11-18 Thread Vivek Kasireddy
The imported object can be considered a guest blob resource; therefore, we use create_blob cmd while creating it. These helpers are used in the next patch which does the actual import. Cc: Gerd Hoffmann Cc: Dmitry Osipenko Cc: Rob Clark Cc: Gurchetan Singh Cc: Chia-I Wu Signed-off-by: Vivek K

[PATCH v3 5/5] drm/virtio: Add prepare and cleanup routines for imported dmabuf obj

2024-11-18 Thread Vivek Kasireddy
When an imported dmabuf obj is used as part of an atomic commit, we need to pin it as part of prepare and unpin it during cleanup of the associated FB, to make sure that it does not move until the commit is completed (and also while it is being used on the Host). Cc: Gerd Hoffmann Cc: Dmitry Osip

Re: [PATCH v9 3/4] drm/xe: Use device wedged event

2024-11-18 Thread Ghimiray, Himal Prasad
On 15-11-2024 10:37, Raag Jadav wrote: This was previously attempted as xe specific reset uevent but dropped in commit 77a0d4d1cea2 ("drm/xe/uapi: Remove reset uevent for now") as part of refactoring. Now that we have device wedged event provided by DRM core, make use of it and support both d

Re: [PATCH v1 05/10] media: platform: mediatek: add isp_7x camsys unit

2024-11-18 Thread 胡俊光

[PATCHv2 3/3] drm/i915/display: Populate list of async supported formats/modifiers

2024-11-18 Thread Arun R Murthy
Populate the list of formats/modifiers supported by async flip. Register a async property and expose the same to user through blob. Signed-off-by: Arun R Murthy --- .../drm/i915/display/skl_universal_plane.c| 51 +++ 1 file changed, 51 insertions(+) diff --git a/drivers/gpu/

Re: [PATCH v1 2/4] misc: fastrpc: Rename fastrpc.c to fastrpc_main.c

2024-11-18 Thread Greg KH
On Mon, Nov 18, 2024 at 02:10:44PM +0530, Ekansh Gupta wrote: > Rename the main fastrpc source file to accomodate new files to be > compiled in the same kernel object. > > Signed-off-by: Ekansh Gupta > --- > drivers/misc/fastrpc/Makefile | 1 + > drivers/misc/fastrpc/{fastrp

Re: [PATCH v1 3/4] misc: fastrpc: Introduce fastrpc_shared.h header

2024-11-18 Thread Greg KH
On Mon, Nov 18, 2024 at 02:10:45PM +0530, Ekansh Gupta wrote: > Move fastrpc structures and MACRO definitions to a new header file. > These definitions are consumed by other upcoming features like > debugfs, PDR support etc. > > Signed-off-by: Ekansh Gupta > --- > drivers/misc/fastrpc/fastrpc_ma

[PATCH v2 11/21] drm/imagination: Rename event_mask -> status_mask

2024-11-18 Thread Matt Coster
Now that enable_reg isn't used, rename the previously shared event_mask to status_mask since it's only used with status_reg. Signed-off-by: Matt Coster --- Changes in v2: - None - Link to v1: https://lore.kernel.org/r/20241105-sets-bxs-4-64-patch-v1-v1-11-4ed30e865...@imgtec.com --- drivers/gpu

[PATCH v2 18/21] drm/imagination: Add platform overrides infrastructure

2024-11-18 Thread Matt Coster
This infrastructure will be used in cases where a specific GPU integration or implementation requires some special handling in the driver. The first use case is the device cached memory override added in the next patch. The infrastructure is built out in this separate commit to make it clear which

Re: [PATCH 3/4] drm/i915/dp_mst: Expose a connector to kernel users after it's properly initialized

2024-11-18 Thread Imre Deak
On Mon, Nov 18, 2024 at 02:23:48PM +0200, Jani Nikula wrote: > On Mon, 18 Nov 2024, Imre Deak wrote: > > On Mon, Nov 18, 2024 at 02:12:14PM +0200, Jani Nikula wrote: > >> On Fri, 15 Nov 2024, Imre Deak wrote: > >> > After a connector is added to the drm_mode_config::connector_list, it's > >> > vi

[PATCH v2 01/21] dt-bindings: gpu: img: More explicit compatible strings

2024-11-18 Thread Matt Coster
The current compatible strings are not specific enough to constrain the hardware in devicetree. For example, the current "img,img-axe" string refers to the entire family of Series AXE GPUs. The more specific "img,img-axe-1-16m" string refers to the AXE-1-16M GPU which, unlike the rest of its family

Re: [PATCH 1/5] drm/encoder_slave: make mode_valid accept const struct drm_display_mode

2024-11-18 Thread Dmitry Baryshkov
On Mon, Nov 18, 2024 at 11:26:03AM +0200, Jani Nikula wrote: > On Mon, 18 Nov 2024, Dmitry Baryshkov wrote: > > On Mon, 18 Nov 2024 at 01:33, Laurent Pinchart > > wrote: > >> > >> On Mon, Nov 18, 2024 at 01:22:12AM +0200, Dmitry Baryshkov wrote: > >> > On Sun, 17 Nov 2024 at 22:54, Laurent Pincha

[Bug 219507] nouveau: GeForce GT 710: irq 166 handler nvkm_intr+0x0/0x1b3 [nouveau] enabled interrupts

2024-11-18 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=219507 Artem S. Tashkinov (a...@gmx.com) changed: What|Removed |Added Status|NEW |RESOLVED Reso

Re: [PATCH v1 4/4] misc: fastrpc: Add debugfs support for fastrpc

2024-11-18 Thread Greg KH
On Mon, Nov 18, 2024 at 02:10:46PM +0530, Ekansh Gupta wrote: > Add changes to support debugfs. The fastrpc directory will be > created which will carry debugfs files for all fastrpc processes. > The information of fastrpc user and channel contexts are getting > captured as part of this change. >

Re: [PATCH v8 2/5] drm: make drm-active- stats optional

2024-11-18 Thread Tvrtko Ursulin
On 16/11/2024 04:44, Yunxiang Li wrote: When memory stats is generated fresh everytime by going though all the BOs, their active information is quite easy to get. But if the stats are tracked with BO's state this becomes harder since the job scheduling part doesn't really deal with individual b

Re: [PATCH v3] drm/v3d: Add DRM_IOCTL_V3D_PERFMON_SET_GLOBAL

2024-11-18 Thread Maíra Canal
Hi Christian, The patch overall LGTM, I just have one small nit. On 17/11/24 18:41, Christian Gmeiner wrote: From: Christian Gmeiner Add a new ioctl, DRM_IOCTL_V3D_PERFMON_SET_GLOBAL, to allow configuration of a global performance monitor (perfmon). Use the global perfmon for all jobs to ensu

Re: [PATCH 1/4] drm/i915/dp_mst: Fix connector initialization in intel_dp_add_mst_connector()

2024-11-18 Thread Imre Deak
On Mon, Nov 18, 2024 at 11:10:18AM +0200, Jani Nikula wrote: > On Fri, 15 Nov 2024, Imre Deak wrote: > > On Fri, Nov 15, 2024 at 03:20:58PM -0500, Rodrigo Vivi wrote: > >> On Fri, Nov 15, 2024 at 06:41:56PM +0200, Imre Deak wrote: > >> > The connector initialization in intel_dp_add_mst_connector()

[PATCH v1 4/4] misc: fastrpc: Add debugfs support for fastrpc

2024-11-18 Thread Ekansh Gupta
Add changes to support debugfs. The fastrpc directory will be created which will carry debugfs files for all fastrpc processes. The information of fastrpc user and channel contexts are getting captured as part of this change. Signed-off-by: Ekansh Gupta --- drivers/misc/fastrpc/Makefile|

Re: [PATCH v5 06/13] drm/bridge: cdns-dsi: Check return value when getting default PHY config

2024-11-18 Thread Tomi Valkeinen
On 19/10/2024 22:54, Aradhya Bhatia wrote: From: Aradhya Bhatia Check for the return value of the phy_mipi_dphy_get_default_config() call, and incase of an error, return back the same. Fixes: fced5a364dee ("drm/bridge: cdns: Convert to phy framework") Signed-off-by: Aradhya Bhatia Signed-off-

[PATCH V11 00/10] AMD XDNA driver

2024-11-18 Thread Lizhi Hou
This patchset introduces a new Linux Kernel Driver, amdxdna for AMD NPUs. The driver is based on Linux accel subsystem. NPU (Neural Processing Unit) is an AI inference accelerator integrated into AMD client CPUs. NPU enables efficient execution of Machine Learning applications like CNNs, LLMs, etc

RE: [PATCH v2 2/5] drm/virtio: Add a helper to map and note the dma addrs and lengths

2024-11-18 Thread Kasireddy, Vivek
Hi Dmitry, > Subject: Re: [PATCH v2 2/5] drm/virtio: Add a helper to map and note the > dma addrs and lengths > > On 10/29/24 09:18, Kasireddy, Vivek wrote: > BTW, is any DG2 GPU suitable for testing of this patchset? Will I be > able to test it using a regular consumer A750 card? > >>>

Re: [PATCH 0/5] Fixes etc for fence merging

2024-11-18 Thread Christian König
Am 15.11.24 um 11:21 schrieb Tvrtko Ursulin: From: Tvrtko Ursulin Consolidated series as an simpler alternative to https://lore.kernel.org/dri-devel/20241024124159.4519-3-christian.koe...@amd.com/. Hopefully fixes https://gitlab.freedesktop.org/drm/amd/-/issues/3617. First two patches are fix

[Bug 219507] nouveau: GeForce GT 710: irq 166 handler nvkm_intr+0x0/0x1b3 [nouveau] enabled interrupts

2024-11-18 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=219507 --- Comment #1 from Paul Osmialowski (newch...@king.net.pl) --- I've just made an accidental discovery: this does not happen when I'm using HDMI output only. And that's a huge degradation, as I'm so got used to work with two-monitor setup like thi

Re: [PATCH 5/5] drm/connector: make mode_valid accept const struct drm_display_mode

2024-11-18 Thread Jani Nikula
On Fri, 15 Nov 2024, Dmitry Baryshkov wrote: > The mode_valid() callbacks of drm_encoder, drm_crtc and drm_bridge > accept const struct drm_display_mode argument. Change the mode_valid > callback of drm_connector to also accept const argument. > > Signed-off-by: Dmitry Baryshkov Acked-by: Jani N

[PATCHv2 2/3] drm/plane: Expose function to create format/modifier blob

2024-11-18 Thread Arun R Murthy
Expose drm plane function to create formats/modifiers blob. This function can be used to expose list of supported formats/modifiers for sync/async flips. Signed-off-by: Arun R Murthy --- drivers/gpu/drm/drm_plane.c | 44 - include/drm/drm_plane.h | 4

[PATCH v1 3/4] misc: fastrpc: Introduce fastrpc_shared.h header

2024-11-18 Thread Ekansh Gupta
Move fastrpc structures and MACRO definitions to a new header file. These definitions are consumed by other upcoming features like debugfs, PDR support etc. Signed-off-by: Ekansh Gupta --- drivers/misc/fastrpc/fastrpc_main.c | 136 +- drivers/misc/fastrpc/fastrpc_shared.h |

Re: [PATCH] accel/qaic: Drop redundant vfree() null check in sahara

2024-11-18 Thread Carl Vanderlip
On 11/17/2024 12:26 PM, Jeffrey Hugo wrote: The documentation for vfree() says that passing in NULL is ok. Therefore we can drop the null check as redundant. Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202410301732.abf5md4e-...@intel.com/ Signed-off-by: Jeffrey

[PATCH v2 03/21] dt-bindings: gpu: img: Power domain details

2024-11-18 Thread Matt Coster
The single existing GPU (AXE-1-16M) only requires a single power domain. Subsequent patches will add support for BXS-4-64 MC1, which has two power domains. Add infrastructure now to allow for this. Signed-off-by: Matt Coster --- Changes in v2: - Simplified power-domains constraints P3 - Link to v

Re: [PATCH] [v2] drm: rework FB_CORE dependency

2024-11-18 Thread Thomas Zimmermann
Hi Am 15.11.24 um 17:23 schrieb Arnd Bergmann: From: Arnd Bergmann The 'select FB_CORE' statement moved from CONFIG_DRM to DRM_CLIENT_LIB, but there are now configurations that have code calling into fb_core as built-in even though the client_lib itself is a loadable module: x86_64-linux-ld:

Re: [PATCH 3/4] drm/i915/dp_mst: Expose a connector to kernel users after it's properly initialized

2024-11-18 Thread Jani Nikula
On Mon, 18 Nov 2024, Imre Deak wrote: > On Mon, Nov 18, 2024 at 02:12:14PM +0200, Jani Nikula wrote: >> On Fri, 15 Nov 2024, Imre Deak wrote: >> > After a connector is added to the drm_mode_config::connector_list, it's >> > visible to any in-kernel users looking up connectors via the above list.

Re: [PATCH RFC 6/8] drm/msm: adreno: enable GMU bandwidth for A740 and A750

2024-11-18 Thread Neil Armstrong
On 15/11/2024 15:39, Dmitry Baryshkov wrote: On Fri, Nov 15, 2024 at 10:20:01AM +0100, Neil Armstrong wrote: On 15/11/2024 08:33, Dmitry Baryshkov wrote: On Wed, Nov 13, 2024 at 04:48:32PM +0100, Neil Armstrong wrote: Now all the DDR bandwidth voting via the GPU Management Unit (GMU) is in pla

Re: [PATCH v2 06/29] drm/xe/uapi: Add DRM_XE_VM_BIND_FLAG_SYSTEM_ALLOCATON flag

2024-11-18 Thread Thomas Hellström
On Tue, 2024-10-15 at 20:24 -0700, Matthew Brost wrote: > Add the DRM_XE_VM_BIND_FLAG_SYSTEM_ALLOCATOR flag, which is used to > create unpopulated virtual memory areas (VMAs) without memory backing > or > GPU page tables. These VMAs are referred to as system allocator VMAs. > The idea is that upon

[PATCHv2 3/3] drm/i915/display: Populate list of async supported formats/modifiers

2024-11-18 Thread Arun R Murthy
Populate the list of formats/modifiers supported by async flip. Register a async property and expose the same to user through blob. Signed-off-by: Arun R Murthy --- .../drm/i915/display/skl_universal_plane.c| 51 +++ 1 file changed, 51 insertions(+) diff --git a/drivers/gpu/

Re: [PATCH v8 3/5] Documentation/gpu: Clarify drm memory stats definition

2024-11-18 Thread Christian König
Am 16.11.24 um 05:44 schrieb Yunxiang Li: Define how to handle buffers with multiple possible placement so we don't get incompatible implementations. Callout the resident requirement for drm-purgeable- explicitly. Remove the requirement for there to be only drm-memory- or only drm-resident-, it's

[PATCH v5 drm-dp 5/5] drm/hisilicon/hibmc: add dp module in hibmc

2024-11-18 Thread Yongbang Shi
From: baihan li To support DP interface displaying in hibmc driver. Add a encoder and connector for DP modual. Signed-off-by: Baihan Li Signed-off-by: Yongbang Shi --- ChangeLog: v3 -> v4: - static inline hibmc_dp_prepare(), suggested by Dmitry Baryshkov. --- drivers/gpu/drm/hisilicon/hibmc

[PATCH 3/3] drm/dp: extract drm_dp_dpcd_clear_payload()

2024-11-18 Thread Jani Nikula
SST with 128b/132b channel coding needs this too. Extract to a separate helper, independent of MST. Signed-off-by: Jani Nikula --- drivers/gpu/drm/display/drm_dp_helper.c | 14 ++ drivers/gpu/drm/display/drm_dp_mst_topology.c | 2 +- include/drm/display/drm_dp_helper.h

[PATCH 1/3] drm/dp: extract drm_dp_dpcd_poll_act_handled()

2024-11-18 Thread Jani Nikula
SST with 128b/132b channel coding needs this too. Extract to a separate helper, independent of MST. Pass timeout in as a parameter, anticipating that we can reduce the timeout for SST. Signed-off-by: Jani Nikula --- drivers/gpu/drm/display/drm_dp_helper.c | 54 ++- drivers

[PATCH 0/3] drm/dp: extract payload helpers

2024-11-18 Thread Jani Nikula
Add some mst topology manager independent payload helpers. Jani Nikula (3): drm/dp: extract drm_dp_dpcd_poll_act_handled() drm/dp: extract drm_dp_dpcd_write_payload() drm/dp: extract drm_dp_dpcd_clear_payload() drivers/gpu/drm/display/drm_dp_helper.c | 124 +- drivers

RE: [PATCH v7 2/4] drm: make drm-active- stats optional

2024-11-18 Thread Li, Yunxiang (Teddy)
[Public] > From: Tvrtko Ursulin > Sent: Monday, November 11, 2024 5:30 > On 10/11/2024 15:41, Yunxiang Li wrote: > > Make drm-active- optional just like drm-resident- and drm-purgeable-. > > As Jani has already commented the commit message needs some work. > > > Signed-off-by: Yunxiang Li > > CC

Re: [PATCH 3/4] drm/i915/dp_mst: Expose a connector to kernel users after it's properly initialized

2024-11-18 Thread Jani Nikula
On Fri, 15 Nov 2024, Imre Deak wrote: > After a connector is added to the drm_mode_config::connector_list, it's > visible to any in-kernel users looking up connectors via the above list. > Make sure that the connector is properly initialized before such > look-ups. > > Signed-off-by: Imre Deak >

RE: [PATCH v8 2/5] drm: make drm-active- stats optional

2024-11-18 Thread Li, Yunxiang (Teddy)
[Public] Indeed I have, thanks for the reminder Teddy

Re: [PATCH] drm/radeon: Fix spurious unplug event on radeon HDMI

2024-11-18 Thread Alex Deucher
Applied. Thanks! Alex On Sat, Nov 16, 2024 at 4:51 AM Steven 'Steve' Kendall wrote: > > On several HP models (tested on HP 3125 and HP Probook 455 G2), > spurious unplug events are emitted upon login on Chrome OS. > This is likely due to the way Chrome OS restarts graphics > upon login, so it's

[PATCH v13 3/7] drm/vkms: Drop YUV formats TODO

2024-11-18 Thread Louis Chauvet
From: Arthur Grillo VKMS has support for YUV formats now. Remove the task from the TODO list. Signed-off-by: Arthur Grillo Signed-off-by: Louis Chauvet --- Documentation/gpu/vkms.rst | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/Documentation/gpu/vkms.rst b/Documentati

[PATCH v13 1/7] drm/vkms: Add YUV support

2024-11-18 Thread Louis Chauvet
From: Arthur Grillo Add support to the YUV formats bellow: - NV12/NV16/NV24 - NV21/NV61/NV42 - YUV420/YUV422/YUV444 - YVU420/YVU422/YVU444 The conversion from yuv to rgb is done with fixed-point arithmetic, using 32.32 fixed-point numbers and the drm_fixed helpers. To do the conversion, a spec

[PATCH v13 6/7] drm/vkms: Add how to run the Kunit tests

2024-11-18 Thread Louis Chauvet
From: Arthur Grillo Now that we have KUnit tests, add instructions on how to run them. Signed-off-by: Arthur Grillo Signed-off-by: Louis Chauvet --- Documentation/gpu/vkms.rst | 11 +++ 1 file changed, 11 insertions(+) diff --git a/Documentation/gpu/vkms.rst b/Documentation/gpu/vkms.

[PATCH v14 4/9] drm/vkms: Use const for input pointers in pixel_read an pixel_write functions

2024-11-18 Thread Louis Chauvet
As the pixel_read and pixel_write function should never modify the input buffer, mark those pointers const. Reviewed-by: Pekka Paalanen Reviewed-by: Maíra Canal Reviewed-by: José Expósito Signed-off-by: Louis Chauvet --- drivers/gpu/drm/vkms/vkms_drv.h | 4 ++-- drivers/gpu/drm/vkms/vkms

[PATCH v13 7/7] drm/vkms: Add support for DRM_FORMAT_R*

2024-11-18 Thread Louis Chauvet
This add the support for: - R1/R2/R4/R8 R1 format was tested with [1] and [2]. [1]: https://lore.kernel.org/r/20240313-new_rotation-v2-0-6230fd5ca...@bootlin.com [2]: https://lore.kernel.org/igt-dev/20240306-b4-kms_tests-v1-0-8fe451efd...@bootlin.com/ Reviewed-by: Pekka Paalanen Signed-off-by

Re: [PATCH V11 00/10] AMD XDNA driver

2024-11-18 Thread Jeffrey Hugo
On 11/18/2024 10:29 AM, Lizhi Hou wrote: This patchset introduces a new Linux Kernel Driver, amdxdna for AMD NPUs. The driver is based on Linux accel subsystem. Not seeing any additional issues. Build for bisect looks good. My plan is to let this sit on list until Friday to allow for one fin

Re: [PATCH v13 5/9] drm/vkms: Update pixels accessor to support packed and multi-plane formats.

2024-11-18 Thread José Expósito
On Mon, Nov 18, 2024 at 06:17:11PM +0100, Louis Chauvet wrote: > On 18/11/24 - 18:10, José Expósito wrote: > > > Introduce the usage of block_h/block_w to compute the offset and the > > > pointer of a pixel. The previous implementation was specialized for > > > planes with block_h == block_w == 1.

[PATCH v5 drm-dp 3/5] drm/hisilicon/hibmc: add dp hw moduel in hibmc

2024-11-18 Thread Yongbang Shi
From: baihan li Build a dp level that hibmc driver can enable dp by calling their functions. Signed-off-by: Baihan Li Signed-off-by: Yongbang Shi --- ChangeLog: v3 -> v4: - changed the type of train_set to array, suggested by Dmitry Baryshkov. - using actual link rate instead of magic num,

[PATCH v5 drm-dp 0/5] Add dp module in hibmc driver

2024-11-18 Thread Yongbang Shi
From: baihan li Realizing the basic display function of DP cable for DP connector displaying. Add DP module in hibmc drm driver, which is for Hisilicon Hibmc SoC which used for Out-of-band management. Blow is the general hardware connection, both the Hibmc and the host CPU are on the same mother

RE: [PATCH v8 3/5] Documentation/gpu: Clarify drm memory stats definition

2024-11-18 Thread Li, Yunxiang (Teddy)
[Public] > From: Tvrtko Ursulin > Sent: Monday, November 18, 2024 9:38 > On 16/11/2024 04:44, Yunxiang Li wrote: > > Define how to handle buffers with multiple possible placement so we > > don't get incompatible implementations. Callout the resident > > requirement for drm-purgeable- explicitly.

Re: [PULL] drm-misc-next

2024-11-18 Thread Nathan Chancellor
On Thu, Oct 31, 2024 at 02:41:38PM +0100, Maarten Lankhorst wrote: > Cristian Ciocaltea (3): > drm/rockchip: Add basic RK3588 HDMI output support Can someone please apply [1] to resolve a link time failure seen with 32-bit clang builds? I am still seeing it in -next and my ping on the patch

Re: [PATCH v8 3/5] Documentation/gpu: Clarify drm memory stats definition

2024-11-18 Thread Tvrtko Ursulin
On 18/11/2024 14:56, Li, Yunxiang (Teddy) wrote: [Public] From: Tvrtko Ursulin Sent: Monday, November 18, 2024 9:38 On 16/11/2024 04:44, Yunxiang Li wrote: Define how to handle buffers with multiple possible placement so we don't get incompatible implementations. Callout the resident requir

[Bug 219507] nouveau: GeForce GT 710: irq 166 handler nvkm_intr+0x0/0x1b3 [nouveau] enabled interrupts

2024-11-18 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=219507 --- Comment #3 from Paul Osmialowski (newch...@king.net.pl) --- Ah yes yes, I've unmasked 6.12.0-gentoo and it happens there too. -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assigne

[PATCHv2 1/3] drm/plane: Add new plane property IN_FORMATS_ASYNC

2024-11-18 Thread Arun R Murthy
There exists a property IN_FORMATS which exposes the plane supported modifiers/formats to the user. In some platforms when asynchronous flips are used all of modifiers/formats mentioned in IN_FORMATS are not supported. This patch adds a new plane property IN_FORMATS_ASYNC to expose the async flips

[PATCH v5 drm-dp 2/5] drm/hisilicon/hibmc: add dp link moduel in hibmc

2024-11-18 Thread Yongbang Shi
From: baihan li Add link training process functions in this moduel. Signed-off-by: Baihan Li Signed-off-by: Yongbang Shi --- Changelog: v3 -> v4: - optimizing hibmc_dp_link_get_adjust_train() to delete for loop, suggested by Dmitry Baryshkov. - changing ELNRNG to EIO error code, suggested

[PATCH v5 drm-dp 4/5] drm/hisilicon/hibmc: separate struct of vdac

2024-11-18 Thread Yongbang Shi
From: baihan li Refactored struct hibmc_drm_private to separate VGA module from generic struct. Signed-off-by: Baihan Li Signed-off-by: Yongbang Shi --- ChangeLog: v3 -> v4: - separating hibmc_vdac and hibmc_dp changes into separate patche, suggested by Dmitry Baryshkov. v2 -> v3: - fix b

Re: [PATCH v8 3/5] Documentation/gpu: Clarify drm memory stats definition

2024-11-18 Thread Tvrtko Ursulin
On 16/11/2024 04:44, Yunxiang Li wrote: Define how to handle buffers with multiple possible placement so we don't get incompatible implementations. Callout the resident requirement for drm-purgeable- explicitly. Remove the requirement for there to be only drm-memory- or only drm-resident-, it's

[PATCH v1 1/4] misc: fastrpc: Move fastrpc driver to misc/fastrpc/

2024-11-18 Thread Ekansh Gupta
Move fastrpc.c from misc/ to misc/fastrpc/. New C files are planned to be added for PD notifications and other missing features. Adding and maintaining new files from within fastrpc directory would be easy. Example of feature that is being planned to be introduced in a new C file: https://lore.ker

Re: [PATCH RFC 6/8] drm/msm: adreno: enable GMU bandwidth for A740 and A750

2024-11-18 Thread Dmitry Baryshkov
On Mon, 18 Nov 2024 at 15:43, Neil Armstrong wrote: > > On 15/11/2024 15:39, Dmitry Baryshkov wrote: > > On Fri, Nov 15, 2024 at 10:20:01AM +0100, Neil Armstrong wrote: > >> On 15/11/2024 08:33, Dmitry Baryshkov wrote: > >>> On Wed, Nov 13, 2024 at 04:48:32PM +0100, Neil Armstrong wrote: > No

[PATCH v13 2/7] drm/vkms: Add range and encoding properties to the plane

2024-11-18 Thread Louis Chauvet
From: Arthur Grillo Now that the driver internally handles these quantization ranges and YUV encoding matrices, expose the UAPI for setting them. Signed-off-by: Arthur Grillo [Louis Chauvet: retained only relevant parts, updated the commit message] Acked-by: Pekka Paalanen Signed-off-by: Louis

[PATCH v13 4/7] drm: Export symbols to use in tests

2024-11-18 Thread Louis Chauvet
The functions drm_get_color_encoding_name and drm_get_color_range_name are useful for clarifying test results. Therefore, export them so they can be used in tests built as modules. --- drivers/gpu/drm/drm_color_mgmt.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/drm_color_

Re: [PATCH v2 02/21] coccinelle: misc: Add secs_to_jiffies script

2024-11-18 Thread Easwar Hariharan
On 11/16/2024 1:52 AM, Christophe Leroy wrote: > > > Le 15/11/2024 à 22:26, Easwar Hariharan a écrit : >> [Vous ne recevez pas souvent de courriers de >> eahar...@linux.microsoft.com. Découvrez pourquoi ceci est important à >> https://aka.ms/LearnAboutSenderIdentification ] >> > > There should b

Re: [PATCH v13 0/7] drm/vkms: Add support for YUV and DRM_FORMAT_R*

2024-11-18 Thread Louis Chauvet
On 18/11/24 - 19:43, Louis Chauvet wrote: > This series depends on [1]. > > This patchset is extracted from [1]. The goal is to introduce the YUV > support, thanks to Arthur's work. > > - PATCH 1: Add the support of YUV formats > - PATCH 2: Add some drm properties to expose more YUV features > -

[PATCH v13 5/7] drm/vkms: Create KUnit tests for YUV conversions

2024-11-18 Thread Louis Chauvet
From: Arthur Grillo Create KUnit tests to test the conversion between YUV and RGB. Test each conversion and range combination with some common colors. The code used to compute the expected result can be found in comment. [Louis Chauvet: - fix minor formating issues (whitespace, double line) - c

[PATCH v13 0/7] drm/vkms: Add support for YUV and DRM_FORMAT_R*

2024-11-18 Thread Louis Chauvet
This series depends on [1]. This patchset is extracted from [1]. The goal is to introduce the YUV support, thanks to Arthur's work. - PATCH 1: Add the support of YUV formats - PATCH 2: Add some drm properties to expose more YUV features - PATCH 3: Cleanup the todo - PATCH 4..6: Add some kunit tes

[Bug 219507] nouveau: GeForce GT 710: irq 166 handler nvkm_intr+0x0/0x1b3 [nouveau] enabled interrupts

2024-11-18 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=219507 --- Comment #4 from Paul Osmialowski (newch...@king.net.pl) --- As suggested, I've opened freedesktop issue: https://gitlab.freedesktop.org/drm/nouveau/-/issues/394 -- You may reply to this email to add a comment. You are receiving this mail be

Re: [PATCH] drm/bridge: tc358767: Fix odd pixel alignment

2024-11-18 Thread Marek Vasut
On 11/18/24 4:19 PM, Maxime Ripard wrote: On Mon, Oct 28, 2024 at 03:49:42PM +0100, Marek Vasut wrote: On 10/28/24 2:52 PM, Maxime Ripard wrote: On Mon, Oct 28, 2024 at 01:36:58PM +0100, Marek Vasut wrote: On 10/28/24 10:25 AM, Maxime Ripard wrote: On Sat, Oct 26, 2024 at 06:10:01AM +0200, Ma

Re: [PATCH] drm/panthor: Simplify FW fast reset path

2024-11-18 Thread Liviu Dudau
On Mon, Nov 18, 2024 at 03:21:52PM +, Karunika Choo wrote: > Stop checking the FW halt_status as MCU_STATUS should be sufficient. > This should make the check for successful FW halt and subsequently > setting fast_reset to true more robust. > > We should also clear GLB_REQ.GLB_HALT bit only on

Re: [PATCH v2 00/21] Converge on using secs_to_jiffies()

2024-11-18 Thread Easwar Hariharan
On 11/16/2024 2:23 AM, LEROY Christophe wrote: > > > Le 15/11/2024 à 22:26, Easwar Hariharan a écrit : >> [Vous ne recevez pas souvent de courriers de eahar...@linux.microsoft.com. >> Découvrez pourquoi ceci est important à >> https://aka.ms/LearnAboutSenderIdentification ] >> >> This is a seri

Re: [PATCH v2 02/21] coccinelle: misc: Add secs_to_jiffies script

2024-11-18 Thread Easwar Hariharan
On 11/15/2024 10:05 PM, Christophe JAILLET wrote: > Le 15/11/2024 à 22:26, Easwar Hariharan a écrit : >> Suggested-by: Anna-Maria Behnsen >> Signed-off-by: Easwar Hariharan >> --- >> scripts/coccinelle/misc/secs_to_jiffies.cocci | 21 + >> 1 file changed, 21 insertions(+) >

Re: [PATCH 3/4] drm/i915/dp_mst: Expose a connector to kernel users after it's properly initialized

2024-11-18 Thread Imre Deak
On Mon, Nov 18, 2024 at 02:12:14PM +0200, Jani Nikula wrote: > On Fri, 15 Nov 2024, Imre Deak wrote: > > After a connector is added to the drm_mode_config::connector_list, it's > > visible to any in-kernel users looking up connectors via the above list. > > Make sure that the connector is properly

  1   2   3   >