Re: [PATCH v3 1/3] vop2: Add clock resets support

Hi Detlev, Am Freitag, 8. November 2024, 19:50:39 CET schrieb Detlev Casanova: > At the end of initialization, each VP clock needs to be reset before > they can be used. > > Failing to do so can put the VOP in an undefined state where the > generated HDMI signal is either lost or not matching the

Re: [PATCH 1/2] drm/rockchip: vop2: fix rk3588 dp+dsi maxclk verification

Hi Andy, On 11/14/24 1:50 AM, Andy Yan wrote: Hi, At 2024-05-06 15:44:36, "Quentin Schulz" wrote: Hi Heiko, On 4/25/24 9:55 PM, Heiko Stuebner wrote: From: Heiko Stuebner The clock is in Hz while the value checked against is in kHz, so actual frequencies will never be able to be below to

Re: [PATCH] drm/bridge: adv7511_audio: Update Audio InfoFrame properly

On Wed, Nov 13, 2024 at 08:38:11AM +0100, Stefan Ekenberg wrote: > AUDIO_UPDATE bit (Bit 5 of MAIN register 0x4A) needs to be set to 1 > while updating Audio InfoFrame information and then set to 0 when done. > Otherwise partially updated Audio InfoFrames could be sent out. Two > cases where this r

Re: [PATCH] drm/bridge: adv7533: Reset DSI receiver logic

On Wed, Nov 13, 2024 at 08:40:15AM +0100, Stefan Ekenberg wrote: > Reset DSI receiver logic during power on. The need for this change was > discovered when investigating issue with ADV7535. The symptom of the > problem was that ADV7535 continuously outputs a black image. This > happened for about 1

Re: [PATCH RFC 3/8] drm/msm: adreno: add plumbing to generate bandwidth vote table for GMU

On 15/11/2024 08:20, Dmitry Baryshkov wrote: On Wed, Nov 13, 2024 at 04:48:29PM +0100, Neil Armstrong wrote: The Adreno GMU Management Unit (GMU) can also scale DDR Bandwidth along the Frequency and Power Domain level, but by default we leave the OPP core scale the interconnect ddr path. In ord

Re: [PATCH RFC 5/8] drm/msm: adreno: find bandwidth index of OPP and set it along freq index

On 15/11/2024 08:28, Dmitry Baryshkov wrote: On Wed, Nov 13, 2024 at 04:48:31PM +0100, Neil Armstrong wrote: The Adreno GMU Management Unit (GMU) can also scale the DDR Bandwidth along the Frequency and Power Domain level, until now we left the OPP core scale the OPP bandwidth via the interconne

Re: [PATCH v6 2/7] drm/sched: store the drm client_id in drm_sched_fence

On 14/11/2024 10:01, Pierre-Eric Pelloux-Prayer wrote: > This will be used in a later commit to trace the drm client_id in > some of the gpu_scheduler trace events. > > Signed-off-by: Pierre-Eric Pelloux-Prayer > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 2 +- > drivers/gpu/drm/amd/a

[PATCH v14 1/8] drm/ttm: Balance ttm_resource_cursor_init() and ttm_resource_cursor_fini()

Make the interface more symmetric by providing and using a ttm_resource_cursor_init(). v10: - Fix a stray newline (Matthew Brost) - Update kerneldoc (Matthew Brost) Signed-off-by: Thomas Hellström Reviewed-by: Matthew Brost Reviewed-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c |

[PATCH v14 8/8] drm/xe: Increase the XE_PL_TT watermark

The XE_PL_TT watermark was set to 50% of system memory. The idea behind that was unclear since the net effect is that TT memory will be evicted to TTM_PL_SYSTEM memory if that watermark is exceeded, requiring PPGTT rebinds and dma remapping. But there is no similar watermark for TTM_PL_1SYSTEM memo

[PATCH v14 7/8] drm/xe: Add a shrinker for xe bos

Rather than relying on the TTM watermark accounting add a shrinker for xe_bos in TT or system memory. Leverage the newly added TTM per-page shrinking and shmem backup support. Although xe doesn't fully support WONTNEED (purgeable) bos yet, introduce and add shrinker support for purgeable ttm_tts.

[PATCH v14 4/8] drm/ttm: Use fault-injection to test error paths

Use fault-injection to test partial TTM swapout and interrupted swapin. Return -EINTR for swapin to test the callers ability to handle and restart the swapin, and on swapout perform a partial swapout to test that the swapin and release_shrunken functionality. v8: - Use the core fault-injection sys

[PATCH v14 3/8] drm/ttm/pool: Provide a helper to shrink pages

Provide a helper to shrink ttm_tt page-vectors on a per-page basis. A ttm_backup backend could then in theory get away with allocating a single temporary page for each struct ttm_tt. This is accomplished by splitting larger pages before trying to back them up. In the future we could allow ttm_bac

[PATCH v14 6/8] drm/ttm: Add helpers for shrinking

Add a number of helpers for shrinking that access core TTM and core MM functionality in a way that make them unsuitable for driver open-coding. v11: - New patch (split off from previous) and additional helpers. v13: - Adapt to ttm_backup interface change. - Take resource off LRU when backed up. S

[PATCH v14 2/8] drm/ttm: Provide a shmem backup implementation

Provide a standalone shmem backup implementation. Given the ttm_backup interface, this could later on be extended to providing other backup implementation than shmem, with one use-case being GPU swapout to a user-provided fd. v5: - Fix a UAF. (kernel test robot, Dan Carptenter) v6: - Rename ttm_ba

[PATCH v14 0/8] TTM shrinker helpers and xe buffer object shrinker

This series implements TTM shrinker / eviction helpers and an xe bo shrinker. It builds on a previous series, *and obsoletes that one*. https://lore.kernel.org/linux-mm/b7491378-defd-4f1c-31e2-29e4c77e2...@amd.com/T/ Where the comment about layering https://lore.kernel.org/linux-mm/b7491378-defd-

[PATCH v14 5/8] drm/ttm: Add a macro to perform LRU iteration

Following the design direction communicated here: https://lore.kernel.org/linux-mm/b7491378-defd-4f1c-31e2-29e4c77e2...@amd.com/T/#ma918844aa8a6efe8768fdcda0c6590d5c93850c9 Export a LRU walker for driver shrinker use. The walker initially supports only trylocking, since that's the method used by

Re: [PATCH v6 2/7] drm/sched: store the drm client_id in drm_sched_fence

On Thu, 2024-11-14 at 11:01 +0100, Pierre-Eric Pelloux-Prayer wrote: > This will be used in a later commit to trace the drm client_id in > some of the gpu_scheduler trace events. I think this commit message should detail what the patch is actual intended to do. Especially, it should mention that

Re: [PATCH v6 3/7] drm/sched: add device name to the drm_sched_process_job event

On Thu, 2024-11-14 at 11:01 +0100, Pierre-Eric Pelloux-Prayer wrote: > Until the switch from kthread to workqueue, Could you include the commit ID here where that happened? "Since switching the scheduler from using kthreads to workqueues in commit 1234 ("foo: bar") userspace applications cannot

[PATCH] drm/amd/display: Allow building DC with clang on LoongArch

Clang on LoongArch (18+) appears to be unaffected by the bug causing excessive stack usage in calculate_bandwidth(). But when building DC_FP support the stack frame size can be as large as 2816 bytes, which causes the FRAME_WARN build warnings. So on LoongArch we allow building DC with clang, but d

[PATCH v2] drm/rockchip: vop2: fix rk3588 dp+dsi maxclk verification

From: Heiko Stuebner The clock is in Hz while the value checked against is in kHz, so actual frequencies will never be able to be below to max value. Fix this by specifying the max-value in Hz too. Fixes: 5a028e8f062f ("drm/rockchip: vop2: Add support for rk3588") Signed-off-by: Heiko Stuebner

Re: [PATCH v6 4/7] drm/sched: cleanup gpu_scheduler trace events

On Thu, 2024-11-14 at 11:01 +0100, Pierre-Eric Pelloux-Prayer wrote: > A fence uniquely identify a job, so this commits updates the places s/identify/identifies > where a kernel pointer was used as an identifier by: But better sth like this: "Currently, the scheduler's tracing infrastructure us

Re: [PATCH 03/22] arm: pxa: Convert timeouts to use secs_to_jiffies()

Hi Easwar, On Fri, 15 Nov 2024 21:22:33 + Easwar Hariharan wrote: > > -#define SHARPSL_CHARGE_ON_TIME_INTERVAL(msecs_to_jiffies(1*60*1000)) > /* 1 min */ > -#define SHARPSL_CHARGE_FINISH_TIME > (msecs_to_jiffies(10*60*1000)) /* 10 min */ > -#define SHARPSL_BATCHK_TIME

Re: [PATCH 1/4] drm/i915/dp_mst: Fix connector initialization in intel_dp_add_mst_connector()

On Fri, Nov 15, 2024 at 10:30:12PM +0200, Imre Deak wrote: > On Fri, Nov 15, 2024 at 03:20:58PM -0500, Rodrigo Vivi wrote: > > On Fri, Nov 15, 2024 at 06:41:56PM +0200, Imre Deak wrote: > > > The connector initialization in intel_dp_add_mst_connector() depends on > > > the device pointer in connect

Re: [PATCH v2 01/21] netfilter: conntrack: Cleanup timeout definitions

On 11/15/2024 2:34 PM, Stephen Rothwell wrote: > Hi Easwar, > > On Fri, 15 Nov 2024 21:26:18 + Easwar Hariharan > wrote: >> >> static const unsigned int sctp_timeouts[SCTP_CONNTRACK_MAX] = { >> -[SCTP_CONNTRACK_CLOSED] = 10 SECS, >> -[SCTP_CONNTRACK_COOKIE_WAIT]

Re: [PATCH 03/22] arm: pxa: Convert timeouts to use secs_to_jiffies()

On 11/15/2024 2:38 PM, Stephen Rothwell wrote: > Hi Easwar, > > On Fri, 15 Nov 2024 21:22:33 + Easwar Hariharan > wrote: >> >> -#define SHARPSL_CHARGE_ON_TIME_INTERVAL >> (msecs_to_jiffies(1*60*1000)) /* 1 min */ >> -#define SHARPSL_CHARGE_FINISH_TIME >> (msecs_to_jiffi

[git pull] drm fixes for 6.12-rc8

Hi Linus, Final week of fixes, lots of small amdgpu fixes, some i915 and xe fixes, the nouveau changes fix a recent regression and some laptop panel black screens, then a couple of other misc ones. It's probably a little busier than I'd like, but each fix seems fine. Dave. drm-fixes-2024-11-16:

[PATCH v2 13/21] xen/blkback: Convert timeouts to secs_to_jiffies()

Changes made with the following Coccinelle rules: @@ constant C; @@ - msecs_to_jiffies(C * 1000) + secs_to_jiffies(C) @@ constant C; @@ - msecs_to_jiffies(C * MSEC_PER_SEC) + secs_to_jiffies(C) Signed-off-by: Easwar Hariharan --- drivers/block/xen-blkback/blkback.c | 2 +- 1 file changed, 1

[PATCH v2 10/21] scsi: lpfc: Convert timeouts to secs_to_jiffies()

Changes made with the following Coccinelle rules: @@ constant C; @@ - msecs_to_jiffies(C * 1000) + secs_to_jiffies(C) @@ constant C; @@ - msecs_to_jiffies(C * MSEC_PER_SEC) + secs_to_jiffies(C) Signed-off-by: Easwar Hariharan --- drivers/scsi/lpfc/lpfc_init.c | 18 +- dr

[PATCH 11/22] scsi: arcmsr: Convert timeouts to secs_to_jiffies()

Changes made with the following Coccinelle rules: @@ constant C; @@ - msecs_to_jiffies(C * 1000) + secs_to_jiffies(C) @@ constant C; @@ - msecs_to_jiffies(C * MSEC_PER_SEC) + secs_to_jiffies(C) Signed-off-by: Easwar Hariharan --- drivers/scsi/arcmsr/arcmsr_hba.c | 2 +- 1 file changed, 1 ins

[PATCH 17/22] staging: vc04_services: Convert timeouts to secs_to_jiffies()

Changes made with the following Coccinelle rules: @@ constant C; @@ - msecs_to_jiffies(C * 1000) + secs_to_jiffies(C) @@ constant C; @@ - msecs_to_jiffies(C * MSEC_PER_SEC) + secs_to_jiffies(C) Signed-off-by: Easwar Hariharan --- drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c |

Re: [PATCH 22/22] jiffies: Define secs_to_jiffies()

On 11/15/2024 1:22 PM, Easwar Hariharan wrote: > secs_to_jiffies() is defined in hci_event.c and cannot be reused by > other call sites. Hoist it into the core code to allow conversion of the > ~1150 usages of msecs_to_jiffies() that either: > > - use a multiplier value of 1000 or equivalently MS

[PATCH 12/22] scsi: pm8001: Convert timeouts to secs_to_jiffies()

Changes made with the following Coccinelle rules: @@ constant C; @@ - msecs_to_jiffies(C * 1000) + secs_to_jiffies(C) @@ constant C; @@ - msecs_to_jiffies(C * MSEC_PER_SEC) + secs_to_jiffies(C) Signed-off-by: Easwar Hariharan --- drivers/scsi/pm8001/pm8001_init.c | 2 +- 1 file changed, 1 in

[PATCH 13/22] xen/blkback: Convert timeouts to secs_to_jiffies()

Changes made with the following Coccinelle rules: @@ constant C; @@ - msecs_to_jiffies(C * 1000) + secs_to_jiffies(C) @@ constant C; @@ - msecs_to_jiffies(C * MSEC_PER_SEC) + secs_to_jiffies(C) Signed-off-by: Easwar Hariharan --- drivers/block/xen-blkback/blkback.c | 2 +- 1 file changed, 1

Re: [PATCH v2] drm/xe/hw_engine_group: Fix bad free in xe_hw_engine_setup_groups()

On Fri, Nov 15, 2024 at 10:49:42AM +0800, Su Hui wrote: > Clang static checker(scan-build) warning： > drivers/gpu/drm/xe/xe_hw_engine_group.c: line 134, column 2 > Argument to kfree() is a constant address (18446744073709551604), which > is not memory allocated by malloc(). > > kfree() can only ha

[PATCH v2 16/21] Bluetooth: MGMT: Convert timeouts to secs_to_jiffies()

Changes made with the following Coccinelle rules: @@ constant C; @@ - msecs_to_jiffies(C * 1000) + secs_to_jiffies(C) @@ constant C; @@ - msecs_to_jiffies(C * MSEC_PER_SEC) + secs_to_jiffies(C) Signed-off-by: Easwar Hariharan --- net/bluetooth/mgmt.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH v2 07/21] accel/habanalabs: Convert timeouts to secs_to_jiffies()

Changes made with the following Coccinelle rules: @@ constant C; @@ - msecs_to_jiffies(C * 1000) + secs_to_jiffies(C) @@ constant C; @@ - msecs_to_jiffies(C * MSEC_PER_SEC) + secs_to_jiffies(C) Signed-off-by: Easwar Hariharan --- drivers/accel/habanalabs/common/device.c | 2 +- drive

[PATCH v2 02/21] coccinelle: misc: Add secs_to_jiffies script

Suggested-by: Anna-Maria Behnsen Signed-off-by: Easwar Hariharan --- scripts/coccinelle/misc/secs_to_jiffies.cocci | 21 + 1 file changed, 21 insertions(+) diff --git a/scripts/coccinelle/misc/secs_to_jiffies.cocci b/scripts/coccinelle/misc/secs_to_jiffies.cocci new file mo

[PATCH v2 08/21] drm/xe: Convert timeout to secs_to_jiffies()

Changes made with the following Coccinelle rules: @@ constant C; @@ - msecs_to_jiffies(C * 1000) + secs_to_jiffies(C) @@ constant C; @@ - msecs_to_jiffies(C * MSEC_PER_SEC) + secs_to_jiffies(C) Signed-off-by: Easwar Hariharan --- drivers/gpu/drm/xe/xe_device.c | 2 +- 1 file changed, 1 inser

[PATCH v2 19/21] livepatch: Convert timeouts to secs_to_jiffies()

Changes made with the following Coccinelle rules: @@ constant C; @@ - msecs_to_jiffies(C * 1000) + secs_to_jiffies(C) @@ constant C; @@ - msecs_to_jiffies(C * MSEC_PER_SEC) + secs_to_jiffies(C) Signed-off-by: Easwar Hariharan --- samples/livepatch/livepatch-callbacks-busymod.c | 2 +- sampl

[PATCH v2 14/21] gve: Convert timeouts to secs_to_jiffies()

Changes made with the following Coccinelle rules: @@ constant C; @@ - msecs_to_jiffies(C * 1000) + secs_to_jiffies(C) @@ constant C; @@ - msecs_to_jiffies(C * MSEC_PER_SEC) + secs_to_jiffies(C) Signed-off-by: Easwar Hariharan --- drivers/net/ethernet/google/gve/gve_tx_dqo.c | 6 ++ 1 fil

[PATCH v2 00/21] Converge on using secs_to_jiffies()

bulletpoints and terse descriptions. - Link to v1: https://lore.kernel.org/r/20241115-converge-secs-to-jiffies-v1-0-19aadc349...@linux.microsoft.com --- Easwar Hariharan (21): netfilter: conntrack: Cleanup timeout definitions coccinelle: misc: Add secs_to_jiffies script arm: pxa: Convert

Re: [PATCH v2 01/21] netfilter: conntrack: Cleanup timeout definitions

Hi Easwar, On Fri, 15 Nov 2024 21:26:18 + Easwar Hariharan wrote: > > static const unsigned int sctp_timeouts[SCTP_CONNTRACK_MAX] = { > - [SCTP_CONNTRACK_CLOSED] = 10 SECS, > - [SCTP_CONNTRACK_COOKIE_WAIT]= 3 SECS, > - [SCTP_CONNTRACK_COOKIE_ECHOED]

Re: [PATCH 1/2] drm/sched: add WARN_ON and BUG_ON to drm_sched_fini

On Fri, 2024-11-15 at 15:39 +0100, Christian König wrote: >  Am 15.11.24 um 14:55 schrieb Philipp Stanner: >   > > [SNIP] > > >   > > > A good bunch of the problems we have here are caused by abusing > > > the > > > job > > > as state for executing the submission on the hardware. > > > > > > The

[PATCH 1/1] drm/bridge: tc358775: Remove burst mode support

Current tc358775 bridge driver implementation assumes that DSI clock is used as a source for LVDS pixel clock. Moreover, clock divider PCLKDIV has a hard-coded value. This means that driver expects DSI clock to always match a panel pixel clock. With such assumption, LVDS pixel clock is configured t

[PATCH 0/1] drm/bridge: tc358775: Remove burst mode support

DSI operation mode is configured to support burst mode, but bridge driver does not correctly implement it. This results in bad LVDS timings when bridge is connected to DSI host that sets higher transmission rate on DSI link, than indicated by CRTC pixel clock. TC358775 power up sequence is still b

[PATCH v2] drm/i2c: tda9950: Constify struct i2c_device_id

'struct i2c_device_id' is not modified in this driver. Constifying this structure moves some data to a read-only section, so increase overall security. On a x86_64, with allmodconfig: Before: == textdata bss dec hex filename 12136 822 0 12958329e drivers/g

Re: [PATCH v4 15/18] dt-bindings: usb: Add ports to google,cros-ec-typec for DP altmode

On Mon, Nov 11, 2024 at 06:16:27PM -0800, Stephen Boyd wrote: > Quoting Dmitry Baryshkov (2024-11-08 23:05:18) > > On Thu, Nov 07, 2024 at 04:28:24PM -0800, Stephen Boyd wrote: > > > Quoting Dmitry Baryshkov (2024-10-31 15:54:49) > > > > On Thu, Oct 31, 2024 at 02:45:29PM -0700, Stephen Boyd wrote:

[PATCH 5/5] drm/connector: make mode_valid accept const struct drm_display_mode

The mode_valid() callbacks of drm_encoder, drm_crtc and drm_bridge accept const struct drm_display_mode argument. Change the mode_valid callback of drm_connector to also accept const argument. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c | 8 -

[PATCH 0/5] drm/connector: make mode_valid() callback accept const mode pointer

ase-commit: 7d2faa8dbb7055a115fe0cd6068d7090094a573d change-id: 20241115-drm-connector-mode-valid-const-ae3db0ef6cb7 Best regards, -- Dmitry Baryshkov

[PATCH 1/5] drm/encoder_slave: make mode_valid accept const struct drm_display_mode

The mode_valid() callbacks of drm_encoder, drm_crtc and drm_bridge accept const struct drm_display_mode argument. Change the mode_valid callback of drm_encoder_slave to also accept const argument. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/i2c/ch7006_drv.c | 2 +- drivers/gpu/d

[PATCH 2/5] drm/amdgpu: don't change mode in amdgpu_dm_connector_mode_valid()

Make amdgpu_dm_connector_mode_valid() duplicate the mode during the test rather than modifying the passed mode. This is a preparation to converting the mode_valid() callback of drm_connector to accept const struct drm_display_mode argument. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/amd

[PATCH 3/5] drm/sti: hda: pass const struct drm_display_mode* to hda_get_mode_idx()

Make hda_get_mode_idx() accept const struct drm_display_mode pointer instead of just raw struct drm_display_mode. This is a preparation to converting the mode_valid() callback of drm_connector to accept const struct drm_display_mode argument. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/

[PATCH 4/5] drm/connector: make mode_valid_ctx accept const struct drm_display_mode

The mode_valid() callbacks of drm_encoder, drm_crtc and drm_bridge accept const struct drm_display_mode argument. Change the mode_valid_ctx callback of drm_connector to also accept const argument. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/i915/display/intel_dp_mst.c | 2 +- include/drm

[PATCH 04/22] s390: kernel: Convert timeouts to use secs_to_jiffies()

Changes made with the following Coccinelle rules: @@ constant C; @@ - msecs_to_jiffies(C * 1000) + secs_to_jiffies(C) @@ constant C; @@ - msecs_to_jiffies(C * MSEC_PER_SEC) + secs_to_jiffies(C) Signed-off-by: Easwar Hariharan --- arch/s390/kernel/lgr.c | 3 ++- arch/s390/kernel/time.c

[PATCH 07/22] accel/habanalabs: Convert timeouts to secs_to_jiffies()

Changes made with the following Coccinelle rules: @@ constant C; @@ - msecs_to_jiffies(C * 1000) + secs_to_jiffies(C) @@ constant C; @@ - msecs_to_jiffies(C * MSEC_PER_SEC) + secs_to_jiffies(C) Signed-off-by: Easwar Hariharan --- drivers/accel/habanalabs/common/device.c | 2 +- drive

[PATCH 06/22] mm: kmemleak: Convert timeouts to secs_to_jiffies()

Changes made with the following Coccinelle rules: @@ constant C; @@ - msecs_to_jiffies(C * 1000) + secs_to_jiffies(C) @@ constant C; @@ - msecs_to_jiffies(C * MSEC_PER_SEC) + secs_to_jiffies(C) Signed-off-by: Easwar Hariharan --- mm/kmemleak.c | 4 ++-- 1 file changed, 2 insertions(+), 2 del

[PATCH 01/22] netfilter: conntrack: Cleanup timeout definitions

None of the higher order definitions are used anymore, so remove definitions for minutes, hours, and days timeouts. Convert the seconds denominated timeouts to secs_to_jiffies() Signed-off-by: Easwar Hariharan --- net/netfilter/nf_conntrack_proto_sctp.c | 21 - 1 file changed

[PATCH 00/22] Converge on using secs_to_jiffies()

This is a series that follows up on my previous series to introduce secs_to_jiffies() and convert a few initial users.[1] In the review for that series, Anna-Maria requested converting other users with Coccinelle. This is part 1 that converts users of msecs_to_jiffies() that use the multiply patter

[PATCH 02/22] coccinelle: misc: Add secs_to_jiffies script

Suggested-by: Anna-Maria Behnsen Signed-off-by: Easwar Hariharan --- scripts/coccinelle/misc/secs_to_jiffies.cocci | 21 + 1 file changed, 21 insertions(+) diff --git a/scripts/coccinelle/misc/secs_to_jiffies.cocci b/scripts/coccinelle/misc/secs_to_jiffies.cocci new file mo

[PATCH 03/22] arm: pxa: Convert timeouts to use secs_to_jiffies()

Changes made with the following Coccinelle rules: @@ constant C; @@ - msecs_to_jiffies(C * 1000) + secs_to_jiffies(C) @@ constant C; @@ - msecs_to_jiffies(C * MSEC_PER_SEC) + secs_to_jiffies(C) Signed-off-by: Easwar Hariharan --- arch/arm/mach-pxa/sharpsl_pm.c | 6 +++--- 1 file changed, 3 i

[PATCH 05/22] powerpc/papr_scm: Convert timeouts to secs_to_jiffies()

Changes made with the following Coccinelle rules: @@ constant C; @@ - msecs_to_jiffies(C * 1000) + secs_to_jiffies(C) @@ constant C; @@ - msecs_to_jiffies(C * MSEC_PER_SEC) + secs_to_jiffies(C) Signed-off-by: Easwar Hariharan --- arch/powerpc/platforms/pseries/papr_scm.c | 2 +- 1 file chang

[PATCH 08/22] drm/xe: Convert timeout to secs_to_jiffies()

Changes made with the following Coccinelle rules: @@ constant C; @@ - msecs_to_jiffies(C * 1000) + secs_to_jiffies(C) @@ constant C; @@ - msecs_to_jiffies(C * MSEC_PER_SEC) + secs_to_jiffies(C) Signed-off-by: Easwar Hariharan --- drivers/gpu/drm/xe/xe_device.c | 2 +- 1 file changed, 1 inser

[PATCH 09/22] drm/etnaviv: Convert timeouts to secs_to_jiffies()

Changes made with the following Coccinelle rules: @@ constant C; @@ - msecs_to_jiffies(C * 1000) + secs_to_jiffies(C) @@ constant C; @@ - msecs_to_jiffies(C * MSEC_PER_SEC) + secs_to_jiffies(C) Signed-off-by: Easwar Hariharan --- drivers/gpu/drm/etnaviv/etnaviv_cmdbuf.c | 2 +- 1 file change

[PATCH 10/22] scsi: lpfc: Convert timeouts to secs_to_jiffies()

Changes made with the following Coccinelle rules: @@ constant C; @@ - msecs_to_jiffies(C * 1000) + secs_to_jiffies(C) @@ constant C; @@ - msecs_to_jiffies(C * MSEC_PER_SEC) + secs_to_jiffies(C) Signed-off-by: Easwar Hariharan --- drivers/scsi/lpfc/lpfc_init.c | 18 +- dr

[PATCH 15/22] wifi: ath11k: Convert timeouts to secs_to_jiffies()

Changes made with the following Coccinelle rules: @@ constant C; @@ - msecs_to_jiffies(C * 1000) + secs_to_jiffies(C) @@ constant C; @@ - msecs_to_jiffies(C * MSEC_PER_SEC) + secs_to_jiffies(C) Signed-off-by: Easwar Hariharan --- drivers/net/wireless/ath/ath11k/debugfs.c | 2 +- 1 file chang

[PATCH 16/22] Bluetooth: MGMT: Convert timeouts to secs_to_jiffies()

Changes made with the following Coccinelle rules: @@ constant C; @@ - msecs_to_jiffies(C * 1000) + secs_to_jiffies(C) @@ constant C; @@ - msecs_to_jiffies(C * MSEC_PER_SEC) + secs_to_jiffies(C) Signed-off-by: Easwar Hariharan --- net/bluetooth/mgmt.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 18/22] ceph: Convert timeouts to secs_to_jiffies()

Changes made with the following Coccinelle rules: @@ constant C; @@ - msecs_to_jiffies(C * 1000) + secs_to_jiffies(C) @@ constant C; @@ - msecs_to_jiffies(C * MSEC_PER_SEC) + secs_to_jiffies(C) Signed-off-by: Easwar Hariharan --- fs/ceph/quota.c | 2 +- 1 file changed, 1 insertion(+), 1 dele

[PATCH 20/22] ALSA: line6: Convert timeouts to secs_to_jiffies()

Changes made with the following Coccinelle rules: @@ constant C; @@ - msecs_to_jiffies(C * 1000) + secs_to_jiffies(C) @@ constant C; @@ - msecs_to_jiffies(C * MSEC_PER_SEC) + secs_to_jiffies(C) Signed-off-by: Easwar Hariharan --- sound/usb/line6/toneport.c | 2 +- 1 file changed, 1 insertion

[PATCH 14/22] gve: Convert timeouts to secs_to_jiffies()

Changes made with the following Coccinelle rules: @@ constant C; @@ - msecs_to_jiffies(C * 1000) + secs_to_jiffies(C) @@ constant C; @@ - msecs_to_jiffies(C * MSEC_PER_SEC) + secs_to_jiffies(C) Signed-off-by: Easwar Hariharan --- drivers/net/ethernet/google/gve/gve_tx_dqo.c | 6 ++ 1 fil

[PATCH 22/22] jiffies: Define secs_to_jiffies()

secs_to_jiffies() is defined in hci_event.c and cannot be reused by other call sites. Hoist it into the core code to allow conversion of the ~1150 usages of msecs_to_jiffies() that either: - use a multiplier value of 1000 or equivalently MSEC_PER_SEC, or - have timeouts that are denominated in s

[PATCH 19/22] livepatch: Convert timeouts to secs_to_jiffies()

Changes made with the following Coccinelle rules: @@ constant C; @@ - msecs_to_jiffies(C * 1000) + secs_to_jiffies(C) @@ constant C; @@ - msecs_to_jiffies(C * MSEC_PER_SEC) + secs_to_jiffies(C) Signed-off-by: Easwar Hariharan --- samples/livepatch/livepatch-callbacks-busymod.c | 2 +- sampl

[PATCH v2 09/21] drm/etnaviv: Convert timeouts to secs_to_jiffies()

Changes made with the following Coccinelle rules: @@ constant C; @@ - msecs_to_jiffies(C * 1000) + secs_to_jiffies(C) @@ constant C; @@ - msecs_to_jiffies(C * MSEC_PER_SEC) + secs_to_jiffies(C) Signed-off-by: Easwar Hariharan --- drivers/gpu/drm/etnaviv/etnaviv_cmdbuf.c | 2 +- 1 file change

[PATCH v2 11/21] scsi: arcmsr: Convert timeouts to secs_to_jiffies()

Changes made with the following Coccinelle rules: @@ constant C; @@ - msecs_to_jiffies(C * 1000) + secs_to_jiffies(C) @@ constant C; @@ - msecs_to_jiffies(C * MSEC_PER_SEC) + secs_to_jiffies(C) Signed-off-by: Easwar Hariharan --- drivers/scsi/arcmsr/arcmsr_hba.c | 2 +- 1 file changed, 1 ins

[PATCH v2 05/21] powerpc/papr_scm: Convert timeouts to secs_to_jiffies()

Changes made with the following Coccinelle rules: @@ constant C; @@ - msecs_to_jiffies(C * 1000) + secs_to_jiffies(C) @@ constant C; @@ - msecs_to_jiffies(C * MSEC_PER_SEC) + secs_to_jiffies(C) Signed-off-by: Easwar Hariharan --- arch/powerpc/platforms/pseries/papr_scm.c | 2 +- 1 file chang

[PATCH v2 18/21] ceph: Convert timeouts to secs_to_jiffies()

Changes made with the following Coccinelle rules: @@ constant C; @@ - msecs_to_jiffies(C * 1000) + secs_to_jiffies(C) @@ constant C; @@ - msecs_to_jiffies(C * MSEC_PER_SEC) + secs_to_jiffies(C) Signed-off-by: Easwar Hariharan --- fs/ceph/quota.c | 2 +- 1 file changed, 1 insertion(+), 1 dele

[PATCH v2 15/21] wifi: ath11k: Convert timeouts to secs_to_jiffies()

Changes made with the following Coccinelle rules: @@ constant C; @@ - msecs_to_jiffies(C * 1000) + secs_to_jiffies(C) @@ constant C; @@ - msecs_to_jiffies(C * MSEC_PER_SEC) + secs_to_jiffies(C) Signed-off-by: Easwar Hariharan --- drivers/net/wireless/ath/ath11k/debugfs.c | 2 +- 1 file chang

[PATCH v2 20/21] ALSA: line6: Convert timeouts to secs_to_jiffies()

Changes made with the following Coccinelle rules: @@ constant C; @@ - msecs_to_jiffies(C * 1000) + secs_to_jiffies(C) @@ constant C; @@ - msecs_to_jiffies(C * MSEC_PER_SEC) + secs_to_jiffies(C) Signed-off-by: Easwar Hariharan --- sound/usb/line6/toneport.c | 2 +- 1 file changed, 1 insertion

[PATCH v2 01/21] netfilter: conntrack: Cleanup timeout definitions

None of the higher order definitions are used anymore, so remove definitions for minutes, hours, and days timeouts. Convert the seconds denominated timeouts to secs_to_jiffies() Signed-off-by: Easwar Hariharan --- net/netfilter/nf_conntrack_proto_sctp.c | 21 - 1 file changed

[PATCH v2 12/21] scsi: pm8001: Convert timeouts to secs_to_jiffies()

Changes made with the following Coccinelle rules: @@ constant C; @@ - msecs_to_jiffies(C * 1000) + secs_to_jiffies(C) @@ constant C; @@ - msecs_to_jiffies(C * MSEC_PER_SEC) + secs_to_jiffies(C) Signed-off-by: Easwar Hariharan --- drivers/scsi/pm8001/pm8001_init.c | 2 +- 1 file changed, 1 in

[PATCH v2 03/21] arm: pxa: Convert timeouts to use secs_to_jiffies()

Changes made with the following Coccinelle rules: @@ constant C; @@ - msecs_to_jiffies(C * 1000) + secs_to_jiffies(C) @@ constant C; @@ - msecs_to_jiffies(C * MSEC_PER_SEC) + secs_to_jiffies(C) Signed-off-by: Easwar Hariharan --- arch/arm/mach-pxa/sharpsl_pm.c | 6 +++--- 1 file changed, 3 i

[PATCH v2 06/21] mm: kmemleak: Convert timeouts to secs_to_jiffies()

Changes made with the following Coccinelle rules: @@ constant C; @@ - msecs_to_jiffies(C * 1000) + secs_to_jiffies(C) @@ constant C; @@ - msecs_to_jiffies(C * MSEC_PER_SEC) + secs_to_jiffies(C) Signed-off-by: Easwar Hariharan --- mm/kmemleak.c | 4 ++-- 1 file changed, 2 insertions(+), 2 del

[PATCH v2 21/21] nfp: Convert timeouts to secs_to_jiffies()

Changes made with the following Coccinelle rules: @@ constant C; @@ - msecs_to_jiffies(C * 1000) + secs_to_jiffies(C) @@ constant C; @@ - msecs_to_jiffies(C * MSEC_PER_SEC) + secs_to_jiffies(C) Signed-off-by: Easwar Hariharan --- drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 2 +- 1

Re: [PATCH v2 15/21] wifi: ath11k: Convert timeouts to secs_to_jiffies()

On 11/15/2024 1:26 PM, Easwar Hariharan wrote: > Changes made with the following Coccinelle rules: > > @@ constant C; @@ > > - msecs_to_jiffies(C * 1000) > + secs_to_jiffies(C) > > @@ constant C; @@ > > - msecs_to_jiffies(C * MSEC_PER_SEC) > + secs_to_jiffies(C) > > Signed-off-by: Easwar Harih

Re: [PATCH v2 00/21] Converge on using secs_to_jiffies()

On Fri, Nov 15 2024 at 14:15, Easwar Hariharan wrote: > On 11/15/2024 1:41 PM, Jeff Johnson wrote: >> >> How do you expect this series to land since it overlaps a large number of >> maintainer trees? Do you have a maintainer who has volunteered to take the >> series and the maintainers should just

Re: [PATCH v2] drm/xe/hw_engine_group: Fix bad free in xe_hw_engine_setup_groups()

On 15.11.2024 10:49, Su Hui wrote: > Clang static checker(scan-build) warning： > drivers/gpu/drm/xe/xe_hw_engine_group.c: line 134, column 2 > Argument to kfree() is a constant address (18446744073709551604), which > is not memory allocated by malloc(). > > kfree() can only handle NULL pointers in

Re: [PATCH 1/2] drm/sched: add WARN_ON and BUG_ON to drm_sched_fini

Interesting, those mails just showed up in my inbox as unread. More than 14 days after you send it. So sorry for the late reply. Am 29.10.24 um 08:22 schrieb Philipp Stanner: Christian, Sima? Matthew? (+CC) Opinions on the below? tl;dr: I still think it's a good thing to detectably block in

[PATCH] drm/msm/dpu: fix x1e80100 intf_6 underrun/vsync interrupt

PU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 17), }, { .name = "intf_7", .id = INTF_7, .base = 0x3b000, .len = 0x280, --- base-commit: 744cf71b8bdfcdd77aaf58395e068b7457634b2c change-id: 20241115-x1e80100-dp2-fix-beb12c6dcac9 Best regards, -- Stephan Gerhold

Re: [PATCH] video: fbdev: metronomefb: Fix buffer overflow in load_waveform()

On 14/11/24 20:13, Helge Deller wrote: On 11/12/24 21:28, Suraj Sonawane wrote: Fix an error detected by the Smatch tool: drivers/video/fbdev/metronomefb.c:220 load_waveform() error: buffer overflow 'wfm_hdr->stuff2a' 2 <= 4 drivers/video/fbdev/metronomefb.c:220 load_waveform() error: buffer ov

Re: [PATCH RFC 5/8] drm/msm: adreno: find bandwidth index of OPP and set it along freq index

On Wed, Nov 13, 2024 at 04:48:31PM +0100, Neil Armstrong wrote: > The Adreno GMU Management Unit (GMU) can also scale the DDR Bandwidth > along the Frequency and Power Domain level, until now we left the OPP > core scale the OPP bandwidth via the interconnect path. > > In order to enable bandwidth

[PATCH] drm/sched: Extend and update documentation

The various objects defined and used by the GPU scheduler are currently not fully documented. Furthermore, there is no documentation yet informing drivers about how they should handle timeouts. Add documentation describing the scheduler's objects and timeout procedure. Consistently, update drm_sch

[PATCH] drm: rework FB_CORE dependency

From: Arnd Bergmann The 'select FB_CORE' statement moved from CONFIG_DRM to DRM_CLIENT_LIB, but there are now configurations that have code calling into fb_core as built-in even though the client_lib itself is a loadable module: x86_64-linux-ld: drivers/gpu/drm/drm_fbdev_shmem.o: in function `d

Re: [PATCH v6 7/7] drm/doc: document some tracepoints as uAPI

On Thu, 2024-11-14 at 12:30 +0100, Lucas Stach wrote: > Hi, > > Am Donnerstag, dem 14.11.2024 um 11:01 +0100 schrieb Pierre-Eric > Pelloux-Prayer: > > This commit adds a document section in drm-uapi.rst about > > tracepoints, > > and mark the events gpu_scheduler_trace.h as stable uAPI. > > > > T

Re: [PATCH] drm/msm: Fix spelling mistake "swtich" to "switch"

The "upstream" for the gpu related .xml files is in mesa because they are used by the usermode (gl/vk) drivers: https://gitlab.freedesktop.org/mesa/mesa/-/blob/main/src/freedreno/registers/adreno/adreno_pm4.xml?ref_type=heads#L573 Things should be fixed/changed there, otherwise the change will ge

Re: [PATCH RFC 2/8] drm/msm: adreno: add GMU_BW_VOTE quirk

On 15/11/2024 16:10, Rob Clark wrote: On Fri, Nov 15, 2024 at 6:18 AM Dmitry Baryshkov wrote: On Fri, 15 Nov 2024 at 11:21, Neil Armstrong wrote: On 15/11/2024 08:07, Dmitry Baryshkov wrote: On Wed, Nov 13, 2024 at 04:48:28PM +0100, Neil Armstrong wrote: The Adreno GMU Management Unit (GN

Re: [PATCH v9 2/4] drm/doc: Document device wedged event

Am 15.11.24 um 06:07 schrieb Raag Jadav: Add documentation for device wedged event in a new 'Device wedging' chapter. The describes basic definitions and consumer expectations along with an example. v8: Improve documentation (Christian, Rodrigo) v9: Add prerequisites section (Christian) Signed-

Re: [PATCH RFC 6/8] drm/msm: adreno: enable GMU bandwidth for A740 and A750

On 15/11/2024 08:33, Dmitry Baryshkov wrote: On Wed, Nov 13, 2024 at 04:48:32PM +0100, Neil Armstrong wrote: Now all the DDR bandwidth voting via the GPU Management Unit (GMU) is in place, let's declare the Bus Control Modules (BCMs) and s/let's //g it's parameters in the GPU info struct and

Re: [PATCH RFC 4/8] drm/msm: adreno: dynamically generate GMU bw table

On 15/11/2024 08:24, Dmitry Baryshkov wrote: On Wed, Nov 13, 2024 at 04:48:30PM +0100, Neil Armstrong wrote: The Adreno GPU Management Unit (GMU) can also scale the ddr bandwidth along the frequency and power domain level, but for now we statically fill the bw_table with values from the downstre

Re: [PATCH RFC 2/8] drm/msm: adreno: add GMU_BW_VOTE quirk

On 15/11/2024 08:07, Dmitry Baryshkov wrote: On Wed, Nov 13, 2024 at 04:48:28PM +0100, Neil Armstrong wrote: The Adreno GMU Management Unit (GNU) can also scale the DDR Bandwidth along the Frequency and Power Domain level, but by default we leave the OPP core vote for the interconnect ddr path.

Re: [PATCH 0/3] drm: Move client code into subdirectories

Hi Am 08.11.24 um 17:43 schrieb Jocelyn Falempe: On 08/11/2024 16:42, Thomas Zimmermann wrote: The drm_log client will likely be merged into DRM soon. Time to clean up some of the existing files. This series moves the existing DRM client for fbdev emulation and its build infrastructure into cl

Re: [PATCH v6 1/7] drm/debugfs: output client_id in in drm_clients_info

On Thu, 2024-11-14 at 11:01 +0100, Pierre-Eric Pelloux-Prayer wrote: > client_id is a unique id used by fdinfo. Having it listed in > 'clients' > output means a userspace application can correlate the fields, eg: > given a fdinfo id get the fdinfo name. > > Signed-off-by: Pierre-Eric Pelloux-Praye

  1   2   >