Re: [PATCH] drm/tiny: Fix some error handling paths in sharp_memory_probe()

2024-10-28 Thread Alex Lanzano
On Sat, Oct 26, 2024 at 08:32:36AM +0200, Christophe JAILLET wrote: > If an error occurs after allocating resources based on which > "sharp,vcom-mode" is used, then these resources must be released, as > already done in the .remove() function. > > Use 2 new devm_add_action_or_reset() for that and

[PATCH v1] FOR-CI: drm/i915/guc: Disable ct receive tasklet during reset preparation

2024-10-28 Thread Zhanjun Dong
During GuC reset prepare, interrupt is disabled, if the interrupt event already happens and is in progress, from interrupt event to tasklet get running, there is alway some kind of latency. In long latency case, it might have 2 rare race conditions: 1. Tasklet runs after IRQ flush, add request to q

[PATCH] drm/edid: add non-desktop quirk to XREAL Air/Air 2 Pro

2024-10-28 Thread Sefa Eyeoglu
Both devices lack a DisplayID 2.0 block and therefore do not advertise themselves as HMDs. See https://gitlab.freedesktop.org/drm/misc/kernel/-/issues/53 Signed-off-by: Sefa Eyeoglu --- drivers/gpu/drm/drm_edid.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/drm_edid.c

Re: [PATCH 2/2] drm: bridge: ti-sn65dsi83: Add error recovery mechanism

2024-10-28 Thread Marek Vasut
On 10/28/24 2:52 PM, Herve Codina wrote: Hi Marek, Hi, On Sat, 26 Oct 2024 00:53:51 +0200 Marek Vasut wrote: On 10/24/24 11:55 AM, Herve Codina wrote: In some cases observed during ESD tests, the TI SN65DSI83 cannot recover from errors by itself. A full restart of the bridge is needed

Re: [PATCH v2] driver core: fw_devlink: Stop trying to optimize cycle detection logic

2024-10-28 Thread Saravana Kannan
On Mon, Oct 28, 2024 at 1:06 AM Tomi Valkeinen wrote: > > Hi, > > On 26/10/2024 07:52, Saravana Kannan wrote: > > In attempting to optimize fw_devlink runtime, I introduced numerous cycle > > detection bugs by foregoing cycle detection logic under specific > > conditions. Each fix has further narr

Re: [PATCH] fbdev: udl: Make CONFIG_FB_DEVICE optional

2024-10-28 Thread kernel test robot
Hi Gonzalo, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on drm-tip/drm-tip linus/master v6.12-rc5 next-20241028] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting

Re: [PATCH v2 1/3] drm/xen: remove redundant initialization info print

2024-10-28 Thread Alex Deucher
On Mon, Oct 28, 2024 at 3:04 PM Jani Nikula wrote: > > drm_dev_register() already prints the same information on successful > init. Remove the redundant prints. > > Signed-off-by: Jani Nikula Acked-by: Alex Deucher > > --- > > Note: I prefer to merge this together with the next patch via > drm

Re:Re: [PATCH v6] rockchip/drm: vop2: add support for gamma LUT

2024-10-28 Thread Piotr Zalewski
Hi again On Monday, October 28th, 2024 at 5:40 PM, Piotr Zalewski wrote: > On Monday, October 28th, 2024 at 7:42 AM, Andy Yan andys...@163.com wrote: > > > Hi Piotr, > > > Hi Andy > > > Tested on top of Linux 6.12-rc5 with rk3566-box-demo in a buildroot + > > weston environment: > > weston

Re: [PATCH v9 0/4] io-pgtable-arm + drm/msm: Extend iova fault debugging

2024-10-28 Thread Rob Clark
On Mon, Oct 28, 2024 at 4:53 AM Mostafa Saleh wrote: > > Hi Rob, > > On Tue, Aug 27, 2024 at 11:17:08AM -0700, Rob Clark wrote: > > From: Rob Clark > > > > This series extends io-pgtable-arm with a method to retrieve the page > > table entries traversed in the process of address translation, and

Re: [PATCH v1 05/10] media: platform: mediatek: add isp_7x camsys unit

2024-10-28 Thread 胡俊光

Re: [PATCH v2] drm/amdgpu: Fix possible NULL pointer dereference

2024-10-28 Thread Lazar, Lijo
On 10/29/2024 3:48 PM, Li Huafei wrote: > Fix the potential NULL pointer dereference on mem_ranges in > amdgpu_discovery_get_nps_info(). Additionally, assign the output > parameters nps_type and range_cnt after the kvzalloc() call to prevent > modifying the output parameters in case of an error

Re: [PATCH v4 00/13] Add ITE IT6263 LVDS to HDMI converter support

2024-10-28 Thread Liu Ying
On 10/28/2024, Dmitry Baryshkov wrote: > On Mon, Oct 28, 2024 at 11:12:00AM +, Biju Das wrote: >> Hi Dmitry, Liu, >> >>> -Original Message- >>> From: Dmitry Baryshkov >>> Sent: 28 October 2024 10:20 >>> Subject: Re: [PATCH v4 00/13] Add ITE IT6263 LVDS to HDMI converter support >>> >>>

Re: [PATCH v1 06/10] media: platform: mediatek: add isp_7x utility

2024-10-28 Thread 胡俊光

Re:Re:Re: [PATCH v6] rockchip/drm: vop2: add support for gamma LUT

2024-10-28 Thread Andy Yan
Hi Piotr, 在 2024-10-28 14:42:28,"Andy Yan" 写道: > >Hi Piotr, >Tested on top of Linux 6.12-rc5 with rk3566-box-demo in a buildroot + > weston environment: >weston --backend=drm-backend.so -i 0 --continue-without-input >weston-simple-egl > > simple-egl will draw a triangle on the des

Re: [PATCH] drm/v3d: Drop allocation of object without mountpoint

2024-10-28 Thread Maíra Canal
Maíra - else - shmem_obj = drm_gem_shmem_create(dev, unaligned_size); - if (IS_ERR(shmem_obj)) return ERR_CAST(shmem_obj); bo = to_v3d_bo(&shmem_obj->base); --- base-commit: dec9255a128e19c5fcc3bdb18175d78094cc624d change-id: 20241028-v3d-1d254

[PATCH v2] drm/amdgpu: Fix possible NULL pointer dereference

2024-10-28 Thread Li Huafei
Fix the potential NULL pointer dereference on mem_ranges in amdgpu_discovery_get_nps_info(). Additionally, assign the output parameters nps_type and range_cnt after the kvzalloc() call to prevent modifying the output parameters in case of an error return. Fixes: b194d21b9bcc ("drm/amdgpu: Use NPS

RE: [PATCH v4 08/13] dt-bindings: display: Document dual-link LVDS display common properties

2024-10-28 Thread Biju Das
Hi Liu Ying, > -Original Message- > From: Liu Ying > Sent: 29 October 2024 06:17 > Subject: Re: [PATCH v4 08/13] dt-bindings: display: Document dual-link LVDS > display common properties > > On 10/28/2024, Liu Ying wrote: > > Dual-link LVDS displays receive odd pixels and even pixels se

Re: [PATCH] drm/amdgpu: Fix possible NULL pointer dereference

2024-10-28 Thread Li Huafei
On 2024/10/28 22:33, Lazar, Lijo wrote: > > > On 10/29/2024 3:29 AM, Li Huafei wrote: >> Fix the potential NULL pointer dereference on mem_ranges in >> amdgpu_discovery_get_nps_info(). Additionally, assign the output >> parameters nps_type and range_cnt after the kvzalloc() call to prevent >>

Re: [PATCH v4 08/13] dt-bindings: display: Document dual-link LVDS display common properties

2024-10-28 Thread Liu Ying
On 10/28/2024, Liu Ying wrote: > Dual-link LVDS displays receive odd pixels and even pixels separately from > dual LVDS links. One link receives odd pixels and the other receives even > pixels. Some of those displays may also use only one LVDS link to receive > all pixels, being odd and even agno

[PATCH v18 1/8] drm: bridge: Cadence: Create MHDP helper driver

2024-10-28 Thread Sandor Yu
Mailbox access functions in MHDP8546 will be share to other MHDP driver and Cadence HDP-TX HDMI/DP PHY drivers. Create a new MHDP helper driver and move all mailbox access functions into. According the mailbox access sequence and type of security. Six mailbox access API functions are introduced. T

[PATCH v18 6/8] phy: freescale: Add DisplayPort/HDMI Combo-PHY driver for i.MX8MQ

2024-10-28 Thread Sandor Yu
Add Cadence HDP-TX DisplayPort and HDMI PHY driver for i.MX8MQ. Cadence HDP-TX PHY could be put in either DP mode or HDMI mode base on the configuration chosen. DisplayPort or HDMI PHY mode is configured in the driver. Signed-off-by: Sandor Yu Signed-off-by: Alexander Stein --- v17->v18: - fix

[PATCH v18 4/8] drm: bridge: Cadence: Add MHDP8501 DP/HDMI driver

2024-10-28 Thread Sandor Yu
Add a new DRM DisplayPort and HDMI bridge driver for Candence MHDP8501 used in i.MX8MQ SOC. MHDP8501 could support HDMI or DisplayPort standards according embedded Firmware running in the uCPU. For iMX8MQ SOC, the DisplayPort/HDMI FW was loaded and activated by SOC's ROM code. Bootload binary incl

[PATCH v18 8/8] arm64: dts: imx8mq: tqma8mq-mba8mx: Enable HDMI support

2024-10-28 Thread Sandor Yu
From: Alexander Stein Add HDMI connector and connect it to MHDP output. Enable peripherals for HDMI output. Signed-off-by: Alexander Stein --- v17->v18: - replace lane-mapping with data-lanes .../dts/freescale/imx8mq-tqma8mq-mba8mx.dts | 21 +++ arch/arm64/boot/dts/freescale

[PATCH v18 7/8] arm64: dts: imx8mq: Add DCSS + HDMI/DP display pipeline

2024-10-28 Thread Sandor Yu
From: Alexander Stein This adds DCSS + MHDP + MHDP PHY nodes. PHY mode (DP/HDMI) is selected by the connector type connected to mhdp port@1 endpoint. Signed-off-by: Alexander Stein --- v17->v18: *No change arch/arm64/boot/dts/freescale/imx8mq.dtsi | 68 +++ 1 file changed

[PATCH v18 0/8] Initial support Cadence MHDP8501(HDMI/DP) for i.MX8MQ

2024-10-28 Thread Sandor Yu
The patch set initial support Cadence MHDP8501(HDMI/DP) DRM bridge driver and Cadence HDP-TX PHY(HDMI/DP) driver for Freescale i.MX8MQ. The patch set compose of DRM bridge drivers and PHY driver. Both of them need by patch #1 and #2 to pass build. DRM bridges driver patches: #1: drm: bridge: C

[PATCH v18 3/8] dt-bindings: display: bridge: Add Cadence MHDP8501

2024-10-28 Thread Sandor Yu
Add bindings for Cadence MHDP8501 DisplayPort/HDMI bridge. Signed-off-by: Sandor Yu --- v17->v18: - remove lane-mapping and replace it with data-lanes - remove r-b tag as property changed. v16->v17: - Add lane-mapping property v9->v16: *No change .../display/bridge/cdns,mhdp8501.yaml

[PATCH v18 2/8] phy: Add HDMI configuration options

2024-10-28 Thread Sandor Yu
Allow HDMI PHYs to be configured through the generic functions through a custom structure added to the generic union. The parameters added here are based on HDMI PHY implementation practices. The current set of parameters should cover the potential users. Signed-off-by: Sandor Yu Reviewed-by: D

[PATCH v18 5/8] dt-bindings: phy: Add Freescale iMX8MQ DP and HDMI PHY

2024-10-28 Thread Sandor Yu
Add bindings for Freescale iMX8MQ DP and HDMI PHY. Signed-off-by: Sandor Yu Reviewed-by: Rob Herring --- v9->v18: *No change. .../bindings/phy/fsl,imx8mq-dp-hdmi-phy.yaml | 51 +++ 1 file changed, 51 insertions(+) create mode 100644 Documentation/devicetree/bindings/phy/fsl

Re: [PATCH v1 05/10] media: platform: mediatek: add isp_7x camsys unit

2024-10-28 Thread 胡俊光

Re: [PATCH v2 03/29] mm/migrate: Trylock device page in do_swap_page

2024-10-28 Thread Alistair Popple
Matthew Brost writes: > On Thu, Oct 17, 2024 at 12:51:08PM +1100, Alistair Popple wrote: >> >> Matthew Brost writes: >> >> > On Wed, Oct 16, 2024 at 03:00:08PM +1100, Alistair Popple wrote: >> >> >> >> Matthew Brost writes: >> >> >> >> > Avoid multiple CPU page faults to the same device p

RE: [PATCH v2 2/5] drm/virtio: Add a helper to map and note the dma addrs and lengths

2024-10-28 Thread Kasireddy, Vivek
Hi Dmitry, > Subject: Re: [PATCH v2 2/5] drm/virtio: Add a helper to map and note the > dma addrs and lengths > > +long virtgpu_dma_buf_import_sgt(struct virtio_gpu_mem_entry > >> **ents, > > + unsigned int *nents, > > + struc

Re: [PATCH] drm/xe: Fix build error for XE_IOCTL_DBG macro

2024-10-28 Thread gyeyoung
Thank you for your review, I missed how && work. I will revise a patch that print only when cond is true. sincerely, Gyeyoung baek On Tue, Oct 29, 2024 at 4:47 AM Lucas De Marchi wrote: > > On Sun, Oct 27, 2024 at 01:57:52PM +0900, Gyeyoung Baek wrote: > >In the previous code, there is build err

Re: [PATCH 1/2] drm/mediatek: Fix child node refcount handling in early exit

2024-10-28 Thread Chen-Yu Tsai
On Sat, Oct 12, 2024 at 3:22 AM Javier Carrasco wrote: > > Early exits (goto, break, return) from for_each_child_of_node() required > an explicit call to of_node_put(), which was not introduced with the > break if cnt == MAX_CRTC. > > Add the missing of_node_put() before the break. > > Cc: sta...@

Re: [PATCH 2/2] drm: bridge: ti-sn65dsi83: Add error recovery mechanism

2024-10-28 Thread Herve Codina
Hi Marek, On Sat, 26 Oct 2024 00:53:51 +0200 Marek Vasut wrote: > On 10/24/24 11:55 AM, Herve Codina wrote: > > In some cases observed during ESD tests, the TI SN65DSI83 cannot recover > > from errors by itself. A full restart of the bridge is needed in those > > cases to have the bridge output

RE: [PATCH v4 09/13] dt-bindings: display: bridge: Add ITE IT6263 LVDS to HDMI converter

2024-10-28 Thread Biju Das
Hi Liu Ying, Thanks for the patch. > -Original Message- > From: Liu Ying > Sent: 28 October 2024 02:38 > Subject: [PATCH v4 09/13] dt-bindings: display: bridge: Add ITE IT6263 LVDS > to HDMI converter > > Document ITE IT6263 LVDS to HDMI converter. > > Product link: > https://www.ite.

Re: [PATCH v2] driver core: fw_devlink: Stop trying to optimize cycle detection logic

2024-10-28 Thread Tomi Valkeinen
Hi, On 26/10/2024 07:52, Saravana Kannan wrote: In attempting to optimize fw_devlink runtime, I introduced numerous cycle detection bugs by foregoing cycle detection logic under specific conditions. Each fix has further narrowed the conditions for optimization. It's time to give up on these opt

Re: [PATCH] drm/etnaviv: flush shader L1 cache after user commandstream

2024-10-28 Thread Christian Gmeiner
Hi Lucas > > The shader L1 cache is a writeback cache for shader loads/stores > and thus must be flushed before any BOs backing the shader buffers > are potentially freed. > > Cc: sta...@vger.kernel.org > Signed-off-by: Lucas Stach Reviewed-by: Christian Gmeiner > --- > drivers/gpu/drm/etnavi

Re: [PATCH v8 1/4] drm: Introduce device wedged event

2024-10-28 Thread Jani Nikula
On Fri, 25 Oct 2024, Jani Nikula wrote: > On Fri, 25 Oct 2024, Raag Jadav wrote: >> @@ -70,6 +73,16 @@ static struct dentry *drm_debugfs_root; >> >> DEFINE_STATIC_SRCU(drm_unplug_srcu); >> >> +/* >> + * Available recovery methods for wedged device. To be sent along with >> device >> + * wed

Re: [PATCH v12 08/15] drm/vkms: Re-introduce line-per-line composition algorithm

2024-10-28 Thread Maíra Canal
Hi Louis, On 28/10/24 06:50, Louis Chauvet wrote: On 26/10/24 - 11:26, Maíra Canal wrote: Hi Louis, On 07/10/24 13:10, Louis Chauvet wrote: Re-introduce a line-by-line composition algorithm for each pixel format. This allows more performance by not requiring an indirection per pixel read. Thi

Re: [PATCH v12 09/15] drm/vkms: Remove useless drm_rotation_simplify

2024-10-28 Thread Maíra Canal
Hi Louis, On 28/10/24 06:50, Louis Chauvet wrote: On 26/10/24 - 09:10, Maíra Canal wrote: Hi Louis, On 14/10/24 05:39, Louis Chauvet wrote: On 11/10/24 - 10:53, Maira Canal wrote: Hi Louis, On 10/11/24 06:36, Louis Chauvet wrote: Hi all, Until this point, this series has not received any

Re: [PATCH v4 13/13] MAINTAINERS: Add maintainer for ITE IT6263 driver

2024-10-28 Thread Dmitry Baryshkov
On Mon, Oct 28, 2024 at 10:37:40AM +0800, Liu Ying wrote: > Add myself as the maintainer of ITE IT6263 LVDS TO HDMI BRIDGE DRIVER. > > Signed-off-by: Liu Ying > --- > v4: > * No change. > > v3: > * No change. > > v2: > * New patch. (Maxime) > > MAINTAINERS | 8 > 1 file changed, 8 i

Re: [PATCH v4 00/13] Add ITE IT6263 LVDS to HDMI converter support

2024-10-28 Thread Dmitry Baryshkov
Hi, On Mon, 28 Oct 2024 at 04:37, Liu Ying wrote: > > Hi, > > This patch series aims to add ITE IT6263 LVDS to HDMI converter on > i.MX8MP EVK. Combined with LVDS receiver and HDMI 1.4a transmitter, > the IT6263 supports LVDS input and HDMI 1.4 output by conversion > function. IT6263 product li

Re: [PATCH RESEND v2 2/8] drm/vkms: Add support for ARGB8888 formats

2024-10-28 Thread Maíra Canal
Hi Louis, On 28/10/24 06:50, Louis Chauvet wrote: On 26/10/24 - 11:11, Maíra Canal wrote: Hi Louis, On 07/10/24 13:46, Louis Chauvet wrote: The formats XRGB and ARGB were already supported. Add the support for: - XBGR - RGBX - BGRX - ABGR - RGBA - BGRA Signed-

[RFC PATCH 08/10] drm: bridge: samsung-dsim: don't re-activate the bridge if already setup

2024-10-28 Thread Dario Binacchi
The patch does not re-execute the hardware initialization/activation procedure for the bridge if it is already operational. This feature is crucial when supporting the simple framebuffer, as the controller has already been initialized by the bootloader. Co-developed-by: Michael Trimarchi Signed-o

[RFC PATCH 06/10] drm/panel: synaptics-r63353: don't re-activate the panel if already setup

2024-10-28 Thread Dario Binacchi
The patch does not re-execute the hardware initialization/activation procedure for the panel if it is already operational. This feature is crucial when supporting the simple framebuffer, as the controller has already been initialized by the bootloader. Co-developed-by: Michael Trimarchi Signed-of

[RFC PATCH 05/10] dt-bindings: display: panel: add 'syna, boot-on' property

2024-10-28 Thread Dario Binacchi
The property states that the panel display has been initialized and left on by the bootloader. This information becomes relevant in the case of supporting the simple framebuffer. Signed-off-by: Dario Binacchi --- .../devicetree/bindings/display/panel/synaptics,r63353.yaml | 5 + 1 file cha

[RFC PATCH 07/10] dt-bindings: bridge: samsung-dsim: add 'samsung, boot-on' property

2024-10-28 Thread Dario Binacchi
The property states that the bridge controller has been initialized and left on by the bootloader. This information becomes relevant in the case of supporting the simple framebuffer. Signed-off-by: Dario Binacchi --- .../bindings/display/bridge/samsung,mipi-dsim.yaml | 5 + 1 file

[RFC PATCH 10/10] drm/mxsfb: stop controller and drain FIFOs if already initialized

2024-10-28 Thread Dario Binacchi
You can't re-program the controller if it is still running. This may lead to shifted pictures, so stop the controller and drain its FIFOs in case it's already properly setup. This patch is crucial when supporting the simple framebuffer, as the controller has already been initialized by the bootload

[RFC PATCH 09/10] dt-bindings: lcdif: add 'fsl,boot-on' property

2024-10-28 Thread Dario Binacchi
The property states that the (e)LCDIF display controller has been initialized and left on by the bootloader. This information becomes relevant in the case of supporting the simple framebuffer. Signed-off-by: Dario Binacchi --- Documentation/devicetree/bindings/display/fsl,lcdif.yaml | 5 +

Re: [PATCH 2/2] drm: bridge: ti-sn65dsi83: Add error recovery mechanism

2024-10-28 Thread Herve Codina
Hi Laurent, On Sun, 27 Oct 2024 18:23:50 +0200 Laurent Pinchart wrote: [...] > > +static int sn65dsi83_reset_pipeline(struct sn65dsi83 *sn65dsi83) > > +{ > > + struct drm_device *dev = sn65dsi83->bridge.dev; > > + struct drm_modeset_acquire_ctx ctx; > > + struct drm_atomic_state *state; >

Re: [PATCH] drm/omap: Clean up deadcode functions

2024-10-28 Thread Tomi Valkeinen
Hi, On 27/10/2024 01:00, li...@treblig.org wrote: From: "Dr. David Alan Gilbert" dispc_enable_fifomerge() last use was removed by 2012's commit 85099f11bd03 ("Revert "OMAPDSS: APPLY: add fifo merge support funcs"") dispc_has_writeback(), dispc_wb_get_framedone_irq(), dispc_wb_go(), dispc_wb_g

Re: [PATCH] drm/msm/a6xx: Fix excessive stack usage

2024-10-28 Thread Dmitry Baryshkov
On Sun, Oct 27, 2024 at 11:35:47PM +0530, Akhil P Oommen wrote: > Clang-19 and above sometimes end up with multiple copies of the large > a6xx_hfi_msg_bw_table structure on the stack. The problem is that > a6xx_hfi_send_bw_table() calls a number of device specific functions to > fill the structure,

Re: [PATCH 2/2] drm: bridge: ti-sn65dsi83: Add error recovery mechanism

2024-10-28 Thread Dan Carpenter
Hi Herve, kernel test robot noticed the following build warnings: https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Herve-Codina/dt-bindings-display-bridge-sn65dsi83-Add-interrupt/20241024-175758 base: https://git.kernel.o

Re: [PATCH][next] drm/omap: clean up error exit path on omap_encoder allocation failure

2024-10-28 Thread Tomi Valkeinen
Hi, On 15/10/2024 17:10, Colin Ian King wrote: Currently when an allocation failure occurs for omap_encoder the exit path will destroy encoder via omap_encoder_destroy if it is not null. However, encoder is always null at this point, so the check and destroy is redundant and can be removed. Cle

Re: linux-next: manual merge of the drm tree with the asm-generic tree

2024-10-28 Thread Arnd Bergmann
On Mon, Oct 28, 2024, at 02:34, Stephen Rothwell wrote: > -} else { > +} else if (IS_ENABLED(CONFIG_HAS_IOPORT)) { > ioaddr = VBE_DISPI_IOPORT_INDEX; > iosize = 2; > - if (!request_region(ioaddr, iosize, "bochs-drm")) { > + if (!devm_re

Re: [PATCH] drm/bridge: tc358767: Fix odd pixel alignment

2024-10-28 Thread Maxime Ripard
On Sat, Oct 26, 2024 at 06:10:01AM +0200, Marek Vasut wrote: > Horizontal Timing Control0 Register 1/2 (HTIM01/HTIM02) Register > bitfields description state "These bits must be multiple of even > pixel". It is not possible to simply align every bitfield to the > nearest even pixel, because that wo

[PATCH] drm/xe/hdcp: Fix logic errors

2024-10-28 Thread 1064094935
From: pengfuyuan Here the gsc struct null pointer check should use '||' instead of '&&'. Fix the following patches: drm/xe/hdcp: Check GSC structure validity Signed-off-by: pengfuyuan --- drivers/gpu/drm/xe/display/xe_hdcp_gsc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [PATCH 0/7] kernel/cgroups: Add "dev" memory accounting cgroup.

2024-10-28 Thread Maxime Ripard
On Thu, Oct 24, 2024 at 07:06:36AM -1000, Tejun Heo wrote: > Hello, > > On Thu, Oct 24, 2024 at 09:20:43AM +0200, Maxime Ripard wrote: > ... > > > Yeah, let's not use "dev" name for this. As Waiman pointed out, it > > > conflicts > > > with the devices controller from cgroup1. While cgroup1 is mo

Re: [PATCH] drm/msm/a6xx: Fix excessive stack usage

2024-10-28 Thread Akhil P Oommen
On 10/28/2024 1:56 PM, Dmitry Baryshkov wrote: > On Sun, Oct 27, 2024 at 11:35:47PM +0530, Akhil P Oommen wrote: >> Clang-19 and above sometimes end up with multiple copies of the large >> a6xx_hfi_msg_bw_table structure on the stack. The problem is that >> a6xx_hfi_send_bw_table() calls a number o

Re: [PATCH 2/2] drm/mediatek: Switch to for_each_child_of_node_scoped()

2024-10-28 Thread Chen-Yu Tsai
On Sat, Oct 12, 2024 at 3:22 AM Javier Carrasco wrote: > > Introduce the scoped variant of the loop to automatically release the > child node when it goes out of scope, which is more robust than the > non-scoped variant, and accounts for new early exits that could be added > in the future. > > Sig

RE: [PATCH v4 10/13] drm/bridge: Add ITE IT6263 LVDS to HDMI converter

2024-10-28 Thread Biju Das
Hi Liu Ying, Thanks for the patch. > -Original Message- > From: Liu Ying > Sent: 28 October 2024 02:38 > Subject: [PATCH v4 10/13] drm/bridge: Add ITE IT6263 LVDS to HDMI converter > > Add basic HDMI video output support. Currently, only RGB888 output pixel > format is supported. At t

Re: [PATCH] drm/bridge: tc358767: Improve DPI output pixel clock accuracy

2024-10-28 Thread Maxime Ripard
On Sat, Oct 26, 2024 at 06:11:12AM +0200, Marek Vasut wrote: > The Pixel PLL is not very capable and may come up with wildly inaccurate > clock. Since DPI panels are often tolerant to slightly higher pixel clock > without being operated outside of specification, calculate two Pixel PLL > settings f

Re: [PATCH] drm/bridge: tc358767: Improve DPI output pixel clock accuracy

2024-10-28 Thread Neil Armstrong
On 26/10/2024 06:11, Marek Vasut wrote: The Pixel PLL is not very capable and may come up with wildly inaccurate clock. Since DPI panels are often tolerant to slightly higher pixel clock without being operated outside of specification, calculate two Pixel PLL settings for DPI output, one for desi

Re: [PATCH RESEND v2 5/8] drm/vkms: Add support for RGB888 formats

2024-10-28 Thread Louis Chauvet
On 26/10/24 - 11:51, Maíra Canal wrote: > Hi Louis, > > On 07/10/24 13:46, Louis Chauvet wrote: > > Add the support for: > > - RGB888 > > - BGR888 > > > > Signed-off-by: Louis Chauvet > > --- > > drivers/gpu/drm/vkms/vkms_formats.c | 7 +++ > > drivers/gpu/drm/vkms/vkms_plane.c | 2 ++ >

Re: [PATCH v2 1/3] drm/vkms: Re-introduce line-by-line algorithm for writeback

2024-10-28 Thread Louis Chauvet
On 26/10/24 - 12:05, Maíra Canal wrote: > Hi Louis, > > On 14/08/24 05:42, Louis Chauvet wrote: > > Re-introduce a line-by-line writeback algorithm for each pixel format. > > This allows more performance by not requiring an indirection per pixel > > write. > > > > Line-by-line writeback was intro

Re: [PATCH RESEND v2 3/8] drm/vkms: Add support for ARGB16161616 formats

2024-10-28 Thread Louis Chauvet
On 26/10/24 - 11:15, Maíra Canal wrote: > Hi Louis, > > On 07/10/24 13:46, Louis Chauvet wrote: > > The formats XRGB16161616 and ARGB16161616 were already supported. > > Add the support for: > > - ABGR16161616 > > - XBGR16161616 > > > > Signed-off-by: Louis Chauvet > > --- > > drivers/gpu/drm/

Re: [PATCH v2 2/3] drm/vkms: Add a macro for write_line functions

2024-10-28 Thread Louis Chauvet
On 26/10/24 - 12:08, Maíra Canal wrote: > Hi Louis, > > On 14/08/24 05:42, Louis Chauvet wrote: > > As stated in [2], the write_line functions are very similar and force code > > Where is [2]? > > > duplication. This patch add a macro to avoid code repetition. > > > > Signed-off-by: Louis Chauv

Re: [PATCH v12 09/15] drm/vkms: Remove useless drm_rotation_simplify

2024-10-28 Thread Louis Chauvet
On 26/10/24 - 09:10, Maíra Canal wrote: > Hi Louis, > > On 14/10/24 05:39, Louis Chauvet wrote: > > On 11/10/24 - 10:53, Maira Canal wrote: > > > Hi Louis, > > > > > > On 10/11/24 06:36, Louis Chauvet wrote: > > > > > > > > Hi all, > > > > > > > > Until this point, this series has not received

Re: [PATCH v4 0/5] drm/vkms: Switch all vkms object to DRM managed objects

2024-10-28 Thread Louis Chauvet
On 26/10/24 - 12:33, Maíra Canal wrote: > Hi Louis, > > How do you feel about adding the patch [1] to this series? This will > avoid issues when reviewing and pushing the series? Ack! Thanks, Louis Chauvet > [1] > https://lore.kernel.org/all/20241010-vkms-remove-index-v2-1-6b8d6cfd5...@bootli

Re: [PATCH RESEND v2 1/8] drm/vkms: Create helpers macro to avoid code duplication in format callbacks

2024-10-28 Thread Louis Chauvet
On 26/10/24 - 11:29, Maíra Canal wrote: > Hi Louis, > > On 07/10/24 13:46, Louis Chauvet wrote: > > The callback functions for line conversion are almost identical for > > some format. The generic READ_LINE macro generate all the required > > boilerplate to process a line. > > > > Two overrides o

Re: [PATCH RESEND v2 1/8] drm/vkms: Create helpers macro to avoid code duplication in format callbacks

2024-10-28 Thread Louis Chauvet
On 26/10/24 - 11:58, Maíra Canal wrote: > Hi Louis, > > On 07/10/24 13:46, Louis Chauvet wrote: > > The callback functions for line conversion are almost identical for > > some format. The generic READ_LINE macro generate all the required > > boilerplate to process a line. > > > > Two overrides o

Re: [PATCH v12 08/15] drm/vkms: Re-introduce line-per-line composition algorithm

2024-10-28 Thread Louis Chauvet
On 26/10/24 - 11:26, Maíra Canal wrote: > Hi Louis, > > On 07/10/24 13:10, Louis Chauvet wrote: > > Re-introduce a line-by-line composition algorithm for each pixel format. > > This allows more performance by not requiring an indirection per pixel > > read. This patch is focused on readability of

Re: [PATCH RESEND v2 2/8] drm/vkms: Add support for ARGB8888 formats

2024-10-28 Thread Louis Chauvet
On 26/10/24 - 11:11, Maíra Canal wrote: > Hi Louis, > > On 07/10/24 13:46, Louis Chauvet wrote: > > The formats XRGB and ARGB were already supported. > > Add the support for: > > - XBGR > > - RGBX > > - BGRX > > - ABGR > > - RGBA > > - BGRA > > > > Signed-off-by: L

Re: [PATCH v2] drm/vkms: Remove index parameter from init_vkms_output

2024-10-28 Thread Louis Chauvet
On 26/10/24 - 12:22, Maíra Canal wrote: > Hi Louis, > > On 10/10/24 14:27, Louis Chauvet wrote: > > VKMS currently supports only one CRTC, so it make no sense to have this > > index configurable. To avoid issues, replace this hardcoded index by > > drm_crtc_mask when applicable. > > > > There is

Re: [PATCH v4 1/5] drm/vkms: Switch to managed for connector

2024-10-28 Thread Louis Chauvet
On 26/10/24 - 12:29, Maíra Canal wrote: > Hi Louis, > > On 10/10/24 14:39, Louis Chauvet wrote: > > The current VKMS driver uses non-managed function to create connectors. It > > is not an issue yet, but in order to support multiple devices easily, > > convert this code to use drm and device manag

Re: [PATCH v12 13/15] drm/vkms: Create KUnit tests for YUV conversions

2024-10-28 Thread Louis Chauvet
On 26/10/24 - 11:49, Maíra Canal wrote: > Hi Louis, > > On 07/10/24 13:10, Louis Chauvet wrote: > > From: Arthur Grillo > > > > Create KUnit tests to test the conversion between YUV and RGB. Test each > > conversion and range combination with some common colors. > > > > The code used to compute

Re: [PATCH RESEND v2 4/8] drm/vkms: Add support for RGB565 formats

2024-10-28 Thread Louis Chauvet
On 26/10/24 - 11:17, Maíra Canal wrote: > Hi Louis, > > On 07/10/24 13:46, Louis Chauvet wrote: > > The format RGB565 was already supported. Add the support for: > > - BGR565 > > > > Signed-off-by: Louis Chauvet > > --- > > drivers/gpu/drm/vkms/vkms_formats.c | 25 - > >

Re: [PATCH] drm/msm/a6xx: Fix excessive stack usage

2024-10-28 Thread Akhil P Oommen
On 10/28/2024 12:13 AM, Arnd Bergmann wrote: > On Sun, Oct 27, 2024, at 18:05, Akhil P Oommen wrote: >> Clang-19 and above sometimes end up with multiple copies of the large >> a6xx_hfi_msg_bw_table structure on the stack. The problem is that >> a6xx_hfi_send_bw_table() calls a number of device spe

[PATCH] drm/rockchip: vop2: Don't spam logs in atomic update

2024-10-28 Thread Andy Yan
From: Andy Yan Demote the error message to drm_dbg_kms to only print the message if the respective debug messages are enabled. Signed-off-by: Andy Yan --- drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/drivers/

Re: [PATCH] fbdev: udl: Make CONFIG_FB_DEVICE optional

2024-10-28 Thread Thomas Zimmermann
Hi Helge Am 25.10.24 um 17:37 schrieb Helge Deller: On 10/25/24 11:25, Gonzalo Silvalde Blanco wrote: The fb_udl driver currently depends on CONFIG_FB_DEVICE to create sysfs entries and access framebuffer device information. This patch wraps the relevant code blocks with #ifdef CONFIG_FB_DEVICE

Re: [PATCH 1/2] drm/mediatek: Fix child node refcount handling in early exit

2024-10-28 Thread AngeloGioacchino Del Regno
Il 11/10/24 21:21, Javier Carrasco ha scritto: Early exits (goto, break, return) from for_each_child_of_node() required an explicit call to of_node_put(), which was not introduced with the break if cnt == MAX_CRTC. Add the missing of_node_put() before the break. Cc: sta...@vger.kernel.org Fixes

Re: [PATCH 2/2] drm/mediatek: Switch to for_each_child_of_node_scoped()

2024-10-28 Thread AngeloGioacchino Del Regno
Il 11/10/24 21:21, Javier Carrasco ha scritto: Introduce the scoped variant of the loop to automatically release the child node when it goes out of scope, which is more robust than the non-scoped variant, and accounts for new early exits that could be added in the future. Signed-off-by: Javier C

Re: [PATCH 2/2] drm: bridge: ti-sn65dsi83: Add error recovery mechanism

2024-10-28 Thread Maxime Ripard
On Sun, Oct 27, 2024 at 06:23:50PM +0200, Laurent Pinchart wrote: > On Thu, Oct 24, 2024 at 11:55:38AM +0200, Herve Codina wrote: > > In some cases observed during ESD tests, the TI SN65DSI83 cannot recover > > from errors by itself. A full restart of the bridge is needed in those > > cases to have

Re: [PATCH v4 10/13] drm/bridge: Add ITE IT6263 LVDS to HDMI converter

2024-10-28 Thread Dmitry Baryshkov
On Mon, Oct 28, 2024 at 10:37:37AM +0800, Liu Ying wrote: > Add basic HDMI video output support. Currently, only RGB888 output > pixel format is supported. At the LVDS input side, the driver > supports single LVDS link and dual LVDS links with "jeida-24" LVDS > mapping. > > Product link: > https:

Re: [PATCH] drm/msm/a6xx: Fix excessive stack usage

2024-10-28 Thread Konrad Dybcio
On 28.10.2024 11:27 AM, Dmitry Baryshkov wrote: > On Mon, 28 Oct 2024 at 12:08, Akhil P Oommen wrote: >> >> On 10/28/2024 1:56 PM, Dmitry Baryshkov wrote: >>> On Sun, Oct 27, 2024 at 11:35:47PM +0530, Akhil P Oommen wrote: Clang-19 and above sometimes end up with multiple copies of the large

Re: [PATCH 1/3] dma-buf/dma-fence_array: use kvzalloc

2024-10-28 Thread Christian König
Am 25.10.24 um 11:05 schrieb Tvrtko Ursulin: On 25/10/2024 09:59, Tvrtko Ursulin wrote: On 24/10/2024 13:41, Christian König wrote: Reports indicates that some userspace applications try to merge more than 80k of fences into a single dma_fence_array leading to a warning from kzalloc() that t

Re: [PATCH] drm/msm/a6xx: Fix excessive stack usage

2024-10-28 Thread Dmitry Baryshkov
On Mon, 28 Oct 2024 at 12:08, Akhil P Oommen wrote: > > On 10/28/2024 1:56 PM, Dmitry Baryshkov wrote: > > On Sun, Oct 27, 2024 at 11:35:47PM +0530, Akhil P Oommen wrote: > >> Clang-19 and above sometimes end up with multiple copies of the large > >> a6xx_hfi_msg_bw_table structure on the stack. T

Re: [PATCH RESEND v2 5/8] drm/vkms: Add support for RGB888 formats

2024-10-28 Thread Maíra Canal
Hi Louis, On 28/10/24 06:50, Louis Chauvet wrote: On 26/10/24 - 11:51, Maíra Canal wrote: Hi Louis, On 07/10/24 13:46, Louis Chauvet wrote: Add the support for: - RGB888 - BGR888 Signed-off-by: Louis Chauvet --- drivers/gpu/drm/vkms/vkms_formats.c | 7 +++ drivers/gpu/drm/vkms/vkms

Re: [PATCH] drm/msm/a6xx: Fix excessive stack usage

2024-10-28 Thread Konrad Dybcio
On 28.10.2024 10:52 AM, Akhil P Oommen wrote: > On 10/28/2024 12:13 AM, Arnd Bergmann wrote: >> On Sun, Oct 27, 2024, at 18:05, Akhil P Oommen wrote: >>> Clang-19 and above sometimes end up with multiple copies of the large >>> a6xx_hfi_msg_bw_table structure on the stack. The problem is that >>> a

Re: [PATCH v6 2/9] drm/msm/dpu: move pstate->pipe initialization to dpu_plane_atomic_check

2024-10-28 Thread Dmitry Baryshkov
On Fri, Oct 25, 2024 at 12:00:20PM -0700, Abhinav Kumar wrote: > > > On 10/24/2024 5:20 PM, Dmitry Baryshkov wrote: > > In preparation for virtualized planes support, move pstate->pipe > > initialization from dpu_plane_reset() to dpu_plane_atomic_check(). In > > case of virtual planes the plane's

Re: [RFC PATCH 00/10] Support simple-framebuffer on imx8m

2024-10-28 Thread Maxime Ripard
Hi, On Mon, Oct 28, 2024 at 11:25:23AM +0100, Dario Binacchi wrote: > This series is the Linux counterpart of what was sent to U-Boot [1] > for the support of the simple-framebuffer for the BSH SMM S2Pro board. I'm confused. simple-framebuffer is a mechanism for which the entire point is that the

Re: [PATCH] drm/msm/a6xx: Fix excessive stack usage

2024-10-28 Thread Dmitry Baryshkov
On Mon, Oct 28, 2024 at 11:39:16AM +0100, Konrad Dybcio wrote: > On 28.10.2024 10:52 AM, Akhil P Oommen wrote: > > On 10/28/2024 12:13 AM, Arnd Bergmann wrote: > >> On Sun, Oct 27, 2024, at 18:05, Akhil P Oommen wrote: > >>> Clang-19 and above sometimes end up with multiple copies of the large > >>

[PATCH AUTOSEL 6.11 28/32] drm/xe: Enlarge the invalidation timeout from 150 to 500

2024-10-28 Thread Sasha Levin
From: Shuicheng Lin [ Upstream commit c8fb95e7a54315460b45090f0968167a332e1657 ] There are error messages like below that are occurring during stress testing: "[ 31.004009] xe :03:00.0: [drm] ERROR GT0: Global invalidation timeout". Previously it was hitting this 3 out of 1000 executions o

[PATCH AUTOSEL 6.11 32/32] drm/xe: Don't restart parallel queues multiple times on GT reset

2024-10-28 Thread Sasha Levin
From: Nirmoy Das [ Upstream commit cdc21021f0351226a4845715564afd5dc50ed44b ] In case of parallel submissions multiple GuC id will point to the same exec queue and on GT reset such exec queues will get restarted multiple times which is not desirable. v2: don't use exec_queue_enabled() which cou

[PATCH AUTOSEL 6.11 30/32] drm/xe: Handle unreliable MMIO reads during forcewake

2024-10-28 Thread Sasha Levin
From: Shuicheng Lin [ Upstream commit 69418db678567bdf9a4992c83d448da462ffa78c ] In some cases, when the driver attempts to read an MMIO register, the hardware may return 0x. The current force wake path code treats this as a valid response, as it only checks the BIT. However, 0x

[PATCH AUTOSEL 6.11 31/32] drm/xe/ufence: Prefetch ufence addr to catch bogus address

2024-10-28 Thread Sasha Levin
From: Nirmoy Das [ Upstream commit 9c1813b3253480b30604c680026c7dc721ce86d1 ] access_ok() only checks for addr overflow so also try to read the addr to catch invalid addr sent from userspace. Link: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/1630 Cc: Francois Dugast Cc: Maarten Lankh

Re: [PATCH V2 drm-dp 1/4] drm/hisilicon/hibmc: add dp aux in hibmc

2024-10-28 Thread Dmitry Baryshkov
On Fri, Oct 25, 2024 at 03:52:49AM +0800, kernel test robot wrote: > Hi Yongbang, > > kernel test robot noticed the following build errors: > > [auto build test ERROR on drm-misc/drm-misc-next] > [also build test ERROR on linus/master v6.12-rc4 next-20241024] > [If your patch is applied to the wr

Re: [PATCH 3/5] drm/vblank: Remove unused drm_crtc_vblank_count_and_time

2024-10-28 Thread Ville Syrjälä
On Wed, Oct 23, 2024 at 12:29:32AM +0100, li...@treblig.org wrote: > From: "Dr. David Alan Gilbert" > > drm_crtc_vblank_count_and_time() was explicitly added by > commit cf6483050e9b ("drm/irq: Add drm_crtc_vblank_count_and_time()") > in 2015, but never used. I see a bunch of places that could t

Re: [PATCH v4 6/7] PCI: Allow drivers to control VF BAR size

2024-10-28 Thread Bjorn Helgaas
On Fri, Oct 25, 2024 at 11:50:37PM +0200, Michał Winiarski wrote: > Drivers could leverage the fact that the VF BAR MMIO reservation is > created for total number of VFs supported by the device by resizing the > BAR to larger size when smaller number of VFs is enabled. > > Add a pci_iov_vf_bar_set

Re: [PATCH 1/2] drm/etnaviv: Fix misunderstanding about the scatterlist structure

2024-10-28 Thread Sui Jingfeng
Hi, Dear reviewers On 2024/10/29 00:05, Sui Jingfeng wrote: The 'offset' data member of the 'struct scatterlist' denotes the offset into a SG entry in bytes. The sg_dma_len() macro could be used to get lengths of SG entries, those lengths are expected to be CPU page size aligned. Since, at least

  1   2   >