Re: [PATCH v2 5/5] drm/panel: samsung-s6e88a0-ams427ap24: Add flip option

2024-10-23 Thread Neil Armstrong
On 22/10/2024 23:33, Jakob Hauser wrote: The way of implementing a flip option follows the existing panel-samsung-s6e8aa0.c [1][2][3]. The value to flip the screen is taken from a downstream kernel file of a similar but older panel [4]. The mipi clock [5] for the new panel samsung-s6e88a0-ams427

Re: [PATCH] drm/panel: s6e3ha8: add static modifier to supply list

2024-10-23 Thread Neil Armstrong
Hi, On Mon, 21 Oct 2024 16:52:36 +0300, Dzmitry Sankouski wrote: > Add 'static' modifier to panel supply list. > > Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-next) [1/1] drm/panel: s6e3ha8: add static modifier to supply list https://gitlab.freedeskt

Re: [PATCH v5 4/4] drm/amdgpu: track bo memory stats at runtime

2024-10-23 Thread Tvrtko Ursulin
On 22/10/2024 18:06, Christian König wrote: Am 22.10.24 um 18:46 schrieb Li, Yunxiang (Teddy): [Public] I suppose we could add a field like amd-memory-private: to cover the private placements. No, that is not really appropriate either. GWS, GDS and OA are not memory in the first place.

Re: [PATCH 1/4] drm/sched: Mark scheduler work queues with WQ_MEM_RECLAIM

2024-10-23 Thread Philipp Stanner
On Tue, 2024-10-22 at 18:11 +, Matthew Brost wrote: > On Tue, Oct 22, 2024 at 04:19:18PM +0200, Philipp Stanner wrote: > > On Mon, 2024-10-21 at 10:57 -0700, Matthew Brost wrote: > > > DRM scheduler work queues are used to submit jobs, jobs are in > > > the > > > path > > > > "scheduler work q

[PATCH 1/7] kernel/cgroup: Add "dev" memory accounting cgroup

2024-10-23 Thread Maarten Lankhorst
The initial version was based roughly on the rdma and misc cgroup controllers, with a lot of the accounting code borrowed from rdma. The current version is a complete rewrite with page counter; it uses the same min/low/max semantics as the memory cgroup as a result. There's a small mismatch as TT

[PATCH 6/7] [HACK] drm/xe: Hack to test with mapped pages instead of vram.

2024-10-23 Thread Maarten Lankhorst
We will probably want to make this a proper region in TTM for everything, so that we can charge VRAM twice, once for mapped in sysmem, once for mapped in vram. That way we don't need to deal with evict failing from lack of available memory in mapped. Signed-off-by: Maarten Lankhorst Signed-off-by

[PATCH 4/7] drm/xe: Implement cgroup for vram

2024-10-23 Thread Maarten Lankhorst
Add vram based cgroup eviction to Xe. Most hardware with VRAM uses TTM for its management, and can be similarly trivially enabled. Co-developed-by: Maxime Ripard Signed-off-by: Maxime Ripard Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/xe/xe_device.c | 4 drivers/gpu/drm/xe

[PATCH 2/7] drm/drv: Add drmm cgroup registration for dev cgroups.

2024-10-23 Thread Maarten Lankhorst
From: Maxime Ripard Drivers will need to register a cgroup device at probe time, so let's give them a drm-managed helper. Signed-off-by: Maxime Ripard Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/drm_drv.c | 21 + include/drm/drm_drv.h | 4 2 files change

[PATCH 7/7] [DISCUSSION] drm/gem: Add cgroup memory accounting

2024-10-23 Thread Maarten Lankhorst
From: Maxime Ripard In order to support any device using the GEM support, let's register a dev cgroup device in the drm_dev_register path, and account for allocated buffers in the buffer allocation path. Marked discussion by Maarten Lankhorst: This is only implemented for drm_gem_dma_helper.c, a

[PATCH 5/7] drm/amdgpu: Add cgroups implementation

2024-10-23 Thread Maarten Lankhorst
Similar to xe, enable some simple management of VRAM only. Co-developed-by: Maxime Ripard Signed-off-by: Maxime Ripard Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 6 ++ drivers/gpu/drm/amd/amdgpu/a

Re: [PATCH v2 3/5] drm/panel: samsung-s6e88a0-ams427ap24: Add initial driver

2024-10-23 Thread Neil Armstrong
Hi, On 22/10/2024 23:33, Jakob Hauser wrote: This initial part of the panel driver was mostly generated by the "linux-mdss-dsi-panel-driver-generator" tool [1], reading downstream Android kernel file "dsi_panel_S6E88A0_AMS427AP24_qhd_octa_video.dtsi" [2]. On top of the generic output of the too

Re: [PATCH v7 1/9] of: property: add of_graph_get_next_port()

2024-10-23 Thread Sakari Ailus
Dear Morimoto-san, On Wed, Oct 23, 2024 at 04:40:45AM +, Kuninori Morimoto wrote: > > Hi Sakari, again > > > > diff --git a/drivers/of/property.c b/drivers/of/property.c > > > index 11b922fde7af..6a5d27dd0c64 100644 > > > --- a/drivers/of/property.c > > > +++ b/drivers/of/property.c > > > @@

Re: [PATCH v2 4/5] drm/panel: samsung-s6e88a0-ams427ap24: Add brightness control

2024-10-23 Thread Neil Armstrong
On 22/10/2024 23:33, Jakob Hauser wrote: The tables for brightness to candela, aid and elvss were taken from downstream kernel file "dsi_panel_S6E88A0_AMS427AP24_qhd_octa_video.dtsi" [1][2][3]. The gamma table gets generated in "ss_dsi_smart_dimming_S6E88A0_AMS427AP24.c" [4] with hard-coded sta

Re: [PATCH v1] drm/bridge: tc358768: Fix DSI command tx

2024-10-23 Thread Neil Armstrong
On 26/09/2024 16:12, Francesco Dolcini wrote: From: Francesco Dolcini Wait for the command transmission to be completed in the DSI transfer function polling for the dc_start bit to go back to idle state after the transmission is started. This is documented in the datasheet and failures to do s

[PATCH 3/7] drm/ttm: Handle cgroup based eviction in TTM

2024-10-23 Thread Maarten Lankhorst
cgroup resource allocation has to be handled in TTM, so -EAGAIN from cgroups can be converted into -ENOSPC, and the limitcg can be properly evicted in ttm code. When hitting a resource limit through -EAGAIN, the cgroup for which the limit is hit is also returned. This allows eviction to delete onl

[PATCH 0/7] kernel/cgroups: Add "dev" memory accounting cgroup.

2024-10-23 Thread Maarten Lankhorst
New submission! I've added documentation for each call, and integrated the renaming from drm cgroup to dev cgroup, based on maxime ripard's work. Maxime has been testing this with dma-buf heaps and v4l2 too, and it seems to work. In the initial submission, I've decided to only add the smallest en

Re: [PATCH 4/5] drm/client: Remove unused drm_client_framebuffer_flush

2024-10-23 Thread Jocelyn Falempe
On 23/10/2024 08:46, Thomas Zimmermann wrote: Hi Am 23.10.24 um 01:29 schrieb li...@treblig.org: From: "Dr. David Alan Gilbert" drm_client_framebuffer_flush() was explicitly added in 2020 by commit c9c03e3cf072 ("drm/client: Add drm_client_framebuffer_flush()") but has never been used. Remov

Re: [PATCH] PCI/VGA: Don't assume only VGA device found is the boot VGA device

2024-10-23 Thread Luke Jones
On Wed, 23 Oct 2024, at 3:27 AM, Kai-Heng Feng wrote: > On 2024/10/22 9:04 PM, Alex Deucher wrote: >> External email: Use caution opening links or attachments >> >> >> On Tue, Oct 22, 2024 at 2:31 AM Kai-Heng Feng wrote: >>> >>> Hi Luke, >>> >>> On 2024/10/15 4:04 PM, Luke Jones wrote: O

[PATCH next] drm/sharp-memory: Fix some checks in sharp_memory_probe()

2024-10-23 Thread Dan Carpenter
The devm_drm_dev_alloc() function returns error pointers, it never returns NULL. Change that check to IS_ERR(). The devm_gpiod_get_optional() function returns a mix of error pointers if there is an error, or NULL if there is no GPIO assigned. Add a check for error pointers. Fixes: b8f9f21716fe

Re: [PATCH v5 4/4] drm/amdgpu: track bo memory stats at runtime

2024-10-23 Thread Tvrtko Ursulin
On 22/10/2024 17:24, Christian König wrote: Am 22.10.24 um 17:17 schrieb Li, Yunxiang (Teddy): [Public] +static uint32_t fold_memtype(uint32_t memtype) { In general please add prefixes to even static functions, e.g. amdgpu_vm_ or amdgpu_bo_. +   /* Squash private placements into 'cpu' to

[PATCH next] drm/fsl-dcu: prevent error pointer dereference in fsl_dcu_load()

2024-10-23 Thread Dan Carpenter
The syscon_regmap_lookup_by_compatible() function returns -ENODEV if there isn't a compatible for it or other error pointers on error. This code only checks for -ENODEV instead of checking for other errors so it could lead to an error pointer dereference inside the regmap_update_bits() function.

Re: [PATCH next] drm/fsl-dcu: prevent error pointer dereference in fsl_dcu_load()

2024-10-23 Thread Matthias Schiffer
On Wed, 2024-10-23 at 11:35 +0300, Dan Carpenter wrote: > > The syscon_regmap_lookup_by_compatible() function returns -ENODEV if > there isn't a compatible for it or other error pointers on error. This > code only checks for -ENODEV instead of checking for other errors so it > could lead to an er

Re: [PATCH v5 4/4] drm/amdgpu: track bo memory stats at runtime

2024-10-23 Thread Christian König
Am 23.10.24 um 09:38 schrieb Tvrtko Ursulin: On 22/10/2024 17:24, Christian König wrote: Am 22.10.24 um 17:17 schrieb Li, Yunxiang (Teddy): [Public] +static uint32_t fold_memtype(uint32_t memtype) { In general please add prefixes to even static functions, e.g. amdgpu_vm_ or amdgpu_bo_. + 

Re: [PATCH] drm: xlnx: zynqmp_dpsub: fix hotplug detection

2024-10-23 Thread Tomi Valkeinen
On 21/10/2024 16:41, Steffen Dirkwinkel wrote: From: Steffen Dirkwinkel drm_kms_helper_poll_init needs to be called after zynqmp_dpsub_kms_init. zynqmp_dpsub_kms_init creates the connector and without it we don't enable hotplug detection. Signed-off-by: Steffen Dirkwinkel --- drivers/gpu/dr

Re: [PATCH 42/43] drm/fbdev-generic: Convert to fbdev-ttm

2024-10-23 Thread Jon Hunter
On 23/10/2024 07:43, Thomas Zimmermann wrote: Hi Am 22.10.24 um 17:36 schrieb Jon Hunter: We'd turn a linker/modpost error into a compiler error. Likely makes no difference. And AFAICT every driver that selects TTM also selects TTM_HELPER. Drivers without TTM should not use this header.

Re: [PATCH 2/7] drm/drv: Add drmm cgroup registration for dev cgroups.

2024-10-23 Thread Jani Nikula
On Wed, 23 Oct 2024, Maarten Lankhorst wrote: > From: Maxime Ripard > > Drivers will need to register a cgroup device at probe time, so let's > give them a drm-managed helper. > > Signed-off-by: Maxime Ripard > Signed-off-by: Maarten Lankhorst > --- > drivers/gpu/drm/drm_drv.c | 21 ++

Re: [PATCH 42/43] drm/fbdev-generic: Convert to fbdev-ttm

2024-10-23 Thread Jon Hunter
On 23/10/2024 09:44, Jon Hunter wrote: On 23/10/2024 07:43, Thomas Zimmermann wrote: Hi Am 22.10.24 um 17:36 schrieb Jon Hunter: We'd turn a linker/modpost error into a compiler error. Likely makes no difference. And AFAICT every driver that selects TTM also selects TTM_HELPER. Drivers w

Re: [PATCH 6/7] [HACK] drm/xe: Hack to test with mapped pages instead of vram.

2024-10-23 Thread Jani Nikula
On Wed, 23 Oct 2024, Maarten Lankhorst wrote: > We will probably want to make this a proper region in TTM for > everything, so that we can charge VRAM twice, once for mapped > in sysmem, once for mapped in vram. That way we don't need to > deal with evict failing from lack of available memory in

[PATCH v3] drm/amdgpu: Add dcn30 drm_panic support

2024-10-23 Thread Jocelyn Falempe
Add support for the drm_panic module, which displays a pretty user friendly message on the screen when a Linux kernel panic occurs. It should work on all radeon using amdgpu_dm_plane.c, when the framebuffer is linear (like when in a VT). For tiled framebuffer, it will only work on radeon with dcn3

[PULL] drm-intel-gt-next

2024-10-23 Thread Tvrtko Ursulin
Hi Dave, Sima, This is the main pull request for 6.13 merge window. PXP GuC auto-teardown feature got enabled, GPU reset robustness improvement for Haswell and basic PMU functionality was enabled for Gen2 platforms. The rest is a handful of small cleanups. Regards, Tvrtko drm-intel-gt-next-

Re: [PATCH v1 04/10] media: platform: mediatek: add isp_7x cam-raw unit

2024-10-23 Thread 胡俊光

Re: [PATCH 1/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04 devices

2024-10-23 Thread Armin Wolf
Am 22.10.24 um 21:15 schrieb Pavel Machek: Hi! - interface for setting multiple LEDs at once - interface for setting a range of LEDs at once How are LEDs ordered? I don't believe range makes much sense. Range would allow for efficiently changing the color of all LEDs. But i agree that this c

Re: [PATCH v2 1/5] dt-bindings: display: panel: Move flip properties to panel-common

2024-10-23 Thread Krzysztof Kozlowski
On Tue, Oct 22, 2024 at 11:33:35PM +0200, Jakob Hauser wrote: > The flip properties were used by "samsung,s6e8aa0.yaml" only so far. By > introducing "samsung,s6e88a0-ams427ap24.yaml" they become more common. > > Signed-off-by: Jakob Hauser > --- > Patch is based on current branch drm-misc-next.

Re: [PATCH v2 2/5] dt-bindings: display: panel: Add Samsung S6E88A0-AMS427AP24 bindings

2024-10-23 Thread Krzysztof Kozlowski
On Tue, Oct 22, 2024 at 11:33:36PM +0200, Jakob Hauser wrote: > Add bindings for Samsung AMS427AP24 panel with S6E88A0 controller. > > Signed-off-by: Jakob Hauser > --- > Patch is based on current branch drm-misc-next. > > Changes in v2: > - Adapted property "flip-horizontal" to being moved to

Re: [PATCH] drm: xlnx: zynqmp_disp: layer may be null while releasing

2024-10-23 Thread Tomi Valkeinen
Hi, On 21/10/2024 16:51, Steffen Dirkwinkel wrote: From: Steffen Dirkwinkel layer->info can be null if we have an error on the first layer in zynqmp_disp_create_layers Signed-off-by: Steffen Dirkwinkel --- drivers/gpu/drm/xlnx/zynqmp_disp.c | 3 +++ 1 file changed, 3 insertions(+) diff -

Re: [PATCH 4/5] drm/client: Remove unused drm_client_framebuffer_flush

2024-10-23 Thread Dr. David Alan Gilbert
* Jocelyn Falempe (jfale...@redhat.com) wrote: > On 23/10/2024 08:46, Thomas Zimmermann wrote: > > Hi > > > > Am 23.10.24 um 01:29 schrieb li...@treblig.org: > > > From: "Dr. David Alan Gilbert" > > > > > > drm_client_framebuffer_flush() was explicitly added in 2020 > > > by > > > commit c9c03e3

Re: [PATCH v5 4/4] drm/amdgpu: track bo memory stats at runtime

2024-10-23 Thread Tvrtko Ursulin
On 23/10/2024 10:14, Christian König wrote: Am 23.10.24 um 09:38 schrieb Tvrtko Ursulin: On 22/10/2024 17:24, Christian König wrote: Am 22.10.24 um 17:17 schrieb Li, Yunxiang (Teddy): [Public] +static uint32_t fold_memtype(uint32_t memtype) { In general please add prefixes to even static

[PATCH v4 3/3] drm: xlnx: zynqmp_dpsub: Add DP audio support

2024-10-23 Thread Tomi Valkeinen
Add basic DisplayPort audio support. Support non-live audio playback from two PCMs (DMA channels), and the volume control in the audio mixer. As older dtb files may not have the audio DMA channels defined, the driver will just mark the audio support as disabled if the audio DMA is missing, and wi

[PATCH v4 0/3] drm: xlnx: zynqmp: Add DP audio support

2024-10-23 Thread Tomi Valkeinen
Add DisplayPort audio support for Xilinx ZynqMP platforms. The current DT is, for some reason, missing the DMA channels for the audio. This series adds that to the bindings and the dts file, but to support older dtb files without the audio DMA, the driver will not fail if the audio DMA is missing,

[PATCH v4 1/3] dt-bindings: display/xlnx/zynqmp-dpsub: Add audio DMAs

2024-10-23 Thread Tomi Valkeinen
The DP subsystem for ZynqMP supports audio via two channels, and the DP DMA has dma-engines for those channels. For some reason the DT binding has not specified those channels, even if the picture included in xlnx,zynqmp-dpsub.yaml shows "2 x aud" DMAs. This hasn't caused any issues as the drivers

Re: [PATCH v3 2/3] arm64: dts: zynqmp: Add DMA for DP audio

2024-10-23 Thread Tomi Valkeinen
Hi Michal, On 08/10/2024 11:22, Michal Simek wrote: On 9/10/24 13:19, Tomi Valkeinen wrote: Add the two DMA channels used for the DisplayPort audio to the zynqmp_dpsub node. Signed-off-by: Tomi Valkeinen ---   arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 7 +--   1 file changed, 5 insertions

[PATCH v5 1/6] drm/panic: Move drawing functions to drm_draw

2024-10-23 Thread Jocelyn Falempe
Move the color conversions, blit and fill functions to drm_draw.c, so that they can be re-used by drm_log. drm_draw is internal to the drm subsystem, and shouldn't be used by gpu drivers. Signed-off-by: Jocelyn Falempe --- v5: * Export drm_draw symbols, so they can be used if drm_client_lib is

[PATCH v5 0/6] drm/log: Introduce a new boot logger to draw the kmsg on the screen

2024-10-23 Thread Jocelyn Falempe
drm_log is a simple logger that uses the drm_client API to print the kmsg boot log on the screen. This is not a full replacement to fbcon, as it will only print the kmsg. It will never handle user input, or a terminal because this is better done in userspace. If you're curious on how it looks li

Re: [PATCH v5 4/4] drm/amdgpu: track bo memory stats at runtime

2024-10-23 Thread Tvrtko Ursulin
On 23/10/2024 13:12, Christian König wrote: Am 23.10.24 um 13:37 schrieb Tvrtko Ursulin: On 23/10/2024 10:14, Christian König wrote: Am 23.10.24 um 09:38 schrieb Tvrtko Ursulin: On 22/10/2024 17:24, Christian König wrote: Am 22.10.24 um 17:17 schrieb Li, Yunxiang (Teddy): [Public] +sta

Re: [PATCH v5 4/4] drm/amdgpu: track bo memory stats at runtime

2024-10-23 Thread Christian König
Am 23.10.24 um 13:37 schrieb Tvrtko Ursulin: On 23/10/2024 10:14, Christian König wrote: Am 23.10.24 um 09:38 schrieb Tvrtko Ursulin: On 22/10/2024 17:24, Christian König wrote: Am 22.10.24 um 17:17 schrieb Li, Yunxiang (Teddy): [Public] +static uint32_t fold_memtype(uint32_t memtype) { I

[PATCH v5 3/6] drm/log: Do not draw if drm_master is taken

2024-10-23 Thread Jocelyn Falempe
When userspace takes drm_master, the drm_client buffer is no more visible, so drm_log shouldn't waste CPU cycle to draw on it. Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/drm_log.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_log.c b/d

[PATCH v5 4/6] drm/log: Color the timestamp, to improve readability

2024-10-23 Thread Jocelyn Falempe
Color the timesamp prefix, similar to dmesg. Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/drm_log.c | 27 +-- 1 file changed, 21 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/drm_log.c b/drivers/gpu/drm/drm_log.c index 226e206e8b6a3..635dff7b37ce5 1006

[PATCH v5 2/6] drm/log: Introduce a new boot logger to draw the kmsg on the screen

2024-10-23 Thread Jocelyn Falempe
drm_log is a simple logger that uses the drm_client API to print the kmsg boot log on the screen. This is not a full replacement to fbcon, as it will only print the kmsg. It will never handle user input, or a terminal because this is better done in userspace. Design decisions: * It uses the drm_c

[PATCH v5 5/6] drm/log: Implement suspend/resume

2024-10-23 Thread Jocelyn Falempe
The console is already suspended in printk.c. Just make sure we don't write to the framebuffer while the graphic driver is suspended. It may lose a few messages between graphic suspend and console suspend. Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/drm_log.c | 26

Re: vc4: HDMI Sink doesn't support RGB, something's wrong.

2024-10-23 Thread Dave Stevenson
On Sat, 19 Oct 2024 at 10:34, Stefan Wahren wrote: > > Hi, > > Am 17.10.24 um 17:59 schrieb Maxime Ripard: > > On Thu, Oct 17, 2024 at 05:26:46PM GMT, Stefan Wahren wrote: > >> Am 17.10.24 um 16:27 schrieb Maxime Ripard: > >>> On Wed, Oct 16, 2024 at 07:16:43PM GMT, Dave Stevenson wrote: > Hi

Re: [PATCH 1/7] kernel/cgroup: Add "dev" memory accounting cgroup

2024-10-23 Thread Waiman Long
On 10/23/24 3:52 AM, Maarten Lankhorst wrote: The initial version was based roughly on the rdma and misc cgroup controllers, with a lot of the accounting code borrowed from rdma. The current version is a complete rewrite with page counter; it uses the same min/low/max semantics as the memory cgr

Re: [PATCH] PCI/VGA: Don't assume only VGA device found is the boot VGA device

2024-10-23 Thread Alex Deucher
On Tue, Oct 22, 2024 at 9:27 PM Kai-Heng Feng wrote: > > > > On 2024/10/22 9:04 PM, Alex Deucher wrote: > > External email: Use caution opening links or attachments > > > > > > On Tue, Oct 22, 2024 at 2:31 AM Kai-Heng Feng wrote: > >> > >> Hi Luke, > >> > >> On 2024/10/15 4:04 PM, Luke Jones wrot

Re: [PATCH 1/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04 devices

2024-10-23 Thread Werner Sembach
Hi Am 22.10.24 um 11:47 schrieb Pavel Machek: Hi! Sorry for taking a bit long to respond. This "illumination" subsystem would (from my perspective) act like some sort of LED subsystem for devices with a high count of LEDs, like some RGB keyboards. This would allow us too: - provide an abstr

RE: [PATCH v5 4/4] drm/amdgpu: track bo memory stats at runtime

2024-10-23 Thread Li, Yunxiang (Teddy)
[AMD Official Use Only - AMD Internal Distribution Only] Yeah it looks like I missed the whole active/purgeable thing as well... Teddy

Re: [PATCH next] drm/sharp-memory: Fix some checks in sharp_memory_probe()

2024-10-23 Thread Alex Lanzano
On Wed, Oct 23, 2024 at 11:30:31AM +0300, Dan Carpenter wrote: > The devm_drm_dev_alloc() function returns error pointers, it never > returns NULL. Change that check to IS_ERR(). > > The devm_gpiod_get_optional() function returns a mix of error pointers > if there is an error, or NULL if there is

[PATCH] drm/amd/display: add missing tracepoint event in DM atomic_commit_tail

2024-10-23 Thread Melissa Wen
There are two events to trace the beginning and the end of amdgpu_dm_atomic_commit_tail, but only the one ate the beginning was placed. Place amdgpu_dm_atomic_commit_tail_finish tracepoint at the end than. Signed-off-by: Melissa Wen --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 ++ 1

RE: [PATCH v5 4/4] drm/amdgpu: track bo memory stats at runtime

2024-10-23 Thread Li, Yunxiang (Teddy)
[AMD Official Use Only - AMD Internal Distribution Only] > From: Tvrtko Ursulin > Sent: Wednesday, October 23, 2024 8:25 > On 23/10/2024 13:12, Christian König wrote: > > Am 23.10.24 um 13:37 schrieb Tvrtko Ursulin: > >> > >> On 23/10/2024 10:14, Christian König wrote: > >>> Am 23.10.24 um 09:38

[PATCH 1/5] drm: Introduce sharpness strength property

2024-10-23 Thread Nemesa Garg
Introduces the new crtc property "SHARPNESS_STRENGTH" that allows the user to set the intensity so as to get the sharpness effect. The value of this property can be set from 0-255. It is useful in scenario when the output is blurry and user want to sharpen the pixels. User can increase/decrease the

[PATCH 0/5] Introduce drm sharpness property

2024-10-23 Thread Nemesa Garg
Many a times images are blurred or upscaled content is also not as crisp as original rendered image. Traditional sharpening techniques often apply a uniform level of enhancement across entire image, which sometimes result in over-sharpening of some areas and potential loss of natural detail

[PATCH 4/5] drm/i915/display: Add registers and compute the strength

2024-10-23 Thread Nemesa Garg
Add new registers and related bits. Compute the strength value and tap value based on display mode. v2: Replace i915/dev_priv with display[Jani] v3: Create separate file for defining register[Jani] Add display->drm in debug prints[Jani] v4: Rebase Signed-off-by: Nemesa Garg --- drivers/gpu/

[PATCH 5/5] drm/i915/display: Load the lut values and enable sharpness

2024-10-23 Thread Nemesa Garg
Load the lut values during pipe enable. v2: Add the display version check Signed-off-by: Nemesa Garg --- drivers/gpu/drm/i915/display/intel_crtc.c| 3 +++ drivers/gpu/drm/i915/display/intel_display.c | 6 ++ .../gpu/drm/i915/display/intel_display_types.h | 2 ++ drivers/gpu

[PATCH 3/5] drm/i915/display: Enable the second scaler for sharpness

2024-10-23 Thread Nemesa Garg
As only second scaler can be used for sharpness check if it is available and also check if panel fitting is also not enabled, then set the sharpness. Panel fitting will have the preference over sharpness property. v2: Add the panel fitting check before enabling sharpness v3: Reframe commit message

[PATCH 2/5] drm/i915/display: Compute the scaler filter coefficients

2024-10-23 Thread Nemesa Garg
The sharpness property requires the use of one of the scaler so need to set the sharpness scaler coefficient values. These values are based on experiments and vary for different tap value/win size. These values are normalized by taking the sum of all values and then dividing each value with a sum.

Re: [PATCH] drm/amd/display: add missing tracepoint event in DM atomic_commit_tail

2024-10-23 Thread Leo Li
On 2024-10-23 09:53, Melissa Wen wrote: There are two events to trace the beginning and the end of amdgpu_dm_atomic_commit_tail, but only the one ate the beginning was placed. Place amdgpu_dm_atomic_commit_tail_finish tracepoint at the end than. Signed-off-by: Melissa Wen Reviewed-by: Leo

Re: [PATCH v4 00/11] Preemption support for A7XX

2024-10-23 Thread Akhil P Oommen
On 10/22/2024 8:35 PM, Rob Clark wrote: > On Fri, Sep 20, 2024 at 9:15 AM Akhil P Oommen > wrote: >> >> On Wed, Sep 18, 2024 at 08:39:30AM -0700, Rob Clark wrote: >>> On Wed, Sep 18, 2024 at 12:46 AM Neil Armstrong >>> wrote: Hi, On 17/09/2024 13:14, Antonino Maniscalco wrote

Re: [PATCH v5 1/1] drm/mediatek: Fix get efuse issue for MT8188 DPTX

2024-10-23 Thread Chun-Kuang Hu
Hi, Liankun: Liankun Yang 於 2024年9月23日 週一 下午9:25寫道: > > Update efuse data for MT8188 displayport. > > The DP monitor can not display when DUT connected to USB-c to DP dongle. > Analysis view is invalid DP efuse data. Applied to mediatek-drm-fixes [1], thanks. [1] https://git.kernel.org/pub/scm

Re: [PATCH] dt-bindings: display: mediatek: dpi: Update device list with power-domains

2024-10-23 Thread Chun-Kuang Hu
Hi, Fei: Fei Shao 於 2024年10月19日 週六 下午1:30寫道: > > There are two kinds of MediaTek DPI devices in the tree: the ones with a > power domain and those without (or missing). The former are the majority > and are more common in newer DTs. Only three older DTs fall into the > latter category: MT2701, MT

Re: [PATCH 2/3] dt-bindings: display: panel: add YAML schema for LXD M9189A

2024-10-23 Thread Rob Herring (Arm)
On Wed, 23 Oct 2024 14:44:09 +0200, Rouven Czerwinski wrote: > The LXD M9189A is a 1024x600 MIPI-DSI panel. > > Signed-off-by: Rouven Czerwinski > --- > .../bindings/display/panel/lxd,m9189a.yaml| 64 +++ > 1 file changed, 64 insertions(+) > create mode 100644 > Documenta

Re: [PATCH 1/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04 devices

2024-10-23 Thread Werner Sembach
Am 22.10.24 um 11:05 schrieb Benjamin Tissoires: Sorry I should have answered earlier... On Oct 09 2024, Werner Sembach wrote: Resend because HTML mail ..., but I think I now know when Thunderbird does it: Every time I include a link it gets converted. Hi Am 08.10.24 um 17:21 schrieb Benjam

Re: [PATCH v5 4/4] drm/amdgpu: track bo memory stats at runtime

2024-10-23 Thread Tvrtko Ursulin
On 23/10/2024 14:31, Li, Yunxiang (Teddy) wrote: [AMD Official Use Only - AMD Internal Distribution Only] From: Tvrtko Ursulin Sent: Wednesday, October 23, 2024 8:25 On 23/10/2024 13:12, Christian König wrote: Am 23.10.24 um 13:37 schrieb Tvrtko Ursulin: On 23/10/2024 10:14, Christian Kön

Re: [PATCH v3 2/3] arm64: dts: zynqmp: Add DMA for DP audio

2024-10-23 Thread Michal Simek
Hi Tomi, On 10/23/24 14:00, Tomi Valkeinen wrote: Hi Michal, On 08/10/2024 11:22, Michal Simek wrote: On 9/10/24 13:19, Tomi Valkeinen wrote: Add the two DMA channels used for the DisplayPort audio to the zynqmp_dpsub node. Signed-off-by: Tomi Valkeinen ---   arch/arm64/boot/dts/xilinx/zy

Re: [PATCH v6 02/15] net: generalise net_iov chunk owners

2024-10-23 Thread Pavel Begunkov
On 10/23/24 08:20, Christoph Hellwig wrote: On Wed, Oct 16, 2024 at 11:52:39AM -0700, David Wei wrote: From: Pavel Begunkov Currently net_iov stores a pointer to struct dmabuf_genpool_chunk_owner, which serves as a useful abstraction to share data and provide a context. However, it's too devme

Re: [PATCH v6 4/4] dt-bindings: display: mediatek: dpi: correct power-domains property

2024-10-23 Thread Chun-Kuang Hu
Hi, Macpaul: Macpaul Lin 於 2024年10月3日 週四 上午11:09寫道: > > The MediaTek DPI module is typically associated with one of the > following multimedia power domains: > - POWER_DOMAIN_DISPLAY > - POWER_DOMAIN_VDOSYS > - POWER_DOMAIN_MM > The specific power domain used varies depending on the SoC design

Re: [PATCH 1/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04 devices

2024-10-23 Thread Pavel Machek
Hi! > > > > > Personally I really like the idea to just emulate a HID LampArray > > > > > device > > > > > for this instead or rolling our own API. I believe there need to be > > > > > strong arguments to go with some alternative NIH API and I have not > > > > > heard such arguments yet. > > > >

[PATCH v4 2/3] arm64: dts: zynqmp: Add DMA for DP audio

2024-10-23 Thread Tomi Valkeinen
Add the two DMA channels used for the DisplayPort audio to the zynqmp_dpsub node. Acked-by: Michal Simek Signed-off-by: Tomi Valkeinen --- arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/

Re: [PATCH v5 4/4] drm/amdgpu: track bo memory stats at runtime

2024-10-23 Thread Christian König
Am 23.10.24 um 14:24 schrieb Tvrtko Ursulin: [SNIP] To fold or not the special placements (GWS, GDS & co) is also tangential. In my patch I just preserved the legacy behaviour so it can easily be tweaked on top. Yeah, but again the original behavior is completely broken. GWS, GDS and OA are

Re: [PATCH] drm/i915/active: Use try_cmpxchg() in active_fence_cb()

2024-10-23 Thread Jani Nikula
On Thu, 03 Oct 2024, Uros Bizjak wrote: > Replace this pattern in active_fence_cb(): > > cmpxchg(*ptr, old, new) == old > > ... with the simpler and faster: > > try_cmpxchg(*ptr, &old, new) > > The x86 CMPXCHG instruction returns success in the ZF flag, > so this change saves a compare aft

[PATCH AUTOSEL 6.11 25/30] drm/amdkfd: Accounting pdd vram_usage for svm

2024-10-23 Thread Sasha Levin
From: Philip Yang [ Upstream commit 68d26c10ef503175df3142db6fcd75dd94860592 ] Process device data pdd->vram_usage is read by rocm-smi via sysfs, this is currently missing the svm_bo usage accounting, so "rocm-smi --showpids" per process VRAM usage report is incorrect. Add pdd->vram_usage accou

[PATCH AUTOSEL 6.11 28/30] drm/xe/query: Increase timestamp width

2024-10-23 Thread Sasha Levin
From: Lucas De Marchi [ Upstream commit 477d665e9b6a1369968383f50c688d56b692a155 ] Starting with Xe2 the timestamp is a full 64 bit counter, contrary to the 36 bit that was available before. Although 36 should be sufficient for any reasonable delta calculation (for Xe2, of about 30min), it's sur

[PATCH AUTOSEL 6.11 19/30] drm/vmwgfx: Limit display layout ioctl array size to VMWGFX_NUM_DISPLAY_UNITS

2024-10-23 Thread Sasha Levin
From: Ian Forbes [ Upstream commit 28a5dfd4f615539fb22fb6d5c219c199c14e6eb6 ] Currently the array size is only limited by the largest kmalloc size which is incorrect. This change will also return a more specific error message than ENOMEM to userspace. Signed-off-by: Ian Forbes Reviewed-by: Zac

[PATCH AUTOSEL 6.6 15/23] drm/vmwgfx: Limit display layout ioctl array size to VMWGFX_NUM_DISPLAY_UNITS

2024-10-23 Thread Sasha Levin
From: Ian Forbes [ Upstream commit 28a5dfd4f615539fb22fb6d5c219c199c14e6eb6 ] Currently the array size is only limited by the largest kmalloc size which is incorrect. This change will also return a more specific error message than ENOMEM to userspace. Signed-off-by: Ian Forbes Reviewed-by: Zac

[PATCH AUTOSEL 6.6 19/23] drm/amdkfd: Accounting pdd vram_usage for svm

2024-10-23 Thread Sasha Levin
From: Philip Yang [ Upstream commit 68d26c10ef503175df3142db6fcd75dd94860592 ] Process device data pdd->vram_usage is read by rocm-smi via sysfs, this is currently missing the svm_bo usage accounting, so "rocm-smi --showpids" per process VRAM usage report is incorrect. Add pdd->vram_usage accou

[PATCH AUTOSEL 6.1 12/17] drm/vmwgfx: Limit display layout ioctl array size to VMWGFX_NUM_DISPLAY_UNITS

2024-10-23 Thread Sasha Levin
From: Ian Forbes [ Upstream commit 28a5dfd4f615539fb22fb6d5c219c199c14e6eb6 ] Currently the array size is only limited by the largest kmalloc size which is incorrect. This change will also return a more specific error message than ENOMEM to userspace. Signed-off-by: Ian Forbes Reviewed-by: Zac

[PATCH AUTOSEL 5.15 09/10] drm/vmwgfx: Limit display layout ioctl array size to VMWGFX_NUM_DISPLAY_UNITS

2024-10-23 Thread Sasha Levin
From: Ian Forbes [ Upstream commit 28a5dfd4f615539fb22fb6d5c219c199c14e6eb6 ] Currently the array size is only limited by the largest kmalloc size which is incorrect. This change will also return a more specific error message than ENOMEM to userspace. Signed-off-by: Ian Forbes Reviewed-by: Zac

Re: [PATCH v5] dt-bindings: display: mediatek: split: add subschema property constraints

2024-10-23 Thread Chun-Kuang Hu
Hi, Moudy: Moudy Ho 於 2024年10月7日 週一 上午10:28寫道: > > The display node in mt8195.dtsi was triggering a CHECK_DTBS error due > to an excessively long 'clocks' property: > display@14f06000: clocks: [[31, 14], [31, 43], [31, 44]] is too long > > To resolve this issue, the constraints for 'clocks' and

[pull] amdgpu drm-fixes-6.12

2024-10-23 Thread Alex Deucher
Hi Dave, Simona, Fixes for 6.12. The following changes since commit 42f7652d3eb527d03665b09edac47f85fb600924: Linux 6.12-rc4 (2024-10-20 15:19:38 -0700) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm-fixes-6.12-2024-10-23 for you to fe

[PATCH v5 6/6] drm/log: Add integer scaling support

2024-10-23 Thread Jocelyn Falempe
Add a module parameter, to increase the font size for HiDPI screen. Even with CONFIG_FONT_TER16x32, it can still be a bit small to read. In this case, adding drm_log.scale=2 to your kernel command line will double the character size. Signed-off-by: Jocelyn Falempe --- v5: * Change scale paramet

Re: [PATCH] drm/mediatek: Fix potential NULL dereference in mtk_crtc_destroy()

2024-10-23 Thread Chun-Kuang Hu
Hi, Dan: Dan Carpenter 於 2024年9月12日 週四 下午4:45寫道: > > In mtk_crtc_create(), if the call to mbox_request_channel() fails then we > set the "mtk_crtc->cmdq_client.chan" pointer to NULL. In that situation, > we do not call cmdq_pkt_create(). > > During the cleanup, we need to check if the "mtk_crtc-

[PATCH] drm/sched: warn about drm_sched_job_init()'s partial init

2024-10-23 Thread Philipp Stanner
drm_sched_job_init()'s name suggests that after the function succeeded, parameter "job" will be fully initialized. This is not the case; some members are only later set, notably drm_sched_job.sched by drm_sched_job_arm(). Document that drm_sched_job_init() does not set all struct members. Documen

[PATCH 36/37] arm64: dts: broadcom: Add display pipeline support to BCM2712

2024-10-23 Thread Dave Stevenson
Adds the HVS and associated hardware blocks to support the HDMI and writeback connectors on BCM2712 / Pi5. Signed-off-by: Dave Stevenson --- arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts | 14 ++ arch/arm64/boot/dts/broadcom/bcm2712.dtsi| 188 +++ 2 files changed,

[PATCH 27/37] drm/vc4: Add additional warn_on for incorrect revisions

2024-10-23 Thread Dave Stevenson
From: Maxime Ripard Some code path in vc4 are conditional to a generation and cannot be executed on others. Let's put a WARN_ON if that ever happens. Signed-off-by: Maxime Ripard Signed-off-by: Dave Stevenson --- drivers/gpu/drm/vc4/vc4_hvs.c | 30 -- drivers/gpu

[PATCH 34/37] clk: bcm: rpi: Add disp clock

2024-10-23 Thread Dave Stevenson
From: Maxime Ripard BCM2712 has an extra clock exposed by the firmware called DISP, and used by (at least) the HVS. Let's add it to the list of clocks to register in Linux. Signed-off-by: Maxime Ripard Signed-off-by: Dave Stevenson --- drivers/clk/bcm/clk-raspberrypi.c | 5 + inc

[PATCH 35/37] arm64: dts: broadcom: Add firmware clocks and power nodes to Pi5 DT

2024-10-23 Thread Dave Stevenson
BCM2712 still uses the firmware clocks and power drivers, so add them to the base device tree. Signed-off-by: Dave Stevenson --- arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts | 28 1 file changed, 28 insertions(+) diff --git a/arch/arm64/boot/dts/broadcom/bcm2712-rpi

[PATCH 32/37] clk: bcm: rpi: Enable minimize for all firmware clocks

2024-10-23 Thread Dave Stevenson
From: Dom Cobley There isn't a reason not to minimise the clocks, and it saves some power. Signed-off-by: Dom Cobley Signed-off-by: Dave Stevenson --- drivers/clk/bcm/clk-raspberrypi.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/clk/bcm/clk-raspberrypi.c b/drivers/clk/b

[PATCH 16/37] drm/vc4: txp: Add byte enable toggle bit

2024-10-23 Thread Dave Stevenson
From: Maxime Ripard The MOPLET doesn't have the BYTE_ENABLE field to set, but the TXP and MOP do, so let's add a boolean to control whether or not we need to set it. Signed-off-by: Maxime Ripard Signed-off-by: Dave Stevenson --- drivers/gpu/drm/vc4/vc4_drv.h | 1 + drivers/gpu/drm/vc4/vc4_txp

[PATCH 30/37] clk: bcm: rpi: Add ISP to exported clocks

2024-10-23 Thread Dave Stevenson
From: Dom Cobley The ISP clock can be controlled by the driver, so register it with the clock subsystem. Signed-off-by: Dom Cobley Signed-off-by: Dave Stevenson --- drivers/clk/bcm/clk-raspberrypi.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/clk/bcm/clk-raspberrypi.c b/dr

[PATCH 37/37] arm64: dts: broadcom: Add DT for D-step version of BCM2712

2024-10-23 Thread Dave Stevenson
The D-Step has some minor variations in the hardware, so needs matching changes to DT. Add a new DTS file that modifies the existing (C-step) devicetree. Signed-off-by: Dave Stevenson --- arch/arm64/boot/dts/broadcom/Makefile | 1 + arch/arm64/boot/dts/broadcom/bcm2712-d-rpi-5-b.d

[PATCH 26/37] drm/vc4: hdmi: Support 2712 D-step register map

2024-10-23 Thread Dave Stevenson
The D-step has increased FIFO sizes of the MAI_THR blocks, resulting in changes to the register masking. Add support for it. Signed-off-by: Dave Stevenson --- drivers/gpu/drm/vc4/vc4_hdmi.c | 19 +-- drivers/gpu/drm/vc4/vc4_regs.h | 9 + 2 files changed, 26 insertions(+)

[PATCH 28/37] drm/vc4: Enable bg_fill if there are no planes enabled

2024-10-23 Thread Dave Stevenson
The default was to have enable_bg_fill disabled and the first plane set it if it wasn't opaque and covering the whole screen. However that meant that if no planes were enabled, then the background fill wasn't enabled, and would give a striped output from the uninitialised output buffer. Initialise

[PATCH 14/37] drm/vc4: txp: Introduce structure to deal with revision differences

2024-10-23 Thread Dave Stevenson
From: Maxime Ripard The BCM2712 will have several TXP with small differences. Let's add a structure tied to the compatible to deal with those differences. Signed-off-by: Maxime Ripard Signed-off-by: Dave Stevenson --- drivers/gpu/drm/vc4/tests/vc4_mock.c | 4 ++-- drivers/gpu/drm/vc4/vc4_drv

  1   2   >