[PATCH v2 1/1] drm/i2c: tda998x: Make use of irq_get_trigger_type()

2024-09-13 Thread Vasileios Amoiridis
Convert irqd_get_trigger_type(irq_get_irq_data(irq)) cases to the more simple irq_get_trigger_type(irq). Suggested-by: Andy Shevchenko Signed-off-by: Vasileios Amoiridis --- drivers/gpu/drm/i2c/tda998x_drv.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i

[PATCH v2 0/1] Use functionality of irq_get_trigger_type()

2024-09-13 Thread Vasileios Amoiridis
Changes in v2: - Split patches to subsystems - Add tag --- v1: https://lore.kernel.org/all/20240902225534.130383-1-vassilisa...@gmail.com/ Vasileios Amoiridis (1): drm/i2c: tda998x: Make use of irq_get_trigger_type() drivers/gpu/drm/i2c/tda998x_drv.c | 3 +-- 1 file changed, 1

[PATCH v1] drm/i915/gvt: Correct multiple typos in comments

2024-09-13 Thread Shen Lichuan
Fixed some spelling errors, the details are as follows: -in the code comments: addess->address trasitions->transitions furture->future unsubmited->unsubmitted Signed-off-by: Shen Lichuan --- drivers/gpu/drm/i915/gvt/gtt.c| 2 +- drivers/gpu/drm/i915/gvt/o

Re: [NOT A REGRESSION] firmware: framebuffer-coreboot: duplicate device name "simple-framebuffer.0"

2024-09-13 Thread Javier Martinez Canillas
Thomas Zimmermann writes: Hello Thomas, > Hi Javier, > > thanks for the patch. > Thanks for your feedback. > Am 12.09.24 um 18:33 schrieb Javier Martinez Canillas: >> Julius Werner writes: [...] >> --- >> drivers/firmware/google/framebuffer-coreboot.c | 16 >> 1 file cha

[PATCH v3 0/2] drm/nouveau: Add drm_panic support for nv50+

2024-09-13 Thread Jocelyn Falempe
This series adds basic drm_panic support for nouveau. Patches 1 Add ABGR2101010 support in drm_panic. Patch 2 registers nouveau to drm_panic, and handle tiling. I've tested on a GTX1650 (Turing) and GF 8800 GT (Tesla), while running Gnome/Wayland desktop, and in VT. It should work on other nv50+ c

[PATCH v3 1/2] drm/panic: Add ABGR2101010 support

2024-09-13 Thread Jocelyn Falempe
Add support for ABGR2101010, used by the nouveau driver. Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/drm_panic.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/gpu/drm/drm_panic.c b/drivers/gpu/drm/drm_panic.c index 74412b7bf936..0a9ecc1380d2 100644 --- a/drivers/

[PATCH v3 2/2] drm/nouveau: Add drm_panic support for nv50+

2024-09-13 Thread Jocelyn Falempe
Add drm_panic support, for nv50+ cards. It's enough to get the panic screen while running Gnome/Wayland on a GTX 1650. It doesn't support multi-plane or compressed format. Support for other formats and older cards will come later. Tiling is only tested on GTX1650, and might be wrong for other cards

Re: [PATCH v3 1/2] drm/panic: Add ABGR2101010 support

2024-09-13 Thread Javier Martinez Canillas
Jocelyn Falempe writes: Hello Jocelyn, > Add support for ABGR2101010, used by the nouveau driver. > > Signed-off-by: Jocelyn Falempe > --- > drivers/gpu/drm/drm_panic.c | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/gpu/drm/drm_panic.c b/drivers/gpu/drm/drm_panic.

Re: [PATCH 1/7] dma-buf: add WARN_ON() illegal dma-fence signaling

2024-09-13 Thread Philipp Stanner
On Thu, 2024-09-12 at 16:55 +0200, Christian König wrote: > Am 11.09.24 um 11:44 schrieb Philipp Stanner: > > On Wed, 2024-09-11 at 10:58 +0200, Christian König wrote: > > > Calling the signaling a NULL fence is obviously a coding error in > > > a > > > driver. Those functions unfortunately just re

Re: [PATCH v4 RESEND 0/9] Increase coverage on drm_framebuffer.c

2024-09-13 Thread Jani Nikula
On Wed, 11 Sep 2024, Maxime Ripard wrote: > On Tue, 10 Sep 2024 21:15:25 -0300, Carlos Eduardo Gallo Filho wrote: >> This patchset includes new KUnit tests for 5 untested functions from >> drm_framebuffer.c and improvements to the existent one. >> >> The first patch replace the use of dev_private

Re: [PATCH] drm/tidss: Add MIT license along with GPL-2.0

2024-09-13 Thread Uwe Kleine-König
Hello, On Thu, Sep 12, 2024 at 10:47:31PM +0200, Danilo Krummrich wrote: > On 9/12/24 7:11 PM, Devarsh Thakkar wrote: > > Modify license to include dual licensing as GPL-2.0-only OR MIT license for > > tidss display driver. This allows other operating system ecosystems such as > > Zephyr and also

Re: [PATCH] drm/tidss: Add MIT license along with GPL-2.0

2024-09-13 Thread Javier Martinez Canillas
Uwe Kleine-König writes: > Hello, > > On Thu, Sep 12, 2024 at 10:47:31PM +0200, Danilo Krummrich wrote: >> On 9/12/24 7:11 PM, Devarsh Thakkar wrote: >> > Modify license to include dual licensing as GPL-2.0-only OR MIT license for >> > tidss display driver. This allows other operating system ecos

Re: [PATCH v4 RESEND 0/9] Increase coverage on drm_framebuffer.c

2024-09-13 Thread Maxime Ripard
On Fri, Sep 13, 2024 at 10:31:08AM GMT, Jani Nikula wrote: > On Wed, 11 Sep 2024, Maxime Ripard wrote: > > On Tue, 10 Sep 2024 21:15:25 -0300, Carlos Eduardo Gallo Filho wrote: > >> This patchset includes new KUnit tests for 5 untested functions from > >> drm_framebuffer.c and improvements to the

Re: [PATCH] drm/tidss: Add MIT license along with GPL-2.0

2024-09-13 Thread Geert Uytterhoeven
On Fri, Sep 13, 2024 at 9:38 AM Javier Martinez Canillas wrote: > Uwe Kleine-König writes: > > On Thu, Sep 12, 2024 at 10:47:31PM +0200, Danilo Krummrich wrote: > >> On 9/12/24 7:11 PM, Devarsh Thakkar wrote: > >> > Modify license to include dual licensing as GPL-2.0-only OR MIT license > >> >

Re: [PATCH 5/5] drm/bridge: ti-dlpc3433: constify regmap_config

2024-09-13 Thread Neil Armstrong
On 08/09/2024 16:21, Krzysztof Kozlowski wrote: Mark local static 'struct regmap_config' as const for safer and more obvious code. Signed-off-by: Krzysztof Kozlowski --- drivers/gpu/drm/bridge/ti-dlpc3433.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/b

Re: [PATCH v2] drm/bridge: imx8mp-hdmi-tx: allow 0.5% margin with selected clock

2024-09-13 Thread Neil Armstrong
On 07/09/2024 07:54, Dominique Martinet wrote: From: Dominique Martinet This allows the hdmi driver to pick e.g. 64.8MHz instead of 65Mhz when we cannot output the exact frequency, enabling the imx8mp HDMI output to support more modes Tested-by: Adam Ford #imx8mp-beacon Reviewed-by: Frieder S

Re: [PATCH] drm/tidss: Add MIT license along with GPL-2.0

2024-09-13 Thread jyri . sarha
September 12, 2024 at 8:11 PM, "Devarsh Thakkar" mailto:devar...@ti.com?to=%22Devarsh%20Thakkar%22%20%3Cdevarsht%40ti.com%3E > wrote: > > Modify license to include dual licensing as GPL-2.0-only OR MIT license for > tidss display driver. This allows other operating system ecosystems such as > Ze

Re: [PATCH -next 1/3] drm/bridge: it6505: Enable module autoloading

2024-09-13 Thread neil . armstrong
On 02/09/2024 13:33, Liao Chen wrote: Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded based on the alias from of_device_id table. Signed-off-by: Liao Chen --- drivers/gpu/drm/bridge/ite-it6505.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/bridge/ite

Re: [PATCH 2/6] drm/bridge: imx8qm-ldb: Switch to RUNTIME_PM_OPS()

2024-09-13 Thread neil . armstrong
On 27/06/2024 01:07, Fabio Estevam wrote: From: Fabio Estevam Replace SET_RUNTIME_PM_OPS with its modern RUNTIME_PM_OPS() alternative. The combined usage of pm_ptr() and RUNTIME_PM_OPS() allows the compiler to evaluate if the runtime suspend/resume() functions are used at build time or are sim

Re: [PATCH 3/6] drm/bridge: imx8qxp-pixel-combiner: Switch to RUNTIME_PM_OPS()

2024-09-13 Thread neil . armstrong
On 27/06/2024 01:07, Fabio Estevam wrote: From: Fabio Estevam Replace SET_RUNTIME_PM_OPS with its modern RUNTIME_PM_OPS() alternative. The combined usage of pm_ptr() and RUNTIME_PM_OPS() allows the compiler to evaluate if the runtime suspend/resume() functions are used at build time or are sim

Re: [PATCH 4/6] drm/bridge: samsung-dsim: Switch to RUNTIME_PM_OPS()

2024-09-13 Thread neil . armstrong
On 27/06/2024 01:07, Fabio Estevam wrote: From: Fabio Estevam Replace SET_RUNTIME_PM_OPS with its modern RUNTIME_PM_OPS() alternative. The combined usage of pm_ptr() and RUNTIME_PM_OPS() allows the compiler to evaluate if the runtime suspend/resume() functions are used at build time or are sim

Re: [PATCH 5/6] drm/bridge: dw-hdmi-cec: Switch to SYSTEM_SLEEP_PM_OPS()

2024-09-13 Thread neil . armstrong
On 27/06/2024 01:07, Fabio Estevam wrote: From: Fabio Estevam Replace SET_SYSTEM_SLEEP_PM_OPS with its modern SYSTEM_SLEEP_PM_OPS() alternative. The combined usage of pm_ptr() and SYSTEM_SLEEP_PM_OPS() allows the compiler to evaluate if the runtime suspend/resume() functions are used at build

Re: [PATCH 6/6] drm/bridge: imx8qxp-ldb: Switch to RUNTIME_PM_OPS()

2024-09-13 Thread neil . armstrong
On 27/06/2024 01:07, Fabio Estevam wrote: From: Fabio Estevam Replace SET_RUNTIME_PM_OPS with its modern RUNTIME_PM_OPS() alternative. The combined usage of pm_ptr() and RUNTIME_PM_OPS() allows the compiler to evaluate if the runtime suspend/resume() functions are used at build time or are sim

Re: [PATCH 1/2] drm/bridge: dw-hdmi: Move vmalloc PCM buffer management into the driver

2024-09-13 Thread Neil Armstrong
On 07/08/2024 17:27, Takashi Iwai wrote: The dw-hdmi drm bridge driver is the only one who still uses the ALSA vmalloc helper API functions. A previous attempt to change the way of buffer management wasn't taken for this legacy stuff, as we had little chance for test and some risk of major break

Re: [PATCH] drm/bridge: nwl-dsi: Use vsync/hsync polarity from display mode

2024-09-13 Thread Neil Armstrong
On 14/08/2024 12:37, Esben Haabendal wrote: Using the correct bit helps. The documentation specifies bit 0 in both registers to be controlling polarity of dpi_vsync_input and dpi_hsync_input polarity. Bit 1 is reserved, and should therefore not be set. Tested with panel that requires active high

Re: [PATCH 1/6] drm/bridge: imx8mp-hdmi-tx: Switch to SYSTEM_SLEEP_PM_OPS()

2024-09-13 Thread neil . armstrong
On 27/06/2024 01:06, Fabio Estevam wrote: From: Fabio Estevam Replace SET_SYSTEM_SLEEP_PM_OPS with its modern SYSTEM_SLEEP_PM_OPS() alternative. The combined usage of pm_ptr() and SYSTEM_SLEEP_PM_OPS() allows the compiler to evaluate if the runtime suspend/resume() functions are used at build

Re: [PATCH v2 09/10] drm: bridge: dw_hdmi: Update EDID during hotplug processing

2024-09-13 Thread Neil Armstrong
On 08/09/2024 15:28, Jonas Karlman wrote: Update successfully read EDID during hotplug processing to ensure the connector diplay_info is always up-to-date. Signed-off-by: Jonas Karlman --- v2: No change --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 12 1 file changed, 12 inser

Re: [PATCH v2 06/10] drm: bridge: dw_hdmi: Remove previous_mode and mode_set

2024-09-13 Thread Neil Armstrong
On 08/09/2024 15:28, Jonas Karlman wrote: With the use of adjusted_mode directly from the crtc_state there is no longer a need to store a copy in previous_mode, remove it and the now unneeded mode_set ops. Signed-off-by: Jonas Karlman --- v2: No change --- drivers/gpu/drm/bridge/synopsys/dw-h

Re: [PATCH v2 04/10] drm: bridge: dw_hdmi: Use passed mode instead of stored previous_mode

2024-09-13 Thread Neil Armstrong
On 08/09/2024 15:28, Jonas Karlman wrote: Use the passed mode instead of mixing use of passed mode and the stored previous_mode. The passed mode is currenly always the previous_mode. Also fix a small typo and add a variable to help shorten a code line. Signed-off-by: Jonas Karlman --- v2: Upda

Re: [PATCH v2 03/10] drm: bridge: dw_hdmi: Call poweron/poweroff from atomic enable/disable

2024-09-13 Thread Neil Armstrong
On 08/09/2024 15:28, Jonas Karlman wrote: Change to only call poweron/poweroff from atomic_enable/atomic_disable ops instead of trying to be clever by keeping a bridge_is_on state and poweron/off in the hotplug irq handler. The bridge is already enabled/disabled depending on connection state wit

Re: [PATCH v2 05/10] drm: bridge: dw_hdmi: Fold poweron and setup functions

2024-09-13 Thread Neil Armstrong
On 08/09/2024 15:28, Jonas Karlman wrote: Fold the poweron and setup functions into one function and use the adjusted_mode directly from the new crtc_state to remove the need of storing previous_mode. Signed-off-by: Jonas Karlman --- v2: No change --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c

Re: [PATCH v3 0/3] Improve tc358767 debugging

2024-09-13 Thread Neil Armstrong
Hi, On Wed, 04 Sep 2024 14:05:42 +0200, Alexander Stein wrote: > this small series improves debugging the tc358767 driver by using > dev_err_probe for additional information (patch 1) and print IRQ > debug output only if hotplug status actually changed. > > Changes inv 3: > * Collected Robert's a

Re: [PATCH 1/6] drm/bridge: imx8mp-hdmi-tx: Switch to SYSTEM_SLEEP_PM_OPS()

2024-09-13 Thread Neil Armstrong
Hi, On Wed, 26 Jun 2024 20:06:59 -0300, Fabio Estevam wrote: > Replace SET_SYSTEM_SLEEP_PM_OPS with its modern SYSTEM_SLEEP_PM_OPS() > alternative. > > The combined usage of pm_ptr() and SYSTEM_SLEEP_PM_OPS() > allows the compiler to evaluate if the runtime suspend/resume() functions > are used a

Re: [PATCH v2] drm/bridge: imx8mp-hdmi-tx: allow 0.5% margin with selected clock

2024-09-13 Thread Neil Armstrong
Hi, On Sat, 07 Sep 2024 14:54:33 +0900, Dominique Martinet wrote: > This allows the hdmi driver to pick e.g. 64.8MHz instead of 65Mhz when we > cannot output the exact frequency, enabling the imx8mp HDMI output to > support more modes > > Thanks, Applied to https://gitlab.freedesktop.org/drm/mi

Re: [PATCH v3 1/2] drm/panic: Add ABGR2101010 support

2024-09-13 Thread Jocelyn Falempe
On 13/09/2024 09:22, Javier Martinez Canillas wrote: Jocelyn Falempe writes: Hello Jocelyn, Add support for ABGR2101010, used by the nouveau driver. Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/drm_panic.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/gpu/

Re: [PATCH][next] drm/nouveau: Avoid -Wflex-array-member-not-at-end warning

2024-09-13 Thread Gustavo A. R. Silva
Hi all, Friendly ping: who can take this, please? 🙂 Thanks -Gustavo On 21/08/24 22:16, Gustavo A. R. Silva wrote: Use the `DEFINE_RAW_FLEX()` helper for an on-stack definition of a flexible structure where the size of the flexible-array member is known at compile-time, and refactor the rest of

Re: [PATCH 3/5] drm/fsl-dcu: constify regmap_config

2024-09-13 Thread Neil Armstrong
On 08/09/2024 16:21, Krzysztof Kozlowski wrote: Mark local static 'struct regmap_config' as const for safer and more obvious code. Signed-off-by: Krzysztof Kozlowski --- drivers/gpu/drm/fsl-dcu/fsl_tcon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/fsl

Re: [PATCH] drm/tidss: Add MIT license along with GPL-2.0

2024-09-13 Thread Laurent Pinchart
Hi Devarsh, On Thu, Sep 12, 2024 at 10:41:42PM +0530, Devarsh Thakkar wrote: > Modify license to include dual licensing as GPL-2.0-only OR MIT license for > tidss display driver. This allows other operating system ecosystems such as > Zephyr and also the commercial firmwares to refer and derive co

Re: [PATCH 06/10] drm/ast: dp501: Avoid upcasting to struct ast_device

2024-09-13 Thread Thomas Zimmermann
Hi Am 12.09.24 um 15:48 schrieb Jocelyn Falempe: [...] --- a/drivers/gpu/drm/ast/ast_main.c +++ b/drivers/gpu/drm/ast/ast_main.c @@ -110,7 +110,7 @@ static void ast_detect_tx_chip(struct ast_device *ast, bool need_post)   ast->dp501_fw_addr = drmm_kzalloc(dev, 32*1024, GFP_KERNEL);

Re: [PATCH v7 1/2] dt-bindings: arm: mediatek: Add MT8186 Ponyta Chromebook

2024-09-13 Thread AngeloGioacchino Del Regno
Il 13/09/24 05:15, Jianeng Ceng ha scritto: Ponyta is a custom label Chromebook based on MT8186. It is a self-developed project of Huaqin and has no fixed OEM. Acked-by: Krzysztof Kozlowski Signed-off-by: Jianeng Ceng --- Changes in v5: - PATCH 1/2: Remove sku2147483647. - Link to v4:https://

[PATCH v2] drm/sti: avoid potential dereference of error pointers

2024-09-13 Thread Ma Ke
The return value of drm_atomic_get_crtc_state() needs to be checked. To avoid use of error pointer 'crtc_state' in case of the failure. Cc: sta...@vger.kernel.org Fixes: dd86dc2f9ae1 ("drm/sti: implement atomic_check for the planes") Signed-off-by: Ma Ke --- Changes in v2: - modified the Fixes ta

Re: [PATCH v7 2/2] arm64: dts: mediatek: Add MT8186 Ponyta Chromebooks

2024-09-13 Thread AngeloGioacchino Del Regno
Il 13/09/24 05:15, Jianeng Ceng ha scritto: MT8186 ponyta, known as huaqin custom label, is a MT8186 Ponyta is a Huaqin board based on the Corsola board design with the addition of (optional??) LTE connectivity through (usb? pcie? what?) integrated module. MT8186 based laptop. It is based on

Re: [PATCH] drm/panel: raydium-rm69380: transition to mipi_dsi wrapped functions

2024-09-13 Thread neil . armstrong
Hi, On 07/09/2024 16:01, Tejas Vipin wrote: Changes the raydium-rm69380 panel to use multi style functions for improved error handling. Signed-off-by: Tejas Vipin --- drivers/gpu/drm/panel/panel-raydium-rm69380.c | 95 ++- 1 file changed, 30 insertions(+), 65 deletions(-) di

Re: [PATCH] drm: panel: nt36523: use devm_mipi_dsi_* function to register and attach dsi

2024-09-13 Thread Neil Armstrong
On 04/09/2024 16:29, Jianhua Lu wrote: Switch to devm_mipi_dsi_* function, we don't need to detach and unregister dsi manually any more. Signed-off-by: Jianhua Lu --- drivers/gpu/drm/panel/panel-novatek-nt36523.c | 16 ++-- 1 file changed, 2 insertions(+), 14 deletions(-) diff -

[PATCH] drm/sti: avoid potential dereference of error pointers in sti_hqvdp_atomic_check

2024-09-13 Thread Ma Ke
The return value of drm_atomic_get_crtc_state() needs to be checked. To avoid use of error pointer 'crtc_state' in case of the failure. Cc: sta...@vger.kernel.org Fixes: dd86dc2f9ae1 ("drm/sti: implement atomic_check for the planes") Signed-off-by: Ma Ke --- drivers/gpu/drm/sti/sti_hqvdp.c | 3 +

Re: [PATCH v1 1/1] drm/panel: sony-acx565akm: Use %*ph to print small buffer

2024-09-13 Thread Neil Armstrong
On 11/09/2024 22:01, Andy Shevchenko wrote: Use %*ph format to print small buffer as hex string. Signed-off-by: Andy Shevchenko --- drivers/gpu/drm/panel/panel-sony-acx565akm.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-sony-acx565akm.c

Re: [PATCH v4 RESEND 0/9] Increase coverage on drm_framebuffer.c

2024-09-13 Thread Jani Nikula
On Fri, 13 Sep 2024, Maxime Ripard wrote: > On Fri, Sep 13, 2024 at 10:31:08AM GMT, Jani Nikula wrote: >> On Wed, 11 Sep 2024, Maxime Ripard wrote: >> > On Tue, 10 Sep 2024 21:15:25 -0300, Carlos Eduardo Gallo Filho wrote: >> >> This patchset includes new KUnit tests for 5 untested functions from

Re: [PATCH v2 2/4] dt-bindings: display: panel-lvds: Add compatible for Jenson BL-JT60050-01A

2024-09-13 Thread Neil Armstrong
Hi, On 28/08/2024 09:46, Frieder Schrempf wrote: From: Frieder Schrempf The Jenson BL-JT60050-01A is a 7" 1024x600 LVDS display. Signed-off-by: Frieder Schrempf Acked-by: Conor Dooley --- Changes for v2: * Add tag from Conor (thanks!) --- Documentation/devicetree/bindings/display/panel/pa

Re: [PATCH] drm: panel: nt36523: use devm_mipi_dsi_* function to register and attach dsi

2024-09-13 Thread Neil Armstrong
Hi, On Wed, 04 Sep 2024 22:29:07 +0800, Jianhua Lu wrote: > Switch to devm_mipi_dsi_* function, we don't need to detach and > unregister dsi manually any more. > > Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-next) [1/1] drm: panel: nt36523: use devm_mipi_ds

Re: [PATCH] drm/panel: khadas-ts050: make ts050[v2]_panel_data static

2024-09-13 Thread Neil Armstrong
Hi, On Sun, 08 Sep 2024 21:35:30 +0800, Min-Hua Chen wrote: > make ts050_panel_data and ts050v2_panel_data static because they > are only used in drivers/gpu/drm/panel/panel-khadas-ts050.c, > and fix the following sparse warnings: > > drivers/gpu/drm/panel/panel-khadas-ts050.c:620:32: > sparse: w

Re: [PATCH v1 1/1] drm/panel: sony-acx565akm: Use %*ph to print small buffer

2024-09-13 Thread Neil Armstrong
Hi, On Wed, 11 Sep 2024 23:01:25 +0300, Andy Shevchenko wrote: > Use %*ph format to print small buffer as hex string. > > Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-next) [1/1] drm/panel: sony-acx565akm: Use %*ph to print small buffer https://gitlab

Re: [PATCH v4 0/5] Support alpha blending in MTK display driver

2024-09-13 Thread AngeloGioacchino Del Regno
Il 13/09/24 07:40, Alper Nebi Yasak ha scritto: Hi, On 2024-09-13 05:56 +03:00, Jason-JH Lin (林睿祥) wrote: Hi Alper, I think that's a platform issue because it works find in my MT8188 platform, but I don't have any MT8173 platform. Can you help me test the fix patch in your MT8173 platform? I'

Re: [PATCH RESEND] drm/sti: avoid potential dereference of error pointers

2024-09-13 Thread Ma Ke
Alain Volmat wrote: > Hi, > > I probably went a bit fast on the commit message. It seems to me that > the Fixes line would be probably better with below one instead. > > Fixes: dd86dc2f9ae1 ("drm/sti: implement atomic_check for the planes") > > The same fix is actually necessary for all planes

Re: [PATCH v2 1/1] drm/i2c: tda998x: Make use of irq_get_trigger_type()

2024-09-13 Thread Andy Shevchenko
On Fri, Sep 13, 2024 at 02:11:56AM +0200, Vasileios Amoiridis wrote: > Convert irqd_get_trigger_type(irq_get_irq_data(irq)) cases to the more > simple irq_get_trigger_type(irq). LGTM, FWIW, Reviewed-by: Andy Shevchenko -- With Best Regards, Andy Shevchenko

RE: [EXT] Re: [PATCH v16 4/8] drm: bridge: Cadence: Add MHDP8501 DP/HDMI driver

2024-09-13 Thread Sandor Yu
> Subject: Re: [EXT] Re: [PATCH v16 4/8] drm: bridge: Cadence: Add MHDP8501 > DP/HDMI driver > > On Fri, Sep 06, 2024 at 02:50:08AM GMT, Sandor Yu wrote: > > > On Tue, Sep 03, 2024 at 06:07:25AM GMT, Sandor Yu wrote: > > > > > -Original Message- > > > > > From: dri-devel On > > > > > Beh

Re: [PATCH 7/7] dma-buf: rework the enable_signaling handling

2024-09-13 Thread Tvrtko Ursulin
On 11/09/2024 09:59, Christian König wrote: The enable_signaling callback is the only function the dma_fence objects calls with the fence lock held (the signaled callback might be called with the fence lock held as well, but that isn't guaranted). The background of that decision was to avoid r

Re: [PATCH][next] drm/nouveau: Avoid -Wflex-array-member-not-at-end warning

2024-09-13 Thread Danilo Krummrich
Hi, On 9/13/24 10:09 AM, Gustavo A. R. Silva wrote: Hi all, Friendly ping: who can take this, please? 🙂 Usually, that's me. But I thought you might want to send a v2 based on Kees' comments? - Danilo Thanks -Gustavo On 21/08/24 22:16, Gustavo A. R. Silva wrote: Use the `DEFINE_RAW_FLEX(

[PATCH v2 5/5] drm/msm/dp: Add DisplayPort controller for SA8775P

2024-09-13 Thread Soutrik Mukhopadhyay
The Qualcomm SA8775P platform comes with a DisplayPort controller with a different base offset than the previous SoCs, add support for this in the DisplayPort driver. Signed-off-by: Soutrik Mukhopadhyay --- v2: No change --- drivers/gpu/drm/msm/dp/dp_display.c | 7 +++ 1 file changed, 7 ins

[PATCH v2 3/5] phy: qcom: edp: Add support for eDP PHY on SA8775P

2024-09-13 Thread Soutrik Mukhopadhyay
Add support for eDP PHY v5 found on the Qualcomm SA8775P platform. Signed-off-by: Soutrik Mukhopadhyay --- v2: Fixed review comments from Dmitry - Reused edp_swing_hbr_rbr and edp_swing_hbr2_hbr3 for v5. --- drivers/phy/qualcomm/phy-qcom-edp.c | 33 + 1 file

[PATCH v2 4/5] dt-bindings: display: msm: dp-controller: document SA8775P compatible

2024-09-13 Thread Soutrik Mukhopadhyay
Add compatible string for the DisplayPort controller found on the Qualcomm SA8775P platform. Signed-off-by: Soutrik Mukhopadhyay --- v2: No change --- Documentation/devicetree/bindings/display/msm/dp-controller.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bi

[PATCH v2 1/5] dt-bindings: phy: Add eDP PHY compatible for sa8775p

2024-09-13 Thread Soutrik Mukhopadhyay
Add compatible string for the supported eDP PHY on sa8775p platform. Signed-off-by: Soutrik Mukhopadhyay --- v2: No change --- Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml b/

[PATCH v2 2/5] phy: qcom: edp: Introduce aux_cfg array for version specific aux settings

2024-09-13 Thread Soutrik Mukhopadhyay
In order to support different HW versions, introduce aux_cfg array to move v4 specific aux configuration settings. Signed-off-by: Soutrik Mukhopadhyay --- v2: Fixed review comments from Bjorn and Dmitry - Made aux_cfg array as const. --- drivers/phy/qualcomm/phy-qcom-edp.c | 37

[PATCH v2 0/5] Add support for DisplayPort on SA8775P platform

2024-09-13 Thread Soutrik Mukhopadhyay
This series adds support for the DisplayPort controller and eDP PHY v5 found on the Qualcomm SA8775P platform. --- v2: Fixed review comments from Dmitry and Bjorn - Made aux_cfg array as const. - Reused edp_swing_hbr_rbr and edp_swing_hbr2_hbr3 for v5. --- Soutrik Mukhopa

drm: GPU Scheduler maintainership

2024-09-13 Thread Philipp Stanner
Hi everyone, it seemed to me in recent weeks that the GPU Scheduler is not that actively maintained. At least I haven't seen Luben posting that much, and a trivial patch of mine [1] has been pending for a while now. We also didn't have that much discussion yet about looking deeper into the schedu

Re: drm: GPU Scheduler maintainership

2024-09-13 Thread Christian König
Am 13.09.24 um 12:49 schrieb Philipp Stanner: Hi everyone, it seemed to me in recent weeks that the GPU Scheduler is not that actively maintained. At least I haven't seen Luben posting that much, and a trivial patch of mine [1] has been pending for a while now. We also didn't have that much dis

Re: drm: GPU Scheduler maintainership

2024-09-13 Thread Christian König
Using Tvrtko's updated mail address. Am 13.09.24 um 12:55 schrieb Christian König: Am 13.09.24 um 12:49 schrieb Philipp Stanner: Hi everyone, it seemed to me in recent weeks that the GPU Scheduler is not that actively maintained. At least I haven't seen Luben posting that much, and a trivial

[PATCH] drm/panthor: Lock the VM resv before calling drm_gpuvm_bo_obtain_prealloc()

2024-09-13 Thread Boris Brezillon
drm_gpuvm_bo_obtain_prealloc() will call drm_gpuvm_bo_put() on our pre-allocated BO if the association exists. Given we only have one ref on preallocated_vm_bo, drm_gpuvm_bo_destroy() will be called immediately, and we have to hold the VM resv lock when calling this function. Fixes: 647810ec2476

Re: [PATCH v2 2/5] phy: qcom: edp: Introduce aux_cfg array for version specific aux settings

2024-09-13 Thread Dmitry Baryshkov
On Fri, 13 Sept 2024 at 13:38, Soutrik Mukhopadhyay wrote: > > In order to support different HW versions, introduce aux_cfg array > to move v4 specific aux configuration settings. > > Signed-off-by: Soutrik Mukhopadhyay > --- > v2: Fixed review comments from Bjorn and Dmitry > - Made aux_

Re: [PATCH v2 5/5] drm/msm/dp: Add DisplayPort controller for SA8775P

2024-09-13 Thread Dmitry Baryshkov
On Fri, 13 Sept 2024 at 13:38, Soutrik Mukhopadhyay wrote: > > The Qualcomm SA8775P platform comes with a DisplayPort controller > with a different base offset than the previous SoCs, > add support for this in the DisplayPort driver. > > Signed-off-by: Soutrik Mukhopadhyay > --- > v2: No change >

RE: [PATCH 3/8] drm/kmb: annotate set_test_mode_src_osc_freq_target_{low,hi}_bits() with __maybe_unused

2024-09-13 Thread Jani Nikula
On Tue, 10 Sep 2024, "Chrisanthus, Anitha" wrote: > Thanks for the patch. > > Acked-by: Anitha Chrisanthus Thanks, pushed to drm-misc-next. BR, Jani. -- Jani Nikula, Intel

Re: [PATCH 5/8] drm/imagination: annotate pvr_fw_version_packed() with __maybe_unused

2024-09-13 Thread Jani Nikula
On Tue, 10 Sep 2024, Matt Coster wrote: > On 10/09/2024 11:03, Jani Nikula wrote: >> Building with clang and and W=1 leads to warning about unused >> pvr_fw_version_packed(). Fix by annotating it with __maybe_unused. >> >> See also commit 6863f5643dd7 ("kbuild: allow Clang to find unused static >

Re: [PATCH v2 1/2] drm/sched: memset() 'job' in drm_sched_job_init()

2024-09-13 Thread Tvrtko Ursulin
Hi, On 28/08/2024 10:41, Philipp Stanner wrote: drm_sched_job_init() has no control over how users allocate struct drm_sched_job. Unfortunately, the function can also not set some struct members such as job->sched. job->sched usage from within looks like a bug. But not related to the memset

Re: [PATCH v3 1/2] drm/panic: Add ABGR2101010 support

2024-09-13 Thread Javier Martinez Canillas
Jocelyn Falempe writes: > On 13/09/2024 09:22, Javier Martinez Canillas wrote: >> Jocelyn Falempe writes: >> >> Hello Jocelyn, >> >>> Add support for ABGR2101010, used by the nouveau driver. >>> >>> Signed-off-by: Jocelyn Falempe >>> --- >>> drivers/gpu/drm/drm_panic.c | 10 ++ >>>

Re: [PATCH v1] drm/ci: enable lockdep detection

2024-09-13 Thread Vignesh Raman
Hi Rob, Helen, On 14/08/24 23:11, Rob Clark wrote: On Wed, Aug 14, 2024 at 2:42 AM Vignesh Raman wrote: Hi Helen, On 14/08/24 01:44, Helen Mae Koike Fornazier wrote: On Tue, 13 Aug 2024 02:26:48 -0300 Vignesh Raman wrote --- > Hi Helen, > > On 13/08/24 01:47, Helen Mae K

Re: [PATCH 8/8] drm/sched: Further optimise drm_sched_entity_push_job

2024-09-13 Thread Philipp Stanner
On Wed, 2024-09-11 at 13:22 +0100, Tvrtko Ursulin wrote: > > On 10/09/2024 11:25, Philipp Stanner wrote: > > On Mon, 2024-09-09 at 18:19 +0100, Tvrtko Ursulin wrote: > > > From: Tvrtko Ursulin > > > > > > Having removed one re-lock cycle on the entity->lock in a patch > > > titled > > > "drm/sch

Re: [PATCH v2 2/2] drm/sched: warn about drm_sched_job_init()'s partial init

2024-09-13 Thread Tvrtko Ursulin
On 28/08/2024 10:41, Philipp Stanner wrote: drm_sched_job_init()'s name suggests that after the function succeeded, parameter "job" will be fully initialized. This is not the case; some members are only later set, notably "job->sched" by drm_sched_job_arm(). Document that drm_sched_job_init()

Re: [PATCH 1/3] drm: add DRM_SET_NAME ioctl

2024-09-13 Thread Christian König
Am 13.09.24 um 14:17 schrieb Pierre-Eric Pelloux-Prayer: Hi Tvrtko, Le 12/09/2024 à 10:13, Tvrtko Ursulin a écrit : On 11/09/2024 15:58, Pierre-Eric Pelloux-Prayer wrote: Giving the opportunity to userspace to associate a free-form name with a drm_file struct is helpful for tracking and debug

Re: [PATCH 3/3] drm/amdgpu: use drm_file name

2024-09-13 Thread Pierre-Eric Pelloux-Prayer
Hi, Le 12/09/2024 à 10:24, Tvrtko Ursulin a écrit : On 11/09/2024 15:58, Pierre-Eric Pelloux-Prayer wrote: In debugfs gem_info/vm_info files, timeout handler and page fault reports. This information is useful with the virtio/native-context driver: this allows the guest applications identifier

Re: [PATCH 1/3] drm: add DRM_SET_NAME ioctl

2024-09-13 Thread Pierre-Eric Pelloux-Prayer
Hi Tvrtko, Le 12/09/2024 à 10:13, Tvrtko Ursulin a écrit : On 11/09/2024 15:58, Pierre-Eric Pelloux-Prayer wrote: Giving the opportunity to userspace to associate a free-form name with a drm_file struct is helpful for tracking and debugging. This is similar to the existing DMA_BUF_SET_NAME io

Re: [PATCH v2 1/2] drm/sched: memset() 'job' in drm_sched_job_init()

2024-09-13 Thread Philipp Stanner
On Fri, 2024-09-13 at 12:56 +0100, Tvrtko Ursulin wrote: > > Hi, > > On 28/08/2024 10:41, Philipp Stanner wrote: > > drm_sched_job_init() has no control over how users allocate struct > > drm_sched_job. Unfortunately, the function can also not set some > > struct > > members such as job->sched. >

Re: [PATCH v2 3/5] phy: qcom: edp: Add support for eDP PHY on SA8775P

2024-09-13 Thread Dmitry Baryshkov
On Fri, Sep 13, 2024 at 04:07:53PM GMT, Soutrik Mukhopadhyay wrote: > Add support for eDP PHY v5 found on the Qualcomm SA8775P platform. > > Signed-off-by: Soutrik Mukhopadhyay > --- > v2: Fixed review comments from Dmitry > - Reused edp_swing_hbr_rbr and edp_swing_hbr2_hbr3 for v5. > > --

[PATCH v6 0/5] Support fdinfo runtime and memory stats on Panthor

2024-09-13 Thread Adrián Larumbe
This patch series enables userspace utilities like gputop and nvtop to query a render context's fdinfo file and figure out rates of engine and memory utilisation. Previous discussion can be found at https://lore.kernel.org/dri-devel/20240903202541.430225-1-adrian.laru...@collabora.com/ Changelog:

[PATCH v6 1/5] drm/panthor: introduce job cycle and timestamp accounting

2024-09-13 Thread Adrián Larumbe
Enable calculations of job submission times in clock cycles and wall time. This is done by expanding the boilerplate command stream when running a job to include instructions that compute said times right before and after a user CS. A separate kernel BO is created per queue to store those values.

[PATCH v6 2/5] drm/panthor: record current and maximum device clock frequencies

2024-09-13 Thread Adrián Larumbe
In order to support UM in calculating rates of GPU utilisation, the current operating and maximum GPU clock frequencies must be recorded during device initialisation, and also during OPP state transitions. Signed-off-by: Adrián Larumbe --- drivers/gpu/drm/panthor/panthor_devfreq.c | 18 +

[PATCH v6 3/5] drm/panthor: add DRM fdinfo support

2024-09-13 Thread Adrián Larumbe
Drawing from the FW-calculated values in a previous commit, we can increase the numbers for an open file by collecting them from finished jobs when updating their group synchronisation objects. Display of fdinfo key-value pairs is governed by a bitmask that is by default unset in the present commi

[PATCH v6 4/5] drm/panthor: enable fdinfo for memory stats

2024-09-13 Thread Adrián Larumbe
Implement drm object's status callback. Also, we consider a PRIME imported BO to be resident if its matching dma_buf has an open attachment, which means its backing storage had already been allocated. Signed-off-by: Adrián Larumbe Reviewed-by: Steven Price Reviewed-by: Liviu Dudau Reviewed-by:

[PATCH v6 5/5] drm/panthor: add sysfs knob for enabling job profiling

2024-09-13 Thread Adrián Larumbe
This commit introduces a DRM device sysfs attribute that lets UM control the job accounting status in the device. The knob variable had been brought in as part of a previous commit, but now we're able to fix it manually. As sysfs files are part of a driver's uAPI, describe its legitimate input val

Re: [PATCH v2 1/2] drm/sched: memset() 'job' in drm_sched_job_init()

2024-09-13 Thread Tvrtko Ursulin
On 13/09/2024 13:30, Philipp Stanner wrote: On Fri, 2024-09-13 at 12:56 +0100, Tvrtko Ursulin wrote: Hi, On 28/08/2024 10:41, Philipp Stanner wrote: drm_sched_job_init() has no control over how users allocate struct drm_sched_job. Unfortunately, the function can also not set some struct mem

[pull] amdgpu, amdkfd, drm amd-drm-next-6.12

2024-09-13 Thread Alex Deucher
Hi Dave, Simona, A few fixes for 6.12 and the drm dma-buf race fixes from Al Viro. The following changes since commit 7a199557643e993d4e7357860624b8aa5d8f4340: Revert "drm/amdgpu: align pp_power_profile_mode with kernel docs" (2024-09-05 14:27:41 -0400) are available in the Git repository at

Re: [PATCH 1/3] drm: add DRM_SET_NAME ioctl

2024-09-13 Thread Tvrtko Ursulin
On 13/09/2024 13:17, Pierre-Eric Pelloux-Prayer wrote: Hi Tvrtko, Le 12/09/2024 à 10:13, Tvrtko Ursulin a écrit : On 11/09/2024 15:58, Pierre-Eric Pelloux-Prayer wrote: Giving the opportunity to userspace to associate a free-form name with a drm_file struct is helpful for tracking and debug

Re: [PATCH] drm/panthor: Lock the VM resv before calling drm_gpuvm_bo_obtain_prealloc()

2024-09-13 Thread Liviu Dudau
On Fri, Sep 13, 2024 at 01:27:22PM +0200, Boris Brezillon wrote: > drm_gpuvm_bo_obtain_prealloc() will call drm_gpuvm_bo_put() on our > pre-allocated BO if the association exists. Given we > only have one ref on preallocated_vm_bo, drm_gpuvm_bo_destroy() will > be called immediately, and we have t

Re: [PATCH v6 2/5] drm/panthor: record current and maximum device clock frequencies

2024-09-13 Thread Boris Brezillon
On Fri, 13 Sep 2024 13:42:10 +0100 Adrián Larumbe wrote: > In order to support UM in calculating rates of GPU utilisation, the current > operating and maximum GPU clock frequencies must be recorded during device > initialisation, and also during OPP state transitions. > > Signed-off-by: Adrián L

Re: [PATCH v6 3/5] drm/panthor: add DRM fdinfo support

2024-09-13 Thread Boris Brezillon
On Fri, 13 Sep 2024 13:42:11 +0100 Adrián Larumbe wrote: > Drawing from the FW-calculated values in a previous commit, we can increase > the numbers for an open file by collecting them from finished jobs when > updating their group synchronisation objects. > > Display of fdinfo key-value pairs i

Re: [PATCH v6 5/5] drm/panthor: add sysfs knob for enabling job profiling

2024-09-13 Thread Boris Brezillon
On Fri, 13 Sep 2024 13:42:13 +0100 Adrián Larumbe wrote: > This commit introduces a DRM device sysfs attribute that lets UM control > the job accounting status in the device. The knob variable had been brought > in as part of a previous commit, but now we're able to fix it manually. > > As sysfs

Re: [PATCH] drm/panthor: Lock the VM resv before calling drm_gpuvm_bo_obtain_prealloc()

2024-09-13 Thread Steven Price
On 13/09/2024 12:27, Boris Brezillon wrote: > drm_gpuvm_bo_obtain_prealloc() will call drm_gpuvm_bo_put() on our > pre-allocated BO if the association exists. Given we > only have one ref on preallocated_vm_bo, drm_gpuvm_bo_destroy() will > be called immediately, and we have to hold the VM resv lo

Re: [PATCH v7 0/2] arm64: dts: mediatek: Add MT8186 Ponyta

2024-09-13 Thread Rob Herring (Arm)
On Fri, 13 Sep 2024 11:15:03 +0800, Jianeng Ceng wrote: > This is v7 of the MT8186 Chromebook device tree series. > --- > Changes in v7: > - PATCH 2/2: Remove prototype sku. > - PATCH 2/2: Disable the other trackpad to enable one of them. > - Link to > v5:https://lore.kernel.org/all/202409130155

[PATCH next] drm/tegra: Fix NULL vs IS_ERR() check in probe()

2024-09-13 Thread Dan Carpenter
The iommu_paging_domain_alloc() function doesn't return NULL pointers, it returns error pointers. Update the check to match. Fixes: 45c690aea8ee ("drm/tegra: Use iommu_paging_domain_alloc()") Signed-off-by: Dan Carpenter --- drivers/gpu/drm/tegra/drm.c | 4 ++-- 1 file changed, 2 insertions(+)

Re: [PATCH v3 04/23] dt-bindings: mfd: add maxim,max77705

2024-09-13 Thread Dzmitry Sankouski
чт, 20 июн. 2024 г. в 18:46, Krzysztof Kozlowski : > > On 18/06/2024 15:59, Dzmitry Sankouski wrote: > > maxim,max77705 is MAX77705 pmic binding part > > > > Signed-off-by: Dzmitry Sankouski > > --- > > .../devicetree/bindings/mfd/maxim,max77705.yaml| 112 > > + > > Your p

[PATCH] drm/i915/gt: Fixed an typo

2024-09-13 Thread Zhang He
column header should be GPU, not CPU Signed-off-by: Zhang He --- drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c b/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c index 8d08b38874ef..b6

Re: [PATCH 8/8] drm/sched: Further optimise drm_sched_entity_push_job

2024-09-13 Thread Tvrtko Ursulin
On 10/09/2024 16:03, Christian König wrote: Am 10.09.24 um 11:46 schrieb Tvrtko Ursulin: On 10/09/2024 10:08, Christian König wrote: Am 09.09.24 um 19:19 schrieb Tvrtko Ursulin: From: Tvrtko Ursulin Having removed one re-lock cycle on the entity->lock in a patch titled "drm/sched: Optimis

  1   2   >