[PATCH v3 2/3] drm/amdgpu: Add optional explicit sync fences for GEM operations.

2024-08-19 Thread Friedrich Vock
From: Tatsuyuki Ishi In Vulkan, it is the application's responsibility to perform adequate synchronization before a sparse unmap, replace or BO destroy operation. Until now, the kernel applied the same rule as implicitly-synchronized APIs like OpenGL, which with per-VM BOs made page table updates

[PATCH v3 3/3] drm/amdgpu: Bump amdgpu driver version.

2024-08-19 Thread Friedrich Vock
From: Tatsuyuki Ishi For detection of the new explicit sync functionality without having to try the ioctl. Signed-off-by: Tatsuyuki Ishi --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/

[PATCH v3 0/3] drm/amdgpu: Explicit sync for GEM VA operations

2024-08-19 Thread Friedrich Vock
In Vulkan, it is the application's responsibility to perform adequate synchronization before a sparse unmap, replace or BO destroy operation. This adds an option to AMDGPU_VA_OPs to disable redundant implicit sync that happens on sparse unmap or replace operations. This has seen a significant impr

[PATCH v3 1/3] drm/amdgpu: Don't implicit sync PRT maps.

2024-08-19 Thread Friedrich Vock
From: Tatsuyuki Ishi These are considered map operations rather than unmap, and there is no point of doing implicit synchronization here. Signed-off-by: Tatsuyuki Ishi --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm

Re: Build regressions/improvements in v6.11-rc4

2024-08-19 Thread Geert Uytterhoeven
On Mon, 19 Aug 2024, Geert Uytterhoeven wrote: JFYI, when comparing v6.11-rc4[1] to v6.11-rc3[3], the summaries are: - build errors: +6/-4 + /kisskb/src/arch/sparc/vdso/vdso32/../vclock_gettime.c: error: no previous prototype for '__vdso_clock_gettime' [-Werror=missing-prototypes]: => 254:

Re: [PATCH] fix member variable description warnings while building docs

2024-08-19 Thread Jani Nikula
On Sun, 18 Aug 2024, abid-sayyad wrote: > Fix the following warnings while building the docs :- > > ./include/linux/jbd2.h:1303: warning: Function parameter or struct member > 'j_transaction_overhead_buffers' not described in 'journal_s' > ./include/linux/jbd2.h:1303: warning: Excess

Re: [PATCH v3 06/19] dt-bindings: display: imx: Add i.MX8qxp Display Controller command sequencer

2024-08-19 Thread Liu Ying
On 08/17/2024, Rob Herring wrote: > On Wed, Jul 24, 2024 at 05:29:37PM +0800, Liu Ying wrote: >> i.MX8qxp Display Controller contains a command sequencer is designed to >> autonomously process command lists. >> >> Signed-off-by: Liu Ying >> --- >> v3: >> * New patch. (Rob) >> >> .../imx/fsl,imx8q

Re: [PATCH v8 0/3] drm/mediatek: Add support for OF graphs

2024-08-19 Thread Michael Walle
Hi, On Thu Jul 4, 2024 at 10:29 AM CEST, AngeloGioacchino Del Regno wrote: > Il 19/06/24 12:56, AngeloGioacchino Del Regno ha scritto: > > Il 18/06/24 12:17, AngeloGioacchino Del Regno ha scritto: > >> Changes in v8: > >>   - Rebased on next-20240617 > >>   - Changed to allow probing a VDO with no

Re: [PATCH v4 1/4] drm/panthor: introduce job cycle and timestamp accounting

2024-08-19 Thread Steven Price
Hi Adrián, On 31/07/2024 13:41, Adrián Larumbe wrote: > Hi Steven, thanks for the remarks. > > On 19.07.2024 15:14, Steven Price wrote: >> On 16/07/2024 21:11, Adrián Larumbe wrote: >>> Enable calculations of job submission times in clock cycles and wall >>> time. This is done by expanding the bo

RE: [PATCH] fix member variable description warnings while building docs

2024-08-19 Thread Golani, Mitulkumar Ajitkumar
Hi @abid-sayyad > -Original Message- > From: abid-sayyad > Sent: Sunday, August 18, 2024 4:56 PM > To: airl...@gmail.com > Cc: dan...@ffwll.ch; dmitry.barysh...@linaro.org; mrip...@kernel.org; > Nautiyal, Ankit K ; Nikula, Jani > ; Deak, Imre ; Golani, > Mitulkumar Ajitkumar ; > quic_abhi

[PATCH v3 0/2] drm/panfrost: Wire cycle counters and timestamp info to userspace

2024-08-19 Thread Mary Guillemard
Mali has hardware cycle counters and GPU timestamps available for profiling. This patch series adds support for cycle counters propagation and also new timestamp info parameters. Those new changes to the uAPI will be used in Mesa to implement timestamp queries for OpenGL and Vulkan. The Mesa MR

[PATCH v3 1/2] drm/panfrost: Add SYSTEM_TIMESTAMP and SYSTEM_TIMESTAMP_FREQUENCY parameters

2024-08-19 Thread Mary Guillemard
Expose system timestamp and frequency supported by the GPU. Mali uses an external timer as GPU system time. On ARM, this is wired to the generic arch timer so we wire cntfrq_el0 as device frequency. This new uAPI will be used in Mesa to implement timestamp queries and VK_KHR_calibrated_timestamps

[PATCH v3 2/2] drm/panfrost: Add cycle counter job requirement

2024-08-19 Thread Mary Guillemard
Extend the uAPI with a new job requirement flag for cycle counters. This requirement is used by userland to indicate that a job requires cycle counters or system timestamp to be propagated. (for use with write value timestamp jobs) We cannot enable cycle counters unconditionally as this would resu

Re: [PATCH] video/aperture: match the pci device when calling sysfb_disable()

2024-08-19 Thread Thomas Zimmermann
Hi Am 16.08.24 um 22:57 schrieb Alex Deucher: On Mon, Aug 12, 2024 at 8:10 AM Thomas Zimmermann wrote: Hi Am 10.08.24 um 13:44 schrieb kernel test robot: Hi Alex, kernel test robot noticed the following build errors: [auto build test ERROR on drm-misc/drm-misc-next] [also build test ERROR

Re: [PATCH v8 2/6] drm/ttm/pool: Provide a helper to shrink pages

2024-08-19 Thread Thomas Hellström
Hi, Matt. On Fri, 2024-08-16 at 14:10 +, Matthew Brost wrote: > On Fri, Aug 16, 2024 at 03:37:13PM +0200, Thomas Hellström wrote: > > Provide a helper to shrink ttm_tt page-vectors on a per-page > > basis. A ttm_backup backend could then in theory get away with > > allocating a single temporar

Re: [PATCH v3 4/5] drm/sched: Use drm sched lockdep map for submit_wq

2024-08-19 Thread Ghimiray, Himal Prasad
On 14-08-2024 00:46, Matthew Brost wrote: On Mon, Aug 12, 2024 at 11:05:31AM +0530, Ghimiray, Himal Prasad wrote: On 10-08-2024 03:58, Matthew Brost wrote: Avoid leaking a lockdep map on each drm sched creation and destruction by using a single lockdep map for all drm sched allocated submi

Re: [PATCH 03/12] drm/edid: constify argument of drm_edid_is_valid()

2024-08-19 Thread Jani Nikula
On Sun, 18 Aug 2024, Thomas Weißschuh wrote: > drm_edid_is_valid() does not modify its argument, so mark it as const. That's not true. BR, Jani. > > Signed-off-by: Thomas Weißschuh > --- > drivers/gpu/drm/drm_edid.c | 2 +- > include/drm/drm_edid.h | 2 +- > 2 files changed, 2 insertions(

Re: [PATCH] drm/radeon/evergreen_cs: fix int overflow errors in cs track offsets

2024-08-19 Thread Christian König
Am 05.08.24 um 09:34 schrieb Nikita Zhandarovich: On 7/30/24 23:56, Christian König wrote: Am 30.07.24 um 19:36 schrieb Nikita Zhandarovich: On 7/29/24 11:12, Christian König wrote: Am 29.07.24 um 20:04 schrieb Christian König: Am 29.07.24 um 19:26 schrieb Nikita Zhandarovich: Hi, On 7/29/

Re: [PATCH 09/12] drm/amd/display: Switch amdgpu_dm_connector to struct drm_edid

2024-08-19 Thread Jani Nikula
On Sun, 18 Aug 2024, Thomas Weißschuh wrote: > "struct drm_edid" is the safe and recommended alternative to "struct edid". > > Rename the member to make sure that no usage sites are missed, > as "struct drm_edid" has some restrictions, for example it can not be > used with kfree(). > > Signed-off-

[PATCH v9 0/6] TTM shrinker helpers and xe buffer object shrinker

2024-08-19 Thread Thomas Hellström
This series implements TTM shrinker / eviction helpers and an xe bo shrinker. It builds on a previous series, *and obsoletes that one*. https://lore.kernel.org/linux-mm/b7491378-defd-4f1c-31e2-29e4c77e2...@amd.com/T/ Where the comment about layering https://lore.kernel.org/linux-mm/b7491378-defd-

[PATCH v9 1/6] drm/ttm: Add a virtual base class for graphics memory backup

2024-08-19 Thread Thomas Hellström
Initially intended for experimenting with different backup solutions (shmem vs direct swap cache insertion), abstract the backup destination using a virtual base class. Also provide a sample implementation for shmem. While when settling on a preferred backup solution, one could perhaps skip the a

[PATCH v9 2/6] drm/ttm/pool: Provide a helper to shrink pages

2024-08-19 Thread Thomas Hellström
Provide a helper to shrink ttm_tt page-vectors on a per-page basis. A ttm_backup backend could then in theory get away with allocating a single temporary page for each struct ttm_tt. This is accomplished by splitting larger pages before trying to back them up. In the future we could allow ttm_bac

[PATCH v9 3/6] drm/ttm: Use fault-injection to test error paths

2024-08-19 Thread Thomas Hellström
Use fault-injection to test partial TTM swapout and interrupted swapin. Return -EINTR for swapin to test the callers ability to handle and restart the swapin, and on swapout perform a partial swapout to test that the swapin and release_shrunken functionality. v8: - Use the core fault-injection sys

[PATCH v9 4/6] drm/ttm: Add a shrinker helper and export the LRU walker for driver use

2024-08-19 Thread Thomas Hellström
Following the design direction communicated here: https://lore.kernel.org/linux-mm/b7491378-defd-4f1c-31e2-29e4c77e2...@amd.com/T/#ma918844aa8a6efe8768fdcda0c6590d5c93850c9 Export the LRU walker for driver shrinker use and add a bo shrinker helper for initial use by the xe driver. v8: - Split ou

[PATCH v9 5/6] drm/xe: Add a shrinker for xe bos

2024-08-19 Thread Thomas Hellström
Rather than relying on the TTM watermark accounting add a shrinker for xe_bos in TT or system memory. Leverage the newly added TTM per-page shrinking and shmem backup support. Although xe doesn't fully support WONTNEED (purgeable) bos yet, introduce and add shrinker support for purgeable ttm_tts.

[PATCH v9 6/6] drm/xe: Increase the XE_PL_TT watermark

2024-08-19 Thread Thomas Hellström
The XE_PL_TT watermark was set to 50% of system memory. The idea behind that was unclear since the net effect is that TT memory will be evicted to TTM_PL_SYSTEM memory if that watermark is exceeded, requiring PPGTT rebinds and dma remapping. But there is no similar watermark for TTM_PL_1SYSTEM memo

Re: [PATCH 10/12] drm/edid: add a helper to compare two EDIDs

2024-08-19 Thread Jani Nikula
On Sun, 18 Aug 2024, Thomas Weißschuh wrote: > As struct drm_edid is opaque, drivers can't directly memcmp() the > contained data. Add a helper to provide this functionality. I'm not sure why drivers would need to compare EDIDs. The only user was added in commit eb815442e840 ("drm/amd/display: d

Re: [PATCH] drm/radeon: Switch radeon_connector to struct drm_edid

2024-08-19 Thread Jani Nikula
On Sun, 18 Aug 2024, Thomas Weißschuh wrote: > "struct drm_edid" is the safe and recommended alternative to "struct edid". > > Rename the member to make sure that no usage sites are missed, > as "struct drm_edid" has some restrictions, for example it can not be > used with kfree(). > > Signed-off-

Re: [82/86] drm/i915: Move custom hotplug code into separate callback

2024-08-19 Thread Sui Jingfeng
Hi, Thomas I love your patch, yet ... On 2024/8/16 20:23, Thomas Zimmermann wrote: i915's fbdev contains additional code for hotplugging a display that cannot be ported to the common fbdev client. Introduce the callback struct drm_fb_helper.fb_hotplug and implement it for i915. The fbdev help

Re: [68/86] drm/loongson: Run DRM default client setup

2024-08-19 Thread Sui Jingfeng
Hi, On 2024/8/16 20:23, Thomas Zimmermann wrote: Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. The loongson driver specifies a preferred color mode of 32. As this is th

[PATCH] drm/sti: avoid potential dereference of error pointers

2024-08-19 Thread Ma Ke
The return value of drm_atomic_get_crtc_state() needs to be checked. To avoid use of error pointer 'crtc_state' in case of the failure. Cc: sta...@vger.kernel.org Fixes: dec92020671c ("drm: Use the state pointer directly in planes atomic_check") Signed-off-by: Ma Ke --- drivers/gpu/drm/sti/sti_

Re: [PATCH v3 02/11] drm/ast: Add struct ast_connector

2024-08-19 Thread Jocelyn Falempe
On 15/08/2024 17:18, Thomas Zimmermann wrote: Add struct ast_connector to track a connector's physical status. With the upcoming BMC support, the physical status can be different from the reported status. Thanks for this, as we fake the connector to be always connected with BMC, it has to know

RE: [PATCH 35/86] drm/renesas/rz-du: Run DRM default client setup

2024-08-19 Thread Biju Das
Hi Thomas Zimmermann, > -Original Message- > From: Thomas Zimmermann > Sent: Friday, August 16, 2024 1:23 PM > Subject: [PATCH 35/86] drm/renesas/rz-du: Run DRM default client setup > > Call drm_client_setup() to run the kernel's default client setup for DRM. Set > fbdev_probe in struct

Re: [PATCH v3 05/11] drm/ast: astdp: Simplify power management when detecting display

2024-08-19 Thread Jocelyn Falempe
On 15/08/2024 17:18, Thomas Zimmermann wrote: Remove the CRTC handling in the ASTDP detect_ctx helper and enable power while the detecting the display. Unconditionally wait a few milliseconds after switching power. Simplifies the code and makes it more robust. Thanks, it looks good to me. Revi

[RESEND PATCH] drm/xe/oa: Use vma_pages() helper function in xe_oa_mmap()

2024-08-19 Thread Thorsten Blum
Use the vma_pages() helper function and remove the following Coccinelle/coccicheck warning reported by vma_pages.cocci: WARNING: Consider using vma_pages helper on vma Reviewed-by: Ashutosh Dixit Signed-off-by: Thorsten Blum --- drivers/gpu/drm/xe/xe_oa.c | 3 +-- 1 file changed, 1 insertion

Re: [PATCH] drm/mediatek: Fix missing configuration flags in mtk_crtc_ddp_config()

2024-08-19 Thread 林睿祥

Re: [PATCH v4 1/4] drm/panthor: introduce job cycle and timestamp accounting

2024-08-19 Thread Boris Brezillon
Hi, On Mon, 19 Aug 2024 08:48:24 +0100 Steven Price wrote: > Hi Adrián, > > On 31/07/2024 13:41, Adrián Larumbe wrote: > > Hi Steven, thanks for the remarks. > > > > On 19.07.2024 15:14, Steven Price wrote: > >> On 16/07/2024 21:11, Adrián Larumbe wrote: > >>> Enable calculations of job su

Re: [PATCH v1] misc: fastrpc: Trigger a panic using BUG_ON in device release

2024-08-19 Thread Caleb Connolly
Hi Abishek, On 30/07/2024 09:09, Abhishek Singh wrote: The user process on ARM closes the device node while closing the session, triggers a remote call to terminate the PD running on the DSP. If the DSP is in an unstable state and cannot process the remote request from the HLOS, glink fails to d

Re: [PATCH 4/7] drm/ttm: move LRU walk defines into new internal header

2024-08-19 Thread Christian König
Am 06.08.24 um 10:29 schrieb Thomas Hellström: Hi, Christian. On Thu, 2024-07-11 at 14:01 +0200, Christian König wrote: Am 10.07.24 um 20:19 schrieb Matthew Brost: On Wed, Jul 10, 2024 at 02:42:58PM +0200, Christian König wrote: That is something drivers really shouldn't mess with. Thomas u

Re: [PATCH v3] misc: fastrpc: Add support for multiple PD from one process

2024-08-19 Thread Caleb Connolly
Hi Ekansh, On 08/08/2024 12:42, Ekansh Gupta wrote: Memory intensive applications(which requires more tha 4GB) that wants to offload tasks to DSP might have to split the tasks to multiple user PD to make the resources available. For every call to DSP, fastrpc driver passes the process tgid whic

Re: [PATCH v6 2/2] drm/xe/lnl: Offload system clear page activity to GPU

2024-08-19 Thread Matthew Auld
On 16/08/2024 14:51, Nirmoy Das wrote: On LNL because of flat CCS, driver creates migrates job to clear CCS meta data. Extend that to also clear system pages using GPU. Inform TTM to allocate pages without __GFP_ZERO to avoid double page clearing by clearing out TTM_TT_FLAG_ZERO_ALLOC flag and se

Re: [PATCH v2 1/2] dt-bindings: mtd: nuvoton,ma35d1-nand: add new bindings

2024-08-19 Thread Krzysztof Kozlowski
On Mon, Aug 19, 2024 at 09:20:36AM +, Hui-Ping Chen wrote: > Add dt-bindings for the Nuvoton MA35 SoC NAND Controller. > > Signed-off-by: Hui-Ping Chen > --- > .../bindings/mtd/nuvoton,ma35d1-nand.yaml | 93 +++ > 1 file changed, 93 insertions(+) > create mode 100644 >

Re: [PATCH v2 2/2] mtd: rawnand: nuvoton: add new driver for the Nuvoton MA35 SoC

2024-08-19 Thread Krzysztof Kozlowski
On Mon, Aug 19, 2024 at 09:20:37AM +, Hui-Ping Chen wrote: > Nuvoton MA35 SoCs NAND Flash Interface Controller > supports 2KB, 4KB and 8KB page size, and up to 8-bit, > 12-bit, and 24-bit hardware ECC calculation circuit > to protect data communication. > > Signed-off-by: Hui-Ping Chen ... >

Re: [PATCH v3 0/3] drm/amdgpu: Explicit sync for GEM VA operations

2024-08-19 Thread Christian König
Am 19.08.24 um 09:21 schrieb Friedrich Vock: In Vulkan, it is the application's responsibility to perform adequate synchronization before a sparse unmap, replace or BO destroy operation. This adds an option to AMDGPU_VA_OPs to disable redundant implicit sync that happens on sparse unmap or replac

[PATCH v3] drm/panthor: Add DEV_QUERY_TIMESTAMP_INFO dev query

2024-08-19 Thread Mary Guillemard
Expose timestamp information supported by the GPU with a new device query. Mali uses an external timer as GPU system time. On ARM, this is wired to the generic arch timer so we wire cntfrq_el0 as device frequency. This new uAPI will be used in Mesa to implement timestamp queries and VK_KHR_calibr

[PATCH] drm/i915/gt: Continue creating engine sysfs files even after a failure

2024-08-19 Thread Andi Shyti
The i915 driver generates sysfs entries for each engine of the GPU in /sys/class/drm/cardX/engines/. The process is straightforward: we loop over the UABI engines and for each one, we: - Create the object. - Create basic files. - If the engine supports timeslicing, create timeslice duration fi

Re: [PATCH] drm/bridge: ti-sn65dsi83: use dev_err_probe when failing to get panel bridge

2024-08-19 Thread Luca Ceresoli
Hello Andi, thanks for your additional comments. On Tue, 13 Aug 2024 16:32:50 +0200 Andi Shyti wrote: > Hi Luca, > > On Tue, Aug 13, 2024 at 10:16:43AM +0200, Luca Ceresoli wrote: > > On Thu, 8 Aug 2024 11:35:23 +0100 > > Andi Shyti wrote: > > > On Thu, Aug 08, 2024 at 12:26:14PM +0200, Luc

Re: [PATCH 4/7] drm/ttm: move LRU walk defines into new internal header

2024-08-19 Thread Thomas Hellström
Hi, Christian, On Mon, 2024-08-19 at 13:03 +0200, Christian König wrote: > Am 06.08.24 um 10:29 schrieb Thomas Hellström: > > Hi, Christian. > > > > On Thu, 2024-07-11 at 14:01 +0200, Christian König wrote: > > > Am 10.07.24 um 20:19 schrieb Matthew Brost: > > > > On Wed, Jul 10, 2024 at 02:42:58

[PATCH -next 6/8] drm/panel: khadas-ts050: Make ts050_panel_data and ts050v2_panel_data static

2024-08-19 Thread Jinjie Ruan
The sparse tool complains as follows: drivers/gpu/drm/panel/panel-khadas-ts050.c:620:32: warning: symbol 'ts050_panel_data' was not declared. Should it be static? drivers/gpu/drm/panel/panel-khadas-ts050.c:625:32: warning: symbol 'ts050v2_panel_data' was not declared. Should it be

Re: [PATCH v4 1/4] drm/panthor: introduce job cycle and timestamp accounting

2024-08-19 Thread Boris Brezillon
Hi Adrian, Sorry for chiming so late, but I think I have a few concerns with this patch. Nothing major, but I'd prefer to have it addressed now rather than in a follow-up series. On Tue, 16 Jul 2024 21:11:40 +0100 Adrián Larumbe wrote: > Enable calculations of job submission times in clock cycl

[PATCH v2 1/2] dt-bindings: mtd: nuvoton, ma35d1-nand: add new bindings

2024-08-19 Thread Hui-Ping Chen
Add dt-bindings for the Nuvoton MA35 SoC NAND Controller. Signed-off-by: Hui-Ping Chen --- .../bindings/mtd/nuvoton,ma35d1-nand.yaml | 93 +++ 1 file changed, 93 insertions(+) create mode 100644 Documentation/devicetree/bindings/mtd/nuvoton,ma35d1-nand.yaml diff --git a/Do

[PATCH v2 2/2] mtd: rawnand: nuvoton: add new driver for the Nuvoton MA35 SoC

2024-08-19 Thread Hui-Ping Chen
Nuvoton MA35 SoCs NAND Flash Interface Controller supports 2KB, 4KB and 8KB page size, and up to 8-bit, 12-bit, and 24-bit hardware ECC calculation circuit to protect data communication. Signed-off-by: Hui-Ping Chen --- drivers/mtd/nand/raw/Kconfig |8 + drivers/mtd/nand/raw/Ma

[PATCH v2 0/2] Add support for nuvoton ma35 nand controller

2024-08-19 Thread Hui-Ping Chen
This patch series adds the mtd nand driver for the nuvoton ma35 ARMv8 SoC. It includes DT binding documentation and the ma35 mtd nand driver. v2: - Update nuvoton,ma35d1-nand.yaml - Adjust the order and remove any unnecessary items. - Add 'nand-ecc-step-size' and 'nand-ecc-strength' to t

RE: [PATCH v3 1/4] dt-bindings: display: renesas,rzg2l-du: Document RZ/G2UL DU bindings

2024-08-19 Thread Biju Das
Hi Laurent and Rob, Thanks for the feedback > -Original Message- > From: Laurent Pinchart > Sent: Tuesday, August 13, 2024 8:39 PM > Subject: Re: [PATCH v3 1/4] dt-bindings: display: renesas,rzg2l-du: Document > RZ/G2UL DU bindings > > Hi Rob, > > On Tue, Aug 13, 2024 at 10:32:20AM -0

RE: [PATCH v3 2/4] drm: renesas: rz-du: Add RZ/G2UL DU Support

2024-08-19 Thread Biju Das
Hi Laurent, Thanks for the feedback. > -Original Message- > From: Laurent Pinchart > Sent: Tuesday, August 13, 2024 8:49 PM > Subject: Re: [PATCH v3 2/4] drm: renesas: rz-du: Add RZ/G2UL DU Support > > Hi Biju, > > Thank you for the patch. > > On Mon, Aug 05, 2024 at 04:52:36PM +0100,

Re: Build regressions/improvements in v6.11-rc4

2024-08-19 Thread Lucas De Marchi
On Mon, Aug 19, 2024 at 09:30:32AM GMT, Geert Uytterhoeven wrote: On Mon, 19 Aug 2024, Geert Uytterhoeven wrote: JFYI, when comparing v6.11-rc4[1] to v6.11-rc3[3], the summaries are: - build errors: +6/-4 + /kisskb/src/arch/sparc/vdso/vdso32/../vclock_gettime.c: error: no previous prototype

Re: [PATCH] drm/bridge: lontium-lt8912b: Validate mode in drm_bridge_funcs::mode_valid()

2024-08-19 Thread Robert Foss
On Tue, 13 Aug 2024 17:16:37 +0800, Liu Ying wrote: > If the bridge is attached with the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag set, > this driver won't initialize a connector and hence display mode won't be > validated in drm_connector_helper_funcs::mode_valid(). So, move the mode > validation from

Re: [PATCH] drm/bridge: dw-hdmi: Simplify clock handling

2024-08-19 Thread Robert Foss
On Tue, 13 Aug 2024 00:23:21 +0300, Cristian Ciocaltea wrote: > Make use of devm_clk_get_enabled() to replace devm_clk_get() and > clk_prepare_enable() for isfr and iahb clocks, and drop the now > unnecessary calls to clk_disable_unprepare(). > > Similarly, use devm_clk_get_optional_enabled() help

Re: [PATCH] drm: bridge: anx7625: Use of_property_read_variable_u8_array()

2024-08-19 Thread Robert Foss
On Wed, 31 Jul 2024 14:13:59 -0600, Rob Herring (Arm) wrote: > There's no need to get the length of an DT array property before > parsing the array. of_property_read_variable_u8_array() takes a minimum > and maximum length and returns the actual length (or error code). > > This is part of a larger

Re: [PATCH] video/aperture: match the pci device when calling sysfb_disable()

2024-08-19 Thread Javier Martinez Canillas
Thomas Zimmermann writes: Hello Alex and Thomas, > Hi > > Am 16.08.24 um 22:57 schrieb Alex Deucher: >> On Mon, Aug 12, 2024 at 8:10 AM Thomas Zimmermann >> wrote: >>> Hi >>> >>> Am 10.08.24 um 13:44 schrieb kernel test robot: Hi Alex, kernel test robot noticed the following bui

Re: [PATCH 0/3] ACPI/video / platform/x86: Add backlight=native quirk for Dell OptiPlex 7760 AIO

2024-08-19 Thread Rafael J. Wysocki
On Wed, Aug 14, 2024 at 10:10 PM Andy Shevchenko wrote: > > On Wed, Aug 14, 2024 at 09:01:56PM +0200, Hans de Goede wrote: > > Hi Rafael, > > > > 6.10 has a new backlight driver for UART attached backlight controller > > boards found in some Dell All in One models. > > > > Now the first AIO has tu

Re: [PATCH 02/11] drm/sti/sti_hdmi: convert to struct drm_edid

2024-08-19 Thread Daniel Vetter
On Thu, Aug 15, 2024 at 03:55:30PM +0300, Jani Nikula wrote: > On Mon, 24 Jun 2024, Daniel Vetter wrote: > > On Tue, May 14, 2024 at 03:55:08PM +0300, Jani Nikula wrote: > >> Prefer the struct drm_edid based functions for reading the EDID and > >> updating the connector. > >> > >> The functional

Re: [PATCH v3 2/2] drm/vmwgfx: Fix prime with external buffers

2024-08-19 Thread Martin Krastev
On Thu, Aug 15, 2024 at 6:34 PM Zack Rusin wrote: > > Make sure that for external buffers mapping goes through the dma_buf > interface instead of trying to access pages directly. > > External buffers might not provide direct access to readable/writable > pages so to make sure the bo's created from

Re: [PATCH v3 1/2] drm/vmwgfx: Prevent unmapping active read buffers

2024-08-19 Thread Martin Krastev
On Thu, Aug 15, 2024 at 6:34 PM Zack Rusin wrote: > > The kms paths keep a persistent map active to read and compare the cursor > buffer. These maps can race with each other in simple scenario where: > a) buffer "a" mapped for update > b) buffer "a" mapped for compare > c) do the compare > d) unma

Re: [PATCH 4/7] drm/ttm: move LRU walk defines into new internal header

2024-08-19 Thread Daniel Vetter
On Mon, Aug 19, 2024 at 01:38:56PM +0200, Thomas Hellström wrote: > Hi, Christian, > > On Mon, 2024-08-19 at 13:03 +0200, Christian König wrote: > > Am 06.08.24 um 10:29 schrieb Thomas Hellström: > > > Hi, Christian. > > > > > > On Thu, 2024-07-11 at 14:01 +0200, Christian König wrote: > > > > Am

Re: [PATCH 0/2] Allow partial memory mapping for cpu memory

2024-08-19 Thread Daniel Vetter
On Wed, Aug 14, 2024 at 02:08:49AM +, Matthew Brost wrote: > On Tue, Aug 13, 2024 at 07:08:02PM +, Matthew Brost wrote: > > On Tue, Aug 13, 2024 at 04:09:55PM +0200, Daniel Vetter wrote: > > > On Tue, Aug 13, 2024 at 02:54:31AM +, Matthew Brost wrote: > > > > On Mon, Aug 12, 2024 at 04:

Re: [PATCH 1/2] Documentation/gpu: Document the situation with unqualified drm-memory-

2024-08-19 Thread Daniel Vetter
On Thu, Aug 15, 2024 at 09:37:31AM +0100, Tvrtko Ursulin wrote: > > On 13/08/2024 19:47, Rob Clark wrote: > > On Tue, Aug 13, 2024 at 6:57 AM Tvrtko Ursulin wrote: > > > > > > From: Tvrtko Ursulin > > > > > > Currently it is not well defined what is drm-memory- compared to other > > > categori

Re: [PATCH RFC 01/15] drm/vkms: Remove useles devres group

2024-08-19 Thread Daniel Vetter
On Wed, Aug 14, 2024 at 04:36:23PM +0200, Louis Chauvet wrote: > As the driver now uses drm managed allocation, the devres group is not > needed anymore, so remove it. drmm isn't devres, and you still have a devres managed resource here, namely devm_drm_dev_alloc. The reason I suggest in the revie

Re: [PATCH] drm/vmwgfx: Limit display layout ioctl array size to VMWGFX_NUM_DISPLAY_UNITS

2024-08-19 Thread Martin Krastev
On Thu, Aug 8, 2024 at 11:06 PM Ian Forbes wrote: > > Currently the array size is only limited by the largest kmalloc size which > is incorrect. This change will also return a more specific error message > than ENOMEM to userspace. > > Signed-off-by: Ian Forbes > --- > drivers/gpu/drm/vmwgfx/vmw

Re: [PATCH v3] drm/panthor: Add DEV_QUERY_TIMESTAMP_INFO dev query

2024-08-19 Thread Mihail Atanassov
Hi Mary, On 19/08/2024 12:25, Mary Guillemard wrote: Expose timestamp information supported by the GPU with a new device query. Mali uses an external timer as GPU system time. On ARM, this is wired to the generic arch timer so we wire cntfrq_el0 as device frequency. This new uAPI will be used

Re: [PATCH 00/12] drm/amd: Switch over to struct drm_edid

2024-08-19 Thread Melissa Wen
On 08/18, Thomas Weißschuh wrote: > The AMD DRM drivers use 'struct edid', raw pointers and even custom > structs to represent EDID data. > Uniformly switch to the safe and recommended "struct drm_edid". > > Some uses of "struct edid" are left because some ad-hoc parsing is still > being done insi

Re: [PATCH] drm/vmwgfx: Handle possible ENOMEM in vmw_stdu_connector_atomic_check

2024-08-19 Thread Martin Krastev
LGTM. Reviewed-by: Martin Krastev Regards, Martin On Fri, Aug 9, 2024 at 9:38 PM Ian Forbes wrote: > > Handle unlikely ENOMEN condition and other errors in > vmw_stdu_connector_atomic_check. > > Signed-off-by: Ian Forbes > Reported-by: Dan Carpenter > Fixes: 75c3e8a26a35 ("drm/vmwgfx: Trigge

Re: [PATCH 0/3] Various prime/dumb buffer fixes

2024-08-19 Thread Martin Krastev
Still LGTM. Reviewed-by: Martin Krastev Regards, Martin On Fri, Aug 16, 2024 at 9:33 PM Zack Rusin wrote: > > This is the same series I've sent out earlier but with one extra patch, > that fixes the dumb buffer coherency on low mem systems. > > The second patch has also been updated to not use

Re: Build regressions/improvements in v6.11-rc4

2024-08-19 Thread Rodrigo Vivi
On Mon, Aug 19, 2024 at 08:22:13AM -0500, Lucas De Marchi wrote: > On Mon, Aug 19, 2024 at 09:30:32AM GMT, Geert Uytterhoeven wrote: > > On Mon, 19 Aug 2024, Geert Uytterhoeven wrote: > > > JFYI, when comparing v6.11-rc4[1] to v6.11-rc3[3], the summaries are: > > > - build errors: +6/-4 > > > > +

Re: [RESEND PATCH] drm/xe/oa: Use vma_pages() helper function in xe_oa_mmap()

2024-08-19 Thread Dixit, Ashutosh
On Mon, 19 Aug 2024 02:57:52 -0700, Thorsten Blum wrote: > > Use the vma_pages() helper function and remove the following > Coccinelle/coccicheck warning reported by vma_pages.cocci: > > WARNING: Consider using vma_pages helper on vma > > Reviewed-by: Ashutosh Dixit > Signed-off-by: Thorsten Blu

Re: [RFC] amdgpu: Add a context flag to disable implicit sync

2024-08-19 Thread Christian König
Am 07.08.24 um 22:33 schrieb Bas Nieuwenhuizen: On Wed, Aug 7, 2024 at 10:25 PM Faith Ekstrand wrote: On Wed, Aug 7, 2024 at 2:23 PM Joshua Ashton wrote: I was thinking about this more recently. I was initially considering "maybe this should be a per-BO import," but I

Re: [RFC] amdgpu: Add a context flag to disable implicit sync

2024-08-19 Thread Bas Nieuwenhuizen
On Mon, Aug 19, 2024 at 4:51 PM Christian König < ckoenig.leichtzumer...@gmail.com> wrote: > Am 07.08.24 um 22:33 schrieb Bas Nieuwenhuizen: > > On Wed, Aug 7, 2024 at 10:25 PM Faith Ekstrand > wrote: > >> On Wed, Aug 7, 2024 at 2:23 PM Joshua Ashton wrote: >> >>> I was thinking about this more

[PATCH 3/3] drm/vkms: Add documentation

2024-08-19 Thread José Expósito
Hi Louis, Thanks for this patch, adding some minor review comments: > Add documentation around vkms_output and its initialization. > > Signed-off-by: Louis Chauvet > --- > drivers/gpu/drm/vkms/vkms_drv.h| 81 > -- > drivers/gpu/drm/vkms/vkms_output.c |

Re: [PATCH] video/aperture: match the pci device when calling sysfb_disable()

2024-08-19 Thread Thomas Zimmermann
Am 19.08.24 um 10:04 schrieb Thomas Zimmermann: Hi Am 16.08.24 um 22:57 schrieb Alex Deucher: On Mon, Aug 12, 2024 at 8:10 AM Thomas Zimmermann wrote: Hi Am 10.08.24 um 13:44 schrieb kernel test robot: Hi Alex, kernel test robot noticed the following build errors: [auto build test ERRO

Re: [PATCH v2 0/2] Allow partial memory mapping for cpu memory

2024-08-19 Thread Andi Shyti
Hi Matt, On Wed, Aug 14, 2024 at 04:07:02PM +, Matthew Brost wrote: > On Wed, Aug 14, 2024 at 03:48:32PM +0200, Andi Shyti wrote: > > I am resending this patch series, not to disregard the previous > > discussions, but to ensure it gets tested with the IGTs that > > Krzysztof has provided. > >

Re: [PATCH v4] drm/i915/hwmon: expose fan speed

2024-08-19 Thread Andi Shyti
Hi Raag, I'm sorry, I missed this mail. On Mon, Aug 19, 2024 at 09:50:13AM +0300, Raag Jadav wrote: > On Wed, Aug 14, 2024 at 02:07:44PM +0530, Nilawar, Badal wrote: > > On 09-08-2024 15:46, Andi Shyti wrote: > > > > > +static int > > > > > +hwm_fan_read(struct hwm_drvdata *ddat, u32 attr, long *

[PATCH v2] drm/mediatek: Fix missing configuration flags in mtk_crtc_ddp_config()

2024-08-19 Thread Jason-JH.Lin via B4 Relay
_gamma_size(&mtk_crtc->base, gamma_lut_size); drm_crtc_enable_color_mgmt(&mtk_crtc->base, 0, has_ctm, gamma_lut_size); mutex_init(&mtk_crtc->hw_lock); + spin_lock_init(&mtk_crtc->config_lock); #if IS_REACHABLE(CONFIG_MTK_CMDQ) i = priv->mbox_index++; --- base-commit: 469f1bad3c1c6e268059f78c0eec7e9552b3894c change-id: 20240819-drm-fixup-0819-f51e2d37fcd7 Best regards, -- Jason-JH.Lin

Re: [PATCH 4/7] drm/ttm: move LRU walk defines into new internal header

2024-08-19 Thread Christian König
Am 19.08.24 um 16:14 schrieb Daniel Vetter: On Mon, Aug 19, 2024 at 01:38:56PM +0200, Thomas Hellström wrote: Hi, Christian, On Mon, 2024-08-19 at 13:03 +0200, Christian König wrote: Am 06.08.24 um 10:29 schrieb Thomas Hellström: Hi, Christian. On Thu, 2024-07-11 at 14:01 +0200, Christian Kö

Re: [PATCH 0/2] Allow partial memory mapping for cpu memory

2024-08-19 Thread Andi Shyti
Hi Sima, On Mon, Aug 19, 2024 at 04:17:01PM +0200, Daniel Vetter wrote: > On Wed, Aug 14, 2024 at 02:08:49AM +, Matthew Brost wrote: > > On Tue, Aug 13, 2024 at 07:08:02PM +, Matthew Brost wrote: > > > On Tue, Aug 13, 2024 at 04:09:55PM +0200, Daniel Vetter wrote: > > > > On Tue, Aug 13, 2

Re: [PATCH -next 6/8] drm/panel: khadas-ts050: Make ts050_panel_data and ts050v2_panel_data static

2024-08-19 Thread neil . armstrong
On 19/08/2024 14:00, Jinjie Ruan wrote: The sparse tool complains as follows: drivers/gpu/drm/panel/panel-khadas-ts050.c:620:32: warning: symbol 'ts050_panel_data' was not declared. Should it be static? drivers/gpu/drm/panel/panel-khadas-ts050.c:625:32: warning: symbol 'ts050v2_

Re: [PATCH] drm/panel: mantix-mlaf057we51: transition to mipi_dsi wrapped functions

2024-08-19 Thread neil . armstrong
Hi, On 18/08/2024 09:23, Tejas Vipin wrote: Changes the mantix-mlaf057we51 panel to use multi style functions for improved error handling. Signed-off-by: Tejas Vipin --- .../gpu/drm/panel/panel-mantix-mlaf057we51.c | 79 +++ 1 file changed, 27 insertions(+), 52 deletions(-)

Re: [PATCH 31/86] drm/panel/ili9341: Run DRM default client setup

2024-08-19 Thread Neil Armstrong
On 16/08/2024 14:22, Thomas Zimmermann wrote: Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. Signed-off-by: Thomas Zimmermann Cc: Neil Armstrong Cc: Jessica Zhang ---

Re: [PATCH 2/2] drm/panel: simple: Add ON Tat Industrial Company KD50G21-40NT-A1 panel

2024-08-19 Thread neil . armstrong
On 16/08/2024 10:50, Liu Ying wrote: ON Tat Industrial Company KD50G21-40NT-A1 is a 5" WVGA LCD panel with DPI interface. The LCD module specification can be found at: https://cdn-shop.adafruit.com/datasheets/KD50G21-40NT-A1.pdf Signed-off-by: Liu Ying --- drivers/gpu/drm/panel/panel-simple.

Re: [PATCH 31/86] drm/panel/ili9341: Run DRM default client setup

2024-08-19 Thread Neil Armstrong
On 16/08/2024 14:22, Thomas Zimmermann wrote: Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. Signed-off-by: Thomas Zimmermann Cc: Neil Armstrong Cc: Jessica Zhang ---

Re: [PATCH] drm/panel: ili9341: Add comments for ILI9341 register

2024-08-19 Thread neil . armstrong
On 12/08/2024 19:10, Abhishek Tamboli wrote: TODO : Add missing comments for ILI9341 register definition. Please rephrase the commit message, and explain why in a proper english sentence. Neil Signed-off-by: Abhishek Tamboli --- drivers/gpu/drm/panel/panel-ilitek-ili9341.c | 14 +++-

Re: [PATCH v3 1/2] drm/panel: jd9365da: Move "exit sleep mode" and "set display on" cmds

2024-08-19 Thread neil . armstrong
On 12/08/2024 17:45, Doug Anderson wrote: Jessica, On Thu, Aug 8, 2024 at 3:56 PM Jessica Zhang wrote: On 8/7/2024 3:04 AM, Zhaoxiong Lv wrote: Move the "exit sleep mode" and "set display on" command from enable() to init() function. As mentioned in the patch: https://lore.kernel.org/all/

Re: [PATCH v2 2/2] drm/panel: simple: add Innolux G070ACE-LH3 LVDS display support

2024-08-19 Thread Neil Armstrong
On 29/07/2024 09:02, Steffen Trumtrar wrote: The G070ACE-LH3 is a 7" TFT Color LCD module with WLED backlight. https://www.data-modul.com/sites/default/files/products/G070ACE-LH3-specification-12058417.pdf Signed-off-by: Steffen Trumtrar --- drivers/gpu/drm/panel/panel-simple.c | 35

Re: [PATCH] drm/bridge: ti-sn65dsi83: use dev_err_probe when failing to get panel bridge

2024-08-19 Thread Andi Shyti
Hi Luca, On Mon, Aug 19, 2024 at 01:38:40PM +0200, Luca Ceresoli wrote: > On Tue, 13 Aug 2024 16:32:50 +0200 > > On Tue, Aug 13, 2024 at 10:16:43AM +0200, Luca Ceresoli wrote: > > > On Thu, 8 Aug 2024 11:35:23 +0100 > > > Andi Shyti wrote: > > > > On Thu, Aug 08, 2024 at 12:26:14PM +0200, Luca

Re: [PATCH] drm/virtio: Use XRGB8888 also for big endian systems

2024-08-19 Thread Javier Martinez Canillas
Jocelyn Falempe writes: Helo Jocelyn, AFAICT your patch is doing two things: > Mesa doesn't support BGRX, that means most wayland compositors > doesn't work on big endian guests. > 1) Dropping the BGR{A,X} support. > Also the colors are inverted when testing a s390x VM on a s390x host

Re: [RFC] amdgpu: Add a context flag to disable implicit sync

2024-08-19 Thread Faith Ekstrand
On Mon, Aug 19, 2024 at 10:00 AM Bas Nieuwenhuizen wrote: > > > On Mon, Aug 19, 2024 at 4:51 PM Christian König < > ckoenig.leichtzumer...@gmail.com> wrote: > >> Am 07.08.24 um 22:33 schrieb Bas Nieuwenhuizen: >> >> On Wed, Aug 7, 2024 at 10:25 PM Faith Ekstrand >> wrote: >> >>> On Wed, Aug 7, 2

Re: [PATCH 1/9] drm/meson: hdmi: move encoder settings out of phy driver

2024-08-19 Thread Neil Armstrong
On 30/07/2024 14:50, Jerome Brunet wrote: This relocates register pokes of the HDMI VPU encoder out of the HDMI phy driver. As far as HDMI is concerned, the sequence in which the setup is done remains mostly the same. This was tested with modetest, cycling through the following resolutions: #

Re: [PATCH 2/9] drm/meson: vclk: drop hdmi system clock setup

2024-08-19 Thread Neil Armstrong
On 30/07/2024 14:50, Jerome Brunet wrote: Poking the HHI syscon is a way to setup clocks behind CCF's back. Also, 2 drm code paths, the encoder and the hdmi-phy, are racing to do the same setup of the HDMI system clock. This clock is used is used by the HDMI phy and should not be set by the enco

Re: [PATCH v6 2/2] drm/xe/lnl: Offload system clear page activity to GPU

2024-08-19 Thread Nirmoy Das
On 8/19/2024 1:05 PM, Matthew Auld wrote: On 16/08/2024 14:51, Nirmoy Das wrote: On LNL because of flat CCS, driver creates migrates job to clear CCS meta data. Extend that to also clear system pages using GPU. Inform TTM to allocate pages without __GFP_ZERO to avoid double page clearing by cl

Re: [PATCH 3/9] drm/meson: dw-hdmi: use generic clock helpers

2024-08-19 Thread Neil Armstrong
On 30/07/2024 14:50, Jerome Brunet wrote: The Amlogic HDMI phy driver is not doing anything with the clocks besides enabling on probe. CCF provides generic helpers to do that. Use the generic clock helpers rather than using a custom one to get and enable clocks. Signed-off-by: Jerome Brunet --

Re: [PATCH v2 0/2] drm/panel: simple: add Innolux G070ACE-LH3

2024-08-19 Thread Neil Armstrong
Hi, On Mon, 29 Jul 2024 09:02:37 +0200, Steffen Trumtrar wrote: > This series adds support for the Innolux G070ACE-LH3 to the panel-simple > driver and adds the according compatible to the devicetree bindings. > > Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-

  1   2   3   >